Re: [PR] HOTFIX: Fix compilation error in TransactionManagerTest [kafka]

2024-02-22 Thread via GitHub
cadonna commented on PR #15405: URL: https://github.com/apache/kafka/pull/15405#issuecomment-1958910910 @jolshan No worries! I think this is a shortcoming of our GitHub setup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] HOTFIX: Fix compilation error in TransactionManagerTest [kafka]

2024-02-21 Thread via GitHub
jolshan commented on PR #15405: URL: https://github.com/apache/kafka/pull/15405#issuecomment-1957306611 Sorry that was my bad. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] HOTFIX: Fix compilation error in TransactionManagerTest [kafka]

2024-02-21 Thread via GitHub
cadonna merged PR #15405: URL: https://github.com/apache/kafka/pull/15405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] HOTFIX: Fix compilation error in TransactionManagerTest [kafka]

2024-02-21 Thread via GitHub
showuon commented on PR #15405: URL: https://github.com/apache/kafka/pull/15405#issuecomment-1956277808 I think as long as the compilation passed, we can merge this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] HOTFIX: Fix compilation error in TransactionManagerTest [kafka]

2024-02-21 Thread via GitHub
cadonna commented on PR #15405: URL: https://github.com/apache/kafka/pull/15405#issuecomment-1956274512 ping @artemlivshits @jolshan for awareness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] HOTFIX: Fix compilation error in TransactionManagerTest [kafka]

2024-02-21 Thread via GitHub
cadonna opened a new pull request, #15405: URL: https://github.com/apache/kafka/pull/15405 Variable `metadataMock` was removed by https://github.com/apache/kafka/pull/15323 after the CI build of https://github.com/apache/kafka/pull/15320 was run and before https://github.com/apache/kafka/p