Re: [PR] Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964652942 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java: ## @@ -216,11 +217,13 @@ public interface UserTaskAssignmentListener

Re: [PR] Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964651322 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig { /** {@code upgrade

Re: [PR] Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
mjsax commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964651322 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig { /** {@code upgrade

Re: [PR] Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
ableegoldman commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964648789 ## tests/kafkatest/tests/streams/streams_cooperative_rebalance_upgrade_test.py: ## @@ -43,7 +43,10 @@ class StreamsCooperativeRebalanceUpgradeTest(Test): seco

Re: [PR] Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
ableegoldman commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964649521 ## tests/kafkatest/tests/streams/streams_application_upgrade_test.py: ## @@ -23,19 +23,18 @@ from kafkatest.version import LATEST_2_2, LATEST_2_3, LATEST_2_4, LAT

Re: [PR] Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
ableegoldman commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964648165 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig { /** {@code

Re: [PR] Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
ableegoldman commented on code in PR #18988: URL: https://github.com/apache/kafka/pull/18988#discussion_r1964642690 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -794,13 +794,11 @@ public class StreamsConfig extends AbstractConfig { /** {@code

[PR] Drop EAGER rebalancing support in Kafka Streams [kafka]

2025-02-20 Thread via GitHub
ableegoldman opened a new pull request, #18988: URL: https://github.com/apache/kafka/pull/18988 In 3.1 we deprecated the eager rebalancing protocol and marked it for removal in a later release. We aim to officially drop support and remove the protocol from Streams in 4.0. Note that we are o