Re: [PR] Add integration test for IQv2 in KIP-1071 [kafka]

bbejeck merged PR #18856: URL: https://github.com/apache/kafka/pull/18856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] Add integration test for IQv2 in KIP-1071 [kafka]

lucasbru commented on code in PR #18856: URL: https://github.com/apache/kafka/pull/18856#discussion_r1958320133 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/IQv2EndpointToPartitionsIntegrationTest.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to

Re: [PR] Add integration test for IQv2 in KIP-1071 [kafka]

bbejeck commented on PR #18856: URL: https://github.com/apache/kafka/pull/18856#issuecomment-2657877973 @lucasbru I've updated for you comments and it's ready for another review. I'll need to dig in some to see why we only get repartition topics for the standby tasks. My guess that while

Re: [PR] Add integration test for IQv2 in KIP-1071 [kafka]

bbejeck commented on code in PR #18856: URL: https://github.com/apache/kafka/pull/18856#discussion_r1955299542 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/IQv2EndpointToPartitionsIntegrationTest.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to t

Re: [PR] Add integration test for IQv2 in KIP-1071 [kafka]

bbejeck commented on code in PR #18856: URL: https://github.com/apache/kafka/pull/18856#discussion_r1955299542 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/IQv2EndpointToPartitionsIntegrationTest.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to t

Re: [PR] Add integration test for IQv2 in KIP-1071 [kafka]

bbejeck commented on code in PR #18856: URL: https://github.com/apache/kafka/pull/18856#discussion_r1953540705 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/IQv2EndpointToPartitionsIntegrationTest.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to t

Re: [PR] Add integration test for IQv2 in KIP-1071 [kafka]

bbejeck commented on code in PR #18856: URL: https://github.com/apache/kafka/pull/18856#discussion_r1953533199 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/EndpointToPartitionsManager.java: ## @@ -47,11 +46,11 @@ public static StreamsGrou

Re: [PR] Add integration test for IQv2 in KIP-1071 [kafka]

lucasbru commented on code in PR #18856: URL: https://github.com/apache/kafka/pull/18856#discussion_r1952314367 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/IQv2EndpointToPartitionsIntegrationTest.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to

Re: [PR] Add integration test for IQv2 in KIP-1071 [kafka]

lucasbru commented on code in PR #18856: URL: https://github.com/apache/kafka/pull/18856#discussion_r1952293106 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/EndpointToPartitionsManager.java: ## @@ -47,11 +46,11 @@ public static StreamsGro

Re: [PR] Add integration test for IQv2 in KIP-1071 [kafka]

bbejeck commented on code in PR #18856: URL: https://github.com/apache/kafka/pull/18856#discussion_r1949922287 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2382,17 +2382,19 @@ private CoordinatorResult stream priv

Re: [PR] Add integration test for IQv2 in KIP-1071 [kafka]

bbejeck commented on code in PR #18856: URL: https://github.com/apache/kafka/pull/18856#discussion_r1951585523 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/IQv2EndpointToPartitionsIntegrationTest.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to t

Re: [PR] Add integration test for IQv2 in KIP-1071 [kafka]

bbejeck commented on code in PR #18856: URL: https://github.com/apache/kafka/pull/18856#discussion_r1949922615 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java: ## @@ -454,6 +454,15 @@ public Map members() { return Collecti

[PR] Add integration test for IQv2 in KIP-1071 [kafka]

bbejeck opened a new pull request, #18856: URL: https://github.com/apache/kafka/pull/18856 Adds a parameterized integration test ensuring that the same host->partitions information is sent in both `classic` and `streams` group mode. This is a stacked PR only review the last commit.