mimaison merged PR #13201:
URL: https://github.com/apache/kafka/pull/13201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mimaison commented on PR #13201:
URL: https://github.com/apache/kafka/pull/13201#issuecomment-1764452479
With the latest updates it's not failing anymore on my laptop. I'll let the
Apache CI run before merging.
--
This is an automated message from the Apache Git Service.
To respond to the
OmniaGM commented on PR #13201:
URL: https://github.com/apache/kafka/pull/13201#issuecomment-1764360877
> @OmniaGM thanks for the updates. I'm getting a test failure in
TopicCommandIntegrationTest:
>
> ```
> Gradle Test Run :tools:test > Gradle Test Executor 31 >
TopicCommandInteg
mimaison commented on PR #13201:
URL: https://github.com/apache/kafka/pull/13201#issuecomment-1764319701
@OmniaGM thanks for the updates. I'm getting a test failure in
TopicCommandIntegrationTest:
```
Gradle Test Run :tools:test > Gradle Test Executor 31 >
TopicCommandIntegrationTest
OmniaGM commented on code in PR #13201:
URL: https://github.com/apache/kafka/pull/13201#discussion_r1360418599
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -2395,6 +2395,8 @@ object TestUtils extends Logging {
)
def unexpectedThreads: Set[String] =
mimaison commented on code in PR #13201:
URL: https://github.com/apache/kafka/pull/13201#discussion_r1360412557
##
tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java:
##
@@ -123,4 +125,21 @@ public static void validateBootstrapServer(String
hostPort) throws IllegalArgum
OmniaGM commented on code in PR #13201:
URL: https://github.com/apache/kafka/pull/13201#discussion_r1358474706
##
tools/src/test/java/org/apache/kafka/tools/TopicCommandTest.java:
##
@@ -0,0 +1,283 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
OmniaGM commented on code in PR #13201:
URL: https://github.com/apache/kafka/pull/13201#discussion_r1358474161
##
tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java:
##
@@ -0,0 +1,1050 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
OmniaGM commented on code in PR #13201:
URL: https://github.com/apache/kafka/pull/13201#discussion_r1358473808
##
tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java:
##
@@ -0,0 +1,1050 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
OmniaGM commented on code in PR #13201:
URL: https://github.com/apache/kafka/pull/13201#discussion_r1358473310
##
tools/src/test/java/org/apache/kafka/tools/TopicCommandIntegrationTest.java:
##
@@ -0,0 +1,1050 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
OmniaGM commented on code in PR #13201:
URL: https://github.com/apache/kafka/pull/13201#discussion_r1358472785
##
checkstyle/import-control.xml:
##
@@ -286,6 +289,8 @@
+
+
Review Comment:
not any more I needed them at some point while converting fro
OmniaGM commented on code in PR #13201:
URL: https://github.com/apache/kafka/pull/13201#discussion_r1358468634
##
tools/src/main/java/org/apache/kafka/tools/TopicCommand.java:
##
@@ -0,0 +1,1007 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * co
OmniaGM commented on code in PR #13201:
URL: https://github.com/apache/kafka/pull/13201#discussion_r1358471763
##
tools/src/main/java/org/apache/kafka/tools/TopicCommand.java:
##
@@ -0,0 +1,1007 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * co
OmniaGM commented on PR #13201:
URL: https://github.com/apache/kafka/pull/13201#issuecomment-1755578715
@mimaison fixed the compilation issue. I spotted another one with Java21 and
fixed it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
mimaison commented on PR #13201:
URL: https://github.com/apache/kafka/pull/13201#issuecomment-1753360551
@OmniaGM Thanks for the update. I've not had time to take a look yet but
noticed there's a compilation failure:
```
> Task :tools:compileTestJava
/home/jenkins/jenkins-agent
OmniaGM commented on PR #13201:
URL: https://github.com/apache/kafka/pull/13201#issuecomment-1749188089
> @OmniaGM Thanks for the PR. Can you rebase on trunk to resolve the
conflicts?
Updated the pr waiting now for the pipeline to pass
--
This is an automated message from the Apach
mimaison commented on PR #13201:
URL: https://github.com/apache/kafka/pull/13201#issuecomment-1744639271
@OmniaGM Thanks for the PR. Can you rebase on trunk to resolve the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
17 matches
Mail list logo
