chia7712 merged PR #16049:
URL: https://github.com/apache/kafka/pull/16049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
sjhajharia commented on code in PR #16049:
URL: https://github.com/apache/kafka/pull/16049#discussion_r1624467049
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -311,7 +311,7 @@ public void
testPerformAssignmentShouldUpd
sjhajharia commented on code in PR #16049:
URL: https://github.com/apache/kafka/pull/16049#discussion_r162444
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -1336,13 +1335,13 @@ public ClientResponse mockOffsetCommit
sjhajharia commented on code in PR #16049:
URL: https://github.com/apache/kafka/pull/16049#discussion_r1624466257
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -371,6 +371,7 @@ public static boolean isEqualConstantTime(char[] first,
char[] second) {
chia7712 commented on code in PR #16049:
URL: https://github.com/apache/kafka/pull/16049#discussion_r1619270234
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -371,6 +371,7 @@ public static boolean isEqualConstantTime(char[] first,
char[] second) {
chia7712 commented on PR #16049:
URL: https://github.com/apache/kafka/pull/16049#issuecomment-2128711390
> I rebased the PR!
I guess other PRs will encounter same failed tests, so please rebase code
for others too, thanks!
--
This is an automated message from the Apache Git Service
sjhajharia commented on PR #16049:
URL: https://github.com/apache/kafka/pull/16049#issuecomment-2128709392
Thanks for pointing out @chia7712
I rebased the PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chia7712 commented on PR #16049:
URL: https://github.com/apache/kafka/pull/16049#issuecomment-2128703246
@sjhajharia Could you please rebase code to include #16044? It fixes a lot
of failed tests :)
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
sjhajharia opened a new pull request, #16049:
URL: https://github.com/apache/kafka/pull/16049
## What
Code Cleanup in Clients Module
## Changes
Some common changes include
- Replace the Arrays.asList() with Collections.singletonList() wherever
possible
- Cleaning up so
