sjhajharia commented on code in PR #19069:
URL: https://github.com/apache/kafka/pull/19069#discussion_r1992084076
##
metadata/src/test/java/org/apache/kafka/metadata/ControllerRegistrationTest.java:
##
@@ -46,18 +44,18 @@ static Map doubleMap(K k1, V v1, K k2, V v2) {
chia7712 commented on code in PR #19069:
URL: https://github.com/apache/kafka/pull/19069#discussion_r1992038764
##
metadata/src/test/java/org/apache/kafka/metadata/ControllerRegistrationTest.java:
##
@@ -46,18 +44,18 @@ static Map doubleMap(K k1, V v1, K k2, V v2) {
Ha
sjhajharia commented on PR #19069:
URL: https://github.com/apache/kafka/pull/19069#issuecomment-2708939212
Thanks @chia7712 for looking into the PR. I have addressed the comments.
PTAL when possible!
--
This is an automated message from the Apache Git Service.
To respond to the message, p
chia7712 commented on code in PR #19069:
URL: https://github.com/apache/kafka/pull/19069#discussion_r1986355627
##
metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java:
##
@@ -437,14 +436,14 @@ private void checkSection(
/**
* The se
mumrah commented on PR #19069:
URL: https://github.com/apache/kafka/pull/19069#issuecomment-2708307265
@sjhajharia can you merge trunk into this branch? There are some recent CI
changes that are needed. I will try to review this over the weekend.
--
This is an automated message from the A
sjhajharia commented on PR #19069:
URL: https://github.com/apache/kafka/pull/19069#issuecomment-2708215564
cc: @m1a2st / @mumrah for a final review
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
sjhajharia commented on PR #19069:
URL: https://github.com/apache/kafka/pull/19069#issuecomment-2702786625
Sure @mumrah
Will keep that in mind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mumrah commented on PR #19069:
URL: https://github.com/apache/kafka/pull/19069#issuecomment-2701677430
@sjhajharia just a quick note -- if you force push your branch after someone
has reviewed your PR, it basically destroys the history of the review and
inline conversations. It's best to me
sjhajharia commented on PR #19069:
URL: https://github.com/apache/kafka/pull/19069#issuecomment-2696583647
Thanks @m1a2st
Was just noting that down. In the future when we get rid of these null tests
in Map and List for ClientQuotaControlManagerTest, we would be able to get rid
of them.
sjhajharia commented on PR #19069:
URL: https://github.com/apache/kafka/pull/19069#issuecomment-2696315162
Thanks @m1a2st , I have added more changes as suggested. Could you PTAL
again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
sjhajharia commented on PR #19069:
URL: https://github.com/apache/kafka/pull/19069#issuecomment-2696232218
Thanks @mumrah
The build turns out green 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
sjhajharia commented on PR #19069:
URL: https://github.com/apache/kafka/pull/19069#issuecomment-2694200768
Thanks @m1a2st for catching those classes. Updated the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
sjhajharia commented on PR #19069:
URL: https://github.com/apache/kafka/pull/19069#issuecomment-2692598551
Thanks @m1a2st for the suggestion. I have updated the PR as per the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
sjhajharia opened a new pull request, #19069:
URL: https://github.com/apache/kafka/pull/19069
Given that now we support Java 17 on our brokers, this PR replace the use of
the following in metadata module:
Collections.singletonList() and Collections.emptyList() with List.of()
Collec
14 matches
Mail list logo
