chia7712 commented on code in PR #20614:
URL: https://github.com/apache/kafka/pull/20614#discussion_r2391990917
##
clients/src/main/java/org/apache/kafka/common/protocol/types/Type.java:
##
@@ -1116,7 +1116,8 @@ private static String toHtml() {
UINT16, UNSIGNED_INT3
chia7712 commented on PR #20571:
URL: https://github.com/apache/kafka/pull/20571#issuecomment-3352261445
@Forest0923 Could you please open a PR for 4.0? It has some conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
chia7712 merged PR #20571:
URL: https://github.com/apache/kafka/pull/20571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 merged PR #20555:
URL: https://github.com/apache/kafka/pull/20555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
AndrewJSchofield commented on PR #20536:
URL: https://github.com/apache/kafka/pull/20536#issuecomment-3351935398
> > > > This is a nice improvement but I wonder whether it could be even
better with a bit of tweak. Here's an example of the current output.
> > > > The part that could do wit
omkreddy commented on PR #20571:
URL: https://github.com/apache/kafka/pull/20571#issuecomment-3351917014
I’ll assume we’ll be backporting the fixes to the 4.1 and 4.0 branches as
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
omkreddy commented on PR #20607:
URL: https://github.com/apache/kafka/pull/20607#issuecomment-3351687798
> @rreddy-22 Could you please open PR for 4.2 as well? I try to cherry-pick
it but there are some conflicts :(
4.1
--
This is an automated message from the Apache Git Service.
T
see-quick commented on PR #20546:
URL: https://github.com/apache/kafka/pull/20546#issuecomment-3350387148
> Can you open a Jira for this PR? I consider this worthy to appear in the
release notes.
Sure, I have created [1].
[1] - https://issues.apache.org/jira/browse/KAFKA-19745
chickenchickenlove commented on PR #20159:
URL: https://github.com/apache/kafka/pull/20159#issuecomment-3350181138
@chia7712 Hi!
I made a new commit based on your comments!
When you have time, please take another look. 🙇♂️
--
This is an automated message from the Apache Git Servi
junrao commented on code in PR #20285:
URL: https://github.com/apache/kafka/pull/20285#discussion_r2389360602
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java:
##
@@ -1062,6 +1062,146 @@ public void testSplitAndReenqueue() throws
E
majialoong opened a new pull request, #20612:
URL: https://github.com/apache/kafka/pull/20612
[In this PR](https://github.com/apache/kafka/pull/20334), we added some
validation checks for the connect config, such as ensuring that `plugin.path`
cannot be empty.
However, currently, Co
mjsax merged PR #19304:
URL: https://github.com/apache/kafka/pull/19304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on PR #19304:
URL: https://github.com/apache/kafka/pull/19304#issuecomment-3347832484
Thanks for the PR! Merged to `trunk`. Leaving the Jira ticket open, as it's
only a partial solution for it.
--
This is an automated message from the Apache Git Service.
To respond to the
mjsax commented on code in PR #20605:
URL: https://github.com/apache/kafka/pull/20605#discussion_r2388356518
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionSendProcessorSupplier.java:
##
@@ -128,47 +128,105 @@ public void process(f
mjsax commented on code in PR #20605:
URL: https://github.com/apache/kafka/pull/20605#discussion_r2388349078
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionReceiveProcessorSupplier.java:
##
@@ -82,7 +82,8 @@ public void init(final
mimaison commented on PR #19079:
URL: https://github.com/apache/kafka/pull/19079#issuecomment-3347440152
@FrankYang0529 Thanks for looking into this. Can you rebase on trunk? I
agree with @ahuang98, a few comments could help.
--
This is an automated message from the Apache Git Service.
To
harmadasg commented on PR #20128:
URL: https://github.com/apache/kafka/pull/20128#issuecomment-3347356886
Rebased on latest 3.9 to retrigger CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kevin-wu24 commented on code in PR #20604:
URL: https://github.com/apache/kafka/pull/20604#discussion_r2388228394
##
docs/ops.html:
##
@@ -4072,45 +4072,27 @@
- $ bin/kafka-features.sh --bootstrap-controller localhost:9093 describe
-
-
- If the kraft.version field is level 0
josefk31 opened a new pull request, #20610:
URL: https://github.com/apache/kafka/pull/20610
Allow users to perform an unclean leadership election by designated a
specific replica as the leader as part of the ElectLeadersRequest.
--
This is an automated message from the Apache Git Ser
mimaison commented on PR #19762:
URL: https://github.com/apache/kafka/pull/19762#issuecomment-3347277573
@jsancio @junrao I keep rebasing this each week. Quick reminder, can you
take another look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the messag
lianetm commented on code in PR #20565:
URL: https://github.com/apache/kafka/pull/20565#discussion_r2380264135
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/metrics/ConsumerRebalanceMetricsManagerTest.java:
##
Review Comment:
now that we have multiple
pnagy-cldr closed pull request #20603: KAFKA-19739: Upgrade commons-validator
to 1.10.0
URL: https://github.com/apache/kafka/pull/20603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
mimaison commented on code in PR #19876:
URL: https://github.com/apache/kafka/pull/19876#discussion_r2387569440
##
server/src/main/java/org/apache/kafka/server/purgatory/DelayedRemoteFetch.java:
##
Review Comment:
It seems like these two classes could go into storage as wel
DL1231 commented on code in PR #19876:
URL: https://github.com/apache/kafka/pull/19876#discussion_r2387479407
##
server/src/main/java/org/apache/kafka/server/purgatory/DelayedRemoteFetch.java:
##
Review Comment:
Thanks for pointing this out! Initially, I intended to move
`
AndrewJSchofield commented on PR #20385:
URL: https://github.com/apache/kafka/pull/20385#issuecomment-3345489813
@mkansara23 The code changes were performed by @aheev. Maybe they have an
opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
github-actions[bot] commented on PR #19267:
URL: https://github.com/apache/kafka/pull/19267#issuecomment-3344741817
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
mjsax commented on code in PR #20605:
URL: https://github.com/apache/kafka/pull/20605#discussion_r2386497159
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java:
##
@@ -891,7 +891,10 @@ protected static T
mjsax commented on PR #20362:
URL: https://github.com/apache/kafka/pull/20362#issuecomment-3344295186
We are somewhat swamped recently. Sorry for the delay... Don't know when I
will get to it. But please keeping nagging us about it :)
--
This is an automated message from the Apache Git S
mjsax commented on PR #20254:
URL: https://github.com/apache/kafka/pull/20254#issuecomment-3344291319
> Did you actually observe that flush() returns early?
@junrao Yes (as described above:
https://github.com/apache/kafka/pull/20254#issuecomment-3134139853), I did set
a breakpoint so
mjsax commented on PR #18816:
URL: https://github.com/apache/kafka/pull/18816#issuecomment-3344280430
Replace via https://github.com/apache/kafka/pull/20353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
deepgolani4 commented on code in PR #20540:
URL: https://github.com/apache/kafka/pull/20540#discussion_r2386354501
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java:
##
@@ -141,20 +141,18 @@ public void setup(final T
majialoong commented on PR #20596:
URL: https://github.com/apache/kafka/pull/20596#issuecomment-3343927035
I re-examined the code logic. Although the `plugin.path` config is set to
non-empty, the plugin is actually initialized before the config is validated.
Therefore, even if the `plugin.p
chia7712 merged PR #20265:
URL: https://github.com/apache/kafka/pull/20265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
majialoong closed pull request #20596: KAFKA-19737: Fix
PluginUtils#pluginLocations warning log not being printed
URL: https://github.com/apache/kafka/pull/20596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
chia7712 commented on code in PR #20555:
URL: https://github.com/apache/kafka/pull/20555#discussion_r2386193584
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/ReconfigurableQuorumIntegrationTest.java:
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to th
chia7712 commented on code in PR #20567:
URL: https://github.com/apache/kafka/pull/20567#discussion_r2386192751
##
server/src/main/java/org/apache/kafka/server/config/AbstractKafkaConfig.java:
##
@@ -161,6 +169,76 @@ public static Map getMap(String propName,
String propValue) {
chia7712 commented on code in PR #20388:
URL: https://github.com/apache/kafka/pull/20388#discussion_r2386189192
##
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##
@@ -230,24 +231,32 @@ private static void printExtendedProgress(long bytesRead,
public
chia7712 commented on PR #20577:
URL: https://github.com/apache/kafka/pull/20577#issuecomment-3343833643
```
./gradlew cleanTest core:test --tests ConsumerBounceTest --tests
elegationTokenEndToEndAuthorizationWithOwnerTest --tests AclControlManagerTest
--tests QuorumControllerTest storag
AndrewJSchofield commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2386146884
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##
@@ -298,7 +299,8 @@ public class GroupCoordinatorConfig {
AndrewJSchofield merged PR #20388:
URL: https://github.com/apache/kafka/pull/20388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
DL1231 opened a new pull request, #20234:
URL: https://github.com/apache/kafka/pull/20234
Repartition topic records should be purged up to the currently committed
offset once `repartition.purge.interval.ms` duration has passed.
Reviewers: Matthias J. Sax
--
This is an automa
mjsax closed pull request #20234: KAFKA-19539: Kafka Streams should also purge
internal topics based on user commit requests
URL: https://github.com/apache/kafka/pull/20234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
AndrewJSchofield commented on PR #20536:
URL: https://github.com/apache/kafka/pull/20536#issuecomment-3343799218
> > This is a nice improvement but I wonder whether it could be even better
with a bit of tweak. Here's an example of the current output.
> > https://private-user-images.github
chia7712 merged PR #20432:
URL: https://github.com/apache/kafka/pull/20432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #20601:
URL: https://github.com/apache/kafka/pull/20601#issuecomment-3343697001
@pnagy-cldr please fix the license files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
github-actions[bot] commented on PR #20050:
URL: https://github.com/apache/kafka/pull/20050#issuecomment-3342243144
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
chia7712 commented on PR #20577:
URL: https://github.com/apache/kafka/pull/20577#issuecomment-3342997346
@rreddy-22 out of curiosity. Do you plan to backport it to 4.1 and 4.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
chia7712 commented on code in PR #20602:
URL: https://github.com/apache/kafka/pull/20602#discussion_r2385521933
##
gradle/dependencies.gradle:
##
@@ -60,9 +60,8 @@ versions += [
caffeine: "3.1.1",
bndlib: "7.0.0",
checkstyle: project.hasProperty('checkstyleVersion') ? c
chia7712 commented on code in PR #20532:
URL: https://github.com/apache/kafka/pull/20532#discussion_r2385490176
##
docs/ops.html:
##
@@ -4082,42 +4082,32 @@
- $ bin/kafka-features.sh --bootstrap-controller localhost:9093 describe
-
-
- If the kraft.version field is level 0 or
chia7712 merged PR #20492:
URL: https://github.com/apache/kafka/pull/20492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2385458576
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##
@@ -298,7 +299,8 @@ public class GroupCoordinatorConfig {
pu
github-actions[bot] closed pull request #19751: KAFKA-15370: Support
Participation in 2PC (KIP-939) (K/N)
URL: https://github.com/apache/kafka/pull/19751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on PR #20048:
URL: https://github.com/apache/kafka/pull/20048#issuecomment-3342243131
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #19751:
URL: https://github.com/apache/kafka/pull/19751#issuecomment-3342243110
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
AndrewJSchofield commented on PR #20536:
URL: https://github.com/apache/kafka/pull/20536#issuecomment-3342044685
This is a nice improvement but I wonder whether it could be even better with
a bit of tweak. Here's an example of the current output.
https://github.com/user-attachments/as
jack2012aa commented on PR #20536:
URL: https://github.com/apache/kafka/pull/20536#issuecomment-3342221120
> This is a nice improvement but I wonder whether it could be even better
with a bit of tweak. Here's an example of the current output.
>
> https://private-user-images.githubuser
DL1231 commented on code in PR #20388:
URL: https://github.com/apache/kafka/pull/20388#discussion_r2384437256
##
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##
@@ -230,24 +231,32 @@ private static void printExtendedProgress(long bytesRead,
public st
mjsax commented on code in PR #20293:
URL: https://github.com/apache/kafka/pull/20293#discussion_r2377363240
##
tools/src/test/java/org/apache/kafka/tools/streams/DeleteStreamsGroupOffsetTest.java:
##
@@ -132,6 +132,7 @@ public void testDeleteOffsetsNonExistingGroup() {
samarth-ksolves commented on code in PR #20353:
URL: https://github.com/apache/kafka/pull/20353#discussion_r2377955353
##
streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueBytesStoreTest.java:
##
@@ -112,28 +208,59 @@ public void after() {
mjsax commented on PR #19913:
URL: https://github.com/apache/kafka/pull/19913#issuecomment-3342102916
Blocked on some other PRs, that we split out (just commenting so the PR does
not get auto-closed).
--
This is an automated message from the Apache Git Service.
To respond to the message,
chia7712 commented on code in PR #16042:
URL: https://github.com/apache/kafka/pull/16042#discussion_r2377510526
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1259,12 +1260,18 @@ class ReplicaManager(val config: KafkaConfig,
.setIsFutureKey
Copilot commented on code in PR #20569:
URL: https://github.com/apache/kafka/pull/20569#discussion_r2375132004
##
core/src/main/scala/kafka/server/AutoTopicCreationManager.scala:
##
@@ -229,26 +272,13 @@ class DefaultAutoTopicCreationManager(
}
}
-val request =
mjsax commented on code in PR #20540:
URL: https://github.com/apache/kafka/pull/20540#discussion_r2384386485
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java:
##
@@ -121,6 +139,24 @@ public void setup(final TestInfo
mjsax commented on PR #20540:
URL: https://github.com/apache/kafka/pull/20540#issuecomment-3342112965
Build failed with checkstyle errors.
```
Run './gradlew :streams:integration-tests:spotlessApply' to fix these
violations.
```
--
This is an automated message from the Apache
mjsax commented on code in PR #20540:
URL: https://github.com/apache/kafka/pull/20540#discussion_r2384386540
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java:
##
@@ -121,6 +139,24 @@ public void setup(final TestInfo
AndrewJSchofield commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2384236392
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##
@@ -298,7 +299,8 @@ public class GroupCoordinatorConfig {
UladzislauBlok commented on code in PR #20600:
URL: https://github.com/apache/kafka/pull/20600#discussion_r2384097202
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1960,19 +1960,28 @@ private CoordinatorResult stream
mimaison commented on PR #19237:
URL: https://github.com/apache/kafka/pull/19237#issuecomment-3328274226
Done in https://github.com/apache/kafka/pull/20044, closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
github-actions[bot] commented on PR #19913:
URL: https://github.com/apache/kafka/pull/19913#issuecomment-3341115140
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
github-actions[bot] commented on PR #19693:
URL: https://github.com/apache/kafka/pull/19693#issuecomment-3341115117
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
github-actions[bot] commented on PR #20505:
URL: https://github.com/apache/kafka/pull/20505#issuecomment-3341101333
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #20234:
URL: https://github.com/apache/kafka/pull/20234#issuecomment-3341101439
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19244:
URL: https://github.com/apache/kafka/pull/19244#issuecomment-3341101673
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
lucasbru closed pull request #20457: KAFKA-19661: Streams groups sometimes
describe as NOT_READY when STABLE
URL: https://github.com/apache/kafka/pull/20457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lianetm commented on code in PR #20585:
URL: https://github.com/apache/kafka/pull/20585#discussion_r2383507510
##
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##
@@ -239,29 +239,6 @@ def test_broker_type_bounce(self, failure_mode,
broker_type, sleep_time_secs, n
lianetm commented on code in PR #20584:
URL: https://github.com/apache/kafka/pull/20584#discussion_r2383502632
##
tests/kafkatest/tests/streams/streams_broker_bounce_test.py:
##
@@ -225,30 +225,6 @@ def test_broker_type_bounce(self, failure_mode,
broker_type, sleep_time_secs, n
AndrewJSchofield commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2382970509
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##
@@ -298,7 +299,8 @@ public class GroupCoordinatorConfig {
lucasbru commented on PR #20457:
URL: https://github.com/apache/kafka/pull/20457#issuecomment-3338793236
@mjsax and I discussed this off-line. We will attempt to solve this by
storing additional data in the consumer offset topic, not by adding groups
outside the replay path. I will close th
chia7712 commented on code in PR #20577:
URL: https://github.com/apache/kafka/pull/20577#discussion_r2383320439
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1067,8 +1067,19 @@ class UnifiedLog(@volatile var logStartOffset: Long,
// transaction is complete
kevin-wu24 commented on PR #20595:
URL: https://github.com/apache/kafka/pull/20595#issuecomment-3339114645
I messed up the cherry-pick. I need to keep the integration test changes,
otherwise the existing tests break. I'm going to pick this again in a new PR
@frankvicky.
--
This is an aut
chia7712 commented on PR #20580:
URL: https://github.com/apache/kafka/pull/20580#issuecomment-3339194696
@dajac I hope my previous comments did not disrupt the flow. Since 4.0.1 is
currently in the RC vote, I assume the backport should remain pending unless
the RM wants to include it. Other
majialoong commented on PR #20543:
URL: https://github.com/apache/kafka/pull/20543#issuecomment-3340188944
To test compatibility, I wrote the following test code, which includes code
demonstrating the usage of Gauge and Measurable.
```
import org.apache.kafka.common.MetricName;
kevin-wu24 commented on PR #20595:
URL: https://github.com/apache/kafka/pull/20595#issuecomment-3340062372
here's the new PR link: @frankvicky
https://github.com/apache/kafka/pull/20604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
kevin-wu24 opened a new pull request, #20604:
URL: https://github.com/apache/kafka/pull/20604
```
commit ec37eb538b7d7e113b80e09276606395b007127e (HEAD ->
KAFKA-19719-cherry-pick-41, origin/KAFKA-19719-cherry-pick-41)
Author: Kevin Wu
Date: Thu Sep 25 11:56:16 2025 -0500
rreddy-22 commented on code in PR #20577:
URL: https://github.com/apache/kafka/pull/20577#discussion_r2383218875
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1067,8 +1067,19 @@ class UnifiedLog(@volatile var logStartOffset: Long,
// transaction is complet
pnagy-cldr opened a new pull request, #20601:
URL: https://github.com/apache/kafka/pull/20601
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
Copilot commented on code in PR #20600:
URL: https://github.com/apache/kafka/pull/20600#discussion_r2383114279
##
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala:
##
@@ -255,10 +256,10 @@ abstract class IntegrationTestHarness extends
KafkaServerTestHarnes
elmoctarebnou commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2382852427
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##
@@ -69,6 +69,7 @@ public class GroupCoordinatorConfig {
elmoctarebnou commented on PR #20466:
URL: https://github.com/apache/kafka/pull/20466#issuecomment-3339487663
Related PR:
[apache/kafka-site#717](https://github.com/apache/kafka-site/pull/717)
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
jsancio commented on PR #19668:
URL: https://github.com/apache/kafka/pull/19668#issuecomment-3339345861
Abandon this change in favor of a KIP which allows AddVoter to return a
response before the record has been committed.
--
This is an automated message from the Apache Git Service.
To re
jsancio closed pull request #19668: KAFKA-19255: KRaft request manager should
support one in-flight request per request type
URL: https://github.com/apache/kafka/pull/19668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
lucasbru commented on code in PR #20592:
URL: https://github.com/apache/kafka/pull/20592#discussion_r2382259714
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java:
##
@@ -711,9 +726,8 @@ public void
shouldNotViolateEosIfOneTa
kevin-wu24 closed pull request #20595: KAFKA-19719: --no-initial-controllers
should not assume kraft.version=1
URL: https://github.com/apache/kafka/pull/20595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2382653851
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##
@@ -298,7 +299,8 @@ public class GroupCoordinatorConfig {
pu
pnagy-cldr opened a new pull request, #20603:
URL: https://github.com/apache/kafka/pull/20603
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
pnagy-cldr opened a new pull request, #20602:
URL: https://github.com/apache/kafka/pull/20602
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
lucasbru commented on code in PR #20600:
URL: https://github.com/apache/kafka/pull/20600#discussion_r2382504677
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4223,7 +4232,7 @@ private CoordinatorResult
streamsGroupFence
lucasbru commented on code in PR #20600:
URL: https://github.com/apache/kafka/pull/20600#discussion_r2382499866
##
group-coordinator/src/main/resources/common/message/StreamsGroupMetadataValue.json:
##
@@ -24,6 +24,8 @@
{ "name": "Epoch", "versions": "0+", "type": "int32",
lucasbru commented on code in PR #20600:
URL: https://github.com/apache/kafka/pull/20600#discussion_r2382494668
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java:
##
@@ -837,7 +853,7 @@ private void maybeUpdateGroupState() {
lucasbru commented on code in PR #20600:
URL: https://github.com/apache/kafka/pull/20600#discussion_r2382492257
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java:
##
@@ -148,9 +148,9 @@ public static class DeadlineAndEpoch {
pri
1 - 100 of 18889 matches
Mail list logo
