smjn commented on PR #19739:
URL: https://github.com/apache/kafka/pull/19739#issuecomment-2900126586
> @smjn I apologize that I've already merged #19611, and that pull request
takes a different approach than this one. Please feel free to update this PR if
you have a better way to address th
[
https://issues.apache.org/jira/browse/KAFKA-19291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal resolved KAFKA-19291.
---
Fix Version/s: 4.1.0
Resolution: Fixed
> Increase the timeout of remote storage share
dengziming commented on PR #19762:
URL: https://github.com/apache/kafka/pull/19762#issuecomment-2900099738
> Where has this been discussed?
In KIP-595 we wrote:
> We are also trying to pave the way for normal partition replication
through Raft as well as eventually supporting metad
apoorvmittal10 merged PR #19757:
URL: https://github.com/apache/kafka/pull/19757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.
apoorvmittal10 commented on code in PR #19759:
URL: https://github.com/apache/kafka/pull/19759#discussion_r2101752608
##
server-common/src/main/java/org/apache/kafka/server/purgatory/DelayedOperation.java:
##
@@ -68,24 +67,36 @@ public DelayedOperation(long delayMs, Lock lock) {
apoorvmittal10 commented on code in PR #19759:
URL: https://github.com/apache/kafka/pull/19759#discussion_r2101746039
##
server-common/src/main/java/org/apache/kafka/server/purgatory/DelayedOperation.java:
##
@@ -68,24 +67,36 @@ public DelayedOperation(long delayMs, Lock lock) {
apoorvmittal10 commented on code in PR #19759:
URL: https://github.com/apache/kafka/pull/19759#discussion_r2101744337
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -191,26 +191,23 @@ public void onExpiration() {
* Complete the share fetch operation
AndrewJSchofield commented on PR #19743:
URL: https://github.com/apache/kafka/pull/19743#issuecomment-2899942570
Test failed of
`kafka.api.PlaintextAdminIntegrationTest.testDeleteConsumerGroupOffsets`. Does
not appear related.
--
This is an automated message from the Apache Git Service.
AndrewJSchofield commented on code in PR #18929:
URL: https://github.com/apache/kafka/pull/18929#discussion_r2101636242
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -667,6 +670,56 @@ public void run() {
));
chia7712 commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2101615974
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -589,8 +589,9 @@ object KafkaMetadataLog extends Logging {
): KafkaMetadataLog = {
val props =
chia7712 commented on code in PR #19687:
URL: https://github.com/apache/kafka/pull/19687#discussion_r2101606077
##
server/src/main/java/org/apache/kafka/server/logger/LoggingController.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
chia7712 commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2101594593
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -589,8 +589,9 @@ object KafkaMetadataLog extends Logging {
): KafkaMetadataLog = {
val props =
[
https://issues.apache.org/jira/browse/KAFKA-18220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953308#comment-17953308
]
Lan Ding commented on KAFKA-18220:
--
Hi [~schofielaj], could you clarify what exactly ne
github-actions[bot] closed pull request #18596: KAFKA-16368: Constraints update
for segment.index.bytes
URL: https://github.com/apache/kafka/pull/18596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
github-actions[bot] commented on PR #18596:
URL: https://github.com/apache/kafka/pull/18596#issuecomment-2899812287
This PR has been closed since it has not had any activity in 120 days. If
you feel like this
was a mistake, or you would like to continue working on it, please feel free
to
[ https://issues.apache.org/jira/browse/KAFKA-18220 ]
Lan Ding deleted comment on KAFKA-18220:
--
was (Author: JIRAUSER30):
Hi [~schofielaj], what exactly needs to be done for this issue?
> Refactor AsyncConsumerMetrics so they are appropriate f
[
https://issues.apache.org/jira/browse/KAFKA-18220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953306#comment-17953306
]
Lan Ding commented on KAFKA-18220:
--
Hi [~schofielaj], what exactly needs to be done for
github-actions[bot] commented on PR #19029:
URL: https://github.com/apache/kafka/pull/19029#issuecomment-2899787739
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #18715:
URL: https://github.com/apache/kafka/pull/18715#issuecomment-2899787789
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19236:
URL: https://github.com/apache/kafka/pull/19236#issuecomment-2899787646
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19720:
URL: https://github.com/apache/kafka/pull/19720#issuecomment-2899787485
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #19231:
URL: https://github.com/apache/kafka/pull/19231#issuecomment-2899787668
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
FrankYang0529 commented on code in PR #19687:
URL: https://github.com/apache/kafka/pull/19687#discussion_r2101523213
##
server/src/main/java/org/apache/kafka/server/logger/LoggingController.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
JimmyWang6 commented on PR #18929:
URL: https://github.com/apache/kafka/pull/18929#issuecomment-2899735458
@AndrewJSchofield @chia7712 ，
Fixed the failed test. PTAL :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chenshi5012 closed pull request #19777: MINOR Fix: fix line separator for
different systems
URL: https://github.com/apache/kafka/pull/19777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
junrao commented on code in PR #19759:
URL: https://github.com/apache/kafka/pull/19759#discussion_r2101385805
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -191,26 +191,23 @@ public void onExpiration() {
* Complete the share fetch operation by fetc
apoorvmittal10 commented on PR #19759:
URL: https://github.com/apache/kafka/pull/19759#issuecomment-2899443174
> @apoorvmittal10 : Thanks for the explanation. It seems that we found a
case that an acquired sharePartition lock was released more than once. I am
still not sure how it happened.
ahuang98 commented on code in PR #19742:
URL: https://github.com/apache/kafka/pull/19742#discussion_r2101157535
##
core/src/main/scala/kafka/server/ClientQuotaManager.scala:
##
@@ -451,6 +452,43 @@ class ClientQuotaManager(private val config:
ClientQuotaManagerConfig,
}
ahuang98 commented on code in PR #19742:
URL: https://github.com/apache/kafka/pull/19742#discussion_r2101129753
##
core/src/main/scala/kafka/server/ClientQuotaManager.scala:
##
@@ -428,18 +426,21 @@ class ClientQuotaManager(private val config:
ClientQuotaManagerConfig,
try
junrao commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2101057057
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -589,8 +589,9 @@ object KafkaMetadataLog extends Logging {
): KafkaMetadataLog = {
val props = ne
ahuang98 commented on code in PR #19742:
URL: https://github.com/apache/kafka/pull/19742#discussion_r210062
##
core/src/main/scala/kafka/server/ClientQuotaManager.scala:
##
@@ -155,6 +155,7 @@ class ClientQuotaManager(private val config:
ClientQuotaManagerConfig,
case
jsancio opened a new pull request, #19784:
URL: https://github.com/apache/kafka/pull/19784
At the retry limit binaryExponentialElectionBackoffMs it becomes
statistically likely that the exponential backoff returned
electionBackoffMaxMs. This is an issue as multiple replicas can get stuck
s
gaurav-narula commented on PR #19783:
URL: https://github.com/apache/kafka/pull/19783#issuecomment-2899085622
Running into https://github.com/spotbugs/spotbugs/issues/3320 with 4.9.3. I
think it's probably best to hold this off for now
--
This is an automated message from the Apache Git S
rreddy-22 commented on code in PR #19751:
URL: https://github.com/apache/kafka/pull/19751#discussion_r2101070031
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala:
##
@@ -250,7 +300,7 @@ private[transaction] class TransactionMetadata(val
transaction
gaurav-narula closed pull request #19783: MINOR: Update spotbugs to v4.9.0 to
support Java 24
URL: https://github.com/apache/kafka/pull/19783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
rreddy-22 commented on code in PR #19751:
URL: https://github.com/apache/kafka/pull/19751#discussion_r2101028588
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala:
##
@@ -174,6 +190,29 @@ private[transaction] class TransactionMetadata(val
transactio
rreddy-22 commented on code in PR #19751:
URL: https://github.com/apache/kafka/pull/19751#discussion_r2101028588
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala:
##
@@ -174,6 +190,29 @@ private[transaction] class TransactionMetadata(val
transactio
rreddy-22 commented on code in PR #19751:
URL: https://github.com/apache/kafka/pull/19751#discussion_r2100995696
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala:
##
@@ -70,6 +72,20 @@ private[transaction] class TransactionMetadata(val
transactiona
chia7712 commented on code in PR #19687:
URL: https://github.com/apache/kafka/pull/19687#discussion_r2100995473
##
core/src/main/scala/kafka/server/ConfigHelper.scala:
##
@@ -130,7 +131,7 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig, configRepo
chia7712 commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2100943381
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -589,8 +589,9 @@ object KafkaMetadataLog extends Logging {
): KafkaMetadataLog = {
val props =
junrao commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2100899250
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -589,8 +589,9 @@ object KafkaMetadataLog extends Logging {
): KafkaMetadataLog = {
val props = ne
chia7712 commented on code in PR #18929:
URL: https://github.com/apache/kafka/pull/18929#discussion_r2100883358
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3620,7 +3620,49 @@ class KafkaApis(val requestChannel: RequestChannel,
def handleAlterShareGroupOffset
junrao commented on PR #19759:
URL: https://github.com/apache/kafka/pull/19759#issuecomment-2898796227
@apoorvmittal10 : Thanks for the explanation. It seems that we found a case
that an acquired sharePartition lock was released more than once. I am still
not sure how it happened. forceComp
chia7712 commented on code in PR #19759:
URL: https://github.com/apache/kafka/pull/19759#discussion_r2100858959
##
server-common/src/main/java/org/apache/kafka/server/purgatory/DelayedOperation.java:
##
@@ -68,24 +67,36 @@ public DelayedOperation(long delayMs, Lock lock) {
gaurav-narula commented on PR #19783:
URL: https://github.com/apache/kafka/pull/19783#issuecomment-2898787730
Looks like there's a
[regression](https://github.com/spotbugs/spotbugs/issues/3267) in 4.9.0
unfortunately. Please hold of reviewing until I bump it to 4.9.3 instead.
--
This is
gaurav-narula opened a new pull request, #19783:
URL: https://github.com/apache/kafka/pull/19783
Spotbugs 4.9.0 brings in ASM v9.7.1 [[0]] which supports Java 24 [[1]].
[0]:
https://github.com/spotbugs/spotbugs/commit/2d48463113f9073369eb01757bc069d107757a9c
[1]:
https://gitlab.ow
chia7712 commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2100843498
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -589,8 +589,9 @@ object KafkaMetadataLog extends Logging {
): KafkaMetadataLog = {
val props =
chia7712 commented on PR #19371:
URL: https://github.com/apache/kafka/pull/19371#issuecomment-2898754119
@m1a2st please fix the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
gaurav-narula opened a new pull request, #19782:
URL: https://github.com/apache/kafka/pull/19782
Refer
https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html#scala-compatibility-table
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
junrao commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2100793274
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -446,6 +447,14 @@ public static List configNames() {
return CONFIG.names()
AndrewJSchofield commented on code in PR #19778:
URL: https://github.com/apache/kafka/pull/19778#discussion_r2100757284
##
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##
@@ -372,6 +459,110 @@ public void testNewContext() {
assertEquals(0, cache
FrankYang0529 commented on PR #19743:
URL: https://github.com/apache/kafka/pull/19743#issuecomment-2898578489
> Looks like a failed test:
>
> FAILED ❌ KafkaApisTest > testListConfigResourcesV0()
Sorry for that. The v0 doesn't support resource types field. If the version
is 0, w
apoorvmittal10 commented on PR #19759:
URL: https://github.com/apache/kafka/pull/19759#issuecomment-2898579823
> > Now the thread in tryComplete cannot invoke onComplete as completed is
marked true in DelayedOperation, hence acquired partitions will be released.
>
> Hmm, is this true?
mimaison commented on PR #19762:
URL: https://github.com/apache/kafka/pull/19762#issuecomment-2898574096
> we are trying to keep it dependency-free to be used as a raft-sdk anywhere
Where has this been discussed?
The way Kafka implements Raft is via a topic so our implementation of
[
https://issues.apache.org/jira/browse/KAFKA-19233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953199#comment-17953199
]
Lianet Magrans commented on KAFKA-19233:
Hey Travis, could you double check if y
junrao commented on PR #19759:
URL: https://github.com/apache/kafka/pull/19759#issuecomment-2898553890
> Now the thread in tryComplete cannot invoke onComplete as completed is
marked true in DelayedOperation, hence acquired partitions will be released.
Hmm, is this true? tryComplete
AndrewJSchofield commented on code in PR #18929:
URL: https://github.com/apache/kafka/pull/18929#discussion_r2100710818
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3620,7 +3620,49 @@ class KafkaApis(val requestChannel: RequestChannel,
def handleAlterShareGro
AndrewJSchofield commented on PR #18929:
URL: https://github.com/apache/kafka/pull/18929#issuecomment-2898540864
Test failure:
FAILED ❌ GroupCoordinatorServiceTest >
testPersisterInitializeForAlterShareGroupOffsetsResponseSuccess()
--
This is an automated message from the Apache Gi
AndrewJSchofield commented on PR #19743:
URL: https://github.com/apache/kafka/pull/19743#issuecomment-2898523151
Looks like a failed test:
FAILED ❌ KafkaApisTest > testListConfigResourcesV0()
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
sjhajharia commented on PR #19775:
URL: https://github.com/apache/kafka/pull/19775#issuecomment-2898518442
Thanks @m1a2st for the review,
I have addressed the suggestions.
Requesting a re-review!
--
This is an automated message from the Apache Git Service.
To respond to the message,
AndrewJSchofield commented on code in PR #19743:
URL: https://github.com/apache/kafka/pull/19743#discussion_r2100683768
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -3868,6 +3868,92 @@ class PlaintextAdminIntegrationTest extends
BaseAd
josefk31 commented on PR #19664:
URL: https://github.com/apache/kafka/pull/19664#issuecomment-2898498747
> > We need a boolean to indicate that there is more data that we were
unable to send due to length restrictions
>
> I wonder if it is good enough to indicate the limit is reached
srdo commented on PR #19514:
URL: https://github.com/apache/kafka/pull/19514#issuecomment-2898410433
@chia7712 Sure, rebased. But this won't be mergeable until the next Spotbugs
release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
m1a2st commented on code in PR #19687:
URL: https://github.com/apache/kafka/pull/19687#discussion_r2100497716
##
server/src/main/java/org/apache/kafka/server/logger/LoggingController.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
adixitconfluent commented on code in PR #19757:
URL: https://github.com/apache/kafka/pull/19757#discussion_r2100482477
##
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##
@@ -904,4 +948,30 @@ private boolean forceCompleteRequest() {
}
return com
smjn opened a new pull request, #19781:
URL: https://github.com/apache/kafka/pull/19781
1. Currently, the code allows for retrying any initializing topics in
subsequent heartbeats. This can result in duplicate calls to persister if
multiple share consumers join the same group concurrently.
bh-tt commented on PR #19386:
URL: https://github.com/apache/kafka/pull/19386#issuecomment-2898172902
I've some statistics from a medium busy kafka broker running on 4.0 (about 2
cpu's used continuously): method profiling from a JFR gave me approximately 3%
of cpu usage spent in java.util.s
TaiJuWu commented on code in PR #19765:
URL: https://github.com/apache/kafka/pull/19765#discussion_r2100431418
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -1311,39 +1295,38 @@ class ReplicaManagerTest {
val tidp0 = new TopicIdPartition(topicId
apoorvmittal10 commented on code in PR #19757:
URL: https://github.com/apache/kafka/pull/19757#discussion_r2100372692
##
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##
@@ -130,6 +130,10 @@ public class SharePartitionManager implements
AutoCloseable {
fvaleri commented on PR #19780:
URL: https://github.com/apache/kafka/pull/19780#issuecomment-2898049319
cc @showuon
I was also wondering if we still need to keep `gradleAll` given the
deprecation note, and why are we using `gradle-8.14-all.zip` instead of
`gradle-8.14-bin.zip`?
fvaleri opened a new pull request, #19780:
URL: https://github.com/apache/kafka/pull/19780
Today, we have to change multiple files when upgrading Gradle:
- gradle/dependencies.gradle
- gradle/wrapper/gradle-wrapper.properties
- gradlew
By using `$gradle.gradleVersion` and
apoorvmittal10 commented on code in PR #19759:
URL: https://github.com/apache/kafka/pull/19759#discussion_r2100282893
##
server-common/src/main/java/org/apache/kafka/server/purgatory/DelayedOperation.java:
##
@@ -68,24 +67,36 @@ public DelayedOperation(long delayMs, Lock lock) {
bbejeck commented on PR #18951:
URL: https://github.com/apache/kafka/pull/18951#issuecomment-2897893435
Thanks for the contribution @lorcanj !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-4650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bill Bejeck updated KAFKA-4650:
---
Fix Version/s: 4.1.0
> Improve test coverage org.apache.kafka.streams.kstream.internals
> ---
bbejeck commented on PR #18951:
URL: https://github.com/apache/kafka/pull/18951#issuecomment-2897882620
merged #18951 into trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
bbejeck merged PR #18951:
URL: https://github.com/apache/kafka/pull/18951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
chia7712 commented on code in PR #19779:
URL: https://github.com/apache/kafka/pull/19779#discussion_r2100159806
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java:
##
@@ -443,7 +443,7 @@ public void transitionToFatal() {
Rancho-7 commented on code in PR #19779:
URL: https://github.com/apache/kafka/pull/19779#discussion_r2100170330
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractMembershipManager.java:
##
@@ -443,7 +443,7 @@ public void transitionToFatal() {
m1a2st commented on code in PR #19775:
URL: https://github.com/apache/kafka/pull/19775#discussion_r2100149965
##
test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/junit/ClusterTestExtensions.java:
##
@@ -268,7 +268,7 @@ private List
processClusterTestIn
Rancho-7 opened a new pull request, #19779:
URL: https://github.com/apache/kafka/pull/19779
jira: https://issues.apache.org/jira/browse/KAFKA-19300
As title.
I verified the behavior by rewriting the `GroupAuthorizerIntegrationTest` in
Java in this PR: https://github.com/apache/
FrankYang0529 commented on code in PR #19743:
URL: https://github.com/apache/kafka/pull/19743#discussion_r2100067823
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -3868,6 +3868,92 @@ class PlaintextAdminIntegrationTest extends
BaseAdmin
FrankYang0529 commented on code in PR #19743:
URL: https://github.com/apache/kafka/pull/19743#discussion_r2100067823
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -3868,6 +3868,92 @@ class PlaintextAdminIntegrationTest extends
BaseAdmin
FrankYang0529 commented on code in PR #19761:
URL: https://github.com/apache/kafka/pull/19761#discussion_r2100070543
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4909,6 +4930,8 @@ public void replay(
consume
FrankYang0529 commented on code in PR #19743:
URL: https://github.com/apache/kafka/pull/19743#discussion_r2100066414
##
clients/src/main/java/org/apache/kafka/common/requests/ListConfigResourcesRequest.java:
##
@@ -36,6 +38,15 @@ public Builder(ListConfigResourcesRequestData dat
chia7712 commented on PR #19093:
URL: https://github.com/apache/kafka/pull/19093#issuecomment-2897575808
@frankvicky could you please fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chia7712 merged PR #19749:
URL: https://github.com/apache/kafka/pull/19749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[ https://issues.apache.org/jira/browse/KAFKA-13351 ]
zhangzhisheng deleted comment on KAFKA-13351:
---
was (Author: zhangzs):
哈哈哈
> Add possibility to write kafka headers in Kafka Console Producer
> -
[
https://issues.apache.org/jira/browse/KAFKA-13351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953107#comment-17953107
]
zhangzhisheng commented on KAFKA-13351:
---
哈哈哈
> Add possibility to write kafka hea
[
https://issues.apache.org/jira/browse/KAFKA-13351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953108#comment-17953108
]
zhangzhisheng commented on KAFKA-13351:
---
good
> Add possibility to write kafka he
chirag-wadhwa5 opened a new pull request, #19778:
URL: https://github.com/apache/kafka/pull/19778
This PR includes more unit tests in the file SharePartitionManagerTest to
improve the coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
apoorvmittal10 commented on PR #19759:
URL: https://github.com/apache/kafka/pull/19759#issuecomment-2897258835
> > This was a tricky bug to find, so nice catch.
>
> @apoorvmittal10 : My understanding is that this PR is not fixing a bug.
Without the PR, we still guarantee that onComple
apoorvmittal10 commented on PR #19759:
URL: https://github.com/apache/kafka/pull/19759#issuecomment-2897267180
> @apoorvmittal10 : Thanks for the PR. The code looks reasonable to me.
Could you run TestPurgatoryPerformance to see if there is any perf degradation?
I ran some tests and p
TaiJuWu commented on code in PR #19761:
URL: https://github.com/apache/kafka/pull/19761#discussion_r2099763827
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -4909,6 +4930,8 @@ public void replay(
consumerGroup
chia7712 merged PR #19380:
URL: https://github.com/apache/kafka/pull/19380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
AndrewJSchofield commented on code in PR #19743:
URL: https://github.com/apache/kafka/pull/19743#discussion_r2099600892
##
clients/src/main/java/org/apache/kafka/clients/admin/Admin.java:
##
@@ -1775,12 +1775,36 @@ default FenceProducersResult
fenceProducers(Collection transact
LoganZhuZzz commented on code in PR #19728:
URL: https://github.com/apache/kafka/pull/19728#discussion_r2099577017
##
clients/src/main/java/org/apache/kafka/clients/admin/ListConsumerGroupOffsetsResult.java:
##
@@ -60,9 +58,6 @@ public KafkaFuture>
partitionsToOffsetAnd
*
apoorvmittal10 commented on PR #18929:
URL: https://github.com/apache/kafka/pull/18929#issuecomment-2896724104
@JimmyWang6 There is a test failure, can you please fix:
```
FAILED ❌ GroupCoordinatorServiceTest >
testPersisterInitializeForAlterShareGroupOffsetsResponseSuccess()
--
showuon merged PR #19772:
URL: https://github.com/apache/kafka/pull/19772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
Chirag Wadhwa created KAFKA-19321:
-
Summary: Add share_consumer_performance.py and related system tests
Key: KAFKA-19321
URL: https://issues.apache.org/jira/browse/KAFKA-19321
Project: Kafka
smjn commented on code in PR #19774:
URL: https://github.com/apache/kafka/pull/19774#discussion_r2099538853
##
tests/kafkatest/tests/core/share_group_command_test.py:
##
@@ -0,0 +1,128 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor licens
1 - 100 of 111 matches
Mail list logo
