Re: [PR] KAFKA-19042: [9/N] Move GroupAuthorizerIntegrationTest to clients-integration-tests module [kafka]

2025-05-18 Thread via GitHub
Rancho-7 commented on code in PR #19685: URL: https://github.com/apache/kafka/pull/19685#discussion_r2094844425 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/security/GroupAuthorizerIntegrationTest.java: ## @@ -0,0 +1,422 @@ +/* + * Licensed to the

Re: [PR] KAFKA-18903: update-cache.sh use curl + jq to get sha contains gradle cache instead of gh cli [kafka]

2025-05-18 Thread via GitHub
mingyen066 commented on code in PR #19753: URL: https://github.com/apache/kafka/pull/19753#discussion_r2094814279 ## committer-tools/README.md: ## @@ -103,3 +103,14 @@ Found tests that were started, but not finished: 2024-09-10T20:31:26.6830206Z Gradle Test Run :streams:test

Re: [PR] KAFKA-17747: [3/N] Get rid of TopicMetadata in SubscribedTopicDescriberImpl [kafka]

2025-05-18 Thread via GitHub
FrankYang0529 commented on code in PR #19611: URL: https://github.com/apache/kafka/pull/19611#discussion_r2094785891 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/SubscribedTopicDescriberImpl.java: ## @@ -79,49 +80,65 @@ public int numPartitions(Uu

Re: [PR] jprnt02 [kafka]

2025-05-18 Thread via GitHub
github-actions[bot] commented on PR #19672: URL: https://github.com/apache/kafka/pull/19672#issuecomment-2889506652 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Created] (KAFKA-19309) Add transaction client template code in kafka examples

2025-05-18 Thread Kaushik Raina (Jira)
Kaushik Raina created KAFKA-19309: - Summary: Add transaction client template code in kafka examples Key: KAFKA-19309 URL: https://issues.apache.org/jira/browse/KAFKA-19309 Project: Kafka Issu

Re: [PR] KAFKA-18903: update-cache.sh use curl + jq to get sha contains gradle cache instead of gh cli [kafka]

2025-05-18 Thread via GitHub
m1a2st commented on code in PR #19753: URL: https://github.com/apache/kafka/pull/19753#discussion_r2094762591 ## committer-tools/README.md: ## @@ -103,3 +103,14 @@ Found tests that were started, but not finished: 2024-09-10T20:31:26.6830206Z Gradle Test Run :streams:test > Gr

Re: [PR] KAFKA-19042: [9/N] Move GroupAuthorizerIntegrationTest to clients-integration-tests module [kafka]

2025-05-18 Thread via GitHub
m1a2st commented on code in PR #19685: URL: https://github.com/apache/kafka/pull/19685#discussion_r2094735839 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/security/GroupAuthorizerIntegrationTest.java: ## @@ -0,0 +1,422 @@ +/* + * Licensed to the Ap

Re: [PR] KAFKA-19260: Move LoggingController to server module [kafka]

2025-05-18 Thread via GitHub
frankvicky commented on code in PR #19687: URL: https://github.com/apache/kafka/pull/19687#discussion_r2094750118 ## server/src/main/java/org/apache/kafka/server/logger/LoggingController.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[jira] [Updated] (KAFKA-19308) Improve OAuth unit testing based on code coverage analysis

2025-05-18 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19308: -- Component/s: unit tests (was: documentation) (was: tools) >

Re: [PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-05-18 Thread via GitHub
kirktrue commented on PR #19754: URL: https://github.com/apache/kafka/pull/19754#issuecomment-2889177302 cc @lianetm @omkreddy @zacharydhamilton -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-05-18 Thread via GitHub
kirktrue opened a new pull request, #19754: URL: https://github.com/apache/kafka/pull/19754 Adding support for the `urn:ietf:params:oauth:grant-type:jwt-bearer` grant type (AKA `jwt-bearer`). Includes further refactoring of the existing OAuth layer and addition of generic JWT assertion laye

[jira] [Updated] (KAFKA-19308) Improve OAuth unit testing based on code coverage analysis

2025-05-18 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19308: -- Description: This task is to increase the unit testing of the OAuth layer for improved code coverage.

[jira] [Updated] (KAFKA-19307) Improve OAuthCompatibilityTool ergonomics

2025-05-18 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19307: -- Description: This task is to improve/enhance the usability of the {{OAuthCompatibilityTool}} based on

[jira] [Created] (KAFKA-19308) Improve OAuth unit testing based on code coverage analysis

2025-05-18 Thread Kirk True (Jira)
Kirk True created KAFKA-19308: - Summary: Improve OAuth unit testing based on code coverage analysis Key: KAFKA-19308 URL: https://issues.apache.org/jira/browse/KAFKA-19308 Project: Kafka Issue Ty

[jira] [Updated] (KAFKA-19307) Improve OAuthCompatibilityTool ergonomics

2025-05-18 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19307: -- Component/s: tools > Improve OAuthCompatibilityTool ergonomics > -

[jira] [Created] (KAFKA-19307) Improve OAuthCompatibilityTool ergonomics

2025-05-18 Thread Kirk True (Jira)
Kirk True created KAFKA-19307: - Summary: Improve OAuthCompatibilityTool ergonomics Key: KAFKA-19307 URL: https://issues.apache.org/jira/browse/KAFKA-19307 Project: Kafka Issue Type: Improvement

Re: [PR] KAFKA-19042: [9/N] Move GroupAuthorizerIntegrationTest to clients-integration-tests module [kafka]

2025-05-18 Thread via GitHub
integral1 commented on code in PR #19685: URL: https://github.com/apache/kafka/pull/19685#discussion_r2094603630 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/security/GroupAuthorizerIntegrationTest.java: ## @@ -0,0 +1,464 @@ +/* + * Licensed to the

Re: [PR] KAFKA-18573: Add support for OAuth jwt-bearer grant type [kafka]

2025-05-18 Thread via GitHub
kirktrue closed pull request #19748: KAFKA-18573: Add support for OAuth jwt-bearer grant type URL: https://github.com/apache/kafka/pull/19748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Assigned] (KAFKA-19306) Migrate LogCompactionTester to tool module

2025-05-18 Thread Yunchi Pang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunchi Pang reassigned KAFKA-19306: --- Assignee: Yunchi Pang (was: Chia-Ping Tsai) > Migrate LogCompactionTester to tool module >

[jira] [Commented] (KAFKA-19306) Migrate LogCompactionTester to tool module

2025-05-18 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952467#comment-17952467 ] Chia-Ping Tsai commented on KAFKA-19306: noted that it is used by e2e `LogCompac

[jira] [Created] (KAFKA-19306) Migrate LogCompactionTester to tool module

2025-05-18 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19306: -- Summary: Migrate LogCompactionTester to tool module Key: KAFKA-19306 URL: https://issues.apache.org/jira/browse/KAFKA-19306 Project: Kafka Issue Type: Im

Re: [PR] MINOR: Refactor shared-group request handle methods to return CompletableFuture for consistent error handling [kafka]

2025-05-18 Thread via GitHub
chia7712 merged PR #19724: URL: https://github.com/apache/kafka/pull/19724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19287: document all group coordinator metrics [kafka]

2025-05-18 Thread via GitHub
chia7712 commented on PR #19749: URL: https://github.com/apache/kafka/pull/19749#issuecomment-2889098456 > For num-partitions, there is partition-count. We need to check which one is correct in the code. There's a discrepancy in the naming of the partition configuration. The code use

Re: [PR] KAFKA-19056: Rewrite EndToEndClusterIdTest in Java and move it to the server module [kafka]

2025-05-18 Thread via GitHub
chia7712 commented on code in PR #19741: URL: https://github.com/apache/kafka/pull/19741#discussion_r2094581285 ## server/src/test/java/org/apache/kafka/api/EndToEndClusterIdTest.java: ## @@ -0,0 +1,216 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[jira] [Assigned] (KAFKA-19305) Ensure all image classes are immutable

2025-05-18 Thread Chang Chi Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chang Chi Hsu reassigned KAFKA-19305: - Assignee: Chang Chi Hsu (was: Chia-Ping Tsai) > Ensure all image classes are immutable

Re: [PR] KAFKA-19260: Move LoggingController to server module [kafka]

2025-05-18 Thread via GitHub
chia7712 commented on code in PR #19687: URL: https://github.com/apache/kafka/pull/19687#discussion_r2094574178 ## core/src/main/scala/kafka/server/ConfigHelper.scala: ## @@ -130,7 +131,7 @@ class ConfigHelper(metadataCache: MetadataCache, config: KafkaConfig, configRepo

Re: [PR] KAFKA-17747: [3/N] Get rid of TopicMetadata in SubscribedTopicDescriberImpl [kafka]

2025-05-18 Thread via GitHub
chia7712 commented on code in PR #19611: URL: https://github.com/apache/kafka/pull/19611#discussion_r2094571756 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/SubscribedTopicDescriberImpl.java: ## @@ -79,49 +80,65 @@ public int numPartitions(Uuid to

[jira] [Created] (KAFKA-19305) Ensure all image classes are immutable

2025-05-18 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19305: -- Summary: Ensure all image classes are immutable Key: KAFKA-19305 URL: https://issues.apache.org/jira/browse/KAFKA-19305 Project: Kafka Issue Type: Improv

Re: [PR] MINOR: Remove unnecessary test conditions where ListOffsetsRequest version is 0 [kafka]

2025-05-18 Thread via GitHub
chia7712 merged PR #19738: URL: https://github.com/apache/kafka/pull/19738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19303 Move VerifiableProperties to server-common module [kafka]

2025-05-18 Thread via GitHub
chia7712 commented on PR #19752: URL: https://github.com/apache/kafka/pull/19752#issuecomment-2889075726 we can't move `VerifiableProperties` for now, as it is used by `KafkaMetricsReporter` which "may" be a part of public APIs. related jira: https://issues.apache.org/jira/browse/KAFK

Re: [PR] KAFKA-19042: [9/N] Move GroupAuthorizerIntegrationTest to clients-integration-tests module [kafka]

2025-05-18 Thread via GitHub
Rancho-7 commented on code in PR #19685: URL: https://github.com/apache/kafka/pull/19685#discussion_r2094550909 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/security/GroupAuthorizerIntegrationTest.java: ## @@ -0,0 +1,464 @@ +/* + * Licensed to the

Re: [PR] KAFKA-19034: [1/N] Rewrite RemoteTopicCrudTest by ClusterTest and move it to storage module [kafka]

2025-05-18 Thread via GitHub
apalan60 commented on PR #19681: URL: https://github.com/apache/kafka/pull/19681#issuecomment-2889029146 CI failed due to a known flaky test, tracked here: https://issues.apache.org/jira/browse/KAFKA-17999 -- This is an automated message from the Apache Git Service. To respond to the mess

[PR] KAFKA-18903: update-cache.sh use curl + jq to get sha contains gradle cache instead of gh cli [kafka]

2025-05-18 Thread via GitHub
mingyen066 opened a new pull request, #19753: URL: https://github.com/apache/kafka/pull/19753 The original logic required setting up alias.update-cache. After the change, this configuration is no longer necessary. Additionally, the purpose of update-cache.sh has been added to the README.md.

[jira] [Assigned] (KAFKA-19286) RemoteIndexCacheTest.testConcurrentRemoveReadForCache1 is flaky

2025-05-18 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uladzislau Blok reassigned KAFKA-19286: --- Assignee: Uladzislau Blok > RemoteIndexCacheTest.testConcurrentRemoveReadForCache1

[PR] KAFKA-19303 Move VerifiableProperties to server-common module [kafka]

2025-05-18 Thread via GitHub
m1a2st opened a new pull request, #19752: URL: https://github.com/apache/kafka/pull/19752 We could move VerifiableProperties class to server-common module, and rewrite to java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Created] (KAFKA-19304) Move KafkaMetricsConfig to server module

2025-05-18 Thread Jira
黃竣陽 created KAFKA-19304: --- Summary: Move KafkaMetricsConfig to server module Key: KAFKA-19304 URL: https://issues.apache.org/jira/browse/KAFKA-19304 Project: Kafka Issue Type: Improvement Re

[jira] [Updated] (KAFKA-19304) Move KafkaMetricsConfig to server module

2025-05-18 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-19304: Parent: KAFKA-15852 Issue Type: Sub-task (was: Improvement) > Move KafkaMetricsConfig to server module >

[jira] [Updated] (KAFKA-19303) Move VerifiableProperties to server-common module

2025-05-18 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-19303: Parent: KAFKA-15852 Issue Type: Sub-task (was: Task) > Move VerifiableProperties to server-common module

[jira] [Created] (KAFKA-19303) Move VerifiableProperties to server-common module

2025-05-18 Thread Jira
黃竣陽 created KAFKA-19303: --- Summary: Move VerifiableProperties to server-common module Key: KAFKA-19303 URL: https://issues.apache.org/jira/browse/KAFKA-19303 Project: Kafka Issue Type: Improvement

[jira] [Updated] (KAFKA-19303) Move VerifiableProperties to server-common module

2025-05-18 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-19303: Issue Type: Task (was: Improvement) > Move VerifiableProperties to server-common module > ---

[jira] [Comment Edited] (KAFKA-18883) Move TransactionLog to transaction-coordinator module

2025-05-18 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952438#comment-17952438 ] TaiJuWu edited comment on KAFKA-18883 at 5/18/25 12:21 PM: --- Th

[jira] [Commented] (KAFKA-18883) Move TransactionLog to transaction-coordinator module

2025-05-18 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952438#comment-17952438 ] TaiJuWu commented on KAFKA-18883: - This is blocked by KAFKA-1884  so I am waiting that P

[jira] [Commented] (KAFKA-19261) Move ConnectionQuotas to server module

2025-05-18 Thread Chang Chi Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952437#comment-17952437 ] Chang Chi Hsu commented on KAFKA-19261: --- [~bloku]  Yes, I'm > Move ConnectionQuot

[jira] [Assigned] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-05-18 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uladzislau Blok reassigned KAFKA-19259: --- Assignee: Arpit Goyal (was: Uladzislau Blok) > Async consumer fetch intermittent d

[jira] [Commented] (KAFKA-18727) Move RequestChannel to server module

2025-05-18 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952430#comment-17952430 ] Uladzislau Blok commented on KAFKA-18727: - [~m1a2st] Thanks for response. Okay.

[jira] [Commented] (KAFKA-18727) Move RequestChannel to server module

2025-05-18 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952429#comment-17952429 ] 黃竣陽 commented on KAFKA-18727: - [~bloku] This shouldn't work at the moment, as there are othe

[jira] [Commented] (KAFKA-19276) Trigger rebalance when assignment related configurations are updated

2025-05-18 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952428#comment-17952428 ] Uladzislau Blok commented on KAFKA-19276: - [~lucasbru] Hello. I see no one is as

[jira] [Commented] (KAFKA-19261) Move ConnectionQuotas to server module

2025-05-18 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952427#comment-17952427 ] Uladzislau Blok commented on KAFKA-19261: - [~jim0987795064] Hello. Are still wor

[jira] [Commented] (KAFKA-18727) Move RequestChannel to server module

2025-05-18 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952426#comment-17952426 ] Uladzislau Blok commented on KAFKA-18727: - [~m1a2st] Hello. Are you sill working

[jira] [Commented] (KAFKA-18883) Move TransactionLog to transaction-coordinator module

2025-05-18 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952425#comment-17952425 ] Uladzislau Blok commented on KAFKA-18883: - [~taijuwu] Hello. Are you still looki

[jira] [Commented] (KAFKA-19259) Async consumer fetch intermittent delays on console consumer

2025-05-18 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17952424#comment-17952424 ] Uladzislau Blok commented on KAFKA-19259: - [~goyarpit] Sure. FYI: ticket was ass

Re: [PR] KAFKA-19287: document all group coordinator metrics [kafka]

2025-05-18 Thread via GitHub
dajac commented on PR #19749: URL: https://github.com/apache/kafka/pull/19749#issuecomment-224730 @YutaLin Could you please ensure that the updates are in this [section](https://kafka.apache.org/documentation/#group_coordinator_monitoring)? For the histogram, they are already there but