Re: [PR] KAFKA-18881: Document the ConsumerRecord as non-thread safe [kafka]

2025-02-27 Thread via GitHub
LoganZhuZzz commented on PR #19056: URL: https://github.com/apache/kafka/pull/19056#issuecomment-2689972128 > Do we need to add an annotation to indicate that the thread is not thread-safe? @LoganZhuZzz @chia7712 Thanks for the feedback @gongxuanzhang ! Kafka already provides the `@k

Re: [PR] KAFKA-18881: Document the ConsumerRecord as non-thread safe [kafka]

2025-02-27 Thread via GitHub
gongxuanzhang commented on PR #19056: URL: https://github.com/apache/kafka/pull/19056#issuecomment-2689908338 Do we need to add an annotation to indicate that the thread is not thread-safe? @LoganZhuZzz @chia7712 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-18873: Fixed incorrect error message when exceeds 5 for transactional producers [kafka]

2025-02-27 Thread via GitHub
mjsax commented on PR #19041: URL: https://github.com/apache/kafka/pull/19041#issuecomment-2689866165 Thanks for the PR. Seems there is some confusion about this test... First, the test was added like this 2 year ago and never modified. So it was missed on the original PR review http

Re: [PR] KAFKA-18868: add the "default value" explanation to the docs of num.replica.alter.log.dirs.threads [kafka]

2025-02-27 Thread via GitHub
LoganZhuZzz commented on code in PR #19038: URL: https://github.com/apache/kafka/pull/19038#discussion_r1974863681 ## server/src/main/java/org/apache/kafka/server/config/ServerConfigs.java: ## @@ -52,7 +52,8 @@ public class ServerConfigs { public static final String BACKGRO

Re: [PR] HOTFIX: remove PageView example to support Java11 for :streams:examples module [kafka]

2025-02-27 Thread via GitHub
mjsax commented on code in PR #19052: URL: https://github.com/apache/kafka/pull/19052#discussion_r1974831931 ## build.gradle: ## @@ -51,7 +51,7 @@ ext { gradleVersion = versions.gradle minClientJavaVersion = 11 minNonClientJavaVersion = 17 - modulesNeedingJava11 = [":c

Re: [PR] KAFKA-17627: ConfigProvider TTLs do not restart Tasks [kafka]

2025-02-27 Thread via GitHub
github-actions[bot] closed pull request #17643: KAFKA-17627: ConfigProvider TTLs do not restart Tasks URL: https://github.com/apache/kafka/pull/17643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-17348: Add custom produce request parsers [kafka]

2025-02-27 Thread via GitHub
github-actions[bot] closed pull request #17324: KAFKA-17348: Add custom produce request parsers URL: https://github.com/apache/kafka/pull/17324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] KAFKA-10361: Windows batch files that use /bin/windows/kafka-run-class.bat fail with a class path error on fresh installation [kafka]

2025-02-27 Thread via GitHub
github-actions[bot] commented on PR #9125: URL: https://github.com/apache/kafka/pull/9125#issuecomment-2689641018 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

Re: [PR] KAFKA-17316: Standard authorizer refactor [kafka]

2025-02-27 Thread via GitHub
github-actions[bot] closed pull request #16779: KAFKA-17316: Standard authorizer refactor URL: https://github.com/apache/kafka/pull/16779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KIP-1097 POC: error record reporter API [kafka]

2025-02-27 Thread via GitHub
github-actions[bot] closed pull request #17493: KIP-1097 POC: error record reporter API URL: https://github.com/apache/kafka/pull/17493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] KIP-1097 POC: error record reporter API [kafka]

2025-02-27 Thread via GitHub
github-actions[bot] commented on PR #17493: URL: https://github.com/apache/kafka/pull/17493#issuecomment-2689641187 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-17316: Standard authorizer refactor [kafka]

2025-02-27 Thread via GitHub
github-actions[bot] commented on PR #16779: URL: https://github.com/apache/kafka/pull/16779#issuecomment-2689641095 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-17348: Add custom produce request parsers [kafka]

2025-02-27 Thread via GitHub
github-actions[bot] commented on PR #17324: URL: https://github.com/apache/kafka/pull/17324#issuecomment-2689641143 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

[jira] [Assigned] (KAFKA-13022) Optimize ClientQuotasImage#describe

2025-02-27 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-13022: - Assignee: PoAn Yang > Optimize ClientQuotasImage#describe > ---

Re: [PR] KAFKA-18864:remove the Evolving tag from stable public interfaces [kafka]

2025-02-27 Thread via GitHub
gongxuanzhang commented on PR #19036: URL: https://github.com/apache/kafka/pull/19036#issuecomment-2689565270 I think I have fixed it, but I’m not sure if I should delete the `Admin`’s comment. PTAL @junrao @chia7712 -- This is an automated message from the Apache Git Service. To respo

[PR] KAFKA-18817:[1/N] ShareGroupHeartbeat and ShareGroupDescribe API must check topic describe [kafka]

2025-02-27 Thread via GitHub
DL1231 opened a new pull request, #19055: URL: https://github.com/apache/kafka/pull/19055 1、Client support for TopicAuthException in DescribeShareGroup and HB path 2、ShareConsumerImpl#sendAcknowledgementsAndLeaveGroup swallow TopicAuthorizationException and GroupAuthorizationException

Re: [PR] MINOR: Add README.md test command [kafka]

2025-02-27 Thread via GitHub
mingdaoy commented on code in PR #19025: URL: https://github.com/apache/kafka/pull/19025#discussion_r1974675887 ## README.md: ## @@ -42,6 +42,7 @@ Follow instructions in https://kafka.apache.org/quickstart ./gradlew test # runs both unit and integration tests ./gradle

Re: [PR] KAFKA-18500 Build PRs at HEAD commit [kafka]

2025-02-27 Thread via GitHub
chia7712 commented on code in PR #18449: URL: https://github.com/apache/kafka/pull/18449#discussion_r1974425642 ## .github/workflows/README.md: ## @@ -133,4 +133,47 @@ Composite actions are a convenient way to reuse build logic, but they have some limitations. - Cannot run

Re: [PR] MINOR: Add README.md test command [kafka]

2025-02-27 Thread via GitHub
mingdaoy commented on code in PR #19025: URL: https://github.com/apache/kafka/pull/19025#discussion_r1974658273 ## README.md: ## @@ -75,6 +76,7 @@ Retries are disabled by default, but you can set maxTestRetryFailures and maxTes The following example declares -PmaxTestRetries=1

[PR] KAFKA-18882:Move BaseKey, TxnKey, and UnknownKey to transaction-coordinator module [kafka]

2025-02-27 Thread via GitHub
gongxuanzhang opened a new pull request, #19054: URL: https://github.com/apache/kafka/pull/19054 Move BaseKey, TxnKey, and UnknownKey to transaction-coordinator module -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] KAFKA-18864:remove the Evolving tag from stable public interfaces [kafka]

2025-02-27 Thread via GitHub
gongxuanzhang commented on code in PR #19036: URL: https://github.com/apache/kafka/pull/19036#discussion_r1974595611 ## clients/src/main/java/org/apache/kafka/clients/admin/AbortTransactionOptions.java: ## @@ -16,9 +16,7 @@ */ package org.apache.kafka.clients.admin; -import

[jira] [Assigned] (KAFKA-18817) ShareGroupHeartbeat and ShareGroupDescribe API must check topic describe

2025-02-27 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding reassigned KAFKA-18817: Assignee: Lan Ding (was: Shivsundar R) > ShareGroupHeartbeat and ShareGroupDescribe API must che

[jira] [Assigned] (KAFKA-18883) Move TransactionLog to transaction-coordinator module

2025-02-27 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-18883: - Assignee: TaiJuWu (was: PoAn Yang) > Move TransactionLog to transaction-coordinator module > -

[PR] MINOR: Removing share partition manager flaky annotation [kafka]

2025-02-27 Thread via GitHub
apoorvmittal10 opened a new pull request, #19053: URL: https://github.com/apache/kafka/pull/19053 There isn't any flaky test for SharePartitionManager in last 7 days, removing flaky annotation. https://develocity.apache.org/scans/tests?search.timeZoneId=Europe%2FLondon&tests.containe

Re: [PR] KAFKA-18734: Implemented share partition metrics (KIP-1103) [kafka]

2025-02-27 Thread via GitHub
apoorvmittal10 commented on code in PR #19045: URL: https://github.com/apache/kafka/pull/19045#discussion_r1974552557 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1291,13 +1303,30 @@ public boolean maybeAcquireFetchLock() { if (stateNotActive())

Re: [PR] KAFKA-18734: Implemented share partition metrics (KIP-1103) [kafka]

2025-02-27 Thread via GitHub
apoorvmittal10 commented on code in PR #19045: URL: https://github.com/apache/kafka/pull/19045#discussion_r1974546851 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1326,6 +1355,42 @@ int leaderEpoch() { return leaderEpoch; } +// Visible

[jira] [Assigned] (KAFKA-18894) Add support for ConfigProvider

2025-02-27 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jhen-Yung Hsu reassigned KAFKA-18894: - Assignee: Jhen-Yung Hsu > Add support for ConfigProvider >

Re: [PR] MINOR: Add README.md test command [kafka]

2025-02-27 Thread via GitHub
chia7712 commented on code in PR #19025: URL: https://github.com/apache/kafka/pull/19025#discussion_r1974442226 ## README.md: ## @@ -75,6 +76,7 @@ Retries are disabled by default, but you can set maxTestRetryFailures and maxTes The following example declares -PmaxTestRetries=1

Re: [PR] MINOR: correct an ELR test name in ActivationRecordsGeneratorTest [kafka]

2025-02-27 Thread via GitHub
junrao merged PR #19044: URL: https://github.com/apache/kafka/pull/19044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[jira] [Resolved] (KAFKA-18860) Clarify the KRaft missing feature

2025-02-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18860. Resolution: Fixed trunk: [https://github.com/apache/kafka/commit/e2d9ced098c35068900746af

Re: [PR] KAFKA-18860: Remove Missing Features section [kafka]

2025-02-27 Thread via GitHub
chia7712 merged PR #19048: URL: https://github.com/apache/kafka/pull/19048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18860: Remove Missing Features section [kafka]

2025-02-27 Thread via GitHub
chia7712 commented on PR #19048: URL: https://github.com/apache/kafka/pull/19048#issuecomment-2689265249 cherry-pick to 4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] KAFKA-18860: Remove Missing Features section [kafka]

2025-02-27 Thread via GitHub
chia7712 commented on PR #19048: URL: https://github.com/apache/kafka/pull/19048#issuecomment-2689263012 for future reviewers, I have opened https://issues.apache.org/jira/browse/KAFKA-18885 to add the "behavioral differences between ZooKeeper and KRaft" - that will include the missing fea

[jira] [Updated] (KAFKA-18371) TopicBasedRemoteLogMetadataManagerConfig exposes sensitive configuration data in logs

2025-02-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18371: --- Fix Version/s: 4.1.0 (was: 4.1) > TopicBasedRemoteLogMetadataManagerC

Re: [PR] KAFKA-18371 TopicBasedRemoteLogMetadataManagerConfig exposes sensitive configuration data in logs [kafka]

2025-02-27 Thread via GitHub
chia7712 merged PR #18349: URL: https://github.com/apache/kafka/pull/18349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-18898) 4.0 Upgrade docs rendering below other versions

2025-02-27 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931318#comment-17931318 ] 黃竣陽 commented on KAFKA-18898: - Hello [~davidarthur] ,The {{zk2kraft}} page has been moved to

[jira] [Updated] (KAFKA-18898) 4.0 Upgrade docs rendering below other versions

2025-02-27 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18898: Attachment: image-2025-02-28-06-28-28-356.png > 4.0 Upgrade docs rendering below other versions >

[jira] [Commented] (KAFKA-18898) 4.0 Upgrade docs rendering below other versions

2025-02-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931317#comment-17931317 ] Chia-Ping Tsai commented on KAFKA-18898: [~davidarthur] Are you testing the 4.0

[jira] [Updated] (KAFKA-18898) 4.0 Upgrade docs rendering below other versions

2025-02-27 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18898: Attachment: image-2025-02-28-06-29-11-204.png > 4.0 Upgrade docs rendering below other versions >

[jira] [Assigned] (KAFKA-18896) Add support for Login

2025-02-27 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 reassigned KAFKA-18896: --- Assignee: 黃竣陽 > Add support for Login > - > > Key: KAFKA-18896 >

[jira] [Assigned] (KAFKA-18892) Add support for ClientQuotaCallback

2025-02-27 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 reassigned KAFKA-18892: --- Assignee: 黃竣陽 > Add support for ClientQuotaCallback > --- > >

Re: [PR] HOTFIX: remove PageView example to support Java11 for :streams:examples module [kafka]

2025-02-27 Thread via GitHub
chia7712 commented on code in PR #19052: URL: https://github.com/apache/kafka/pull/19052#discussion_r1974350080 ## build.gradle: ## @@ -51,7 +51,7 @@ ext { gradleVersion = versions.gradle minClientJavaVersion = 11 minNonClientJavaVersion = 17 - modulesNeedingJava11 = [

Re: [PR] KAFKA-6829: Retry commits on unknown topic or partition [kafka]

2025-02-27 Thread via GitHub
aminaaddd commented on PR #4948: URL: https://github.com/apache/kafka/pull/4948#issuecomment-2689167200 | ERROR:root:Error: KafkaError{code=UNKNOWN_TOPIC_OR_PART,val=3,str="Subscribed topic not available: housing_topic: Broker: Unknown topic or partition"} i have this problem and i d

[jira] [Commented] (KAFKA-18890) Add support for CreateTopicPolicy and AlterConfigPolicy

2025-02-27 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931296#comment-17931296 ] Jhen-Yung Hsu commented on KAFKA-18890: --- I'm working on this, thanks :) > Add sup

[jira] [Assigned] (KAFKA-18895) Add support for AuthenticateCallbackHandler

2025-02-27 Thread Mingdao Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingdao Yang reassigned KAFKA-18895: Assignee: Mingdao Yang > Add support for AuthenticateCallbackHandler > --

[jira] [Assigned] (KAFKA-18897) Add support for SslEngineFactory

2025-02-27 Thread Mingdao Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingdao Yang reassigned KAFKA-18897: Assignee: Mingdao Yang > Add support for SslEngineFactory > -

[jira] [Commented] (KAFKA-18894) Add support for ConfigProvider

2025-02-27 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931297#comment-17931297 ] Jhen-Yung Hsu commented on KAFKA-18894: --- I'm working on this, thanks :) > Add sup

[jira] [Assigned] (KAFKA-18890) Add support for CreateTopicPolicy and AlterConfigPolicy

2025-02-27 Thread Jhen-Yung Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jhen-Yung Hsu reassigned KAFKA-18890: - Assignee: Jhen-Yung Hsu > Add support for CreateTopicPolicy and AlterConfigPolicy > ---

[jira] [Assigned] (KAFKA-14488) Move log layer tests to storage module

2025-02-27 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu reassigned KAFKA-14488: --- Assignee: TaiJuWu > Move log layer tests to storage module > --

Re: [PR] HOTFIX: remove PageView example to support Java11 for :streams:examples module [kafka]

2025-02-27 Thread via GitHub
gharris1727 commented on code in PR #19052: URL: https://github.com/apache/kafka/pull/19052#discussion_r1974314924 ## docs/streams/developer-guide/datatypes.html: ## @@ -156,11 +156,9 @@ Primitive and basic types JSON -The Kafka Streams code examples also includ

[PR] HOTFIX: remove PageView example to support Java11 for :streams:examples module [kafka]

2025-02-27 Thread via GitHub
mjsax opened a new pull request, #19052: URL: https://github.com/apache/kafka/pull/19052 The PageView example depends on Connect to pull in Json (de)serializers, but Connect does not support Java11 any longer. To allow supporting Java11 for the Kafka Streams examples, this PR removes

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-27 Thread via GitHub
kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r1971722138 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -1127,14 +1331,75 @@ private MajorityReachedHighWatermark(Cluster cluster) {

[jira] [Updated] (KAFKA-18898) 4.0 Upgrade docs rendering below other versions

2025-02-27 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-18898: - Affects Version/s: 4.0.0 > 4.0 Upgrade docs rendering below other versions > ---

[jira] [Created] (KAFKA-18898) 4.0 Upgrade docs rendering below other versions

2025-02-27 Thread David Arthur (Jira)
David Arthur created KAFKA-18898: Summary: 4.0 Upgrade docs rendering below other versions Key: KAFKA-18898 URL: https://issues.apache.org/jira/browse/KAFKA-18898 Project: Kafka Issue Type: B

[jira] [Assigned] (KAFKA-18893) Add support for ReplicaSelector

2025-02-27 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu reassigned KAFKA-18893: --- Assignee: TaiJuWu > Add support for ReplicaSelector > --- > >

[jira] [Assigned] (KAFKA-18891) Add support for RemoteLogMetadataManager and RemoteStorageManager

2025-02-27 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu reassigned KAFKA-18891: --- Assignee: TaiJuWu > Add support for RemoteLogMetadataManager and RemoteStorageManager > ---

[jira] [Commented] (KAFKA-18891) Add support for RemoteLogMetadataManager and RemoteStorageManager

2025-02-27 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931280#comment-17931280 ] Mickael Maison commented on KAFKA-18891: Sure, it's unassigned so feel free to g

[jira] [Commented] (KAFKA-18891) Add support for RemoteLogMetadataManager and RemoteStorageManager

2025-02-27 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931278#comment-17931278 ] TaiJuWu commented on KAFKA-18891: - Hi[~mimaison] , may I take this over if you are not w

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests pt 1 [kafka]

2025-02-27 Thread via GitHub
kevin-wu24 commented on PR #18987: URL: https://github.com/apache/kafka/pull/18987#issuecomment-2688961782 https://github.com/apache/kafka/pull/18987#discussion_r1971722138 contains the most recent observation on what is going on when we're checking the `MajorityReachedHighWatermark` invari

Re: [PR] KAFKA-18864:remove the Evolving tag from stable public interfaces [kafka]

2025-02-27 Thread via GitHub
junrao commented on code in PR #19036: URL: https://github.com/apache/kafka/pull/19036#discussion_r1974060328 ## clients/src/main/java/org/apache/kafka/clients/admin/AbortTransactionOptions.java: ## @@ -16,9 +16,7 @@ */ package org.apache.kafka.clients.admin; -import org.ap

Re: [PR] KAFKA-18629: ShareGroupDeleteState admin client impl. [kafka]

2025-02-27 Thread via GitHub
junrao commented on code in PR #18928: URL: https://github.com/apache/kafka/pull/18928#discussion_r1974106703 ## clients/src/main/java/org/apache/kafka/clients/admin/DeleteGroupsResult.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] MINOR: correct an ELR test name in ActivationRecordsGeneratorTest [kafka]

2025-02-27 Thread via GitHub
CalvinConfluent commented on PR #19044: URL: https://github.com/apache/kafka/pull/19044#issuecomment-2688735295 @junrao I guess we need to add the ci-approved tag for the next test run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Created] (KAFKA-18890) Add support for CreateTopicPolicy and AlterConfigPolicy

2025-02-27 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-18890: -- Summary: Add support for CreateTopicPolicy and AlterConfigPolicy Key: KAFKA-18890 URL: https://issues.apache.org/jira/browse/KAFKA-18890 Project: Kafka I

Re: [PR] MINOR: Extract HeartbeatRequestState from heartbeat request managers [kafka]

2025-02-27 Thread via GitHub
cadonna commented on code in PR #19043: URL: https://github.com/apache/kafka/pull/19043#discussion_r1974015099 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestState.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Created] (KAFKA-18897) Add support for SslEngineFactory

2025-02-27 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-18897: -- Summary: Add support for SslEngineFactory Key: KAFKA-18897 URL: https://issues.apache.org/jira/browse/KAFKA-18897 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-18896) Add support for Login

2025-02-27 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-18896: -- Summary: Add support for Login Key: KAFKA-18896 URL: https://issues.apache.org/jira/browse/KAFKA-18896 Project: Kafka Issue Type: Sub-task Re

[jira] [Created] (KAFKA-18894) Add support for ConfigProvider

2025-02-27 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-18894: -- Summary: Add support for ConfigProvider Key: KAFKA-18894 URL: https://issues.apache.org/jira/browse/KAFKA-18894 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-18893) Add support for ReplicaSelector

2025-02-27 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-18893: -- Summary: Add support for ReplicaSelector Key: KAFKA-18893 URL: https://issues.apache.org/jira/browse/KAFKA-18893 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-18891) Add support for RemoteLogMetadataManager and RemoteStorageManager

2025-02-27 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-18891: -- Summary: Add support for RemoteLogMetadataManager and RemoteStorageManager Key: KAFKA-18891 URL: https://issues.apache.org/jira/browse/KAFKA-18891 Project: Kafka

[jira] [Created] (KAFKA-18895) Add support for AuthenticateCallbackHandler

2025-02-27 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-18895: -- Summary: Add support for AuthenticateCallbackHandler Key: KAFKA-18895 URL: https://issues.apache.org/jira/browse/KAFKA-18895 Project: Kafka Issue Type: S

[jira] [Created] (KAFKA-18892) Add support for ClientQuotaCallback

2025-02-27 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-18892: -- Summary: Add support for ClientQuotaCallback Key: KAFKA-18892 URL: https://issues.apache.org/jira/browse/KAFKA-18892 Project: Kafka Issue Type: Sub-task

[jira] [Commented] (KAFKA-18820) CVE-2025-24970 [netty-handler]

2025-02-27 Thread Vishal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931235#comment-17931235 ] Vishal commented on KAFKA-18820: Okay, thanks! > CVE-2025-24970 [netty-handler] > -

[PR] KAFKA-18888: Add KIP-877 support to Authorizer [kafka]

2025-02-27 Thread via GitHub
mimaison opened a new pull request, #19050: URL: https://github.com/apache/kafka/pull/19050 This also adds metrics to StandardAuthorizer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] KAFKA-18844: Stale features information in QuorumController#registerBroker [kafka]

2025-02-27 Thread via GitHub
junrao commented on PR #18997: URL: https://github.com/apache/kafka/pull/18997#issuecomment-2688642424 @jsancio : I merged the PR to trunk. Could you help cherry-pick it to 4.0 and 3.9? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] KAFKA-18844: Stale features information in QuorumController#registerBroker [kafka]

2025-02-27 Thread via GitHub
junrao merged PR #18997: URL: https://github.com/apache/kafka/pull/18997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-18844: Stale features information in QuorumController#registerBroker [kafka]

2025-02-27 Thread via GitHub
junrao commented on PR #18997: URL: https://github.com/apache/kafka/pull/18997#issuecomment-2688594729 @FrankYang0529 : Thanks for the updated description. LGTM @jsancio : +1 on cherry-pick this to 3.9 too. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] KAFKA-18873: Fixed incorrect error message when exceeds 5 for transactional producers [kafka]

2025-02-27 Thread via GitHub
kirktrue commented on PR #19041: URL: https://github.com/apache/kafka/pull/19041#issuecomment-2688532201 > If it’s helpful, I can investigate further to identify when this behavior was introduced. Let me know if you'd like me to proceed with that! I'll let Matthias (or someone else) d

Re: [PR] KAFKA-18734: Implemented share partition metrics (KIP-1103) [kafka]

2025-02-27 Thread via GitHub
AndrewJSchofield commented on code in PR #19045: URL: https://github.com/apache/kafka/pull/19045#discussion_r1973984099 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -1291,13 +1303,30 @@ public boolean maybeAcquireFetchLock() { if (stateNotActive()

Re: [PR] MINOR: Extract HeartbeatRequestState from heartbeat request managers [kafka]

2025-02-27 Thread via GitHub
kirktrue commented on code in PR #19043: URL: https://github.com/apache/kafka/pull/19043#discussion_r1973966726 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestState.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] KAFKA-18873: Fixed incorrect error message when exceeds 5 for transactional producers [kafka]

2025-02-27 Thread via GitHub
kirktrue commented on PR #19041: URL: https://github.com/apache/kafka/pull/19041#issuecomment-2688529462 cc @mjsax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] MINOR: Extract HeartbeatRequestState from heartbeat request managers [kafka]

2025-02-27 Thread via GitHub
kirktrue commented on code in PR #19043: URL: https://github.com/apache/kafka/pull/19043#discussion_r1973966726 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestState.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundatio

[jira] [Updated] (KAFKA-18881) Document the ConsumerRecord as non-thread safe

2025-02-27 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-18881: -- Component/s: clients consumer > Document the ConsumerRecord as non-thread safe >

Re: [PR] KAFKA-18780: Extend RetriableException related exceptions [kafka]

2025-02-27 Thread via GitHub
jolshan merged PR #19020: URL: https://github.com/apache/kafka/pull/19020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18276 Migrate RebootstrapTest to new test infra [kafka]

2025-02-27 Thread via GitHub
m1a2st commented on code in PR #19046: URL: https://github.com/apache/kafka/pull/19046#discussion_r1973857804 ## core/src/test/java/kafka/test/api/ProducerRebootstrapTest.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

Re: [PR] MINOR: TopicIdPartition Records Benchmark [kafka]

2025-02-27 Thread via GitHub
frankvicky commented on PR #18917: URL: https://github.com/apache/kafka/pull/18917#issuecomment-2688312404 It's weird that `oldImplHashCodeBenchmark` slows after the first warmup, so I benchmark with JDK17 again. However, the behavior is identical. ``` BUILD SUCCESSFUL in 10s 94

Re: [PR] MINOR: TopicIdPartition Records Benchmark [kafka]

2025-02-27 Thread via GitHub
frankvicky commented on PR #18917: URL: https://github.com/apache/kafka/pull/18917#issuecomment-2688238076 ``` BUILD SUCCESSFUL in 10s 94 actionable tasks: 3 executed, 91 up-to-date gradle build done running JMH with args: TopicIdPartitionBenchmark # JMH version: 1.37 # VM v

Re: [PR] KAFKA-18276 Migrate RebootstrapTest to new test infra [kafka]

2025-02-27 Thread via GitHub
clarkwtc commented on code in PR #19046: URL: https://github.com/apache/kafka/pull/19046#discussion_r1973767767 ## core/src/test/java/kafka/test/api/ProducerRebootstrapTest.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-18276 Migrate RebootstrapTest to new test infra [kafka]

2025-02-27 Thread via GitHub
clarkwtc commented on code in PR #19046: URL: https://github.com/apache/kafka/pull/19046#discussion_r1973779776 ## core/src/test/java/kafka/test/api/ProducerRebootstrapTest.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-18276 Migrate RebootstrapTest to new test infra [kafka]

2025-02-27 Thread via GitHub
clarkwtc commented on code in PR #19046: URL: https://github.com/apache/kafka/pull/19046#discussion_r1973779776 ## core/src/test/java/kafka/test/api/ProducerRebootstrapTest.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Commented] (KAFKA-18871) KRaft migration rollback causes downtime

2025-02-27 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931194#comment-17931194 ] Daniel Urban commented on KAFKA-18871: -- [~ppatierno] Oh, apologies, I attached the

Re: [PR] KAFKA-18276 Migrate RebootstrapTest to new test infra [kafka]

2025-02-27 Thread via GitHub
clarkwtc commented on code in PR #19046: URL: https://github.com/apache/kafka/pull/19046#discussion_r1973769247 ## core/src/test/java/kafka/test/api/ProducerRebootstrapTest.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-18276 Migrate RebootstrapTest to new test infra [kafka]

2025-02-27 Thread via GitHub
clarkwtc commented on code in PR #19046: URL: https://github.com/apache/kafka/pull/19046#discussion_r1973768673 ## core/src/test/java/kafka/test/api/ProducerRebootstrapTest.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-18276 Migrate RebootstrapTest to new test infra [kafka]

2025-02-27 Thread via GitHub
clarkwtc commented on code in PR #19046: URL: https://github.com/apache/kafka/pull/19046#discussion_r1973760130 ## core/src/test/java/kafka/test/api/ProducerRebootstrapTest.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Updated] (KAFKA-18871) KRaft migration rollback causes downtime

2025-02-27 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Urban updated KAFKA-18871: - Attachment: cluster-operator.log.zip > KRaft migration rollback causes downtime > --

[jira] [Commented] (KAFKA-18871) KRaft migration rollback causes downtime

2025-02-27 Thread Paolo Patierno (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931192#comment-17931192 ] Paolo Patierno commented on KAFKA-18871: > The logs cover a large timespan, but

Re: [PR] KAFKA-18873: Fixed incorrect error message when exceeds 5 for transactional producers [kafka]

2025-02-27 Thread via GitHub
EsMoX commented on PR #19041: URL: https://github.com/apache/kafka/pull/19041#issuecomment-2688180286 > > Thanks for the PR @EsMoX! > > I'm a little surprised that this test bug exists. Either this test has been failing for awhile, or something was changed in the `ProducerConfig` logic t

Re: [PR] KAFKA-18873: Fixed incorrect error message when exceeds 5 for transactional producers [kafka]

2025-02-27 Thread via GitHub
EsMoX commented on PR #19041: URL: https://github.com/apache/kafka/pull/19041#issuecomment-2688178209 Thank you for your feedback, @kirktrue! I looked into the issue, and it seems that this problem may have existed for some time. The test likely started failing due to a change in the

Re: [PR] KAFKA-18873: Fixed incorrect error message when exceeds 5 for transactional producers [kafka]

2025-02-27 Thread via GitHub
EsMoX closed pull request #19041: KAFKA-18873: Fixed incorrect error message when exceeds 5 for transactional producers URL: https://github.com/apache/kafka/pull/19041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] KAFKA-18873: Fixed incorrect error message when exceeds 5 for transactional producers [kafka]

2025-02-27 Thread via GitHub
EsMoX commented on PR #19041: URL: https://github.com/apache/kafka/pull/19041#issuecomment-2688176379 > Thanks for the PR @EsMoX! > > I'm a little surprised that this test bug exists. Either this test has been failing for awhile, or something was changed in the `ProducerConfig` logic

[jira] [Commented] (KAFKA-18871) KRaft migration rollback causes downtime

2025-02-27 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931180#comment-17931180 ] Daniel Urban commented on KAFKA-18871: -- One more correction, sorry for the confusio

  1   2   >