Re: [PR] reuse LoginCallbackHandler on kerberos re-login [kafka]

2025-02-04 Thread via GitHub
sparkforreg commented on PR #18589: URL: https://github.com/apache/kafka/pull/18589#issuecomment-2635991215 Can you suggest what should be done to make this pr reviewed and merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] KAFKA-16892: fix TopicsDelta generated from snapshot #localChanges return empty deletes [kafka]

2025-02-04 Thread via GitHub
showuon commented on PR #16206: URL: https://github.com/apache/kafka/pull/16206#issuecomment-2635984692 @superhx , sorry that I didn't see the PR. Are you still interested in this PR? Do you think this issue still exist in the trunk branch? -- This is an automated message from the Apa

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-02-04 Thread via GitHub
ableegoldman commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1942372964 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CloseOptionsInternal.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-02-04 Thread via GitHub
ableegoldman commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1942370967 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ClassicKafkaConsumer.java: ## @@ -1102,10 +1103,11 @@ public void enforceRebalance() {

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-02-04 Thread via GitHub
ableegoldman commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1942370387 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1236,10 +1237,11 @@ public void enforceRebalance(String reason

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-02-04 Thread via GitHub
ableegoldman commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1942366854 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1187,6 +1183,21 @@ public synchronized RequestFuture maybeLe

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-02-04 Thread via GitHub
ableegoldman commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1942365317 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1187,6 +1183,21 @@ public synchronized RequestFuture maybeLe

Re: [PR] DRAFT KAFKA-18692: Consider to unify KStreamImpl "repartitionRequired" with GraphNode "keyChangingOperation" [kafka]

2025-02-04 Thread via GitHub
appchemist commented on code in PR #18800: URL: https://github.com/apache/kafka/pull/18800#discussion_r1941275162 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1250,6 +1237,7 @@ public KStream process( name,

Re: [PR] KAFKA-18064: SASL mechanisms that do support neihter integrity nor co… [kafka]

2025-02-04 Thread via GitHub
stoty commented on PR #17901: URL: https://github.com/apache/kafka/pull/17901#issuecomment-2635861758 Third party code that uses the SASL mechanisms from the Kafka codebase / loads them from the same JVM. Without this change, buggy thirdparty code may think it is communicating on an

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-02-04 Thread via GitHub
Goooler commented on code in PR #18018: URL: https://github.com/apache/kafka/pull/18018#discussion_r1942276633 ## build.gradle: ## @@ -41,7 +41,7 @@ plugins { id "com.github.spotbugs" version '6.0.25' apply false id 'org.scoverage' version '8.0.3' apply false - id 'io.g

Re: [PR] MINOR: cleanup KStream JavaDocs (7/N) - repartition/to/toTable [kafka]

2025-02-04 Thread via GitHub
mjsax commented on code in PR #18760: URL: https://github.com/apache/kafka/pull/18760#discussion_r1942246889 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -758,185 +756,118 @@ KStream flatMapValues(final ValueMapperWithKey - * The created to

Re: [PR] MINOR: cleanup KStream JavaDocs (7/N) - repartition/to/toTable [kafka]

2025-02-04 Thread via GitHub
mjsax commented on code in PR #18760: URL: https://github.com/apache/kafka/pull/18760#discussion_r1942246261 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -758,185 +756,118 @@ KStream flatMapValues(final ValueMapperWithKey - * The created to

[PR] MINOR: cleanup KStream JavaDocs (9/N) - flatMap[Values] [kafka]

2025-02-04 Thread via GitHub
mjsax opened a new pull request, #18805: URL: https://github.com/apache/kafka/pull/18805 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] MINOR: cleanup KStream JavaDocs (6/N) - map[Values] [kafka]

2025-02-04 Thread via GitHub
mjsax merged PR #18755: URL: https://github.com/apache/kafka/pull/18755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-17029: handle primitive types in SetSchemaMetadata [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16442: KAFKA-17029: handle primitive types in SetSchemaMetadata URL: https://github.com/apache/kafka/pull/16442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-16810: Add flag to read from specific partitions while checking consumer performance [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #15905: KAFKA-16810: Add flag to read from specific partitions while checking consumer performance URL: https://github.com/apache/kafka/pull/15905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] KAFKA-15259: pass TxnSendOption to Producer send() [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16465: KAFKA-15259: pass TxnSendOption to Producer send() URL: https://github.com/apache/kafka/pull/16465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-3737: Adjusted the log level from INFO to WARN [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16546: KAFKA-3737: Adjusted the log level from INFO to WARN URL: https://github.com/apache/kafka/pull/16546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] MINOR: cleanup KStream JavaDocs (8/N) - stream-stream-inner-join [kafka]

2025-02-04 Thread via GitHub
mjsax commented on PR #18761: URL: https://github.com/apache/kafka/pull/18761#issuecomment-2635641281 Thanks for the review. Update the PR accoringly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-15309: part 2-Add custom error handler for UnknownTopicOrPartitionException to Producer [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #15855: URL: https://github.com/apache/kafka/pull/15855#issuecomment-2635628980 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-15045: (KIP-924) Extend TaskAssignorIntegrationTest with new public TaskAssignor [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16349: KAFKA-15045: (KIP-924) Extend TaskAssignorIntegrationTest with new public TaskAssignor URL: https://github.com/apache/kafka/pull/16349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] KAFKA-16918: TestUtils#assertFutureThrows should use future.get with timeout [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16264: URL: https://github.com/apache/kafka/pull/16264#issuecomment-2635629251 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16918: TestUtils#assertFutureThrows should use future.get with timeout [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16264: KAFKA-16918: TestUtils#assertFutureThrows should use future.get with timeout URL: https://github.com/apache/kafka/pull/16264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-17029: handle primitive types in SetSchemaMetadata [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16442: URL: https://github.com/apache/kafka/pull/16442#issuecomment-2635629665 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16638 Align the naming convention for config and default variables in *Config classes [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16289: KAFKA-16638 Align the naming convention for config and default variables in *Config classes URL: https://github.com/apache/kafka/pull/16289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Add GetReplicaLogInfo API server side support [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #15604: Add GetReplicaLogInfo API server side support URL: https://github.com/apache/kafka/pull/15604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Add GetReplicaLogInfo API server side support [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #15604: URL: https://github.com/apache/kafka/pull/15604#issuecomment-2635628805 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-14919 sync topic configs test [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16143: URL: https://github.com/apache/kafka/pull/16143#issuecomment-2635629104 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16211: Inconsistent config values in CreateTopicsResult and DescribeConfigsResult [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #15696: KAFKA-16211: Inconsistent config values in CreateTopicsResult and DescribeConfigsResult URL: https://github.com/apache/kafka/pull/15696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] KAFKA-16811 Sliding window approach to calculate non-zero punctuate-ratio metric [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16162: URL: https://github.com/apache/kafka/pull/16162#issuecomment-2635629168 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16810: Add flag to read from specific partitions while checking consumer performance [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #15905: URL: https://github.com/apache/kafka/pull/15905#issuecomment-2635629012 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] [Minor] Fill remaining elements with null when provided array is longer [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16534: URL: https://github.com/apache/kafka/pull/16534#issuecomment-2635629933 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] MINOR: Improve Debugging and Logging in testElectPreferredLeaders [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #17677: URL: https://github.com/apache/kafka/pull/17677#issuecomment-2635630086 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] Changes to support selection of appropriate alias from a keystore with multiple alias entries [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16495: URL: https://github.com/apache/kafka/pull/16495#issuecomment-2635629844 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] Minor: Consumer group response should set error msg [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16497: Minor: Consumer group response should set error msg URL: https://github.com/apache/kafka/pull/16497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [Minor] Fill remaining elements with null when provided array is longer [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16534: [Minor] Fill remaining elements with null when provided array is longer URL: https://github.com/apache/kafka/pull/16534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] KAFKA-3737: Adjusted the log level from INFO to WARN [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16546: URL: https://github.com/apache/kafka/pull/16546#issuecomment-2635629979 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-17091: Add @FunctionalInterface to Streams interfaces [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16544: URL: https://github.com/apache/kafka/pull/16544#issuecomment-2635629948 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] Minor: Consumer group response should set error msg [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16497: URL: https://github.com/apache/kafka/pull/16497#issuecomment-2635629906 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-17045: Move MetadataLogConfig from kafka to kafka.raft [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16484: KAFKA-17045: Move MetadataLogConfig from kafka to kafka.raft URL: https://github.com/apache/kafka/pull/16484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-17091: Add @FunctionalInterface to Streams interfaces [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16544: KAFKA-17091: Add @FunctionalInterface to Streams interfaces URL: https://github.com/apache/kafka/pull/16544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-17025: Producer throws uncaught exception in the io thread [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16479: URL: https://github.com/apache/kafka/pull/16479#issuecomment-2635629778 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-17045: Move MetadataLogConfig from kafka to kafka/raft [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16468: URL: https://github.com/apache/kafka/pull/16468#issuecomment-2635629748 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-17045: Move MetadataLogConfig from kafka to kafka/raft [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16468: KAFKA-17045: Move MetadataLogConfig from kafka to kafka/raft URL: https://github.com/apache/kafka/pull/16468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-16995 The listeners broker parameter incorrect documentation [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16395: KAFKA-16995 The listeners broker parameter incorrect documentation URL: https://github.com/apache/kafka/pull/16395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] KAFKA-16995 The listeners broker parameter incorrect documentation [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16395: URL: https://github.com/apache/kafka/pull/16395#issuecomment-2635629590 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KIP-966 dynamic configs server side support [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16389: KIP-966 dynamic configs server side support URL: https://github.com/apache/kafka/pull/16389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] KIP-966 dynamic configs server side support [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16389: URL: https://github.com/apache/kafka/pull/16389#issuecomment-2635629559 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] refactor: refactoring code smells [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16365: refactor: refactoring code smells URL: https://github.com/apache/kafka/pull/16365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] refactor: refactoring code smells [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16365: URL: https://github.com/apache/kafka/pull/16365#issuecomment-2635629532 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] refactor: refactoring code smells [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16363: URL: https://github.com/apache/kafka/pull/16363#issuecomment-2635629474 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] [DEMO] Measuring memory usage during a test [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16445: [DEMO] Measuring memory usage during a test URL: https://github.com/apache/kafka/pull/16445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] MINOR: Add logs when metadata update is not successful [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16496: MINOR: Add logs when metadata update is not successful URL: https://github.com/apache/kafka/pull/16496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] MINOR: Add logs when metadata update is not successful [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16496: URL: https://github.com/apache/kafka/pull/16496#issuecomment-2635629878 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] Changes to support selection of appropriate alias from a keystore with multiple alias entries [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16495: Changes to support selection of appropriate alias from a keystore with multiple alias entries URL: https://github.com/apache/kafka/pull/16495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] KAFKA-17045: Move MetadataLogConfig from kafka to kafka.raft [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16484: URL: https://github.com/apache/kafka/pull/16484#issuecomment-2635629807 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-17025: Producer throws uncaught exception in the io thread [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16479: KAFKA-17025: Producer throws uncaught exception in the io thread URL: https://github.com/apache/kafka/pull/16479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-15259: pass TxnSendOption to Producer send() [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16465: URL: https://github.com/apache/kafka/pull/16465#issuecomment-2635629724 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] [DEMO] Measuring memory usage during a test [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16445: URL: https://github.com/apache/kafka/pull/16445#issuecomment-2635629697 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-17023: add PCollectionsImmutableMap to ConcurrentMapBenchmark [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16425: KAFKA-17023: add PCollectionsImmutableMap to ConcurrentMapBenchmark URL: https://github.com/apache/kafka/pull/16425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-17023: add PCollectionsImmutableMap to ConcurrentMapBenchmark [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16425: URL: https://github.com/apache/kafka/pull/16425#issuecomment-2635629628 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] WIP KAFKA-16707: Kafka Kraft : using Principal Type in StandardACL in order to defined ACL with a notion of group without rewriting KafkaPrincipal of client by rules [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16361: URL: https://github.com/apache/kafka/pull/16361#issuecomment-2635629436 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] refactor: refactoring code smells [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16364: refactor: refactoring code smells URL: https://github.com/apache/kafka/pull/16364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] refactor: refactoring code smells [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16363: refactor: refactoring code smells URL: https://github.com/apache/kafka/pull/16363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] refactor: refactoring code smells [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16364: URL: https://github.com/apache/kafka/pull/16364#issuecomment-2635629501 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] WIP KAFKA-16707: Kafka Kraft : using Principal Type in StandardACL in order to defined ACL with a notion of group without rewriting KafkaPrincipal of client by rules [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16361: WIP KAFKA-16707: Kafka Kraft : using Principal Type in StandardACL in order to defined ACL with a notion of group without rewriting KafkaPrincipal of client by rules URL: https://github.com/apache/kafka/pull/16361 -- This is an automated messag

Re: [PR] KAFKA-15045: (KIP-924) Extend TaskAssignorIntegrationTest with new public TaskAssignor [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16349: URL: https://github.com/apache/kafka/pull/16349#issuecomment-2635629393 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-15259: Processing must continue with flush() + commitTnx(commitOption) [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16332: KAFKA-15259: Processing must continue with flush() + commitTnx(commitOption) URL: https://github.com/apache/kafka/pull/16332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-15259: Processing must continue with flush() + commitTnx(commitOption) [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16332: URL: https://github.com/apache/kafka/pull/16332#issuecomment-2635629371 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-15133: only tick messageConversionsTimeMs if there are conversions [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16329: KAFKA-15133: only tick messageConversionsTimeMs if there are conversions URL: https://github.com/apache/kafka/pull/16329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-15133: only tick messageConversionsTimeMs if there are conversions [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16329: URL: https://github.com/apache/kafka/pull/16329#issuecomment-2635629333 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16913 Support external schemas in JSONConverter [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16311: URL: https://github.com/apache/kafka/pull/16311#issuecomment-2635629314 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16823: Extract LegacyConsumer-specific unit tests from generic KafkaConsumerTest [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16228: KAFKA-16823: Extract LegacyConsumer-specific unit tests from generic KafkaConsumerTest URL: https://github.com/apache/kafka/pull/16228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] KAFKA-16913 Support external schemas in JSONConverter [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16311: KAFKA-16913 Support external schemas in JSONConverter URL: https://github.com/apache/kafka/pull/16311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-16823: Extract LegacyConsumer-specific unit tests from generic KafkaConsumerTest [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16228: URL: https://github.com/apache/kafka/pull/16228#issuecomment-2635629225 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16638 Align the naming convention for config and default variables in *Config classes [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16289: URL: https://github.com/apache/kafka/pull/16289#issuecomment-2635629280 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16892: fix TopicsDelta generated from snapshot #localChanges return empty deletes [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16206: KAFKA-16892: fix TopicsDelta generated from snapshot #localChanges return empty deletes URL: https://github.com/apache/kafka/pull/16206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] SMT InsertField current timestamp [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16159: URL: https://github.com/apache/kafka/pull/16159#issuecomment-2635629138 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16892: fix TopicsDelta generated from snapshot #localChanges return empty deletes [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16206: URL: https://github.com/apache/kafka/pull/16206#issuecomment-2635629200 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16788 - Fix resource leakage during connector start() failure [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16095: KAFKA-16788 - Fix resource leakage during connector start() failure URL: https://github.com/apache/kafka/pull/16095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-16811 Sliding window approach to calculate non-zero punctuate-ratio metric [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16162: KAFKA-16811 Sliding window approach to calculate non-zero punctuate-ratio metric URL: https://github.com/apache/kafka/pull/16162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] SMT InsertField current timestamp [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16159: SMT InsertField current timestamp URL: https://github.com/apache/kafka/pull/16159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] KAFKA-15309: part 2-Add custom error handler for UnknownTopicOrPartitionException to Producer [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #15855: KAFKA-15309: part 2-Add custom error handler for UnknownTopicOrPartitionException to Producer URL: https://github.com/apache/kafka/pull/15855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] KAFKA-14919 sync topic configs test [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #16143: KAFKA-14919 sync topic configs test URL: https://github.com/apache/kafka/pull/16143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Add demo template for transactional client [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #15913: Add demo template for transactional client URL: https://github.com/apache/kafka/pull/15913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-16788 - Fix resource leakage during connector start() failure [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #16095: URL: https://github.com/apache/kafka/pull/16095#issuecomment-2635629077 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] MINOR: cleanup KStream JavaDocs (5/N) - stream-globalTable-inner-join [kafka]

2025-02-04 Thread via GitHub
mjsax commented on code in PR #18747: URL: https://github.com/apache/kafka/pull/18747#discussion_r1942200709 ## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ## @@ -2616,134 +2616,107 @@ KStream leftJoin(final KTable table,

Re: [PR] MINOR: ensure LocalLogManagerTestEnv is closed in QuorumControllerTest [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #15582: MINOR: ensure LocalLogManagerTestEnv is closed in QuorumControllerTest URL: https://github.com/apache/kafka/pull/15582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Add s390x support to CI [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #15644: URL: https://github.com/apache/kafka/pull/15644#issuecomment-2635628884 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] Add demo template for transactional client [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #15913: URL: https://github.com/apache/kafka/pull/15913#issuecomment-2635629040 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] Add s390x support to CI [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #15644: Add s390x support to CI URL: https://github.com/apache/kafka/pull/15644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] KAFKA-15309: part 1-Add custom error handler for RecordTooLargeException to Producer [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #15846: KAFKA-15309: part 1-Add custom error handler for RecordTooLargeException to Producer URL: https://github.com/apache/kafka/pull/15846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-15309: part 1-Add custom error handler for RecordTooLargeException to Producer [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #15846: URL: https://github.com/apache/kafka/pull/15846#issuecomment-2635628951 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16211: Inconsistent config values in CreateTopicsResult and DescribeConfigsResult [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #15696: URL: https://github.com/apache/kafka/pull/15696#issuecomment-2635628920 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16450: Add instance methods to Exit to replace static methods [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #15598: KAFKA-16450: Add instance methods to Exit to replace static methods URL: https://github.com/apache/kafka/pull/15598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #15615: URL: https://github.com/apache/kafka/pull/15615#issuecomment-2635628837 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #15615: KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value URL: https://github.com/apache/kafka/pull/15615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-16450: Add instance methods to Exit to replace static methods [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #15598: URL: https://github.com/apache/kafka/pull/15598#issuecomment-2635628772 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] MINOR: update kraft_upgrade_test to create a new topic after metadata upgrade [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] closed pull request #15451: MINOR: update kraft_upgrade_test to create a new topic after metadata upgrade URL: https://github.com/apache/kafka/pull/15451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] MINOR: ensure LocalLogManagerTestEnv is closed in QuorumControllerTest [kafka]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #15582: URL: https://github.com/apache/kafka/pull/15582#issuecomment-2635628744 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

  1   2   3   >