[jira] [Commented] (KAFKA-16368) Change constraints and default values for various configurations

2025-01-08 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911355#comment-17911355 ] David Jacot commented on KAFKA-16368: - [~divijvaidya] Are we done with this KIP for

[PR] KAFKA-18308; Update CoordinatorSerde [kafka]

2025-01-08 Thread via GitHub
dajac opened a new pull request, #18455: URL: https://github.com/apache/kafka/pull/18455 This patch updates the GroupCoordinatorSerde and the ShareGroupCoordinatorSerde to leverage the CoordinatorRecordType to deserialize records. With this, newly added record are automatically picked up. I

Re: [PR] KAFKA-18111: Add Kafka Logo to README [kafka]

2025-01-08 Thread via GitHub
fvaleri commented on PR #18452: URL: https://github.com/apache/kafka/pull/18452#issuecomment-2579348966 @swikarpat sorry for the late review, but why there is a new line between "of" and "companies" in the very first line? -- This is an automated message from the Apache Git Service. To r

Re: [PR] KAFKA-18211: Override class loaders for class graph scanning in connect. [kafka]

2025-01-08 Thread via GitHub
snehashisp commented on code in PR #18403: URL: https://github.com/apache/kafka/pull/18403#discussion_r1908232685 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/ReflectionScanner.java: ## @@ -76,8 +78,21 @@ private static String versionFor(Class pl

Re: [PR] KAFKA-18446:Remove MetadataCacheControllerNodeProvider [kafka]

2025-01-08 Thread via GitHub
gongxuanzhang closed pull request #18437: KAFKA-18446:Remove MetadataCacheControllerNodeProvider URL: https://github.com/apache/kafka/pull/18437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] KAFKA-17544: Fix for loading big files while performing load tests [kafka]

2025-01-08 Thread via GitHub
m1a2st commented on code in PR #18391: URL: https://github.com/apache/kafka/pull/18391#discussion_r1908181486 ## tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java: ## @@ -194,9 +195,16 @@ static List readPayloadFile(String payloadFilePath, String payloadDelimi

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (6/N): CREATE_ACLS, DELETE_ACLS [kafka]

2025-01-08 Thread via GitHub
TaiJuWu commented on code in PR #18454: URL: https://github.com/apache/kafka/pull/18454#discussion_r1908160414 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2619,16 +2619,6 @@ class KafkaApis(val requestChannel: RequestChannel, aclApis.handleDescribeAcls(reque

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis with handleCreateTokenRequest, handleRenewTokenRequestZk, handleExpireTokenRequestZk (3/N)… [kafka]

2025-01-08 Thread via GitHub
TaiJuWu commented on code in PR #18447: URL: https://github.com/apache/kafka/pull/18447#discussion_r1908074550 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -233,7 +232,7 @@ class KafkaApis(val requestChannel: RequestChannel, case ApiKeys.CREATE_PARTITIONS

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis with handleCreateTokenRequest, handleRenewTokenRequestZk, handleExpireTokenRequestZk (3/N)… [kafka]

2025-01-08 Thread via GitHub
TaiJuWu commented on code in PR #18447: URL: https://github.com/apache/kafka/pull/18447#discussion_r1908157891 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -233,7 +232,7 @@ class KafkaApis(val requestChannel: RequestChannel, case ApiKeys.CREATE_PARTITIONS

Re: [PR] KAFKA-17544: Fix for loading big files while performing load tests [kafka]

2025-01-08 Thread via GitHub
manoj-mathivanan commented on code in PR #18391: URL: https://github.com/apache/kafka/pull/18391#discussion_r1908135455 ## tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java: ## @@ -194,9 +195,16 @@ static List readPayloadFile(String payloadFilePath, String pay

[PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (teddy) [kafka]

2025-01-08 Thread via GitHub
tedyyan opened a new pull request, #18454: URL: https://github.com/apache/kafka/pull/18454 *More detailed description of your change, Delete follow KafkaApi handler handleCreateAcls handleDeleteAcls In Kraft mode, all requests are forwarded to controller and all authorization

Re: [PR] KAFKA-8721: Kafka metrics improvements [kafka]

2025-01-08 Thread via GitHub
github-actions[bot] commented on PR #7121: URL: https://github.com/apache/kafka/pull/7121#issuecomment-2579121852 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] KAFKA-8721: Kafka metrics improvements [kafka]

2025-01-08 Thread via GitHub
github-actions[bot] closed pull request #7121: KAFKA-8721: Kafka metrics improvements URL: https://github.com/apache/kafka/pull/7121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis with ApiKeys `LEADER_AND_ISR`, `STOP_REPLICA`, `UPDATE_METADATA` (1/N) [kafka]

2025-01-08 Thread via GitHub
chia7712 commented on code in PR #18417: URL: https://github.com/apache/kafka/pull/18417#discussion_r1908117518 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -3034,99 +3032,7 @@ class KafkaApisTest extends Logging { val markersResponse = capturedRespon

Re: [PR] Minor : Increase Config change throwable log info to error [kafka]

2025-01-08 Thread via GitHub
github-actions[bot] commented on PR #14380: URL: https://github.com/apache/kafka/pull/14380#issuecomment-2579105909 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] Updated year in NOTICE [kafka]

2025-01-08 Thread via GitHub
github-actions[bot] commented on PR #18375: URL: https://github.com/apache/kafka/pull/18375#issuecomment-2579105793 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18446:Remove MetadataCacheControllerNodeProvider [kafka]

2025-01-08 Thread via GitHub
chia7712 commented on code in PR #18437: URL: https://github.com/apache/kafka/pull/18437#discussion_r1908115933 ## core/src/main/scala/kafka/server/NodeToControllerChannelManager.scala: ## @@ -52,37 +51,6 @@ trait ControllerNodeProvider { def getControllerInfo(): ControllerIn

Re: [PR] KAFKA-18445: Remove LazyDownConversionRecords and LazyDownConversionRecordsSend [kafka]

2025-01-08 Thread via GitHub
chia7712 commented on code in PR #18445: URL: https://github.com/apache/kafka/pull/18445#discussion_r1908113186 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -203,8 +203,7 @@ public static FetchResponseData.PartitionData partitionResponse(i

Re: [PR] KAFKA-18446:Remove MetadataCacheControllerNodeProvider [kafka]

2025-01-08 Thread via GitHub
gongxuanzhang commented on PR #18437: URL: https://github.com/apache/kafka/pull/18437#issuecomment-2579096337 @chia7712 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-806: Index may not always observe log.index.interval.bytes [kafka]

2025-01-08 Thread via GitHub
chia7712 commented on code in PR #18012: URL: https://github.com/apache/kafka/pull/18012#discussion_r1908110068 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -257,13 +257,21 @@ public void append(long largestOffset, if (large

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (5/N): ELECT_LEADERS , ALTER_PARTITION, UPDATE_FEATURES [kafka]

2025-01-08 Thread via GitHub
TaiJuWu commented on code in PR #18453: URL: https://github.com/apache/kafka/pull/18453#discussion_r1908109040 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -238,7 +247,7 @@ class KafkaApis(val requestChannel: RequestChannel, case ApiKeys.EXPIRE_DELEGATION_

[PR] KAFKA-18399 Remove ZooKeeper from KafkaApis (5/N): ELECT_LEADERS , ALTER_PARTITION, UPDATE_FEATURES [kafka]

2025-01-08 Thread via GitHub
TaiJuWu opened a new pull request, #18453: URL: https://github.com/apache/kafka/pull/18453 remove follow handler within KafkaApis - ELECT_LEADERS - ALTER_PARTITION - UPDATE_FEATURES ### Committer Checklist (excluded from commit message) - [ ] Verify design and implement

Re: [PR] KAFKA-18435: Remove zookeeper dependencies in build.gradle [kafka]

2025-01-08 Thread via GitHub
m1a2st commented on code in PR #18450: URL: https://github.com/apache/kafka/pull/18450#discussion_r1908103404 ## core/src/main/scala/kafka/zk/KafkaZkClient.scala: ## @@ -53,28 +37,9 @@ import scala.jdk.CollectionConverters._ * easier to migrate away from `ZkUtils` (since remov

Re: [PR] KAFKA-806: Index may not always observe log.index.interval.bytes [kafka]

2025-01-08 Thread via GitHub
chia7712 commented on code in PR #18012: URL: https://github.com/apache/kafka/pull/18012#discussion_r1908095683 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -253,17 +253,33 @@ public void append(long largestOffset, // append

[jira] [Resolved] (KAFKA-18435) Remove zookeeper dependencies in build.gradle

2025-01-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18435. Resolution: Fixed trunk: https://github.com/apache/kafka/commit/c28d9a348670f9efc599b4813

Re: [PR] [WIP] MINOR: CI testing for v3.5.3 [kafka]

2025-01-08 Thread via GitHub
showuon closed pull request #16630: [WIP] MINOR: CI testing for v3.5.3 URL: https://github.com/apache/kafka/pull/16630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] MINOR: add logs when connection count exceeds configured count [kafka]

2025-01-08 Thread via GitHub
showuon closed pull request #12559: MINOR: add logs when connection count exceeds configured count URL: https://github.com/apache/kafka/pull/12559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-13370: add unit test for offset-commit metrics [kafka]

2025-01-08 Thread via GitHub
showuon closed pull request #11509: KAFKA-13370: add unit test for offset-commit metrics URL: https://github.com/apache/kafka/pull/11509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-13108: improve ConfigCommandTest test coverage [kafka]

2025-01-08 Thread via GitHub
showuon closed pull request #11147: KAFKA-13108: improve ConfigCommandTest test coverage URL: https://github.com/apache/kafka/pull/11147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Assigned] (KAFKA-18455) Add logs or metrics when connection count exceeds

2025-01-08 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-18455: - Assignee: TengYao Chi > Add logs or metrics when connection count exceeds > ---

[jira] [Commented] (KAFKA-18455) Add logs or metrics when connection count exceeds

2025-01-08 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911298#comment-17911298 ] Luke Chen commented on KAFKA-18455: --- Assigned to you [~frankvicky] ! Thanks. > Add lo

[jira] [Commented] (KAFKA-18455) Add logs or metrics when connection count exceeds

2025-01-08 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911297#comment-17911297 ] TengYao Chi commented on KAFKA-18455: - Hi [~showuon]  May I take over this issue ?

Re: [PR] KAFKA-18435: Remove zookeeper dependencies in build.gradle [kafka]

2025-01-08 Thread via GitHub
chia7712 merged PR #18450: URL: https://github.com/apache/kafka/pull/18450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18435: Remove zookeeper dependencies in build.gradle [kafka]

2025-01-08 Thread via GitHub
chia7712 commented on code in PR #18450: URL: https://github.com/apache/kafka/pull/18450#discussion_r1908070818 ## core/src/main/scala/kafka/zk/KafkaZkClient.scala: ## @@ -53,28 +37,9 @@ import scala.jdk.CollectionConverters._ * easier to migrate away from `ZkUtils` (since rem

[jira] [Created] (KAFKA-18456) Fix flaky PlaintextConsumerPollTest#testMaxPollIntervalMsShorterThanPollTimeout

2025-01-08 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18456: -- Summary: Fix flaky PlaintextConsumerPollTest#testMaxPollIntervalMsShorterThanPollTimeout Key: KAFKA-18456 URL: https://issues.apache.org/jira/browse/KAFKA-18456 P

[jira] [Created] (KAFKA-18455) Add logs or metrics when connection count exceeds

2025-01-08 Thread Luke Chen (Jira)
Luke Chen created KAFKA-18455: - Summary: Add logs or metrics when connection count exceeds Key: KAFKA-18455 URL: https://issues.apache.org/jira/browse/KAFKA-18455 Project: Kafka Issue Type: Impro

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis with handleCreateTokenRequest, handleRenewTokenRequestZk, handleExpireTokenRequestZk (3/N)… [kafka]

2025-01-08 Thread via GitHub
TaiJuWu commented on code in PR #18447: URL: https://github.com/apache/kafka/pull/18447#discussion_r1908077543 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3066,40 +2962,7 @@ class KafkaApis(val requestChannel: RequestChannel, .setErrorCode(Errors.D

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis with handleCreateTokenRequest, handleRenewTokenRequestZk, handleExpireTokenRequestZk (3/N)… [kafka]

2025-01-08 Thread via GitHub
TaiJuWu commented on code in PR #18447: URL: https://github.com/apache/kafka/pull/18447#discussion_r1908077458 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3020,40 +2949,7 @@ class KafkaApis(val requestChannel: RequestChannel, .setErrorCode(Errors.D

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis with handleCreateTokenRequest, handleRenewTokenRequestZk, handleExpireTokenRequestZk (3/N)… [kafka]

2025-01-08 Thread via GitHub
TaiJuWu commented on code in PR #18447: URL: https://github.com/apache/kafka/pull/18447#discussion_r1908074550 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -233,7 +232,7 @@ class KafkaApis(val requestChannel: RequestChannel, case ApiKeys.CREATE_PARTITIONS

Re: [PR] KAFKA-18399 Remove ZooKeeper from KafkaApis with handleCreateTokenRequest, handleRenewTokenRequestZk, handleExpireTokenRequestZk (3/N)… [kafka]

2025-01-08 Thread via GitHub
TaiJuWu commented on code in PR #18447: URL: https://github.com/apache/kafka/pull/18447#discussion_r1908074550 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -233,7 +232,7 @@ class KafkaApis(val requestChannel: RequestChannel, case ApiKeys.CREATE_PARTITIONS

Re: [PR] MINOR: Skip snapshot header footer [kafka]

2025-01-08 Thread via GitHub
showuon closed pull request #12711: MINOR: Skip snapshot header footer URL: https://github.com/apache/kafka/pull/12711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] MINOR: set test global timeout as 10 mins [kafka]

2025-01-08 Thread via GitHub
showuon closed pull request #15065: MINOR: set test global timeout as 10 mins URL: https://github.com/apache/kafka/pull/15065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-14284: fix "current-vote" metric in leader state [kafka]

2025-01-08 Thread via GitHub
showuon closed pull request #12724: KAFKA-14284: fix "current-vote" metric in leader state URL: https://github.com/apache/kafka/pull/12724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [WIP]MINOR: Find test [kafka]

2025-01-08 Thread via GitHub
showuon closed pull request #14452: [WIP]MINOR: Find test URL: https://github.com/apache/kafka/pull/14452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] [WIP] MINOR: fix flaky test [kafka]

2025-01-08 Thread via GitHub
showuon closed pull request #15052: [WIP] MINOR: fix flaky test URL: https://github.com/apache/kafka/pull/15052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-01-08 Thread via GitHub
kirktrue commented on PR #17700: URL: https://github.com/apache/kafka/pull/17700#issuecomment-2579018868 > @kirktrue : Thanks for the reply. For latency, I was thinking about the end-to-end latency, i.e. the time from a record is published to the time it's consumed. Since option 4 reduces t

Re: [PR] KAFKA-17455: fix stuck producer when throttling or retrying [kafka]

2025-01-08 Thread via GitHub
coltmcnealy-lh commented on PR #17527: URL: https://github.com/apache/kafka/pull/17527#issuecomment-2579020258 @dajac writes: > I suppose that the test passes with new MockTime(1L) because the new time is not used by the client. The client must be created after the time is set. Would it

[jira] [Closed] (KAFKA-18112) Add Kafka Logo to README

2025-01-08 Thread Swikar Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swikar Patel closed KAFKA-18112. > Add Kafka Logo to README > > > Key: KAFKA-18112 >

[jira] [Closed] (KAFKA-18111) Add Kafka Logo to README

2025-01-08 Thread Swikar Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swikar Patel closed KAFKA-18111. > Add Kafka Logo to README > > > Key: KAFKA-18111 >

[jira] [Commented] (KAFKA-17825) ByteBufferDeserializaer's array size can be inconsistent with the older version

2025-01-08 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911280#comment-17911280 ] Chris Egerton commented on KAFKA-17825: --- IMO this is an acceptable change as-is. U

[jira] [Resolved] (KAFKA-18112) Add Kafka Logo to README

2025-01-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-18112. - Resolution: Fixed > Add Kafka Logo to README > > >

[jira] [Resolved] (KAFKA-18111) Add Kafka Logo to README

2025-01-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-18111. - Resolution: Fixed > Add Kafka Logo to README > > >

Re: [PR] KAFKA-18446:Remove MetadataCacheControllerNodeProvider [kafka]

2025-01-08 Thread via GitHub
gongxuanzhang closed pull request #18437: KAFKA-18446:Remove MetadataCacheControllerNodeProvider URL: https://github.com/apache/kafka/pull/18437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] KAFKA-18111: Add Kafka Logo to README [kafka]

2025-01-08 Thread via GitHub
mjsax commented on PR #18452: URL: https://github.com/apache/kafka/pull/18452#issuecomment-2579004759 Thanks for the PR. Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] KAFKA-18111: Add Kafka Logo to README [kafka]

2025-01-08 Thread via GitHub
mjsax merged PR #18452: URL: https://github.com/apache/kafka/pull/18452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-18418: Use CDL to block the thread termination to avoid flaky tests [kafka]

2025-01-08 Thread via GitHub
mjsax commented on code in PR #18418: URL: https://github.com/apache/kafka/pull/18418#discussion_r1908056183 ## streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java: ## @@ -1324,8 +1361,7 @@ public void shouldGetClientSupplierFromConfigForConstructor() throws Ex

Re: [PR] KAFKA-18418: Use CDL to block the thread termination to avoid flaky tests [kafka]

2025-01-08 Thread via GitHub
mjsax commented on code in PR #18418: URL: https://github.com/apache/kafka/pull/18418#discussion_r1908056380 ## streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java: ## @@ -957,6 +960,7 @@ public void shouldThrowOnCleanupWhileShuttingDown() throws Exception {

[jira] [Comment Edited] (KAFKA-17635) Lost events on internal repartition topic when excatly_once_v2 is set and producer is fenced

2025-01-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911275#comment-17911275 ] A. Sophie Blee-Goldman edited comment on KAFKA-17635 at 1/9/25 1:03 AM: --

[jira] [Commented] (KAFKA-17635) Lost events on internal repartition topic when excatly_once_v2 is set and producer is fenced

2025-01-08 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911275#comment-17911275 ] A. Sophie Blee-Goldman commented on KAFKA-17635: Nice find! Seems like a

Re: [PR] MINOR Remove needs-attention label after review [kafka]

2025-01-08 Thread via GitHub
mumrah merged PR #18366: URL: https://github.com/apache/kafka/pull/18366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-18111: Add Kafka Logo to README [kafka]

2025-01-08 Thread via GitHub
swikarpat commented on PR #18452: URL: https://github.com/apache/kafka/pull/18452#issuecomment-2578928606 @mjsax As Kafka latest version going to release I was thinking to add nice kafka logo. See attached screenshot it looks like. https://github.com/user-attachments/assets/d841790d-5a53-

Re: [PR] KAFKA-18211: Override class loaders for class graph scanning in connect. [kafka]

2025-01-08 Thread via GitHub
gharris1727 commented on code in PR #18403: URL: https://github.com/apache/kafka/pull/18403#discussion_r1907898181 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/TestPlugins.java: ## @@ -251,7 +252,11 @@ public enum TestPlugin { /**

[PR] KAFKA-18111: Add Kafka Logo to README [kafka]

2025-01-08 Thread via GitHub
swikarpat opened a new pull request, #18452: URL: https://github.com/apache/kafka/pull/18452 Added Kafka logo to Readme.md ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

Re: [PR] KAFKA-17915: Convert remaining Kafka Client system tests to use KRaft [kafka]

2025-01-08 Thread via GitHub
kevin-wu24 commented on PR #18367: URL: https://github.com/apache/kafka/pull/18367#issuecomment-2578880597 Thanks for the review @lianetm! > Regarding the quota_test, since is being migrated to kraft with this PR, should we revise the `force_use_zk_connection` param it's still using?

Re: [PR] KAFKA-806: Index may not always observe log.index.interval.bytes [kafka]

2025-01-08 Thread via GitHub
junrao commented on code in PR #18012: URL: https://github.com/apache/kafka/pull/18012#discussion_r1907970044 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java: ## @@ -257,13 +257,21 @@ public void append(long largestOffset, if (largest

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-01-08 Thread via GitHub
ableegoldman commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1907960162 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1114,22 +1115,26 @@ private boolean isProtocolTypeInconsisten

Re: [PR] MINOR: improve StreamThread periodic processing log [kafka]

2025-01-08 Thread via GitHub
ableegoldman commented on code in PR #18430: URL: https://github.com/apache/kafka/pull/18430#discussion_r1907956818 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -1075,12 +1077,14 @@ void runOnceWithoutProcessingThreads() {

Re: [PR] MINOR: improve StreamThread periodic processing log [kafka]

2025-01-08 Thread via GitHub
ableegoldman commented on code in PR #18430: URL: https://github.com/apache/kafka/pull/18430#discussion_r1907956445 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -1075,12 +1077,14 @@ void runOnceWithoutProcessingThreads() {

Re: [PR] MINOR: improve StreamThread periodic processing log [kafka]

2025-01-08 Thread via GitHub
ableegoldman commented on code in PR #18430: URL: https://github.com/apache/kafka/pull/18430#discussion_r1907953698 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -1075,12 +1077,14 @@ void runOnceWithoutProcessingThreads() {

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-01-08 Thread via GitHub
junrao commented on PR #17700: URL: https://github.com/apache/kafka/pull/17700#issuecomment-2578830900 @kirktrue : Thanks for the reply. For latency, I was thinking about the end-to-end latency, i.e. the time from a record is published to the time it's consumed. Since option 4 reduces the p

[PR] WIP: KAFKA-18035 [kafka]

2025-01-08 Thread via GitHub
jolshan opened a new pull request, #18451: URL: https://github.com/apache/kafka/pull/18451 debugging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] KAFKA-18035: TransactionsTest testBumpTransactionalEpochWithTV2Disabled failed on trunk [kafka]

2025-01-08 Thread via GitHub
jolshan closed pull request #17852: KAFKA-18035: TransactionsTest testBumpTransactionalEpochWithTV2Disabled failed on trunk URL: https://github.com/apache/kafka/pull/17852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-01-08 Thread via GitHub
kirktrue commented on PR #17700: URL: https://github.com/apache/kafka/pull/17700#issuecomment-2578802259 > Hey @kirktrue, how do we want to push this forward? Should we review this Draft? @lianetm—We need consensus on whether option 4 is the best path forward or not. The PR is

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

2025-01-08 Thread via GitHub
kirktrue commented on PR #17700: URL: https://github.com/apache/kafka/pull/17700#issuecomment-2578784450 > @kirktrue : Thanks for the experimental results. What's the reason for the high eviction rate at the beginning of all tests? Four warm-up runs are executed before the test, and t

Re: [PR] KAFKA-18150: Downgrade group on classic leave of last consumer member [kafka]

2025-01-08 Thread via GitHub
squah-confluent commented on PR #18224: URL: https://github.com/apache/kafka/pull/18224#issuecomment-2578783735 @dajac Thanks for taking a look! I've updated the PR based on feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] KAFKA-18150: Downgrade group on classic leave of last consumer member [kafka]

2025-01-08 Thread via GitHub
squah-confluent commented on code in PR #18224: URL: https://github.com/apache/kafka/pull/18224#discussion_r1907929701 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java: ## @@ -1336,21 +1336,21 @@ public Map groupAssignment() {

Re: [PR] KAFKA-18150: Downgrade group on classic leave of last consumer member [kafka]

2025-01-08 Thread via GitHub
squah-confluent commented on code in PR #18224: URL: https://github.com/apache/kafka/pull/18224#discussion_r1907920061 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/ConsumerGroup.java: ## @@ -1263,6 +1263,21 @@ public boolean allMembersUse

Re: [PR] KAFKA-18150: Downgrade group on classic leave of last consumer member [kafka]

2025-01-08 Thread via GitHub
squah-confluent commented on code in PR #18224: URL: https://github.com/apache/kafka/pull/18224#discussion_r1907918895 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -6091,30 +6096,41 @@ private CoordinatorResult classicGro

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-01-08 Thread via GitHub
ableegoldman commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1907910093 ## clients/src/main/java/org/apache/kafka/clients/consumer/GroupMembershipOperation.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] KAFKA-18435: Remove zookeeper dependencies in build.gradle [kafka]

2025-01-08 Thread via GitHub
cmccabe commented on code in PR #18450: URL: https://github.com/apache/kafka/pull/18450#discussion_r1907916903 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -1476,7 +1484,8 @@ class KRaftClusterTest { val parentDir = log.parentDir

Re: [PR] KAFKA-18435: Remove zookeeper dependencies in build.gradle [kafka]

2025-01-08 Thread via GitHub
cmccabe commented on code in PR #18450: URL: https://github.com/apache/kafka/pull/18450#discussion_r1907916903 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -1476,7 +1484,8 @@ class KRaftClusterTest { val parentDir = log.parentDir

Re: [PR] KAFKA-18435: Remove zookeeper dependencies in build.gradle [kafka]

2025-01-08 Thread via GitHub
ijuma commented on code in PR #18450: URL: https://github.com/apache/kafka/pull/18450#discussion_r1907911940 ## core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala: ## @@ -1476,7 +1484,8 @@ class KRaftClusterTest { val parentDir = log.parentDir

Re: [PR] KAFKA-16758: Extend Consumer#close with an option to leave the group or not [kafka]

2025-01-08 Thread via GitHub
ableegoldman commented on code in PR #17614: URL: https://github.com/apache/kafka/pull/17614#discussion_r1907911078 ## clients/src/main/java/org/apache/kafka/clients/consumer/CloseOption.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-16540: enforce min.insync.replicas config invariants for ELR [kafka]

2025-01-08 Thread via GitHub
cmccabe merged PR #17952: URL: https://github.com/apache/kafka/pull/17952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-18211: Override class loaders for class graph scanning in connect. [kafka]

2025-01-08 Thread via GitHub
snehashisp commented on code in PR #18403: URL: https://github.com/apache/kafka/pull/18403#discussion_r1907895838 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginScannerTest.java: ## @@ -137,6 +139,17 @@ public void testVersionedPluginsHasVersio

[jira] [Commented] (KAFKA-18435) Remove zookeeper dependencies in build.gradle

2025-01-08 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911243#comment-17911243 ] Colin McCabe commented on KAFKA-18435: -- Marking as 4.0 blocker. cc [~dajac] > Remo

[jira] [Assigned] (KAFKA-18435) Remove zookeeper dependencies in build.gradle

2025-01-08 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe reassigned KAFKA-18435: Assignee: Colin McCabe (was: 黃竣陽) > Remove zookeeper dependencies in build.gradle >

[jira] [Updated] (KAFKA-18435) Remove zookeeper dependencies in build.gradle

2025-01-08 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-18435: - Fix Version/s: 4.0.0 Affects Version/s: 4.0.0 Priority: Blocker (was: Major

[PR] KAFKA-18435: Remove zookeeper dependencies in build.gradle [kafka]

2025-01-08 Thread via GitHub
cmccabe opened a new pull request, #18450: URL: https://github.com/apache/kafka/pull/18450 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] KAFKA-17671: Create better documentation for transactions [kafka]

2025-01-08 Thread via GitHub
AndrewJSchofield commented on code in PR #17454: URL: https://github.com/apache/kafka/pull/17454#discussion_r1907876806 ## docs/design.html: ## @@ -290,24 +290,58 @@ https://kafka.apache.org/documentation/streams";>Kafka Streams -application), we can leverage the new transac

Re: [PR] KAFKA-17671: Create better documentation for transactions [kafka]

2025-01-08 Thread via GitHub
AndrewJSchofield commented on code in PR #17454: URL: https://github.com/apache/kafka/pull/17454#discussion_r1907876128 ## docs/design.html: ## @@ -290,24 +290,58 @@ https://kafka.apache.org/documentation/streams";>Kafka Streams -application), we can leverage the new transac

Re: [PR] KAFKA-18073: Prevent dropped records from failed retriable exceptions [kafka]

2025-01-08 Thread via GitHub
gharris1727 commented on code in PR #18146: URL: https://github.com/apache/kafka/pull/18146#discussion_r1907854665 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTestUtils.java: ## @@ -155,4 +165,29 @@ public static void assertAssignment(boolean expectFa

Re: [PR] KAFKA-17671: Create better documentation for transactions [kafka]

2025-01-08 Thread via GitHub
AndrewJSchofield commented on code in PR #17454: URL: https://github.com/apache/kafka/pull/17454#discussion_r1907866806 ## docs/design.html: ## @@ -290,24 +290,56 @@ https://kafka.apache.org/documentation/streams";>Kafka Streams -application), we can leverage the new transac

Re: [PR] KAFKA-18311: Configuring repartition topics (3/N) [kafka]

2025-01-08 Thread via GitHub
lucasbru commented on code in PR #18395: URL: https://github.com/apache/kafka/pull/18395#discussion_r1907842225 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/topics/RepartitionTopicsTest.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache So

Re: [PR] KAFKA-18311: Configuring repartition topics (3/N) [kafka]

2025-01-08 Thread via GitHub
lucasbru commented on code in PR #18395: URL: https://github.com/apache/kafka/pull/18395#discussion_r1907840618 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/topics/RepartitionTopicsTest.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache So

Re: [PR] KAFKA-18311: Configuring repartition topics (3/N) [kafka]

2025-01-08 Thread via GitHub
lucasbru commented on code in PR #18395: URL: https://github.com/apache/kafka/pull/18395#discussion_r1907835468 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/topics/RepartitionTopicsTest.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache So

Re: [PR] KAFKA-18311: Configuring repartition topics (3/N) [kafka]

2025-01-08 Thread via GitHub
lucasbru commented on code in PR #18395: URL: https://github.com/apache/kafka/pull/18395#discussion_r1907830474 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/topics/RepartitionTopicsTest.java: ## @@ -0,0 +1,273 @@ +/* + * Licensed to the Apache So

[jira] [Commented] (KAFKA-18333) Simulation test should include invariant that quorum state never loses state

2025-01-08 Thread Alyssa Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911224#comment-17911224 ] Alyssa Huang commented on KAFKA-18333: -- I'm not working on this currently, this may

[PR] Checking on the gradle cache [kafka]

2025-01-08 Thread via GitHub
mumrah opened a new pull request, #18449: URL: https://github.com/apache/kafka/pull/18449 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] KAFKA-18274: Failed to restart controller in testing due to closed socket channel [2/2] [kafka]

2025-01-08 Thread via GitHub
chia7712 commented on code in PR #18337: URL: https://github.com/apache/kafka/pull/18337#discussion_r1907688757 ## test-common/test-common-api/src/test/java/org/apache/kafka/common/test/api/ClusterTestExtensionsTest.java: ## @@ -347,6 +349,20 @@ public void testControllerListene

  1   2   3   >