[jira] [Commented] (KAFKA-17616) Remove KafkaServer

2024-12-30 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909027#comment-17909027 ] PoAn Yang commented on KAFKA-17616: --- Hi [~cmccabe], it looks like most of references t

[jira] [Assigned] (KAFKA-17691) Remove KafkaServer references in tools tests

2024-12-30 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-17691: --- Assignee: TengYao Chi > Remove KafkaServer references in tools tests >

Re: [PR] KAFKA-18353: Remove zk config `control.plane.listener.name` [kafka]

2024-12-30 Thread via GitHub
chia7712 commented on code in PR #18329: URL: https://github.com/apache/kafka/pull/18329#discussion_r1899919726 ## docs/upgrade.html: ## @@ -65,6 +65,8 @@ Notable changes in 4 The function onNewBatch in org.apache.kafka.clients

[PR] MINOR: Remove PaswwordEncoderConfig related entries from upgrade.html [kafka]

2024-12-30 Thread via GitHub
frankvicky opened a new pull request, #18362: URL: https://github.com/apache/kafka/pull/18362 Please refer to https://github.com/apache/kafka/pull/18329?notification_referrer_id=NT_kwDOAwtMyLQxNDAyOTM2OTE0NTo1MTA3MjIwMA#discussion_r1899677248 for further details. ### Committer Checkl

Re: [PR] KAFKA-18225: ClientQuotaCallback#updateClusterMetadata is unsupported by kraft [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18196: URL: https://github.com/apache/kafka/pull/18196#discussion_r1899937001 ## core/src/main/scala/kafka/server/metadata/DynamicClientQuotaPublisher.scala: ## @@ -48,6 +51,11 @@ class DynamicClientQuotaPublisher( ): Unit = { val deltaNa

[jira] [Commented] (KAFKA-17212) Segments containing a single message can be incorrectly marked as local only

2024-12-30 Thread Guang Zhao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909012#comment-17909012 ] Guang Zhao commented on KAFKA-17212: Hi [~guillaumemallet], can I look into this iss

Re: [PR] KAFKA-18353: Remove zk config `control.plane.listener.name` [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18329: URL: https://github.com/apache/kafka/pull/18329#discussion_r1899916566 ## docs/upgrade.html: ## @@ -65,6 +65,8 @@ Notable changes in 4 The function onNewBatch in org.apache.kafka.clients.

Re: [PR] KAFKA-17421: Add IT for ConsumerRecord#leaderEpoch [kafka]

2024-12-30 Thread via GitHub
xijiu commented on code in PR #18254: URL: https://github.com/apache/kafka/pull/18254#discussion_r1899921489 ## test-common/test-common-api/src/main/java/org/apache/kafka/common/test/api/RaftClusterInvocationContext.java: ## @@ -222,6 +228,24 @@ public void waitForReadyBrokers()

Re: [PR] KAFKA-18353: Remove zk config `control.plane.listener.name` [kafka]

2024-12-30 Thread via GitHub
chia7712 commented on code in PR #18329: URL: https://github.com/apache/kafka/pull/18329#discussion_r1899919726 ## docs/upgrade.html: ## @@ -65,6 +65,8 @@ Notable changes in 4 The function onNewBatch in org.apache.kafka.clients

Re: [PR] MINOR: KAFKA-18280 follow up [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18358: URL: https://github.com/apache/kafka/pull/18358#discussion_r1899915353 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -593,6 +593,9 @@ def close_port(self, listener_name): def start_minikdc_if_necessary(self, add_principals=""):

Re: [PR] MINOR: KAFKA-18280 follow up [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18358: URL: https://github.com/apache/kafka/pull/18358#discussion_r1899915353 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -593,6 +593,9 @@ def close_port(self, listener_name): def start_minikdc_if_necessary(self, add_principals=""):

Re: [PR] MINOR: KAFKA-18280 follow up [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18358: URL: https://github.com/apache/kafka/pull/18358#discussion_r1899915353 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -593,6 +593,9 @@ def close_port(self, listener_name): def start_minikdc_if_necessary(self, add_principals=""):

Re: [PR] MINOR: KAFKA-18280 follow up [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18358: URL: https://github.com/apache/kafka/pull/18358#discussion_r1899915353 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -593,6 +593,9 @@ def close_port(self, listener_name): def start_minikdc_if_necessary(self, add_principals=""):

Re: [PR] KAFKA-18353: Remove zk config `control.plane.listener.name` [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18329: URL: https://github.com/apache/kafka/pull/18329#discussion_r1899916566 ## docs/upgrade.html: ## @@ -65,6 +65,8 @@ Notable changes in 4 The function onNewBatch in org.apache.kafka.clients.

Re: [PR] MINOR: KAFKA-18280 follow up [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18358: URL: https://github.com/apache/kafka/pull/18358#discussion_r1899915353 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -593,6 +593,9 @@ def close_port(self, listener_name): def start_minikdc_if_necessary(self, add_principals=""):

Re: [PR] KAFKA-13303, KAFKA-9965: Enhancments for Roun Robing Partitioner and fix of uneven distribution [kafka]

2024-12-30 Thread via GitHub
ijuma commented on PR #17977: URL: https://github.com/apache/kafka/pull/17977#issuecomment-2566127779 @artemlivshits do you have cycles to review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] KAFKA-18353: Remove zk config `control.plane.listener.name` [kafka]

2024-12-30 Thread via GitHub
ijuma commented on code in PR #18329: URL: https://github.com/apache/kafka/pull/18329#discussion_r1899912094 ## docs/upgrade.html: ## @@ -65,6 +65,8 @@ Notable changes in 4 The function onNewBatch in org.apache.kafka.clients.pr

Re: [PR] MINOR: KAFKA-18280 follow up [kafka]

2024-12-30 Thread via GitHub
ijuma commented on code in PR #18358: URL: https://github.com/apache/kafka/pull/18358#discussion_r1899911671 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -593,6 +593,9 @@ def close_port(self, listener_name): def start_minikdc_if_necessary(self, add_principals=""):

Re: [PR] Allow replace all for RegexRouter [kafka]

2024-12-30 Thread via GitHub
github-actions[bot] closed pull request #9176: Allow replace all for RegexRouter URL: https://github.com/apache/kafka/pull/9176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-18277: fix e2e network_degrade_test [kafka]

2024-12-30 Thread via GitHub
github-actions[bot] commented on PR #18247: URL: https://github.com/apache/kafka/pull/18247#issuecomment-2566104309 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] Allow replace all for RegexRouter [kafka]

2024-12-30 Thread via GitHub
github-actions[bot] commented on PR #9176: URL: https://github.com/apache/kafka/pull/9176#issuecomment-2566104298 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to r

Re: [PR] KAFKA-16524: Metrics for KIP-853 [kafka]

2024-12-30 Thread via GitHub
github-actions[bot] commented on PR #18304: URL: https://github.com/apache/kafka/pull/18304#issuecomment-2566104295 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[PR] MINOR: Remove PureJavaCrc32C and reflective code for CRC32C [kafka]

2024-12-30 Thread via GitHub
ijuma opened a new pull request, #18361: URL: https://github.com/apache/kafka/pull/18361 This is no longer required since we dropped support for Java 8. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and C

[jira] [Commented] (KAFKA-17825) ByteBufferDeserializaer's array size can be inconsistent with the older version

2024-12-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909000#comment-17909000 ] Matthias J. Sax commented on KAFKA-17825: - I dug into this, and I am actually no

[PR] [WIP] KIP-891: Multiversioning in Kafka Connect - Connector Multiversion Integration Test [kafka]

2024-12-30 Thread via GitHub
snehashisp opened a new pull request, #18360: URL: https://github.com/apache/kafka/pull/18360 This adds tests for [KIP-891](https://cwiki.apache.org/confluence/display/KAFKA/KIP-891%3A+Running+multiple+versions+of+Connector+plugins). . This adds integration tests. It has dependency on the a

[PR] KAFKA-18375: Update the LICENSE-binary [kafka]

2024-12-30 Thread via GitHub
xijiu opened a new pull request, #18359: URL: https://github.com/apache/kafka/pull/18359 As title. ![image](https://github.com/user-attachments/assets/1434686f-36bb-4f66-8e75-fd1984ac6748) ### Committer Checklist (excluded from commit message) - [ ] Verify design and imp

[jira] [Created] (KAFKA-18383) Remove reserved.broker.max.id, broker.id.generation.enable, and broker.id

2024-12-30 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-18383: - Summary: Remove reserved.broker.max.id, broker.id.generation.enable, and broker.id Key: KAFKA-18383 URL: https://issues.apache.org/jira/browse/KAFKA-18383 Project: Kafka

[jira] [Assigned] (KAFKA-18381) Remove raftSupport in KafkaApisTest

2024-12-30 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-18381: - Assignee: (was: PoAn Yang) > Remove raftSupport in KafkaApisTest >

[jira] [Assigned] (KAFKA-18382) Change KafkaConfigTest to use kraft config

2024-12-30 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-18382: - Assignee: (was: PoAn Yang) > Change KafkaConfigTest to use kraft config > -

[jira] [Resolved] (KAFKA-18382) Change KafkaConfigTest to use kraft config

2024-12-30 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang resolved KAFKA-18382. --- Resolution: Duplicate > Change KafkaConfigTest to use kraft config > ---

[jira] [Created] (KAFKA-18382) Change KafkaConfigTest to use kraft config

2024-12-30 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-18382: - Summary: Change KafkaConfigTest to use kraft config Key: KAFKA-18382 URL: https://issues.apache.org/jira/browse/KAFKA-18382 Project: Kafka Issue Type: Sub-task

[jira] [Resolved] (KAFKA-18381) Remove raftSupport in KafkaApisTest

2024-12-30 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang resolved KAFKA-18381. --- Resolution: Duplicate > Remove raftSupport in KafkaApisTest > --- >

[jira] [Created] (KAFKA-18381) Remove raftSupport in KafkaApisTest

2024-12-30 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-18381: - Summary: Remove raftSupport in KafkaApisTest Key: KAFKA-18381 URL: https://issues.apache.org/jira/browse/KAFKA-18381 Project: Kafka Issue Type: Sub-task

Re: [PR] MINOR: KAFKA-18280 follow up [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on PR #18358: URL: https://github.com/apache/kafka/pull/18358#issuecomment-2566059958 @chia7712 @ijuma Could you take a look when you are available? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] MINOR: KAFKA-18280 follow up [kafka]

2024-12-30 Thread via GitHub
TaiJuWu opened a new pull request, #18358: URL: https://github.com/apache/kafka/pull/18358 see https://github.com/apache/kafka/pull/18308#discussion_r1899834438 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test covera

[jira] [Commented] (KAFKA-18375) Update the LICENSE-binary

2024-12-30 Thread kangning.li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908995#comment-17908995 ] kangning.li commented on KAFKA-18375: - [~chia7712]   If you have not started working

Re: [PR] KAFKA-18368 Remove TestUtils#MockZkConnect and remove zkConnect from TestUtils#createBrokerConfig [kafka]

2024-12-30 Thread via GitHub
m1a2st commented on PR #18352: URL: https://github.com/apache/kafka/pull/18352#issuecomment-2566044157 Thanks for @chia7712 comment, I open a Jira to trace it. https://issues.apache.org/jira/browse/KAFKA-18380 -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] MINOR Remove some flaky annotations [kafka]

2024-12-30 Thread via GitHub
mumrah commented on PR #18357: URL: https://github.com/apache/kafka/pull/18357#issuecomment-2566042782 https://github.com/apache/kafka/actions/runs/12542607476 was the report used -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] MINOR Remove some flaky annotations [kafka]

2024-12-30 Thread via GitHub
mumrah opened a new pull request, #18357: URL: https://github.com/apache/kafka/pull/18357 Thanks to the efforts of the community, several flaky tests have been fixed recently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Updated] (KAFKA-18380) Remove KafkaApisTest `raftSupport` and change test to Kraft mode

2024-12-30 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 updated KAFKA-18380: Parent: KAFKA-18261 Issue Type: Sub-task (was: Improvement) > Remove KafkaApisTest `raftSupport` and chan

[jira] [Created] (KAFKA-18380) Remove KafkaApisTest `raftSupport` and change test to Kraft mode

2024-12-30 Thread Jira
黃竣陽 created KAFKA-18380: --- Summary: Remove KafkaApisTest `raftSupport` and change test to Kraft mode Key: KAFKA-18380 URL: https://issues.apache.org/jira/browse/KAFKA-18380 Project: Kafka Issue Type: I

[PR] Feature/arch analysis [kafka]

2024-12-30 Thread via GitHub
Jacck opened a new pull request, #18356: URL: https://github.com/apache/kafka/pull/18356 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing s

Re: [PR] KAFKA-18280:fix e2e TestSecurityRollingUpgrade.test_rolling_upgrade_sasl_mechanism_phase_one [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18308: URL: https://github.com/apache/kafka/pull/18308#discussion_r1899859550 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -602,12 +602,6 @@ def start_minikdc_if_necessary(self, add_principals=""): nodes_for_kdc += o

Re: [PR] KAFKA-18347: Add tools-log4j2.yaml to config and remove unsed tools-log4j.properties from config [kafka]

2024-12-30 Thread via GitHub
frankvicky commented on PR #18351: URL: https://github.com/apache/kafka/pull/18351#issuecomment-2565999202 Hi @chia7712 Could you please take a look ? Many thanks 😸 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Commented] (KAFKA-18378) standardize raft quorum state transitions

2024-12-30 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908990#comment-17908990 ] TengYao Chi commented on KAFKA-18378: - Hi [~alyssahuang]  I would take over this on

[jira] [Assigned] (KAFKA-18378) standardize raft quorum state transitions

2024-12-30 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18378: --- Assignee: TengYao Chi > standardize raft quorum state transitions > ---

[jira] [Commented] (KAFKA-18377) pollResigned can short circuit to unattached on receiving all endquorum acks

2024-12-30 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908989#comment-17908989 ] TengYao Chi commented on KAFKA-18377: - Hi [~alyssahuang]  I would take a look at th

[jira] [Assigned] (KAFKA-18377) pollResigned can short circuit to unattached on receiving all endquorum acks

2024-12-30 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18377: --- Assignee: TengYao Chi > pollResigned can short circuit to unattached on receiving all endqu

[jira] [Commented] (KAFKA-18379) Enforce resigned cannot transition to any other state in same epoch

2024-12-30 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908988#comment-17908988 ] TengYao Chi commented on KAFKA-18379: - Hi [~alyssahuang]  I would take over this is

[jira] [Assigned] (KAFKA-18379) Enforce resigned cannot transition to any other state in same epoch

2024-12-30 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18379: --- Assignee: TengYao Chi > Enforce resigned cannot transition to any other state in same epoch

Re: [PR] MINOR: Fix logging with exception trace for AbstractHerder#validateConverterConfig [kafka]

2024-12-30 Thread via GitHub
ijuma commented on PR #18199: URL: https://github.com/apache/kafka/pull/18199#issuecomment-2565988051 For cases where we're changing the logging, we should include the before/after since there are often no tests and it's very easy to make a mistake by just reading the code. -- This is an

Re: [PR] KAFKA-18280:fix e2e TestSecurityRollingUpgrade.test_rolling_upgrade_sasl_mechanism_phase_one [kafka]

2024-12-30 Thread via GitHub
ijuma commented on code in PR #18308: URL: https://github.com/apache/kafka/pull/18308#discussion_r1899834438 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -602,12 +602,6 @@ def start_minikdc_if_necessary(self, add_principals=""): nodes_for_kdc += oth

Re: [PR] KAFKA-17615: Remove KafkaServer from tests [kafka]

2024-12-30 Thread via GitHub
ijuma commented on code in PR #18271: URL: https://github.com/apache/kafka/pull/18271#discussion_r1899833711 ## core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala: ## @@ -100,37 +99,6 @@ class DynamicBrokerConfigTest { } } - @Test Review Comment:

Re: [PR] KAFKA-16339: [Docs] Add migrating from transform to process [kafka]

2024-12-30 Thread via GitHub
mjsax commented on PR #18314: URL: https://github.com/apache/kafka/pull/18314#issuecomment-2565928361 > may I format the code? Some blocks are not indented properly. I understand it might pollute the diff in code changes, so if I may, I would do it as a final commit. Let's do this in

Re: [PR] KAFKA-17642: PreVote response handling and ProspectiveState [kafka]

2024-12-30 Thread via GitHub
jsancio commented on code in PR #18240: URL: https://github.com/apache/kafka/pull/18240#discussion_r1899774561 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -957,13 +998,33 @@ private boolean handleVoteResponse( } } +private void may

Re: [PR] KAFKA-17642: PreVote response handling and ProspectiveState [kafka]

2024-12-30 Thread via GitHub
jsancio commented on code in PR #18240: URL: https://github.com/apache/kafka/pull/18240#discussion_r1899774561 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -957,13 +998,33 @@ private boolean handleVoteResponse( } } +private void may

Re: [PR] KAFKA-17642: PreVote response handling and ProspectiveState [kafka]

2024-12-30 Thread via GitHub
jsancio commented on code in PR #18240: URL: https://github.com/apache/kafka/pull/18240#discussion_r1899773951 ## raft/src/main/java/org/apache/kafka/raft/QuorumState.java: ## @@ -402,58 +417,100 @@ public void transitionToUnattached(int epoch) { } /** - * Grant

Re: [PR] KAFKA-17915: Convert Kafka Client system tests to use KRaft [kafka]

2024-12-30 Thread via GitHub
kirktrue commented on code in PR #17669: URL: https://github.com/apache/kafka/pull/17669#discussion_r1899766473 ## tests/kafkatest/services/verifiable_consumer.py: ## @@ -398,8 +398,9 @@ def start_cmd(self, node): # The two implementations use slightly different configu

[jira] [Created] (KAFKA-18379) Enforce resigned cannot transition to any other state in same epoch

2024-12-30 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-18379: Summary: Enforce resigned cannot transition to any other state in same epoch Key: KAFKA-18379 URL: https://issues.apache.org/jira/browse/KAFKA-18379 Project: Kafka

[jira] [Created] (KAFKA-18378) standardize raft quorum state transitions

2024-12-30 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-18378: Summary: standardize raft quorum state transitions Key: KAFKA-18378 URL: https://issues.apache.org/jira/browse/KAFKA-18378 Project: Kafka Issue Type: Improve

Re: [PR] KAFKA-18371 TopicBasedRemoteLogMetadataManagerConfig exposes sensitive configuration data in logs [kafka]

2024-12-30 Thread via GitHub
Wadimz commented on code in PR #18349: URL: https://github.com/apache/kafka/pull/18349#discussion_r1899729081 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java: ## @@ -227,9 +229,9 @@ public String toString

Re: [PR] KAFKA-17642: PreVote response handling and ProspectiveState [kafka]

2024-12-30 Thread via GitHub
ahuang98 commented on code in PR #18240: URL: https://github.com/apache/kafka/pull/18240#discussion_r1899727021 ## raft/src/main/java/org/apache/kafka/raft/QuorumState.java: ## @@ -402,58 +417,100 @@ public void transitionToUnattached(int epoch) { } /** - * Grant

Re: [PR] KAFKA-17642: PreVote response handling and ProspectiveState [kafka]

2024-12-30 Thread via GitHub
ahuang98 commented on code in PR #18240: URL: https://github.com/apache/kafka/pull/18240#discussion_r1899726857 ## raft/src/main/java/org/apache/kafka/raft/QuorumState.java: ## @@ -402,58 +417,100 @@ public void transitionToUnattached(int epoch) { } /** - * Grant

Re: [PR] KAFKA-17642: PreVote response handling and ProspectiveState [kafka]

2024-12-30 Thread via GitHub
ahuang98 commented on code in PR #18240: URL: https://github.com/apache/kafka/pull/18240#discussion_r1899726228 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2935,14 +3014,18 @@ private long pollResigned(long currentTimeMs) { // until eith

[jira] [Created] (KAFKA-18377) pollResigned can short circuit to unattached on receiving all endquorum acks

2024-12-30 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-18377: Summary: pollResigned can short circuit to unattached on receiving all endquorum acks Key: KAFKA-18377 URL: https://issues.apache.org/jira/browse/KAFKA-18377 Project:

Re: [PR] KAFKA-18173: Remove duplicate `assertFutureError` [kafka]

2024-12-30 Thread via GitHub
ijuma commented on code in PR #18296: URL: https://github.com/apache/kafka/pull/18296#discussion_r1899724466 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -583,19 +583,6 @@ public static void assertFutureThrows( assertEquals(expectedMessage, rec

Re: [PR] KAFKA-17642: PreVote response handling and ProspectiveState [kafka]

2024-12-30 Thread via GitHub
jsancio commented on code in PR #18240: URL: https://github.com/apache/kafka/pull/18240#discussion_r1899633981 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2935,14 +3014,18 @@ private long pollResigned(long currentTimeMs) { // until eithe

Re: [PR] KAFKA-18368 Remove TestUtils#MockZkConnect and remove zkConnect from TestUtils#createBrokerConfig [kafka]

2024-12-30 Thread via GitHub
chia7712 commented on code in PR #18352: URL: https://github.com/apache/kafka/pull/18352#discussion_r1899702437 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -614,136 +288,12 @@ class KafkaApisTest extends Logging { assertEquals(cgConfigs.size, configs

[jira] [Created] (KAFKA-18376) High CPU load when AsyncKafkaConsumer uses a small max poll value

2024-12-30 Thread Philip Nee (Jira)
Philip Nee created KAFKA-18376: -- Summary: High CPU load when AsyncKafkaConsumer uses a small max poll value Key: KAFKA-18376 URL: https://issues.apache.org/jira/browse/KAFKA-18376 Project: Kafka

Re: [PR] KAFKA-17642: PreVote response handling and ProspectiveState [kafka]

2024-12-30 Thread via GitHub
ahuang98 commented on PR #18240: URL: https://github.com/apache/kafka/pull/18240#issuecomment-2565744411 > It makes sense to me that after the resign state the replica should always increase its epoch. The replica resigned from leadership at epoch X so eventually the epoch will be at least

Re: [PR] KAFKA-18173: Remove duplicate `assertFutureError` [kafka]

2024-12-30 Thread via GitHub
chia7712 commented on code in PR #18296: URL: https://github.com/apache/kafka/pull/18296#discussion_r1899690842 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -583,19 +583,6 @@ public static void assertFutureThrows( assertEquals(expectedMessage,

Re: [PR] KAFKA-17642: PreVote response handling and ProspectiveState [kafka]

2024-12-30 Thread via GitHub
jsancio commented on code in PR #18240: URL: https://github.com/apache/kafka/pull/18240#discussion_r1899579689 ## raft/src/main/java/org/apache/kafka/raft/QuorumState.java: ## @@ -39,40 +39,47 @@ * how they are triggered: * * Resigned transitions to: - *Unattached: Aft

Re: [PR] KAFKA-18173: Remove duplicate `assertFutureError` [kafka]

2024-12-30 Thread via GitHub
ijuma commented on code in PR #18296: URL: https://github.com/apache/kafka/pull/18296#discussion_r1899687406 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -583,19 +583,6 @@ public static void assertFutureThrows( assertEquals(expectedMessage, rec

Re: [PR] KAFKA-18353: Remove zk config `control.plane.listener.name` [kafka]

2024-12-30 Thread via GitHub
chia7712 commented on code in PR #18329: URL: https://github.com/apache/kafka/pull/18329#discussion_r1899686345 ## docs/upgrade.html: ## @@ -65,6 +65,8 @@ Notable changes in 4 The function onNewBatch in org.apache.kafka.clients

Re: [PR] KAFKA-18353: Remove zk config `control.plane.listener.name` [kafka]

2024-12-30 Thread via GitHub
ijuma commented on code in PR #18329: URL: https://github.com/apache/kafka/pull/18329#discussion_r1899677248 ## docs/upgrade.html: ## @@ -65,6 +65,8 @@ Notable changes in 4 The function onNewBatch in org.apache.kafka.clients.pr

Re: [PR] KAFKA-17607: Add CI step to verify LICENSE-binary [kafka]

2024-12-30 Thread via GitHub
chia7712 commented on PR #18299: URL: https://github.com/apache/kafka/pull/18299#issuecomment-2565710373 @xijiu btw, I open https://issues.apache.org/jira/browse/KAFKA-18375 to fix the license file for 4.0 release. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Created] (KAFKA-18375) Update the LICENSE-binary

2024-12-30 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18375: -- Summary: Update the LICENSE-binary Key: KAFKA-18375 URL: https://issues.apache.org/jira/browse/KAFKA-18375 Project: Kafka Issue Type: Improvement

Re: [PR] KAFKA-17607: Add CI step to verify LICENSE-binary [kafka]

2024-12-30 Thread via GitHub
chia7712 commented on code in PR #18299: URL: https://github.com/apache/kafka/pull/18299#discussion_r1899667957 ## build.gradle: ## @@ -1326,6 +1326,42 @@ project(':core') { from(project(':tools:tools-api').jar) { into("libs/") } from(project(':tools:tools-api').config

[PR] KAFKA-18374 Remove unused EncryptingPasswordEncoder [kafka]

2024-12-30 Thread via GitHub
mingdaoy opened a new pull request, #18355: URL: https://github.com/apache/kafka/pull/18355 https://issues.apache.org/jira/browse/KAFKA-18374 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build sta

Re: [PR] KAFKA-18371 TopicBasedRemoteLogMetadataManagerConfig exposes sensitive configuration data in logs [kafka]

2024-12-30 Thread via GitHub
chia7712 commented on code in PR #18349: URL: https://github.com/apache/kafka/pull/18349#discussion_r1899662858 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java: ## @@ -227,9 +229,9 @@ public String toStri

[jira] [Assigned] (KAFKA-18374) Remove EncryptingPasswordEncoder

2024-12-30 Thread Mingdao Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingdao Yang reassigned KAFKA-18374: Assignee: Mingdao Yang (was: Chia-Ping Tsai) > Remove EncryptingPasswordEncoder > --

[jira] [Updated] (KAFKA-18371) TopicBasedRemoteLogMetadataManagerConfig exposes sensitive configuration data in logs

2024-12-30 Thread Vadym Zhytkevych (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vadym Zhytkevych updated KAFKA-18371: - Description: {code:java} [2024-12-20 14:52:56,805] INFO Successfully configured topic-ba

[jira] [Commented] (KAFKA-18374) Remove EncryptingPasswordEncoder

2024-12-30 Thread Mingdao Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908909#comment-17908909 ] Mingdao Yang commented on KAFKA-18374: -- [~chia7712] I’d like to work on it. Thank y

[jira] [Assigned] (KAFKA-18371) TopicBasedRemoteLogMetadataManagerConfig exposes sensitive configuration data in logs

2024-12-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-18371: -- Assignee: Vadym Zhytkevych > TopicBasedRemoteLogMetadataManagerConfig exposes sensiti

[jira] [Resolved] (KAFKA-18361) Remove PasswordEncoderConfigs

2024-12-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18361. Fix Version/s: 4.0.0 Resolution: Fixed trunk: https://github.com/apache/kafka/comm

[jira] [Updated] (KAFKA-18374) Remove EncryptingPasswordEncoder

2024-12-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18374: --- Fix Version/s: 4.0.0 > Remove EncryptingPasswordEncoder > >

[jira] [Created] (KAFKA-18374) Remove EncryptingPasswordEncoder

2024-12-30 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18374: -- Summary: Remove EncryptingPasswordEncoder Key: KAFKA-18374 URL: https://issues.apache.org/jira/browse/KAFKA-18374 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-18361: Remove PasswordEncoderConfigs [kafka]

2024-12-30 Thread via GitHub
chia7712 merged PR #18347: URL: https://github.com/apache/kafka/pull/18347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18361: Remove PasswordEncoderConfigs [kafka]

2024-12-30 Thread via GitHub
chia7712 commented on PR #18347: URL: https://github.com/apache/kafka/pull/18347#issuecomment-2565677381 the failed tests are traced by following jiras: https://issues.apache.org/jira/browse/KAFKA-18298 https://issues.apache.org/jira/browse/KAFKA-15474 https://issues.apache.org/j

Re: [PR] KAFKA-17607: Add CI step to verify LICENSE-binary [kafka]

2024-12-30 Thread via GitHub
mumrah commented on code in PR #18299: URL: https://github.com/apache/kafka/pull/18299#discussion_r1899638244 ## .github/workflows/build.yml: ## @@ -113,7 +113,7 @@ jobs: # --scan: Publish the build scan. This will only work on PRs from apache/kafka and trunk

Re: [PR] MINOR: Fix logging with exception trace for AbstractHerder#validateConverterConfig [kafka]

2024-12-30 Thread via GitHub
chia7712 commented on PR #18199: URL: https://github.com/apache/kafka/pull/18199#issuecomment-2565626536 @YunKuiLu thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] MINOR: Fix logging with exception trace for AbstractHerder#validateConverterConfig [kafka]

2024-12-30 Thread via GitHub
chia7712 merged PR #18199: URL: https://github.com/apache/kafka/pull/18199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18353: Remove zk config `control.plane.listener.name` [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18329: URL: https://github.com/apache/kafka/pull/18329#discussion_r1899620032 ## core/src/test/scala/unit/kafka/server/SaslApiVersionsRequestTest.scala: ## @@ -51,7 +51,7 @@ object SaslApiVersionsRequestTest { // Configure control plane li

Re: [PR] KAFKA-18353: Remove zk config `control.plane.listener.name` [kafka]

2024-12-30 Thread via GitHub
chia7712 commented on code in PR #18329: URL: https://github.com/apache/kafka/pull/18329#discussion_r1899617831 ## core/src/test/scala/unit/kafka/server/SaslApiVersionsRequestTest.scala: ## @@ -51,7 +51,7 @@ object SaslApiVersionsRequestTest { // Configure control plane l

Re: [PR] KAFKA-18353: Remove zk config `control.plane.listener.name` [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18329: URL: https://github.com/apache/kafka/pull/18329#discussion_r1899617849 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -321,7 +266,7 @@ class SocketServer( if (acceptor != null) { acceptor.localPort }

[jira] [Created] (KAFKA-18373) Remove ZkMetadataCache

2024-12-30 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-18373: - Summary: Remove ZkMetadataCache Key: KAFKA-18373 URL: https://issues.apache.org/jira/browse/KAFKA-18373 Project: Kafka Issue Type: Sub-task Reporter: P

Re: [PR] KAFKA-18353: Remove zk config `control.plane.listener.name` [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18329: URL: https://github.com/apache/kafka/pull/18329#discussion_r1899616913 ## core/src/test/scala/unit/kafka/server/SaslApiVersionsRequestTest.scala: ## @@ -51,7 +51,7 @@ object SaslApiVersionsRequestTest { // Configure control plane li

Re: [PR] KAFKA-18173: Remove duplicate `assertFutureError` [kafka]

2024-12-30 Thread via GitHub
chia7712 commented on code in PR #18296: URL: https://github.com/apache/kafka/pull/18296#discussion_r1899616344 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -583,19 +583,6 @@ public static void assertFutureThrows( assertEquals(expectedMessage,

Re: [PR] KAFKA-18353: Remove zk config `control.plane.listener.name` [kafka]

2024-12-30 Thread via GitHub
TaiJuWu commented on code in PR #18329: URL: https://github.com/apache/kafka/pull/18329#discussion_r1899616913 ## core/src/test/scala/unit/kafka/server/SaslApiVersionsRequestTest.scala: ## @@ -51,7 +51,7 @@ object SaslApiVersionsRequestTest { // Configure control plane li

Re: [PR] KAFKA-14484: Move UnifiedLog static methods to storage [kafka]

2024-12-30 Thread via GitHub
mimaison commented on PR #18039: URL: https://github.com/apache/kafka/pull/18039#issuecomment-2565614617 Rebased on trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

  1   2   >