brandboat opened a new pull request, #18193:
URL: https://github.com/apache/kafka/pull/18193
related to https://issues.apache.org/jira/browse/KAFKA-18082
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and
chia7712 commented on PR #18154:
URL: https://github.com/apache/kafka/pull/18154#issuecomment-2543525812
@mjsax could you please fix the conflicts ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
chia7712 merged PR #18187:
URL: https://github.com/apache/kafka/pull/18187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 merged PR #18191:
URL: https://github.com/apache/kafka/pull/18191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 merged PR #18188:
URL: https://github.com/apache/kafka/pull/18188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-18246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18246.
Fix Version/s: 4.0.0
Resolution: Fixed
> Fix ConnectRestApiTest.test_rest_api by ad
chia7712 commented on code in PR #17311:
URL: https://github.com/apache/kafka/pull/17311#discussion_r1885529180
##
core/src/test/java/kafka/admin/AdminFenceProducersTest.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * con
m1a2st commented on code in PR #18166:
URL: https://github.com/apache/kafka/pull/18166#discussion_r1885528522
##
core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala:
##
@@ -55,7 +55,7 @@ abstract class BaseProducerSendTest extends
KafkaServerTestHarness {
m1a2st commented on code in PR #18166:
URL: https://github.com/apache/kafka/pull/18166#discussion_r1885525659
##
core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala:
##
@@ -55,7 +55,7 @@ abstract class BaseProducerSendTest extends
KafkaServerTestHarness {
m1a2st commented on code in PR #18166:
URL: https://github.com/apache/kafka/pull/18166#discussion_r1885525659
##
core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala:
##
@@ -55,7 +55,7 @@ abstract class BaseProducerSendTest extends
KafkaServerTestHarness {
peterxcli commented on code in PR #17311:
URL: https://github.com/apache/kafka/pull/17311#discussion_r1885502815
##
core/src/test/java/kafka/admin/AdminFenceProducersTest.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * co
Yunyung opened a new pull request, #18192:
URL: https://github.com/apache/kafka/pull/18192
As mentioned in the Jira, add the fix for
[KAFKA-18145](https://issues.apache.org/jira/browse/KAFKA-18145) to the log4j2
yaml, so the `test_dynamic_logging` test can use a non-root logger.
Jir
[
https://issues.apache.org/jira/browse/KAFKA-18247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905780#comment-17905780
]
Jhen-Yung Hsu commented on KAFKA-18247:
---
I'm trying to work on it. Thanks :)
>
[
https://issues.apache.org/jira/browse/KAFKA-18247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jhen-Yung Hsu reassigned KAFKA-18247:
-
Assignee: Jhen-Yung Hsu (was: Chia-Ping Tsai)
> Use log4j2 yaml to rewrite the fix of
clarkwtc opened a new pull request, #18191:
URL: https://github.com/apache/kafka/pull/18191
The test rest api is missing some configs, causing e2e error in the connect
protocol.
Connect protocol in compatible.metadata_quorum=ISOLATED_KRAFT
ableegoldman commented on code in PR #18150:
URL: https://github.com/apache/kafka/pull/18150#discussion_r1885482865
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StatefulProcessorNode.java:
##
@@ -47,11 +47,9 @@ public StatefulProcessorNode(final Proc
ableegoldman commented on code in PR #18150:
URL: https://github.com/apache/kafka/pull/18150#discussion_r1885482579
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StatefulProcessorNode.java:
##
@@ -47,11 +47,9 @@ public StatefulProcessorNode(final Proc
[
https://issues.apache.org/jira/browse/KAFKA-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905776#comment-17905776
]
PoAn Yang commented on KAFKA-18201:
---
Hi [~lianetm], I found that GroupMetadataValue is
chia7712 commented on PR #17373:
URL: https://github.com/apache/kafka/pull/17373#issuecomment-2543435727
I am currently testing this patch, and all related issues are tracked under
[KAFKA-18161](https://issues.apache.org/jira/browse/KAFKA-18161). Please feel
free to report any issues if I o
[
https://issues.apache.org/jira/browse/KAFKA-18247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905775#comment-17905775
]
Chia-Ping Tsai commented on KAFKA-18247:
I have noted that KAFKA-18243 causes a
[
https://issues.apache.org/jira/browse/KAFKA-18243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-18243:
---
Parent: KAFKA-18161
Issue Type: Sub-task (was: Bug)
> Loggers breaks the use of roo
Chia-Ping Tsai created KAFKA-18247:
--
Summary: Use log4j2 yaml to rewrite the fix of KAFKA-18145
Key: KAFKA-18247
URL: https://issues.apache.org/jira/browse/KAFKA-18247
Project: Kafka
Issue T
[
https://issues.apache.org/jira/browse/KAFKA-18243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-18243:
---
Summary: Loggers breaks the use of root logger after migrating to log4j2
(was: Loggers#logg
[
https://issues.apache.org/jira/browse/KAFKA-18243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-18243:
---
Priority: Blocker (was: Major)
> Loggers#loggers should not add rootLogger again.
> ---
chia7712 commented on PR #18185:
URL: https://github.com/apache/kafka/pull/18185#issuecomment-2543432064
@frankvicky I feel `Loggers` is chaos in handling "old" root and "new" root.
We need to keep compatibility to convert the "empty" to "root":
1. get "root" logger -> we need to use
brandboat opened a new pull request, #18189:
URL: https://github.com/apache/kafka/pull/18189
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upg
[
https://issues.apache.org/jira/browse/KAFKA-18246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-18246:
---
Parent: KAFKA-18161
Issue Type: Sub-task (was: Bug)
> Fix ConnectRestApiTest.test_r
[
https://issues.apache.org/jira/browse/KAFKA-18246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-18246:
--
Assignee: Wei-Ting Chen (was: Chia-Ping Tsai)
> Fix ConnectRestApiTest.test_rest_api
[
https://issues.apache.org/jira/browse/KAFKA-18246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905771#comment-17905771
]
Wei-Ting Chen commented on KAFKA-18246:
---
Hi [~chia7712]
Could you assign this ti
chia7712 merged PR #18089:
URL: https://github.com/apache/kafka/pull/18089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
Chia-Ping Tsai created KAFKA-18246:
--
Summary: Fix ConnectRestApiTest.test_rest_api by adding
multiversioning configs
Key: KAFKA-18246
URL: https://issues.apache.org/jira/browse/KAFKA-18246
Project: K
chia7712 commented on code in PR #17741:
URL: https://github.com/apache/kafka/pull/17741#discussion_r1885463533
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java:
##
@@ -82,6 +87,11 @@ public class ConnectorConfig extends AbstractConfig {
frankvicky opened a new pull request, #18188:
URL: https://github.com/apache/kafka/pull/18188
JIRA: KAFKA-15474
as title, since `test-common:test-common-api` requires Java 17, we use
`@Disable` instead.
### Committer Checklist (excluded from commit message)
- [ ] Verify desi
frankvicky opened a new pull request, #18187:
URL: https://github.com/apache/kafka/pull/18187
JIRA: KAFKA-18245
as title
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ]
Chia-Ping Tsai created KAFKA-18245:
--
Summary: Fix flaky
testMetricsDuringTopicCreateDelete(String).quorum=kraft
Key: KAFKA-18245
URL: https://issues.apache.org/jira/browse/KAFKA-18245
Project: Kafka
chia7712 commented on code in PR #18183:
URL: https://github.com/apache/kafka/pull/18183#discussion_r1885404476
##
.github/workflows/build.yml:
##
@@ -118,6 +118,17 @@ jobs:
# --no-scan: For public fork PRs, we won't attempt to publish the
scan
run: |
[
https://issues.apache.org/jira/browse/KAFKA-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16183:
--
Assignee: Chia-Ping Tsai
> Flaky test - testMetricsDuringTopicCreateDelete(String).qu
[
https://issues.apache.org/jira/browse/KAFKA-16183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16183.
Resolution: Won't Fix
> Flaky test - testMetricsDuringTopicCreateDelete(String).quorum=zk
[
https://issues.apache.org/jira/browse/KAFKA-18234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18234.
Fix Version/s: 4.0.0
Resolution: Fixed
> DumpLogSegments cannot print ConsumerGroup
chia7712 merged PR #18173:
URL: https://github.com/apache/kafka/pull/18173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-18240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18240.
Fix Version/s: 4.0.0
Assignee: Nick Guo (was: Chia-Ping Tsai)
Resolution:
chia7712 merged PR #18184:
URL: https://github.com/apache/kafka/pull/18184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
Chia-Ping Tsai created KAFKA-18244:
--
Summary: "Pull Request Labeled" always pass empty commit sha
Key: KAFKA-18244
URL: https://issues.apache.org/jira/browse/KAFKA-18244
Project: Kafka
Issue
chia7712 commented on PR #18184:
URL: https://github.com/apache/kafka/pull/18184#issuecomment-2543354810
the error of labeled is due to
https://github.com/apache/kafka/pull/17881/files#r1885399129
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
chia7712 commented on code in PR #17881:
URL: https://github.com/apache/kafka/pull/17881#discussion_r1885399129
##
.github/workflows/pr-reviewed-trigger.yml:
##
@@ -0,0 +1,42 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreemen
AndrewJSchofield commented on PR #18164:
URL: https://github.com/apache/kafka/pull/18164#issuecomment-2543347646
10 failed tests due to changed default:
* FAILED ❌ AuthorizerIntegrationTest >
testCreatePermissionOnClusterToReadFromNonExistentTopic(String,
String).quorum=kraft.groupPr
chia7712 merged PR #18186:
URL: https://github.com/apache/kafka/pull/18186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-15474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-15474:
--
Assignee: Chia-Ping Tsai
> AbstractCoordinator.testWakeupAfterSyncGroupReceivedExtern
[
https://issues.apache.org/jira/browse/KAFKA-18235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18235.
Fix Version/s: 4.0.0
Resolution: Fixed
> can't build release tar due to broken genC
chia7712 merged PR #18177:
URL: https://github.com/apache/kafka/pull/18177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-14587.
Fix Version/s: 4.0.0
Resolution: Fixed
> Move AclCommand to tools
> ---
[
https://issues.apache.org/jira/browse/KAFKA-14587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison reassigned KAFKA-14587:
--
Assignee: Mickael Maison (was: Omnia Ibrahim)
> Move AclCommand to tools
> -
mimaison commented on PR #13310:
URL: https://github.com/apache/kafka/pull/13310#issuecomment-2543314386
Done in https://github.com/apache/kafka/pull/17880, closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
mimaison closed pull request #13310: KAFKA-14587: Move AclCommand to tools [WIP]
URL: https://github.com/apache/kafka/pull/13310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
mimaison merged PR #17880:
URL: https://github.com/apache/kafka/pull/17880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
FrankYang0529 commented on PR #17199:
URL: https://github.com/apache/kafka/pull/17199#issuecomment-2543180990
Hi @lianetm, thanks for reviewing this PR. I mentioned the metric in the
vote thread.
https://lists.apache.org/thread/4sn92okp89pt3pzk6f0g3wp0lbtn0g2c
--
This is an automat
mimaison commented on code in PR #18166:
URL: https://github.com/apache/kafka/pull/18166#discussion_r1885099406
##
core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala:
##
@@ -55,7 +55,7 @@ abstract class BaseProducerSendTest extends
KafkaServerTestHarness {
m1a2st commented on code in PR #18050:
URL: https://github.com/apache/kafka/pull/18050#discussion_r1885087039
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -176,9 +176,15 @@ public CommitRequestManager(
*/
@Overr
mumrah opened a new pull request, #18186:
URL: https://github.com/apache/kafka/pull/18186
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
m1a2st commented on code in PR #18050:
URL: https://github.com/apache/kafka/pull/18050#discussion_r1885085674
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java:
##
@@ -200,12 +196,12 @@ private void onFailedResponse(final long cu
m1a2st commented on PR #18050:
URL: https://github.com/apache/kafka/pull/18050#issuecomment-2543124548
Thanks for @kirktrue comments,
> I have a personal preference to avoid different RequestManager classes
from calling one another directly. I could imagine introducing a class that's
m1a2st commented on code in PR #18050:
URL: https://github.com/apache/kafka/pull/18050#discussion_r1885068181
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java:
##
@@ -188,12 +184,12 @@ private void onFailedResponse(final long cu
frankvicky commented on code in PR #18185:
URL: https://github.com/apache/kafka/pull/18185#discussion_r1885043342
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/LoggersTest.java:
##
@@ -247,6 +248,7 @@ public TestLoggers(Logger rootLogger, Logger...
knownLogg
frankvicky opened a new pull request, #18185:
URL: https://github.com/apache/kafka/pull/18185
JIRA: KAFKA-18242
In log4j1, the `LogManager#getCurrentLoggers` method returns all loggers
except for the root logger. Therefore, in the
`org.apache.kafka.connect.runtime.Loggers#loggers` me
Rancho-7 commented on PR #18184:
URL: https://github.com/apache/kafka/pull/18184#issuecomment-2543057728
> LGTM. Just add a space after the colon in the PR title, and use the formal
e2e output instead of the in-house tool to show the results next time.
Thanks for review! Updated the t
Rancho-7 opened a new pull request, #18184:
URL: https://github.com/apache/kafka/pull/18184
jira: https://issues.apache.org/jira/browse/KAFKA-18240
As title.
https://github.com/user-attachments/assets/8b5d2b0f-7bde-416c-870c-c36dca0af0c7";
/>
https://github.com/user-attachments/asse
chia7712 commented on code in PR #18177:
URL: https://github.com/apache/kafka/pull/18177#discussion_r1885014330
##
gradle/dependencies.gradle:
##
@@ -166,6 +168,8 @@ libs += [
jaxAnnotationApi:
"javax.annotation:javax.annotation-api:$versions.jaxAnnotation",
jaxbApi: "jav
TengYao Chi created KAFKA-18243:
---
Summary: Loggers#loggers should not add rootLogger again.
Key: KAFKA-18243
URL: https://issues.apache.org/jira/browse/KAFKA-18243
Project: Kafka
Issue Type: Bu
Serwios commented on PR #18162:
URL: https://github.com/apache/kafka/pull/18162#issuecomment-2543037153
Hi, request for review @AndrewJSchofield
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
m1a2st opened a new pull request, #18183:
URL: https://github.com/apache/kafka/pull/18183
Jira: https://issues.apache.org/jira/browse/KAFKA-18241
We missed to check generated document in CI, thus we should test this
### Committer Checklist (excluded from commit message)
- [ ]
[
https://issues.apache.org/jira/browse/KAFKA-18242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-18242.
Fix Version/s: 4.0.0
Resolution: Fixed
> The java code in core module is NOT config
chia7712 merged PR #18182:
URL: https://github.com/apache/kafka/pull/18182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #18182:
URL: https://github.com/apache/kafka/pull/18182#issuecomment-2543023947
I tested the Java 19+ features on the core module, and IntelliJ now displays
accurate error messages.
