Re: [PR] KAFKA-16437 - Upgrade to Jakarta and Jetty 12 (KIP-1032) [kafka]

chia7712 commented on code in PR #16754: URL: https://github.com/apache/kafka/pull/16754#discussion_r1877503804 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/HerderRequestHandler.java: ## @@ -113,6 +113,7 @@ public T completeOrForwardRequest(FutureCallb

[PR] KAFKA-18188; Admin LeaveGroup should allow removing member using consumer protocol by member id [kafka]

dajac opened a new pull request, #18116: URL: https://github.com/apache/kafka/pull/18116 The LeaveGroup API is used by the admin client to remove static members or remove all members from the group. The latter does not work because the API does not allow removing a member using the CONSUMER

[jira] [Updated] (KAFKA-18188) Admin LeaveGroup should allow removing member using consumer protocol by member id

[ https://issues.apache.org/jira/browse/KAFKA-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-18188: Summary: Admin LeaveGroup should allow removing member using consumer protocol by member id (was:

Re: [PR] KAFKA-18058: Share group state record pruning impl. [kafka]

smjn commented on code in PR #18014: URL: https://github.com/apache/kafka/pull/18014#discussion_r1877473873 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorOffsetsManager.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] KAFKA-18183: replace BytesSerializer with ByteArraySerializer for producer/consumer [kafka]

LoganZhuZzz commented on PR #18113: URL: https://github.com/apache/kafka/pull/18113#issuecomment-2530613243 > @LoganZhuZzz please fix the failed tests done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]

m1a2st commented on PR #18104: URL: https://github.com/apache/kafka/pull/18104#issuecomment-2530611762 I test in my local machine  -- This is an automated message

[jira] [Updated] (KAFKA-18194) Flaky test_broker_rolling_bounce due to frequent rebootstrapping

[ https://issues.apache.org/jira/browse/KAFKA-18194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-18194: --- Description: This is introduced after KIP-1102 I believe this is a critical bug because bounced bro

Re: [PR] KAFKA-18040: PlaintextProducerSendTest.testSendToPartitionWithFollowerShutdownShouldNotTimeout fails with CONSUMER group protocol [kafka]

dajac merged PR #18108: URL: https://github.com/apache/kafka/pull/18108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Commented] (KAFKA-18196) Reuse window store for stream-stream self-join

[ https://issues.apache.org/jira/browse/KAFKA-18196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904359#comment-17904359 ] Kuan Po Tseng commented on KAFKA-18196: --- May I try this one ? Thank you ! > Reuse

Re: [PR] KAFKA-18026: KIP-1112, migrate stream-stream joins to use ProcesserSupplier#stores [kafka]

ableegoldman commented on code in PR #18111: URL: https://github.com/apache/kafka/pull/18111#discussion_r1877415780 ## streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java: ## @@ -1816,6 +1816,105 @@ public void shouldWrapProcessorsForStreamTableJoinWithGraceP

[jira] [Created] (KAFKA-18196) Reuse window store for stream-stream self-join

A. Sophie Blee-Goldman created KAFKA-18196: -- Summary: Reuse window store for stream-stream self-join Key: KAFKA-18196 URL: https://issues.apache.org/jira/browse/KAFKA-18196 Project: Kafka

[jira] [Updated] (KAFKA-18194) Flaky test_broker_rolling_bounce due to metadata update

[ https://issues.apache.org/jira/browse/KAFKA-18194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-18194: --- Summary: Flaky test_broker_rolling_bounce due to metadata update (was: Flaky test_broker_rolling_bo

Re: [PR] KAFKA-18026: KIP-1112, document new config and update the Streams upgrade guide [kafka]

ableegoldman merged PR #17906: URL: https://github.com/apache/kafka/pull/17906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[jira] [Commented] (KAFKA-18195) Enter "incompatible" instead of leaving incompatible entires blank in Kafka Streams broker compatibility matrix

[ https://issues.apache.org/jira/browse/KAFKA-18195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904358#comment-17904358 ] PoAn Yang commented on KAFKA-18195: --- Hi [~ableegoldman], if you're not working on this

[jira] [Created] (KAFKA-18195) Enter "incompatible" instead of leaving incompatible entires blank in Kafka Streams broker compatibility matrix

A. Sophie Blee-Goldman created KAFKA-18195: -- Summary: Enter "incompatible" instead of leaving incompatible entires blank in Kafka Streams broker compatibility matrix Key: KAFKA-18195 URL: https://issues.

Re: [PR] KAFKA-18026: KIP-1112, document new config and update the Streams upgrade guide [kafka]

ableegoldman commented on PR #17906: URL: https://github.com/apache/kafka/pull/17906#issuecomment-2530538635 @chia7712 filed a ticket for the incompatible cells cleanup: https://issues.apache.org/jira/browse/KAFKA-18195 -- This is an automated message from the Apache Git Service. To respo

[jira] [Updated] (KAFKA-18194) Flaky test_broker_rolling_bounce due to metadata update

[ https://issues.apache.org/jira/browse/KAFKA-18194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-18194: --- Description: This is introduced after KIP-1102 I believe this is a critical bug because bounced bro

[jira] [Updated] (KAFKA-18194) Flaky test_broker_rolling_bounce due to metadata update

[ https://issues.apache.org/jira/browse/KAFKA-18194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-18194: --- Description: This is introduced after KIP-1102 I believe this is a critical bug because bounced bro

[jira] [Updated] (KAFKA-18194) Flaky test_broker_rolling_bounce due to frequent rebootstrapping

[ https://issues.apache.org/jira/browse/KAFKA-18194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-18194: --- Description: This is introduced after KIP-1102 I believe this is a critical bug because bounced bro

Re: [PR] KAFKA-18026: KIP-1112, migrate stream-stream joins to use ProcesserSupplier#stores [kafka]

ableegoldman commented on code in PR #18111: URL: https://github.com/apache/kafka/pull/18111#discussion_r1877399075 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamStreamJoinNode.java: ## @@ -198,16 +158,6 @@ public StreamStreamJoinNodeBuilder wi

[jira] [Resolved] (KAFKA-18192) generator module should run under java 11

[ https://issues.apache.org/jira/browse/KAFKA-18192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18192. Fix Version/s: 4.0.0 Resolution: Fixed > generator module should run under java 11

Re: [PR] KAFKA-18192: generator module should run under java 11 [kafka]

chia7712 merged PR #18114: URL: https://github.com/apache/kafka/pull/18114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-18194) Flaky test_broker_rolling_bounce due to frequent rebootstrapping

Philip Nee created KAFKA-18194: -- Summary: Flaky test_broker_rolling_bounce due to frequent rebootstrapping Key: KAFKA-18194 URL: https://issues.apache.org/jira/browse/KAFKA-18194 Project: Kafka

Re: [PR] MINOR: Logs warning message when user invoke producer#flush within callback [kafka]

chia7712 commented on code in PR #18112: URL: https://github.com/apache/kafka/pull/18112#discussion_r1877395191 ## docs/upgrade.html: ## @@ -159,6 +159,9 @@ Notable changes in 4 The deprecated sendOffsetsToTransaction(Map

Re: [PR] KAFKA-18183: replace BytesSerializer with ByteArraySerializer for producer/consumer [kafka]

chia7712 commented on PR #18113: URL: https://github.com/apache/kafka/pull/18113#issuecomment-2530492909 @LoganZhuZzz please fix the failed tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Resolved] (KAFKA-18184) Remove the unnecessary project path check from build.gradle

[ https://issues.apache.org/jira/browse/KAFKA-18184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18184. Fix Version/s: 4.0.0 Resolution: Fixed > Remove the unnecessary project path check

Re: [PR] KAFKA-18184:Remove the unnecessary project path check from build.gradle [kafka]

chia7712 merged PR #18102: URL: https://github.com/apache/kafka/pull/18102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-18190) TopologyTestDriver time is not synchronized with test topics

[ https://issues.apache.org/jira/browse/KAFKA-18190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904344#comment-17904344 ] Matthias J. Sax commented on KAFKA-18190: - This sounds familiar. Did you check i

[jira] [Commented] (KAFKA-18193) Kafka Streams `CloseOptions` should not have a public constructor

[ https://issues.apache.org/jira/browse/KAFKA-18193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904345#comment-17904345 ] Matthias J. Sax commented on KAFKA-18193: - Sure. Thanks for picking it up. > Ka

Re: [PR] DO NOT MERGE -- KAFKA-18015: add byDuration auto.offset.reset to Kafka Streams [kafka]

mjsax commented on code in PR #18115: URL: https://github.com/apache/kafka/pull/18115#discussion_r1877313848 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/OffsetResetStrategy.java: ## @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-18015: Add support for duration based offset reset strategy to Kafka Streams [kafka]

mjsax commented on PR #17973: URL: https://github.com/apache/kafka/pull/17973#issuecomment-2530378841 Thanks @KApolinario1120. Great to hear. I will take another look tomorrow, after you pushed more updates. As we are very short in time, I did start to work on a second PR for the int

[PR] DO NOT MERGE -- KAFKA-18015: add byDuration auto.offset.reset to Kafka Streams [kafka]

mjsax opened a new pull request, #18115: URL: https://github.com/apache/kafka/pull/18115 Part of KIP-1106. This PR depends on https://github.com/apache/kafka/pull/17973 -- To speed up development, I did this PR for the KS internal changes in parallel, so we can meet the feature freez

Re: [PR] KAFKA-18192: generator module should run under java 11 [kafka]

frankvicky commented on PR #18114: URL: https://github.com/apache/kafka/pull/18114#issuecomment-2530321521 Command: `./gradlew :streams:check -PmaxTestRetries=1 -PmaxTestRetryFailures=3`  -- T

Re: [PR] KAFKA-18192: generator module should run under java 11 [kafka]

frankvicky commented on PR #18114: URL: https://github.com/apache/kafka/pull/18114#issuecomment-2530290653 command: `./gradlew :clients:check -PmaxTestRetries=1 -PmaxTestRetryFailures=3` https://github.com/user-attachments/assets/3dc30b10-76ee-40aa-8a66-71b58b122193";> -- This

Re: [PR] KAFKA-18192: generator module should run under java 11 [kafka]

frankvicky commented on PR #18114: URL: https://github.com/apache/kafka/pull/18114#issuecomment-2530288908 Command: `./gradlew :clients:check -PmaxTestRetries=1 -PmaxTestRetryFailures=3` ![53899088804_c226fced43_o](https://github.com/user-attachments/assets/715eb2ef-0fc2-4781-9b5d-5b599a

Re: [PR] KAFKA-18111 Add kafka logo [kafka]

frankvicky commented on PR #18066: URL: https://github.com/apache/kafka/pull/18066#issuecomment-2530266949 Hi @swikarpat This logo doesn’t feel very balanced. Have you considered using the following version? https://kafka.apache.org/trademark -- This is an automated message fro

Re: [PR] KAFKA-18192: generator module should run under java 11 [kafka]

chia7712 commented on PR #18114: URL: https://github.com/apache/kafka/pull/18114#issuecomment-2530205641 @frankvicky could you please use JDK 11 to build/test/check both `streams` and `clients` modules? -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] KAFKA-8721: Kafka metrics improvements [kafka]

github-actions[bot] commented on PR #7121: URL: https://github.com/apache/kafka/pull/7121#issuecomment-2530192162 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR

[jira] [Resolved] (KAFKA-18030) Remove old upgrade-system-tests modules

[ https://issues.apache.org/jira/browse/KAFKA-18030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18030. Fix Version/s: 4.0.0 Resolution: Fixed > Remove old upgrade-system-tests modules >

Re: [PR] KAFKA-18030 Remove old upgrade-system-tests modules [kafka]

chia7712 merged PR #17843: URL: https://github.com/apache/kafka/pull/17843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18030 Remove old upgrade-system-tests modules [kafka]

chia7712 commented on PR #17843: URL: https://github.com/apache/kafka/pull/17843#issuecomment-2530162408 @cadonna Please feel free to raise any objections. This PR solely removes the 0.10 versions and can be easily reverted if necessary. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-18026: KIP-1112, migrate stream-stream joins to use ProcesserSupplier#stores [kafka]

guozhangwang commented on code in PR #18111: URL: https://github.com/apache/kafka/pull/18111#discussion_r1877177357 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamStreamJoinNode.java: ## @@ -198,16 +158,6 @@ public StreamStreamJoinNodeBuilder wi

Re: [PR] KAFKA-18015: Add support for duration based offset reset strategy to Kafka Streams [kafka]

KApolinario1120 commented on code in PR #17973: URL: https://github.com/apache/kafka/pull/17973#discussion_r1877164922 ## streams/src/main/java/org/apache/kafka/streams/kstream/Consumed.java: ## @@ -96,13 +112,21 @@ protected Consumed(final Consumed consumed) { * * @

Re: [PR] KAFKA-18015: Add support for duration based offset reset strategy to Kafka Streams [kafka]

KApolinario1120 commented on code in PR #17973: URL: https://github.com/apache/kafka/pull/17973#discussion_r1877168538 ## streams/src/main/java/org/apache/kafka/streams/kstream/Consumed.java: ## @@ -55,9 +56,12 @@ public class Consumed implements NamedOperation> { protecte

[PR] KAFKA-18192: generator module should run under java 11 [kafka]

frankvicky opened a new pull request, #18114: URL: https://github.com/apache/kafka/pull/18114 JIRA: KAFKA-18192 > Both Streams and Clients are now using Java 11, but the Generator modules are not. This discrepancy causes an issue where developers cannot use JDK 11 to run tests for bo

Re: [PR] KAFKA-18015: Add support for duration based offset reset strategy to Kafka Streams [kafka]

KApolinario1120 commented on code in PR #17973: URL: https://github.com/apache/kafka/pull/17973#discussion_r1877165559 ## streams/src/main/java/org/apache/kafka/streams/kstream/Consumed.java: ## @@ -55,9 +56,12 @@ public class Consumed implements NamedOperation> { protecte

Re: [PR] KAFKA-18015: Add support for duration based offset reset strategy to Kafka Streams [kafka]

KApolinario1120 commented on code in PR #17973: URL: https://github.com/apache/kafka/pull/17973#discussion_r1877165266 ## streams/src/main/java/org/apache/kafka/streams/kstream/Consumed.java: ## @@ -96,13 +112,21 @@ protected Consumed(final Consumed consumed) { * * @

Re: [PR] KAFKA-18021: Disabled MirrorCheckpointConnector throws RetriableException on task config generation [kafka]

frankvicky commented on code in PR #18098: URL: https://github.com/apache/kafka/pull/18098#discussion_r1877159384 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java: ## @@ -132,20 +132,23 @@ public Class taskClass() { // divide co

Re: [PR] KAFKA-18015: Add support for duration based offset reset strategy to Kafka Streams [kafka]

KApolinario1120 commented on code in PR #17973: URL: https://github.com/apache/kafka/pull/17973#discussion_r1877151556 ## streams/src/main/java/org/apache/kafka/streams/kstream/Consumed.java: ## @@ -55,9 +56,12 @@ public class Consumed implements NamedOperation> { protecte

Re: [PR] KAFKA-18026: KIP-1112, document new config and update the Streams upgrade guide [kafka]

chia7712 commented on PR #17906: URL: https://github.com/apache/kafka/pull/17906#issuecomment-2530072628 > Personally I think just writing "incompatible" for these cells would convey the information much better. yes, I prefer to write them down explicitly :) -- This is an automate

Re: [PR] KAFKA-18183: replace BytesSerializer with ByteArraySerializer for producer/consumer [kafka]

LoganZhuZzz commented on PR #18113: URL: https://github.com/apache/kafka/pull/18113#issuecomment-2530051686 https://github.com/user-attachments/assets/7dbfcf54-830b-4018-aac5-f2543322c2ec";> -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] KAFKA-18183: replace BytesSerializer with ByteArraySerializer for producer/consumer [kafka]

LoganZhuZzz opened a new pull request, #18113: URL: https://github.com/apache/kafka/pull/18113 *ClusterInstance's helper should use byte array instead of Bytes in creating producer/consumer.* *byte array is more common than Bytes.* ### Committer Checklist (excluded from commit

Re: [PR] KAFKA-18181: Refactor ShareConsumerTest [kafka]

brandboat commented on code in PR #18105: URL: https://github.com/apache/kafka/pull/18105#discussion_r1877047149 ## core/src/test/java/kafka/test/api/ShareConsumerTest.java: ## @@ -1749,23 +1642,18 @@ public void testShareAutoOffsetResetEarliestAfterLsoMovement(String persister

Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]

chia7712 commented on code in PR #18104: URL: https://github.com/apache/kafka/pull/18104#discussion_r1877030678 ## build.gradle: ## @@ -125,6 +125,7 @@ ext { options.compilerArgs << "-encoding" << "UTF-8" options.compilerArgs += ["--release", String.valueOf(releaseVe

[jira] [Updated] (KAFKA-18067) Kafka Streams can leak Producer client under EOS

[ https://issues.apache.org/jira/browse/KAFKA-18067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-18067: --- Fix Version/s: 4.0.0 > Kafka Streams can leak Producer client under EOS > --

Re: [PR] KAFKA-18026: KIP-1112, migrate table-table joins to use ProcesserSuppliers#stores [kafka]

ableegoldman commented on code in PR #18048: URL: https://github.com/apache/kafka/pull/18048#discussion_r1877003569 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/KTableKTableJoinNode.java: ## @@ -120,30 +115,13 @@ private void enableVersionedSemantics

Re: [PR] KAFKA-18026: KIP-1112, migrate table-table joins to use ProcesserSuppliers#stores [kafka]

ableegoldman commented on code in PR #18048: URL: https://github.com/apache/kafka/pull/18048#discussion_r1877002471 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableLeftJoin.java: ## @@ -38,8 +41,10 @@ class KTableKTableLeftJoin extends KTableKTab

Re: [PR] KAFKA-18026: KIP-1112, migrate table-table joins to use ProcesserSuppliers#stores [kafka]

ableegoldman commented on code in PR #18048: URL: https://github.com/apache/kafka/pull/18048#discussion_r1877002471 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableLeftJoin.java: ## @@ -38,8 +41,10 @@ class KTableKTableLeftJoin extends KTableKTab

Re: [PR] KAFKA-18026: KIP-1112, migrate table-table joins to use ProcesserSuppliers#stores [kafka]

ableegoldman commented on code in PR #18048: URL: https://github.com/apache/kafka/pull/18048#discussion_r1877002090 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableAbstractJoin.java: ## @@ -26,18 +29,21 @@ public abstract class KTableKTableAbstrac

Re: [PR] KAFKA-18026: KIP-1112, migrate table-table joins to use ProcesserSuppliers#stores [kafka]

ableegoldman commented on code in PR #18048: URL: https://github.com/apache/kafka/pull/18048#discussion_r1876998523 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java: ## @@ -788,19 +768,47 @@ private KTable doJoin(final KTable other,

Re: [PR] KAFKA-17811: Separate modules to use different JDKs [kafka]

chia7712 commented on PR #17522: URL: https://github.com/apache/kafka/pull/17522#issuecomment-2529939976 > We should make sure it's possible to run tests with Java 11 for the modules that support it since it's possible to have issues at runtime that only affect a particular version.

Re: [PR] KAFKA-18026: KIP-1112, migrate table-table joins to use ProcesserSuppliers#stores [kafka]

ableegoldman commented on code in PR #18048: URL: https://github.com/apache/kafka/pull/18048#discussion_r1876994900 ## streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java: ## @@ -1816,6 +1816,102 @@ public void shouldWrapProcessorsForStreamTableJoinWithGraceP

Re: [PR] KAFKA-10790: Add deadlock detection to producer#flush [kafka]

frankvicky commented on PR #17946: URL: https://github.com/apache/kafka/pull/17946#issuecomment-2529922052 This is minor PR: #18112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[PR] MINOR: Logs warning message when user invoke producer#flush within callback [kafka]

frankvicky opened a new pull request, #18112: URL: https://github.com/apache/kafka/pull/18112 As title. Please refer to the discussion of #17946 for further details ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify

Re: [PR] KAFKA-16437 - Upgrade to Jakarta and Jetty 12 (KIP-1032) [kafka]

cshannon commented on PR #16754: URL: https://github.com/apache/kafka/pull/16754#issuecomment-2529909264 > I re-ran the tests three times, looks good. I'm approving this now, but will wait a few days before merging to see if @gharris1727 or @C0urante (or @chia7712) have anything to add.

[jira] [Resolved] (KAFKA-18067) Kafka Streams can leak Producer client under EOS

[ https://issues.apache.org/jira/browse/KAFKA-18067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-18067. Resolution: Fixed > Kafka Streams can leak Producer client under EOS > ---

Re: [PR] KAFKA-10790: Add deadlock detection to producer#flush [kafka]

frankvicky commented on PR #17946: URL: https://github.com/apache/kafka/pull/17946#issuecomment-2529895143 Hi @AndrewJSchofield @chia7712 No problem. I will file a PR soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] KAFKA-18067: Kafka Streams can leak Producer client under EOS [kafka]

ableegoldman commented on PR #17931: URL: https://github.com/apache/kafka/pull/17931#issuecomment-2529891486 Merged to trunk. Thanks for the fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] KAFKA-18067: Kafka Streams can leak Producer client under EOS [kafka]

ableegoldman merged PR #17931: URL: https://github.com/apache/kafka/pull/17931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]

chia7712 commented on code in PR #18104: URL: https://github.com/apache/kafka/pull/18104#discussion_r1876946798 ## build.gradle: ## @@ -125,6 +125,7 @@ ext { options.compilerArgs << "-encoding" << "UTF-8" options.compilerArgs += ["--release", String.valueOf(releaseVe

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

junrao commented on code in PR #17700: URL: https://github.com/apache/kafka/pull/17700#discussion_r1876938254 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java: ## @@ -172,6 +186,387 @@ private PollResult pollInternal(FetchRequestPrepa

Re: [PR] KAFKA-18058: Share group state record pruning impl. [kafka]

junrao commented on code in PR #18014: URL: https://github.com/apache/kafka/pull/18014#discussion_r1876910317 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorOffsetsManager.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software F

[jira] [Commented] (KAFKA-18191) StreamJoined name is not used for processor names

[ https://issues.apache.org/jira/browse/KAFKA-18191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904292#comment-17904292 ] TengYao Chi commented on KAFKA-18191: - Hi [~ableegoldman]  May I take over this iss

[jira] [Commented] (KAFKA-18193) Kafka Streams `CloseOptions` should not have a public constructor

[ https://issues.apache.org/jira/browse/KAFKA-18193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904291#comment-17904291 ] TengYao Chi commented on KAFKA-18193: - Hi [~mjsax]  I would like to handle this iss

Re: [PR] [WIP] KIP-891: Connect Multiversioning Support (Configs and Validation changes for Connectors and Converters) [kafka]

snehashisp commented on code in PR #17741: URL: https://github.com/apache/kafka/pull/17741#discussion_r1876897276 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorPluginsResource.java: ## @@ -154,9 +158,18 @@ public List listConnectorPlug

Re: [PR] [WIP] KIP-891: Connect Multiversioning Support (Configs and Validation changes for Connectors and Converters) [kafka]

snehashisp commented on code in PR #17741: URL: https://github.com/apache/kafka/pull/17741#discussion_r1876896702 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java: ## @@ -367,6 +371,13 @@ public Object newPlugin(String classOrAlias, Versio

[jira] [Assigned] (KAFKA-18193) Kafka Streams `CloseOptions` should not have a public constructor

[ https://issues.apache.org/jira/browse/KAFKA-18193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TengYao Chi reassigned KAFKA-18193: --- Assignee: TengYao Chi > Kafka Streams `CloseOptions` should not have a public constructor >

Re: [PR] KAFKA-17182: Consumer fetch sessions are evicted too quickly with AsyncKafkaConsumer [kafka]

kirktrue commented on code in PR #17700: URL: https://github.com/apache/kafka/pull/17700#discussion_r1876888597 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java: ## @@ -172,6 +186,387 @@ private PollResult pollInternal(FetchRequestPre

Re: [PR] MINOR: Update Streams compatibility table in upgrade guide for 3.8 [kafka]

JimGalasyn commented on PR #17851: URL: https://github.com/apache/kafka/pull/17851#issuecomment-2529712603 @mjsax thanks for the heads up! Closing in favor of https://github.com/apache/kafka/pull/17937. -- This is an automated message from the Apache Git Service. To respond to the message

[jira] [Created] (KAFKA-18193) Kafka Streams `CloseOptions` should not have a public constructor

Matthias J. Sax created KAFKA-18193: --- Summary: Kafka Streams `CloseOptions` should not have a public constructor Key: KAFKA-18193 URL: https://issues.apache.org/jira/browse/KAFKA-18193 Project: Kafk

Re: [PR] MINOR: Update Streams compatibility table in upgrade guide for 3.8 [kafka]

JimGalasyn closed pull request #17851: MINOR: Update Streams compatibility table in upgrade guide for 3.8 URL: https://github.com/apache/kafka/pull/17851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [WIP] KIP-891: Connect Multiversioning Support (Configs and Validation changes for Connectors and Converters) [kafka]

snehashisp commented on code in PR #17741: URL: https://github.com/apache/kafka/pull/17741#discussion_r1876874046 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java: ## @@ -98,6 +118,12 @@ public class ConnectorConfig extends AbstractConfig {

Re: [PR] [WIP] KIP-891: Connect Multiversioning Support (Configs and Validation changes for Connectors and Converters) [kafka]

snehashisp commented on code in PR #17741: URL: https://github.com/apache/kafka/pull/17741#discussion_r1876874046 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java: ## @@ -98,6 +118,12 @@ public class ConnectorConfig extends AbstractConfig {

[jira] [Assigned] (KAFKA-18190) TopologyTestDriver time is not synchronized with test topics

[ https://issues.apache.org/jira/browse/KAFKA-18190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-18190: -- Assignee: A. Sophie Blee-Goldman > TopologyTestDriver time is not syn

[jira] [Updated] (KAFKA-18190) TopologyTestDriver time is not synchronized with test topics

[ https://issues.apache.org/jira/browse/KAFKA-18190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-18190: --- Fix Version/s: 4.0.0 > TopologyTestDriver time is not synchronized with test

Re: [PR] [WIP] KIP-891: Connect Multiversioning Support (Configs and Validation changes for Connectors and Converters) [kafka]

gharris1727 commented on code in PR #17741: URL: https://github.com/apache/kafka/pull/17741#discussion_r1876871165 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java: ## @@ -367,6 +371,13 @@ public Object newPlugin(String classOrAlias, Versi

Re: [PR] [WIP] KIP-891: Connect Multiversioning Support (Configs and Validation changes for Connectors and Converters) [kafka]

snehashisp commented on code in PR #17741: URL: https://github.com/apache/kafka/pull/17741#discussion_r1876867588 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java: ## @@ -367,6 +371,13 @@ public Object newPlugin(String classOrAlias, Versio

Re: [PR] [WIP] KIP-891: Connect Multiversioning Support (Configs and Validation changes for Connectors and Converters) [kafka]

gharris1727 commented on code in PR #17741: URL: https://github.com/apache/kafka/pull/17741#discussion_r1876868562 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SampleSinkConnector.java: ## @@ -25,7 +25,7 @@ public class SampleSinkConnector extends SinkCon

Re: [PR] [WIP] KIP-891: Connect Multiversioning Support (Configs and Validation changes for Connectors and Converters) [kafka]

gharris1727 commented on code in PR #17741: URL: https://github.com/apache/kafka/pull/17741#discussion_r1876866999 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java: ## @@ -405,13 +471,102 @@ protected ConfigDef config(Predicate predicate) {

Re: [PR] KAFKA-18181: Refactor ShareConsumerTest [kafka]

apoorvmittal10 commented on code in PR #18105: URL: https://github.com/apache/kafka/pull/18105#discussion_r1876860865 ## core/src/test/java/kafka/test/api/ShareConsumerTest.java: ## @@ -1749,23 +1642,18 @@ public void testShareAutoOffsetResetEarliestAfterLsoMovement(String pers

[jira] [Created] (KAFKA-18192) generator module should run under java 11

Chia-Ping Tsai created KAFKA-18192: -- Summary: generator module should run under java 11 Key: KAFKA-18192 URL: https://issues.apache.org/jira/browse/KAFKA-18192 Project: Kafka Issue Type: Sub

Re: [PR] KAFKA-18014: Add duration based offset reset option for ShareConsumer [kafka]

apoorvmittal10 commented on code in PR #18096: URL: https://github.com/apache/kafka/pull/18096#discussion_r1876851848 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2125,16 +2128,25 @@ private long startOffsetDuringInitialization(long partitionDataStartOff

Re: [PR] [WIP] KIP-891: Connect Multiversioning Support (Configs and Validation changes for Connectors and Converters) [kafka]

snehashisp commented on code in PR #17741: URL: https://github.com/apache/kafka/pull/17741#discussion_r1876854461 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java: ## @@ -405,13 +471,102 @@ protected ConfigDef config(Predicate predicate) {

Re: [PR] KAFKA-18026: KIP-1112, migrate stream-stream joins to use ProcesserSupplier#stores [kafka]

ableegoldman commented on code in PR #18111: URL: https://github.com/apache/kafka/pull/18111#discussion_r1876844961 ## streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java: ## @@ -1816,6 +1816,105 @@ public void shouldWrapProcessorsForStreamTableJoinWithGraceP

Re: [PR] KAFKA-17915: Convert Kafka Client system tests to use KRaft [kafka]

kirktrue commented on code in PR #17669: URL: https://github.com/apache/kafka/pull/17669#discussion_r1876850368 ## tests/kafkatest/services/verifiable_consumer.py: ## @@ -398,8 +398,9 @@ def start_cmd(self, node): # The two implementations use slightly different configu

Re: [PR] KAFKA-18014: Add duration based offset reset option for ShareConsumer [kafka]

apoorvmittal10 commented on code in PR #18096: URL: https://github.com/apache/kafka/pull/18096#discussion_r1876845995 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/ShareGroupAutoOffsetResetStrategy.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache

[jira] [Resolved] (KAFKA-15284) Implement GroupProtocolResolver to dynamically determine consumer group protocol

[ https://issues.apache.org/jira/browse/KAFKA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-15284. --- Resolution: Won't Fix > Implement GroupProtocolResolver to dynamically determine consumer group > p

[jira] [Updated] (KAFKA-18190) TopologyTestDriver time is not synchronized with test topics

[ https://issues.apache.org/jira/browse/KAFKA-18190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-18190: --- Description: If a user does not provide explicit timestamps for records pipe

Re: [PR] KAFKA-18174: Subsequent write event completions should be a noop [kafka]

jeffkbkim merged PR #18083: URL: https://github.com/apache/kafka/pull/18083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[PR] KAFKA-18026: KIP-1112, migrate stream-stream joins to use ProcesserSupplier#stores [kafka]

ableegoldman opened a new pull request, #18111: URL: https://github.com/apache/kafka/pull/18111 Covers wrapping of processors and state stores for KStream-KStream joins. Includes self-joins and the spurious results fix optimization -- This is an automated message from the Apache Git

  1   2   3   >