[jira] [Assigned] (KAFKA-17578) Remove partitionRacks from TopicMetadata

2024-09-18 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-17578: - Assignee: PoAn Yang > Remove partitionRacks from TopicMetadata > --

[jira] [Commented] (KAFKA-17578) Remove partitionRacks from TopicMetadata

2024-09-18 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882865#comment-17882865 ] Jeff Kim commented on KAFKA-17578: -- [~yangpoan] sure! > Remove partitionRacks from Top

[jira] [Updated] (KAFKA-17578) Remove partitionRacks from TopicMetadata

2024-09-18 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-17578: - Description: The ModernGroup#subscribedTopicMetadata takes too much memory due to  partitionRacks: ```

[jira] [Updated] (KAFKA-17578) Remove partitionRacks from TopicMetadata

2024-09-18 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-17578: - Description: The ModernGroup#subscribedTopicMetadata takes too much memory due to  partitionRacks: /**

[jira] [Updated] (KAFKA-17578) Remove partitionRacks from TopicMetadata

2024-09-18 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim updated KAFKA-17578: - Description: The ModernGroup#subscribedTopicMetadata takes too much memory due to  partitionRacks: /**

Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]

2024-09-18 Thread via GitHub
TaiJuWu commented on code in PR #17208: URL: https://github.com/apache/kafka/pull/17208#discussion_r1766061907 ## .github/labeler.yml: ## @@ -0,0 +1,99 @@ +clients: +- changed-files: + - any-glob-to-any-file: +- 'clients/**' + +config: +- changed-files: + - any-glob-to-an

[jira] [Commented] (KAFKA-17578) Remove partitionRacks from TopicMetadata

2024-09-18 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882856#comment-17882856 ] PoAn Yang commented on KAFKA-17578: --- Hi [~jeffkbkim], if you're not working on this is

[jira] [Created] (KAFKA-17578) Remove partitionRacks from TopicMetadata

2024-09-18 Thread Jeff Kim (Jira)
Jeff Kim created KAFKA-17578: Summary: Remove partitionRacks from TopicMetadata Key: KAFKA-17578 URL: https://issues.apache.org/jira/browse/KAFKA-17578 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-16379: Coordinator event queue, processing, flush, purgatory time histograms [kafka]

2024-09-18 Thread via GitHub
ijuma commented on code in PR #16949: URL: https://github.com/apache/kafka/pull/16949#discussion_r1766071203 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/HdrHistogram.java: ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]

2024-09-18 Thread via GitHub
TaiJuWu commented on code in PR #17208: URL: https://github.com/apache/kafka/pull/17208#discussion_r1766061907 ## .github/labeler.yml: ## @@ -0,0 +1,99 @@ +clients: +- changed-files: + - any-glob-to-any-file: +- 'clients/**' + +config: +- changed-files: + - any-glob-to-an

[PR] KAFKA-16908: Refactor `QuorumConfig` with `AbstractConfig` [kafka]

2024-09-18 Thread via GitHub
xijiu opened a new pull request, #17231: URL: https://github.com/apache/kafka/pull/17231 As title ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

Re: [PR] KAFKA-17540: Create floating tag on trunk for CI cache [kafka]

2024-09-18 Thread via GitHub
mumrah commented on PR #17204: URL: https://github.com/apache/kafka/pull/17204#issuecomment-2359818588 I think tag signing with `git` may not work as expected here. It may be possible to use the API to create a signed tag. https://docs.github.com/en/rest/git/tags?apiVersion=2022-11-28 --

Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]

2024-09-18 Thread via GitHub
TaiJuWu commented on code in PR #17208: URL: https://github.com/apache/kafka/pull/17208#discussion_r1766034189 ## .github/labeler.yml: ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE fil

Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]

2024-09-18 Thread via GitHub
C0urante commented on code in PR #17208: URL: https://github.com/apache/kafka/pull/17208#discussion_r1766021173 ## .github/labeler.yml: ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE fi

Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]

2024-09-18 Thread via GitHub
mumrah commented on code in PR #17208: URL: https://github.com/apache/kafka/pull/17208#discussion_r1765988397 ## .github/labeler.yml: ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file

Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]

2024-09-18 Thread via GitHub
TaiJuWu commented on code in PR #17208: URL: https://github.com/apache/kafka/pull/17208#discussion_r1765954861 ## .github/labeler.yml: ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE fil

[PR] KAFKA-17505: New consumer seekToBeginning/End should run in background thread [kafka]

2024-09-18 Thread via GitHub
TaiJuWu opened a new pull request, #17230: URL: https://github.com/apache/kafka/pull/17230 Jira: https://issues.apache.org/jira/browse/KAFKA-17505 Move `seekToBeginning/End` run in background thread. This change will dealy subscribeState change so we leverage `cachedSubscriptionHa

Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]

2024-09-18 Thread via GitHub
TaiJuWu commented on code in PR #17208: URL: https://github.com/apache/kafka/pull/17208#discussion_r1765954861 ## .github/labeler.yml: ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE fil

Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]

2024-09-18 Thread via GitHub
TaiJuWu commented on code in PR #17208: URL: https://github.com/apache/kafka/pull/17208#discussion_r1765954861 ## .github/labeler.yml: ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE fil

Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]

2024-09-18 Thread via GitHub
C0urante commented on code in PR #17208: URL: https://github.com/apache/kafka/pull/17208#discussion_r1765945378 ## .github/labeler.yml: ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE fi

Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]

2024-09-18 Thread via GitHub
TaiJuWu commented on code in PR #17208: URL: https://github.com/apache/kafka/pull/17208#discussion_r1765915196 ## .github/labeler.yml: ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE fil

[jira] [Commented] (KAFKA-17343) Fix failed benchmark_test.py

2024-09-18 Thread Eric Chang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882837#comment-17882837 ] Eric Chang commented on KAFKA-17343: I you want to play around with this issue, you

[jira] [Updated] (KAFKA-17343) Fix failed benchmark_test.py

2024-09-18 Thread Eric Chang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Chang updated KAFKA-17343: --- Attachment: (was: producer_performance-oom.log) > Fix failed benchmark_test.py > ---

[jira] [Updated] (KAFKA-17343) Fix failed benchmark_test.py

2024-09-18 Thread Eric Chang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Chang updated KAFKA-17343: --- Attachment: (was: producer_performance-oom.stderr) > Fix failed benchmark_test.py >

[jira] [Updated] (KAFKA-17343) Fix failed benchmark_test.py

2024-09-18 Thread Eric Chang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Chang updated KAFKA-17343: --- Attachment: (was: producer_performance-oom.stdout) > Fix failed benchmark_test.py >

Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]

2024-09-18 Thread via GitHub
TaiJuWu commented on code in PR #17208: URL: https://github.com/apache/kafka/pull/17208#discussion_r1765915196 ## .github/labeler.yml: ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE fil

[jira] [Comment Edited] (KAFKA-17343) Fix failed benchmark_test.py

2024-09-18 Thread Eric Chang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882835#comment-17882835 ] Eric Chang edited comment on KAFKA-17343 at 9/19/24 12:40 AM:

[jira] [Commented] (KAFKA-17343) Fix failed benchmark_test.py

2024-09-18 Thread Eric Chang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882835#comment-17882835 ] Eric Chang commented on KAFKA-17343: I think It’s caused by laking of container awar

[jira] [Updated] (KAFKA-17343) Fix failed benchmark_test.py

2024-09-18 Thread Eric Chang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Chang updated KAFKA-17343: --- Attachment: producer_performance-oom.stdout producer_performance-oom.stderr

Re: [PR] MINOR Group the junit parser console logs [kafka]

2024-09-18 Thread via GitHub
mumrah commented on PR #17229: URL: https://github.com/apache/kafka/pull/17229#issuecomment-2359620394 Example here https://github.com/apache/kafka/actions/runs/10928437993/job/30337019209?pr=17229#step:7:21 -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] KAFKA-17109: Move lock backoff retry to streams TaskManager [kafka]

2024-09-18 Thread via GitHub
cadonna commented on code in PR #17209: URL: https://github.com/apache/kafka/pull/17209#discussion_r1765850540 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -150,6 +153,11 @@ void setMainConsumer(final Consumer mainConsumer) {

[jira] [Created] (KAFKA-17577) May be record metrics on UnknownSubscriptionIdException

2024-09-18 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-17577: - Summary: May be record metrics on UnknownSubscriptionIdException Key: KAFKA-17577 URL: https://issues.apache.org/jira/browse/KAFKA-17577 Project: Kafka Iss

Re: [PR] MINOR: improve RecordCollectorImpl [kafka]

2024-09-18 Thread via GitHub
lucasbru commented on code in PR #17185: URL: https://github.com/apache/kafka/pull/17185#discussion_r1765596728 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -529,7 +528,7 @@ private void checkForException() { fina

Re: [PR] KAFKA-12823 Remove Deprecated method KStream#through (KIP-1087) [kafka]

2024-09-18 Thread via GitHub
ardada2468 commented on PR #16761: URL: https://github.com/apache/kafka/pull/16761#issuecomment-2359286604 Hey, I just made new commits which address all of your comments. Let me know if I missed anything -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] KAFKA-17543: Improve and clarify the error message about generated broker IDs in migration [kafka]

2024-09-18 Thread via GitHub
cmccabe merged PR #17210: URL: https://github.com/apache/kafka/pull/17210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Updated] (KAFKA-17543) Enforce that broker ids are specified when migrating to KRaft

2024-09-18 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-17543: - Summary: Enforce that broker ids are specified when migrating to KRaft (was: Enforce that broke

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-18 Thread via GitHub
cmccabe commented on PR #17076: URL: https://github.com/apache/kafka/pull/17076#issuecomment-2359158707 Thanks, everyone. I committed what we have so far. If there are any gaps please raise another PR. Hopefully in time for RC1, so that everyone can kick the tires :) -- This is an automa

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-18 Thread via GitHub
cmccabe commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1765531541 ## config/kraft/reconfig-server.properties: ## @@ -0,0 +1,132 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more Review Comment: For now, I gu

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-18 Thread via GitHub
cmccabe commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1765530754 ## docs/quickstart.html: ## @@ -50,46 +50,47 @@ Kafka with KRaft Kafka can be run using KRaft mode using local scripts and downloaded files or the docker im

Re: [PR] KAFKA-16437 - Upgrade to Jakarta and Jetty 12 (KIP-1032) [kafka]

2024-09-18 Thread via GitHub
cshannon commented on PR #16754: URL: https://github.com/apache/kafka/pull/16754#issuecomment-2359143095 The checks on Java 8 and Java 11 fail because this PR requires JDK 17+ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-18 Thread via GitHub
cmccabe commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1765516538 ## config/kraft/controller.properties: ## @@ -26,13 +26,13 @@ process.roles=controller # The node id associated with this instance's roles node.id=1 -# The connect

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-18 Thread via GitHub
cmccabe merged PR #17076: URL: https://github.com/apache/kafka/pull/17076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-17542: Use actions/labeler for automatic PR labeling [kafka]

2024-09-18 Thread via GitHub
C0urante commented on code in PR #17208: URL: https://github.com/apache/kafka/pull/17208#discussion_r1765428493 ## .github/labeler.yml: ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE fi

[jira] [Resolved] (KAFKA-17559) RemoteLogOffsetReaderTest flaky on trunk

2024-09-18 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-17559. -- Assignee: Kamal Chandraprakash (was: Chia-Ping Tsai) Resolution: Fixed > RemoteLogOffse

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-18 Thread via GitHub
jsancio commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1765388388 ## config/kraft/reconfig-server.properties: ## @@ -0,0 +1,132 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more Review Comment: > As I commen

[PR] MINOR Group the junit parser console logs [kafka]

2024-09-18 Thread via GitHub
mumrah opened a new pull request, #17229: URL: https://github.com/apache/kafka/pull/17229 Use `::group::` feature of GitHub Actions to hide some of the verbose output from Parse JUnit Tests step. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] MINOR Group the junit parser console logs [kafka]

2024-09-18 Thread via GitHub
mumrah commented on PR #17229: URL: https://github.com/apache/kafka/pull/17229#issuecomment-2358942103 https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#grouping-log-lines -- This is an automated message from the Apa

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-18 Thread via GitHub
jsancio commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1765383672 ## config/kraft/reconfig-server.properties: ## @@ -0,0 +1,132 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more Review Comment: > It's unclea

[jira] [Created] (KAFKA-17576) Fix all references to kraft/server.properties to use reconfig-server.properties

2024-09-18 Thread Jira
José Armando García Sancio created KAFKA-17576: -- Summary: Fix all references to kraft/server.properties to use reconfig-server.properties Key: KAFKA-17576 URL: https://issues.apache.org/jira/browse/KA

Re: [PR] KAFKA-17488: Cleanup (test) code for Kafka Streams "metric version" [kafka]

2024-09-18 Thread via GitHub
fonsdant commented on code in PR #17182: URL: https://github.com/apache/kafka/pull/17182#discussion_r1765376428 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java: ## @@ -139,7 +139,7 @@ public class StreamsMetricsImplTest {

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-18 Thread via GitHub
jsancio commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1765362396 ## config/kraft/controller.properties: ## @@ -26,13 +26,13 @@ process.roles=controller # The node id associated with this instance's roles node.id=1 -# The connect

Re: [PR] KAFKA-17559: Fix the flaky RemoteLogOffsetReader#testTaskQueueFullAndCancelTask [kafka]

2024-09-18 Thread via GitHub
satishd merged PR #17214: URL: https://github.com/apache/kafka/pull/17214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-17540: Create floating tag on trunk for CI cache [kafka]

2024-09-18 Thread via GitHub
mumrah commented on PR #17204: URL: https://github.com/apache/kafka/pull/17204#issuecomment-2358897273 > Is the purpose of the sign to be the same as the commits? No, the purpose is just to have a signature on the tag itself. When Github merges PRs, it will sign the resulting commit

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-18 Thread via GitHub
jsancio commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1765340548 ## config/kraft/broker.properties: ## @@ -26,8 +26,8 @@ process.roles=broker # The node id associated with this instance's roles node.id=2 -# The connect string for

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-18 Thread via GitHub
jsancio commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1765336554 ## docs/quickstart.html: ## @@ -50,46 +50,47 @@ Kafka with KRaft Kafka can be run using KRaft mode using local scripts and downloaded files or the docker im

Re: [PR] KAFKA-17154: New consumer subscribe may join group without a call to consumer.poll [kafka]

2024-09-18 Thread via GitHub
FrankYang0529 commented on code in PR #17165: URL: https://github.com/apache/kafka/pull/17165#discussion_r1765334799 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManagerTest.java: ## @@ -1617,12 +1617,25 @@ public void testRevokePartiti

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-18 Thread via GitHub
jsancio commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1765329524 ## docs/quickstart.html: ## @@ -32,8 +32,8 @@ the latest Kafka release and extract it: -$ tar -xzf kafka_{{scalaVersion}}-{{fullDotVe

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-18 Thread via GitHub
jsancio commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1765319856 ## docs/ops.html: ## @@ -3776,25 +3776,77 @@ controller.quorum.voters=id1@host1:port1,id2@host2:port2,id3@host3:port3 + controller.quorum.bootstrap.servers=host1:port1

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-18 Thread via GitHub
jsancio commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1765315597 ## docs/ops.html: ## @@ -3776,25 +3776,77 @@ controller.quorum.voters=id1@host1:port1,id2@host2:port2,id3@host3:port3 + controller.quorum.bootstrap.servers=host1:port1

Re: [PR] KAFKA-17048; Add docs for KIP-853 [kafka]

2024-09-18 Thread via GitHub
jsancio commented on code in PR #17076: URL: https://github.com/apache/kafka/pull/17076#discussion_r1765311641 ## docs/ops.html: ## @@ -3776,25 +3776,77 @@ controller.quorum.voters=id1@host1:port1,id2@host2:port2,id3@host3:port3 + controller.quorum.bootstrap.servers=host1:port1

Re: [PR] KAFKA-17154: New consumer subscribe may join group without a call to consumer.poll [kafka]

2024-09-18 Thread via GitHub
FrankYang0529 commented on code in PR #17165: URL: https://github.com/apache/kafka/pull/17165#discussion_r1765301371 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManagerTest.java: ## @@ -1617,12 +1617,25 @@ public void testRevokePartiti

Re: [PR] KAFKA-17564: Move BrokerFeatures to server module [kafka]

2024-09-18 Thread via GitHub
m1a2st commented on PR #17228: URL: https://github.com/apache/kafka/pull/17228#issuecomment-2358810269 @frankvicky thanks for your comments, addressed them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-17540: Create floating tag on trunk for CI cache [kafka]

2024-09-18 Thread via GitHub
fonsdant commented on PR #17204: URL: https://github.com/apache/kafka/pull/17204#issuecomment-2358799628 > One small thing remaining. > > Also, can you see if signed tags are possible here? That might be a nice thing to include. Yes, they are possible but require a GPG key. Is

Re: [PR] KAFKA-17154: New consumer subscribe may join group without a call to consumer.poll [kafka]

2024-09-18 Thread via GitHub
FrankYang0529 commented on code in PR #17165: URL: https://github.com/apache/kafka/pull/17165#discussion_r1765288070 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerMembershipManagerTest.java: ## @@ -1617,12 +1617,25 @@ public void testRevokePartiti

Re: [PR] KAFKA-17540: Create floating tag on trunk for CI cache [kafka]

2024-09-18 Thread via GitHub
fonsdant commented on code in PR #17204: URL: https://github.com/apache/kafka/pull/17204#discussion_r1765262944 ## .github/workflows/ci-complete.yml: ## @@ -118,3 +118,17 @@ jobs: description: 'The build scan was successfully published' context: 'Gradle Bui

[jira] [Commented] (KAFKA-17488) Cleanup (test) code for Kafka Streams "metric version"

2024-09-18 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882743#comment-17882743 ] João Pedro Fonseca commented on KAFKA-17488: In fact, I have considered not

[jira] [Commented] (KAFKA-17233) MirrorCheckpointConnector should use batched listConsumerGroupOffsets

2024-09-18 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882741#comment-17882741 ] João Pedro Fonseca commented on KAFKA-17233: Hi, [~gharris1727]! I have push

Re: [PR] KAFKA-17564: Move BrokerFeatures to server module [kafka]

2024-09-18 Thread via GitHub
frankvicky commented on code in PR #17228: URL: https://github.com/apache/kafka/pull/17228#discussion_r1765205630 ## server/src/main/java/org/apache/kafka/server/BrokerFeatures.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-17480: New consumer commit all consumed should retrieve offsets in background thread [kafka]

2024-09-18 Thread via GitHub
frankvicky commented on code in PR #17150: URL: https://github.com/apache/kafka/pull/17150#discussion_r1765190740 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessorTest.java: ## @@ -208,6 +206,110 @@ public void testSeekUnvalida

Re: [PR] KAFKA-17480: New consumer commit all consumed should retrieve offsets in background thread [kafka]

2024-09-18 Thread via GitHub
frankvicky commented on code in PR #17150: URL: https://github.com/apache/kafka/pull/17150#discussion_r1765190740 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessorTest.java: ## @@ -208,6 +206,110 @@ public void testSeekUnvalida

[PR] KAFKA-17564: Move BrokerFeatures to server module [kafka]

2024-09-18 Thread via GitHub
m1a2st opened a new pull request, #17228: URL: https://github.com/apache/kafka/pull/17228 Jira: https://issues.apache.org/jira/browse/KAFKA-17564 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build

[PR] MINOR Fix is-public-fork input type [kafka]

2024-09-18 Thread via GitHub
mumrah opened a new pull request, #17227: URL: https://github.com/apache/kafka/pull/17227 PRs are getting the wrong value for this workflow input. The context value we are checking is a boolean and we were treating it as a string. This patch fixes that by defining the workflow input as a bo

[jira] [Comment Edited] (KAFKA-17572) Clear build scan PR status when re-running the tests

2024-09-18 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882726#comment-17882726 ] David Arthur edited comment on KAFKA-17572 at 9/18/24 2:01 PM: ---

[jira] [Commented] (KAFKA-17572) Clear build scan PR status when re-running the tests

2024-09-18 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882726#comment-17882726 ] David Arthur commented on KAFKA-17572: -- Here is an example    !image-2024-09-18-0

[jira] [Updated] (KAFKA-17572) Clear build scan PR status when re-running the tests

2024-09-18 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-17572: - Attachment: image-2024-09-18-09-56-21-416.png > Clear build scan PR status when re-running the t

[jira] [Assigned] (KAFKA-17024) add integration test for TransactionsCommand

2024-09-18 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-17024: - Assignee: Kuan Po Tseng (was: PoAn Yang) > add integration test for TransactionsCommand >

[jira] [Commented] (KAFKA-17558) Cleanup Kafka Streams integration tests

2024-09-18 Thread zhengke zhou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882722#comment-17882722 ] zhengke zhou commented on KAFKA-17558: -- [~mjsax]  Can I have a try ? > Cleanup Kaf

[jira] [Commented] (KAFKA-17575) TestUtils.tempDirectory registers two shutdown hooks for the same thing

2024-09-18 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882702#comment-17882702 ] 黃竣陽 commented on KAFKA-17575: - Thanks for [~chia7712] reminder, I will take a look this PR.

[jira] [Commented] (KAFKA-17575) TestUtils.tempDirectory registers two shutdown hooks for the same thing

2024-09-18 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882701#comment-17882701 ] Chia-Ping Tsai commented on KAFKA-17575: [~m1a2st] there is already a PR for it.

[jira] [Commented] (KAFKA-17568) Rewrite TestPurgatoryPerformance by JMH

2024-09-18 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882698#comment-17882698 ] Chia-Ping Tsai commented on KAFKA-17568: [~linsiyuan] thanks for contributing to

[jira] [Assigned] (KAFKA-17568) Rewrite TestPurgatoryPerformance by JMH

2024-09-18 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-17568: -- Assignee: 黃竣陽 > Rewrite TestPurgatoryPerformance by JMH > ---

[PR] KAFKA-17575: Remove unnecessary file.deleteOnExit call [kafka]

2024-09-18 Thread via GitHub
srdo opened a new pull request, #17226: URL: https://github.com/apache/kafka/pull/17226 TestUtils.tempDirectory already registers a shutdown hook for deleting the temp directory. There's no reason to also call File.deleteOnExit, since that just registers another hook to do the same thing.

[PR] KAFKA-17574: Allow overriding TestKitNodes baseDirectory [kafka]

2024-09-18 Thread via GitHub
srdo opened a new pull request, #17225: URL: https://github.com/apache/kafka/pull/17225 This allows shutting down a KafkaClusterTestKit from a JVM shutdown hook without risking error logs because the base directory has already been deleted by the shutdown hook TestUtils.tempDirectory sets u

[jira] [Commented] (KAFKA-17575) TestUtils.tempDirectory registers two shutdown hooks for the same thing

2024-09-18 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882695#comment-17882695 ] 黃竣陽 commented on KAFKA-17575: - Hello [~srdo] , If you wouldn't work on this, may I take this

[PR] KAFKA-17385: Remove authorizer, authorizer-properties, zk-tls-config-file in AclCommand [kafka]

2024-09-18 Thread via GitHub
FrankYang0529 opened a new pull request, #17224: URL: https://github.com/apache/kafka/pull/17224 The [authorizer](https://github.com/apache/kafka/blob/944c1353a925858ea9bd9024a713cd7301f55133/core/src/main/scala/kafka/admin/AclCommand.scala#L501-L506), [authorizer-properties](https://githu

[jira] [Updated] (KAFKA-17575) TestUtils.tempDirectory registers two shutdown hooks for the same thing

2024-09-18 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-17575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stig Rohde Døssing updated KAFKA-17575: --- Description: TestUtils.tempDirectory registers a shutdown hook to clean up the tempo

[jira] [Created] (KAFKA-17575) TestUtils.tempDirectory registers two shutdown hooks for the same thing

2024-09-18 Thread Jira
Stig Rohde Døssing created KAFKA-17575: -- Summary: TestUtils.tempDirectory registers two shutdown hooks for the same thing Key: KAFKA-17575 URL: https://issues.apache.org/jira/browse/KAFKA-17575 P

[jira] [Created] (KAFKA-17574) KafkaClusterTestKit produces error logs if shut down from a shutdown hook

2024-09-18 Thread Jira
Stig Rohde Døssing created KAFKA-17574: -- Summary: KafkaClusterTestKit produces error logs if shut down from a shutdown hook Key: KAFKA-17574 URL: https://issues.apache.org/jira/browse/KAFKA-17574

Re: [PR] KAFKA-17367: Share coordinator impl. Added additional tests. [3/N] [kafka]

2024-09-18 Thread via GitHub
smjn commented on PR #17149: URL: https://github.com/apache/kafka/pull/17149#issuecomment-2358244258 For better understanding, I will remove both the candidate and last from the sortedBatches and add the appropriate one whenever required. -- This is an automated message from the Apache Gi

[jira] [Comment Edited] (KAFKA-17515) Fix flaky RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener

2024-09-18 Thread Yu-Lin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882672#comment-17882672 ] Yu-Lin Chen edited comment on KAFKA-17515 at 9/18/24 11:22 AM: ---

[PR] KAFKA-17563: Move `RequestConvertToJson` to server module [kafka]

2024-09-18 Thread via GitHub
xijiu opened a new pull request, #17223: URL: https://github.com/apache/kafka/pull/17223 As title. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (includin

Re: [PR] KAFKA-17515: Fix flaky RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener [kafka]

2024-09-18 Thread via GitHub
chenyulin0719 commented on code in PR #17187: URL: https://github.com/apache/kafka/pull/17187#discussion_r1764864632 ## streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java: ## @@ -579,12 +580,15 @@ public void shouldInvokeUserDefinedGlobalStat

Re: [PR] KAFKA-17515: Fix flaky RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener [kafka]

2024-09-18 Thread via GitHub
chenyulin0719 commented on code in PR #17187: URL: https://github.com/apache/kafka/pull/17187#discussion_r1764864632 ## streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java: ## @@ -579,12 +580,15 @@ public void shouldInvokeUserDefinedGlobalStat

[jira] [Comment Edited] (KAFKA-17515) Fix flaky RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener

2024-09-18 Thread Yu-Lin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882672#comment-17882672 ] Yu-Lin Chen edited comment on KAFKA-17515 at 9/18/24 11:14 AM: ---

Re: [PR] KAFKA-17515: Fix flaky RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener [kafka]

2024-09-18 Thread via GitHub
chenyulin0719 commented on code in PR #17187: URL: https://github.com/apache/kafka/pull/17187#discussion_r1764866480 ## streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java: ## @@ -634,6 +634,19 @@ public static void waitForStandbyCompletion

Re: [PR] KAFKA-17515: Fix flaky RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener [kafka]

2024-09-18 Thread via GitHub
chenyulin0719 commented on code in PR #17187: URL: https://github.com/apache/kafka/pull/17187#discussion_r1764866283 ## streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java: ## @@ -579,12 +580,15 @@ public void shouldInvokeUserDefinedGlobalStat

Re: [PR] KAFKA-17515: Fix flaky RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener [kafka]

2024-09-18 Thread via GitHub
chenyulin0719 commented on code in PR #17187: URL: https://github.com/apache/kafka/pull/17187#discussion_r1764864632 ## streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java: ## @@ -579,12 +580,15 @@ public void shouldInvokeUserDefinedGlobalStat

[jira] [Comment Edited] (KAFKA-17515) Fix flaky RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener

2024-09-18 Thread Yu-Lin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882672#comment-17882672 ] Yu-Lin Chen edited comment on KAFKA-17515 at 9/18/24 11:05 AM: ---

[jira] [Commented] (KAFKA-17515) Fix flaky RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener

2024-09-18 Thread Yu-Lin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882672#comment-17882672 ] Yu-Lin Chen commented on KAFKA-17515: - The another flaky was caused by long initiali

[jira] [Comment Edited] (KAFKA-17515) Fix flaky RestoreIntegrationTest.shouldInvokeUserDefinedGlobalStateRestoreListener

2024-09-18 Thread Yu-Lin Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882672#comment-17882672 ] Yu-Lin Chen edited comment on KAFKA-17515 at 9/18/24 11:03 AM: ---

  1   2   >