omkreddy merged PR #16340:
URL: https://github.com/apache/kafka/pull/16340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
frankvicky opened a new pull request, #16350:
URL: https://github.com/apache/kafka/pull/16350
Migrate test of connect module to Junit5
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
artemlivshits commented on code in PR #16332:
URL: https://github.com/apache/kafka/pull/16332#discussion_r1640809221
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1257,6 +1261,9 @@ public void flush() {
this.sender.wakeup();
ableegoldman opened a new pull request, #16349:
URL: https://github.com/apache/kafka/pull/16349
End-to-end integration test for the new TaskAssignor interface and public
config. This test builds on top of the existing TaskAssignorIntegrationTest
which simply checked the assignor configurati
DL1231 commented on PR #15067:
URL: https://github.com/apache/kafka/pull/15067#issuecomment-2169160642
@AndrewJSchofield I've resolved the conflict, PTAL, thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chia7712 commented on code in PR #16317:
URL: https://github.com/apache/kafka/pull/16317#discussion_r1640810468
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -515,14 +524,20 @@ private void deleteAndVerifyConfig(Admin client,
Optional brokerId, Set<
jlprat commented on PR #16310:
URL: https://github.com/apache/kafka/pull/16310#issuecomment-2169158166
Hi @chia7712 we can let it stay in the 3.8 branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chia7712 commented on code in PR #16348:
URL: https://github.com/apache/kafka/pull/16348#discussion_r1640779452
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/TopologyTest.scala:
##
@@ -54,6 +42,7 @@ import scala.jdk.CollectionConverters._
*/
//noinspe
m1a2st commented on PR #16019:
URL: https://github.com/apache/kafka/pull/16019#issuecomment-2169144736
I think that seperate to three PRs are good, these formatter are not
dependency for each other.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
[
https://issues.apache.org/jira/browse/KAFKA-16747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Dixit updated KAFKA-16747:
--
Fix Version/s: 4.0.0
3.9.0
> Implement share sessions and context
> ---
[
https://issues.apache.org/jira/browse/KAFKA-16747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Dixit updated KAFKA-16747:
--
Fix Version/s: (was: 4.0.0)
> Implement share sessions and context
> -
ashoke-cube commented on code in PR #16095:
URL: https://github.com/apache/kafka/pull/16095#discussion_r1640754632
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -231,6 +231,12 @@ private synchronized void onFailure(Throwable t) {
dujian0068 commented on code in PR #16348:
URL: https://github.com/apache/kafka/pull/16348#discussion_r1640747850
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/TopologyTest.scala:
##
@@ -54,6 +42,7 @@ import scala.jdk.CollectionConverters._
*/
//noins
chia7712 merged PR #16277:
URL: https://github.com/apache/kafka/pull/16277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-14567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855179#comment-17855179
]
A. Sophie Blee-Goldman commented on KAFKA-14567:
[~cadonna] [~mjsax] do
chia7712 commented on PR #16083:
URL: https://github.com/apache/kafka/pull/16083#issuecomment-2169107085
@TaiJuWu any updates? I do love those docs improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
chia7712 commented on PR #16019:
URL: https://github.com/apache/kafka/pull/16019#issuecomment-2169105054
This PR includes many migration, and hence it gets a bit complicated. Maybe
we should separate it into different PRs. For example:
1. move `TransactionLog` to `transaction-coordina
chia7712 commented on code in PR #16348:
URL: https://github.com/apache/kafka/pull/16348#discussion_r1640643644
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/TopologyTest.scala:
##
@@ -54,6 +42,7 @@ import scala.jdk.CollectionConverters._
*/
//noinspe
chia7712 commented on PR #16297:
URL: https://github.com/apache/kafka/pull/16297#issuecomment-2169079745
@gongxuanzhang could you please fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 merged PR #16278:
URL: https://github.com/apache/kafka/pull/16278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #16310:
URL: https://github.com/apache/kafka/pull/16310#issuecomment-2169076981
> Can this get merged into 3.8.0?
Sorry that I did not wait for @jlprat feedback before backporting to 3.8 ...
@jlprat I will revert that if it is unsuitable to be in 3.8 :)
dujian0068 opened a new pull request, #16348:
URL: https://github.com/apache/kafka/pull/16348
[KAFKA-16958
add `STRICT_STUBS` to `EndToEndLatencyTest`,
`OffsetCommitCallbackInvokerTest`, `ProducerPerformanceTest`, and
`TopologyTest`](https://issues.apache.org/jira/browse/KAFKA-16958?jql=
[
https://issues.apache.org/jira/browse/KAFKA-16967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855172#comment-17855172
]
Greg Harris commented on KAFKA-16967:
-
Thanks for picking this up [~frankvicky] . Do
[
https://issues.apache.org/jira/browse/KAFKA-16967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855170#comment-17855170
]
Greg Harris commented on KAFKA-16967:
-
I looked into the IllegalStateException more
kirktrue commented on PR #16310:
URL: https://github.com/apache/kafka/pull/16310#issuecomment-2169044767
@jlprat Can this get merged into 3.8.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
[
https://issues.apache.org/jira/browse/KAFKA-16960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855167#comment-17855167
]
Matthias J. Sax commented on KAFKA-16960:
-
I applied Justine's patch locally and
jolshan merged PR #16342:
URL: https://github.com/apache/kafka/pull/16342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-16547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16547:
--
Assignee: TengYao Chi (was: Ming-Yen Chung)
> add test for DescribeConfigsOptions#in
[
https://issues.apache.org/jira/browse/KAFKA-16547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855164#comment-17855164
]
TengYao Chi commented on KAFKA-16547:
-
It seems this issue is not working now, I wou
[
https://issues.apache.org/jira/browse/KAFKA-16546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16546:
--
Assignee: xuanzhang gong (was: Chia Chuan Yu)
> add docs to explain how to update cl
[
https://issues.apache.org/jira/browse/KAFKA-16546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855163#comment-17855163
]
xuanzhang gong commented on KAFKA-16546:
I will handle this issue
> add docs to
chia7712 commented on code in PR #16341:
URL: https://github.com/apache/kafka/pull/16341#discussion_r1640577317
##
storage/src/test/java/org/apache/kafka/storage/internals/log/TimeIndexTest.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
chia7712 commented on code in PR #16280:
URL: https://github.com/apache/kafka/pull/16280#discussion_r1640574384
##
core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala:
##
@@ -472,6 +472,80 @@ class DynamicConfigChangeTest extends
KafkaServerTestHarness {
}
[
https://issues.apache.org/jira/browse/KAFKA-16960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855162#comment-17855162
]
Matthias J. Sax edited comment on KAFKA-16960 at 6/15/24 1:13 AM:
chia7712 commented on PR #16210:
URL: https://github.com/apache/kafka/pull/16210#issuecomment-2169017877
@dopuskh3 thanks for you contribution and @kamalcph thanks for your great
reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
chia7712 merged PR #16210:
URL: https://github.com/apache/kafka/pull/16210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855162#comment-17855162
]
Matthias J. Sax commented on KAFKA-16960:
-
I looked into the test run and found
Colin McCabe created KAFKA-16968:
Summary: Make 3.8-IV0 a stable MetadataVersion and create 3.9-IV0
Key: KAFKA-16968
URL: https://issues.apache.org/jira/browse/KAFKA-16968
Project: Kafka
Issu
[
https://issues.apache.org/jira/browse/KAFKA-16967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16967:
--
Assignee: TengYao Chi
> NioEchoServer fails to register connection and causes flaky f
[
https://issues.apache.org/jira/browse/KAFKA-16967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855161#comment-17855161
]
TengYao Chi commented on KAFKA-16967:
-
If this ticket is open, I would like to fix i
[
https://issues.apache.org/jira/browse/KAFKA-16967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-16967:
Issue Type: Bug (was: Task)
> NioEchoServer fails to register connection and causes flaky failure
[
https://issues.apache.org/jira/browse/KAFKA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855158#comment-17855158
]
Chia-Ping Tsai commented on KAFKA-16637:
push to trunk [0] and 3.8 [1]
[0]
htt
chia7712 merged PR #16310:
URL: https://github.com/apache/kafka/pull/16310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
Greg Harris created KAFKA-16967:
---
Summary: NioEchoServer fails to register connection and causes
flaky failure
Key: KAFKA-16967
URL: https://issues.apache.org/jira/browse/KAFKA-16967
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855156#comment-17855156
]
Chia-Ping Tsai commented on KAFKA-16936:
[~gharris1727] thanks for raising this
junrao commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1640456908
##
server-common/src/main/java/org/apache/kafka/server/common/TestFeatureVersion.java:
##
@@ -21,10 +21,10 @@
public enum TestFeatureVersion implements FeatureVersion
[
https://issues.apache.org/jira/browse/KAFKA-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-16143:
-
Fix Version/s: 3.9.0
(was: 4.0.0)
> New metrics for KIP-848 protocol
> --
[
https://issues.apache.org/jira/browse/KAFKA-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-16110:
-
Fix Version/s: 3.9.0
(was: 4.0.0)
> Document and publicize performance te
[
https://issues.apache.org/jira/browse/KAFKA-16256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-16256:
-
Fix Version/s: 3.9.0
(was: 4.0.0)
> Update ConsumerConfig to validate use
[
https://issues.apache.org/jira/browse/KAFKA-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-16441:
-
Fix Version/s: 3.9.0
(was: 4.0.0)
> Update streams_broker_down_resilience
[
https://issues.apache.org/jira/browse/KAFKA-16442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-16442:
-
Fix Version/s: 3.9.0
(was: 4.0.0)
> Update streams_standby_replica_test.p
[
https://issues.apache.org/jira/browse/KAFKA-16443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-16443:
-
Fix Version/s: 3.9.0
(was: 4.0.0)
> Update streams_static_membership_test
[
https://issues.apache.org/jira/browse/KAFKA-16618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-16618:
-
Fix Version/s: 3.9.0
(was: 4.0.0)
> Update the RPC for ConsumerGroupHeart
[
https://issues.apache.org/jira/browse/KAFKA-16541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-16541:
-
Fix Version/s: 3.8.0
(was: 4.0.0)
> Potential leader epoch checkpoint fil
[
https://issues.apache.org/jira/browse/KAFKA-16899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-16899:
-
Fix Version/s: 3.9.0
(was: 4.0.0)
> Rename MembershipManagerImpl's rebala
[
https://issues.apache.org/jira/browse/KAFKA-16914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-16914:
-
Fix Version/s: 3.9.0
(was: 4.0.0)
> Add Share Group dynamic and broker co
[
https://issues.apache.org/jira/browse/KAFKA-16924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-16924:
-
Fix Version/s: 3.9.0
(was: 4.0.0)
> No log output when running kafka
> -
[
https://issues.apache.org/jira/browse/KAFKA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-16916:
-
Fix Version/s: 3.9.0
(was: 4.0.0)
> ClientAuthenticationFailureTest.testA
mjsax merged PR #16336:
URL: https://github.com/apache/kafka/pull/16336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
harryfallows commented on code in PR #16280:
URL: https://github.com/apache/kafka/pull/16280#discussion_r1640385788
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -239,19 +239,24 @@ class BrokerConfigHandler(private val brokerConfig:
KafkaConfig,
def proces
ahuang98 opened a new pull request, #16346:
URL: https://github.com/apache/kafka/pull/16346
We should print exception information
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ]
jolshan commented on PR #16342:
URL: https://github.com/apache/kafka/pull/16342#issuecomment-2168746471
We had one version fail to build anyway, so I pushed the new commit. Should
be good to merge once the job is done.
--
This is an automated message from the Apache Git Service.
To re
[
https://issues.apache.org/jira/browse/KAFKA-16936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855139#comment-17855139
]
Greg Harris commented on KAFKA-16936:
-
Hi [~muralibasani] [~chia7712] [~mimaison] I
[
https://issues.apache.org/jira/browse/KAFKA-16946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-16946.
--
Resolution: Fixed
> Utils.getHost/getPort cannot parse SASL_PLAINTEXT://host:port
> --
cmccabe merged PR #16319:
URL: https://github.com/apache/kafka/pull/16319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-9015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855137#comment-17855137
]
Shekhar Prasad Rajak commented on KAFKA-9015:
-
I would like to work in this.
[
https://issues.apache.org/jira/browse/KAFKA-12678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855131#comment-17855131
]
Shekhar Prasad Rajak commented on KAFKA-12678:
--
I would like to work on thi
[
https://issues.apache.org/jira/browse/KAFKA-16768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-16768:
Labels: newbie (was: )
> SocketServer leaks accepted SocketChannel instances due to race conditio
[
https://issues.apache.org/jira/browse/KAFKA-16765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-16765:
Labels: newbie (was: )
> NioEchoServer leaks accepted SocketChannel instances due to race conditi
[
https://issues.apache.org/jira/browse/KAFKA-16965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alieh Saeedi reassigned KAFKA-16965:
Assignee: Alieh Saeedi
> Add a "root cause" exception as a nested exception to TimeoutExc
aliehsaeedii commented on code in PR #16344:
URL: https://github.com/apache/kafka/pull/16344#discussion_r1640221918
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1176,18 +1178,25 @@ private ClusterAndWaitTime waitOnMetadata(String topic,
kirktrue commented on PR #16310:
URL: https://github.com/apache/kafka/pull/16310#issuecomment-2168568698
@AndrewJSchofield @cadonna @chia7712 @lianetm @philipnee: this PR is ready
to be re-reviewed. Thanks all for your continued input 😄
--
This is an automated message from the Apache Git
kirktrue commented on code in PR #16310:
URL: https://github.com/apache/kafka/pull/16310#discussion_r1640213245
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1666,23 +1668,68 @@ private boolean initWithCommittedOffsetsIfNeed
gharris1727 commented on code in PR #16303:
URL: https://github.com/apache/kafka/pull/16303#discussion_r1640209104
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java:
##
@@ -84,42 +78,41 @@ public class ConsumerTaskTest {
pr
[
https://issues.apache.org/jira/browse/KAFKA-16966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16966:
--
Description:
In {{{}initWithCommittedOffsetsIfNeeded{}}}, the behavior of the existing
{{LegacyKafkaC
Kirk True created KAFKA-16966:
-
Summary: Allow offset commit fetch to reuse previous request if
partitions are a subset
Key: KAFKA-16966
URL: https://issues.apache.org/jira/browse/KAFKA-16966
Project: Kaf
kirktrue commented on code in PR #16310:
URL: https://github.com/apache/kafka/pull/16310#discussion_r1640209483
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1666,23 +1668,68 @@ private boolean initWithCommittedOffsetsIfNeed
mjsax commented on code in PR #16344:
URL: https://github.com/apache/kafka/pull/16344#discussion_r1640177695
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1176,18 +1178,25 @@ private ClusterAndWaitTime waitOnMetadata(String topic,
Integer
[
https://issues.apache.org/jira/browse/KAFKA-16965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16965:
Component/s: producer
> Add a "root cause" exception as a nested exception to TimeoutExce
mjsax merged PR #16337:
URL: https://github.com/apache/kafka/pull/16337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on code in PR #16337:
URL: https://github.com/apache/kafka/pull/16337#discussion_r1640160017
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -635,14 +634,10 @@ public void setStandbyUpdateListener(final
StandbyUpdateListener standbyLis
chia7712 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1640136697
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,834 +16,986 @@
*/
package org.apache.kafka.tools.consumer.gro
chia7712 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1640133745
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,834 +16,986 @@
*/
package org.apache.kafka.tools.consumer.gro
chia7712 commented on code in PR #16280:
URL: https://github.com/apache/kafka/pull/16280#discussion_r1640131270
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -239,19 +239,24 @@ class BrokerConfigHandler(private val brokerConfig:
KafkaConfig,
def processCon
kirktrue commented on code in PR #16310:
URL: https://github.com/apache/kafka/pull/16310#discussion_r1640117064
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1666,23 +1668,68 @@ private boolean initWithCommittedOffsetsIfNeed
kirktrue commented on code in PR #16310:
URL: https://github.com/apache/kafka/pull/16310#discussion_r1640115221
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1666,23 +1668,68 @@ private boolean initWithCommittedOffsetsIfNeed
chia7712 commented on code in PR #16310:
URL: https://github.com/apache/kafka/pull/16310#discussion_r1640111560
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1666,23 +1668,68 @@ private boolean initWithCommittedOffsetsIfNeed
jolshan commented on PR #16342:
URL: https://github.com/apache/kafka/pull/16342#issuecomment-2168410893
@edoardocomar I can add the commit but it will also restart the build. Given
this shouldn't alter code, I'm not sure if we still want to run all the tests.
--
This is an automated messa
kirktrue commented on code in PR #16310:
URL: https://github.com/apache/kafka/pull/16310#discussion_r1640101706
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1666,23 +1668,68 @@ private boolean initWithCommittedOffsetsIfNeed
chia7712 merged PR #16330:
URL: https://github.com/apache/kafka/pull/16330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #16330:
URL: https://github.com/apache/kafka/pull/16330#issuecomment-2168378242
failed tests pass on my local
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mumrah commented on PR #15918:
URL: https://github.com/apache/kafka/pull/15918#issuecomment-2168375635
Thanks for the review @soarez! Sorry it took me so long to get back to this.
Been busy migrating clusters to KRaft :)
--
This is an automated message from the Apache Git Service.
To res
mumrah commented on code in PR #15918:
URL: https://github.com/apache/kafka/pull/15918#discussion_r1640060787
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -491,6 +536,13 @@ public void run() throws Exception {
re
mumrah commented on code in PR #15918:
URL: https://github.com/apache/kafka/pull/15918#discussion_r1640060787
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -491,6 +536,13 @@ public void run() throws Exception {
re
tinaselenge commented on code in PR #15175:
URL: https://github.com/apache/kafka/pull/15175#discussion_r1640059705
##
core/src/test/scala/integration/kafka/api/SslAdminIntegrationTest.scala:
##
@@ -42,6 +42,7 @@ object SslAdminIntegrationTest {
@volatile var lastUpdateRequest
chia7712 merged PR #16328:
URL: https://github.com/apache/kafka/pull/16328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
aliehsaeedii opened a new pull request, #16344:
URL: https://github.com/apache/kafka/pull/16344
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of te
mumrah commented on code in PR #15918:
URL: https://github.com/apache/kafka/pull/15918#discussion_r1640047647
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -230,16 +234,24 @@ private boolean areZkBrokersReadyForMigration() {
Alieh Saeedi created KAFKA-16965:
Summary: Add a "root cause" exception as a nested exception to
TimeoutException for Producer
Key: KAFKA-16965
URL: https://issues.apache.org/jira/browse/KAFKA-16965
P
edoardocomar commented on PR #16342:
URL: https://github.com/apache/kafka/pull/16342#issuecomment-2168346904
I tested this fix too LGTM - thanks @jolshan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
1 - 100 of 234 matches
Mail list logo
