chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1582583036
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/KAFKA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16640:
--
Assignee: TengYao Chi (was: Chia-Ping Tsai)
> Replace TestUtils#resource by scala.ut
github-actions[bot] commented on PR #15283:
URL: https://github.com/apache/kafka/pull/15283#issuecomment-2081835478
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
brandboat commented on code in PR #15745:
URL: https://github.com/apache/kafka/pull/15745#discussion_r1582482314
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -160,6 +166,7 @@ public boolean equals(Object object) {
return Objects.equals(type, clusterConfig.
[
https://issues.apache.org/jira/browse/KAFKA-16640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841791#comment-17841791
]
TengYao Chi commented on KAFKA-16640:
-
i am able to handle this issue 😀
> Replace T
dongnuo123 commented on PR #15818:
URL: https://github.com/apache/kafka/pull/15818#issuecomment-2081675669
> @dongnuo123 Thanks for the patch. Could you also check if we have other
cases like this one:
>
>
https://github.com/apache/kafka/blob/e7792258df934a5c8470c2925c5d164c7d5a8e6c/
dongnuo123 commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1582404976
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -10921,6 +10855,544 @@ public void
testLastConsumerProtoc
dongnuo123 commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1582403702
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1413,6 +1506,243 @@ private
CoordinatorResult consumerGr
dongnuo123 commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1582397694
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1169,6 +1175,107 @@ private void
throwIfStaticMemberIsUnknow
dongnuo123 commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1582397540
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1413,6 +1506,243 @@ private
CoordinatorResult consumerGr
dongnuo123 commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1582397180
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -1122,4 +1122,27 @@ private OUT handleOperationException(
chia7712 commented on PR #15696:
URL: https://github.com/apache/kafka/pull/15696#issuecomment-2081646079
> or would like me to add a new test in the test class for the function?
this one. Normally, the patch related to bug fix needs to offer the test to
prove the bug does get fixed :)
chia7712 commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1582294569
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -91,9 +91,6 @@ public Stream
provideTestTemplateInvocationContex
ClusterTemplate clu
chia7712 commented on code in PR #15823:
URL: https://github.com/apache/kafka/pull/15823#discussion_r1582290331
##
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java:
##
@@ -392,14 +392,14 @@ private String
topicPartitionsToLogString(Collection partitions)
chia7712 commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1582280178
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1124,24 +933,18 @@ object TestUtils extends Logging {
}, msg = msg, pause = 0L, waitTimeMs = waitT
Chia-Ping Tsai created KAFKA-16640:
--
Summary: Replace TestUtils#resource by scala.util.Using
Key: KAFKA-16640
URL: https://issues.apache.org/jira/browse/KAFKA-16640
Project: Kafka
Issue Type
chia7712 commented on code in PR #15788:
URL: https://github.com/apache/kafka/pull/15788#discussion_r1582265983
##
core/src/main/scala/kafka/MetadataLogConfig.scala:
##
@@ -32,13 +32,13 @@ final case class MetadataLogConfig(
)
object MetadataLogConfig {
- def apply(config:
chia7712 commented on code in PR #15745:
URL: https://github.com/apache/kafka/pull/15745#discussion_r1582250475
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -55,14 +56,15 @@ public class ClusterConfig {
private final Map>
perBrokerOverrideProperties;
@
[
https://issues.apache.org/jira/browse/KAFKA-16639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841678#comment-17841678
]
Philip Nee commented on KAFKA-16639:
thanks for reporting. will do.
> AsyncKafkaCon
chia7712 commented on PR #15766:
URL: https://github.com/apache/kafka/pull/15766#issuecomment-2081560990
I file https://issues.apache.org/jira/browse/KAFKA-16639 to trace the
potential bug about AsyncConsumer. Please wait for that issue. If the issue is
too hard to resolve, we can remove th
chia7712 commented on PR #15822:
URL: https://github.com/apache/kafka/pull/15822#issuecomment-2081560445
```
[2024-04-28T12:34:14.550Z] [Error]
/home/jenkins/workspace/Kafka_kafka-pr_PR-15822/core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:1000:26:
value KafkaMetricsReporterC
johnnychhsu opened a new pull request, #15826:
URL: https://github.com/apache/kafka/pull/15826
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of tes
[
https://issues.apache.org/jira/browse/KAFKA-16639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841675#comment-17841675
]
Chia-Ping Tsai commented on KAFKA-16639:
[~pnee] Could you please take a look if
Chia-Ping Tsai created KAFKA-16639:
--
Summary: AsyncKafkaConsumer#close does not send heartbeat to leave
group
Key: KAFKA-16639
URL: https://issues.apache.org/jira/browse/KAFKA-16639
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841670#comment-17841670
]
Sal Sorrentino commented on KAFKA-16514:
Well, this is not entirely accurate. As
FrankYang0529 commented on PR #15745:
URL: https://github.com/apache/kafka/pull/15745#issuecomment-2081484120
> @FrankYang0529 please fix the conflicts
Hi @chia7712, I resolve conflicts. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the messag
OmniaGM commented on code in PR #15822:
URL: https://github.com/apache/kafka/pull/15822#discussion_r1582152852
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -77,7 +78,7 @@ public class CommonClientConfigs {
public static final String CL
Omnia Ibrahim created KAFKA-16638:
-
Summary: Align the naming convention for config and default
variables in *Config classes
Key: KAFKA-16638
URL: https://issues.apache.org/jira/browse/KAFKA-16638
Pro
[
https://issues.apache.org/jira/browse/KAFKA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sanghyeok An updated KAFKA-16637:
-
Description:
I want to test next generation of the consumer rebalance protocolÂ
([https://cwiki
[
https://issues.apache.org/jira/browse/KAFKA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sanghyeok An updated KAFKA-16637:
-
Description:
I want to test next generation of the consumer rebalance protocolÂ
([https://cwiki
sanghyeok An created KAFKA-16637:
Summary: KIP-848 does not work well
Key: KAFKA-16637
URL: https://issues.apache.org/jira/browse/KAFKA-16637
Project: Kafka
Issue Type: Bug
Report
[
https://issues.apache.org/jira/browse/KAFKA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
sanghyeok An updated KAFKA-16637:
-
Priority: Minor (was: Major)
> KIP-848 does not work well
> --
>
>
kamalcph commented on code in PR #15634:
URL: https://github.com/apache/kafka/pull/15634#discussion_r1582149811
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -282,15 +282,15 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Update high watermark w
kamalcph opened a new pull request, #15825:
URL: https://github.com/apache/kafka/pull/15825
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
kamalcph commented on code in PR #15634:
URL: https://github.com/apache/kafka/pull/15634#discussion_r1582144306
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -282,15 +282,15 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Update high watermark w
kamalcph commented on code in PR #15634:
URL: https://github.com/apache/kafka/pull/15634#discussion_r1582144306
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -282,15 +282,15 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Update high watermark w
kamalcph commented on code in PR #15634:
URL: https://github.com/apache/kafka/pull/15634#discussion_r1582144306
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -282,15 +282,15 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Update high watermark w
OmniaGM commented on code in PR #15822:
URL: https://github.com/apache/kafka/pull/15822#discussion_r1582144106
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -77,7 +78,7 @@ public class CommonClientConfigs {
public static final String CL
[
https://issues.apache.org/jira/browse/KAFKA-15156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez reassigned KAFKA-15156:
Assignee: (was: Walter Hernandez)
> Update cipherInformation correctly in Def
brandboat opened a new pull request, #15824:
URL: https://github.com/apache/kafka/pull/15824
related to [KAFKA-16627](https://issues.apache.org/jira/browse/KAFKA-16627)
In the past we modify configs like server broker properties by modifying the
ClusterConfig reference passed to Befor
johnnychhsu commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2081407268
thanks @chia7712!
just rebased and fixed the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kamalcph commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1582059485
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -54,5 +180,109 @@ PartitionFetchState start(TopicPartition topicPartition,
* @return the new Part
chiacyu commented on code in PR #15823:
URL: https://github.com/apache/kafka/pull/15823#discussion_r1582059240
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1491,7 +1490,7 @@ public void assign(Collection partitions)
{
kamalcph commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1582055490
##
storage/src/test/java/org/apache/kafka/tiered/storage/integration/TransactionsWithTieredStoreTest.java:
##
@@ -74,7 +74,7 @@ public Properties topicConfig() {
chia7712 commented on code in PR #15823:
URL: https://github.com/apache/kafka/pull/15823#discussion_r1582049275
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1491,7 +1490,7 @@ public void assign(Collection partitions)
{
[
https://issues.apache.org/jira/browse/KAFKA-15897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841597#comment-17841597
]
Chia-Ping Tsai commented on KAFKA-15897:
It seems the root cause is that `contex
46 matches
Mail list logo
