[
https://issues.apache.org/jira/browse/KAFKA-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819929#comment-17819929
]
Vaibhav Kushwaha commented on KAFKA-4094:
-
Hi [~jkreps] Shall I pick this ticket
federico-weisse-sportsbet commented on code in PR #15413:
URL: https://github.com/apache/kafka/pull/15413#discussion_r1500201095
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractCon
ableegoldman commented on code in PR #15416:
URL: https://github.com/apache/kafka/pull/15416#discussion_r1500214172
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##
@@ -663,6 +663,7 @@ private void assignOwnedPartitions() {
federico-weisse-sportsbet commented on code in PR #15413:
URL: https://github.com/apache/kafka/pull/15413#discussion_r1500201095
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractCon
federico-weisse-sportsbet commented on code in PR #15413:
URL: https://github.com/apache/kafka/pull/15413#discussion_r1500197041
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractCon
lianetm commented on PR #15415:
URL: https://github.com/apache/kafka/pull/15415#issuecomment-1960700348
Merged trunked latest changes fixing build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lianetm commented on PR #15392:
URL: https://github.com/apache/kafka/pull/15392#issuecomment-1960698893
Broken builds were just fixed in trunk. Merged latest changes here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
github-actions[bot] commented on PR #14760:
URL: https://github.com/apache/kafka/pull/14760#issuecomment-1960687556
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
github-actions[bot] commented on PR #14837:
URL: https://github.com/apache/kafka/pull/14837#issuecomment-1960687526
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
[
https://issues.apache.org/jira/browse/KAFKA-12549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-12549.
-
Resolution: Duplicate
Closing this ticket in favor of K14412.
> Allow state stores to o
mjsax commented on PR #12393:
URL: https://github.com/apache/kafka/pull/12393#issuecomment-1960672595
Closing this PR as stale. KIP-844 was discarded in favor of KIP-892.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mjsax closed pull request #12393: WIP: KAFKA-12549 Prototype for transactional
state stores
URL: https://github.com/apache/kafka/pull/12393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
mjsax commented on code in PR #15419:
URL: https://github.com/apache/kafka/pull/15419#discussion_r1500165337
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData buildRe
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1500157846
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/StreamJoinedTest.scala:
##
@@ -16,22 +16,36 @@
*/
package org.apache.kafka.streams.scal
[
https://issues.apache.org/jira/browse/KAFKA-16277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819877#comment-17819877
]
Cameron Redpath commented on KAFKA-16277:
-
We have a PR ready for review with a
[
https://issues.apache.org/jira/browse/KAFKA-16277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819877#comment-17819877
]
Cameron Redpath edited comment on KAFKA-16277 at 2/23/24 2:26 AM:
mjsax merged PR #12740:
URL: https://github.com/apache/kafka/pull/12740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on code in PR #15372:
URL: https://github.com/apache/kafka/pull/15372#discussion_r1500151525
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -232,13 +232,22 @@ public MembershipManager membershipManager() {
agavra opened a new pull request, #15424:
URL: https://github.com/apache/kafka/pull/15424
See https://github.com/apache/kafka/pull/14648#discussion_r1499780993 --
turns out I didn't use it because it wasn't included as a build dependency 😆
cc @ableegoldman @ijuma
### Committe
gharris1727 opened a new pull request, #15423:
URL: https://github.com/apache/kafka/pull/15423
These really should have gone out with each of the tickets, but I thought
the changes were less notable than they turned out to be 🙃
### Committer Checklist (excluded from commit message)
Greg Harris created KAFKA-16303:
---
Summary: Add upgrade notes about recent MM2 offset translation
changes
Key: KAFKA-16303
URL: https://issues.apache.org/jira/browse/KAFKA-16303
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan resolved KAFKA-16302.
Resolution: Fixed
> Builds failing due to streams test execution failures
> --
jolshan commented on code in PR #15413:
URL: https://github.com/apache/kafka/pull/15413#discussion_r1500128231
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractConfig {
jolshan merged PR #15422:
URL: https://github.com/apache/kafka/pull/15422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
federico-weisse-sportsbet commented on code in PR #15413:
URL: https://github.com/apache/kafka/pull/15413#discussion_r1500118164
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractCon
jolshan commented on PR #15422:
URL: https://github.com/apache/kafka/pull/15422#issuecomment-1960589848
I'll run streams locally as a double check and then merge 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
ableegoldman commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1500111316
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/StreamJoinedTest.scala:
##
@@ -16,22 +16,36 @@
*/
package org.apache.kafka.stream
[
https://issues.apache.org/jira/browse/KAFKA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-15202:
Fix Version/s: 3.6.0
> MM2 OffsetSyncStore clears too many syncs when sync spacing is variable
> -
[
https://issues.apache.org/jira/browse/KAFKA-16301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16301:
--
Fix Version/s: 3.8.0
> Review fenced member unsubscribe/subscribe callbacks interaction
>
[
https://issues.apache.org/jira/browse/KAFKA-16302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16302:
Component/s: streams
unit tests
> Builds failing due to streams test exec
[
https://issues.apache.org/jira/browse/KAFKA-16302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-16302:
---
Assignee: Justine Olshan
> Builds failing due to streams test execution failures
>
stanislavkozlovski commented on PR #15407:
URL: https://github.com/apache/kafka/pull/15407#issuecomment-1960510328
cherry-picked to 3.7 with 9603d4c9ef
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
jolshan commented on code in PR #15413:
URL: https://github.com/apache/kafka/pull/15413#discussion_r1500063914
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractConfig {
gharris1727 commented on PR #15422:
URL: https://github.com/apache/kafka/pull/15422#issuecomment-1960494013
> The metric should be sufficient to test this. Not sure we need the log.
I didn't read the full test before commenting earlier. I think this is
reasonable then.
The test
jolshan commented on PR #15422:
URL: https://github.com/apache/kafka/pull/15422#issuecomment-1960491986
>This whole appender block is unused now that log messages aren't being
asserted on.
Good point, I can remove
> Can we revert the log message removal instead?
Or bring it
gharris1727 commented on PR #15422:
URL: https://github.com/apache/kafka/pull/15422#issuecomment-1960490363
Thanks for root-causing this so quickly @jolshan I was just seeing it pop up
in my PR builds.
--
This is an automated message from the Apache Git Service.
To respond to the message,
junrao commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1500047932
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +520,124 @@ public void run() {
}
}
}
+
+// Visibl
jolshan commented on PR #15396:
URL: https://github.com/apache/kafka/pull/15396#issuecomment-1960482583
fyi: https://github.com/apache/kafka/pull/15422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
jolshan opened a new pull request, #15422:
URL: https://github.com/apache/kafka/pull/15422
https://github.com/apache/kafka/commit/a3528a316f4df969b9995f00af89161a5840a547
removed this log but not the test asserting it.
Builds are currently red because for some reason these tests can'
federico-weisse-sportsbet commented on code in PR #15413:
URL: https://github.com/apache/kafka/pull/15413#discussion_r1500038952
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractCon
stanislavkozlovski merged PR #15418:
URL: https://github.com/apache/kafka/pull/15418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@ka
apoorvmittal10 commented on code in PR #15251:
URL: https://github.com/apache/kafka/pull/15251#discussion_r1500028907
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -493,4 +520,124 @@ public void run() {
}
}
}
+
+/
[
https://issues.apache.org/jira/browse/KAFKA-16302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819835#comment-17819835
]
Justine Olshan commented on KAFKA-16302:
Root cause is [https://github.com/apach
jolshan commented on PR #15396:
URL: https://github.com/apache/kafka/pull/15396#issuecomment-1960438257
Hey this broke the following tests that expect this log message:
```
RocksDBSegmentedBytesStoreTest.
shouldLogAndMeasureExpiredRecords[org.apache.kafka.streams.state.internals.Sessio
jolshan commented on PR #15369:
URL: https://github.com/apache/kafka/pull/15369#issuecomment-1960437037
Looks like it was actually this one:
https://github.com/apache/kafka/pull/15396. I will follow up there.
--
This is an automated message from the Apache Git Service.
To respond to the m
[
https://issues.apache.org/jira/browse/KAFKA-16302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-16302:
---
Description:
I'm seeing this on master and many PR builds for all versions:
{code:java}
[
Justine Olshan created KAFKA-16302:
--
Summary: Builds failing due to streams test execution failures
Key: KAFKA-16302
URL: https://issues.apache.org/jira/browse/KAFKA-16302
Project: Kafka
Iss
jolshan commented on code in PR #15413:
URL: https://github.com/apache/kafka/pull/15413#discussion_r155366
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -231,7 +231,7 @@ public class ProducerConfig extends AbstractConfig {
lianetm commented on PR #15392:
URL: https://github.com/apache/kafka/pull/15392#issuecomment-1960416632
Last build failed, so I rebased to trigger it again with the latest and take
another look at the logs. I had missed
`testPerPartitionLagMetricsWhenReadCommitted`, took a look at the logs
[
https://issues.apache.org/jira/browse/KAFKA-16294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongnuo Lyu updated KAFKA-16294:
Description:
The offline upgrade is triggered when a consumer group heartbeat request is
received
jolshan commented on PR #15369:
URL: https://github.com/apache/kafka/pull/15369#issuecomment-1960394359
Hmm after this was merged, I'm seeing failed builds on every master build.
```
[2024-02-22T21:19:13.914Z] Execution failed for task ':streams:test'.
[2024-02-22T21:19:13.914Z]
ijuma commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1499955177
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/StreamJoinedTest.scala:
##
@@ -16,22 +16,36 @@
*/
package org.apache.kafka.streams.scala
lianetm commented on PR #15415:
URL: https://github.com/apache/kafka/pull/15415#issuecomment-1960329387
Hey @lucasbru. Great push for simplification, went as far as I could see
unifying the leave operations, but still living with the fact that the expired
timer brings up a leave path that's
lianetm commented on code in PR #15415:
URL: https://github.com/apache/kafka/pull/15415#discussion_r1499941957
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -564,7 +587,7 @@ public void transitionToJoining() {
*/
Lianet Magrans created KAFKA-16301:
--
Summary: Review fenced member unsubscribe/subscribe callbacks
interaction
Key: KAFKA-16301
URL: https://issues.apache.org/jira/browse/KAFKA-16301
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fede updated KAFKA-16300:
-
Description:
In documentation from version 3.1 to version 3.4, it looks like the retries
explanation has a bug
[
https://issues.apache.org/jira/browse/KAFKA-16300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fede updated KAFKA-16300:
-
Description:
In documentation from version 3.1 to version 3.4, it looks like the retries
explanation has a bug
lianetm commented on code in PR #15415:
URL: https://github.com/apache/kafka/pull/15415#discussion_r1499920005
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberState.java:
##
@@ -132,11 +132,20 @@ public enum MemberState {
PREPARE_LEAVING.previ
[
https://issues.apache.org/jira/browse/KAFKA-16300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fede updated KAFKA-16300:
-
Description:
In documentation from version 3.1 to version 3.4, it looks like the retries
explanation has a bug
[
https://issues.apache.org/jira/browse/KAFKA-16299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Kim updated KAFKA-16299:
-
Description:
In the new coordinator, the classic group response handling is not consistent
compared to
Fede created KAFKA-16300:
Summary: Wrong documentation for producer config retries
Key: KAFKA-16300
URL: https://issues.apache.org/jira/browse/KAFKA-16300
Project: Kafka
Issue Type: Bug
Com
Jeff Kim created KAFKA-16299:
Summary: Classic group error responses should contain a no
generation id and an empty members list
Key: KAFKA-16299
URL: https://issues.apache.org/jira/browse/KAFKA-16299
Pro
lianetm commented on code in PR #15415:
URL: https://github.com/apache/kafka/pull/15415#discussion_r1499894219
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -215,6 +216,7 @@ public NetworkClientDelegate.PollResult poll(l
[
https://issues.apache.org/jira/browse/KAFKA-16298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16298:
--
Fix Version/s: 3.8.0
> Ensure user callbacks exceptions are propagated to the user on consumer poll
>
[
https://issues.apache.org/jira/browse/KAFKA-16298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16298:
--
Labels: callback kip-848-client-support (was: kip-848-client-support)
> Ensure user callbacks excepti
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1499787175
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/StreamJoinedTest.scala:
##
@@ -16,22 +16,36 @@
*/
package org.apache.kafka.streams.scal
agavra commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1499784399
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/StreamJoinedTest.scala:
##
@@ -16,22 +16,36 @@
*/
package org.apache.kafka.streams.scal
ijuma commented on code in PR #14648:
URL: https://github.com/apache/kafka/pull/14648#discussion_r1499780993
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/StreamJoinedTest.scala:
##
@@ -16,22 +16,36 @@
*/
package org.apache.kafka.streams.scala
ijuma commented on code in PR #14876:
URL: https://github.com/apache/kafka/pull/14876#discussion_r1499766780
##
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##
@@ -179,6 +179,7 @@ class FetchFromFollowerIntegrationTest extends
BaseFetchRe
[
https://issues.apache.org/jira/browse/KAFKA-16298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16298:
---
Description: When user-defined callbacks fail with an exception, the
expectation is that the
[
https://issues.apache.org/jira/browse/KAFKA-16298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16298:
---
Description: When user-defined callbacks fail with an exception, the
expectation is that the
CalvinConfluent commented on code in PR #15265:
URL: https://github.com/apache/kafka/pull/15265#discussion_r1499752721
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2108,9 +2146,12 @@ void handleFailure(Throwable throwable) {
public D
Lianet Magrans created KAFKA-16298:
--
Summary: Ensure user callbacks exceptions are propagated to the
user on consumer poll
Key: KAFKA-16298
URL: https://issues.apache.org/jira/browse/KAFKA-16298
Proj
jolshan commented on PR #15384:
URL: https://github.com/apache/kafka/pull/15384#issuecomment-1960018327
Something wrong with the build so I will restart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jolshan commented on code in PR #15384:
URL: https://github.com/apache/kafka/pull/15384#discussion_r1499709434
##
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionStateManagerTest.scala:
##
@@ -513,12 +514,16 @@ class TransactionStateManagerTest {
putTran
yyu1993 commented on code in PR #15384:
URL: https://github.com/apache/kafka/pull/15384#discussion_r1499702168
##
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionStateManagerTest.scala:
##
@@ -527,16 +532,20 @@ class TransactionStateManagerTest {
def asser
yyu1993 commented on code in PR #15384:
URL: https://github.com/apache/kafka/pull/15384#discussion_r1499698463
##
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionStateManagerTest.scala:
##
@@ -513,12 +514,16 @@ class TransactionStateManagerTest {
putTran
lianetm commented on code in PR #15415:
URL: https://github.com/apache/kafka/pull/15415#discussion_r1499559758
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -744,16 +767,34 @@ public boolean isLeavingGroup() {
ret
kirktrue commented on PR #15408:
URL: https://github.com/apache/kafka/pull/15408#issuecomment-1959841458
@lucasbru—Yes, this looks perfect!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
ocadaruma commented on code in PR #14289:
URL: https://github.com/apache/kafka/pull/14289#discussion_r1499548503
##
storage/src/main/java/org/apache/kafka/storage/internals/log/FetchDataInfo.java:
##
@@ -39,19 +40,40 @@ public FetchDataInfo(LogOffsetMetadata fetchOffsetMetadata,
ocadaruma commented on code in PR #14289:
URL: https://github.com/apache/kafka/pull/14289#discussion_r1499537446
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1408,6 +1408,16 @@ class ReplicaManager(val config: KafkaConfig,
// progress in such cases a
divijvaidya commented on PR #15402:
URL: https://github.com/apache/kafka/pull/15402#issuecomment-1959819714
The build is still failing though @testn please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
divijvaidya commented on code in PR #15402:
URL: https://github.com/apache/kafka/pull/15402#discussion_r1499533378
##
checkstyle/suppressions.xml:
##
@@ -92,7 +92,7 @@
files="(Utils|Topic|KafkaLZ4BlockOutputStream|AclData|JoinGroupRequest).java"/>
+
RamanVerma commented on PR #15384:
URL: https://github.com/apache/kafka/pull/15384#issuecomment-1959796902
I think the unit tests look good.
Is it possible to write/edit (in case we have one existing) an integration
test that builds a request and validates the response from broker. Yo
RamanVerma commented on code in PR #15384:
URL: https://github.com/apache/kafka/pull/15384#discussion_r1499456622
##
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionStateManagerTest.scala:
##
@@ -527,16 +532,20 @@ class TransactionStateManagerTest {
def as
lianetm commented on code in PR #15415:
URL: https://github.com/apache/kafka/pull/15415#discussion_r1499490700
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -564,7 +587,7 @@ public void transitionToJoining() {
*/
Cerchie commented on PR #14448:
URL: https://github.com/apache/kafka/pull/14448#issuecomment-1959710205
> Thanks for the PR. Overall LGTM.
>
> I am just wondering if we should also update the JavaDocs for all
deprecated configs? For example:
>
> ```
> /** {@code default.
testn commented on code in PR #15402:
URL: https://github.com/apache/kafka/pull/15402#discussion_r1499417536
##
checkstyle/suppressions.xml:
##
@@ -92,7 +92,7 @@
files="(Utils|Topic|KafkaLZ4BlockOutputStream|AclData|JoinGroupRequest).java"/>
+
[ https://issues.apache.org/jira/browse/KAFKA-16295 ]
Ahmed Sobeh deleted comment on KAFKA-16295:
-
was (Author: JIRAUSER295920):
https://github.com/apache/kafka/pull/15421
> Align RocksDB and in-memory store init() sequence
> --
ahmedsobeh opened a new pull request, #15421:
URL: https://github.com/apache/kafka/pull/15421
For RocksDB stores, we open the store first and then call #register. However
the in-memory store actually registers itself first, before marking itself as
open. This change aligns the RocksDB init
[
https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna closed KAFKA-1.
-
> Ensure wakeups are handled correctly in PrototypeAsyncConsumer.poll()
> --
[
https://issues.apache.org/jira/browse/KAFKA-16295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Sobeh reassigned KAFKA-16295:
---
Assignee: Ahmed Sobeh
> Align RocksDB and in-memory store init() sequence
> ---
[
https://issues.apache.org/jira/browse/KAFKA-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna closed KAFKA-16194.
-
> KafkaConsumer.groupMetadata() should be correct when first records are
> returned
> -
lucasbru commented on code in PR #15383:
URL: https://github.com/apache/kafka/pull/15383#discussion_r1499319626
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -419,6 +422,35 @@ public void testWakeupAfterNonEmptyFetch() {
lucasbru opened a new pull request, #15420:
URL: https://github.com/apache/kafka/pull/15420
Commit 1442862 introduced a test with an assertion inside a listener
callback. This improves the test by checking that the listener is actually
being executed, to avoid silent skipping of the asserti
Igor Soarez created KAFKA-16297:
---
Summary: Race condition while promoting future replica can lead to
partition unavailability.
Key: KAFKA-16297
URL: https://issues.apache.org/jira/browse/KAFKA-16297
Pro
[
https://issues.apache.org/jira/browse/KAFKA-16297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez reassigned KAFKA-16297:
---
Assignee: Igor Soarez
> Race condition while promoting future replica can lead to partition
lucasbru commented on code in PR #15415:
URL: https://github.com/apache/kafka/pull/15415#discussion_r1499180116
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -215,6 +216,7 @@ public NetworkClientDelegate.PollResult poll(
[
https://issues.apache.org/jira/browse/KAFKA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna closed KAFKA-15991.
-
> Flaky new consumer test testGroupIdNotNullAndValid
> -
[
https://issues.apache.org/jira/browse/KAFKA-16292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ahmed Sobeh reassigned KAFKA-16292:
---
Assignee: Ahmed Sobeh
> Revamp upgrade.html page
> -
>
>
1 - 100 of 128 matches
Mail list logo
