clolov commented on PR #15131:
URL: https://github.com/apache/kafka/pull/15131#issuecomment-1878268696
Heya @showuon and thanks for the review! I will make the changes in a couple
of hours
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
VedarthConfluent commented on code in PR #15048:
URL: https://github.com/apache/kafka/pull/15048#discussion_r1442527460
##
core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala:
##
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
VedarthConfluent commented on code in PR #15048:
URL: https://github.com/apache/kafka/pull/15048#discussion_r1442527460
##
core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala:
##
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
[
https://issues.apache.org/jira/browse/KAFKA-15341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803405#comment-17803405
]
Phuc Hong Tran commented on KAFKA-15341:
[~divijvaidya], broker feature is just
showuon commented on PR #15132:
URL: https://github.com/apache/kafka/pull/15132#issuecomment-1878091765
@divijvaidya , this should be the last fix for kafkaApisTest. (Hope so!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
showuon commented on code in PR #15132:
URL: https://github.com/apache/kafka/pull/15132#discussion_r1442473158
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -2061,20 +2071,24 @@ class KafkaApisTest extends Logging {
responseCallback.capture(),
showuon commented on code in PR #15132:
URL: https://github.com/apache/kafka/pull/15132#discussion_r1442472935
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -1669,12 +1671,16 @@ class KafkaApisTest extends Logging {
val request = buildRequest(offsetC
showuon opened a new pull request, #15132:
URL: https://github.com/apache/kafka/pull/15132
I thought we've closed all kafkaApis instances in KafkaApisTest, but there
are more...
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ]
hachikuji commented on code in PR #15119:
URL: https://github.com/apache/kafka/pull/15119#discussion_r1442435868
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClientDriver.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
hachikuji commented on code in PR #15119:
URL: https://github.com/apache/kafka/pull/15119#discussion_r1442426943
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClientDriver.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
[
https://issues.apache.org/jira/browse/KAFKA-16079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-16079.
---
Fix Version/s: 3.7.0
Resolution: Fixed
> Fix leak in
> LocalLeaderEndPointTest/FinalizedFeat
showuon merged PR #15122:
URL: https://github.com/apache/kafka/pull/15122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #15122:
URL: https://github.com/apache/kafka/pull/15122#issuecomment-1877995119
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
jsancio commented on code in PR #15119:
URL: https://github.com/apache/kafka/pull/15119#discussion_r1442414085
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClientDriver.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1442403275
##
gradle/spotbugs-exclude.xml:
##
@@ -162,8 +162,7 @@ For a detailed description of spotbugs bug categories, see
https://spotbugs.read
on the compiler t
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1440213705
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -2265,11 +2268,12 @@ object UnifiedLog extends Logging {
def deleteProducerSnapshots(): Unit = {
Lo
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1442402745
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1245,7 +1246,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
private[log] def collectAbort
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1442402573
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1441,9 +1442,9 @@ class UnifiedLog(@volatile var logStartOffset: Long,
* (if there is one
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1442402667
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1511,7 +1512,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
localLog.checkIfMem
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1442402484
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java:
##
@@ -0,0 +1,1146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
satishd commented on code in PR #14034:
URL: https://github.com/apache/kafka/pull/14034#discussion_r1442402411
##
checkstyle/import-control-core.xml:
##
@@ -37,6 +37,8 @@
+
+
Review Comment:
Right, it is not needed. I guess it was needed when that class was k
[
https://issues.apache.org/jira/browse/KAFKA-16073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-16073:
---
Fix Version/s: 3.8.0
> Kafka Tiered Storage Bug: Consumer Fetch Error Due to Delayed
> loca
hachikuji commented on code in PR #15119:
URL: https://github.com/apache/kafka/pull/15119#discussion_r1442350821
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClientDriver.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
ijuma commented on code in PR #15119:
URL: https://github.com/apache/kafka/pull/15119#discussion_r1440877890
##
checkstyle/import-control.xml:
##
@@ -443,6 +443,7 @@
+
Review Comment:
Should this be a line above?
--
This is an automated message from
jsancio commented on code in PR #15119:
URL: https://github.com/apache/kafka/pull/15119#discussion_r1442310315
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClientDriver.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 commented on PR #15127:
URL: https://github.com/apache/kafka/pull/15127#issuecomment-1877809786
> I tested the publish again and confirmed it works!
Awesome!
> Who is a good person to ask about this? Maybe some of the original
reviewers of the shadow PR?
M
mumrah commented on code in PR #15115:
URL: https://github.com/apache/kafka/pull/15115#discussion_r1442270635
##
.github/workflows/pr_reviews.yml:
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See th
divijvaidya merged PR #14955:
URL: https://github.com/apache/kafka/pull/14955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
divijvaidya commented on PR #14955:
URL: https://github.com/apache/kafka/pull/14955#issuecomment-1877769128
JDK 8 tests are all successful and other failing tests don't look related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
divijvaidya merged PR #15125:
URL: https://github.com/apache/kafka/pull/15125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
divijvaidya commented on PR #15125:
URL: https://github.com/apache/kafka/pull/15125#issuecomment-1877746515
The modified test is successful
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15125/1/testReport/org.apache.kafka.streams.processor.internals/StoreChangelogReaderTest/
divijvaidya commented on code in PR #15128:
URL: https://github.com/apache/kafka/pull/15128#discussion_r1442237669
##
connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java:
##
@@ -119,16 +117,16 @@ private boolean
divijvaidya commented on code in PR #15071:
URL: https://github.com/apache/kafka/pull/15071#discussion_r1442225284
##
trogdor/src/main/java/org/apache/kafka/trogdor/workload/TopicsSpec.java:
##
@@ -67,8 +67,7 @@ public void set(String name, PartitionsSpec value) {
}
divijvaidya commented on code in PR #15071:
URL: https://github.com/apache/kafka/pull/15071#discussion_r1442224965
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -1079,8 +1077,7 @@ private void clearAll() {
}
wcarlson5 commented on PR #14725:
URL: https://github.com/apache/kafka/pull/14725#issuecomment-1877692107
@mjsax Finally got around to your comments. I think we need to pick this
back to 3.6 and 3.7 as well
--
This is an automated message from the Apache Git Service.
To respond to the mes
wcarlson5 commented on code in PR #14725:
URL: https://github.com/apache/kafka/pull/14725#discussion_r1442198505
##
docs/streams/developer-guide/dsl-api.html:
##
@@ -2849,6 +2851,12 @@ KTable-KTable
Foreign-Key
When the table is versione
clolov opened a new pull request, #15131:
URL: https://github.com/apache/kafka/pull/15131
Adding the public documentation for metrics introduced in
[KIP-963](https://cwiki.apache.org/confluence/display/KAFKA/KIP-963%3A+Additional+metrics+in+Tiered+Storage)
--
This is an automated message
gharris1727 commented on code in PR #15080:
URL: https://github.com/apache/kafka/pull/15080#discussion_r1442146732
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -1001,6 +1001,48 @@ public void testResetConnectorOffs
Greg Harris created KAFKA-16084:
---
Summary: Simplify and deduplicate StandaloneHerderTest mocking
Key: KAFKA-16084
URL: https://issues.apache.org/jira/browse/KAFKA-16084
Project: Kafka
Issue Typ
ditac opened a new pull request, #15130:
URL: https://github.com/apache/kafka/pull/15130
When expiring inflight requests, the network client does not take throttle
time into account. If a connection has multiple inflight requests (default of
5) and each request is throttled then some of the
nickgarvey closed pull request #15129: Quotav2handler [DRAFT]
URL: https://github.com/apache/kafka/pull/15129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
nickgarvey opened a new pull request, #15129:
URL: https://github.com/apache/kafka/pull/15129
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of test
[
https://issues.apache.org/jira/browse/KAFKA-16082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stanislav Kozlovski updated KAFKA-16082:
Fix Version/s: 3.7.0
> JBOD: Possible dataloss when moving leader partition
>
[
https://issues.apache.org/jira/browse/KAFKA-16082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stanislav Kozlovski updated KAFKA-16082:
Fix Version/s: (was: 3.7.0)
> JBOD: Possible dataloss when moving leader parti
iit2009060 commented on PR #15060:
URL: https://github.com/apache/kafka/pull/15060#issuecomment-1877542832
> @iit2009060 You may have mistyped as controller but it does not have any
role in the fetch path here. Remote fetch is executed through a specific
purgatory with DelayedRemoteFetch an
iit2009060 commented on PR #15060:
URL: https://github.com/apache/kafka/pull/15060#issuecomment-1877528171
> Thanks @iit2009060 for the PR.
>
> Let us say there are two segments in remote storage and subsequents
segments in local storage. remote-seg-10[10, 20], remote-seg-21[21, 30] :
cadonna commented on PR #15117:
URL: https://github.com/apache/kafka/pull/15117#issuecomment-1877517561
@lucasbru What do you think about my previous question?
> Should we also add a integration test that tests the scenario?
--
This is an automated message from the Apache Git Servic
[
https://issues.apache.org/jira/browse/KAFKA-14404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803252#comment-17803252
]
Ayoub Omari commented on KAFKA-14404:
-
Hi [~ableegoldman] & [~sujayopensource]
I s
Adithya Chandra created KAFKA-16083:
---
Summary: Exclude throttle time when expiring inflight requests on
a connection
Key: KAFKA-16083
URL: https://issues.apache.org/jira/browse/KAFKA-16083
Project:
philipnee commented on PR #15000:
URL: https://github.com/apache/kafka/pull/15000#issuecomment-1877478293
hi @lucasbru - thanks. i personally prefer to make consumer interceptor
thread safe because firstly, (i think) it simplifies the code quite a bit and
secondly, it is possible to miss t
mimaison commented on code in PR #15071:
URL: https://github.com/apache/kafka/pull/15071#discussion_r1442027962
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -1079,8 +1077,7 @@ private void clearAll() {
}
[
https://issues.apache.org/jira/browse/KAFKA-16081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-16081:
---
Labels: need-kip (was: )
> Limit number of ssl connections in brokers
> ---
mimaison commented on PR #15126:
URL: https://github.com/apache/kafka/pull/15126#issuecomment-1877414085
Thanks for the PR.
Since this is adding new configurations, this change requires a KIP to be
voted by the community. See the [Kafka Improvement
Proposals](https://cwiki.apache.org
mimaison opened a new pull request, #15128:
URL: https://github.com/apache/kafka/pull/15128
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
gharris1727 commented on code in PR #14995:
URL: https://github.com/apache/kafka/pull/14995#discussion_r1441959148
##
clients/src/test/java/org/apache/kafka/common/config/provider/FileConfigProviderTest.java:
##
@@ -98,8 +117,91 @@ public void testServiceLoaderDiscovery() {
mimaison commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1877357358
Sorry for the delay. I tried to build this but it fails in the CI with the
following error:
```
WorkflowScript: 91: unexpected token: % @ line 91, column 82.
InMillis() / 1000
apoorvmittal10 opened a new pull request, #15127:
URL: https://github.com/apache/kafka/pull/15127
## What
The PR fixes the publishing of `kafka-clients` artifact to remote maven. The
`kafka-clients` jar is recently been shadowed which does publish the artifacts
to local maven successfull
satishd commented on PR #15060:
URL: https://github.com/apache/kafka/pull/15060#issuecomment-1877333095
@iit2009060 You may have mistyped as controller but it does not have any
role in the fetch path here.
Remote fetch is executed through a specific purgatory with
DelayedRemoteFetch and
mimaison commented on code in PR #14995:
URL: https://github.com/apache/kafka/pull/14995#discussion_r1441931015
##
clients/src/main/java/org/apache/kafka/common/config/internals/ConfigProviderUtils.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
mimaison commented on PR #15022:
URL: https://github.com/apache/kafka/pull/15022#issuecomment-1877305934
@mumrah can you take a look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
developster commented on PR #15080:
URL: https://github.com/apache/kafka/pull/15080#issuecomment-1877282686
@gharris1727 , I've added the test. It first starts the connector, then
updates both the connector and task at the same time. The reason for this is
that task reconfiguration will ski
[
https://issues.apache.org/jira/browse/KAFKA-16082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803205#comment-17803205
]
Gaurav Narula commented on KAFKA-16082:
---
We tried to analyse the failure scenarios
lucasbru commented on code in PR #15117:
URL: https://github.com/apache/kafka/pull/15117#discussion_r1441867884
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -1164,9 +1243,12 @@ public void
shouldHandleMultipleRemovedTasksFrom
cadonna commented on code in PR #15117:
URL: https://github.com/apache/kafka/pull/15117#discussion_r1441848969
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -1164,9 +1243,12 @@ public void
shouldHandleMultipleRemovedTasksFromS
viktorsomogyi commented on PR #15115:
URL: https://github.com/apache/kafka/pull/15115#issuecomment-1877217071
@mumrah @divijvaidya, the script just edits the PR body, it won't touch the
commit itself.
I discovered yesterday that this PR also already runs the action, however it
failed
Phuc-Hong-Tran commented on PR #15020:
URL: https://github.com/apache/kafka/pull/15020#issuecomment-1877214088
@philipnee, PTAL, thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-16082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Proven Provenzano updated KAFKA-16082:
--
Priority: Blocker (was: Critical)
> JBOD: Possible dataloss when moving leader partit
ijuma commented on PR #14868:
URL: https://github.com/apache/kafka/pull/14868#issuecomment-1877205588
Sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
Proven Provenzano created KAFKA-16082:
-
Summary: JBOD: Possible dataloss when moving leader partition
Key: KAFKA-16082
URL: https://issues.apache.org/jira/browse/KAFKA-16082
Project: Kafka
mimaison commented on PR #14868:
URL: https://github.com/apache/kafka/pull/14868#issuecomment-1877201295
Yes I expect we'll be able to remove that when we remove ZooKeeper. In the
meantime, these PRs are helpful to move the commands to the tools module.
--
This is an automated message fro
lucasbru commented on PR #15000:
URL: https://github.com/apache/kafka/pull/15000#issuecomment-1877184050
@philipnee Good point about auto-commits, I missed that. It's a pity that
auto-commits aren't triggered from the main thread (I wonder if we could do
that? Would be another architectural
viktorsomogyi commented on code in PR #15115:
URL: https://github.com/apache/kafka/pull/15115#discussion_r1441813320
##
.github/workflows/pr_reviews.yml:
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
viktorsomogyi commented on code in PR #15115:
URL: https://github.com/apache/kafka/pull/15115#discussion_r1441800052
##
.github/workflows/pr_reviews.yml:
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
ijuma commented on PR #14868:
URL: https://github.com/apache/kafka/pull/14868#issuecomment-1877150309
You're right. The weird part is actually the fact that `ConfigCommand`
relies on this detail instead of using the relevant public apis. I guess it's
partly due to the remaining zk code. See
JimmyWang6 opened a new pull request, #15126:
URL: https://github.com/apache/kafka/pull/15126
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of test
Jimmy Wang created KAFKA-16081:
--
Summary: Limit number of ssl connections in brokers
Key: KAFKA-16081
URL: https://issues.apache.org/jira/browse/KAFKA-16081
Project: Kafka
Issue Type: New Featur
nizhikov commented on PR #14868:
URL: https://github.com/apache/kafka/pull/14868#issuecomment-1877129273
@ijuma
> Is this used by anything outside of tools?
AFAICS yes.
`DymamicConfig`, `ClientQuotaMetadataManager`, `DynamicConfigPublisher` to
name a few.
These clas
ijuma commented on PR #14868:
URL: https://github.com/apache/kafka/pull/14868#issuecomment-1877112384
It's a bit weird to move stuff like this to `server-common`. Is this used by
anything outside of `tools`?
--
This is an automated message from the Apache Git Service.
To respond to the me
cadonna merged PR #14980:
URL: https://github.com/apache/kafka/pull/14980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cadonna commented on PR #14980:
URL: https://github.com/apache/kafka/pull/14980#issuecomment-1877111288
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
nizhikov commented on PR #14868:
URL: https://github.com/apache/kafka/pull/14868#issuecomment-1877093884
Test failure was fixed by #417338ad77d15cad2534d7cff436c8776e717255
I merged latest trunk to PR so this must be OK now.
--
This is an automated message from the Apache Git Service.
T
clolov commented on code in PR #15125:
URL: https://github.com/apache/kafka/pull/15125#discussion_r1441743303
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java:
##
@@ -1335,9 +1299,6 @@ public void
shouldTransitStateBackToActive
clolov opened a new pull request, #15125:
URL: https://github.com/apache/kafka/pull/15125
This pull request takes a similar approach to how TaskManagerTest is being
migrated to Mockito mock by mock for easier reviews.
--
This is an automated message from the Apache Git Service.
To respond
kagarwal06 commented on PR #15048:
URL: https://github.com/apache/kafka/pull/15048#issuecomment-1877080323
> I saw that but the action only allows me to pick a branch or tag. Ideally
I'd like to run it on the pull request.
Hi @mimaison , thanks for the feedback.
The dockerisati
lucasbru commented on code in PR #15117:
URL: https://github.com/apache/kafka/pull/15117#discussion_r1441719248
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -950,6 +963,12 @@ private void handleRestoredTasksFromStateUpdater(final
clolov commented on PR #15116:
URL: https://github.com/apache/kafka/pull/15116#issuecomment-1877054383
Okay @lucasbru, I will look into it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
lucasbru commented on PR #15116:
URL: https://github.com/apache/kafka/pull/15116#issuecomment-1877052454
@clolov I do believe that the flaky test @divijvaidya mentioned started with
another mockito migration PR on 4th of december, #13932. Maybe you could give
it a look even if it's not rela
divijvaidya merged PR #15116:
URL: https://github.com/apache/kafka/pull/15116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
divijvaidya commented on PR #15116:
URL: https://github.com/apache/kafka/pull/15116#issuecomment-1877045252
My bad! the test failure I notes above is known to be flaky as per
https://ge.apache.org/scans/tests?search.relativeStartTime=P28D&search.rootProjectNames=kafka&search.tags=trunk&searc
mimaison commented on PR #15048:
URL: https://github.com/apache/kafka/pull/15048#issuecomment-1877012641
I saw that but the action only allows me to pick a branch or tag. Ideally
I'd like to run it on the pull request.
--
This is an automated message from the Apache Git Service.
To respon
divijvaidya commented on PR #15116:
URL: https://github.com/apache/kafka/pull/15116#issuecomment-1876978251
@clolov we have test failures related to this PR. Can you please fix them:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15116/1/testReport/org.apache.kafka.streams.proces
wangliucheng created KAFKA-16080:
Summary: partiton not retention after execute
ALTER_REPLICA_LOG_DIRS and LEADER_AND_ISR request at the same time
Key: KAFKA-16080
URL: https://issues.apache.org/jira/browse/KAFKA-
tinaselenge commented on code in PR #14995:
URL: https://github.com/apache/kafka/pull/14995#discussion_r1441652042
##
clients/src/main/java/org/apache/kafka/common/config/internals/ConfigProviderUtils.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (
cadonna commented on code in PR #15117:
URL: https://github.com/apache/kafka/pull/15117#discussion_r1441615070
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -1164,9 +1243,12 @@ public void
shouldHandleMultipleRemovedTasksFromS
VedarthConfluent commented on PR #15048:
URL: https://github.com/apache/kafka/pull/15048#issuecomment-1876954982
@mimaison There is a GitHub Actions Workflow added for just that! You can
check it out
[here](https://github.com/apache/kafka/actions/workflows/docker_build_and_test.yml).
Also
showuon commented on code in PR #15122:
URL: https://github.com/apache/kafka/pull/15122#discussion_r1441641932
##
core/src/test/scala/unit/kafka/server/ReplicaManagerConcurrencyTest.scala:
##
@@ -50,12 +51,15 @@ import scala.collection.{immutable, mutable}
import scala.jdk.Coll
tinaselenge commented on code in PR #14846:
URL: https://github.com/apache/kafka/pull/14846#discussion_r1441637951
##
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala:
##
@@ -187,164 +197,233 @@ class DeleteTopicTest extends QuorumTestHarness {
}.toSet
}
- @
[
https://issues.apache.org/jira/browse/KAFKA-16077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16077:
Priority: Blocker (was: Critical)
> Streams fails to close task after restoration when in
mimaison commented on PR #10244:
URL: https://github.com/apache/kafka/pull/10244#issuecomment-1876911687
@dongjinleekr Following up on this. If I don't hear back in the next couple
of weeks I'll try to complete this task (and keep you as co-author)
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/KAFKA-16077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-16077:
--
Assignee: Lucas Brutschy
> Streams fails to close task after restoration when input p
1 - 100 of 120 matches
Mail list logo
