Re: [PR] KAFKA-14808: fix leaderless partition issue when controller removes u… [kafka]

2023-12-25 Thread via GitHub
songnon commented on code in PR #13451: URL: https://github.com/apache/kafka/pull/13451#discussion_r1436294870 ## core/src/main/scala/kafka/controller/KafkaController.scala: ## @@ -1894,10 +1894,16 @@ class KafkaController(val config: KafkaConfig, val currentAssignment =

Re: [PR] KAFKA-14808: fix leaderless partition issue when controller removes u… [kafka]

2023-12-25 Thread via GitHub
songnon commented on code in PR #13451: URL: https://github.com/apache/kafka/pull/13451#discussion_r1436294870 ## core/src/main/scala/kafka/controller/KafkaController.scala: ## @@ -1894,10 +1894,16 @@ class KafkaController(val config: KafkaConfig, val currentAssignment =

Re: [PR] [WIP]MINOR: Find test [kafka]

2023-12-25 Thread via GitHub
github-actions[bot] commented on PR #14452: URL: https://github.com/apache/kafka/pull/14452#issuecomment-1869227211 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[PR] MONOR: Improve code style [kafka]

2023-12-25 Thread via GitHub
DL1231 opened a new pull request, #15074: URL: https://github.com/apache/kafka/pull/15074 I found a couple of code style inconsistencies. This PR fixes them. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage

[jira] [Assigned] (KAFKA-16011) Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnClose

2023-12-25 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran reassigned KAFKA-16011: -- Assignee: Phuc Hong Tran > Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutO

[jira] [Assigned] (KAFKA-16022) AsyncKafkaConsumer sometimes complains "No current assignment for partition {}"

2023-12-25 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran reassigned KAFKA-16022: -- Assignee: Phuc Hong Tran > AsyncKafkaConsumer sometimes complains "No current assignm

[jira] [Assigned] (KAFKA-16024) SaslPlaintextConsumerTest#testCoordinatorFailover is flaky

2023-12-25 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran reassigned KAFKA-16024: -- Assignee: Phuc Hong Tran > SaslPlaintextConsumerTest#testCoordinatorFailover is flaky

[PR] KAFKA-16046: also fix stores for outer join [kafka]

2023-12-25 Thread via GitHub
agavra opened a new pull request, #15073: URL: https://github.com/apache/kafka/pull/15073 This is the corollary to https://github.com/apache/kafka/pull/15061 for outer joins, which don't use timestamped KV stores either (compared to just window stores). ### Committer Checklist (exclu

[jira] [Updated] (KAFKA-16049) Can you please share tutorial how to run Latest Kafka (3.6.0) with SASL_SSL

2023-12-25 Thread Petr Kostroun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petr Kostroun updated KAFKA-16049: -- Labels: newbie (was: ) > Can you please share tutorial how to run Latest Kafka (3.6.0) with S

[jira] [Updated] (KAFKA-16049) Can you please share tutorial how to run Latest Kafka (3.6.0) with SASL_SSL

2023-12-25 Thread Petr Kostroun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petr Kostroun updated KAFKA-16049: -- Description: Can you please share tutorial how to use SASL_SSL with Kafka version 3.6.0?   I

[jira] [Updated] (KAFKA-16049) Can you please share tutorial how to run Latest Kafka (3.6.0) with SASL_SSL

2023-12-25 Thread Petr Kostroun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petr Kostroun updated KAFKA-16049: -- Summary: Can you please share tutorial how to run Latest Kafka (3.6.0) with SASL_SSL (was: Ca

[jira] [Created] (KAFKA-16049) Can you please share tutorial how to run Latest Kafka (3.6.0)

2023-12-25 Thread Petr Kostroun (Jira)
Petr Kostroun created KAFKA-16049: - Summary: Can you please share tutorial how to run Latest Kafka (3.6.0) Key: KAFKA-16049 URL: https://issues.apache.org/jira/browse/KAFKA-16049 Project: Kafka

[PR] MINOR: New year code cleanup - include final keyword [kafka]

2023-12-25 Thread via GitHub
divijvaidya opened a new pull request, #15072: URL: https://github.com/apache/kafka/pull/15072 Code cleanup to include `final` keyword where ever required. Detected via automatic tooling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] MINOR: Fix NullPointerException in ReplicaFetcherThreadTest testcase. [kafka]

2023-12-25 Thread via GitHub
divijvaidya merged PR #15069: URL: https://github.com/apache/kafka/pull/15069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] MINOR: Fix NullPointerException in ReplicaFetcherThreadTest testcase. [kafka]

2023-12-25 Thread via GitHub
divijvaidya commented on PR #15069: URL: https://github.com/apache/kafka/pull/15069#issuecomment-1869058216 I have verified that this test still passes the CI: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15069/1/testReport/kafka.server/ReplicaFetcherThreadTest/ -- This is

Re: [PR] MINOR: Fix NullPointerException in ReplicaFetcherThreadTest testcase. [kafka]

2023-12-25 Thread via GitHub
divijvaidya commented on PR #15069: URL: https://github.com/apache/kafka/pull/15069#issuecomment-1869046687 Adding to the motivation here, this test prints a NPE in the log which is not relevant to the test. ``` [2023-12-25 17:28:26,107] ERROR [ReplicaFetcher replicaId=1, leaderId=

Re: [PR] KAFKA-15996: Improve JsonConverter performance [kafka]

2023-12-25 Thread via GitHub
divijvaidya commented on PR #14992: URL: https://github.com/apache/kafka/pull/14992#issuecomment-1869045953 > Do you have any estimations? 3.8 is usually expected to release around ~Apr-May timeframe. You can find more details about timelines of our releases here: https://cwiki.apach

[PR] MINOR: New year code clean up (part 1) [kafka]

2023-12-25 Thread via GitHub
divijvaidya opened a new pull request, #15071: URL: https://github.com/apache/kafka/pull/15071 Multiple clean ups for `warn` discovered via automatic tooling (different ones). No logic change. Types of clean up: 1. Remove redundant imports 2. Use bulk collection operations such

Re: [PR] KAFKA-15996: Improve JsonConverter performance [kafka]

2023-12-25 Thread via GitHub
mfvitale commented on PR #14992: URL: https://github.com/apache/kafka/pull/14992#issuecomment-1869012147 > We don't usually backport performance fixes to patch versions. (With the usual caveat that this is not set in stone and is open to discussion). Our motivation is to backport only criti

Re: [PR] KAFKA-15996: Improve JsonConverter performance [kafka]

2023-12-25 Thread via GitHub
divijvaidya commented on PR #14992: URL: https://github.com/apache/kafka/pull/14992#issuecomment-1868993157 > Do you think there can be a chance for 3.7.1? Is there any schedule? We don't usually backport performance fixes to patch versions. (With the usual caveat that this is not set

Re: [PR] KAFKA-16048 Fix shouldNotSupportAlterClientMetricsWithZookeeper [kafka]

2023-12-25 Thread via GitHub
divijvaidya merged PR #15068: URL: https://github.com/apache/kafka/pull/15068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apa

Re: [PR] KAFKA-14588 ConfigType moved to server-common [kafka]

2023-12-25 Thread via GitHub
divijvaidya commented on PR #14867: URL: https://github.com/apache/kafka/pull/14867#issuecomment-1868989653 Thank you @nizhikov for the quick fix. Merged it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-16048 Fix shouldNotSupportAlterClientMetricsWithZookeeper [kafka]

2023-12-25 Thread via GitHub
divijvaidya commented on PR #15068: URL: https://github.com/apache/kafka/pull/15068#issuecomment-1868989330 Verified that test being fixed is passing in CI: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15068/1/testReport/kafka.admin/ConfigCommandTest/Build___JDK_8_and_Scala_2_1

[jira] [Resolved] (KAFKA-15619) Deleted topics will come back again

2023-12-25 Thread Deng Ziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deng Ziming resolved KAFKA-15619. - Assignee: Deng Ziming Resolution: Invalid This has been fixed after setting auto.create.to

[PR] KAFKA-14588 [WIP] ConfigCommand rewritten in java [kafka]

2023-12-25 Thread via GitHub
nizhikov opened a new pull request, #15070: URL: https://github.com/apache/kafka/pull/15070 This PR contains changes to move `ConfigCommand` to `tools` module. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverag

[PR] MINOR: [kafka]

2023-12-25 Thread via GitHub
IBeyondy opened a new pull request, #15069: URL: https://github.com/apache/kafka/pull/15069 Found NullPointerException when executing `testTruncateOnFetchDoesNotUpdateHighWatermark` in `ReplicaFetcherThreadTest`, which is caused by lacking `ReplicaAlterLogDirsManager` mock for `ReplicaMana

[jira] [Commented] (KAFKA-15529) Flaky test ReassignReplicaShrinkTest.executeTieredStorageTest

2023-12-25 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800284#comment-17800284 ] Arpit Goyal commented on KAFKA-15529: - [~divijvaidya] [~Kamal C] Any idea in which c

Re: [PR] KAFKA-14588 ConfigType moved to server-common [kafka]

2023-12-25 Thread via GitHub
nizhikov commented on PR #14867: URL: https://github.com/apache/kafka/pull/14867#issuecomment-1868912717 Fix is ready #15068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.