[GitHub] [kafka] fvaleri opened a new pull request, #14366: MINOR: Fix metadata.version reference in "ZooKeeper to KRaft Migration" documentation

fvaleri opened a new pull request, #14366: URL: https://github.com/apache/kafka/pull/14366 In "ZooKeeper to KRaft Migration" documentation, we are still reporting 3.4 as metadata version. I'm reworking that phrase to make it more clear and avoid the need to update it in the future. -- Th

[GitHub] [kafka] dajac commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

dajac commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1321056941 ## core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [kafka] dajac commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

dajac commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1321055465 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] dajac commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

dajac commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1321053498 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] dajac commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

dajac commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1321053498 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1321035644 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/common/TopicIdPartition.java: ## @@ -0,0 +1,74 @@ +/* Review Comment: yeah that's true I agr

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1321033941 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1321024671 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1321023849 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1321023603 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,413 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14363: KAFKA-14993: Improve TransactionIndex instance handling while copying to and fetching from RSM

abhijeetk88 commented on code in PR #14363: URL: https://github.com/apache/kafka/pull/14363#discussion_r1321001330 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -382,6 +385,8 @@ private RemoteIndexCache.Entry createCacheEntry(Remot

[GitHub] [kafka] hudeqi commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

hudeqi commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1320999054 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -110,27 +113,54 @@ public class RemoteIndexCache implements Closeable {

[GitHub] [kafka] showuon commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

showuon commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1320996086 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -110,27 +113,54 @@ public class RemoteIndexCache implements Closeable {

[GitHub] [kafka] showuon commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

showuon commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1320996086 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -110,27 +113,54 @@ public class RemoteIndexCache implements Closeable {

[GitHub] [kafka] ivanyu commented on pull request #14363: KAFKA-14993: Improve TransactionIndex instance handling while copying to and fetching from RSM

ivanyu commented on PR #14363: URL: https://github.com/apache/kafka/pull/14363#issuecomment-1713147646 Thank you @abhijeetk88! Apart from what's requested by @showuon, LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka] github-actions[bot] commented on pull request #13333: MINOR: Cleanup TestPlugins and normalize TestPlugin enum

github-actions[bot] commented on PR #1: URL: https://github.com/apache/kafka/pull/1#issuecomment-1713106591 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[GitHub] [kafka] showuon commented on a diff in pull request #14363: KAFKA-14993: Improve TransactionIndex instance handling while copying to and fetching from RSM

showuon commented on code in PR #14363: URL: https://github.com/apache/kafka/pull/14363#discussion_r1320955941 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -382,6 +385,8 @@ private RemoteIndexCache.Entry createCacheEntry(RemoteLog

[jira] [Commented] (KAFKA-15140) Improve TopicCommandIntegrationTest to be less flaky

[ https://issues.apache.org/jira/browse/KAFKA-15140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763533#comment-17763533 ] Satish Duggana commented on KAFKA-15140: Moved to 3.7.0 as it is not a blocker f

[jira] [Updated] (KAFKA-15140) Improve TopicCommandIntegrationTest to be less flaky

[ https://issues.apache.org/jira/browse/KAFKA-15140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15140: --- Fix Version/s: 3.7.0 (was: 3.6.0) > Improve TopicCommandIntegrationTe

[GitHub] [kafka] showuon commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

showuon commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1320951850 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -110,27 +113,54 @@ public class RemoteIndexCache implements Closeable {

[GitHub] [kafka] hudeqi commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

hudeqi commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1320948713 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -110,27 +113,54 @@ public class RemoteIndexCache implements Closeable {

[GitHub] [kafka] vamossagar12 commented on pull request #14345: MINOR: Range assignor changes

vamossagar12 commented on PR #14345: URL: https://github.com/apache/kafka/pull/14345#issuecomment-1713089274 aah ok. Yeah that's what I was wondering. Thanks for letting me know :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] showuon commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

showuon commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1320945151 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -110,27 +113,54 @@ public class RemoteIndexCache implements Closeable {

[jira] [Reopened] (KAFKA-15140) Improve TopicCommandIntegrationTest to be less flaky

[ https://issues.apache.org/jira/browse/KAFKA-15140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deng Ziming reopened KAFKA-15140: - This is still flaky, it seems the internal topic is also under min isr partitions. https://ci-buil

[jira] [Resolved] (KAFKA-15286) Migrate ApiVersion related code to kraft

[ https://issues.apache.org/jira/browse/KAFKA-15286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deng Ziming resolved KAFKA-15286. - Resolution: Fixed > Migrate ApiVersion related code to kraft > -

[GitHub] [kafka] dengziming merged pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

dengziming merged PR #13562: URL: https://github.com/apache/kafka/pull/13562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

[GitHub] [kafka] dengziming commented on pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

dengziming commented on PR #13562: URL: https://github.com/apache/kafka/pull/13562#issuecomment-1713063574 Test failures are unrelated ``` [Build / JDK 8 and Scala 2.12 / kafka.admin.TopicCommandIntegrationTest.testDescribeUnderMinIsrPartitionsMixed(String).quorum=kraft](https://ci-bui

[GitHub] [kafka] aiven-anton commented on a diff in pull request #14124: KAFKA-14509; [1/2] Define ConsumerGroupDescribe API request and response schemas and classes.

aiven-anton commented on code in PR #14124: URL: https://github.com/apache/kafka/pull/14124#discussion_r1320822476 ## clients/src/main/resources/common/message/ConsumerGroupDescribeResponse.json: ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] bmscomp commented on pull request #14146: MINOR: Upgrade maven Artifact version to 3.9.4

bmscomp commented on PR #14146: URL: https://github.com/apache/kafka/pull/14146#issuecomment-1712859697 @divijvaidya checked all the dependencies of the projet using the command `./gradlew printAllDependencies`, the dependency of plexus-utils is still here but we need to update it's versio

[GitHub] [kafka] bmscomp opened a new pull request, #14365: MINOR: Upgrade jqwik to version 1.8.0

bmscomp opened a new pull request, #14365: URL: https://github.com/apache/kafka/pull/14365 This minore pull request consist of upgrading version of `jqwik` library to version `1.8.0` that brings some bug fixing and some enhancements, upgrading the version now will make future upgrades easie

[jira] [Commented] (KAFKA-14511) Extend AlterIncrementalConfigs API to support group config

[ https://issues.apache.org/jira/browse/KAFKA-14511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17763427#comment-17763427 ] Jimmy Wang commented on KAFKA-14511: Hi [~dajac] , Can I be assgined for this issue?