[GitHub] [kafka] dajac commented on pull request #14271: KAFKA-14503: Implement ListGroups

dajac commented on PR #14271: URL: https://github.com/apache/kafka/pull/14271#issuecomment-1707768637 @zhaohaidao There is a bunch of conflicts with `trunk`. Could you please fix them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] dajac commented on a diff in pull request #14124: KAFKA-14509; [1/2] Define ConsumerGroupDescribe API request and response schemas and classes.

dajac commented on code in PR #14124: URL: https://github.com/apache/kafka/pull/14124#discussion_r1316808298 ## clients/src/test/java/org/apache/kafka/common/requests/ConsumerGroupDescribeResponseTest.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1316806195 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,393 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] dajac merged pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

dajac merged PR #14321: URL: https://github.com/apache/kafka/pull/14321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1316793219 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java: ## @@ -0,0 +1,288 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1316792230 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java: ## @@ -0,0 +1,288 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Updated] (KAFKA-15410) Add basic functionality integration test with tiered storage

[ https://issues.apache.org/jira/browse/KAFKA-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-15410: - Description: Add the below basic functionality integration tests with tiered sto

[jira] [Updated] (KAFKA-15410) Add basic functionality integration test with tiered storage

[ https://issues.apache.org/jira/browse/KAFKA-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-15410: - Description: Add the below basic functionality integration tests with tiered sto

[GitHub] [kafka] satishd commented on a diff in pull request #14340: KAFKA-15351: Update log-start-offset after leader election for topics enabled with remote storage

satishd commented on code in PR #14340: URL: https://github.com/apache/kafka/pull/14340#discussion_r1316738717 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -1387,6 +1390,112 @@ public void testStopPartitionsWithDeletion() throws RemoteStorageException

[GitHub] [kafka] omkreddy merged pull request #14339: KAFKA-15422: Update documenttion for delegation tokens when working with Kafka with KRaft

omkreddy merged PR #14339: URL: https://github.com/apache/kafka/pull/14339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] lianetm opened a new pull request, #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

lianetm opened a new pull request, #14346: URL: https://github.com/apache/kafka/pull/14346 Implementation of the required functionality for resetting and validating positions in the new async consumer. This PR includes: - New application events `ResetPositionsApplicationEvent` and

[jira] [Updated] (KAFKA-15115) Implement resetPositions functionality in OffsetsRequestManager

[ https://issues.apache.org/jira/browse/KAFKA-15115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15115: --- Description: Introduce support for resetting positions in the new OffsetsRequestManager. Th

[jira] [Updated] (KAFKA-15115) Implement resetPositions functionality in OffsetsRequestManager

[ https://issues.apache.org/jira/browse/KAFKA-15115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15115: --- Summary: Implement resetPositions functionality in OffsetsRequestManager (was: Implement re

[jira] [Created] (KAFKA-15438) Review exception caching logic used for reset/validate positions in async consumer

Lianet Magrans created KAFKA-15438: -- Summary: Review exception caching logic used for reset/validate positions in async consumer Key: KAFKA-15438 URL: https://issues.apache.org/jira/browse/KAFKA-15438

[GitHub] [kafka] showuon commented on a diff in pull request #14329: KAFKA-15410: Delete topic integration test with LocalTieredStorage and TBRLMM (3/4)

showuon commented on code in PR #14329: URL: https://github.com/apache/kafka/pull/14329#discussion_r1316586591 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -3487,8 +3487,12 @@ class ReplicaManagerTest { assertTrue(replicaManager.logManager.ge

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14147: KAFKA-14502; Implement LeaveGroup protocol in new GroupCoordinator

rreddy-22 commented on code in PR #14147: URL: https://github.com/apache/kafka/pull/14147#discussion_r1316576861 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java: ## @@ -306,6 +308,22 @@ public CoordinatorResult commitOffset(

[jira] [Commented] (KAFKA-15249) Verify Connect test-plugins artifact is published to Maven Central

[ https://issues.apache.org/jira/browse/KAFKA-15249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762237#comment-17762237 ] Satish Duggana commented on KAFKA-15249: [~ChrisEgerton] I thought there is some

[GitHub] [kafka] satishd merged pull request #14329: KAFKA-15410: Delete topic integration test with LocalTieredStorage and TBRLMM (3/4)

satishd merged PR #14329: URL: https://github.com/apache/kafka/pull/14329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] satishd commented on pull request #14329: KAFKA-15410: Delete topic integration test with LocalTieredStorage and TBRLMM (3/4)

satishd commented on PR #14329: URL: https://github.com/apache/kafka/pull/14329#issuecomment-1707469208 Merging it to trunk and 3.6 to unblock as it received 3 +1s. A couple of test failures unrelated to this change. Merging it to trunk and 3.6. -- This is an automated message from the Ap

[GitHub] [kafka] jolshan commented on a diff in pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found

jolshan commented on code in PR #14314: URL: https://github.com/apache/kafka/pull/14314#discussion_r1316539813 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/PartitionLeaderStrategy.java: ## @@ -72,6 +79,12 @@ private void handleTopicError( ) { s

[jira] [Updated] (KAFKA-15435) KRaft migration record counts in log message are incorrect

[ https://issues.apache.org/jira/browse/KAFKA-15435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15435: --- Fix Version/s: 3.6.0 > KRaft migration record counts in log message are incorrect >

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14147: KAFKA-14502; Implement LeaveGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #14147: URL: https://github.com/apache/kafka/pull/14147#discussion_r1316531927 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2904,6 +2908,135 @@ private void validateGenericGroupHeartbeat

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14147: KAFKA-14502; Implement LeaveGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #14147: URL: https://github.com/apache/kafka/pull/14147#discussion_r1316531927 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2904,6 +2908,135 @@ private void validateGenericGroupHeartbeat

[GitHub] [kafka] rreddy-22 opened a new pull request, #14345: MINOR: Range assignor changes

rreddy-22 opened a new pull request, #14345: URL: https://github.com/apache/kafka/pull/14345 Minor changes to make the range assignor coherent with the other assignors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [kafka] gharris1727 commented on a diff in pull request #14309: KAFKA-13328, KAFKA-13329 (2): Add custom preflight validation support for connector header, key, and value converters

gharris1727 commented on code in PR #14309: URL: https://github.com/apache/kafka/pull/14309#discussion_r1316480601 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java: ## @@ -380,6 +387,110 @@ protected Map validateSourceConnectorConfig(SourceC

[GitHub] [kafka] gharris1727 commented on pull request #14309: KAFKA-13328, KAFKA-13329 (2): Add custom preflight validation support for connector header, key, and value converters

gharris1727 commented on PR #14309: URL: https://github.com/apache/kafka/pull/14309#issuecomment-1707372782 > I honestly find the EnrichablePlugin class pretty hard to read, and prefer the merge style when it can be used. Sure, I'll buy that. I'm fine with migrating away from Enrichab

[GitHub] [kafka] gharris1727 commented on a diff in pull request #14309: KAFKA-13328, KAFKA-13329 (2): Add custom preflight validation support for connector header, key, and value converters

gharris1727 commented on code in PR #14309: URL: https://github.com/apache/kafka/pull/14309#discussion_r1316465707 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java: ## @@ -380,6 +387,110 @@ protected Map validateSourceConnectorConfig(SourceC

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1316456003 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,393 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1316439651 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,393 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1316429235 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,393 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] jolshan commented on a diff in pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found

jolshan commented on code in PR #14314: URL: https://github.com/apache/kafka/pull/14314#discussion_r1316416748 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -5634,16 +5637,31 @@ public void testListOffsetsMetadataNonRetriableErrors() t

[GitHub] [kafka] jolshan commented on a diff in pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found

jolshan commented on code in PR #14314: URL: https://github.com/apache/kafka/pull/14314#discussion_r1316414818 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/PartitionLeaderStrategy.java: ## @@ -72,6 +79,12 @@ private void handleTopicError( ) { s

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1316408646 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,393 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1316406386 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GeneralUniformAssignmentBuilder.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apach

[GitHub] [kafka] junrao commented on a diff in pull request #14305: KAFKA-14274: [1/7] basic refactoring

junrao commented on code in PR #14305: URL: https://github.com/apache/kafka/pull/14305#discussion_r1316404620 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -363,6 +365,20 @@ private CompletableFuture> chainFuture(fi

[GitHub] [kafka] jolshan commented on pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found

jolshan commented on PR #14314: URL: https://github.com/apache/kafka/pull/14314#issuecomment-1707306276 Sorry for the delay @C0urante and thanks for the explanation. It makes sense. Given that we moved the retries to `TopicAdmin::retryEndOffsets` does this mean there is not any known

[jira] [Created] (KAFKA-15437) Add metrics about open iterators

Matthias J. Sax created KAFKA-15437: --- Summary: Add metrics about open iterators Key: KAFKA-15437 URL: https://issues.apache.org/jira/browse/KAFKA-15437 Project: Kafka Issue Type: New Featur

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1316396258 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -49,6 +51,8 @@ * */ public class RangeAssignor implemen

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1316395025 ## clients/src/main/java/org/apache/kafka/common/requests/ControllerRegistrationRequest.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1316393751 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -320,6 +323,19 @@ public short registerBrokerRecordVersion() { }

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1316393088 ## clients/src/main/resources/common/message/ControllerRegistrationRequest.json: ## @@ -0,0 +1,51 @@ +// Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1316390836 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/common/TopicIdPartition.java: ## @@ -0,0 +1,74 @@ +/* Review Comment: Its not the exact same

[GitHub] [kafka] gharris1727 commented on a diff in pull request #14304: KAFKA-13328, KAFKA-13329 (1): Add preflight validations for key, value, and header converter classes

gharris1727 commented on code in PR #14304: URL: https://github.com/apache/kafka/pull/14304#discussion_r1316388557 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1519,6 +1537,32 @@ public static String[] enumOptions(Class> enumClass) {

[GitHub] [kafka] C0urante commented on pull request #14309: KAFKA-13328, KAFKA-13329 (2): Add custom preflight validation support for connector header, key, and value converters

C0urante commented on PR #14309: URL: https://github.com/apache/kafka/pull/14309#issuecomment-1707264425 > I wonder if we can unify these approaches, and maybe even use the "enrich" patten for producer/consumer/admin instead of the "merge" style. I honestly find the `EnrichablePlugin`

[GitHub] [kafka] gharris1727 commented on a diff in pull request #14304: KAFKA-13328, KAFKA-13329 (1): Add preflight validations for key, value, and header converter classes

gharris1727 commented on code in PR #14304: URL: https://github.com/apache/kafka/pull/14304#discussion_r1316362502 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1519,6 +1537,32 @@ public static String[] enumOptions(Class> enumClass) {

[GitHub] [kafka] gharris1727 commented on a diff in pull request #14304: KAFKA-13328, KAFKA-13329 (1): Add preflight validations for key, value, and header converter classes

gharris1727 commented on code in PR #14304: URL: https://github.com/apache/kafka/pull/14304#discussion_r1316362060 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1090,6 +1090,23 @@ public interface UncheckedCloseable extends AutoCloseable { v

[GitHub] [kafka] C0urante commented on a diff in pull request #14309: KAFKA-13328, KAFKA-13329 (2): Add custom preflight validation support for connector header, key, and value converters

C0urante commented on code in PR #14309: URL: https://github.com/apache/kafka/pull/14309#discussion_r1316338908 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java: ## @@ -380,6 +387,110 @@ protected Map validateSourceConnectorConfig(SourceConn

[GitHub] [kafka] philipnee commented on a diff in pull request #14313: KAFKA-15416: Fix flaky TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound test case

philipnee commented on code in PR #14313: URL: https://github.com/apache/kafka/pull/14313#discussion_r1316332331 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java: ## @@ -286,11 +286,16 @@ public static NewTopicBuilder defineTopic(String topicName)

[jira] [Assigned] (KAFKA-15435) KRaft migration record counts in log message are incorrect

[ https://issues.apache.org/jira/browse/KAFKA-15435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur reassigned KAFKA-15435: Assignee: David Arthur > KRaft migration record counts in log message are incorrect > ---

[GitHub] [kafka] C0urante commented on a diff in pull request #14304: KAFKA-13328, KAFKA-13329 (1): Add preflight validations for key, value, and header converter classes

C0urante commented on code in PR #14304: URL: https://github.com/apache/kafka/pull/14304#discussion_r1316327673 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/InstantiableClassValidator.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] C0urante commented on a diff in pull request #14304: KAFKA-13328, KAFKA-13329 (1): Add preflight validations for key, value, and header converter classes

C0urante commented on code in PR #14304: URL: https://github.com/apache/kafka/pull/14304#discussion_r1316327532 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1519,6 +1537,32 @@ public static String[] enumOptions(Class> enumClass) { .t

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14147: KAFKA-14502; Implement LeaveGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #14147: URL: https://github.com/apache/kafka/pull/14147#discussion_r1316322730 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2904,6 +2908,135 @@ private void validateGenericGroupHeartbeat

[GitHub] [kafka] C0urante commented on a diff in pull request #14304: KAFKA-13328, KAFKA-13329 (1): Add preflight validations for key, value, and header converter classes

C0urante commented on code in PR #14304: URL: https://github.com/apache/kafka/pull/14304#discussion_r1316306495 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1090,6 +1090,23 @@ public interface UncheckedCloseable extends AutoCloseable { void

[jira] [Created] (KAFKA-15436) Custom ConfigDef validators are invoked with null when user-provided value does not match type

Chris Egerton created KAFKA-15436: - Summary: Custom ConfigDef validators are invoked with null when user-provided value does not match type Key: KAFKA-15436 URL: https://issues.apache.org/jira/browse/KAFKA-15436

[GitHub] [kafka] tylerbertrand opened a new pull request, #14344: Resolve checkstyle cache miss

tylerbertrand opened a new pull request, #14344: URL: https://github.com/apache/kafka/pull/14344 Resolves cache misses in `checkstyle` tasks due to absolute paths in `configProperties`. Sets `configDirectory` extension property, which is made available by the `checkstyle` plugin as `

[jira] [Resolved] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-9800. Fix Version/s: 3.7.0 Resolution: Fixed Merged [https://github.com/apache/kafka/pull/14111] to trunk.

[GitHub] [kafka] junrao commented on pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

junrao commented on PR #8846: URL: https://github.com/apache/kafka/pull/8846#issuecomment-1707163099 This probably should be closed now that https://github.com/apache/kafka/pull/14111 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] C0urante commented on pull request #14313: KAFKA-15416: Fix flaky TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound test case

C0urante commented on PR #14313: URL: https://github.com/apache/kafka/pull/14313#issuecomment-1707161908 @philipnee Let me know if you're still looking into this. Happy to wait on your analysis if you are, and if not, we can merge as-is. -- This is an automated message from the Apache Git

[GitHub] [kafka] junrao merged pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

junrao merged PR #14111: URL: https://github.com/apache/kafka/pull/14111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14147: KAFKA-14502; Implement LeaveGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #14147: URL: https://github.com/apache/kafka/pull/14147#discussion_r1316274795 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2904,6 +2908,135 @@ private void validateGenericGroupHeartbeat

[GitHub] [kafka] C0urante commented on pull request #14336: KAFKA-14876: Add stopped state to Kafka Connect Administration docs section

C0urante commented on PR #14336: URL: https://github.com/apache/kafka/pull/14336#issuecomment-1707142324 BTW, same thought about backporting--I'm going to cherry-pick these changes on the `apache/kafka` repo onto the 3.5 and 3.6 branches, and for them to show up immediately, feel free to fi

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14147: KAFKA-14502; Implement LeaveGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #14147: URL: https://github.com/apache/kafka/pull/14147#discussion_r1316264712 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java: ## @@ -306,6 +308,22 @@ public CoordinatorResult commitOffset(

[GitHub] [kafka] C0urante merged pull request #14336: KAFKA-14876: Add stopped state to Kafka Connect Administration docs section

C0urante merged PR #14336: URL: https://github.com/apache/kafka/pull/14336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] yashmayya commented on pull request #14337: MINOR: Update the documentation's table of contents to add missing headings for Kafka Connect

yashmayya commented on PR #14337: URL: https://github.com/apache/kafka/pull/14337#issuecomment-1707112259 Thanks for the review and suggestion Chris! I've raised https://github.com/apache/kafka-site/pull/538 to port over these changes. -- This is an automated message from the Apache Git S

[GitHub] [kafka] mumrah commented on a diff in pull request #14342: KAFKA-15435 Fix counts in MigrationManifest

mumrah commented on code in PR #14342: URL: https://github.com/apache/kafka/pull/14342#discussion_r1316249748 ## metadata/src/main/java/org/apache/kafka/metadata/migration/MigrationManifest.java: ## @@ -60,7 +61,8 @@ public MigrationManifest build() { if (endTimeNan

[GitHub] [kafka] mumrah commented on a diff in pull request #14342: KAFKA-15435 Fix counts in MigrationManifest

mumrah commented on code in PR #14342: URL: https://github.com/apache/kafka/pull/14342#discussion_r1316249748 ## metadata/src/main/java/org/apache/kafka/metadata/migration/MigrationManifest.java: ## @@ -60,7 +61,8 @@ public MigrationManifest build() { if (endTimeNan

[jira] [Commented] (KAFKA-14517) Implement regex subscriptions

[ https://issues.apache.org/jira/browse/KAFKA-14517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762186#comment-17762186 ] Jimmy Wang commented on KAFKA-14517: [~dajac]  Got it. I refactored the previous co

[GitHub] [kafka] lzyLuke commented on a diff in pull request #14342: KAFKA-15435 Fix counts in MigrationManifest

lzyLuke commented on code in PR #14342: URL: https://github.com/apache/kafka/pull/14342#discussion_r1316244101 ## metadata/src/main/java/org/apache/kafka/metadata/migration/MigrationManifest.java: ## @@ -60,7 +61,8 @@ public MigrationManifest build() { if (endTimeNa

[GitHub] [kafka] yashmayya commented on pull request #14336: KAFKA-14876: Add stopped state to Kafka Connect Administration docs section

yashmayya commented on PR #14336: URL: https://github.com/apache/kafka/pull/14336#issuecomment-1707093218 Ah whoops, that was not intentional. Good catch, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] rreddy-22 opened a new pull request, #14343: Minor fix trailing white spaces on reviewers.py

rreddy-22 opened a new pull request, #14343: URL: https://github.com/apache/kafka/pull/14343 Minor: Fixing trailing white spaces on reviewers.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] C0urante commented on pull request #14336: KAFKA-14876: Add stopped state to Kafka Connect Administration docs section

C0urante commented on PR #14336: URL: https://github.com/apache/kafka/pull/14336#issuecomment-1707076130 The new paragraph looks great, but was the `STOPPED` state summary in the section beginning with "Connectors and their tasks publish status updates" intentionally removed? That part look

[GitHub] [kafka] C0urante commented on pull request #14337: MINOR: Update the documentation's table of contents to add missing headings for Kafka Connect

C0urante commented on PR #14337: URL: https://github.com/apache/kafka/pull/14337#issuecomment-1707068710 I've backported this to the 3.5 and 3.6 branches; it should be reflected once a new release is put out on those. @yashmayya if you'd like, feel free to file a PR against https://g

[GitHub] [kafka] C0urante merged pull request #14337: MINOR: Update the documentation's table of contents to add missing headings for Kafka Connect

C0urante merged PR #14337: URL: https://github.com/apache/kafka/pull/14337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] mumrah opened a new pull request, #14342: KAFKA-15435 Fix counts in MigrationManifest

mumrah opened a new pull request, #14342: URL: https://github.com/apache/kafka/pull/14342 This patch fixes an issue in MigrationManifest where we weren't computing the record counts properly. A unit test was added to verify the fix. This patch also changes the counters in MigrationMa

[GitHub] [kafka] C0urante commented on a diff in pull request #14279: KAFKA-15179: Add integration tests for the file sink and source connectors

C0urante commented on code in PR #14279: URL: https://github.com/apache/kafka/pull/14279#discussion_r1316170261 ## connect/file/src/test/java/org/apache/kafka/connect/file/integration/FileStreamSinkConnectorIntegrationTest.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the Apach

[GitHub] [kafka] dajac commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

dajac commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r1316210535 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -1491,10 +1526,15 @@ public void testConsumerGroupOffsetFetch

[GitHub] [kafka] jolshan commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

jolshan commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r1316209008 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -1491,10 +1526,15 @@ public void testConsumerGroupOffsetFet

[GitHub] [kafka] jolshan commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

jolshan commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r1316207292 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -1491,10 +1526,15 @@ public void testConsumerGroupOffsetFet

[GitHub] [kafka] jolshan commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

jolshan commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r1316197710 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -181,10 +181,28 @@ public List fetchOffsets( S

[GitHub] [kafka] yashmayya commented on a diff in pull request #14337: MINOR: Update the documentation's table of contents to add missing headings for Kafka Connect

yashmayya commented on code in PR #14337: URL: https://github.com/apache/kafka/pull/14337#discussion_r1316183113 ## docs/toc.html: ## @@ -206,6 +206,14 @@ Plugin Discovery 8.3 Connector Development Guide +

[GitHub] [kafka] yashmayya commented on a diff in pull request #14336: KAFKA-14876: Add stopped state to Kafka Connect Administration docs section

yashmayya commented on code in PR #14336: URL: https://github.com/apache/kafka/pull/14336#discussion_r1316175988 ## docs/connect.html: ## @@ -1078,7 +1079,7 @@ Kafka Connect -It's sometimes useful to temporarily stop the message processing of a connector. For

[GitHub] [kafka] C0urante commented on a diff in pull request #14337: MINOR: Update the documentation's table of contents to add missing headings for Kafka Connect

C0urante commented on code in PR #14337: URL: https://github.com/apache/kafka/pull/14337#discussion_r1316159088 ## docs/toc.html: ## @@ -206,6 +206,14 @@ Plugin Discovery 8.3 Connector Development Guide +

[GitHub] [kafka] C0urante commented on a diff in pull request #14337: MINOR: Update the documentation's table of contents to add missing headings for Kafka Connect

C0urante commented on code in PR #14337: URL: https://github.com/apache/kafka/pull/14337#discussion_r1316159088 ## docs/toc.html: ## @@ -206,6 +206,14 @@ Plugin Discovery 8.3 Connector Development Guide +

[GitHub] [kafka] Cerchie opened a new pull request, #14341: KAFKA-15307: Removes non-existent configs

Cerchie opened a new pull request, #14341: URL: https://github.com/apache/kafka/pull/14341 addresses 1/3 of https://issues.apache.org/jira/browse/KAFKA-15307 Removes pieces of configuration from the [developer guide to configuring streams.](https://kafka.apache.org/35/documentation/s

[GitHub] [kafka] C0urante commented on a diff in pull request #14336: KAFKA-14876: Add stopped state to Kafka Connect Administration docs section

C0urante commented on code in PR #14336: URL: https://github.com/apache/kafka/pull/14336#discussion_r1316150923 ## docs/connect.html: ## @@ -1078,7 +1079,7 @@ Kafka Connect -It's sometimes useful to temporarily stop the message processing of a connector. For e

[GitHub] [kafka] Cerchie commented on pull request #14341: KAFKA-15307: Removes non-existent configs

Cerchie commented on PR #14341: URL: https://github.com/apache/kafka/pull/14341#issuecomment-1706973281 @mjsax for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Resolved] (KAFKA-15293) Update metrics doc to add tiered storage metrics

[ https://issues.apache.org/jira/browse/KAFKA-15293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana resolved KAFKA-15293. Resolution: Fixed > Update metrics doc to add tiered storage metrics > ---

[GitHub] [kafka] satishd merged pull request #14331: KAFKA-15293 Add documentation for tiered storage metrics

satishd merged PR #14331: URL: https://github.com/apache/kafka/pull/14331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] satishd commented on pull request #14331: KAFKA-15293 Add documentation for tiered storage metrics

satishd commented on PR #14331: URL: https://github.com/apache/kafka/pull/14331#issuecomment-1706953908 There are a few failed tests that are unrelated to this PR. Merging it to trunk and 3.6. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] satishd commented on pull request #14335: MINOR: update comment in consumeAction

satishd commented on PR #14335: URL: https://github.com/apache/kafka/pull/14335#issuecomment-1706906829 There are a few failed tests unrelated to this PR. Merging it to trunk and 3.6. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] satishd merged pull request #14335: MINOR: update comment in consumeAction

satishd merged PR #14335: URL: https://github.com/apache/kafka/pull/14335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] riedelmax commented on pull request #14124: KAFKA-14509; [1/2] Define ConsumerGroupDescribe API request and response schemas and classes.

riedelmax commented on PR #14124: URL: https://github.com/apache/kafka/pull/14124#issuecomment-1706895064 @dajac Thank you for the review. I added unit tests and corrected the nits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Created] (KAFKA-15435) KRaft migration record counts in log message are incorrect

David Arthur created KAFKA-15435: Summary: KRaft migration record counts in log message are incorrect Key: KAFKA-15435 URL: https://issues.apache.org/jira/browse/KAFKA-15435 Project: Kafka Is

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1316096433 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -89,16 +93,17 @@ public MemberWithRemainingAssignments(String

[GitHub] [kafka] cadonna commented on pull request #14317: KAFKA-13973: Fix inflated block cache metrics

cadonna commented on PR #14317: URL: https://github.com/apache/kafka/pull/14317#issuecomment-1706873185 @nicktelford Yes, you are right about the existing tests! Sorry I was in a hurry and only skimmed them and missed that fact. I would like to have some tests that verify the behavior wit

[jira] [Commented] (KAFKA-15414) remote logs get deleted after partition reassignment

[ https://issues.apache.org/jira/browse/KAFKA-15414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762138#comment-17762138 ] Kamal Chandraprakash commented on KAFKA-15414: -- [~fvisconte]  Could you pl

[GitHub] [kafka] kamalcph commented on pull request #14340: KAFKA-15351: Update log-start-offset after leader election for topics enabled with remote storage

kamalcph commented on PR #14340: URL: https://github.com/apache/kafka/pull/14340#issuecomment-1706829016 @clolov @divijvaidya @showuon @abhijeetk88 @satishd Call for review. Please take a look! -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] kamalcph opened a new pull request, #14340: KAFKA-15351: Update log-start-offset after leader election for topics enabled with remote storage

kamalcph opened a new pull request, #14340: URL: https://github.com/apache/kafka/pull/14340 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

[GitHub] [kafka] Chuckame commented on pull request #14157: KAFKA-15303: Avoid unnecessary re-serialization in FK-join

Chuckame commented on PR #14157: URL: https://github.com/apache/kafka/pull/14157#issuecomment-1706826894 Hello @mjsax, do you know if there is potential advancement about this fix ? 🙇 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-15221) Potential race condition between requests from rebooted followers

[ https://issues.apache.org/jira/browse/KAFKA-15221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762134#comment-17762134 ] Calvin Liu commented on KAFKA-15221: [~satish.duggana] The PR is pending review, it

  1   2   >