[GitHub] [kafka] see-quick commented on a diff in pull request #14211: MINOR: Add a few test cases to clients

2023-08-21 Thread via GitHub
see-quick commented on code in PR #14211: URL: https://github.com/apache/kafka/pull/14211#discussion_r1301064046 ## clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java: ## @@ -2399,4 +2400,39 @@ public KafkaProducer newKafkaProducer() { }

[GitHub] [kafka] see-quick commented on a diff in pull request #14211: MINOR: Add a few test cases to clients

2023-08-21 Thread via GitHub
see-quick commented on code in PR #14211: URL: https://github.com/apache/kafka/pull/14211#discussion_r1301064046 ## clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java: ## @@ -2399,4 +2400,39 @@ public KafkaProducer newKafkaProducer() { }

[GitHub] [kafka] showuon commented on pull request #14078: KAFKA-14780: Fix flaky test 'testSecondaryRefreshAfterElapsedDelay'

2023-08-21 Thread via GitHub
showuon commented on PR #14078: URL: https://github.com/apache/kafka/pull/14078#issuecomment-1687439048 Let's wait for the CI build results and also see if @divijvaidya wants to have another review. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] dengziming opened a new pull request, #14272: KAFKA-15390: Do not return fenced broker in FetchResponse.preferredReplica

2023-08-21 Thread via GitHub
dengziming opened a new pull request, #14272: URL: https://github.com/apache/kafka/pull/14272 *More detailed description of your change* `KRaftMetadataCache.getPartitionReplicaEndpoints` will return fenced broker ids, this is not consistent with ZKMetadataCache, *Summary of testin

[jira] [Created] (KAFKA-15390) FetchResponse.preferredReplica may contains fenced replica in KRaft mode

2023-08-21 Thread Deng Ziming (Jira)
Deng Ziming created KAFKA-15390: --- Summary: FetchResponse.preferredReplica may contains fenced replica in KRaft mode Key: KAFKA-15390 URL: https://issues.apache.org/jira/browse/KAFKA-15390 Project: Kafka

[GitHub] [kafka] mehbey commented on a diff in pull request #14135: KAFKA-14991: Implementation of KIP-937 which improves message timesta…

2023-08-21 Thread via GitHub
mehbey commented on code in PR #14135: URL: https://github.com/apache/kafka/pull/14135#discussion_r1300902598 ## core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala: ## @@ -121,16 +122,18 @@ class PlaintextProducerSendTest extends BaseProducerSendTest {

[GitHub] [kafka] bachmanity1 commented on pull request #14255: [KAFKA-14133] Migrate EasyMock to Mockito in StateRestoreCallbackAdapterTest, Store…

2023-08-21 Thread via GitHub
bachmanity1 commented on PR #14255: URL: https://github.com/apache/kafka/pull/14255#issuecomment-1687414682 Hi @olalamichelle, I was planning to open a PR but since you've started to work on this and opened a PR I can transfer the ownership to you. -- This is an automated message from th

[GitHub] [kafka] olalamichelle closed pull request #14250: [KAFKA-15385] Migrate EasyMock to Mockito in AbstractStreamTest

2023-08-21 Thread via GitHub
olalamichelle closed pull request #14250: [KAFKA-15385] Migrate EasyMock to Mockito in AbstractStreamTest URL: https://github.com/apache/kafka/pull/14250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] olalamichelle closed pull request #14251: [KAFKA-15384] Migrate EasyMock to Mockito in KTableTransformValuesTest

2023-08-21 Thread via GitHub
olalamichelle closed pull request #14251: [KAFKA-15384] Migrate EasyMock to Mockito in KTableTransformValuesTest URL: https://github.com/apache/kafka/pull/14251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] olalamichelle closed pull request #14252: [KAFKA-15383] Migrate EasyMock to Mockito in KTableImplTest

2023-08-21 Thread via GitHub
olalamichelle closed pull request #14252: [KAFKA-15383] Migrate EasyMock to Mockito in KTableImplTest URL: https://github.com/apache/kafka/pull/14252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] olalamichelle closed pull request #14253: [KAFKA-15382] Migrate EasyMock to Mockito in KStreamTransformValuesTest

2023-08-21 Thread via GitHub
olalamichelle closed pull request #14253: [KAFKA-15382] Migrate EasyMock to Mockito in KStreamTransformValuesTest URL: https://github.com/apache/kafka/pull/14253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kafka] olalamichelle commented on pull request #14255: [KAFKA-14133] Migrate EasyMock to Mockito in StateRestoreCallbackAdapterTest, Store…

2023-08-21 Thread via GitHub
olalamichelle commented on PR #14255: URL: https://github.com/apache/kafka/pull/14255#issuecomment-1687401357 Hi @bachmanity1, have you already submitted PR for this test? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kafka] olalamichelle commented on pull request #14256: [KAFKA-14133] Migrate EasyMock to Mockito in GlobalStateStoreProviderTest, KeyValue…

2023-08-21 Thread via GitHub
olalamichelle commented on PR #14256: URL: https://github.com/apache/kafka/pull/14256#issuecomment-1687398392 Hi @yashmayya, sorry I didn't realize that lots of these tests were already assigned and even already had PRs. Thank you so much for transferring ownership to me! Btw, @yashmayy

[GitHub] [kafka] olalamichelle commented on pull request #14262: [KAFKA-14133] Migrate EasyMock to Mockito in RocksDBGenericOptionsToDbOptionsColumF…

2023-08-21 Thread via GitHub
olalamichelle commented on PR #14262: URL: https://github.com/apache/kafka/pull/14262#issuecomment-1687382593 Hi @clolov, it seems that I don't have permission to edit the description and assign my name to RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest. Could you please hel

[GitHub] [kafka] showuon commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-21 Thread via GitHub
showuon commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1300875008 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,

[GitHub] [kafka] olalamichelle closed pull request #14254: [KAFKA-14133] Migrate EasyMock to Mockito in RecordCollectorTest

2023-08-21 Thread via GitHub
olalamichelle closed pull request #14254: [KAFKA-14133] Migrate EasyMock to Mockito in RecordCollectorTest URL: https://github.com/apache/kafka/pull/14254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] olalamichelle closed pull request #14263: [KAFKA-14133] Migrate EasyMock to Mockito in RocksDBMetricsRecordingTriggerTest, Wi…

2023-08-21 Thread via GitHub
olalamichelle closed pull request #14263: [KAFKA-14133] Migrate EasyMock to Mockito in RocksDBMetricsRecordingTriggerTest, Wi… URL: https://github.com/apache/kafka/pull/14263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] olalamichelle commented on pull request #14263: [KAFKA-14133] Migrate EasyMock to Mockito in RocksDBMetricsRecordingTriggerTest, Wi…

2023-08-21 Thread via GitHub
olalamichelle commented on PR #14263: URL: https://github.com/apache/kafka/pull/14263#issuecomment-1687373828 Thanks for letting me know! I will close this pull request then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (KAFKA-15309) Add custom error handler to Producer

2023-08-21 Thread Fei Xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757189#comment-17757189 ] Fei Xie commented on KAFKA-15309: - Hi [~mjsax] , I am new to Kafka (I used Kafka daily i

[GitHub] [kafka] showuon commented on a diff in pull request #14078: KAFKA-14780: Fix flaky test 'testSecondaryRefreshAfterElapsedDelay'

2023-08-21 Thread via GitHub
showuon commented on code in PR #14078: URL: https://github.com/apache/kafka/pull/14078#discussion_r1300849860 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -195,4 +231,68 @@ public String getBody() {

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-21 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1300830591 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java: ## @@ -0,0 +1,414 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-21 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1300819413 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java: ## @@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-21 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1300819413 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java: ## @@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {

[GitHub] [kafka] zhaohaidao opened a new pull request, #14271: Kafka 14503: Implement ListGroups

2023-08-21 Thread via GitHub
zhaohaidao opened a new pull request, #14271: URL: https://github.com/apache/kafka/pull/14271 Implement ListGroups ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documen

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-21 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1300780584 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-21 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1300779466 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] cmccabe merged pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

2023-08-21 Thread via GitHub
cmccabe merged PR #14208: URL: https://github.com/apache/kafka/pull/14208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] lianetm commented on pull request #14218: KAFKA-14937; [2/N]: Refactoring for client code to reduce boilerplate

2023-08-21 Thread via GitHub
lianetm commented on PR #14218: URL: https://github.com/apache/kafka/pull/14218#issuecomment-1687066491 Thanks for the comments @junrao . All addressed. All tests pass locally, I will keep and eye on the build here and check the output -- This is an automated message from the Apache Git S

[GitHub] [kafka] lianetm commented on a diff in pull request #14218: KAFKA-14937; [2/N]: Refactoring for client code to reduce boilerplate

2023-08-21 Thread via GitHub
lianetm commented on code in PR #14218: URL: https://github.com/apache/kafka/pull/14218#discussion_r1300660815 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -206,46 +199,34 @@ public void run() { * 3. Poll the netw

[GitHub] [kafka] wcarlson5 commented on pull request #14269: KAFKA-14936: fix grace period partition issue

2023-08-21 Thread via GitHub
wcarlson5 commented on PR #14269: URL: https://github.com/apache/kafka/pull/14269#issuecomment-1687047998 Picking back to 3.6 as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] wcarlson5 merged pull request #14269: KAFKA-14936: fix grace period partition issue

2023-08-21 Thread via GitHub
wcarlson5 merged PR #14269: URL: https://github.com/apache/kafka/pull/14269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] wcarlson5 commented on pull request #14269: KAFKA-14936: fix grace period partition issue

2023-08-21 Thread via GitHub
wcarlson5 commented on PR #14269: URL: https://github.com/apache/kafka/pull/14269#issuecomment-1687044375 Test failures were unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-21 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1300637770 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-21 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1300633833 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java: ## @@ -0,0 +1,218 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-21 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1300633100 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-21 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1300631692 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-21 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1300631692 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-21 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1300627015 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-21 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1300622597 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Ap

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-21 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1300620312 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignor.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] junrao commented on a diff in pull request #14218: KAFKA-14937; [2/N]: Refactoring for client code to reduce boilerplate

2023-08-21 Thread via GitHub
junrao commented on code in PR #14218: URL: https://github.com/apache/kafka/pull/14218#discussion_r1300543812 ## clients/src/main/java/org/apache/kafka/clients/ClientUtils.java: ## @@ -246,13 +247,22 @@ public static NetworkClient createNetworkClient(AbstractConfig config,

[GitHub] [kafka] C0urante commented on a diff in pull request #12637: KAFKA-14226 (KIP-821): [connect:transform] Introduce support for nested structures

2023-08-21 Thread via GitHub
C0urante commented on code in PR #12637: URL: https://github.com/apache/kafka/pull/12637#discussion_r1300510546 ## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java: ## @@ -0,0 +1,585 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] jolshan commented on a diff in pull request #14120: KAFKA-14499: [4/N] Implement OffsetFetch API

2023-08-21 Thread via GitHub
jolshan commented on code in PR #14120: URL: https://github.com/apache/kafka/pull/14120#discussion_r1300505047 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -1040,6 +1089,342 @@ public void testConsumerGroupOffsetCom

[GitHub] [kafka] wcarlson5 commented on pull request #14269: KAFKA-14936: fix grace period partition issue

2023-08-21 Thread via GitHub
wcarlson5 commented on PR #14269: URL: https://github.com/apache/kafka/pull/14269#issuecomment-1686823692 Alright I found a better solution to the context issue :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [kafka] rondagostino opened a new pull request, #14270: MINOR: Move delegation token support to Metadata Version 3.6-IV2

2023-08-21 Thread via GitHub
rondagostino opened a new pull request, #14270: URL: https://github.com/apache/kafka/pull/14270 https://github.com/apache/kafka/pull/14083 added support for delegation tokens in KRaft and attached that support to the existing MetadataVersion `3.6-IV1`. This patch moves that support into a

[GitHub] [kafka] C0urante commented on a diff in pull request #12637: KAFKA-14226 (KIP-821): [connect:transform] Introduce support for nested structures

2023-08-21 Thread via GitHub
C0urante commented on code in PR #12637: URL: https://github.com/apache/kafka/pull/12637#discussion_r1300486803 ## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/FieldSyntaxVersion.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [kafka] jolshan commented on a diff in pull request #14120: KAFKA-14499: [4/N] Implement OffsetFetch API

2023-08-21 Thread via GitHub
jolshan commented on code in PR #14120: URL: https://github.com/apache/kafka/pull/14120#discussion_r1300475705 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java: ## @@ -595,4 +599,98 @@ public void testHeartbeatCoordinatorExce

[GitHub] [kafka] jolshan commented on a diff in pull request #14120: KAFKA-14499: [4/N] Implement OffsetFetch API

2023-08-21 Thread via GitHub
jolshan commented on code in PR #14120: URL: https://github.com/apache/kafka/pull/14120#discussion_r1300471930 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -543,6 +543,14 @@ public void validateOffsetCommit( }

[GitHub] [kafka] jolshan commented on a diff in pull request #14120: KAFKA-14499: [4/N] Implement OffsetFetch API

2023-08-21 Thread via GitHub
jolshan commented on code in PR #14120: URL: https://github.com/apache/kafka/pull/14120#discussion_r1300471930 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -543,6 +543,14 @@ public void validateOffsetCommit( }

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

2023-08-21 Thread via GitHub
rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1300462035 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignor.java: ## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] jolshan commented on a diff in pull request #14120: KAFKA-14499: [4/N] Implement OffsetFetch API

2023-08-21 Thread via GitHub
jolshan commented on code in PR #14120: URL: https://github.com/apache/kafka/pull/14120#discussion_r1300441719 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -401,7 +401,18 @@ public MetadataImage image() { * @return

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14124: Kafka-14509; [1/2] Define ConsumerGroupDescribe API request and response schemas and classes.

2023-08-21 Thread via GitHub
jeffkbkim commented on code in PR #14124: URL: https://github.com/apache/kafka/pull/14124#discussion_r1300435377 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3661,6 +3662,37 @@ class KafkaApis(val requestChannel: RequestChannel, } } + def handleConsumer

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14124: Kafka-14509; [1/2] Define ConsumerGroupDescribe API request and response schemas and classes.

2023-08-21 Thread via GitHub
jeffkbkim commented on code in PR #14124: URL: https://github.com/apache/kafka/pull/14124#discussion_r1300435780 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3661,6 +3662,37 @@ class KafkaApis(val requestChannel: RequestChannel, } } + def handleConsumer

[GitHub] [kafka] jolshan commented on a diff in pull request #14120: KAFKA-14499: [4/N] Implement OffsetFetch API

2023-08-21 Thread via GitHub
jolshan commented on code in PR #14120: URL: https://github.com/apache/kafka/pull/14120#discussion_r1300439381 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java: ## @@ -256,6 +259,40 @@ public HeartbeatResponseData genericGroupHeart

[GitHub] [kafka] jolshan commented on a diff in pull request #14120: KAFKA-14499: [4/N] Implement OffsetFetch API

2023-08-21 Thread via GitHub
jolshan commented on code in PR #14120: URL: https://github.com/apache/kafka/pull/14120#discussion_r1300427290 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -480,9 +482,35 @@ public CompletableFuture retur

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #14269: KAFKA-14936: fix grace period partition issue

2023-08-21 Thread via GitHub
wcarlson5 commented on code in PR #14269: URL: https://github.com/apache/kafka/pull/14269#discussion_r1300411569 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java: ## @@ -83,9 +83,12 @@ public void init(final ProcessorContext con

[GitHub] [kafka] rondagostino merged pull request #14268: MINOR: Enable delegation token system test for KRaft

2023-08-21 Thread via GitHub
rondagostino merged PR #14268: URL: https://github.com/apache/kafka/pull/14268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[jira] [Commented] (KAFKA-14503) Implement ListGroups

2023-08-21 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757017#comment-17757017 ] David Jacot commented on KAFKA-14503: - Hey [~zhaohaidao]. Thanks for picking up this

[GitHub] [kafka] tinaselenge commented on a diff in pull request #14266: KAFKA-15294: Publish remote storage configs

2023-08-21 Thread via GitHub
tinaselenge commented on code in PR #14266: URL: https://github.com/apache/kafka/pull/14266#discussion_r1300374040 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -146,111 +146,111 @@ public final class RemoteLogManagerConfi

[GitHub] [kafka] junrao commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-21 Thread via GitHub
junrao commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1300372620 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -696,11 +704,327 @@ public void run() { } } +public void handleLogSta

[GitHub] [kafka] kamalcph commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-21 Thread via GitHub
kamalcph commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1300364254 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java: ## @@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {

[GitHub] [kafka] kamalcph commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-21 Thread via GitHub
kamalcph commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1300348538 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java: ## @@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {

[GitHub] [kafka] kamalcph commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-21 Thread via GitHub
kamalcph commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1300348538 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java: ## @@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {

[GitHub] [kafka] kamalcph commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-21 Thread via GitHub
kamalcph commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1300343897 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java: ## @@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-21 Thread via GitHub
kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1300319555 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,

[GitHub] [kafka] jeqo commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-21 Thread via GitHub
jeqo commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1300314011 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1096,6 +1493,43 @@ public void close() { } } +// Visible for testing +public s

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-21 Thread via GitHub
kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1300316787 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,

[GitHub] [kafka] vvcephei commented on a diff in pull request #14269: KAFKA-14936: fix grace period partition issue

2023-08-21 Thread via GitHub
vvcephei commented on code in PR #14269: URL: https://github.com/apache/kafka/pull/14269#discussion_r1300308721 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java: ## @@ -83,9 +83,12 @@ public void init(final ProcessorContext cont

[GitHub] [kafka] jolshan merged pull request #14197: KAFKA-15380: Execute action queue after callback request

2023-08-21 Thread via GitHub
jolshan merged PR #14197: URL: https://github.com/apache/kafka/pull/14197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-21 Thread via GitHub
satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1300176481 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -761,11 +784,385 @@ public void run() { } } +public void handleLogSt

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-21 Thread via GitHub
satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1300279331 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -761,11 +784,385 @@ public void run() { } } +public void handleLogSt

[jira] [Updated] (KAFKA-15388) Handle topics that were having compaction as retention earlier are changed to delete only retention policy and onboarded to tiered storage.

2023-08-21 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15388: - Fix Version/s: 3.6.0 > Handle topics that were having compaction as retention earlier are change

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-21 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1300216608 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-21 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1300216006 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,

[jira] [Created] (KAFKA-15389) MetadataLoader may publish an empty image on first start

2023-08-21 Thread David Arthur (Jira)
David Arthur created KAFKA-15389: Summary: MetadataLoader may publish an empty image on first start Key: KAFKA-15389 URL: https://issues.apache.org/jira/browse/KAFKA-15389 Project: Kafka Issu

[jira] [Updated] (KAFKA-15388) Handle topics that were having compaction as retention earlier are changed to delete only retention policy and onboarded to tiered storage.

2023-08-21 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15388: - Description: Context: https://github.com/apache/kafka/pull/13561#discussion_r1300055517 > Handl

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-21 Thread via GitHub
divijvaidya commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1300199098 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -761,11 +784,385 @@ public void run() { } } +public void handleL

[GitHub] [kafka] wcarlson5 opened a new pull request, #14269: KAFKA-14936: fix grace period partition issue

2023-08-21 Thread via GitHub
wcarlson5 opened a new pull request, #14269: URL: https://github.com/apache/kafka/pull/14269 Move the store creation to builder pattern and recover mintimestamp. Also fix a flaky test for this feature. *More detailed description of your change, if necessary. The PR title and

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-21 Thread via GitHub
satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1300178242 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1096,6 +1493,43 @@ public void close() { } } +// Visible for testing +publi

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-21 Thread via GitHub
satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1300176481 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -761,11 +784,385 @@ public void run() { } } +public void handleLogSt

[jira] [Created] (KAFKA-15388) Handle topics that were having compaction as retention earlier are changed to delete only retention policy and onboarded to tiered storage.

2023-08-21 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-15388: -- Summary: Handle topics that were having compaction as retention earlier are changed to delete only retention policy and onboarded to tiered storage. Key: KAFKA-15388 URL: ht

[GitHub] [kafka] rondagostino commented on pull request #14268: MINOR: Enable delegation token system test for KRaft

2023-08-21 Thread via GitHub
rondagostino commented on PR #14268: URL: https://github.com/apache/kafka/pull/14268#issuecomment-1686366324 This should be merged to both `trunk` and `3.6`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [kafka] rondagostino opened a new pull request, #14268: MINOR: Enable delegation token system test for KRaft

2023-08-21 Thread via GitHub
rondagostino opened a new pull request, #14268: URL: https://github.com/apache/kafka/pull/14268 System test follow-on for https://github.com/apache/kafka/pull/14083 Ran locally and tests succeeded: ``` =

[GitHub] [kafka] rondagostino commented on pull request #14268: MINOR: Enable delegation token system test for KRaft

2023-08-21 Thread via GitHub
rondagostino commented on PR #14268: URL: https://github.com/apache/kafka/pull/14268#issuecomment-1686365535 cc @pprovenzano -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] yashmayya commented on pull request #14267: MINOR: Update OpenAPI summary documentation for Connect's /tasks endpoint

2023-08-21 Thread via GitHub
yashmayya commented on PR #14267: URL: https://github.com/apache/kafka/pull/14267#issuecomment-1686332907 @mimaison I noticed this minor discrepancy during our discussion on https://issues.apache.org/jira/browse/KAFKA-15377; could you please take a look? -- This is an automated message fr

[GitHub] [kafka] yashmayya opened a new pull request, #14267: MINOR: Update OpenAPI summary documentation for Connect's /tasks endpoint

2023-08-21 Thread via GitHub
yashmayya opened a new pull request, #14267: URL: https://github.com/apache/kafka/pull/14267 - The `GET /connectors/{connector}/tasks` endpoint not only lists the tasks for a connector but also returns their configurations (and is functionally identical to the `GET /connectors/{connector}/t

[GitHub] [kafka] OmniaGM commented on pull request #13204: KAFKA-14593: Move LeaderElectionCommand to tools

2023-08-21 Thread via GitHub
OmniaGM commented on PR #13204: URL: https://github.com/apache/kafka/pull/13204#issuecomment-1686311572 > Still with all the `LeaderElectionCommandTest` failures https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13204/15/testReport/ I will have a look into the `LeaderElection

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-21 Thread via GitHub
kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1300091311 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,

[GitHub] [kafka] mimaison commented on pull request #13204: KAFKA-14593: Move LeaderElectionCommand to tools

2023-08-21 Thread via GitHub
mimaison commented on PR #13204: URL: https://github.com/apache/kafka/pull/13204#issuecomment-1686299835 Still with all the `LeaderElectionCommandTest` failures https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13204/15/testReport/ -- This is an automated message from the Apac

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14266: KAFKA-15294: Publish remote storage configs

2023-08-21 Thread via GitHub
divijvaidya commented on code in PR #14266: URL: https://github.com/apache/kafka/pull/14266#discussion_r1300083853 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -146,111 +146,111 @@ public final class RemoteLogManagerConfi

[jira] [Commented] (KAFKA-14912) Introduce a configuration for remote index cache size, preferably a dynamic config.

2023-08-21 Thread hudeqi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756895#comment-17756895 ] hudeqi commented on KAFKA-14912: But how to measure and get the size of the entry? [~div

[GitHub] [kafka] kamalcph commented on pull request #14238: KAFKA-15290: Handle topic-level dynamic remote storage enable configuration

2023-08-21 Thread via GitHub
kamalcph commented on PR #14238: URL: https://github.com/apache/kafka/pull/14238#issuecomment-1686286807 > Do we need to implement dynamically configurable remote storage related things in a `DynamicRemoteLogManagerConfig` class similar to https://github.com/apache/kafka/pull/14243/files ?

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

2023-08-21 Thread via GitHub
divijvaidya commented on code in PR #14243: URL: https://github.com/apache/kafka/pull/14243#discussion_r1300024562 ## storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java: ## @@ -370,6 +384,10 @@ public long remoteLogIndexFileCacheTotalSiz

[jira] [Commented] (KAFKA-14912) Introduce a configuration for remote index cache size, preferably a dynamic config.

2023-08-21 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756886#comment-17756886 ] Divij Vaidya commented on KAFKA-14912: -- Hey [~hudeqi]  We would ideally want to ime

[jira] [Commented] (KAFKA-15290) Add support to onboard existing topics to tiered storage

2023-08-21 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756884#comment-17756884 ] Divij Vaidya commented on KAFKA-15290: -- When implementing this Jira, please ensure

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-08-21 Thread via GitHub
divijvaidya commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1300067600 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -166,6 +166,10 @@ public Cache internalCache() { return intern

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-21 Thread via GitHub
divijvaidya commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1300055517 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -761,11 +784,385 @@ public void run() { } } +public void handleL

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-21 Thread via GitHub
divijvaidya commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1300055517 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -761,11 +784,385 @@ public void run() { } } +public void handleL

[GitHub] [kafka] kamalcph commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-08-21 Thread via GitHub
kamalcph commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1300052574 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -166,6 +166,10 @@ public Cache internalCache() { return internalC

[jira] [Updated] (KAFKA-15387) Deprecate and remove Connect's redundant task configurations retrieval endpoint

2023-08-21 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya updated KAFKA-15387: --- Summary: Deprecate and remove Connect's redundant task configurations retrieval endpoint (was: Depr

  1   2   >