see-quick commented on code in PR #14211:
URL: https://github.com/apache/kafka/pull/14211#discussion_r1301064046
##
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##
@@ -2399,4 +2400,39 @@ public KafkaProducer newKafkaProducer() {
}
see-quick commented on code in PR #14211:
URL: https://github.com/apache/kafka/pull/14211#discussion_r1301064046
##
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##
@@ -2399,4 +2400,39 @@ public KafkaProducer newKafkaProducer() {
}
showuon commented on PR #14078:
URL: https://github.com/apache/kafka/pull/14078#issuecomment-1687439048
Let's wait for the CI build results and also see if @divijvaidya wants to
have another review.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
dengziming opened a new pull request, #14272:
URL: https://github.com/apache/kafka/pull/14272
*More detailed description of your change*
`KRaftMetadataCache.getPartitionReplicaEndpoints` will return fenced broker
ids, this is not consistent with ZKMetadataCache,
*Summary of testin
Deng Ziming created KAFKA-15390:
---
Summary: FetchResponse.preferredReplica may contains fenced
replica in KRaft mode
Key: KAFKA-15390
URL: https://issues.apache.org/jira/browse/KAFKA-15390
Project: Kafka
mehbey commented on code in PR #14135:
URL: https://github.com/apache/kafka/pull/14135#discussion_r1300902598
##
core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala:
##
@@ -121,16 +122,18 @@ class PlaintextProducerSendTest extends
BaseProducerSendTest {
bachmanity1 commented on PR #14255:
URL: https://github.com/apache/kafka/pull/14255#issuecomment-1687414682
Hi @olalamichelle, I was planning to open a PR but since you've started to
work on this and opened a PR I can transfer the ownership to you.
--
This is an automated message from th
olalamichelle closed pull request #14250: [KAFKA-15385] Migrate EasyMock to
Mockito in AbstractStreamTest
URL: https://github.com/apache/kafka/pull/14250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
olalamichelle closed pull request #14251: [KAFKA-15384] Migrate EasyMock to
Mockito in KTableTransformValuesTest
URL: https://github.com/apache/kafka/pull/14251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
olalamichelle closed pull request #14252: [KAFKA-15383] Migrate EasyMock to
Mockito in KTableImplTest
URL: https://github.com/apache/kafka/pull/14252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
olalamichelle closed pull request #14253: [KAFKA-15382] Migrate EasyMock to
Mockito in KStreamTransformValuesTest
URL: https://github.com/apache/kafka/pull/14253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
olalamichelle commented on PR #14255:
URL: https://github.com/apache/kafka/pull/14255#issuecomment-1687401357
Hi @bachmanity1, have you already submitted PR for this test? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
olalamichelle commented on PR #14256:
URL: https://github.com/apache/kafka/pull/14256#issuecomment-1687398392
Hi @yashmayya, sorry I didn't realize that lots of these tests were already
assigned and even already had PRs. Thank you so much for transferring ownership
to me!
Btw, @yashmayy
olalamichelle commented on PR #14262:
URL: https://github.com/apache/kafka/pull/14262#issuecomment-1687382593
Hi @clolov, it seems that I don't have permission to edit the description
and assign my name to
RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest. Could you
please hel
showuon commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1300875008
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,
olalamichelle closed pull request #14254: [KAFKA-14133] Migrate EasyMock to
Mockito in RecordCollectorTest
URL: https://github.com/apache/kafka/pull/14254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
olalamichelle closed pull request #14263: [KAFKA-14133] Migrate EasyMock to
Mockito in RocksDBMetricsRecordingTriggerTest, Wi…
URL: https://github.com/apache/kafka/pull/14263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
olalamichelle commented on PR #14263:
URL: https://github.com/apache/kafka/pull/14263#issuecomment-1687373828
Thanks for letting me know! I will close this pull request then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757189#comment-17757189
]
Fei Xie commented on KAFKA-15309:
-
Hi [~mjsax] , I am new to Kafka (I used Kafka daily i
showuon commented on code in PR #14078:
URL: https://github.com/apache/kafka/pull/14078#discussion_r1300849860
##
clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java:
##
@@ -195,4 +231,68 @@ public String getBody() {
showuon commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1300830591
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java:
##
@@ -0,0 +1,414 @@
+/*
+ * Licensed to the Apache Software Foundat
showuon commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1300819413
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java:
##
@@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {
showuon commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1300819413
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java:
##
@@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {
zhaohaidao opened a new pull request, #14271:
URL: https://github.com/apache/kafka/pull/14271
Implement ListGroups
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documen
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1300780584
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,399 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1300779466
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,399 @@
+/*
+ * Licensed to the Ap
cmccabe merged PR #14208:
URL: https://github.com/apache/kafka/pull/14208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
lianetm commented on PR #14218:
URL: https://github.com/apache/kafka/pull/14218#issuecomment-1687066491
Thanks for the comments @junrao . All addressed. All tests pass locally, I
will keep and eye on the build here and check the output
--
This is an automated message from the Apache Git S
lianetm commented on code in PR #14218:
URL: https://github.com/apache/kafka/pull/14218#discussion_r1300660815
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java:
##
@@ -206,46 +199,34 @@ public void run() {
* 3. Poll the netw
wcarlson5 commented on PR #14269:
URL: https://github.com/apache/kafka/pull/14269#issuecomment-1687047998
Picking back to 3.6 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
wcarlson5 merged PR #14269:
URL: https://github.com/apache/kafka/pull/14269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
wcarlson5 commented on PR #14269:
URL: https://github.com/apache/kafka/pull/14269#issuecomment-1687044375
Test failures were unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1300637770
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,399 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1300633833
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java:
##
@@ -0,0 +1,218 @@
+/*
+ * Licensed to the Apache Software Foun
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1300633100
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,399 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1300631692
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,399 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1300631692
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,399 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1300627015
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,399 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1300622597
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java:
##
@@ -0,0 +1,399 @@
+/*
+ * Licensed to the Ap
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1300620312
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignor.java:
##
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache Softw
junrao commented on code in PR #14218:
URL: https://github.com/apache/kafka/pull/14218#discussion_r1300543812
##
clients/src/main/java/org/apache/kafka/clients/ClientUtils.java:
##
@@ -246,13 +247,22 @@ public static NetworkClient
createNetworkClient(AbstractConfig config,
C0urante commented on code in PR #12637:
URL: https://github.com/apache/kafka/pull/12637#discussion_r1300510546
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java:
##
@@ -0,0 +1,585 @@
+/*
+ * Licensed to the Apache Software Founda
jolshan commented on code in PR #14120:
URL: https://github.com/apache/kafka/pull/14120#discussion_r1300505047
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -1040,6 +1089,342 @@ public void
testConsumerGroupOffsetCom
wcarlson5 commented on PR #14269:
URL: https://github.com/apache/kafka/pull/14269#issuecomment-1686823692
Alright I found a better solution to the context issue :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
rondagostino opened a new pull request, #14270:
URL: https://github.com/apache/kafka/pull/14270
https://github.com/apache/kafka/pull/14083 added support for delegation
tokens in KRaft and attached that support to the existing MetadataVersion
`3.6-IV1`. This patch moves that support into a
C0urante commented on code in PR #12637:
URL: https://github.com/apache/kafka/pull/12637#discussion_r1300486803
##
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/FieldSyntaxVersion.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Fou
jolshan commented on code in PR #14120:
URL: https://github.com/apache/kafka/pull/14120#discussion_r1300475705
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -595,4 +599,98 @@ public void testHeartbeatCoordinatorExce
jolshan commented on code in PR #14120:
URL: https://github.com/apache/kafka/pull/14120#discussion_r1300471930
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -543,6 +543,14 @@ public void validateOffsetCommit(
}
jolshan commented on code in PR #14120:
URL: https://github.com/apache/kafka/pull/14120#discussion_r1300471930
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -543,6 +543,14 @@ public void validateOffsetCommit(
}
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1300462035
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignor.java:
##
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache Softw
jolshan commented on code in PR #14120:
URL: https://github.com/apache/kafka/pull/14120#discussion_r1300441719
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -401,7 +401,18 @@ public MetadataImage image() {
* @return
jeffkbkim commented on code in PR #14124:
URL: https://github.com/apache/kafka/pull/14124#discussion_r1300435377
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3661,6 +3662,37 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ def handleConsumer
jeffkbkim commented on code in PR #14124:
URL: https://github.com/apache/kafka/pull/14124#discussion_r1300435780
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3661,6 +3662,37 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ def handleConsumer
jolshan commented on code in PR #14120:
URL: https://github.com/apache/kafka/pull/14120#discussion_r1300439381
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java:
##
@@ -256,6 +259,40 @@ public HeartbeatResponseData genericGroupHeart
jolshan commented on code in PR #14120:
URL: https://github.com/apache/kafka/pull/14120#discussion_r1300427290
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -480,9 +482,35 @@ public
CompletableFuture
retur
wcarlson5 commented on code in PR #14269:
URL: https://github.com/apache/kafka/pull/14269#discussion_r1300411569
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java:
##
@@ -83,9 +83,12 @@ public void init(final ProcessorContext con
rondagostino merged PR #14268:
URL: https://github.com/apache/kafka/pull/14268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
[
https://issues.apache.org/jira/browse/KAFKA-14503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757017#comment-17757017
]
David Jacot commented on KAFKA-14503:
-
Hey [~zhaohaidao]. Thanks for picking up this
tinaselenge commented on code in PR #14266:
URL: https://github.com/apache/kafka/pull/14266#discussion_r1300374040
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -146,111 +146,111 @@ public final class RemoteLogManagerConfi
junrao commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1300372620
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -696,11 +704,327 @@ public void run() {
}
}
+public void handleLogSta
kamalcph commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1300364254
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java:
##
@@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {
kamalcph commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1300348538
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java:
##
@@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {
kamalcph commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1300348538
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java:
##
@@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {
kamalcph commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1300343897
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java:
##
@@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {
kamalcph commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1300319555
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,
jeqo commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1300314011
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1096,6 +1493,43 @@ public void close() {
}
}
+// Visible for testing
+public s
kamalcph commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1300316787
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,
vvcephei commented on code in PR #14269:
URL: https://github.com/apache/kafka/pull/14269#discussion_r1300308721
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java:
##
@@ -83,9 +83,12 @@ public void init(final ProcessorContext cont
jolshan merged PR #14197:
URL: https://github.com/apache/kafka/pull/14197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1300176481
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -761,11 +784,385 @@ public void run() {
}
}
+public void handleLogSt
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1300279331
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -761,11 +784,385 @@ public void run() {
}
}
+public void handleLogSt
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15388:
-
Fix Version/s: 3.6.0
> Handle topics that were having compaction as retention earlier are change
clolov commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1300216608
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,
clolov commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1300216006
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,
David Arthur created KAFKA-15389:
Summary: MetadataLoader may publish an empty image on first start
Key: KAFKA-15389
URL: https://issues.apache.org/jira/browse/KAFKA-15389
Project: Kafka
Issu
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15388:
-
Description: Context:
https://github.com/apache/kafka/pull/13561#discussion_r1300055517
> Handl
divijvaidya commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1300199098
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -761,11 +784,385 @@ public void run() {
}
}
+public void handleL
wcarlson5 opened a new pull request, #14269:
URL: https://github.com/apache/kafka/pull/14269
Move the store creation to builder pattern and recover mintimestamp.
Also fix a flaky test for this feature.
*More detailed description of your change,
if necessary. The PR title and
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1300178242
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -1096,6 +1493,43 @@ public void close() {
}
}
+// Visible for testing
+publi
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1300176481
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -761,11 +784,385 @@ public void run() {
}
}
+public void handleLogSt
Satish Duggana created KAFKA-15388:
--
Summary: Handle topics that were having compaction as retention
earlier are changed to delete only retention policy and onboarded to tiered
storage.
Key: KAFKA-15388
URL: ht
rondagostino commented on PR #14268:
URL: https://github.com/apache/kafka/pull/14268#issuecomment-1686366324
This should be merged to both `trunk` and `3.6`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
rondagostino opened a new pull request, #14268:
URL: https://github.com/apache/kafka/pull/14268
System test follow-on for https://github.com/apache/kafka/pull/14083
Ran locally and tests succeeded:
```
=
rondagostino commented on PR #14268:
URL: https://github.com/apache/kafka/pull/14268#issuecomment-1686365535
cc @pprovenzano
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
yashmayya commented on PR #14267:
URL: https://github.com/apache/kafka/pull/14267#issuecomment-1686332907
@mimaison I noticed this minor discrepancy during our discussion on
https://issues.apache.org/jira/browse/KAFKA-15377; could you please take a look?
--
This is an automated message fr
yashmayya opened a new pull request, #14267:
URL: https://github.com/apache/kafka/pull/14267
- The `GET /connectors/{connector}/tasks` endpoint not only lists the tasks
for a connector but also returns their configurations (and is functionally
identical to the `GET /connectors/{connector}/t
OmniaGM commented on PR #13204:
URL: https://github.com/apache/kafka/pull/13204#issuecomment-1686311572
> Still with all the `LeaderElectionCommandTest` failures
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13204/15/testReport/
I will have a look into the `LeaderElection
kamalcph commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1300091311
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,
mimaison commented on PR #13204:
URL: https://github.com/apache/kafka/pull/13204#issuecomment-1686299835
Still with all the `LeaderElectionCommandTest` failures
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13204/15/testReport/
--
This is an automated message from the Apac
divijvaidya commented on code in PR #14266:
URL: https://github.com/apache/kafka/pull/14266#discussion_r1300083853
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -146,111 +146,111 @@ public final class RemoteLogManagerConfi
[
https://issues.apache.org/jira/browse/KAFKA-14912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756895#comment-17756895
]
hudeqi commented on KAFKA-14912:
But how to measure and get the size of the entry? [~div
kamalcph commented on PR #14238:
URL: https://github.com/apache/kafka/pull/14238#issuecomment-1686286807
> Do we need to implement dynamically configurable remote storage related
things in a `DynamicRemoteLogManagerConfig` class similar to
https://github.com/apache/kafka/pull/14243/files ?
divijvaidya commented on code in PR #14243:
URL: https://github.com/apache/kafka/pull/14243#discussion_r1300024562
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -370,6 +384,10 @@ public long remoteLogIndexFileCacheTotalSiz
[
https://issues.apache.org/jira/browse/KAFKA-14912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756886#comment-17756886
]
Divij Vaidya commented on KAFKA-14912:
--
Hey [~hudeqi]
We would ideally want to ime
[
https://issues.apache.org/jira/browse/KAFKA-15290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756884#comment-17756884
]
Divij Vaidya commented on KAFKA-15290:
--
When implementing this Jira, please ensure
divijvaidya commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1300067600
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -166,6 +166,10 @@ public Cache internalCache() {
return intern
divijvaidya commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1300055517
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -761,11 +784,385 @@ public void run() {
}
}
+public void handleL
divijvaidya commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1300055517
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -761,11 +784,385 @@ public void run() {
}
}
+public void handleL
kamalcph commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1300052574
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -166,6 +166,10 @@ public Cache internalCache() {
return internalC
[
https://issues.apache.org/jira/browse/KAFKA-15387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yash Mayya updated KAFKA-15387:
---
Summary: Deprecate and remove Connect's redundant task configurations
retrieval endpoint (was: Depr
1 - 100 of 144 matches
Mail list logo