[jira] [Assigned] (KAFKA-15351) Update log-start-offset after leader election for topics enabled with remote storage

2023-08-20 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana reassigned KAFKA-15351: -- Assignee: Kamal Chandraprakash > Update log-start-offset after leader election for to

[jira] [Updated] (KAFKA-15351) Update log-start-offset after leader election for topics enabled with remote storage

2023-08-20 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15351: --- Description: Case-1: In the FETCH response, the leader-log-start-offset will be piggy-backe

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-20 Thread via GitHub
satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1299640804 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -696,11 +704,327 @@ public void run() { } } +public void handleLogSt

[jira] [Resolved] (KAFKA-15386) Update log-start-offset in RLM task for a leader partition for the earliest leader epoch of the current leader's leader epoch lineage available in the remote storage.

2023-08-20 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana resolved KAFKA-15386. Resolution: Duplicate > Update log-start-offset in RLM task for a leader partition for the

[jira] [Created] (KAFKA-15386) Update log-start-offset in RLM task for a leader partition for the earliest leader epoch of the current leader's leader epoch lineage available in the remote storage.

2023-08-20 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-15386: -- Summary: Update log-start-offset in RLM task for a leader partition for the earliest leader epoch of the current leader's leader epoch lineage available in the remote storage. Key: KAFKA-153

[GitHub] [kafka] Taher-Ghaleb opened a new pull request, #14264: Refactor @Test(expected) annotation with assertThrows

2023-08-20 Thread via GitHub
Taher-Ghaleb opened a new pull request, #14264: URL: https://github.com/apache/kafka/pull/14264 I am working on research that investigates test smell refactoring in which we identify alternative implementations of test cases, study how commonly used these refactorings are, and assess how ac

[GitHub] [kafka] github-actions[bot] commented on pull request #13475: KAFKA-14652: Add the flow to the log context and the Connect-managed …

2023-08-20 Thread via GitHub
github-actions[bot] commented on PR #13475: URL: https://github.com/apache/kafka/pull/13475#issuecomment-1685578540 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[GitHub] [kafka] Vaibhav-Nazare commented on pull request #13817: KAFKA-15062: Adding ppc64le build stage

2023-08-20 Thread via GitHub
Vaibhav-Nazare commented on PR #13817: URL: https://github.com/apache/kafka/pull/13817#issuecomment-1685572794 Hi @mimaison @cmccabe If you agree can we have your votes too on the KIP please, @divijvaidya has already voted. -- This is an automated message from the Apache Git Service. To r

[jira] [Commented] (KAFKA-15354) Partition leader is not evenly distributed in kraft mode

2023-08-20 Thread Deng Ziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756637#comment-17756637 ] Deng Ziming commented on KAFKA-15354: - [~sagarrao] Yes, we are using a different way

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299492523 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java: ## @@ -0,0 +1,414 @@ +/* + * Licensed to the Apache Software Foundat

[jira] [Commented] (KAFKA-14813) Timeout Exception causes data loss

2023-08-20 Thread Haoze Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756620#comment-17756620 ] Haoze Wu commented on KAFKA-14813: -- Hello, may I have the full broker log? > Timeout E

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299460688 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java: ## @@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299460688 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java: ## @@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {

[GitHub] [kafka] showuon commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
showuon commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299460688 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java: ## @@ -104,6 +106,22 @@ public class RemoteLogMetadataCache {

[GitHub] [kafka] showuon commented on pull request #14236: KAFKA-15353: make sure AlterPartitionRequestBuilder.build() is idempotent

2023-08-20 Thread via GitHub
showuon commented on PR #14236: URL: https://github.com/apache/kafka/pull/14236#issuecomment-1685425389 Re-triggering CI: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14236/2/ @junrao @dajac , do you want to have another review? -- This is an automated message from t

[GitHub] [kafka] jolshan merged pull request #14246: MINOR: Minor storage cleanups

2023-08-20 Thread via GitHub
jolshan merged PR #14246: URL: https://github.com/apache/kafka/pull/14246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] philipnee commented on pull request #14118: KAFKA-14875: Implement wakeup

2023-08-20 Thread via GitHub
philipnee commented on PR #14118: URL: https://github.com/apache/kafka/pull/14118#issuecomment-1685406078 @junrao - This should be ready for review. There's one failing build but it succeed in a separated build, so I believe it is flaky. Here are the list of flaky tests ``` Build

[jira] [Commented] (KAFKA-15331) Handle remote log enabled topic deletion when leader is not available

2023-08-20 Thread Fei Xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756590#comment-17756590 ] Fei Xie commented on KAFKA-15331: - Hi [~junrao], [~ckamal], I am relatively new to Kafka

[jira] [Comment Edited] (KAFKA-14133) Remaining EasyMock to Mockito tests

2023-08-20 Thread Fei Xie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756373#comment-17756373 ] Fei Xie edited comment on KAFKA-14133 at 8/20/23 8:15 PM: -- Sent

[GitHub] [kafka] olalamichelle opened a new pull request, #14263: [KAFKA-14133] Migrate EasyMock to Mockito in RocksDBMetricsRecordingTriggerTest, Wi…

2023-08-20 Thread via GitHub
olalamichelle opened a new pull request, #14263: URL: https://github.com/apache/kafka/pull/14263 …ndowStoreBuilderTest *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping rev

[GitHub] [kafka] olalamichelle opened a new pull request, #14262: [KAFKA-14133] Migrate EasyMock to Mockito in RocksDBGenericOptionsToDbOptionsColumF…

2023-08-20 Thread via GitHub
olalamichelle opened a new pull request, #14262: URL: https://github.com/apache/kafka/pull/14262 …amilyOptionsAdaptarTest, RocksDBRangeIteratorTest *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a se

[GitHub] [kafka] olalamichelle opened a new pull request, #14261: [KAFKA-14133] Migrate EasyMock to Mockito in ReadOnlyKeyValueStoreFacadeTest, ReadO…

2023-08-20 Thread via GitHub
olalamichelle opened a new pull request, #14261: URL: https://github.com/apache/kafka/pull/14261 …nlyWindowStoreFacadeTest *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping

[GitHub] [kafka] olalamichelle opened a new pull request, #14260: [KAFKA-14133] Migrate EasyMock to Mockito in MeteredWindowStoreTest

2023-08-20 Thread via GitHub
olalamichelle opened a new pull request, #14260: URL: https://github.com/apache/kafka/pull/14260 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of t

[GitHub] [kafka] muralibasani commented on pull request #14106: KAFKA-14585: 1st part : Java versions for metadata/broker and updated LogConfig

2023-08-20 Thread via GitHub
muralibasani commented on PR #14106: URL: https://github.com/apache/kafka/pull/14106#issuecomment-1685374411 @fvaleri @mimaison I tried to delete scala versions of (BrokerMetadataCheckpoint, MetaProperties, RawMetaProperties) and update all the dependencies with Java versions, but it has u

[GitHub] [kafka] abhijeetk88 commented on pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
abhijeetk88 commented on PR #14127: URL: https://github.com/apache/kafka/pull/14127#issuecomment-1685273503 Thanks @jeqo for the comments. I have addressed the comments. Please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299369176 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +64,395 @@ class ConsumerTask implements Runnable, Cl

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299369135 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +64,395 @@ class ConsumerTask implements Runnable, Cl

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299369043 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +64,395 @@ class ConsumerTask implements Runnable, Cl

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299368850 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +64,395 @@ class ConsumerTask implements Runnable, Cl

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299368766 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +64,395 @@ class ConsumerTask implements Runnable, Cl

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299368836 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +64,395 @@ class ConsumerTask implements Runnable, Cl

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299368720 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +65,393 @@ class ConsumerTask implements Runnable, Cl

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299368283 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +65,387 @@ class ConsumerTask implements Runnable, Cl

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299368244 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +65,387 @@ class ConsumerTask implements Runnable, Cl

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

2023-08-20 Thread via GitHub
abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1299367611 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +64,395 @@ class ConsumerTask implements Runnable, Cl

[GitHub] [kafka] satishd commented on pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-20 Thread via GitHub
satishd commented on PR #13561: URL: https://github.com/apache/kafka/pull/13561#issuecomment-1685264422 >The latest build still has 120 test failures. @junrao Those tests are not related to the changes in the PR. The next [run](https://ci-builds.apache.org/blue/organizations/jenkins/K

[GitHub] [kafka] satishd merged pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

2023-08-20 Thread via GitHub
satishd merged PR #14116: URL: https://github.com/apache/kafka/pull/14116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] satishd commented on pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

2023-08-20 Thread via GitHub
satishd commented on PR #14116: URL: https://github.com/apache/kafka/pull/14116#issuecomment-1685263094 There are a few failed tests that are unrelated to the changes in the PR. This PR is blocking to add of several integration tests, merging the changes to trunk. It received

[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-08-20 Thread via GitHub
ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1299353603 ## clients/src/test/resources/log4j.properties: ## @@ -19,3 +19,5 @@ log4j.appender.stdout.layout=org.apache.log4j.PatternLayout log4j.appender.stdout.layout.Conversio

[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-08-20 Thread via GitHub
ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1299353258 ## clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java: ## @@ -255,7 +271,7 @@ private SSLContext createSSLContext(SecurityStore key

[GitHub] [kafka] Owen-CH-Leung commented on pull request #14136: Add metadatacache into RemoteLogManager, and refactor all relevant codes

2023-08-20 Thread via GitHub
Owen-CH-Leung commented on PR #14136: URL: https://github.com/apache/kafka/pull/14136#issuecomment-1685205287 @clolov @kamalcph I've merged base and refactored the test suite a bit. There're a few failed test but I believe those are unrelated to the changes I made. Could you please take a l