yashmayya opened a new pull request, #14024:
URL: https://github.com/apache/kafka/pull/14024
-
https://cwiki.apache.org/confluence/display/KAFKA/KIP-793%3A+Allow+sink+connectors+to+be+used+with+topic-mutating+SMTs
- https://issues.apache.org/jira/browse/KAFKA-13431
### Committer Ch
abhijeetk88 commented on code in PR #14004:
URL: https://github.com/apache/kafka/pull/14004#discussion_r1264877738
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java:
##
@@ -100,17 +100,22 @@ void
handleSegmentWithCopySeg
satishd commented on code in PR #14004:
URL: https://github.com/apache/kafka/pull/14004#discussion_r1264876554
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogLeaderEpochState.java:
##
@@ -100,17 +100,22 @@ void
handleSegmentWithCopySegment
tinaselenge commented on PR #13658:
URL: https://github.com/apache/kafka/pull/13658#issuecomment-1637381506
@C0urante thank you so much for reviewing the PR, good suggestions! I made
the changes as you suggested.
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/KAFKA-15186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743616#comment-17743616
]
Prem Kamal commented on KAFKA-15186:
Sure will go through the process and if possibl
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1637362685
> @flashmouse thansk for the PR - I was the one who wrote the if-else if
-else block. I'm a bit surprised that I actually made this mistake, so I held
it off for a few days just to mak
[
https://issues.apache.org/jira/browse/KAFKA-15181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743611#comment-17743611
]
Abhijeet Kumar commented on KAFKA-15181:
Hi [~jeqo] . I am curious to understand
github-actions[bot] commented on PR #13256:
URL: https://github.com/apache/kafka/pull/13256#issuecomment-1637329952
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
hudeqi commented on PR #13913:
URL: https://github.com/apache/kafka/pull/13913#issuecomment-1637307673
> @hudeqi Sorry, I think there's a misunderstanding here. I'm not claiming
that MM2 would be incapable of detecting changes in source cluster ACLs with
this change; I'm worried that it wou
showuon commented on code in PR #14012:
URL: https://github.com/apache/kafka/pull/14012#discussion_r1264796134
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerManager.java:
##
@@ -76,47 +94,50 @@ public void startConsumerThread() {
}
showuon commented on code in PR #14012:
URL: https://github.com/apache/kafka/pull/14012#discussion_r1264796134
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerManager.java:
##
@@ -76,47 +94,50 @@ public void startConsumerThread() {
}
flashmouse commented on code in PR #13920:
URL: https://github.com/apache/kafka/pull/13920#discussion_r1264792983
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##
@@ -158,7 +158,7 @@ private boolean allSubscriptionsEqual(Set al
showuon commented on PR #13944:
URL: https://github.com/apache/kafka/pull/13944#issuecomment-1637281309
@abhijeetk88 , there are errors from spotbugs. Could you take a look.
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-13944/7/pipeline
--
This is a
mumrah merged PR #14009:
URL: https://github.com/apache/kafka/pull/14009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
mumrah commented on PR #14009:
URL: https://github.com/apache/kafka/pull/14009#issuecomment-1637260572
Failed tests from the build look unrelated
https://github.com/apache/kafka/assets/55116/b49741a5-8d59-40b1-b150-0348ec20828e";>
--
This is an automated message from the Apache
bmscomp commented on PR #13662:
URL: https://github.com/apache/kafka/pull/13662#issuecomment-1637198127
@divijvaidya Yes I agree with you this is not a minor change, we need to
create a JIRA ticket for that
--
This is an automated message from the Apache Git Service.
To respond
bmscomp commented on PR #13662:
URL: https://github.com/apache/kafka/pull/13662#issuecomment-1637174843
@divijvaidya The third point you mentioned
Modified handling of datetime with zone information in it. See:
https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.15#changes-behav
bmscomp closed pull request #14022: MINOR: Fix typo in java documentation
URL: https://github.com/apache/kafka/pull/14022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
abhijeetk88 commented on PR #13944:
URL: https://github.com/apache/kafka/pull/13944#issuecomment-1637148456
Addressed all the comments. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
abhijeetk88 commented on code in PR #13944:
URL: https://github.com/apache/kafka/pull/13944#discussion_r1264719933
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -589,6 +687,47 @@ void testIdempotentClose() throws IOException {
inorder.verify(re
abhijeetk88 commented on code in PR #13944:
URL: https://github.com/apache/kafka/pull/13944#discussion_r1264719852
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteStorageThreadPool.java:
##
@@ -70,4 +91,9 @@ public Thread newThread(Runnable r) {
}
cmccabe closed pull request #10463: KAFKA-12670: support
unclean.leader.election.enable in KRaft mode
URL: https://github.com/apache/kafka/pull/10463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cmccabe commented on PR #10463:
URL: https://github.com/apache/kafka/pull/10463#issuecomment-1637144727
This is very stale at this point. Among other things, we ended up going with
`PartitionChangeBuilder` rather than `ElectionStrategizer`. Closing.
--
This is an automated message from th
cmccabe closed pull request #13003: MINOR: only allow certain operations when
in KRaft premigration
URL: https://github.com/apache/kafka/pull/13003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
cmccabe commented on PR #13003:
URL: https://github.com/apache/kafka/pull/13003#issuecomment-1637144128
This has been superseded by #13407. Closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
cmccabe commented on code in PR #13643:
URL: https://github.com/apache/kafka/pull/13643#discussion_r1264717661
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -740,22 +739,27 @@ public Long apply(List records) {
//
cmccabe commented on PR #13703:
URL: https://github.com/apache/kafka/pull/13703#issuecomment-1637136736
As I recall, we did check the Jenkins result, it's just that it was an old
and stale build result. I should have re-run the build. Sorry.
--
This is an automated message from the Apache
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1637117372
Hi @divijvaidya Any further updates on nightly job enablement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Owen-CH-Leung commented on PR #13909:
URL: https://github.com/apache/kafka/pull/13909#issuecomment-1637114315
> Sorry for late reply.
>
> > Could you explain how I should change the way we generate docs so as to
fix this ticket ?
>
> I am not really sure TBH; would need to play
[
https://issues.apache.org/jira/browse/KAFKA-15186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-15186:
---
Labels: need-kip (was: )
> AppInfo metrics don't contain the client-id
> --
[
https://issues.apache.org/jira/browse/KAFKA-15186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743537#comment-17743537
]
Mickael Maison commented on KAFKA-15186:
The logic should not be hard to impleme
bmscomp commented on PR #13662:
URL: https://github.com/apache/kafka/pull/13662#issuecomment-1637051977
@divijvaidya License file updated to mention the correct jackson version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-15186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17743500#comment-17743500
]
Prem Kamal commented on KAFKA-15186:
Hey [~mimaison], this task looks good for a new
33 matches
Mail list logo
