[jira] [Updated] (KAFKA-15074) offset out of range for partition xxx, resetting offset

2023-06-07 Thread YaYun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YaYun Wang updated KAFKA-15074: --- Description: I  got ?? "Fetch position FetchPosition{offset=42574305, offsetEpoch=Optional[2214],

[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

2023-06-07 Thread via GitHub
dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1222426539 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -980,6 +1006,25 @@ class UnifiedLog(@volatile var logStartOffset: Long, if (duplicateBatch.isPresent)

[jira] [Updated] (KAFKA-15074) offset out of range for partition xxx, resetting offset

2023-06-07 Thread YaYun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YaYun Wang updated KAFKA-15074: --- Description: I  got ?? "Fetch position FetchPosition{offset=42574305, offsetEpoch=Optional[2214],

[jira] [Comment Edited] (KAFKA-15074) offset out of range for partition xxx, resetting offset

2023-06-07 Thread YaYun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730365#comment-17730365 ] YaYun Wang edited comment on KAFKA-15074 at 6/8/23 3:30 AM:

[jira] [Updated] (KAFKA-15074) offset out of range for partition xxx, resetting offset

2023-06-07 Thread YaYun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YaYun Wang updated KAFKA-15074: --- Description: I ??got Fetch position FetchPosition{offset=42574305, offsetEpoch=Optional[2214], cur

[jira] [Commented] (KAFKA-15074) offset out of range for partition xxx, resetting offset

2023-06-07 Thread YaYun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730365#comment-17730365 ] YaYun Wang commented on KAFKA-15074: And here is my debug logs of kafka-client: 202

[jira] [Commented] (KAFKA-15074) offset out of range for partition xxx, resetting offset

2023-06-07 Thread YaYun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730360#comment-17730360 ] YaYun Wang commented on KAFKA-15074: *Here is my code:* @KafkaListener( topics = "m

[jira] [Updated] (KAFKA-15074) offset out of range for partition xxx, resetting offset

2023-06-07 Thread YaYun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YaYun Wang updated KAFKA-15074: --- Description: I ??got Fetch position FetchPosition{offset=42574305, offsetEpoch=Optional[2214], cur

[jira] [Updated] (KAFKA-15074) offset out of range for partition xxx, resetting offset

2023-06-07 Thread YaYun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YaYun Wang updated KAFKA-15074: --- Description: I ??got Fetch position FetchPosition{offset=42574305, offsetEpoch=Optional[2214], cur

[jira] [Created] (KAFKA-15074) offset out of range for partition xxx, resetting offset

2023-06-07 Thread YaYun Wang (Jira)
YaYun Wang created KAFKA-15074: -- Summary: offset out of range for partition xxx, resetting offset Key: KAFKA-15074 URL: https://issues.apache.org/jira/browse/KAFKA-15074 Project: Kafka Issue Typ

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #13756: KAFKA-14936: Add On Disk Time Ordered Buffer (1/N)

2023-06-07 Thread via GitHub
wcarlson5 commented on code in PR #13756: URL: https://github.com/apache/kafka/pull/13756#discussion_r1222332377 ## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBufferTest.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] mumrah opened a new pull request, #13827: KAFKA-15073: Add a Github action to mark PRs as stale

2023-06-07 Thread via GitHub
mumrah opened a new pull request, #13827: URL: https://github.com/apache/kafka/pull/13827 This patch uses a Github workflow to mark inactive PRs with the `stale` label. The workflow uses the ["stale" action](https://github.com/actions/stale) which has many features including a number of fil

[jira] [Created] (KAFKA-15073) Automation for old/inactive PRs

2023-06-07 Thread David Arthur (Jira)
David Arthur created KAFKA-15073: Summary: Automation for old/inactive PRs Key: KAFKA-15073 URL: https://issues.apache.org/jira/browse/KAFKA-15073 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] jolshan commented on a diff in pull request #13812: KAFKA-14462; [18/N] Add GroupCoordinatorService

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13812: URL: https://github.com/apache/kafka/pull/13812#discussion_r1222312423 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/ReplicatedGroupCoordinator.java: ## @@ -0,0 +1,202 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] jolshan commented on pull request #13796: KAFKA-14034 Idempotent producer should wait for preceding in-flight b…

2023-06-07 Thread via GitHub
jolshan commented on PR #13796: URL: https://github.com/apache/kafka/pull/13796#issuecomment-1581669973 > No, we can't - it all depends on the retries and the delivery timeout. Do you think that causes a problem? I guess I just need to clarify what retried batches are here -- is the

[GitHub] [kafka] kirktrue commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-06-07 Thread via GitHub
kirktrue commented on PR #13591: URL: https://github.com/apache/kafka/pull/13591#issuecomment-1581658284 > I'm not sure I follow. Are you saying that the test would set the thread local before running? So a single thread may set itself back and forth within the suite? (If you have a commit

[GitHub] [kafka] kirktrue commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-06-07 Thread via GitHub
kirktrue commented on PR #13591: URL: https://github.com/apache/kafka/pull/13591#issuecomment-1581633134 > Are you saying that the test would set the thread local before running? So a single thread may set itself back and forth within the suite? Precisely. That's in effect what it doe

[GitHub] [kafka] pjpringle commented on pull request #12540: bug: State stores lose state when tasks are reassigned under EOS wit…

2023-06-07 Thread via GitHub
pjpringle commented on PR #12540: URL: https://github.com/apache/kafka/pull/12540#issuecomment-1581567216 Is this bug eos specific given the title? Looking at the fix I dont believe it is. I have been seeing similar stale state issues on rebalance in a non eos setup but with stand by replic

[GitHub] [kafka] jolshan commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-06-07 Thread via GitHub
jolshan commented on PR #13591: URL: https://github.com/apache/kafka/pull/13591#issuecomment-1581564571 > No, the test method would need to specifically mark its thread as wanting to poison the thread or not before running the rest of the test. In the TransactionManagerTest, there was only

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13756: KAFKA-14936: Add On Disk Time Ordered Buffer (1/N)

2023-06-07 Thread via GitHub
vcrfxia commented on code in PR #13756: URL: https://github.com/apache/kafka/pull/13756#discussion_r107444 ## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBufferTest.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Softwar

[jira] [Updated] (KAFKA-15060) Fix the ApiVersionManager interface

2023-06-07 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-15060: - Description: (was: Fix Admin.describeFeatures, which was accidentally broken by KAFKA-15007.

[GitHub] [kafka] cmccabe opened a new pull request, #13826: KAFKA-15060: fix the ApiVersionManager interface

2023-06-07 Thread via GitHub
cmccabe opened a new pull request, #13826: URL: https://github.com/apache/kafka/pull/13826 This PR expands the scope of ApiVersionManager a bit to include returning the current MetadataVersion and features that are in effect. This is useful in general because that information needs to be re

[jira] [Updated] (KAFKA-15060) Fix the ApiVersionManager interface

2023-06-07 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-15060: - Summary: Fix the ApiVersionManager interface (was: Fix Admin.describeFeatures) > Fix the ApiVe

[GitHub] [kafka] jolshan commented on a diff in pull request #13795: KAFKA-14462; [17/N] Add CoordinatorRuntime

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13795: URL: https://github.com/apache/kafka/pull/13795#discussion_r102869 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -0,0 +1,803 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13795: KAFKA-14462; [17/N] Add CoordinatorRuntime

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13795: URL: https://github.com/apache/kafka/pull/13795#discussion_r1222198170 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -0,0 +1,803 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13795: KAFKA-14462; [17/N] Add CoordinatorRuntime

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13795: URL: https://github.com/apache/kafka/pull/13795#discussion_r1222177376 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -0,0 +1,803 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13795: KAFKA-14462; [17/N] Add CoordinatorRuntime

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13795: URL: https://github.com/apache/kafka/pull/13795#discussion_r1222175645 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -0,0 +1,803 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13795: KAFKA-14462; [17/N] Add CoordinatorRuntime

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13795: URL: https://github.com/apache/kafka/pull/13795#discussion_r1222169738 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -0,0 +1,803 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13795: KAFKA-14462; [17/N] Add CoordinatorRuntime

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13795: URL: https://github.com/apache/kafka/pull/13795#discussion_r1222158858 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -0,0 +1,803 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13795: KAFKA-14462; [17/N] Add CoordinatorRuntime

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13795: URL: https://github.com/apache/kafka/pull/13795#discussion_r1222148781 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -0,0 +1,803 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] junrao commented on a diff in pull request #13815: KAFKA-14966: Extract OffsetFetcher reusable logic

2023-06-07 Thread via GitHub
junrao commented on code in PR #13815: URL: https://github.com/apache/kafka/pull/13815#discussion_r1222142092 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetFetcherUtils.java: ## @@ -0,0 +1,295 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [kafka] jolshan commented on a diff in pull request #13795: KAFKA-14462; [17/N] Add CoordinatorRuntime

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13795: URL: https://github.com/apache/kafka/pull/13795#discussion_r1222140560 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -0,0 +1,803 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jlprat commented on pull request #13824: MINOR: Use Parametrized types correctly in RemoteLogMetadataSerde

2023-06-07 Thread via GitHub
jlprat commented on PR #13824: URL: https://github.com/apache/kafka/pull/13824#issuecomment-1581463300 Tests failures seem all unrelated and I created the corresponding Jira tickets for the ones I couldn't fine an already existing one: https://issues.apache.org/jira/browse/KAFKA-15070, h

[jira] [Created] (KAFKA-15072) Flaky test MirrorConnectorsIntegrationExactlyOnceTest.testReplicationWithEmptyPartition

2023-06-07 Thread Josep Prat (Jira)
Josep Prat created KAFKA-15072: -- Summary: Flaky test MirrorConnectorsIntegrationExactlyOnceTest.testReplicationWithEmptyPartition Key: KAFKA-15072 URL: https://issues.apache.org/jira/browse/KAFKA-15072 P

[GitHub] [kafka] jolshan commented on a diff in pull request #13795: KAFKA-14462; [17/N] Add CoordinatorRuntime

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13795: URL: https://github.com/apache/kafka/pull/13795#discussion_r1222117410 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -0,0 +1,803 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-15071) Flaky test kafka.admin.LeaderElectionCommandTest.testPreferredReplicaElection for Type=ZK, MetadataVersion=3.5-IV2, Security=PLAINTEXT

2023-06-07 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat updated KAFKA-15071: --- Component/s: core > Flaky test kafka.admin.LeaderElectionCommandTest.testPreferredReplicaElection >

[GitHub] [kafka] jolshan commented on a diff in pull request #13795: KAFKA-14462; [17/N] Add CoordinatorRuntime

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13795: URL: https://github.com/apache/kafka/pull/13795#discussion_r1222115234 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java: ## @@ -39,7 +40,7 @@ public class MultiThreadedEventProc

[jira] [Updated] (KAFKA-15071) Flaky test kafka.admin.LeaderElectionCommandTest.testPreferredReplicaElection for Type=ZK, MetadataVersion=3.5-IV2, Security=PLAINTEXT

2023-06-07 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josep Prat updated KAFKA-15071: --- Affects Version/s: 3.5.0 > Flaky test kafka.admin.LeaderElectionCommandTest.testPreferredReplicaElec

[jira] [Commented] (KAFKA-14971) Flaky Test org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest#testSyncTopicConfigs

2023-06-07 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730272#comment-17730272 ] Josep Prat commented on KAFKA-14971: Another occurrence: https://ci-builds.apache.o

[GitHub] [kafka] junrao commented on a diff in pull request #13797: KAFKA-14950: implement assign() and assignment()

2023-06-07 Thread via GitHub
junrao commented on code in PR #13797: URL: https://github.com/apache/kafka/pull/13797#discussion_r1221908399 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java: ## @@ -106,4 +114,17 @@ private boolean process(final OffsetF

[GitHub] [kafka] kirktrue commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-06-07 Thread via GitHub
kirktrue commented on PR #13591: URL: https://github.com/apache/kafka/pull/13591#issuecomment-1581446668 > ThreadLocal variables are not as frequently used in Kafka, but I can see a potential argument for usage here. One tricky part about thread locals is testing. Any ideas on how we could

[jira] [Commented] (KAFKA-15020) integration.kafka.server.FetchFromFollowerIntegrationTest.testRackAwareRangeAssignor test is flaky

2023-06-07 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730271#comment-17730271 ] Josep Prat commented on KAFKA-15020: Seen this test failing with a different error:

[GitHub] [kafka] jolshan commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-06-07 Thread via GitHub
jolshan commented on PR #13591: URL: https://github.com/apache/kafka/pull/13591#issuecomment-1581443881 ThreadLocal variables are not as frequently used in Kafka, but I can see a potential argument for usage here. One tricky part about thread locals is testing. Any ideas on how we could do

[jira] [Resolved] (KAFKA-14539) Simplify StreamsMetadataState by replacing the Cluster metadata with partition info map

2023-06-07 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck resolved KAFKA-14539. - Resolution: Fixed > Simplify StreamsMetadataState by replacing the Cluster metadata with > part

[jira] [Updated] (KAFKA-14539) Simplify StreamsMetadataState by replacing the Cluster metadata with partition info map

2023-06-07 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-14539: Fix Version/s: 3.6.0 > Simplify StreamsMetadataState by replacing the Cluster metadata with > par

[jira] [Created] (KAFKA-15071) Flaky test kafka.admin.LeaderElectionCommandTest.testPreferredReplicaElection for Type=ZK, MetadataVersion=3.5-IV2, Security=PLAINTEXT

2023-06-07 Thread Josep Prat (Jira)
Josep Prat created KAFKA-15071: -- Summary: Flaky test kafka.admin.LeaderElectionCommandTest.testPreferredReplicaElection for Type=ZK, MetadataVersion=3.5-IV2, Security=PLAINTEXT Key: KAFKA-15071 URL: https://issues.a

[jira] [Created] (KAFKA-15070) Flaky test kafka.log.LogCleanerParameterizedIntegrationTest.testCleansCombinedCompactAndDeleteTopic for codec zstd

2023-06-07 Thread Josep Prat (Jira)
Josep Prat created KAFKA-15070: -- Summary: Flaky test kafka.log.LogCleanerParameterizedIntegrationTest.testCleansCombinedCompactAndDeleteTopic for codec zstd Key: KAFKA-15070 URL: https://issues.apache.org/jira/brows

[jira] [Commented] (KAFKA-15052) Fix flaky test QuorumControllerTest.testBalancePartitionLeaders()

2023-06-07 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730264#comment-17730264 ] Josep Prat commented on KAFKA-15052: Adding another occurrence: https://ci-builds.a

[GitHub] [kafka] gharris1727 commented on pull request #13313: KAFKA-14760: Move ThroughputThrottler from tools to clients, remove tools dependency from connect-runtime

2023-06-07 Thread via GitHub
gharris1727 commented on PR #13313: URL: https://github.com/apache/kafka/pull/13313#issuecomment-1581417136 @ijuma Here are the results of my local test runs of test suites which use LATEST_0_8_2 and VerifiableProducer: * test_verifiable_producer.py: 25/25 PASS * compatibility_test

[jira] [Commented] (KAFKA-8073) Transient failure in kafka.api.UserQuotaTest.testThrottledProducerConsumer

2023-06-07 Thread Josep Prat (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730263#comment-17730263 ] Josep Prat commented on KAFKA-8073: --- I can see this still failing: https://ci-builds.a

[GitHub] [kafka] bbejeck commented on pull request #13751: KAFKA-14539: Simplify StreamsMetadataState by replacing the Cluster metadata with partition info map

2023-06-07 Thread via GitHub
bbejeck commented on PR #13751: URL: https://github.com/apache/kafka/pull/13751#issuecomment-1581399670 merged #13751 into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [kafka] bbejeck merged pull request #13751: KAFKA-14539: Simplify StreamsMetadataState by replacing the Cluster metadata with partition info map

2023-06-07 Thread via GitHub
bbejeck merged PR #13751: URL: https://github.com/apache/kafka/pull/13751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] kirktrue commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-06-07 Thread via GitHub
kirktrue commented on PR #13591: URL: https://github.com/apache/kafka/pull/13591#issuecomment-1581369789 @jolshan here's the basic idea: ```diff diff --git a/clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java b/clients/src/main/java/org/apache/kafka/clie

[GitHub] [kafka] kirktrue commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-06-07 Thread via GitHub
kirktrue commented on PR #13591: URL: https://github.com/apache/kafka/pull/13591#issuecomment-1581356873 @jolshan The more I look at the code, the more I dislike it. Having the extra `CallingThread` parameter to distinguish application threads from the `Sender` thread is just... ugly.

[GitHub] [kafka] jolshan commented on a diff in pull request #13795: KAFKA-14462; [17/N] Add CoordinatorRuntime

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13795: URL: https://github.com/apache/kafka/pull/13795#discussion_r1222035271 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorEvent.java: ## @@ -16,21 +16,23 @@ */ package org.apache.kafka.coordinator.g

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-06-07 Thread via GitHub
kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1222035054 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -977,18 +1058,20 @@ void handleCoordinatorReady() {

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-06-07 Thread via GitHub
kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1222034380 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -471,9 +547,9 @@ synchronized void requestEpochBumpForPartition(To

[GitHub] [kafka] jolshan commented on a diff in pull request #13795: KAFKA-14462; [17/N] Add CoordinatorRuntime

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13795: URL: https://github.com/apache/kafka/pull/13795#discussion_r1222033908 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [kafka] jolshan commented on a diff in pull request #13795: KAFKA-14462; [17/N] Add CoordinatorRuntime

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13795: URL: https://github.com/apache/kafka/pull/13795#discussion_r1222029897 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -0,0 +1,1040 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [kafka] mumrah commented on a diff in pull request #13823: MINOR: Move MockTime to server-common

2023-06-07 Thread via GitHub
mumrah commented on code in PR #13823: URL: https://github.com/apache/kafka/pull/13823#discussion_r1222020155 ## server-common/src/test/java/org/apache/kafka/server/util/MockTime.java: ## @@ -27,15 +23,21 @@ * 1. This has an associated scheduler instance for managing backgroun

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-06-07 Thread via GitHub
kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1222019325 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -609,14 +686,15 @@ public synchronized void handleCompletedBatch(P

[GitHub] [kafka] dajac commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

2023-06-07 Thread via GitHub
dajac commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1221998443 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -579,6 +579,28 @@ class UnifiedLog(@volatile var logStartOffset: Long, result } + /** + * Maybe crea

[GitHub] [kafka] mumrah closed pull request #13825: DO NOT MERGE: Testing a Github action

2023-06-07 Thread via GitHub
mumrah closed pull request #13825: DO NOT MERGE: Testing a Github action URL: https://github.com/apache/kafka/pull/13825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [kafka] jolshan commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1221986657 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -579,6 +579,28 @@ class UnifiedLog(@volatile var logStartOffset: Long, result } + /** + * Maybe cr

[GitHub] [kafka] jolshan commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1221910510 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -980,6 +1006,26 @@ class UnifiedLog(@volatile var logStartOffset: Long, if (duplicateBatch.isPresent

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #13751: KAFKA-14539: Simplify StreamsMetadataState by replacing the Cluster metadata with partition info map

2023-06-07 Thread via GitHub
wcarlson5 commented on code in PR #13751: URL: https://github.com/apache/kafka/pull/13751#discussion_r1221950345 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java: ## @@ -308,12 +308,17 @@ public synchronized KeyQueryMetadata getKe

[GitHub] [kafka] yashmayya commented on pull request #13530: KAFKA-14858: Handle exceptions thrown from Connector::taskConfigs in Connect's standalone mode

2023-06-07 Thread via GitHub
yashmayya commented on PR #13530: URL: https://github.com/apache/kafka/pull/13530#issuecomment-1581235501 > which is oddly not showing up on the GitHub PR UI, although it does show up on my fork's branch which this PR is created from https://www.githubstatus.com/incidents/1g1gkh0qpyvs

[GitHub] [kafka] yashmayya commented on a diff in pull request #13818: KAFKA-14784: Connect offset reset REST API

2023-06-07 Thread via GitHub
yashmayya commented on code in PR #13818: URL: https://github.com/apache/kafka/pull/13818#discussion_r1221937078 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1587,10 +1595,11 @@ private boolean alterConnectorOffsets

[GitHub] [kafka] jolshan commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1221909838 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -579,6 +579,28 @@ class UnifiedLog(@volatile var logStartOffset: Long, result } + /** + * Maybe cr

[GitHub] [kafka] mehbey commented on pull request #13709: KAFKA-14991:Added a validation to check if the record timestamp is in the future compared to the broker's timestamp

2023-06-07 Thread via GitHub
mehbey commented on PR #13709: URL: https://github.com/apache/kafka/pull/13709#issuecomment-1581221839 Hey @showuon , the [KIP](https://cwiki.apache.org/confluence/display/KAFKA/KIP-937%3A+Improve+Message+Timestamp+Validation#KIP937) for this pull request (PR) is published, and there have b

[GitHub] [kafka] C0urante commented on a diff in pull request #13818: KAFKA-14784: Connect offset reset REST API

2023-06-07 Thread via GitHub
C0urante commented on code in PR #13818: URL: https://github.com/apache/kafka/pull/13818#discussion_r1221916704 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1320,89 +1338,188 @@ void alterSinkConnectorOffsets(String connName, Connector c

[GitHub] [kafka] C0urante commented on a diff in pull request #13818: KAFKA-14784: Connect offset reset REST API

2023-06-07 Thread via GitHub
C0urante commented on code in PR #13818: URL: https://github.com/apache/kafka/pull/13818#discussion_r1221803692 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -374,19 +374,38 @@ public synchronized void connectorOffsets(

[GitHub] [kafka] jolshan commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1221911516 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2095,82 +2105,143 @@ class ReplicaManagerTest { } @Test - def testVerificationForTran

[GitHub] [kafka] jolshan commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1221910510 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -980,6 +1006,26 @@ class UnifiedLog(@volatile var logStartOffset: Long, if (duplicateBatch.isPresent

[GitHub] [kafka] jolshan commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

2023-06-07 Thread via GitHub
jolshan commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1221909838 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -579,6 +579,28 @@ class UnifiedLog(@volatile var logStartOffset: Long, result } + /** + * Maybe cr

[GitHub] [kafka] yashmayya commented on pull request #13530: KAFKA-14858: Handle exceptions thrown from Connector::taskConfigs in Connect's standalone mode

2023-06-07 Thread via GitHub
yashmayya commented on PR #13530: URL: https://github.com/apache/kafka/pull/13530#issuecomment-1581192139 > Modifying the status parts of the REST API seems less like introducing further divergence and more like honestly reporting that existing divergence to users. Fair enough, I've

[GitHub] [kafka] jolshan merged pull request #13811: KAFKA-14278: Fix InvalidProducerEpochException and InvalidTxnStateException handling in producer clients

2023-06-07 Thread via GitHub
jolshan merged PR #13811: URL: https://github.com/apache/kafka/pull/13811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] dajac commented on pull request #13823: MINOR: Move MockTime to server-common

2023-06-07 Thread via GitHub
dajac commented on PR #13823: URL: https://github.com/apache/kafka/pull/13823#issuecomment-1581188466 @mimaison @showuon @dengziming Would one of you have time to review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Commented] (KAFKA-15056) Kafka producer still fails with ClusterAuthorizationException after permission granted

2023-06-07 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730199#comment-17730199 ] Kirk True commented on KAFKA-15056: --- [~tophei] is this fixed by [KAFKA-13668|https://

[jira] [Commented] (KAFKA-14445) Producer doesn't request metadata update on REQUEST_TIMED_OUT

2023-06-07 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730195#comment-17730195 ] Kirk True commented on KAFKA-14445: --- [~ocadaruma] my apologies, I didn't read your ini

[jira] [Updated] (KAFKA-13531) Flaky test NamedTopologyIntegrationTest

2023-06-07 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-13531: - Attachment: org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveOneNam

[jira] [Commented] (KAFKA-13531) Flaky test NamedTopologyIntegrationTest

2023-06-07 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730190#comment-17730190 ] John Roesler commented on KAFKA-13531: -- Seen again while verifying the 3.5.0 releas

[jira] [Created] (KAFKA-15069) Refactor scanning hierarchy out of DelegatingClassLoader

2023-06-07 Thread Greg Harris (Jira)
Greg Harris created KAFKA-15069: --- Summary: Refactor scanning hierarchy out of DelegatingClassLoader Key: KAFKA-15069 URL: https://issues.apache.org/jira/browse/KAFKA-15069 Project: Kafka Issue

[GitHub] [kafka] clolov commented on pull request #13260: KAFKA-14661: Upgrade Zookeeper to 3.8.1

2023-06-07 Thread via GitHub
clolov commented on PR #13260: URL: https://github.com/apache/kafka/pull/13260#issuecomment-1581120917 I have not, but I will aim to carry out the check in the upcoming days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Assigned] (KAFKA-10337) Wait for pending async commits in commitSync() even if no offsets are specified

2023-06-07 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-10337: --- Assignee: Erik van Oosten (was: David Jacot) > Wait for pending async commits in commitSyn

[jira] [Commented] (KAFKA-15051) docs: add missing connector plugin endpoint to documentation

2023-06-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730156#comment-17730156 ] ASF GitHub Bot commented on KAFKA-15051: C0urante opened a new pull request, #52

[jira] [Assigned] (KAFKA-10337) Wait for pending async commits in commitSync() even if no offsets are specified

2023-06-07 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-10337: --- Assignee: David Jacot > Wait for pending async commits in commitSync() even if no offsets a

[GitHub] [kafka] vamossagar12 commented on pull request #13158: KAFKA-14647: Moving TopicFilter to server-common/utils

2023-06-07 Thread via GitHub
vamossagar12 commented on PR #13158: URL: https://github.com/apache/kafka/pull/13158#issuecomment-1581026296 I see. TBH I haven't followed that migration off-late. I think there are build failures as well which I haven't addressed yet. -- This is an automated message from the Apache Git S

[GitHub] [kafka] erikvanoosten commented on pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

2023-06-07 Thread via GitHub
erikvanoosten commented on PR #13678: URL: https://github.com/apache/kafka/pull/13678#issuecomment-1581020841 > @erikvanoosten It seems that you don't have an account for jira so I can't assign the ticket to you. You should request one. I do have an account. My Jira userid is erikvano

[GitHub] [kafka] C0urante commented on pull request #13803: KAFKA-15051: add missing GET plugin/config endpoint

2023-06-07 Thread via GitHub
C0urante commented on PR #13803: URL: https://github.com/apache/kafka/pull/13803#issuecomment-1581020451 @vvcephei haha, no worries! I'll leave Jenkins alone if I see you in the neighborhood testing again 🙏 -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] C0urante merged pull request #13803: KAFKA-15051: add missing GET plugin/config endpoint

2023-06-07 Thread via GitHub
C0urante merged PR #13803: URL: https://github.com/apache/kafka/pull/13803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] C0urante commented on pull request #13819: KAFKA-15059: Remove pending rebalance check when fencing zombie source connector tasks

2023-06-07 Thread via GitHub
C0urante commented on PR #13819: URL: https://github.com/apache/kafka/pull/13819#issuecomment-1581002727 Ah, I hadn't noticed that this was only introduced in https://github.com/apache/kafka/pull/13465. In that case, the good news is that this bug hasn't made it into a release yet! And the

[jira] [Resolved] (KAFKA-10337) Wait for pending async commits in commitSync() even if no offsets are specified

2023-06-07 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-10337. - Fix Version/s: 3.6.0 Resolution: Fixed > Wait for pending async commits in commitSync() e

[GitHub] [kafka] dajac commented on pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

2023-06-07 Thread via GitHub
dajac commented on PR #13678: URL: https://github.com/apache/kafka/pull/13678#issuecomment-1580998335 @erikvanoosten It seems that you don't have an account for jira so I can't assign the ticket to you. You should request one. -- This is an automated message from the Apache Git Service. T

[jira] [Assigned] (KAFKA-10337) Wait for pending async commits in commitSync() even if no offsets are specified

2023-06-07 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-10337: --- Assignee: (was: Kirk True) > Wait for pending async commits in commitSync() even if no

[GitHub] [kafka] dajac merged pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

2023-06-07 Thread via GitHub
dajac merged PR #13678: URL: https://github.com/apache/kafka/pull/13678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] vamossagar12 commented on pull request #12306: KAFKA-13976: Improvements for OpenAPI specs

2023-06-07 Thread via GitHub
vamossagar12 commented on PR #12306: URL: https://github.com/apache/kafka/pull/12306#issuecomment-1580988777 Converting to draft. Need some time before I get to this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] vamossagar12 closed pull request #12485: KAFKA-14131: Adding InterruptException when reading to end of Offseto…

2023-06-07 Thread via GitHub
vamossagar12 closed pull request #12485: KAFKA-14131: Adding InterruptException when reading to end of Offseto… URL: https://github.com/apache/kafka/pull/12485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Assigned] (KAFKA-14131) KafkaBasedLog#readToLogEnd() may accciedently falls into infinite loop

2023-06-07 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14131: - Assignee: Sambhav Jain (was: Sagar Rao) > KafkaBasedLog#readToLogEnd() may accciedently falls

[GitHub] [kafka] C0urante commented on pull request #13821: MINOR: Refactor plugin scanning logic into ReflectionScanner and ServiceLoaderScanner

2023-06-07 Thread via GitHub
C0urante commented on PR #13821: URL: https://github.com/apache/kafka/pull/13821#issuecomment-1580969721 @gharris1727 can we start filing Jira tickets for these changes to classloading logic? They're large enough that I don't think `MINOR` is warranted anymore, and it'd be nice to have a pi

  1   2   >