[jira] [Commented] (KAFKA-13771) Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up

[ https://issues.apache.org/jira/browse/KAFKA-13771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694387#comment-17694387 ] Luke Chen commented on KAFKA-13771: --- [~RivenSun] , you can update it by yourselves. Th

[jira] [Commented] (KAFKA-13771) Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up

[ https://issues.apache.org/jira/browse/KAFKA-13771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694380#comment-17694380 ] RivenSun commented on KAFKA-13771: -- Hi [~showuon] , PR is merged. could you help change

[jira] [Commented] (KAFKA-14757) Kafka Cooperative Sticky Assignor results in significant duplicate consumption

[ https://issues.apache.org/jira/browse/KAFKA-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694325#comment-17694325 ] Philip Nee commented on KAFKA-14757: if the progress is lost, then you need to start

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #13270: KAFKA-14729: The kafakConsumer pollForFetches(timer) method takes up a lot of cpu due to the abnormal exit of the heartbeat threa

RivenSun2 commented on code in PR #13270: URL: https://github.com/apache/kafka/pull/13270#discussion_r1119593189 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -355,6 +355,12 @@ protected synchronized long timeToNextHeartbeat

[GitHub] [kafka] ijuma opened a new pull request, #13316: MINOR: srcJar should depend on processMessages task

ijuma opened a new pull request, #13316: URL: https://github.com/apache/kafka/pull/13316 This fixes the following `./gradlew install` issue: ```text * What went wrong: A problem was found with the configuration of task ':storage:srcJar' (type 'Jar'). - Gradle detected a pro

[jira] [Commented] (KAFKA-14764) Metadata API ignores topic names if at least one topic ID is provided

[ https://issues.apache.org/jira/browse/KAFKA-14764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694311#comment-17694311 ] Deng Ziming commented on KAFKA-14764: - [~dajac] Yes, this rule was described here:

[GitHub] [kafka] showuon commented on a diff in pull request #13270: KAFKA-14729: The kafakConsumer pollForFetches(timer) method takes up a lot of cpu due to the abnormal exit of the heartbeat thread

showuon commented on code in PR #13270: URL: https://github.com/apache/kafka/pull/13270#discussion_r1119559892 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -355,6 +355,12 @@ protected synchronized long timeToNextHeartbeat(l

[jira] [Updated] (KAFKA-14768) proposal to reduce the first message's send time cost and max block time for safety

[ https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fujian updated KAFKA-14768: --- Labels: performance (was: ) > proposal to reduce the first message's send time cost and max block time for

[jira] [Updated] (KAFKA-14768) proposal to reduce the first message's send time cost and max block time for safety

[ https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fujian updated KAFKA-14768: --- Affects Version/s: 3.3.2 > proposal to reduce the first message's send time cost and max block time for > s

[jira] [Updated] (KAFKA-14768) proposal to reduce the first message's send time cost and max block time for safety

[ https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fujian updated KAFKA-14768: --- Priority: Major (was: Minor) > proposal to reduce the first message's send time cost and max block time for

[jira] [Updated] (KAFKA-14768) proposal to reduce the first message's send time cost and max block time for safety

[ https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fujian updated KAFKA-14768: --- Description: Hi, Team:   Nice to meet you!   In our business, we found two types of issue which need to

[jira] [Updated] (KAFKA-14768) proposal to reduce the first message's send time cost and max block time for safety

[ https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fujian updated KAFKA-14768: --- Description: Hi, Team:   Nice to meet you!   In our business, we found two types of issue which need to

[jira] [Updated] (KAFKA-14768) proposal to reduce the first message's send time cost and max block time for safety

[ https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fujian updated KAFKA-14768: --- Component/s: clients (was: core) > proposal to reduce the first message's send time cos

[jira] [Updated] (KAFKA-14768) proposal to reduce the first message's send time cost and max block time for safety

[ https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fujian updated KAFKA-14768: --- Priority: Minor (was: Blocker) > proposal to reduce the first message's send time cost and max block time f

[jira] [Updated] (KAFKA-14768) proposal to reduce the first message's send time cost and max block time for safety

[ https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fujian updated KAFKA-14768: --- Reviewer: (was: Satish Duggana) > proposal to reduce the first message's send time cost and max block time

[jira] [Created] (KAFKA-14768) proposal to reduce the first message's send time cost and max block time for safety

fujian created KAFKA-14768: -- Summary: proposal to reduce the first message's send time cost and max block time for safety Key: KAFKA-14768 URL: https://issues.apache.org/jira/browse/KAFKA-14768 Project: Kaf

[GitHub] [kafka] RivenSun2 commented on pull request #13270: KAFKA-14729: The kafakConsumer pollForFetches(timer) method takes up a lot of cpu due to the abnormal exit of the heartbeat thread

RivenSun2 commented on PR #13270: URL: https://github.com/apache/kafka/pull/13270#issuecomment-1447472363 Hi @showuon could you help review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] lqxshay commented on pull request #13097: Draft: close clean for EOS when it's RUNNING standby or RESTORING active

lqxshay commented on PR #13097: URL: https://github.com/apache/kafka/pull/13097#issuecomment-1447390999 @guozhangwang Apologies for the delayed response here. Thanks for the explanation. To put it in another way, as long as the task is in certain states(RESTORING active, RUNNING stan

[GitHub] [kafka] philipnee commented on pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on PR #13190: URL: https://github.com/apache/kafka/pull/13190#issuecomment-1447347885 Here are a couple things I updated: 1. Added some documentation to clarify the intent, but I didn't rewrite it as nested if "can be" harder to read. 2. Added non zero timeouts for

[jira] [Commented] (KAFKA-14748) Relax non-null FK left-join requirement

[ https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694229#comment-17694229 ] Matthias J. Sax commented on KAFKA-14748: - {quote}Hence, adding a `filter` opera

[GitHub] [kafka] philipnee commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1119428911 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -500,14 +500,22 @@ boolean joinGroupIfNeeded(final Timer timer) {

[jira] [Assigned] (KAFKA-14767) Gradle build fails with missing commitId after git gc

[ https://issues.apache.org/jira/browse/KAFKA-14767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-14767: --- Assignee: Greg Harris > Gradle build fails with missing commitId after git gc > ---

[GitHub] [kafka] gharris1727 opened a new pull request, #13315: KAFKA-14767: Fix missing commitId build error after git gc

gharris1727 opened a new pull request, #13315: URL: https://github.com/apache/kafka/pull/13315 `git gc` moves commit hashes from individual `.git/refs/heads/` to `.git/packed-refs` which is not read by the determineCommitId function. Replace the existing lookup within the `.git` direc

[GitHub] [kafka] philipnee commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1119426667 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -3398,7 +3400,8 @@ public void testPrepareJoinAndRejoinAfter

[GitHub] [kafka] philipnee commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1119422842 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -1484,6 +1484,8 @@ public void testRebalanceWithMetadataChang

[jira] [Commented] (KAFKA-14747) FK join should record discarded subscription responses

[ https://issues.apache.org/jira/browse/KAFKA-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694213#comment-17694213 ] Guozhang Wang commented on KAFKA-14747: --- Echoing that, I think we can piggy-back o

[GitHub] [kafka] philipnee commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1119398074 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -1484,6 +1484,8 @@ public void testRebalanceWithMetadataChang

[GitHub] [kafka] philipnee commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1119399381 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -500,14 +500,22 @@ boolean joinGroupIfNeeded(final Timer timer) {

[GitHub] [kafka] philipnee commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1119399381 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -500,14 +500,22 @@ boolean joinGroupIfNeeded(final Timer timer) {

[GitHub] [kafka] philipnee commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1119398074 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -1484,6 +1484,8 @@ public void testRebalanceWithMetadataChang

[GitHub] [kafka] philipnee commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1119397792 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -500,14 +500,22 @@ boolean joinGroupIfNeeded(final Timer timer) {

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13184: KAFKA-14671: Refactor PredicatedTransformation to not implement Transformation

gharris1727 commented on code in PR #13184: URL: https://github.com/apache/kafka/pull/13184#discussion_r1119392537 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ConnectorConfigTest.java: ## @@ -280,25 +283,18 @@ public void abstractPredicate() { asse

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13184: KAFKA-14671: Refactor PredicatedTransformation to not implement Transformation

gharris1727 commented on code in PR #13184: URL: https://github.com/apache/kafka/pull/13184#discussion_r1119389854 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java: ## @@ -268,30 +268,30 @@ public boolean includeRecordDetailsInErrorLog() {

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13184: KAFKA-14671: Refactor PredicatedTransformation to not implement Transformation

gharris1727 commented on code in PR #13184: URL: https://github.com/apache/kafka/pull/13184#discussion_r1119388653 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java: ## @@ -531,8 +543,17 @@ private Converter badConverter() { re

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

guozhangwang commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1119357976 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -500,14 +500,22 @@ boolean joinGroupIfNeeded(final Timer timer

[jira] [Commented] (KAFKA-14767) Gradle build fails with missing commitId after git gc

[ https://issues.apache.org/jira/browse/KAFKA-14767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694207#comment-17694207 ] Greg Harris commented on KAFKA-14767: - This happens occasionally when git performs a

[jira] [Created] (KAFKA-14767) Gradle build fails with missing commitId after git gc

Greg Harris created KAFKA-14767: --- Summary: Gradle build fails with missing commitId after git gc Key: KAFKA-14767 URL: https://issues.apache.org/jira/browse/KAFKA-14767 Project: Kafka Issue Typ

[GitHub] [kafka] rittikaadhikari closed pull request #13314: [DO NOT MERGE] Sync apache/trunk to confluentinc/kafka master 27-Feb-2023

rittikaadhikari closed pull request #13314: [DO NOT MERGE] Sync apache/trunk to confluentinc/kafka master 27-Feb-2023 URL: https://github.com/apache/kafka/pull/13314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] rittikaadhikari opened a new pull request, #13314: [DO NOT MERGE] Sync apache/trunk to confluentinc/kafka master 27-Feb-2023

rittikaadhikari opened a new pull request, #13314: URL: https://github.com/apache/kafka/pull/13314 Conflicts in Jenkinsfile and build.gradle -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Commented] (KAFKA-14757) Kafka Cooperative Sticky Assignor results in significant duplicate consumption

[ https://issues.apache.org/jira/browse/KAFKA-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694182#comment-17694182 ] Siddharth Anand commented on KAFKA-14757: - We follow the pattern below in each c

[GitHub] [kafka] C0urante commented on a diff in pull request #13184: KAFKA-14671: Refactor PredicatedTransformation to not implement Transformation

C0urante commented on code in PR #13184: URL: https://github.com/apache/kafka/pull/13184#discussion_r1119281474 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/TransformationStage.java: ## @@ -16,63 +16,58 @@ */ package org.apache.kafka.connect.runtime; -i

[GitHub] [kafka] gharris1727 commented on pull request #13291: KAFKA-14742: Throttle connectors in ExactlyOnceSourceIntegrationTest to fix flakey OOMEs

gharris1727 commented on PR #13291: URL: https://github.com/apache/kafka/pull/13291#issuecomment-1447059390 @edoardocomar I pulled these values out into three separate constants with descriptive names, let me know if this is closer to what you had in mind! -- This is an automated

[GitHub] [kafka] hgeraldino commented on a diff in pull request #13193: KAFKA-14659 source-record-write-[rate|total] metrics include filtered records

hgeraldino commented on code in PR #13193: URL: https://github.com/apache/kafka/pull/13193#discussion_r1119279751 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java: ## @@ -187,7 +187,8 @@ public ConnectMetricsRegistry(Set tags) {

[GitHub] [kafka] C0urante commented on a diff in pull request #13193: KAFKA-14659 source-record-write-[rate|total] metrics include filtered records

C0urante commented on code in PR #13193: URL: https://github.com/apache/kafka/pull/13193#discussion_r1119262008 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java: ## @@ -187,7 +187,8 @@ public ConnectMetricsRegistry(Set tags) {

[GitHub] [kafka] gharris1727 opened a new pull request, #13313: KAFKA-14760: Move ThroughputThrottler from tools to clients, remove tools dependency from connect-runtime

gharris1727 opened a new pull request, #13313: URL: https://github.com/apache/kafka/pull/13313 Currently connect-runtime pulls in tools as a dependency in order to use the ThroughputThrottler. In the future it will be desirable to have tools pull in connect-runtime as a (test) dependency

[GitHub] [kafka] divijvaidya closed pull request #13307: MINOR: Make ByteUtilsBenchmark deterministic

divijvaidya closed pull request #13307: MINOR: Make ByteUtilsBenchmark deterministic URL: https://github.com/apache/kafka/pull/13307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [kafka] divijvaidya commented on pull request #13307: MINOR: Make ByteUtilsBenchmark deterministic

divijvaidya commented on PR #13307: URL: https://github.com/apache/kafka/pull/13307#issuecomment-1447001588 @showuon I am discarding this PR as I have included it's changes in https://github.com/apache/kafka/pull/13312 -- This is an automated message from the Apache Git Service. To respo

[GitHub] [kafka] dajac commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

dajac commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1119248386 ## clients/src/main/resources/common/message/OffsetCommitRequest.json: ## @@ -47,8 +49,10 @@ "about": "The time period in ms to retain the offset." }, { "name

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694156#comment-17694156 ] Jorge Esteban Quilcate Otoya commented on KAFKA-2967: - Thanks [~mimai

[GitHub] [kafka] hgeraldino commented on a diff in pull request #13193: KAFKA-14659 source-record-write-[rate|total] metrics include filtered records

hgeraldino commented on code in PR #13193: URL: https://github.com/apache/kafka/pull/13193#discussion_r1119228442 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java: ## @@ -187,7 +187,8 @@ public ConnectMetricsRegistry(Set tags) {

[GitHub] [kafka] C0urante commented on a diff in pull request #13193: KAFKA-14659 source-record-write-[rate|total] metrics include filtered records

C0urante commented on code in PR #13193: URL: https://github.com/apache/kafka/pull/13193#discussion_r1119219553 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java: ## @@ -187,7 +187,8 @@ public ConnectMetricsRegistry(Set tags) {

[GitHub] [kafka] C0urante commented on a diff in pull request #13193: KAFKA-14659 source-record-write-[rate|total] metrics include filtered records

C0urante commented on code in PR #13193: URL: https://github.com/apache/kafka/pull/13193#discussion_r1119219553 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java: ## @@ -187,7 +187,8 @@ public ConnectMetricsRegistry(Set tags) {

[GitHub] [kafka] guozhangwang commented on pull request #13308: MINOR: update docs of 'replica.socket.receive.buffer.bytes'

guozhangwang commented on PR #13308: URL: https://github.com/apache/kafka/pull/13308#issuecomment-1446938946 LGTM. Merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka] hgeraldino commented on a diff in pull request #13193: KAFKA-14659 source-record-write-[rate|total] metrics include filtered records

hgeraldino commented on code in PR #13193: URL: https://github.com/apache/kafka/pull/13193#discussion_r1119214853 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java: ## @@ -187,7 +187,8 @@ public ConnectMetricsRegistry(Set tags) {

[GitHub] [kafka] guozhangwang merged pull request #13308: MINOR: update docs of 'replica.socket.receive.buffer.bytes'

guozhangwang merged PR #13308: URL: https://github.com/apache/kafka/pull/13308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.ap

[jira] [Commented] (KAFKA-14748) Relax non-null FK left-join requirement

[ https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694147#comment-17694147 ] Guozhang Wang commented on KAFKA-14748: --- Originally I think this can be treated wi

[jira] [Updated] (KAFKA-14468) Refactor Commit Logic

[ https://issues.apache.org/jira/browse/KAFKA-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-14468: --- Fix Version/s: 3.5.0 > Refactor Commit Logic > - > > Key: KAFKA-

[jira] [Updated] (KAFKA-14264) Refactor coordinator code

[ https://issues.apache.org/jira/browse/KAFKA-14264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-14264: --- Fix Version/s: 3.4.0 > Refactor coordinator code > - > > Key

[jira] [Updated] (KAFKA-14468) Refactor Commit Logic

[ https://issues.apache.org/jira/browse/KAFKA-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-14468: --- Fix Version/s: (was: 3.5.0) > Refactor Commit Logic > - > >

[GitHub] [kafka] C0urante commented on a diff in pull request #13193: KAFKA-14659 source-record-write-[rate|total] metrics include filtered records

C0urante commented on code in PR #13193: URL: https://github.com/apache/kafka/pull/13193#discussion_r1097934299 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java: ## @@ -187,7 +187,8 @@ public ConnectMetricsRegistry(Set tags) {

[jira] [Updated] (KAFKA-14468) Refactor Commit Logic

[ https://issues.apache.org/jira/browse/KAFKA-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-14468: --- Fix Version/s: 3.5.0 > Refactor Commit Logic > - > > Key: KAFKA-

[jira] [Resolved] (KAFKA-14468) Refactor Commit Logic

[ https://issues.apache.org/jira/browse/KAFKA-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-14468. --- Resolution: Fixed [~pnee] can you fill in the details on the fixed versions? Thanks! > Refactor Com

[jira] [Resolved] (KAFKA-14264) Refactor coordinator code

[ https://issues.apache.org/jira/browse/KAFKA-14264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-14264. --- Resolution: Fixed [~pnee] can you fill in the details on the fixed versions? Thanks! > Refactor coo

[GitHub] [kafka] C0urante commented on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

C0urante commented on PR #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-1446878483 Hi @urbandan, thanks for clarifying the point about using `Schema` methods. Agreed that this would be helpful. I think we should try to keep validation of optionality if possible,

[GitHub] [kafka] C0urante commented on pull request #13302: KAFKA-14759: Move Mock, Schema, and Verifiable connectors to new test-plugins module

C0urante commented on PR #13302: URL: https://github.com/apache/kafka/pull/13302#issuecomment-1446859760 Ah yes, good point about KIP-898! Nice that we don't have to file a separate KIP for this change. Will revisit if/when KIP-898 passes. -- This is an automated message from the Apache G

[jira] [Commented] (KAFKA-14762) Remove 0_8_2_LATEST from rolling upgrade system test

[ https://issues.apache.org/jira/browse/KAFKA-14762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694124#comment-17694124 ] Greg Harris commented on KAFKA-14762: - Thanks [~ijuma] for clarifying where the actu

[GitHub] [kafka] gharris1727 commented on pull request #13302: KAFKA-14759: Move Mock, Schema, and Verifiable connectors to new test-plugins module

gharris1727 commented on PR #13302: URL: https://github.com/apache/kafka/pull/13302#issuecomment-1446847150 > I think this may still require a KIP as it removes connectors from OOTB Connect. This is included as part of KIP-898: https://cwiki.apache.org/confluence/display/KAFKA/KIP-89

[GitHub] [kafka] junrao commented on a diff in pull request #13309: MINOR Moved a few log segment util methods from LocalLog to LogFileUtils

junrao commented on code in PR #13309: URL: https://github.com/apache/kafka/pull/13309#discussion_r1119124556 ## core/src/main/scala/kafka/log/LocalLog.scala: ## @@ -686,40 +685,6 @@ object LocalLog extends Logging { s"${topicPartition.topic}-${topicPartition.partition}"

[GitHub] [kafka] junrao commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

junrao commented on code in PR #13304: URL: https://github.com/apache/kafka/pull/13304#discussion_r1119112476 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1434,13 +1434,13 @@ class Partition(val topicPartition: TopicPartition, minOneMessage ) -L

[jira] [Commented] (KAFKA-14757) Kafka Cooperative Sticky Assignor results in significant duplicate consumption

[ https://issues.apache.org/jira/browse/KAFKA-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694119#comment-17694119 ] Philip Nee commented on KAFKA-14757: Hey Sidd, here you go: [https://kafka.apache.o

[jira] [Commented] (KAFKA-14757) Kafka Cooperative Sticky Assignor results in significant duplicate consumption

[ https://issues.apache.org/jira/browse/KAFKA-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694115#comment-17694115 ] Siddharth Anand commented on KAFKA-14757: - Is there documentation that details h

[GitHub] [kafka] kirktrue commented on pull request #12813: KAFKA-14317: ProduceRequest timeouts are logged as network exceptions

kirktrue commented on PR #12813: URL: https://github.com/apache/kafka/pull/12813#issuecomment-1446745731 @dajac I'm having a bit of a hard time figuring out how to test this. Per your previous comments, the `NetworkClient` already issues a request for metadata update when the connecti

[GitHub] [kafka] divijvaidya opened a new pull request, #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

divijvaidya opened a new pull request, #13312: URL: https://github.com/apache/kafka/pull/13312 # Motivation Reading/writing the protocol buffer varInt32 and varInt64 (also called varLong in our code base) is in the hot path of data plane code in Apache Kafka. We read multiple varInt in a

[jira] [Created] (KAFKA-14766) Improve performance of VarInt encoding/decoding

Divij Vaidya created KAFKA-14766: Summary: Improve performance of VarInt encoding/decoding Key: KAFKA-14766 URL: https://issues.apache.org/jira/browse/KAFKA-14766 Project: Kafka Issue Type: I

[GitHub] [kafka] C0urante commented on a diff in pull request #13276: KAFKA-14732: Use an exponential backoff retry mechanism while reconfiguring connector tasks

C0urante commented on code in PR #13276: URL: https://github.com/apache/kafka/pull/13276#discussion_r1119036590 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -3694,6 +3694,54 @@ public void shouldThrowWhenStartAn

[GitHub] [kafka] dajac commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

dajac commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1118981498 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,39 @@ // Version 2 adds the support for new error code PRODUCER_FENCED.

[GitHub] [kafka] dajac commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

dajac commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1118980264 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel, if (config.interBrokerProtocolVe

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1118952253 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel, if (config.interBrokerProtocol

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1118951636 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel, if (config.interBrokerProtocol

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1118949475 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -1303,11 +1305,13 @@ public void testCommitWithTopicAuthorizati

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1118948279 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -118,11 +123,78 @@ public AddPartitionsToTxnRequestData data() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1118946985 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -23,17 +23,39 @@ // Version 2 adds the support for new error code PRODUCER_FENCED.

[jira] [Updated] (KAFKA-14764) Metadata API ignores topic names if at least one topic is provided with an id

[ https://issues.apache.org/jira/browse/KAFKA-14764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14764: Summary: Metadata API ignores topic names if at least one topic is provided with an id (was: Meta

[jira] [Updated] (KAFKA-14764) Metadata API ignores topic names if at least one topic id is provided with an id

[ https://issues.apache.org/jira/browse/KAFKA-14764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14764: Summary: Metadata API ignores topic names if at least one topic id is provided with an id (was: M

[jira] [Updated] (KAFKA-14764) Metadata API ignores topic names if at least one topic ID is provided

[ https://issues.apache.org/jira/browse/KAFKA-14764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14764: Summary: Metadata API ignores topic names if at least one topic ID is provided (was: Metadata API

[GitHub] [kafka] hgeraldino commented on pull request #13193: KAFKA-14659 source-record-write-[rate|total] metrics include filtered records

hgeraldino commented on PR #13193: URL: https://github.com/apache/kafka/pull/13193#issuecomment-1446570858 Thanks @clolov, Now that https://github.com/apache/kafka/pull/13191 has been merged, this PR has been rebased and is ready for review. CC @C0urante -- This is an aut

[jira] [Commented] (KAFKA-14764) Metadata API ignores topic names if at least one topic is provided with an id

[ https://issues.apache.org/jira/browse/KAFKA-14764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694076#comment-17694076 ] David Jacot commented on KAFKA-14764: - [~dengziming] If I remember correctly, you di

[jira] [Commented] (KAFKA-14765) Support SCRAM for brokers at bootstrap

[ https://issues.apache.org/jira/browse/KAFKA-14765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694074#comment-17694074 ] Proven Provenzano commented on KAFKA-14765: --- [KIP-900|https://cwiki.apache.org

[jira] [Comment Edited] (KAFKA-14750) Sink connector fails if a topic matching its topics.regex gets deleted

[ https://issues.apache.org/jira/browse/KAFKA-14750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693369#comment-17693369 ] Chris Egerton edited comment on KAFKA-14750 at 2/27/23 3:28 PM: --

[GitHub] [kafka] dajac commented on pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

dajac commented on PR #13240: URL: https://github.com/apache/kafka/pull/13240#issuecomment-1446539881 @Hangleton Thanks for the update. I will take a look shortly. In the meantime, could you already add a few integration test for the OffsetCommitRequest like we have for the OffsetFetchReque

[jira] [Created] (KAFKA-14765) Support SCRAM for brokers at bootstrap

Proven Provenzano created KAFKA-14765: - Summary: Support SCRAM for brokers at bootstrap Key: KAFKA-14765 URL: https://issues.apache.org/jira/browse/KAFKA-14765 Project: Kafka Issue Type:

[jira] [Assigned] (KAFKA-14765) Support SCRAM for brokers at bootstrap

[ https://issues.apache.org/jira/browse/KAFKA-14765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Proven Provenzano reassigned KAFKA-14765: - Assignee: Proven Provenzano > Support SCRAM for brokers at bootstrap >

[jira] [Created] (KAFKA-14764) Metadata API ignores topic names if at least one topic is provided with an id

David Jacot created KAFKA-14764: --- Summary: Metadata API ignores topic names if at least one topic is provided with an id Key: KAFKA-14764 URL: https://issues.apache.org/jira/browse/KAFKA-14764 Project:

[jira] [Resolved] (KAFKA-14387) kafka.common.KafkaException | kafka_2.12-3.3.1.jar

[ https://issues.apache.org/jira/browse/KAFKA-14387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Katona resolved KAFKA-14387. --- Resolution: Information Provided > kafka.common.KafkaException | kafka_2.12-3.3.1.jar > ---

[jira] [Commented] (KAFKA-14387) kafka.common.KafkaException | kafka_2.12-3.3.1.jar

[ https://issues.apache.org/jira/browse/KAFKA-14387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694068#comment-17694068 ] Andras Katona commented on KAFKA-14387: --- it was removed here: https://github.com/a

[GitHub] [kafka] rondagostino commented on pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

rondagostino commented on PR #13280: URL: https://github.com/apache/kafka/pull/13280#issuecomment-1446491240 The `topicIdInfo` benchmark now performs equivalently. I eliminated the `TranslatedValueMapView` class in favor of adding a value mapper to the `VavrMapAsJava` class. -- This is

[jira] [Resolved] (KAFKA-14738) Topic disappears from kafka_topic.sh --list after modifying it with kafka_acl.sh

[ https://issues.apache.org/jira/browse/KAFKA-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Katona resolved KAFKA-14738. --- Resolution: Not A Bug > Topic disappears from kafka_topic.sh --list after modifying it with

[jira] [Resolved] (KAFKA-14060) Replace EasyMock and PowerMock with Mockito in AbstractWorkerSourceTaskTest

[ https://issues.apache.org/jira/browse/KAFKA-14060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14060. --- Resolution: Done > Replace EasyMock and PowerMock with Mockito in AbstractWorkerSourceTaskTe

[jira] [Commented] (KAFKA-14041) Avoid the keyword var for a variable declaration in ConfigTransformer

[ https://issues.apache.org/jira/browse/KAFKA-14041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694048#comment-17694048 ] Andras Katona commented on KAFKA-14041: --- Java compiler doesn't mind. {{var}} can b

[GitHub] [kafka] C0urante merged pull request #13191: KAFKA-14060: Replace EasyMock and PowerMock with Mockito in AbstractWorkerSourceTaskTest

C0urante merged PR #13191: URL: https://github.com/apache/kafka/pull/13191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

  1   2   >