yashmayya commented on PR #12984:
URL: https://github.com/apache/kafka/pull/12984#issuecomment-1347872598
@C0urante could you please take a look at this whenever you get a chance?
I'm sorry to keep pinging you for review requests, but I'm not aware of any
other committers currently taking a
jianbin.chen created KAFKA-14465:
Summary: java.lang.NumberFormatException: For input string:
"index"
Key: KAFKA-14465
URL: https://issues.apache.org/jira/browse/KAFKA-14465
Project: Kafka
yashmayya commented on code in PR #12984:
URL: https://github.com/apache/kafka/pull/12984#discussion_r1046722667
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConfigBackingStore.java:
##
@@ -51,8 +52,9 @@ public interface ConfigBackingStore {
* Update t
yashmayya opened a new pull request, #12984:
URL: https://github.com/apache/kafka/pull/12984
- Kafka Connect's `POST /connectors` and `PUT
/connectors/{connector}/config` REST APIs internally simply write a message to
the Connect cluster's internal config topic (which is then processed
asy
ijuma closed pull request #7703: MINOR: Avoid unnecessary tuple allocations in
index binary search
URL: https://github.com/apache/kafka/pull/7703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on PR #7703:
URL: https://github.com/apache/kafka/pull/7703#issuecomment-1347702799
Closing this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
cmccabe opened a new pull request, #12983:
URL: https://github.com/apache/kafka/pull/12983
This PR introduces the new metadata loader and snapshot generator. For the
time being, they are only used by the controller, but a PR for the broker will
come soon.
The new metadata loader supp
jsancio merged PR #12975:
URL: https://github.com/apache/kafka/pull/12975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
jsancio commented on PR #12975:
URL: https://github.com/apache/kafka/pull/12975#issuecomment-1347573437
Merging. Unrelated test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
[
https://issues.apache.org/jira/browse/KAFKA-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-14392:
--
Affects Version/s: (was: 3.3.2)
> KRaft broker heartbeat timeout should not exceed broker.
[
https://issues.apache.org/jira/browse/KAFKA-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-14392:
--
Fix Version/s: 3.3.2
> KRaft broker heartbeat timeout should not exceed broker.session.timeout
jsancio commented on code in PR #12981:
URL: https://github.com/apache/kafka/pull/12981#discussion_r1046477051
##
raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java:
##
@@ -32,7 +32,7 @@
* topic partition from offset 0 up to but not including the end offset in th
[
https://issues.apache.org/jira/browse/KAFKA-14271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeffrey Tolar resolved KAFKA-14271.
---
Fix Version/s: 3.4.0
3.3.2
Resolution: Duplicate
Haven't tested th
jolshan commented on code in PR #12968:
URL: https://github.com/apache/kafka/pull/12968#discussion_r1046506543
##
core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala:
##
@@ -167,7 +167,7 @@ class RPCProducerIdManager(brokerId: Int,
if (nextProducerId
jolshan commented on code in PR #12968:
URL: https://github.com/apache/kafka/pull/12968#discussion_r1046505868
##
core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala:
##
@@ -236,7 +236,7 @@ class RPCProducerIdManager(brokerId: Int,
private[transaction] d
jsancio commented on code in PR #12981:
URL: https://github.com/apache/kafka/pull/12981#discussion_r1046477051
##
raft/src/main/java/org/apache/kafka/snapshot/SnapshotWriter.java:
##
@@ -32,7 +32,7 @@
* topic partition from offset 0 up to but not including the end offset in th
CalvinConfluent opened a new pull request, #12982:
URL: https://github.com/apache/kafka/pull/12982
Even if the follower is the ISR, the follower will be excluded because the
logEndOffset (-1) is less than the fetchOffset (0)
```
if (partition.inSyncReplicaIds.contains(replica.brokerId)
hachikuji closed pull request #12963: MINOR: More consistent handling of
snapshot IDs
URL: https://github.com/apache/kafka/pull/12963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
hachikuji commented on PR #12963:
URL: https://github.com/apache/kafka/pull/12963#issuecomment-1347439806
Closing this patch since the issue with MetadataImage.EMPTY was addressed in
https://github.com/apache/kafka/commit/b2dea17041157ceee741041d23783ff993b88ef1.
I've opened a separate patc
hachikuji opened a new pull request, #12981:
URL: https://github.com/apache/kafka/pull/12981
Let `RaftClient.createSnapshot` take the snapshotId directly instead of the
committed offset/epoch (which may not exist).
### Committer Checklist (excluded from commit message)
- [ ] Verif
cmccabe commented on code in PR #12961:
URL: https://github.com/apache/kafka/pull/12961#discussion_r1046455192
##
core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala:
##
@@ -355,6 +375,13 @@ class ZkMetadataCache(brokerId: Int, metadataVersion:
MetadataVersion, brok
cmccabe commented on code in PR #12961:
URL: https://github.com/apache/kafka/pull/12961#discussion_r1046452882
##
core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala:
##
@@ -60,7 +61,8 @@ trait ZkFinalizedFeatureCache {
* A cache for the state (e.g., current leade
cmccabe commented on code in PR #12961:
URL: https://github.com/apache/kafka/pull/12961#discussion_r1046452203
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -544,6 +548,7 @@ class KafkaServer(
private def controlledShutdown(): Unit = {
val socketTimeoutMs
cmccabe commented on code in PR #12961:
URL: https://github.com/apache/kafka/pull/12961#discussion_r1046450807
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -262,8 +263,11 @@ class KafkaServer(
_brokerState = BrokerState.RECOVERY
logManager.start
cmccabe commented on code in PR #12961:
URL: https://github.com/apache/kafka/pull/12961#discussion_r1046450254
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1665,6 +1665,7 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
def
cmccabe commented on code in PR #12961:
URL: https://github.com/apache/kafka/pull/12961#discussion_r1046449684
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1665,6 +1665,7 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
def
cmccabe commented on code in PR #12961:
URL: https://github.com/apache/kafka/pull/12961#discussion_r1046447468
##
clients/src/main/resources/common/message/LeaderAndIsrRequest.json:
##
@@ -36,7 +36,7 @@
"fields": [
{ "name": "ControllerId", "type": "int32", "versions": "
cmccabe commented on code in PR #12961:
URL: https://github.com/apache/kafka/pull/12961#discussion_r1046447181
##
clients/src/main/java/org/apache/kafka/common/requests/UpdateMetadataRequest.java:
##
@@ -51,7 +51,16 @@ public static class Builder extends
AbstractControlRequest.
cmccabe commented on code in PR #12961:
URL: https://github.com/apache/kafka/pull/12961#discussion_r1046447035
##
clients/src/main/java/org/apache/kafka/common/requests/StopReplicaRequest.java:
##
@@ -45,14 +45,23 @@ public static class Builder extends
AbstractControlRequest.Bu
cmccabe commented on code in PR #12961:
URL: https://github.com/apache/kafka/pull/12961#discussion_r1046446539
##
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java:
##
@@ -51,7 +51,16 @@ public static class Builder extends
AbstractControlRequest.Bu
mumrah commented on code in PR #12961:
URL: https://github.com/apache/kafka/pull/12961#discussion_r1046370590
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1317,14 +1316,23 @@ class KafkaApis(val requestChannel: RequestChannel,
trace("Sending topic metadata
[
https://issues.apache.org/jira/browse/KAFKA-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino resolved KAFKA-14392.
---
Fix Version/s: 3.5.0
Resolution: Fixed
> KRaft broker heartbeat timeout should not ex
[
https://issues.apache.org/jira/browse/KAFKA-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-14392:
--
Affects Version/s: 3.3.2
> KRaft broker heartbeat timeout should not exceed broker.session.tim
[
https://issues.apache.org/jira/browse/KAFKA-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-14392:
--
Affects Version/s: 3.4.0
> KRaft broker heartbeat timeout should not exceed broker.session.tim
[
https://issues.apache.org/jira/browse/KAFKA-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-14392:
--
Component/s: kraft
> KRaft broker heartbeat timeout should not exceed broker.session.timeout.m
[
https://issues.apache.org/jira/browse/KAFKA-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-14392:
--
Affects Version/s: (was: 3.4.0)
> KRaft broker heartbeat timeout should not exceed broker.
[
https://issues.apache.org/jira/browse/KAFKA-14392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ron Dagostino updated KAFKA-14392:
--
Affects Version/s: 3.3.1
3.3.0
3.4.0
> KRaft bro
hachikuji commented on code in PR #12968:
URL: https://github.com/apache/kafka/pull/12968#discussion_r1046275111
##
core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala:
##
@@ -167,7 +167,7 @@ class RPCProducerIdManager(brokerId: Int,
if (nextProducer
hachikuji commented on code in PR #12968:
URL: https://github.com/apache/kafka/pull/12968#discussion_r1046262250
##
core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala:
##
@@ -167,7 +167,7 @@ class RPCProducerIdManager(brokerId: Int,
if (nextProducer
jsancio commented on code in PR #12975:
URL: https://github.com/apache/kafka/pull/12975#discussion_r1046207835
##
raft/src/main/java/org/apache/kafka/raft/FollowerState.java:
##
@@ -169,4 +184,26 @@ public void close() {
fetchingSnapshot.get().close();
}
[
https://issues.apache.org/jira/browse/KAFKA-14461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14461:
Component/s: streams
unit tests
> StoreQueryIntegrationTest#shouldQuerySp
cmccabe merged PR #12964:
URL: https://github.com/apache/kafka/pull/12964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
gharris1727 opened a new pull request, #12980:
URL: https://github.com/apache/kafka/pull/12980
For all AutoCloseable resources created by MM2 connectors & tasks, force
their instantiation to take place within a BackgroundResources instance, which
can be closed when the connector/task stops.
[
https://issues.apache.org/jira/browse/KAFKA-14323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-14323:
---
Fix Version/s: (was: 3.4.0)
> KRaft broker time based snapshots
[
https://issues.apache.org/jira/browse/KAFKA-14323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-14323:
---
Fix Version/s: 3.5.0
> KRaft broker time based snapshots
> -
[
https://issues.apache.org/jira/browse/KAFKA-14403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-14403:
---
Fix Version/s: 3.5.0
> Snapshot failure metrics
> --
Greg Harris created KAFKA-14464:
---
Summary: Refactor MM2 connectors to make resource leaks from code
defects less likely
Key: KAFKA-14464
URL: https://issues.apache.org/jira/browse/KAFKA-14464
Project: K
cadonna commented on code in PR #12821:
URL: https://github.com/apache/kafka/pull/12821#discussion_r1046120121
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StateManagerUtilTest.java:
##
@@ -42,77 +40,56 @@
import static java.util.Collections.emptyList
Greg Harris created KAFKA-14463:
---
Summary: ConnectorClientConfigOverridePolicy is not closed at
worker shutdown
Key: KAFKA-14463
URL: https://issues.apache.org/jira/browse/KAFKA-14463
Project: Kafka
mumrah commented on code in PR #12973:
URL: https://github.com/apache/kafka/pull/12973#discussion_r1046093236
##
core/src/main/scala/kafka/zk/KafkaZkClient.scala:
##
@@ -166,60 +166,74 @@ class KafkaZkClient private[zk] (zooKeeperClient:
ZooKeeperClient, isSecure: Boo
* the
David Jacot created KAFKA-14462:
---
Summary: New Group Coordinator State Machine
Key: KAFKA-14462
URL: https://issues.apache.org/jira/browse/KAFKA-14462
Project: Kafka
Issue Type: Sub-task
dajac closed pull request #12969: MINOR: Small refactor in ApiVersionManager
URL: https://github.com/apache/kafka/pull/12969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/KAFKA-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646033#comment-17646033
]
Mikael commented on KAFKA-14419:
Thanks, I'll try that out. I did see the same symptom b
chia7712 opened a new pull request, #12979:
URL: https://github.com/apache/kafka/pull/12979
we don't remove "is-future=true" tag from future log after the future log
becomes "current" log. It causes two potential issues:
1. the metrics monitors can't get metrics of Log if they don't t
[
https://issues.apache.org/jira/browse/KAFKA-14379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-14379.
-
Fix Version/s: 3.3.2
Resolution: Fixed
> consumer should refresh preferred read replica o
dajac commented on PR #12956:
URL: https://github.com/apache/kafka/pull/12956#issuecomment-1346125696
Merged to trunk, 3.4 and 3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
dajac merged PR #12956:
URL: https://github.com/apache/kafka/pull/12956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on code in PR #12956:
URL: https://github.com/apache/kafka/pull/12956#discussion_r1045547158
##
clients/src/main/java/org/apache/kafka/common/Cluster.java:
##
@@ -253,7 +253,11 @@ public Node nodeById(int id) {
public Optional nodeIfOnline(TopicPartition par
dajac opened a new pull request, #12978:
URL: https://github.com/apache/kafka/pull/12978
This is a small follow-up to https://github.com/apache/kafka/pull/12848.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test cove
yashmayya commented on code in PR #12947:
URL: https://github.com/apache/kafka/pull/12947#discussion_r1045537542
##
connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectStandalone.java:
##
@@ -21,41 +21,51 @@
import org.apache.kafka.common.utils.Utils;
import
org
dajac commented on code in PR #12858:
URL: https://github.com/apache/kafka/pull/12858#discussion_r1045524817
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -1992,6 +1992,186 @@ class KafkaApisTest {
testListOffsetFailedGetLeaderReplica(Errors.UNKNOWN_TO
dajac commented on code in PR #12590:
URL: https://github.com/apache/kafka/pull/12590#discussion_r1044655133
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##
@@ -1933,11 +1943,79 @@ private Map
topicPartitionTags(TopicPartition tp) {
62 matches
Mail list logo
