[jira] [Commented] (KAFKA-14306) add uniform serializer and deserializer to the kafka protocol

2022-10-16 Thread Deng Ziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17618381#comment-17618381 ] Deng Ziming commented on KAFKA-14306: - Hello, Kafka has it's own protocol design and

[GitHub] [kafka] showuon commented on a diff in pull request #12752: KAFKA-14303 Fix batch.size=0 in BuiltInPartitioner

2022-10-16 Thread GitBox
showuon commented on code in PR #12752: URL: https://github.com/apache/kafka/pull/12752#discussion_r996542887 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -127,7 +127,9 @@ public RecordAccumulator(LogContext logContext,

[GitHub] [kafka] ijuma commented on a diff in pull request #12750: MINOR: Inline "Running a Kafka broker in KRaft mode" in README.md

2022-10-16 Thread GitBox
ijuma commented on code in PR #12750: URL: https://github.com/apache/kafka/pull/12750#discussion_r996500992 ## README.md: ## @@ -83,15 +83,17 @@ fail due to code changes. You can just run: ./gradlew processMessages processTestMessages +### Running a Kafka broker in KRa

[GitHub] [kafka] ijuma commented on a diff in pull request #12750: MINOR: Inline "Running a Kafka broker in KRaft mode" in README.md

2022-10-16 Thread GitBox
ijuma commented on code in PR #12750: URL: https://github.com/apache/kafka/pull/12750#discussion_r996500992 ## README.md: ## @@ -83,15 +83,17 @@ fail due to code changes. You can just run: ./gradlew processMessages processTestMessages +### Running a Kafka broker in KRa

[GitHub] [kafka] soarez commented on pull request #12314: KAFKA-13903: Queue size metric in QuorumController

2022-10-16 Thread GitBox
soarez commented on PR #12314: URL: https://github.com/apache/kafka/pull/12314#issuecomment-1280064868 Rebased and simplified the changes. PTAL @mumrah -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] ijuma commented on a diff in pull request #12752: KAFKA-14303 Fix batch.size=0 in BuiltInPartitioner

2022-10-16 Thread GitBox
ijuma commented on code in PR #12752: URL: https://github.com/apache/kafka/pull/12752#discussion_r996499836 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -127,7 +127,9 @@ public RecordAccumulator(LogContext logContext,

[GitHub] [kafka] jsancio commented on a diff in pull request #12711: MINOR: Skip snapshot header footer

2022-10-16 Thread GitBox
jsancio commented on code in PR #12711: URL: https://github.com/apache/kafka/pull/12711#discussion_r996492362 ## metadata/src/main/java/org/apache/kafka/metadata/util/SnapshotFileReader.java: ## @@ -131,6 +132,10 @@ private void handleControlBatch(FileChannelRecordBatch batch)

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12735: Replace EasyMock and PowerMock with Mockito in connect/runtime/ErrorHandlingTaskTest | KAFKA-14059

2022-10-16 Thread GitBox
divijvaidya commented on code in PR #12735: URL: https://github.com/apache/kafka/pull/12735#discussion_r996480944 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java: ## @@ -164,8 +166,8 @@ public class ErrorHandlingTaskTest { Offset

[GitHub] [kafka] vjanelle commented on pull request #12675: KAFKA-14256: Upgrade from Scala 2.13.8 to 2.13.10

2022-10-16 Thread GitBox
vjanelle commented on PR #12675: URL: https://github.com/apache/kafka/pull/12675#issuecomment-1280026237 Hmm, trying this locally with 2.8.2 (slightly forked), and the following test fails ``` > Task :core:integrationTest FAILED kafka.admin.TopicCommandWithAdminClientTest.testD

[GitHub] [kafka] vamossagar12 opened a new pull request, #12758: KIP-770-cache size config deprecation

2022-10-16 Thread GitBox
vamossagar12 opened a new pull request, #12758: URL: https://github.com/apache/kafka/pull/12758 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of te

[GitHub] [kafka] shekhar-rajak commented on pull request #12735: Replace EasyMock and PowerMock with Mockito in connect/runtime/ErrorHandlingTaskTest | KAFKA-14059

2022-10-16 Thread GitBox
shekhar-rajak commented on PR #12735: URL: https://github.com/apache/kafka/pull/12735#issuecomment-1279989109 Thanks @divijvaidya for the review. I think now it is all good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] showuon merged pull request #12757: MINOR: typo in KafkaChannel

2022-10-16 Thread GitBox
showuon merged PR #12757: URL: https://github.com/apache/kafka/pull/12757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Resolved] (KAFKA-14280) quorum election random backoff always return 0 for 1st retry

2022-10-16 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-14280. --- Resolution: Not A Problem Closed as not a problem   > quorum election random backoff always return

[GitHub] [kafka] showuon commented on a diff in pull request #12716: KAFKA-14280: return random backoff for 1st retries

2022-10-16 Thread GitBox
showuon commented on code in PR #12716: URL: https://github.com/apache/kafka/pull/12716#discussion_r996433828 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -647,12 +647,13 @@ private boolean handleVoteResponse( } } -private int binar

[GitHub] [kafka] showuon closed pull request #12716: KAFKA-14280: return random backoff for 1st retries

2022-10-16 Thread GitBox
showuon closed pull request #12716: KAFKA-14280: return random backoff for 1st retries URL: https://github.com/apache/kafka/pull/12716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [kafka] aglicacha commented on a diff in pull request #12729: KAFKA-14285: Delete quota node in zookeeper when configs are empty

2022-10-16 Thread GitBox
aglicacha commented on code in PR #12729: URL: https://github.com/apache/kafka/pull/12729#discussion_r996423711 ## core/src/main/scala/kafka/zk/AdminZkClient.scala: ## @@ -365,6 +365,29 @@ class AdminZkClient(zkClient: KafkaZkClient) extends Logging { case ConfigType.Ip

[GitHub] [kafka] aglicacha commented on a diff in pull request #12729: KAFKA-14285: Delete quota node in zookeeper when configs are empty

2022-10-16 Thread GitBox
aglicacha commented on code in PR #12729: URL: https://github.com/apache/kafka/pull/12729#discussion_r996423424 ## core/src/main/scala/kafka/zk/AdminZkClient.scala: ## @@ -365,6 +365,29 @@ class AdminZkClient(zkClient: KafkaZkClient) extends Logging { case ConfigType.Ip

[GitHub] [kafka] aglicacha commented on a diff in pull request #12729: KAFKA-14285: Delete quota node in zookeeper when configs are empty

2022-10-16 Thread GitBox
aglicacha commented on code in PR #12729: URL: https://github.com/apache/kafka/pull/12729#discussion_r996423147 ## core/src/main/scala/kafka/zk/AdminZkClient.scala: ## @@ -365,6 +365,29 @@ class AdminZkClient(zkClient: KafkaZkClient) extends Logging { case ConfigType.Ip

[GitHub] [kafka] aglicacha commented on a diff in pull request #12729: KAFKA-14285: Delete quota node in zookeeper when configs are empty

2022-10-16 Thread GitBox
aglicacha commented on code in PR #12729: URL: https://github.com/apache/kafka/pull/12729#discussion_r996422546 ## core/src/main/scala/kafka/zk/AdminZkClient.scala: ## @@ -365,6 +365,29 @@ class AdminZkClient(zkClient: KafkaZkClient) extends Logging { case ConfigType.Ip

[GitHub] [kafka] Stephan14 commented on pull request #12308: KAFKA-14009: update rebalance timeout in memory when consumers use st…

2022-10-16 Thread GitBox
Stephan14 commented on PR #12308: URL: https://github.com/apache/kafka/pull/12308#issuecomment-1279924132 @dajac I have modify the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [kafka] Stephan14 commented on a diff in pull request #12308: KAFKA-14009: update rebalance timeout in memory when consumers use st…

2022-10-16 Thread GitBox
Stephan14 commented on code in PR #12308: URL: https://github.com/apache/kafka/pull/12308#discussion_r996380503 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala: ## @@ -1036,6 +1036,28 @@ class GroupCoordinatorTest { assertEquals(Errors.NONE, s