hachikuji commented on code in PR #12479:
URL: https://github.com/apache/kafka/pull/12479#discussion_r950612509
##
core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala:
##
@@ -120,6 +125,45 @@ class KRaftQuorumImplementation(
CoreUtils.swallow(raftManager.sh
hachikuji commented on code in PR #12479:
URL: https://github.com/apache/kafka/pull/12479#discussion_r950603583
##
core/src/test/scala/integration/kafka/api/RackAwareAutoTopicCreationTest.scala:
##
@@ -37,29 +43,52 @@ class RackAwareAutoTopicCreationTest extends
KafkaServerTest
hachikuji commented on PR #12469:
URL: https://github.com/apache/kafka/pull/12469#issuecomment-1221137115
@dengziming I reverted the patch to disable the test. I think we found the
cause of the flakiness and fixed here:
https://github.com/apache/kafka/pull/12508/commits/d1936aba7ac23d221b1d
[
https://issues.apache.org/jira/browse/KAFKA-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niket Goel resolved KAFKA-13888.
Resolution: Fixed
> KIP-836: Addition of Information in DescribeQuorumResponse about Voter Lag
> -
hachikuji merged PR #12508:
URL: https://github.com/apache/kafka/pull/12508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
jolshan commented on PR #12541:
URL: https://github.com/apache/kafka/pull/12541#issuecomment-1221122349
Another option I was thinking of was removing the log line from the case
where the previous topic ID was null.
--
This is an automated message from the Apache Git Service.
To respond t
jolshan commented on PR #12541:
URL: https://github.com/apache/kafka/pull/12541#issuecomment-1221121457
Thanks @fabien-chebel -- this was a solution I was thinking of when
reviewing https://github.com/apache/kafka/pull/12378/files
--
This is an automated message from the Apache Git Servi
jolshan commented on code in PR #12543:
URL: https://github.com/apache/kafka/pull/12543#discussion_r950576126
##
core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala:
##
@@ -490,6 +490,41 @@ class ControllerIntegrationTest extends QuorumTestHarness {
jolshan commented on code in PR #12543:
URL: https://github.com/apache/kafka/pull/12543#discussion_r950574990
##
core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala:
##
@@ -490,6 +490,41 @@ class ControllerIntegrationTest extends QuorumTestHarness {
hachikuji merged PR #12538:
URL: https://github.com/apache/kafka/pull/12538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
hachikuji commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r950502736
##
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##
@@ -188,12 +182,16 @@ private ApiError updateFeature(
}
}
hachikuji commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r950487364
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1118,6 +1059,65 @@ private void updateWriteOffset(long offset) {
}
}
hachikuji commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r950458081
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1118,6 +1059,65 @@ private void updateWriteOffset(long offset) {
}
}
hachikuji commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r950450852
##
metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java:
##
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
guozhangwang merged PR #12537:
URL: https://github.com/apache/kafka/pull/12537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
cmccabe commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r950399632
##
metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java:
##
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
junrao commented on code in PR #12516:
URL: https://github.com/apache/kafka/pull/12516#discussion_r950387484
##
core/src/main/scala/kafka/log/LogSegment.scala:
##
@@ -176,10 +179,28 @@ class LogSegment private[log] (val log: FileRecords,
throw new LogSegmentOffsetOverflow
cmccabe commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r950388163
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1118,6 +1059,65 @@ private void updateWriteOffset(long offset) {
}
}
C0urante commented on PR #12478:
URL: https://github.com/apache/kafka/pull/12478#issuecomment-1220885110
> Why do we need to do this? If the task has been cancelled and basically
abandoned by the framework, it shouldn't really matter if the backoff takes up
to `errorMaxDelayInMillis` right?
yashmayya commented on code in PR #12502:
URL: https://github.com/apache/kafka/pull/12502#discussion_r950385666
##
connect/transforms/src/test/java/org/apache/kafka/connect/transforms/HoistFieldTest.java:
##
@@ -58,4 +60,17 @@ public void withSchema() {
assertEquals(42,
hachikuji commented on PR #12469:
URL: https://github.com/apache/kafka/pull/12469#issuecomment-1220878950
@dengziming I've disabled `MetadataQuorumCommandTest` for now so that we can
get this checked in. I see a similar issue in
https://github.com/apache/kafka/pull/12469, but I am unable to
yashmayya commented on PR #12478:
URL: https://github.com/apache/kafka/pull/12478#issuecomment-1220870792
> I think a Supplier isCancelled would be fine to check if the
operator should prematurely exit
Makes sense, I've implemented this with a test.
> One other thing worth acc
[
https://issues.apache.org/jira/browse/KAFKA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581943#comment-17581943
]
Guozhang Wang commented on KAFKA-10635:
---
Thanks [~nicktelford], just to clarify wh
jolshan commented on code in PR #12501:
URL: https://github.com/apache/kafka/pull/12501#discussion_r950361551
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1295,7 +1298,8 @@ object KafkaConfig {
.define(TransactionsAbortTimedOutTransactionCleanupIntervalMs
hachikuji commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r95035
##
metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapDirectory.java:
##
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
jolshan commented on code in PR #12501:
URL: https://github.com/apache/kafka/pull/12501#discussion_r950351272
##
core/src/test/scala/integration/kafka/api/ProducerIdExpirationTest.scala:
##
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-12898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-12898:
Description: While investigating
https://issues.apache.org/jira/browse/KAFKA-12896, I have noticed
dajac commented on code in PR #12501:
URL: https://github.com/apache/kafka/pull/12501#discussion_r950334275
##
core/src/test/scala/integration/kafka/api/ProducerIdExpirationTest.scala:
##
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
dajac commented on code in PR #12501:
URL: https://github.com/apache/kafka/pull/12501#discussion_r950331172
##
core/src/test/scala/integration/kafka/api/ProducerIdExpirationTest.scala:
##
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
[
https://issues.apache.org/jira/browse/KAFKA-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581921#comment-17581921
]
M.P. Korstanje edited comment on KAFKA-10902 at 8/19/22 3:39 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581921#comment-17581921
]
M.P. Korstanje edited comment on KAFKA-10902 at 8/19/22 3:38 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581921#comment-17581921
]
M.P. Korstanje edited comment on KAFKA-10902 at 8/19/22 3:35 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581921#comment-17581921
]
M.P. Korstanje edited comment on KAFKA-10902 at 8/19/22 3:35 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581921#comment-17581921
]
M.P. Korstanje edited comment on KAFKA-10902 at 8/19/22 3:34 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581921#comment-17581921
]
M.P. Korstanje edited comment on KAFKA-10902 at 8/19/22 3:34 PM:
-
jolshan commented on code in PR #12501:
URL: https://github.com/apache/kafka/pull/12501#discussion_r950321257
##
core/src/test/scala/integration/kafka/api/ProducerIdExpirationTest.scala:
##
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581921#comment-17581921
]
M.P. Korstanje edited comment on KAFKA-10902 at 8/19/22 3:32 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581921#comment-17581921
]
M.P. Korstanje edited comment on KAFKA-10902 at 8/19/22 3:32 PM:
-
jolshan commented on code in PR #12501:
URL: https://github.com/apache/kafka/pull/12501#discussion_r950319828
##
core/src/test/scala/integration/kafka/api/TransactionsExpirationTest.scala:
##
@@ -97,6 +111,9 @@ class TransactionsExpirationTest extends
KafkaServerTestHarness {
[
https://issues.apache.org/jira/browse/KAFKA-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581921#comment-17581921
]
M.P. Korstanje commented on KAFKA-10902:
As the original reporter I'm happy to r
jolshan commented on code in PR #12501:
URL: https://github.com/apache/kafka/pull/12501#discussion_r950318797
##
core/src/test/scala/integration/kafka/api/ProducerIdExpirationTest.scala:
##
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
jolshan commented on code in PR #12501:
URL: https://github.com/apache/kafka/pull/12501#discussion_r950318388
##
core/src/test/scala/integration/kafka/api/ProducerIdExpirationTest.scala:
##
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
jolshan commented on code in PR #12501:
URL: https://github.com/apache/kafka/pull/12501#discussion_r950317193
##
core/src/test/scala/integration/kafka/api/ProducerIdExpirationTest.scala:
##
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581914#comment-17581914
]
Sagar Rao commented on KAFKA-12495:
---
[~ChrisEgerton] , I was looking at this and this
[
https://issues.apache.org/jira/browse/KAFKA-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581894#comment-17581894
]
Nicholas Telford commented on KAFKA-10635:
--
Hi [~guozhang], unfortunately what
C0urante commented on code in PR #12502:
URL: https://github.com/apache/kafka/pull/12502#discussion_r950247379
##
connect/transforms/src/test/java/org/apache/kafka/connect/transforms/HoistFieldTest.java:
##
@@ -58,4 +60,17 @@ public void withSchema() {
assertEquals(42,
C0urante commented on PR #12295:
URL: https://github.com/apache/kafka/pull/12295#issuecomment-1220741520
Thanks @dstelljes, I found you, added you to the Kafka project, and assigned
the Jira ticket to you. I couldn't find an account for the [Kafka Confluence
space](https://cwiki.apache.org/
[
https://issues.apache.org/jira/browse/KAFKA-13586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-13586:
-
Assignee: Dan Stelljes (was: Chris Egerton)
> ConfigExceptions thrown by FileConfigPro
mumrah commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r950205140
##
metadata/src/main/java/org/apache/kafka/controller/LogReplayTracker.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
C0urante commented on code in PR #12490:
URL: https://github.com/apache/kafka/pull/12490#discussion_r950226900
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaConfigBackingStoreTest.java:
##
@@ -842,6 +842,7 @@ public void testBackgroundConnectorDeletion()
C0urante commented on PR #12478:
URL: https://github.com/apache/kafka/pull/12478#issuecomment-1220695831
I think a `Supplier isCancelled` would be fine to check if the
operator should prematurely exit. One other thing worth accounting for is the
backoff logic, which currently uses `Time::sl
songnon opened a new pull request, #12543:
URL: https://github.com/apache/kafka/pull/12543
Auto preferred leader election should be allowed for partitions which don't
have any
ongoing reassignments. Otherwise, it might result in unbalanced leaders if
there are
any long-running reassig
[
https://issues.apache.org/jira/browse/KAFKA-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581826#comment-17581826
]
Yash Mayya commented on KAFKA-13431:
Hi [~erdody], pinging you here in case you miss
dajac commented on code in PR #12175:
URL: https://github.com/apache/kafka/pull/12175#discussion_r950125824
##
core/src/main/scala/kafka/tools/ConsoleConsumer.scala:
##
@@ -307,7 +311,11 @@ object ConsoleConsumer extends Logging {
val partitionArg = if (options.has(partitio
dajac merged PR #12198:
URL: https://github.com/apache/kafka/pull/12198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on code in PR #12501:
URL: https://github.com/apache/kafka/pull/12501#discussion_r950107432
##
core/src/test/scala/integration/kafka/api/ProducerIdExpirationTest.scala:
##
@@ -0,0 +1,176 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
yashmayya commented on PR #12478:
URL: https://github.com/apache/kafka/pull/12478#issuecomment-1220560508
Thanks for the review @C0urante and sorry about the late reply. That's a
very astute observation regarding tasks potentially getting stuck in infinite
loops - you're right in that the t
dajac opened a new pull request, #12542:
URL: https://github.com/apache/kafka/pull/12542
Using `group synchronized` when accessing the group state does not seem to
be correct because the group is protected by a lock. Instead we should use
`group.inLock`.
### Committer Checklist (excl
fabien-chebel commented on PR #12541:
URL: https://github.com/apache/kafka/pull/12541#issuecomment-1220450125
The original logging verbosity change was performed in
https://github.com/apache/kafka/pull/11552.
Pinging @jolshan, who previously reviewed
https://github.com/apache/kafka/p
fabien-chebel opened a new pull request, #12541:
URL: https://github.com/apache/kafka/pull/12541
Context
---
Since updating to kafka client 3.0.1, we noticed quite a lot of new
info-level logs generated by `org.apache.kafka.clients.Metadata`.
The logs look like this:
[
https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Hørslev updated KAFKA-14172:
---
Description:
h1. State stores lose state when tasks are reassigned under EOS with standby
r
[
https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Hørslev updated KAFKA-14172:
---
Description:
h1. State stores lose state when tasks are reassigned under EOS with standby
r
[
https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Hørslev updated KAFKA-14172:
---
Description:
h1. State stores lose state when tasks are reassigned under EOS with standby
r
Martin Hørslev created KAFKA-14172:
--
Summary: bug: State stores loose state when tasks are reassigned
under EOS wit…
Key: KAFKA-14172
URL: https://issues.apache.org/jira/browse/KAFKA-14172
Project: K
chorslev opened a new pull request, #12540:
URL: https://github.com/apache/kafka/pull/12540
…h standby replicas and default acceptable lag.
The attached stream is an extension to the known de-duplication example
often use in Kafka.
The goal is to assign a unique identifier to each
RivenSun2 commented on PR #12539:
URL: https://github.com/apache/kafka/pull/12539#issuecomment-1220325922
The two exceptions thrown in the
`SaslClientAuthenticator.createSaslClient()` method, whether the exception
information can be distinguished by sitting down.
Because when the JDK pri
mdedetrich commented on code in PR #12534:
URL: https://github.com/apache/kafka/pull/12534#discussion_r949867626
##
core/src/main/scala/kafka/server/ControllerServer.scala:
##
@@ -78,18 +78,18 @@ class ControllerServer(
val awaitShutdownCond = lock.newCondition()
var statu
mdedetrich commented on code in PR #12534:
URL: https://github.com/apache/kafka/pull/12534#discussion_r949867626
##
core/src/main/scala/kafka/server/ControllerServer.scala:
##
@@ -78,18 +78,18 @@ class ControllerServer(
val awaitShutdownCond = lock.newCondition()
var statu
68 matches
Mail list logo