[GitHub] [kafka] FreerXY closed pull request #12419: fix KAFKA-14082

FreerXY closed pull request #12419: fix KAFKA-14082 URL: https://github.com/apache/kafka/pull/12419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira

[GitHub] [kafka] C0urante commented on a diff in pull request #12444: KAFKA-14101: Improve documentation for consuming from embedded Kafka cluster topics in Connect integration testing framework

C0urante commented on code in PR #12444: URL: https://github.com/apache/kafka/pull/12444#discussion_r933894953 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExampleConnectIntegrationTest.java: ## @@ -157,7 +157,7 @@ public void testSinkConnector() throws

[jira] [Assigned] (KAFKA-13530) Flaky test ReplicaManagerTest

[ https://issues.apache.org/jira/browse/KAFKA-13530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthew de Detrich reassigned KAFKA-13530: -- Assignee: Matthew de Detrich > Flaky test ReplicaManagerTest > --

[jira] [Commented] (KAFKA-13530) Flaky test ReplicaManagerTest

[ https://issues.apache.org/jira/browse/KAFKA-13530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573282#comment-17573282 ] Matthew de Detrich commented on KAFKA-13530: So I tried to simulate this tes

[GitHub] [kafka] YeonCheolGit commented on a diff in pull request #11608: KAFKA-13533: Clean up resources on failed connector and task startup

YeonCheolGit commented on code in PR #11608: URL: https://github.com/apache/kafka/pull/11608#discussion_r933841207 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/Closeables.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [kafka] YeonCheolGit commented on a diff in pull request #12444: KAFKA-14101: Improve documentation for consuming from embedded Kafka cluster topics in Connect integration testing framework

YeonCheolGit commented on code in PR #12444: URL: https://github.com/apache/kafka/pull/12444#discussion_r933815183 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExampleConnectIntegrationTest.java: ## @@ -157,7 +157,7 @@ public void testSinkConnector() thr

[GitHub] [kafka] YeonCheolGit commented on a diff in pull request #12444: KAFKA-14101: Improve documentation for consuming from embedded Kafka cluster topics in Connect integration testing framework

YeonCheolGit commented on code in PR #12444: URL: https://github.com/apache/kafka/pull/12444#discussion_r933815183 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExampleConnectIntegrationTest.java: ## @@ -157,7 +157,7 @@ public void testSinkConnector() thr

[GitHub] [kafka] YeonCheolGit commented on a diff in pull request #12444: KAFKA-14101: Improve documentation for consuming from embedded Kafka cluster topics in Connect integration testing framework

YeonCheolGit commented on code in PR #12444: URL: https://github.com/apache/kafka/pull/12444#discussion_r933815183 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExampleConnectIntegrationTest.java: ## @@ -157,7 +157,7 @@ public void testSinkConnector() thr

[GitHub] [kafka] YeonCheolGit commented on pull request #12019: KAFKA-13764: Improve balancing algorithm for Connect incremental rebalancing

YeonCheolGit commented on PR #12019: URL: https://github.com/apache/kafka/pull/12019#issuecomment-1200166542 > Converting this to a draft since I haven't had time to prioritize it (sorry @YeonCheolGit!) and the changes here are not safe to merge as-are. No worries @C0urante! All good

[GitHub] [kafka] zigarn commented on pull request #12434: KAFKA-14099 - Fix request logs in connect

zigarn commented on PR #12434: URL: https://github.com/apache/kafka/pull/12434#issuecomment-1200115924 @C0urante: what about using the existing scala implementation `kafka.utils.LogCaptureAppender`? I added a commit to try it and it works. May add some methods in scala implementation for

[GitHub] [kafka] dplavcic commented on pull request #12459: KAFKA-13036: Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTest

dplavcic commented on PR #12459: URL: https://github.com/apache/kafka/pull/12459#issuecomment-1200109402 Regarding "Notes to help the reviewers": > 1. Mockito does not have `verifyAll()` hence each mocked function call needs to be verified individually. This depends on the `strictn