ashmeet13 commented on PR #12414:
URL: https://github.com/apache/kafka/pull/12414#issuecomment-1192244910
Hi @dengziming, could you review this once more? I have made the requested
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/KAFKA-14088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569832#comment-17569832
]
Gao Fei commented on KAFKA-14088:
-
Later, by looking at the kafka source code and combin
clolov commented on PR #12285:
URL: https://github.com/apache/kafka/pull/12285#issuecomment-1192206399
I don't know, but I can have a look in the upcoming days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
showuon commented on PR #12347:
URL: https://github.com/apache/kafka/pull/12347#issuecomment-1192143782
@jsancio , sorry, I just found it's been passed the feature freeze date. But
I think this PR is only adding metrics in log manager, it should fine to
backport to 3.3. But let me know if y
showuon commented on PR #12347:
URL: https://github.com/apache/kafka/pull/12347#issuecomment-1192133846
Backport to 3.3 branch. cc @jsancio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
[
https://issues.apache.org/jira/browse/KAFKA-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-13917:
--
Fix Version/s: 3.2.1
> Avoid calling lookupCoordinator() in tight loop
> -
showuon merged PR #12347:
URL: https://github.com/apache/kafka/pull/12347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on PR #12347:
URL: https://github.com/apache/kafka/pull/12347#issuecomment-1192128184
Failed tests are unrelated and also failed in trunk build:
```
Build / JDK 8 and Scala 2.12 /
kafka.server.DynamicBrokerReconfigurationTest.testKeyStoreAlter()
Build / JDK
showuon commented on PR #12417:
URL: https://github.com/apache/kafka/pull/12417#issuecomment-1192099004
Sorry, I didn't notice it until now. Thanks for help review and merge,
@mumrah !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
artemlivshits commented on PR #12365:
URL: https://github.com/apache/kafka/pull/12365#issuecomment-1192047420
Hi @etolbakov, making this method private sounds reasonable to me. Thank
you for suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the me
mumrah merged PR #12417:
URL: https://github.com/apache/kafka/pull/12417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
mumrah commented on PR #12417:
URL: https://github.com/apache/kafka/pull/12417#issuecomment-1192043608
Looks like the test failures are unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
cmccabe merged PR #12396:
URL: https://github.com/apache/kafka/pull/12396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
lihaosky commented on code in PR #12166:
URL: https://github.com/apache/kafka/pull/12166#discussion_r927167240
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -226,9 +226,10 @@ private void emitNonJoinedOuterRecords(
lihaosky commented on code in PR #12166:
URL: https://github.com/apache/kafka/pull/12166#discussion_r927166898
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java:
##
@@ -333,6 +352,87 @@ public void shouldJoinWithCustomStoreSuppliers(
[
https://issues.apache.org/jira/browse/KAFKA-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569715#comment-17569715
]
Chris Egerton commented on KAFKA-14089:
---
Thanks Mickael. I put together a draft fi
C0urante opened a new pull request, #12429:
URL: https://github.com/apache/kafka/pull/12429
[Jira](https://issues.apache.org/jira/browse/KAFKA-14089)
This is a potential fix for the flakiness in the
`ExactlyOnceSourceIntegrationTest::testSeparateOffsetsTopic` test. There's also
a few
badaiaqrandista commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r927148782
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -591,6 +591,11 @@ void pollSelectionKeys(Set selectionKeys,
long n
badaiaqrandista commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r927148782
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -591,6 +591,11 @@ void pollSelectionKeys(Set selectionKeys,
long n
badaiaqrandista commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r927148782
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -591,6 +591,11 @@ void pollSelectionKeys(Set selectionKeys,
long n
badaiaqrandista commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r927123903
##
core/src/test/scala/unit/kafka/network/SocketServerTest.scala:
##
@@ -1878,6 +1878,98 @@ class SocketServerTest {
}, false)
}
+ /**
+ * Tests for
badaiaqrandista commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r927123562
##
core/src/test/scala/unit/kafka/network/SocketServerTest.scala:
##
@@ -1878,6 +1878,98 @@ class SocketServerTest {
}, false)
}
+ /**
+ * Tests for
badaiaqrandista commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r927123679
##
core/src/test/scala/unit/kafka/network/SocketServerTest.scala:
##
@@ -1878,6 +1878,98 @@ class SocketServerTest {
}, false)
}
+ /**
+ * Tests for
badaiaqrandista commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r927098320
##
core/src/test/scala/unit/kafka/network/SocketServerTest.scala:
##
@@ -1878,6 +1878,98 @@ class SocketServerTest {
}, false)
}
+ /**
+ * Tests for
badaiaqrandista commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r927095680
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -591,6 +591,11 @@ void pollSelectionKeys(Set selectionKeys,
long n
badaiaqrandista commented on code in PR #12416:
URL: https://github.com/apache/kafka/pull/12416#discussion_r927095680
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -591,6 +591,11 @@ void pollSelectionKeys(Set selectionKeys,
long n
Justine Olshan created KAFKA-14097:
--
Summary: Separate configuration for producer ID expiry
Key: KAFKA-14097
URL: https://issues.apache.org/jira/browse/KAFKA-14097
Project: Kafka
Issue Type
akatona84 commented on PR #11565:
URL: https://github.com/apache/kafka/pull/11565#issuecomment-1191893077
@urbandan , @lhunyady I've reworked the change, now it has the timeout
exception and timeout based retries (instead of retry counts).
Could you guys take a look please?
--
This is
guozhangwang merged PR #12427:
URL: https://github.com/apache/kafka/pull/12427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
guozhangwang commented on code in PR #12427:
URL: https://github.com/apache/kafka/pull/12427#discussion_r927038139
##
streams/src/test/java/org/apache/kafka/test/StreamsTestUtils.java:
##
@@ -273,4 +281,70 @@ public static boolean isCheckSupplierCall() {
return Arrays.s
guozhangwang commented on PR #12428:
URL: https://github.com/apache/kafka/pull/12428#issuecomment-1191841287
Merged to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
guozhangwang merged PR #12428:
URL: https://github.com/apache/kafka/pull/12428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
guozhangwang commented on code in PR #12397:
URL: https://github.com/apache/kafka/pull/12397#discussion_r927019010
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java:
##
@@ -262,51 +294,30 @@ Collection tasks(final Collection taskIds) {
// TO
cmccabe commented on PR #12396:
URL: https://github.com/apache/kafka/pull/12396#issuecomment-1191834126
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
cmccabe commented on PR #12396:
URL: https://github.com/apache/kafka/pull/12396#issuecomment-1191834062
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
[
https://issues.apache.org/jira/browse/KAFKA-14096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Azama updated KAFKA-14096:
---
Description:
We've recently encountered what appears to be a race condition that can lead to
disk b
[
https://issues.apache.org/jira/browse/KAFKA-14096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Azama updated KAFKA-14096:
---
Description:
We've recently encountered what appears to be a race condition that can lead to
disk b
Eric Azama created KAFKA-14096:
--
Summary: Race Condition in Log Rolling Leading to Disk Failure
Key: KAFKA-14096
URL: https://issues.apache.org/jira/browse/KAFKA-14096
Project: Kafka
Issue Type:
lihaosky commented on PR #12428:
URL: https://github.com/apache/kafka/pull/12428#issuecomment-1191770729
@suhas-satish , good point. That JIRA ticket is internal, let me paste the
comments there.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
suhas-satish commented on PR #12428:
URL: https://github.com/apache/kafka/pull/12428#issuecomment-1191745715
@lihaosky , can you reference the jira ticket with discussion as rationale
for this change either in this PR or in the code as comments ? Thanks for the
fix
--
This is an automat
Mickael Maison created KAFKA-14095:
--
Summary: Improve handling of sync offset failures in MirrorMaker
Key: KAFKA-14095
URL: https://issues.apache.org/jira/browse/KAFKA-14095
Project: Kafka
I
lihaosky opened a new pull request, #12428:
URL: https://github.com/apache/kafka/pull/12428
### Description
In this test, when third proc join, sometimes there are other rebalance
scenarios such as followup joingroup request happens before syncgroup response
was received by one of the pr
[
https://issues.apache.org/jira/browse/KAFKA-13700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569563#comment-17569563
]
Jun Rao edited comment on KAFKA-13700 at 7/21/22 5:04 PM:
--
Inte
[
https://issues.apache.org/jira/browse/KAFKA-13700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569563#comment-17569563
]
Jun Rao commented on KAFKA-13700:
-
Interesting. So the CRC validation passes with DumpLo
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569561#comment-17569561
]
Mickael Maison commented on KAFKA-13868:
[~junrao] Yes the email was sent to the
[
https://issues.apache.org/jira/browse/KAFKA-13868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569525#comment-17569525
]
Jun Rao commented on KAFKA-13868:
-
[~mimaison] : You mentioned "As per the email sent to
José Armando García Sancio created KAFKA-14094:
--
Summary: KIP-853: KRaft Voters Change
Key: KAFKA-14094
URL: https://issues.apache.org/jira/browse/KAFKA-14094
Project: Kafka
Issu
cadonna commented on code in PR #12427:
URL: https://github.com/apache/kafka/pull/12427#discussion_r926852811
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdaterTest.java:
##
@@ -129,7 +128,7 @@ public void shouldThrowIfStatelessTaskNotInSta
cadonna opened a new pull request, #12427:
URL: https://github.com/apache/kafka/pull/12427
This PR introduces an internal config to enable the state updater.
If the state updater is enabled newly created tasks are added to
the state updater.
The integration of the state updat
[
https://issues.apache.org/jira/browse/KAFKA-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Viktor Somogyi-Vass updated KAFKA-13917:
Affects Version/s: 3.3.0
3.2.1
> Avoid calling lookupCoordi
cadonna commented on PR #12285:
URL: https://github.com/apache/kafka/pull/12285#issuecomment-1191644117
@clolov @divijvaidya I just checked and these tests are not run in the
builds. I have also another PR in streams with tests that use junit5 and they
are also not run in the builds. Does a
cadonna merged PR #12285:
URL: https://github.com/apache/kafka/pull/12285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cadonna commented on PR #12285:
URL: https://github.com/apache/kafka/pull/12285#issuecomment-1191623444
Failures are not related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
[
https://issues.apache.org/jira/browse/KAFKA-14076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14076:
Affects Version/s: 3.3.0
> Fix issues with KafkaStreams.CloseOptions
> ---
mjsax commented on PR #12408:
URL: https://github.com/apache/kafka/pull/12408#issuecomment-1191570949
Thanks for the fix. Merged to `trunk` and cherry-picked to `3.3` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mjsax merged PR #12408:
URL: https://github.com/apache/kafka/pull/12408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
cadonna merged PR #12397:
URL: https://github.com/apache/kafka/pull/12397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cadonna commented on PR #12397:
URL: https://github.com/apache/kafka/pull/12397#issuecomment-1191467025
Build failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
cadonna merged PR #12426:
URL: https://github.com/apache/kafka/pull/12426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
soarez commented on PR #12314:
URL: https://github.com/apache/kafka/pull/12314#issuecomment-1191462380
@mumrah a couple of the builds succeeded but some failed with a flaky test —
`testFencedLeaderRecovery`. There is already a JIRA for it
https://issues.apache.org/jira/browse/KAFKA-14093
cadonna commented on PR #12285:
URL: https://github.com/apache/kafka/pull/12285#issuecomment-1191451288
Once I get acceptable builds, I am going to merge this PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
clolov commented on PR #12285:
URL: https://github.com/apache/kafka/pull/12285#issuecomment-1191436663
Hey @cadonna, I rebased on top of trunk. Do let me know if there is
something else you would like me to address :)
--
This is an automated message from the Apache Git Service.
To respond
etolbakov commented on PR #12365:
URL: https://github.com/apache/kafka/pull/12365#issuecomment-1191436621
Hello Artem @artemlivshits,
I was studying the PR/`KAFKA-14020` ticket and decided to share a minor
observation.
It seems that `extractTopicPartition` method from `ProducerInte
clolov commented on code in PR #12285:
URL: https://github.com/apache/kafka/pull/12285#discussion_r926625230
##
streams/src/test/java/org/apache/kafka/streams/integration/ErrorHandlingIntegrationTest.java:
##
@@ -52,36 +52,46 @@
import static org.hamcrest.CoreMatchers.equalTo;
C0urante commented on PR #11783:
URL: https://github.com/apache/kafka/pull/11783#issuecomment-1191429850
Out of the 100 runs, 94 passed. The 6 failures all appear to be
environmental as they were encountered while trying to allocate a console
consumer at the end of the test with this stack
jnh5y commented on code in PR #12408:
URL: https://github.com/apache/kafka/pull/12408#discussion_r926562692
##
streams/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsCloseOptionsIntegrationTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache Software Fo
[
https://issues.apache.org/jira/browse/KAFKA-13953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569354#comment-17569354
]
Doguscan Namal commented on KAFKA-13953:
I tried to reproduce the issue by sendi
mimaison opened a new pull request, #12426:
URL: https://github.com/apache/kafka/pull/12426
Also fix `Transforming Data Pt. 2` video title
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
[
https://issues.apache.org/jira/browse/KAFKA-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569318#comment-17569318
]
Mickael Maison commented on KAFKA-14093:
I've only been able to reproduce it onc
cadonna commented on code in PR #12397:
URL: https://github.com/apache/kafka/pull/12397#discussion_r926372626
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java:
##
@@ -262,51 +294,30 @@ Collection tasks(final Collection taskIds) {
// TODO: c
[
https://issues.apache.org/jira/browse/KAFKA-14093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569313#comment-17569313
]
Mickael Maison commented on KAFKA-14093:
cc [~ChrisEgerton]
> Flaky ExactlyOnce
Mickael Maison created KAFKA-14093:
--
Summary: Flaky
ExactlyOnceSourceIntegrationTest.testFencedLeaderRecovery
Key: KAFKA-14093
URL: https://issues.apache.org/jira/browse/KAFKA-14093
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569309#comment-17569309
]
Mickael Maison commented on KAFKA-14089:
I've hit this issue locally and I can r
[
https://issues.apache.org/jira/browse/KAFKA-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-14089:
---
Attachment:
org.apache.kafka.connect.integration.ExactlyOnceSourceIntegrationTest.testSepara
[
https://issues.apache.org/jira/browse/KAFKA-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569291#comment-17569291
]
Bruno Cadonna commented on KAFKA-14090:
---
I think this would be covered by
[KIP-69
75 matches
Mail list logo
