[GitHub] [kafka] dengziming commented on a diff in pull request #12141: MINOR; DeleteTopics version tests

dengziming commented on code in PR #12141: URL: https://github.com/apache/kafka/pull/12141#discussion_r869904211 ## core/src/test/scala/unit/kafka/server/DeleteTopicsRequestTest.scala: ## @@ -17,24 +17,28 @@ package kafka.server -import java.util.{Arrays, Collections} - +im

[GitHub] [kafka] chernyih commented on pull request #12131: KAFKA-13879: Reconnect exponential backoff is ineffective in some cases

chernyih commented on PR #12131: URL: https://github.com/apache/kafka/pull/12131#issuecomment-1123211008 Retry backoff doesn't help. `KafkaAdminClient` fetches metadata from bootstrap server, let's say with a call timeout of 5s. Within 5s, `NetworkClient` can connect to the bootstrap server

[GitHub] [kafka] ijuma commented on a diff in pull request #12097: MINOR: Make TopicPartitionBookkeeper and TopicPartitionEntry top level

ijuma commented on code in PR #12097: URL: https://github.com/apache/kafka/pull/12097#discussion_r869841007 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TxnPartitionMap.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] ijuma commented on pull request #12144: MINOR: reload4j build dependency fixes

ijuma commented on PR #12144: URL: https://github.com/apache/kafka/pull/12144#issuecomment-1123142383 Merged to trunk and cherry-picked to 3.2 and 3.1 branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] ijuma commented on a diff in pull request #12146: MINOR: Remove kraft authorizer from list of missing features

ijuma commented on code in PR #12146: URL: https://github.com/apache/kafka/pull/12146#discussion_r869838507 ## config/kraft/README.md: ## @@ -114,9 +114,7 @@ We don't support any kind of upgrade right now, either to or from KRaft mode. T Finally, the following Kafka feature

[GitHub] [kafka] showuon commented on pull request #12112: MINOR: Fix flaky testDescribeUnderReplicatedPartitions

showuon commented on PR #12112: URL: https://github.com/apache/kafka/pull/12112#issuecomment-1123139779 @dengziming , thanks for the update! @divijvaidya , if you have no other comments, I'm going to merge this PR within this week. Thank you. -- This is an automated message from th

[GitHub] [kafka] C0urante commented on pull request #12041: MINOR: ignore unused configuration when ConsumerCoordinator is not constructed

C0urante commented on PR #12041: URL: https://github.com/apache/kafka/pull/12041#issuecomment-1123137976 @guozhangwang to be clear, nobody is advocating that we call `ignore` on everything. I was proposing that we call `ignore` on everything that's already defined, which is pretty clear if

[GitHub] [kafka] dengziming commented on a diff in pull request #12062: KAFKA-13833: Remove the min_version_level from the finalized version written to ZooKeeper

dengziming commented on code in PR #12062: URL: https://github.com/apache/kafka/pull/12062#discussion_r869835226 ## core/src/main/scala/kafka/server/ApiVersionManager.scala: ## @@ -86,15 +86,15 @@ class DefaultApiVersionManager( throttleTimeMs, interBrokerProto

[GitHub] [kafka] ijuma merged pull request #12144: MINOR: reload4j build dependency fixes

ijuma merged PR #12144: URL: https://github.com/apache/kafka/pull/12144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] dengziming commented on pull request #12104: KAFKA-13746: Attempt to fix flaky test by waiting to fetch 2 topics f…

dengziming commented on PR #12104: URL: https://github.com/apache/kafka/pull/12104#issuecomment-1123116129 Hello @vamossagar12, sorry for changing around, we added a `TestUtils.ensureConsistentKRaftMetadata` in #12108 to fix this kind of flakiness, which waits until the brokers have caught

[GitHub] [kafka] dengziming commented on pull request #12112: MINOR: Fix flaky testDescribeUnderReplicatedPartitions

dengziming commented on PR #12112: URL: https://github.com/apache/kafka/pull/12112#issuecomment-1123114260 Hello @showuon @divijvaidya, #12108 has been merged, we added `TestUtils.ensureConsistentKRaftMetadata` to fix all this type of flakiness, PTAL. -- This is an automated message from

[GitHub] [kafka] ijuma commented on a diff in pull request #12097: MINOR: Make TopicPartitionBookkeeper and TopicPartitionEntry top level

ijuma commented on code in PR #12097: URL: https://github.com/apache/kafka/pull/12097#discussion_r869795034 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TxnPartitionBookkeeper.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [kafka] hachikuji commented on a diff in pull request #12097: MINOR: Make TopicPartitionBookkeeper and TopicPartitionEntry top level

hachikuji commented on code in PR #12097: URL: https://github.com/apache/kafka/pull/12097#discussion_r869776847 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TxnPartitionBookkeeper.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [kafka] cmccabe commented on a diff in pull request #11969: KAFKA-13649: Implement early.start.listeners and fix StandardAuthorizer loading

cmccabe commented on code in PR #11969: URL: https://github.com/apache/kafka/pull/11969#discussion_r869766209 ## core/src/main/scala/kafka/network/SocketServer.scala: ## @@ -1864,6 +1780,18 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metrics: Metrics) extend

[jira] [Resolved] (KAFKA-7527) Enable Dependency Injection for Kafka Streams handlers (KIP-378)

[ https://issues.apache.org/jira/browse/KAFKA-7527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-7527. Resolution: Fixed > Enable Dependency Injection for Kafka Streams handlers (KIP-378) >

[GitHub] [kafka] mjsax commented on a diff in pull request #12122: WIP: Upgrade tests for KAFKA-13769

mjsax commented on code in PR #12122: URL: https://github.com/apache/kafka/pull/12122#discussion_r869751965 ## streams/upgrade-system-tests-31/src/test/java/org/apache/kafka/streams/tests/StreamsUpgradeTest.java: ## @@ -63,21 +80,30 @@ public static void main(final String[] args

[GitHub] [kafka] ijuma commented on pull request #12131: KAFKA-13879: Reconnect exponential backoff is ineffective in some cases

ijuma commented on PR #12131: URL: https://github.com/apache/kafka/pull/12131#issuecomment-1122986117 Thanks for the PR. One question: did retry backoff help in this case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] mjsax commented on a diff in pull request #12135: KAFKA-13785: [7/N][Emit final] emit final for sliding window

mjsax commented on code in PR #12135: URL: https://github.com/apache/kafka/pull/12135#discussion_r869501138 ## streams/src/main/java/org/apache/kafka/streams/kstream/EmitStrategy.java: ## @@ -19,15 +19,52 @@ import org.apache.kafka.streams.kstream.internals.UnlimitedWindow; im

[jira] [Assigned] (KAFKA-13817) Schedule nextTimeToEmit to system time every time instead of just once

[ https://issues.apache.org/jira/browse/KAFKA-13817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakub Miroś reassigned KAFKA-13817: --- Assignee: (was: Jakub Miroś) > Schedule nextTimeToEmit to system time every time instea

[jira] [Commented] (KAFKA-13892) Dedupe RemoveAccessControlEntryRecord in deleteAcls of AclControlManager

[ https://issues.apache.org/jira/browse/KAFKA-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534600#comment-17534600 ] Andrew Grant commented on KAFKA-13892: -- Merged in https://github.com/apache/kafka/

[jira] [Resolved] (KAFKA-13892) Dedupe RemoveAccessControlEntryRecord in deleteAcls of AclControlManager

[ https://issues.apache.org/jira/browse/KAFKA-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grant resolved KAFKA-13892. -- Resolution: Fixed > Dedupe RemoveAccessControlEntryRecord in deleteAcls of AclControlManager >

[jira] [Assigned] (KAFKA-13817) Schedule nextTimeToEmit to system time every time instead of just once

[ https://issues.apache.org/jira/browse/KAFKA-13817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakub Miroś reassigned KAFKA-13817: --- Assignee: Jakub Miroś > Schedule nextTimeToEmit to system time every time instead of just o

[jira] [Resolved] (KAFKA-13879) Exponential backoff for reconnect does not work

[ https://issues.apache.org/jira/browse/KAFKA-13879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chern Yih Cheah resolved KAFKA-13879. - Resolution: Fixed > Exponential backoff for reconnect does not work > --

[GitHub] [kafka] cmccabe merged pull request #12145: KAFKA-13892: Dedupe RemoveAccessControlEntryRecord in deleteAcls response of AclControlManager

cmccabe merged PR #12145: URL: https://github.com/apache/kafka/pull/12145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

ahuang98 commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r869715273 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -70,13 +47,17 @@ object StorageTool extends Logging { case "format" => val directories =

[GitHub] [kafka] ijuma opened a new pull request, #12146: MINOR: Remove kraft authorizer from list of missing features

ijuma opened a new pull request, #12146: URL: https://github.com/apache/kafka/pull/12146 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes)

[GitHub] [kafka] ahuang98 commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

ahuang98 commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r869544110 ## clients/src/main/java/org/apache/kafka/clients/NodeApiVersions.java: ## @@ -91,6 +97,23 @@ public static NodeApiVersions create(short apiKey, short minVersion, shor

[GitHub] [kafka] andymg3 commented on a diff in pull request #12145: KAFKA-13892: Dedupe RemoveAccessControlEntryRecord in deleteAcls response of AclControlManager

andymg3 commented on code in PR #12145: URL: https://github.com/apache/kafka/pull/12145#discussion_r869680507 ## metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java: ## @@ -152,7 +154,11 @@ ControllerResult> deleteAcls(List filter results.

[jira] [Commented] (KAFKA-13621) Resign leader on network partition

[ https://issues.apache.org/jira/browse/KAFKA-13621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534578#comment-17534578 ] Jose Armando Garcia Sancio commented on KAFKA-13621: [~hachikuji] me

[GitHub] [kafka] hachikuji commented on a diff in pull request #11969: KAFKA-13649: Implement early.start.listeners and fix StandardAuthorizer loading

hachikuji commented on code in PR #11969: URL: https://github.com/apache/kafka/pull/11969#discussion_r868498298 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -725,7 +727,11 @@ object KafkaConfig { /* Authorizer Configuration ***/ val Au

[GitHub] [kafka] mumrah commented on a diff in pull request #12062: KAFKA-13833: Remove the min_version_level from the finalized version written to ZooKeeper

mumrah commented on code in PR #12062: URL: https://github.com/apache/kafka/pull/12062#discussion_r869578975 ## core/src/main/scala/kafka/server/ApiVersionManager.scala: ## @@ -86,15 +86,15 @@ class DefaultApiVersionManager( throttleTimeMs, interBrokerProtocolV

[GitHub] [kafka] hachikuji merged pull request #12082: MINOR: Create case class to encapsulate fetch parameters and simplify handling

hachikuji merged PR #12082: URL: https://github.com/apache/kafka/pull/12082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] cmccabe commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

cmccabe commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r869639379 ## clients/src/main/java/org/apache/kafka/clients/NodeApiVersions.java: ## @@ -233,4 +256,8 @@ public ApiVersion apiVersion(ApiKeys apiKey) { public Map allSupporte

[GitHub] [kafka] hachikuji commented on a diff in pull request #12145: KAFKA-13892: Dedupe RemoveAccessControlEntryRecord in deleteAcls response of AclControlManager

hachikuji commented on code in PR #12145: URL: https://github.com/apache/kafka/pull/12145#discussion_r869633002 ## metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java: ## @@ -152,7 +154,11 @@ ControllerResult> deleteAcls(List filter result

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r869631802 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -55,25 +60,37 @@ public class FeatureControlManager { */ private final

[GitHub] [kafka] cmccabe commented on pull request #12145: KAFKA-13892: Dedupe RemoveAccessControlEntryRecord in deleteAcls response of AclControlManager

cmccabe commented on PR #12145: URL: https://github.com/apache/kafka/pull/12145#issuecomment-1122797307 > I don't think we need to dedupe List. It contains a list of results, where each result contains the ACLs that matched the filter. It should be OK for the same ACL to be in multiple AclD

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r869621801 ## core/src/main/scala/kafka/server/ControllerServer.scala: ## @@ -63,6 +64,8 @@ class ControllerServer( val threadNamePrefix: Option[String], val controllerQuorumV

[GitHub] [kafka] cmccabe merged pull request #12142: MINOR: install Exit.exit handler in BrokerMetadataPublisherTest

cmccabe merged PR #12142: URL: https://github.com/apache/kafka/pull/12142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Resolved] (KAFKA-13862) Add And Subtract multiple config values is not supported in KRaft mode

[ https://issues.apache.org/jira/browse/KAFKA-13862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13862. - Fix Version/s: 3.3.0 Resolution: Fixed > Add And Subtract multiple config values

[GitHub] [kafka] hachikuji merged pull request #12108: KAFKA-13862: Support Append/Subtract multiple config values in KRaft mode

hachikuji merged PR #12108: URL: https://github.com/apache/kafka/pull/12108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] andymg3 opened a new pull request, #12145: KAFKA-13892: Dedupe RemoveAccessControlEntryRecord in deleteAcls response of AclControlManager

andymg3 opened a new pull request, #12145: URL: https://github.com/apache/kafka/pull/12145 ## JIRA https://issues.apache.org/jira/browse/KAFKA-13892 ### Details In https://github.com/apache/kafka/blob/trunk/metadata/src/main/java/org/apache/kafka/controller/AclControlManager.jav

[jira] [Commented] (KAFKA-13892) Dedupe RemoveAccessControlEntryRecord in deleteAcls of AclControlManager

[ https://issues.apache.org/jira/browse/KAFKA-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534543#comment-17534543 ] Andrew Grant commented on KAFKA-13892: -- I dont think we need to dedupe List. It con

[jira] [Updated] (KAFKA-13892) Dedupe RemoveAccessControlEntryRecord in deleteAcls of AclControlManager

[ https://issues.apache.org/jira/browse/KAFKA-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grant updated KAFKA-13892: - Summary: Dedupe RemoveAccessControlEntryRecord in deleteAcls of AclControlManager (was: Dedupe

[jira] [Assigned] (KAFKA-13892) Dedupe response objects in deleteAcls of AclControlManager

[ https://issues.apache.org/jira/browse/KAFKA-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grant reassigned KAFKA-13892: Assignee: Andrew Grant > Dedupe response objects in deleteAcls of AclControlManager > --

[GitHub] [kafka] ijuma opened a new pull request, #12144: MINOR: reload4j dependency fixes

ijuma opened a new pull request, #12144: URL: https://github.com/apache/kafka/pull/12144 * Replace `log4j` with `reload4j` in `copyDependantLibs` * Exclude `log4j` and `slf4j-log4j12` transitive dependencies for 'streams:upgrade-system-tests`. Versions 0100 and 0101 had a transit

[jira] [Created] (KAFKA-13892) Dedupe response objects in deleteAcls of AclControlManager

Andrew Grant created KAFKA-13892: Summary: Dedupe response objects in deleteAcls of AclControlManager Key: KAFKA-13892 URL: https://issues.apache.org/jira/browse/KAFKA-13892 Project: Kafka

[GitHub] [kafka] mumrah commented on pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on PR #12050: URL: https://github.com/apache/kafka/pull/12050#issuecomment-1122497005 @dengziming addressing your old comment: > Thank you for this PR @mumrah , I have a question: should we bump IBP from 3.2-0 to 3.2-1, then in the future when migrating ZooKeeper clus

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r869326805 ## core/src/main/scala/kafka/server/KafkaRaftServer.scala: ## @@ -102,6 +106,8 @@ class KafkaRaftServer( threadNamePrefix, controllerQuorumVotersFuture,

[GitHub] [kafka] Gerrrr commented on pull request #12122: WIP: Upgrade tests for KAFKA-13769

Ge commented on PR #12122: URL: https://github.com/apache/kafka/pull/12122#issuecomment-1122378479 @mjsax Can you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka] showuon commented on a diff in pull request #12140: KAFKA-13891: reset generation when syncgroup failed with REBALANCE_IN_PROGRESS

showuon commented on code in PR #12140: URL: https://github.com/apache/kafka/pull/12140#discussion_r869204407 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -807,6 +807,7 @@ public void handle(SyncGroupResponse syncResponse,

[GitHub] [kafka] cadonna merged pull request #12143: MINOR: Update release versions for upgrade tests with ongoing release

cadonna merged PR #12143: URL: https://github.com/apache/kafka/pull/12143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] aiquestion commented on pull request #12140: KAFKA-13891: reset generation when syncgroup failed with REBALANCE_IN_PROGRESS

aiquestion commented on PR #12140: URL: https://github.com/apache/kafka/pull/12140#issuecomment-1122343498 @[showuon](https://github.com/showuon) can you please help to review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] viktorsomogyi closed pull request #9519: KAFKA-10650: Use Murmur3 instead of MD5 in SkimpyOffsetMap

viktorsomogyi closed pull request #9519: KAFKA-10650: Use Murmur3 instead of MD5 in SkimpyOffsetMap URL: https://github.com/apache/kafka/pull/9519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] viktorsomogyi commented on pull request #9519: KAFKA-10650: Use Murmur3 instead of MD5 in SkimpyOffsetMap

viktorsomogyi commented on PR #9519: URL: https://github.com/apache/kafka/pull/9519#issuecomment-1122331820 Closing this due to inactivity from reviewers' part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] aiquestion commented on pull request #12140: KAFKA-13891: reset generation when syncgroup failed with REBALANCE_IN_PROGRESS

aiquestion commented on PR #12140: URL: https://github.com/apache/kafka/pull/12140#issuecomment-1122315793 created a jira for it: https://issues.apache.org/jira/browse/KAFKA-13891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[jira] [Created] (KAFKA-13891) sync group failed with rebalanceInProgress error cause rebalance many rounds in coopeartive

Shawn Wang created KAFKA-13891: -- Summary: sync group failed with rebalanceInProgress error cause rebalance many rounds in coopeartive Key: KAFKA-13891 URL: https://issues.apache.org/jira/browse/KAFKA-13891

[GitHub] [kafka] rajinisivaram merged pull request #12131: KAFKA-13879: Reconnect exponential backoff is ineffective in some cases

rajinisivaram merged PR #12131: URL: https://github.com/apache/kafka/pull/12131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.a

[GitHub] [kafka] rajinisivaram commented on pull request #12131: KAFKA-13879: Reconnect exponential backoff is ineffective in some cases

rajinisivaram commented on PR #12131: URL: https://github.com/apache/kafka/pull/12131#issuecomment-1122212951 @chernyih Thanks for the PR, LGTM. Seems like a reasonable change since we are just ensuring that backoff is applied unless ApiVersions response is received. Since we were applying

[GitHub] [kafka] cadonna opened a new pull request, #12143: MINOR: Update release versions for upgrade tests with ongoing release

cadonna opened a new pull request, #12143: URL: https://github.com/apache/kafka/pull/12143 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade n

[GitHub] [kafka] sayantanu-dey commented on pull request #12035: KAFKA-13217: Reconsider skipping the LeaveGroup on close() or add an overload that does so

sayantanu-dey commented on PR #12035: URL: https://github.com/apache/kafka/pull/12035#issuecomment-1122126444 @guozhangwang @dajac sorry for being late, I went through the whole conversation and I have pushed the changes suggested. 1. Now I am returning the `close` status after resolving