ijuma commented on code in PR #12133:
URL: https://github.com/apache/kafka/pull/12133#discussion_r867311365
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -363,7 +363,7 @@ public static boolean isEqualConstantTime(char[] first,
char[] second) {
[
https://issues.apache.org/jira/browse/KAFKA-13886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17533200#comment-17533200
]
lqjacklee commented on KAFKA-13886:
---
https://github.com/apache/kafka/pull/12133
> imp
lqjack opened a new pull request, #12133:
URL: https://github.com/apache/kafka/pull/12133
* Improvement the compare logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
lqjacklee created KAFKA-13886:
-
Summary: improve the performance
org.apache.kafka.common.utils.Utils#isEqualConstantTime
Key: KAFKA-13886
URL: https://issues.apache.org/jira/browse/KAFKA-13886
Project: Ka
dengziming commented on code in PR #12108:
URL: https://github.com/apache/kafka/pull/12108#discussion_r867297325
##
core/src/main/scala/kafka/server/ConfigAdminManager.scala:
##
@@ -499,7 +499,8 @@ object ConfigAdminManager {
.orElse(Option(ConfigDef.convertToStrin
lqjack opened a new pull request, #12132:
URL: https://github.com/apache/kafka/pull/12132
*Fix type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-13871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lqjacklee reassigned KAFKA-13871:
-
Assignee: lqjacklee
> The documentation for the configuration item QUORUM_FETCH_TIMEOUT of the
dengziming commented on code in PR #12108:
URL: https://github.com/apache/kafka/pull/12108#discussion_r867294879
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1127,6 +1127,23 @@ object TestUtils extends Logging {
throw new IllegalStateException(s"Cannot
dengziming commented on code in PR #12108:
URL: https://github.com/apache/kafka/pull/12108#discussion_r867294432
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1127,6 +1127,23 @@ object TestUtils extends Logging {
throw new IllegalStateException(s"Cannot
bozhao12 commented on code in PR #12078:
URL: https://github.com/apache/kafka/pull/12078#discussion_r867291272
##
core/src/main/scala/kafka/server/DelayedFetch.scala:
##
@@ -148,8 +148,8 @@ class DelayedFetch(delayMs: Long,
debug(s"Partition $topicIdPartition is in
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r867287314
##
clients/src/test/java/org/apache/kafka/clients/CommonClientConfigsTest.java:
##
@@ -82,4 +102,21 @@ public void testExponentialBackoffDefaults() {
assertEq
dengziming commented on PR #12112:
URL: https://github.com/apache/kafka/pull/12112#issuecomment-1120105686
Let's hold on to this before
[#12108](https://github.com/apache/kafka/pull/12108) was approved.
--
This is an automated message from the Apache Git Service.
To respond to the message
Artem Livshits created KAFKA-13885:
--
Summary: Add new metrics for partitioner logic introduced in
KIP-794
Key: KAFKA-13885
URL: https://issues.apache.org/jira/browse/KAFKA-13885
Project: Kafka
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r867284907
##
clients/src/test/java/org/apache/kafka/clients/CommonClientConfigsTest.java:
##
@@ -82,4 +102,21 @@ public void testExponentialBackoffDefaults() {
assertEq
chernyih opened a new pull request, #12131:
URL: https://github.com/apache/kafka/pull/12131
When a client connects to a SSL listener using PLAINTEXT security protocol,
after the TCP connection is setup, the client considers the channel setup is
complete. In reality the channel setup is
hachikuji commented on code in PR #12108:
URL: https://github.com/apache/kafka/pull/12108#discussion_r867248444
##
core/src/main/scala/kafka/server/ConfigAdminManager.scala:
##
@@ -499,7 +499,8 @@ object ConfigAdminManager {
.orElse(Option(ConfigDef.convertToString
jolshan commented on code in PR #12078:
URL: https://github.com/apache/kafka/pull/12078#discussion_r867234910
##
core/src/main/scala/kafka/server/DelayedFetch.scala:
##
@@ -148,8 +148,8 @@ class DelayedFetch(delayMs: Long,
debug(s"Partition $topicIdPartition is in a
jolshan commented on PR #12121:
URL: https://github.com/apache/kafka/pull/12121#issuecomment-1120023305
I was also wondering -- is this file considered part of the public apis?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
jolshan commented on code in PR #12121:
URL: https://github.com/apache/kafka/pull/12121#discussion_r867226487
##
clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java:
##
@@ -563,10 +615,15 @@ public synchronized void removeReporter(MetricsReporter
reporter) {
jolshan commented on code in PR #12121:
URL: https://github.com/apache/kafka/pull/12121#discussion_r867226334
##
clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java:
##
@@ -524,6 +524,58 @@ public void addMetric(MetricName metricName,
MetricValueProvider metricVa
cmccabe commented on PR #11969:
URL: https://github.com/apache/kafka/pull/11969#issuecomment-1119953102
I made two changes just now:
1. Fixed it so TenantPartitionAssignor ignores fenced brokers, and added a
unit test for this (as we discussed offline)
2. Removed
ClusterMetada
Jose Armando Garcia Sancio created KAFKA-13884:
--
Summary: KRaft Obsever are not required to flush on every append
Key: KAFKA-13884
URL: https://issues.apache.org/jira/browse/KAFKA-13884
Pr
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532518#comment-17532518
]
François Rosière edited comment on KAFKA-13864 at 5/6/22 7:01 PM:
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière updated KAFKA-13864:
-
Description:
To allow implementing Spring managed interceptors for producers and consume
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière updated KAFKA-13864:
-
Description:
To allow implementing Spring managed interceptors for producers and consume
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière updated KAFKA-13864:
-
Description:
To allow implementing Spring managed interceptors for producers and consume
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière updated KAFKA-13864:
-
Description:
To allow implementing Spring managed interceptors for producers and consume
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière updated KAFKA-13864:
-
Description:
To allow implementing Spring managed interceptors for producers and consume
frosiere commented on PR #12125:
URL: https://github.com/apache/kafka/pull/12125#issuecomment-1119923373
@lqjack , based on the discussion thread, the KIP has been updated as follow
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211882578#KIP832:Allowcreatingaproducer/co
[
https://issues.apache.org/jira/browse/KAFKA-10888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-10888.
-
Fix Version/s: 3.3.0
Resolution: Fixed
merged the PR to trunk. Thanks [~alivshits] for the design
junrao merged PR #12049:
URL: https://github.com/apache/kafka/pull/12049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
Jose Armando Garcia Sancio created KAFKA-13883:
--
Summary: KIP-835: Monitor Quorum
Key: KAFKA-13883
URL: https://issues.apache.org/jira/browse/KAFKA-13883
Project: Kafka
Issue Typ
junrao commented on code in PR #12049:
URL: https://github.com/apache/kafka/pull/12049#discussion_r867072573
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1403,25 +1452,54 @@ public boolean isDone() {
}
/**
- * A callback c
mimaison commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r867003730
##
clients/src/test/java/org/apache/kafka/clients/CommonClientConfigsTest.java:
##
@@ -82,4 +102,21 @@ public void testExponentialBackoffDefaults() {
assertEqu
mimaison commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r867002955
##
clients/src/test/java/org/apache/kafka/clients/CommonClientConfigsTest.java:
##
@@ -82,4 +102,21 @@ public void testExponentialBackoffDefaults() {
assertEqu
vvcephei merged PR #12130:
URL: https://github.com/apache/kafka/pull/12130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
hachikuji commented on code in PR #12085:
URL: https://github.com/apache/kafka/pull/12085#discussion_r866948293
##
core/src/test/scala/unit/kafka/cluster/PartitionTest.scala:
##
@@ -2105,6 +2106,203 @@ class PartitionTest extends AbstractPartitionTest {
verify(spyConfigRepo
vvcephei opened a new pull request, #12130:
URL: https://github.com/apache/kafka/pull/12130
A prior commit accidentally changed the javadoc for RecordContext.
In reality, it is not reachable from api.Processor, only Processor.
### Committer Checklist (excluded from commit message)
C0urante commented on PR #11773:
URL: https://github.com/apache/kafka/pull/11773#issuecomment-1119641957
Yep! Got to fix some merge conflicts on that one though; should be ready by
Monday. Thanks Mickael!
--
This is an automated message from the Apache Git Service.
To respond to the messa
bbejeck commented on PR #12129:
URL: https://github.com/apache/kafka/pull/12129#issuecomment-1119607353
Thanks for the fix @cadonna
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
divijvaidya commented on PR #12045:
URL: https://github.com/apache/kafka/pull/12045#issuecomment-1119514099
CC'ing a couple of folks who may be interested to review this.
@mimaison @showuon @dengziming @apovzner @wyuka @satishd
--
This is an automated message from the Apache Git Se
Tom Bentley created KAFKA-13882:
---
Summary: Dockerfile for previewing website
Key: KAFKA-13882
URL: https://issues.apache.org/jira/browse/KAFKA-13882
Project: Kafka
Issue Type: Task
Co
RivenSun2 commented on PR #12010:
URL: https://github.com/apache/kafka/pull/12010#issuecomment-1119480003
Hi @mimaison Thank you for your review.
I just add common testCase, please help to check again.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to
Tom Bentley created KAFKA-13881:
---
Summary: Add package.java for public package javadoc
Key: KAFKA-13881
URL: https://issues.apache.org/jira/browse/KAFKA-13881
Project: Kafka
Issue Type: Task
dengziming commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r866465436
##
clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java:
##
@@ -299,4 +299,30 @@ public static ApiVersion toApiVersion(ApiKeys apiKey) {
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r866686148
##
clients/src/test/java/org/apache/kafka/clients/admin/AdminClientConfigTest.java:
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
mimaison commented on PR #11565:
URL: https://github.com/apache/kafka/pull/11565#issuecomment-1119452581
Sorry for the delay, but this finally made it back to the top of my review
queue.
I'm not sure we necessarily need to do something here. Starting Connect from
scratch when not eno
cadonna commented on PR #12129:
URL: https://github.com/apache/kafka/pull/12129#issuecomment-1119441202
Cherry-picked to 3.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
cadonna merged PR #12129:
URL: https://github.com/apache/kafka/pull/12129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cadonna commented on PR #12129:
URL: https://github.com/apache/kafka/pull/12129#issuecomment-1119439422
@showuon Thanks! They are correct in the current documentation probably
because the release manager fixed the link manually in the kafka-site repo. The
doc is copied over from the kafka r
mimaison merged PR #12028:
URL: https://github.com/apache/kafka/pull/12028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mimaison commented on PR #11773:
URL: https://github.com/apache/kafka/pull/11773#issuecomment-1119416270
Is https://github.com/apache/kafka/pull/11775 the next one to review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mimaison merged PR #11773:
URL: https://github.com/apache/kafka/pull/11773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
divijvaidya commented on PR #12087:
URL: https://github.com/apache/kafka/pull/12087#issuecomment-1119392116
@dengziming @showuon @mimaison please take a look at this minor PR when you
get a chance!
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
mimaison commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r866616320
##
clients/src/test/java/org/apache/kafka/clients/admin/AdminClientConfigTest.java:
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
cadonna commented on PR #12129:
URL: https://github.com/apache/kafka/pull/12129#issuecomment-1119365165
Once merged, the commit needs to be cherry-picked to 3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cadonna commented on PR #12129:
URL: https://github.com/apache/kafka/pull/12129#issuecomment-1119364606
Call for reviews: @bbejeck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
cadonna opened a new pull request, #12129:
URL: https://github.com/apache/kafka/pull/12129
In Kafka's quickstart a link points to the 2.5 Kafka Streams demo.
This PR fixes this link.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
58 matches
Mail list logo
