dengziming commented on PR #12116:
URL: https://github.com/apache/kafka/pull/12116#issuecomment-1115780309
Hello, @ahuang98 I think those tests just belong to
`ApiVersionsResponseTest`, maybe you accidentally copied them to
`MetadataVersionTest` when working on #12072?
--
This is an au
dengziming opened a new pull request, #12116:
URL: https://github.com/apache/kafka/pull/12116
*More detailed description of your change*
Removed some tests in `MetadataVersionTest` which are totally identical to
those in `ApiVersionsResponseTest`.
I think we removed `ApiVersionTest` bu
showuon commented on PR #11889:
URL: https://github.com/apache/kafka/pull/11889#issuecomment-1115770434
> I think the problem here is just to make sure we should provide both
listeners for the combined node, is this right?
Correct. Thanks for your help! :)
--
This is an automated m
showuon commented on code in PR #11983:
URL: https://github.com/apache/kafka/pull/11983#discussion_r863399174
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeConnectProtocol.java:
##
@@ -148,18 +148,18 @@ public class Increment
akhileshchg commented on code in PR #12106:
URL: https://github.com/apache/kafka/pull/12106#discussion_r863475611
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -1364,7 +1364,8 @@ Boolean isBrokerUnfenced(int brokerId) {
akhileshchg commented on code in PR #12106:
URL: https://github.com/apache/kafka/pull/12106#discussion_r863474931
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -499,23 +504,28 @@ class PlaintextAdminIntegrationTest extends
BaseAdminInte
dengziming commented on PR #11889:
URL: https://github.com/apache/kafka/pull/11889#issuecomment-1115729719
@showuon
Oh yeah, I think I misunderstood your intention here. Firstly I think it's
weird to have a config optional for the broker node but mandatory for the
controller node and co
C0urante commented on code in PR #11983:
URL: https://github.com/apache/kafka/pull/11983#discussion_r863330742
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/ConnectProtocolCompatibilityTest.java:
##
@@ -51,95 +41,58 @@ public class ConnectProtocol
C0urante commented on PR #11983:
URL: https://github.com/apache/kafka/pull/11983#issuecomment-1115554702
Thanks @showuon, good call with the improvement to the serialization logic.
Took a bit of legwork but I've pushed a change that implements that and also
cleans up some testing clutter; L
C0urante commented on code in PR #11983:
URL: https://github.com/apache/kafka/pull/11983#discussion_r863330276
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java:
##
@@ -336,13 +332,16 @@ ClusterAssignment performTas
C0urante commented on code in PR #11983:
URL: https://github.com/apache/kafka/pull/11983#discussion_r863330276
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java:
##
@@ -336,13 +332,16 @@ ClusterAssignment performTas
C0urante commented on code in PR #11983:
URL: https://github.com/apache/kafka/pull/11983#discussion_r863329552
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeConnectProtocol.java:
##
@@ -230,15 +230,16 @@ public static Extende
[
https://issues.apache.org/jira/browse/KAFKA-13859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531010#comment-17531010
]
Luke Chen commented on KAFKA-13859:
---
[~opayne] , thanks for the response. That confirm
showuon commented on PR #12105:
URL: https://github.com/apache/kafka/pull/12105#issuecomment-1115548710
> To be clear, the broker would have to be older than 2.8 for the issue to
occur. The server change for KIP-679 happened in Apache Kafka 2.8.
Yes, the user confirmed that their brok
showuon commented on code in PR #11983:
URL: https://github.com/apache/kafka/pull/11983#discussion_r863325064
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java:
##
@@ -336,13 +332,16 @@ ClusterAssignment performTask
C0urante commented on code in PR #11983:
URL: https://github.com/apache/kafka/pull/11983#discussion_r863308185
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java:
##
@@ -108,18 +107,15 @@ public Map performAssignment
C0urante commented on code in PR #11983:
URL: https://github.com/apache/kafka/pull/11983#discussion_r863308048
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java:
##
@@ -336,13 +332,16 @@ ClusterAssignment performTas
C0urante commented on PR #12041:
URL: https://github.com/apache/kafka/pull/12041#issuecomment-1115515896
Thanks Guozhang. I think the cost of logging warnings in cases like this is
fairly low as users can and should adjust their configurations to not use
nonsensical properties, and the bene
[
https://issues.apache.org/jira/browse/KAFKA-13857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531003#comment-17531003
]
RivenSun commented on KAFKA-13857:
--
[~guozhang] Thank you for your reply and approval.
LeonSamuel opened a new pull request, #12115:
URL: https://github.com/apache/kafka/pull/12115
As someone new to Kafka, it would have been welcoming to see a succinct
high-level overview of what Kafka is as the first piece of documentation. As I
clicked on the home page of Kafka website, I r
hachikuji commented on code in PR #12106:
URL: https://github.com/apache/kafka/pull/12106#discussion_r863259182
##
core/src/test/scala/unit/kafka/server/ControllerApisTest.scala:
##
@@ -730,8 +729,45 @@ class ControllerApisTest {
request.topics().add(new
CreatePartitionsTo
[
https://issues.apache.org/jira/browse/KAFKA-13867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530971#comment-17530971
]
Alyssa Huang commented on KAFKA-13867:
--
^ just confirming that you mean `MetadataVe
cmccabe commented on PR #12072:
URL: https://github.com/apache/kafka/pull/12072#issuecomment-1115466993
Thanks for this PR, @ahuang98. And thanks to everyone who reviewed. I filed
https://issues.apache.org/jira/browse/KAFKA-13867 for two very minor issues
that we discussed here (one javadoc
[
https://issues.apache.org/jira/browse/KAFKA-13867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530969#comment-17530969
]
Colin McCabe commented on KAFKA-13867:
--
I also suggest renaming `MetadataVersion#ve
Colin McCabe created KAFKA-13867:
Summary: Improve JavaDoc for MetadataVersion.java
Key: KAFKA-13867
URL: https://issues.apache.org/jira/browse/KAFKA-13867
Project: Kafka
Issue Type: Improvem
cmccabe commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r863258243
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -0,0 +1,334 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
cmccabe merged PR #12072:
URL: https://github.com/apache/kafka/pull/12072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
cmccabe commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r863255928
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersionValidator.java:
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
akhileshchg commented on code in PR #12106:
URL: https://github.com/apache/kafka/pull/12106#discussion_r863179905
##
core/src/test/java/kafka/test/MockController.java:
##
@@ -410,10 +410,16 @@ public CompletableFuture
updateFeatures(
throw new UnsupportedOperationExcep
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530937#comment-17530937
]
François Rosière commented on KAFKA-13864:
--
[~cadonna], table updated and discu
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530937#comment-17530937
]
François Rosière edited comment on KAFKA-13864 at 5/2/22 8:44 PM:
akhileshchg commented on code in PR #12106:
URL: https://github.com/apache/kafka/pull/12106#discussion_r863095080
##
core/src/test/java/kafka/test/MockController.java:
##
@@ -410,10 +410,16 @@ public CompletableFuture
updateFeatures(
throw new UnsupportedOperationExcep
[
https://issues.apache.org/jira/browse/KAFKA-13636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Olson updated KAFKA-13636:
-
Description:
The group coordinator might delete invalid offsets during a group rebalance.
Durin
cadonna commented on code in PR #12114:
URL: https://github.com/apache/kafka/pull/12114#discussion_r863082871
##
docs/upgrade.html:
##
@@ -73,7 +73,11 @@ Notable changes in 3
via Connect worker and/or connector configuration. Connect may
enable idempotent producers
Matthias J. Sax created KAFKA-13866:
---
Summary: Support more advanced time retention policies
Key: KAFKA-13866
URL: https://issues.apache.org/jira/browse/KAFKA-13866
Project: Kafka
Issue Typ
ahuang98 commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r863014438
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersionValidator.java:
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
mimaison commented on PR #11773:
URL: https://github.com/apache/kafka/pull/11773#issuecomment-1115108546
Sorry @C0urante for the delays, we were at Kafka Summit last week and I'm
still trying to catch up on stuff. I'm hoping to take another look this week.
--
This is an automated message
mimaison commented on PR #12067:
URL: https://github.com/apache/kafka/pull/12067#issuecomment-1115103573
@kkonstantine @rhauch Can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cmccabe merged PR #12107:
URL: https://github.com/apache/kafka/pull/12107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
C0urante commented on code in PR #11874:
URL: https://github.com/apache/kafka/pull/11874#discussion_r862970744
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -216,8 +216,10 @@
private static final String MAX_IN_FLIGHT_REQUESTS_PER_CONN
[
https://issues.apache.org/jira/browse/KAFKA-13859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530796#comment-17530796
]
Oliver Payne commented on KAFKA-13859:
--
Sorry for the late response. I see that thi
ijuma commented on code in PR #12114:
URL: https://github.com/apache/kafka/pull/12114#discussion_r862968313
##
docs/upgrade.html:
##
@@ -73,7 +73,11 @@ Notable changes in 3
via Connect worker and/or connector configuration. Connect may
enable idempotent producers
ijuma commented on code in PR #12114:
URL: https://github.com/apache/kafka/pull/12114#discussion_r862967880
##
docs/upgrade.html:
##
@@ -73,7 +73,11 @@ Notable changes in 3
via Connect worker and/or connector configuration. Connect may
enable idempotent producers
C0urante commented on PR #11773:
URL: https://github.com/apache/kafka/pull/11773#issuecomment-1115054516
@tombentley @mimaison I'd really like it if we could confirm the intended
direction for this API. I'm willing to go whichever direction you believe is
best, but (as Tom has noted) given
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530788#comment-17530788
]
Bruno Cadonna commented on KAFKA-13864:
---
[~frosiere] When you write a KIP you need
cadonna commented on PR #12114:
URL: https://github.com/apache/kafka/pull/12114#issuecomment-1115025366
@ijuma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
cadonna opened a new pull request, #12114:
URL: https://github.com/apache/kafka/pull/12114
Adds a note to the upgrade notes to use slf4j-log4j version
1.7.35+ [1] or slf4j-reload4j to avoid possible compatibility issues
originating from the logging framework [2].
[1] https://www.
YeonCheolGit commented on code in PR #12019:
URL: https://github.com/apache/kafka/pull/12019#discussion_r862388033
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java:
##
@@ -110,14 +114,18 @@ public Map performAssign
divijvaidya commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r862915029
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java:
##
@@ -34,22 +34,38 @@
*/
public abstract class SampledStat implements Measurable
divijvaidya commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r862909115
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java:
##
@@ -138,6 +170,46 @@ public boolean isComplete(long timeMs, MetricConfig
config)
divijvaidya commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r862908720
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java:
##
@@ -52,10 +51,6 @@ public Rate(TimeUnit unit, SampledStat stat) {
this.unit = u
divijvaidya commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r862908241
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java:
##
@@ -110,25 +127,40 @@ public String toString() {
protected void purgeObsolet
divijvaidya commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r862908032
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java:
##
@@ -87,8 +103,9 @@ public Sample oldest(long now) {
Sample oldest = this
divijvaidya commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r862906685
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java:
##
@@ -68,28 +63,61 @@ public double measure(MetricConfig config, long now) {
}
divijvaidya commented on PR #12045:
URL: https://github.com/apache/kafka/pull/12045#issuecomment-1114895474
@mimaison Thinking about it, I can actually reduce the code changes such
that no modifications to any public interface is made. Do you still think a KIP
is required for this change in
chromy96 commented on code in PR #11916:
URL: https://github.com/apache/kafka/pull/11916#discussion_r862846428
##
clients/src/test/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactoryTest.java:
##
@@ -291,7 +289,14 @@ public void testPemKeyStoreFileNoKeyPassword() t
chromy96 commented on code in PR #11916:
URL: https://github.com/apache/kafka/pull/11916#discussion_r862845752
##
clients/src/test/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactoryTest.java:
##
@@ -291,7 +289,14 @@ public void testPemKeyStoreFileNoKeyPassword() t
divijvaidya commented on PR #12045:
URL: https://github.com/apache/kafka/pull/12045#issuecomment-1114879179
Thanks for checking @mimaison. As I explained above, the test is flaky since
the logic of computation of `Rate` has a bug and hence, in worst case scenario
it can exceed whatever thre
mimaison commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r862834421
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java:
##
@@ -110,25 +127,40 @@ public String toString() {
protected void purgeObsoleteSa
Hangleton commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r862786317
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java:
##
@@ -87,8 +103,9 @@ public Sample oldest(long now) {
Sample oldest = this.s
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530722#comment-17530722
]
François Rosière edited comment on KAFKA-13864 at 5/2/22 12:52 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530722#comment-17530722
]
François Rosière commented on KAFKA-13864:
--
KIP-832 has been created.
> Change
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530716#comment-17530716
]
Bruno Cadonna commented on KAFKA-13864:
---
[~frosiere] You should be all set now!
>
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530707#comment-17530707
]
François Rosière commented on KAFKA-13864:
--
Make sense... frosiere is my accoun
Hangleton commented on code in PR #12045:
URL: https://github.com/apache/kafka/pull/12045#discussion_r862786317
##
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java:
##
@@ -87,8 +103,9 @@ public Sample oldest(long now) {
Sample oldest = this.s
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530703#comment-17530703
]
Bruno Cadonna edited comment on KAFKA-13864 at 5/2/22 12:06 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530703#comment-17530703
]
Bruno Cadonna commented on KAFKA-13864:
---
Any change that impacts the public interf
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530697#comment-17530697
]
François Rosière edited comment on KAFKA-13864 at 5/2/22 11:59 AM:
---
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530697#comment-17530697
]
François Rosière commented on KAFKA-13864:
--
KIP looks overkill in this specific
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530694#comment-17530694
]
Bruno Cadonna commented on KAFKA-13864:
---
[~Jack-Lee] Could you please open a GitHu
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530689#comment-17530689
]
lqjacklee commented on KAFKA-13864:
---
[~frosiere] [~cadonna] please help review the pa
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lqjacklee updated KAFKA-13864:
--
Attachment: interceptor_constructor_client.patch
> Change the visibility of a KafkaProducer and KafkaC
divijvaidya commented on PR #12113:
URL: https://github.com/apache/kafka/pull/12113#issuecomment-1114739908
Hey @mimaison, one of the flaky tests failing for this PR is
`testListenerConnectionRateLimitWhenActualRateAboveLimit() –
kafka.network.ConnectionQuotasTest` which I have fixed as par
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17530677#comment-17530677
]
Bruno Cadonna commented on KAFKA-13864:
---
[~frosiere][~Jack-Lee] I think this ticke
divijvaidya commented on code in PR #12106:
URL: https://github.com/apache/kafka/pull/12106#discussion_r862747446
##
core/src/main/scala/kafka/server/ControllerApis.scala:
##
@@ -767,7 +767,7 @@ class ControllerApis(val requestChannel: RequestChannel,
setErrorCode(TOP
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-13864:
--
Labels: needs-kip (was: )
> Change the visibility of a KafkaProducer and KafkaConsumer constr
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière updated KAFKA-13864:
-
Description:
To allow implementing Spring managed interceptors for producers and consume
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière updated KAFKA-13864:
-
Description:
To allow implementing Spring managed interceptors for producers and consume
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lqjacklee reassigned KAFKA-13864:
-
Assignee: lqjacklee
> Change the visibility of a KafkaProducer and KafkaConsumer constructor
>
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière updated KAFKA-13864:
-
Description:
To allow implementing Spring managed interceptors for producers and consume
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière updated KAFKA-13864:
-
Description:
To allow implementing Spring managed interceptors for producers and consume
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière updated KAFKA-13864:
-
Description:
To allow implementing Spring managed interceptors for producers and consume
[
https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
François Rosière updated KAFKA-13864:
-
Description:
To allow implementing Spring managed interceptors for producers and consume
divijvaidya commented on code in PR #12112:
URL: https://github.com/apache/kafka/pull/12112#discussion_r862714992
##
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##
@@ -586,11 +586,14 @@ class TopicCommandIntegrationTest extends
KafkaServerTest
[
https://issues.apache.org/jira/browse/KAFKA-13865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-13865.
---
Fix Version/s: 3.3.0
Resolution: Fixed
> Fix ResponseSendTimeMs metric in RequestChannel.sc
showuon merged PR #12111:
URL: https://github.com/apache/kafka/pull/12111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
mimaison commented on PR #11844:
URL: https://github.com/apache/kafka/pull/11844#issuecomment-1114635179
@Corlobin I agree with @C0urante, it would be good to have a test for this.
Are you interested in trying the approach that has been suggested?
--
This is an automated message from the
mimaison opened a new pull request, #12113:
URL: https://github.com/apache/kafka/pull/12113
- Make a few fields `final`
- Remove unnecessary `throws`
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and C
[
https://issues.apache.org/jira/browse/KAFKA-13773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-13773:
-
Assignee: Luke Chen
> Data loss after recovery from crash due to full hard disk
> -
89 matches
Mail list logo
