[GitHub] [kafka] dengziming commented on a diff in pull request #12104: KAFKA-13746: Attempt to fix flaky test by waiting to fetch 2 topics f…

2022-04-30 Thread GitBox
dengziming commented on code in PR #12104: URL: https://github.com/apache/kafka/pull/12104#discussion_r862417737 ## core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala: ## @@ -733,12 +733,18 @@ class TopicCommandIntegrationTest extends KafkaServerTestH

[GitHub] [kafka] dengziming commented on a diff in pull request #12072: KAFKA-13854 Refactor ApiVersion to MetadataVersion

2022-04-30 Thread GitBox
dengziming commented on code in PR #12072: URL: https://github.com/apache/kafka/pull/12072#discussion_r862416055 ## clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java: ## @@ -271,4 +273,30 @@ public static ApiVersion toApiVersion(ApiKeys apiKey) {

[GitHub] [kafka] dengziming opened a new pull request, #12112: MINOR: Fix flaky testDescribeUnderReplicatedPartitions

2022-04-30 Thread GitBox
dengziming opened a new pull request, #12112: URL: https://github.com/apache/kafka/pull/12112 *More detailed description of your change* Currently, we are waiting for metadataCache to bookkeeper the partition info, this isn't enough, we should wait until the partition ISR is less than AR.

[jira] [Updated] (KAFKA-13865) Fix ResponseSendTimeMs metric in RequestChannel.scala was removed repeatedly

2022-04-30 Thread zhaobo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhaobo updated KAFKA-13865: --- Description: ResponseSendTimeMs metric was removed in line 576,but we removed it again in line 578. > Fix

[jira] [Updated] (KAFKA-13865) Fix ResponseSendTimeMs metric in RequestChannel.scala was removed repeatedly

2022-04-30 Thread zhaobo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhaobo updated KAFKA-13865: --- Summary: Fix ResponseSendTimeMs metric in RequestChannel.scala was removed repeatedly (was: Fix Respons

[jira] [Updated] (KAFKA-13865) Fix ResponseSendTimeMs metric was removed repeatedly

2022-04-30 Thread zhaobo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhaobo updated KAFKA-13865: --- Summary: Fix ResponseSendTimeMs metric was removed repeatedly (was: Fix ResponseSendTimeMs metric in R

[jira] [Updated] (KAFKA-13865) Fix ResponseSendTimeMs metric in RequestChannel.scala was removed repeatedly

2022-04-30 Thread zhaobo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhaobo updated KAFKA-13865: --- Summary: Fix ResponseSendTimeMs metric in RequestChannel.scala was removed repeatedly (was: Fix Respon

[jira] [Created] (KAFKA-13865) FIx ResponseSendTimeMs metric in RequestChannel.scala duplicate removed

2022-04-30 Thread zhaobo (Jira)
zhaobo created KAFKA-13865: -- Summary: FIx ResponseSendTimeMs metric in RequestChannel.scala duplicate removed Key: KAFKA-13865 URL: https://issues.apache.org/jira/browse/KAFKA-13865 Project: Kafka

[jira] [Updated] (KAFKA-13865) Fix ResponseSendTimeMs metric in RequestChannel.scala duplicate removed

2022-04-30 Thread zhaobo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhaobo updated KAFKA-13865: --- Summary: Fix ResponseSendTimeMs metric in RequestChannel.scala duplicate removed (was: FIx ResponseSen

[GitHub] [kafka] bozhao12 commented on a diff in pull request #12056: MINOR:Fix test in ReplicaManagerTest.scala

2022-04-30 Thread GitBox
bozhao12 commented on code in PR #12056: URL: https://github.com/apache/kafka/pull/12056#discussion_r862407605 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2352,7 +2352,7 @@ class ReplicaManagerTest { val (rm0, rm1) = prepareDifferentReplicaMan

[GitHub] [kafka] YeonCheolGit commented on a diff in pull request #12019: KAFKA-13764: Improve balancing algorithm for Connect incremental rebalancing

2022-04-30 Thread GitBox
YeonCheolGit commented on code in PR #12019: URL: https://github.com/apache/kafka/pull/12019#discussion_r862396035 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/ConnectUtils.java: ## @@ -160,4 +166,40 @@ public static boolean isSourceConnector(Connector connect

[GitHub] [kafka] YeonCheolGit commented on a diff in pull request #12019: KAFKA-13764: Improve balancing algorithm for Connect incremental rebalancing

2022-04-30 Thread GitBox
YeonCheolGit commented on code in PR #12019: URL: https://github.com/apache/kafka/pull/12019#discussion_r862394876 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -151,19 +159,46 @@ private Long ensureLeade

[jira] [Updated] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

2022-04-30 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] François Rosière updated KAFKA-13864: - Description: To allow implementing Spring managed interceptors for producers and consume

[jira] [Updated] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

2022-04-30 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-13864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] François Rosière updated KAFKA-13864: - Description: To allow implementing Spring managed interceptors for producers and consume

[GitHub] [kafka] YeonCheolGit commented on a diff in pull request #12019: KAFKA-13764: Improve balancing algorithm for Connect incremental rebalancing

2022-04-30 Thread GitBox
YeonCheolGit commented on code in PR #12019: URL: https://github.com/apache/kafka/pull/12019#discussion_r862388033 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -110,14 +114,18 @@ public Map performAssign

[jira] [Created] (KAFKA-13864) Change the visibility of a KafkaProducer and KafkaConsumer constructor

2022-04-30 Thread Jira
François Rosière created KAFKA-13864: Summary: Change the visibility of a KafkaProducer and KafkaConsumer constructor Key: KAFKA-13864 URL: https://issues.apache.org/jira/browse/KAFKA-13864 Projec

[GitHub] [kafka] dajac commented on a diff in pull request #12056: MINOR:Fix typo in ReplicaManagerTest.scala

2022-04-30 Thread GitBox
dajac commented on code in PR #12056: URL: https://github.com/apache/kafka/pull/12056#discussion_r862390142 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2352,7 +2352,7 @@ class ReplicaManagerTest { val (rm0, rm1) = prepareDifferentReplicaManage

[GitHub] [kafka] YeonCheolGit commented on a diff in pull request #12019: KAFKA-13764: Improve balancing algorithm for Connect incremental rebalancing

2022-04-30 Thread GitBox
YeonCheolGit commented on code in PR #12019: URL: https://github.com/apache/kafka/pull/12019#discussion_r862388033 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java: ## @@ -110,14 +114,18 @@ public Map performAssign

[GitHub] [kafka] dengziming commented on a diff in pull request #11951: KAFKA-13836: Improve KRaft broker heartbeat logic

2022-04-30 Thread GitBox
dengziming commented on code in PR #11951: URL: https://github.com/apache/kafka/pull/11951#discussion_r862365685 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -333,7 +353,11 @@ class BrokerLifecycleManager(val config: KafkaConfig, } private def

[GitHub] [kafka] bozhao12 commented on a diff in pull request #12056: MINOR:Fix typo in ReplicaManagerTest.scala

2022-04-30 Thread GitBox
bozhao12 commented on code in PR #12056: URL: https://github.com/apache/kafka/pull/12056#discussion_r862355953 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -2352,7 +2352,7 @@ class ReplicaManagerTest { val (rm0, rm1) = prepareDifferentReplicaMan

[GitHub] [kafka] dengziming commented on a diff in pull request #12104: KAFKA-13746: Attempt to fix flaky test by waiting to fetch 2 topics f…

2022-04-30 Thread GitBox
dengziming commented on code in PR #12104: URL: https://github.com/apache/kafka/pull/12104#discussion_r862353579 ## core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala: ## @@ -733,12 +733,18 @@ class TopicCommandIntegrationTest extends KafkaServerTestH

[GitHub] [kafka] dengziming opened a new pull request, #12110: MINOR: Enable some AdminClient integration tests

2022-04-30 Thread GitBox
dengziming opened a new pull request, #12110: URL: https://github.com/apache/kafka/pull/12110 *More detailed description of your change* Enable KRaft in AdminClientWithPoliciesIntegrationTest and PlaintextAdminIntegrationTest There are some tests not enabled yet: 1. testCreatePartit

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2022-04-30 Thread GitBox
dongjinleekr commented on PR #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-1113974839 Rebased onto the latest trunk. @dhruvp-8 Sorry for being late. For compatibility reasons, the adoption of this PR is postponed to 4.0. in 3.x, the reloadlog4j will be used instea

[GitHub] [kafka] dengziming opened a new pull request, #12109: KAFKA-13863: Prevent null config value when create topic in KRaft mode

2022-04-30 Thread GitBox
dengziming opened a new pull request, #12109: URL: https://github.com/apache/kafka/pull/12109 *More detailed description of your change* When creating topics with customized configs, we should keep consistency with behavior in zk mode. *Summary of testing strategy (including ration

[jira] [Created] (KAFKA-13863) Prevent null config value when create topic in KRaft mode

2022-04-30 Thread dengziming (Jira)
dengziming created KAFKA-13863: -- Summary: Prevent null config value when create topic in KRaft mode Key: KAFKA-13863 URL: https://issues.apache.org/jira/browse/KAFKA-13863 Project: Kafka Issue T

[GitHub] [kafka] dengziming opened a new pull request, #12108: KAFKA-13862: Support Append/Subtract multiple config values in KRaft mode

2022-04-30 Thread GitBox
dengziming opened a new pull request, #12108: URL: https://github.com/apache/kafka/pull/12108 *More detailed description of your change* We can append/subtract multiple values in kraft mode, for example: append/subtract topic "cleanup.policy" with "delete,compact" will end up treating "d

[jira] [Assigned] (KAFKA-13862) Add And Subtract multiple config values is not supported in KRaft mode

2022-04-30 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-13862: -- Assignee: dengziming > Add And Subtract multiple config values is not supported in KRaft mode

[jira] [Created] (KAFKA-13862) Add And Subtract multiple config values is not supported in KRaft mode

2022-04-30 Thread dengziming (Jira)
dengziming created KAFKA-13862: -- Summary: Add And Subtract multiple config values is not supported in KRaft mode Key: KAFKA-13862 URL: https://issues.apache.org/jira/browse/KAFKA-13862 Project: Kafka