[GitHub] [kafka] RivenSun2 opened a new pull request, #12000: MINOR: Use the LEAVE_GROUP_ON_CLOSE_CONFIG configuration uniformly to avoid multiple codes using the `internal.leave.group.on.close` strin

2022-04-05 Thread GitBox
RivenSun2 opened a new pull request, #12000: URL: https://github.com/apache/kafka/pull/12000 Use the LEAVE_GROUP_ON_CLOSE_CONFIG configuration uniformly to avoid multiple codes using the `internal.leave.group.on.close` string alone -- This is an automated message from the Apache Git Servi

[jira] [Commented] (KAFKA-12774) kafka-streams 2.8: logging in uncaught-exceptionhandler doesn't go through log4j

2022-04-05 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517866#comment-17517866 ] Jørgen commented on KAFKA-12774: [~cadonna] : Sounds good to me. We still have the issue

[jira] [Comment Edited] (KAFKA-13793) Add validators for serialization and deserialization related configuration

2022-04-05 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516472#comment-17516472 ] RivenSun edited comment on KAFKA-13793 at 4/6/22 6:26 AM: -- I co

[jira] [Comment Edited] (KAFKA-13793) Add validators for serialization and deserialization related configuration

2022-04-05 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516472#comment-17516472 ] RivenSun edited comment on KAFKA-13793 at 4/6/22 6:26 AM: -- I co

[jira] [Comment Edited] (KAFKA-13793) Add validators for serialization and deserialization related configuration

2022-04-05 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516472#comment-17516472 ] RivenSun edited comment on KAFKA-13793 at 4/6/22 6:26 AM: -- I co

[GitHub] [kafka] dongjoon-hyun commented on pull request #11995: KAFKA-13782; Ensure correct partition added to txn after abort on full batch

2022-04-05 Thread GitBox
dongjoon-hyun commented on PR #11995: URL: https://github.com/apache/kafka/pull/11995#issuecomment-1089831593 Thank you so much all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [kafka] sciclon2 commented on pull request #11842: KAFKA-13687: Limiting the amount of bytes to be read in a segment logs

2022-04-05 Thread GitBox
sciclon2 commented on PR #11842: URL: https://github.com/apache/kafka/pull/11842#issuecomment-1089818537 @junrao I committed the changes and ran the test, all good, thanks! ![Screenshot 2022-04-06 at 06 51 59](https://user-images.githubusercontent.com/74413315/161898272-80c31461-3a80-41df

[GitHub] [kafka] sciclon2 commented on a diff in pull request #11842: KAFKA-13687: Limiting the amount of bytes to be read in a segment logs

2022-04-05 Thread GitBox
sciclon2 commented on code in PR #11842: URL: https://github.com/apache/kafka/pull/11842#discussion_r843459090 ## core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala: ## @@ -310,6 +334,38 @@ class DumpLogSegmentsTest { None } + // Returns the total bytes of

[jira] [Resolved] (KAFKA-6204) Interceptor and MetricsReporter should implement java.io.Closeable

2022-04-05 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté resolved KAFKA-6204. -- Fix Version/s: 3.2.0 Assignee: Xavier Léauté Resolution: Fixed > Interceptor an

[GitHub] [kafka] vvcephei commented on pull request #11997: KAFKA-6204, KAFKA-7402: ProducerInterceptor should implement AutoCloseable

2022-04-05 Thread GitBox
vvcephei commented on PR #11997: URL: https://github.com/apache/kafka/pull/11997#issuecomment-1089682577 Merged! Thanks again, @xvrl . About the non-green checks, Jenkins for some reason started a second test run with changes from another PR. I'm not sure what that's about, but all t

[GitHub] [kafka] vvcephei merged pull request #11997: KAFKA-6204, KAFKA-7402: ProducerInterceptor should implement AutoCloseable

2022-04-05 Thread GitBox
vvcephei merged PR #11997: URL: https://github.com/apache/kafka/pull/11997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] ddrid commented on a diff in pull request #11991: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionManager

2022-04-05 Thread GitBox
ddrid commented on code in PR #11991: URL: https://github.com/apache/kafka/pull/11991#discussion_r843398778 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -184,16 +184,22 @@ private void startSequencesAtBeginning(TopicPartitio

[jira] [Commented] (KAFKA-13799) Improve documentation for Kafka zero-copy

2022-04-05 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517772#comment-17517772 ] RivenSun commented on KAFKA-13799: -- Hi [~guozhang]  [~dajac] , [~showuon] Could you giv

[jira] [Commented] (KAFKA-13793) Add validators for serialization and deserialization related configuration

2022-04-05 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517770#comment-17517770 ] RivenSun commented on KAFKA-13793: -- Hi [~guozhang]  [~dajac] , [~showuon] Could you giv

[GitHub] [kafka] RivenSun2 commented on pull request #11985: MINOR: Supplement the description of `Valid Values` in the documentation of `compression.type`

2022-04-05 Thread GitBox
RivenSun2 commented on PR #11985: URL: https://github.com/apache/kafka/pull/11985#issuecomment-1089641523 Hi @showuon @mimaison could you help to review the PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] samarthd commented on pull request #9794: Add a job to build on ARM64 at Amazon Graviton2 nodes

2022-04-05 Thread GitBox
samarthd commented on PR #9794: URL: https://github.com/apache/kafka/pull/9794#issuecomment-1089560163 @martin-g Thank you for this PR! I'd love to see this get merged. @mimaison You recently closed the parent ticket (https://issues.apache.org/jira/browse/KAFKA-10759) referencing a c

[GitHub] [kafka] mjsax closed pull request #10391: MINOR: disable flaky system test

2022-04-05 Thread GitBox
mjsax closed pull request #10391: MINOR: disable flaky system test URL: https://github.com/apache/kafka/pull/10391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[jira] [Updated] (KAFKA-13130) Deprecate long based range queries in SessionStore

2022-04-05 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13130: -- Fix Version/s: (was: 3.2.0) > Deprecate long based range queries in SessionStore > ---

[jira] [Commented] (KAFKA-13130) Deprecate long based range queries in SessionStore

2022-04-05 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517724#comment-17517724 ] Bruno Cadonna commented on KAFKA-13130: --- Removing from the 3.2.0 release since fea

[jira] [Commented] (KAFKA-12781) Improve the endOffsets accuracy in TaskMetadata

2022-04-05 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517723#comment-17517723 ] Bruno Cadonna commented on KAFKA-12781: --- Removing from the 3.2.0 release since fea

[jira] [Updated] (KAFKA-12781) Improve the endOffsets accuracy in TaskMetadata

2022-04-05 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-12781: -- Fix Version/s: (was: 3.2.0) > Improve the endOffsets accuracy in TaskMetadata > -

[GitHub] [kafka] artemlivshits commented on a diff in pull request #11991: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionManager

2022-04-05 Thread GitBox
artemlivshits commented on code in PR #11991: URL: https://github.com/apache/kafka/pull/11991#discussion_r843285049 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -184,16 +184,22 @@ private void startSequencesAtBeginning(Topic

[GitHub] [kafka] jeqo commented on pull request #10390: KAFKA-12536: Add Instant-based methods to ReadOnlySessionStore

2022-04-05 Thread GitBox
jeqo commented on PR #10390: URL: https://github.com/apache/kafka/pull/10390#issuecomment-1089370471 Thanks @dotjdk ! Do you mean https://github.com/apache/kafka/blob/8f8f914efc2dfb2a6638553038dcb17393d7de96/streams/src/main/java/org/apache/kafka/streams/state/SessionStore.java#L92 spec

[GitHub] [kafka] jeqo opened a new pull request, #11999: [MINOR] fix(streams): align variable names

2022-04-05 Thread GitBox
jeqo opened a new pull request, #11999: URL: https://github.com/apache/kafka/pull/11999 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing st

[GitHub] [kafka] junrao commented on a diff in pull request #11842: KAFKA-13687: Limiting the amount of bytes to be read in a segment logs

2022-04-05 Thread GitBox
junrao commented on code in PR #11842: URL: https://github.com/apache/kafka/pull/11842#discussion_r843226602 ## core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala: ## @@ -310,6 +334,38 @@ class DumpLogSegmentsTest { None } + // Returns the total bytes of t

[GitHub] [kafka] junrao commented on a diff in pull request #11842: KAFKA-13687: Limiting the amount of bytes to be read in a segment logs

2022-04-05 Thread GitBox
junrao commented on code in PR #11842: URL: https://github.com/apache/kafka/pull/11842#discussion_r843225969 ## core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala: ## @@ -310,6 +334,38 @@ class DumpLogSegmentsTest { None } + // Returns the total bytes of t

[GitHub] [kafka] jlprat commented on pull request #11432: KAFKA-13399 towards scala3

2022-04-05 Thread GitBox
jlprat commented on PR #11432: URL: https://github.com/apache/kafka/pull/11432#issuecomment-1089271503 I'll resolve the conflicts tomorrow and ping people for reviews -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] jlprat commented on pull request #11350: Scala3 migration

2022-04-05 Thread GitBox
jlprat commented on PR #11350: URL: https://github.com/apache/kafka/pull/11350#issuecomment-1089268807 @jvican some intermediate work is here: https://github.com/apache/kafka/pull/11432 I'd need to resolve s couple if conflicts as the PR got no traction for a while. But I'm happy to

[GitHub] [kafka] jvican commented on pull request #11350: Scala3 migration

2022-04-05 Thread GitBox
jvican commented on PR #11350: URL: https://github.com/apache/kafka/pull/11350#issuecomment-1089258871 Any plans to prioritize the Scala 3 migration? Would be nice to see this happening. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] mimaison merged pull request #11974: KAFKA-13763 (1): Improve unit testing coverage and flexibility for IncrementalCooperativeAssignor

2022-04-05 Thread GitBox
mimaison merged PR #11974: URL: https://github.com/apache/kafka/pull/11974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-13801) Kafka server does not respect MetricsReporter interface contract for dynamically configured reporters

2022-04-05 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-13801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté updated KAFKA-13801: -- Component/s: metrics > Kafka server does not respect MetricsReporter interface contract for >

[GitHub] [kafka] xvrl opened a new pull request, #11998: KAFKA-13801 Kafka server does not respect MetricsReporter contract for dynamically configured reporters

2022-04-05 Thread GitBox
xvrl opened a new pull request, #11998: URL: https://github.com/apache/kafka/pull/11998 MetricsReporter.contextChange contract states the method should always be called first before MetricsReporter.init is called. This is done correctly for reporters enabled by default (e.g. JmxReporter

[jira] [Created] (KAFKA-13801) Kafka server does not respect MetricsReporter interface contract for dynamically configured reporters

2022-04-05 Thread Jira
Xavier Léauté created KAFKA-13801: - Summary: Kafka server does not respect MetricsReporter interface contract for dynamically configured reporters Key: KAFKA-13801 URL: https://issues.apache.org/jira/browse/KAFKA-

[GitHub] [kafka] xvrl opened a new pull request, #11997: KAFKA-6204 KAFKA-7402 ProducerInterceptor should implement AutoCloseable

2022-04-05 Thread GitBox
xvrl opened a new pull request, #11997: URL: https://github.com/apache/kafka/pull/11997 As part of KIP-376 we had ConsumerInterceptor implement AutoCloseable but forgot to do the same for ProducerInterceptor. This fixes the inconsistency and also fixes KAFKA-6204 at the same time. --

[jira] [Commented] (KAFKA-6204) Interceptor and MetricsReporter should implement java.io.Closeable

2022-04-05 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517651#comment-17517651 ] Xavier Léauté commented on KAFKA-6204: -- this was mostly fixed by KIP-376 https://cw

[GitHub] [kafka] lihaosky commented on a diff in pull request #11896: KAFKA-13785: [Emit final][5/N] emit final for TimeWindowedKStreamImpl

2022-04-05 Thread GitBox
lihaosky commented on code in PR #11896: URL: https://github.com/apache/kafka/pull/11896#discussion_r843123337 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/TimeWindowedKStreamImpl.java: ## @@ -232,11 +247,19 @@ );

[jira] [Assigned] (KAFKA-13800) Remove force cast of TimeWindowKStreamImpl in tests of https://github.com/apache/kafka/pull/11896

2022-04-05 Thread Hao Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hao Li reassigned KAFKA-13800: -- Assignee: Hao Li > Remove force cast of TimeWindowKStreamImpl in tests of > https://github.com/apach

[jira] [Updated] (KAFKA-13797) Adding metric to indicate metadata response outgoing bytes rate

2022-04-05 Thread Lucas Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Wang updated KAFKA-13797: --- Description: It's not a common case, but we experienced the following problem in one of our cluster

[jira] [Created] (KAFKA-13800) Remove force cast of TimeWindowKStreamImpl in tests of https://github.com/apache/kafka/pull/11896

2022-04-05 Thread Hao Li (Jira)
Hao Li created KAFKA-13800: -- Summary: Remove force cast of TimeWindowKStreamImpl in tests of https://github.com/apache/kafka/pull/11896 Key: KAFKA-13800 URL: https://issues.apache.org/jira/browse/KAFKA-13800

[jira] [Updated] (KAFKA-13794) Producer batch lost silently in TransactionManager

2022-04-05 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-13794: Fix Version/s: 3.2.0 > Producer batch lost silently in TransactionManager > --

[GitHub] [kafka] hachikuji commented on pull request #11995: KAFKA-13782; Ensure correct partition added to txn after abort on full batch

2022-04-05 Thread GitBox
hachikuji commented on PR #11995: URL: https://github.com/apache/kafka/pull/11995#issuecomment-1089065258 @tombentley This is merged to 3.1 along with #11991. Thanks for managing the release by the way! -- This is an automated message from the Apache Git Service. To respond to the message

[jira] [Resolved] (KAFKA-13782) Producer may fail to add the correct partition to transaction

2022-04-05 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13782. - Resolution: Fixed > Producer may fail to add the correct partition to transaction >

[GitHub] [kafka] ijuma commented on pull request #11965: KAFKA-13778: Fetch from follower should never run the preferred read replica selection

2022-04-05 Thread GitBox
ijuma commented on PR #11965: URL: https://github.com/apache/kafka/pull/11965#issuecomment-1089061398 Is it worth backporting this to release branches? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[jira] [Resolved] (KAFKA-13794) Producer batch lost silently in TransactionManager

2022-04-05 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13794. - Fix Version/s: 3.1.1 3.0.2 Resolution: Fixed > Producer batch

[GitHub] [kafka] hachikuji merged pull request #11991: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionManager

2022-04-05 Thread GitBox
hachikuji merged PR #11991: URL: https://github.com/apache/kafka/pull/11991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[jira] [Updated] (KAFKA-13778) Fetch from follower should never run the preferred read replica selection

2022-04-05 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-13778: Affects Version/s: 2.6.0 (was: 3.2.0) > Fetch from follower should neve

[jira] [Resolved] (KAFKA-13778) Fetch from follower should never run the preferred read replica selection

2022-04-05 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-13778. - Fix Version/s: 3.3.0 Reviewer: David Jacot Resolution: Fixed > Fetch from follow

[GitHub] [kafka] dajac merged pull request #11965: KAFKA-13778: Fetch from follower should never run the preferred read replica selection

2022-04-05 Thread GitBox
dajac merged PR #11965: URL: https://github.com/apache/kafka/pull/11965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] hachikuji merged pull request #11995: KAFKA-13782; Ensure correct partition added to txn after abort on full batch

2022-04-05 Thread GitBox
hachikuji merged PR #11995: URL: https://github.com/apache/kafka/pull/11995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] ijuma commented on pull request #11995: KAFKA-13782; Ensure correct partition added to txn after abort on full batch

2022-04-05 Thread GitBox
ijuma commented on PR #11995: URL: https://github.com/apache/kafka/pull/11995#issuecomment-1088982164 In addition to this, we will also include https://github.com/apache/kafka/pull/11991. @hachikuji should be able to merge both this morning, I believe. -- This is an automated message fro

[GitHub] [kafka] dongjoon-hyun commented on pull request #11995: KAFKA-13782; Ensure correct partition added to txn after abort on full batch

2022-04-05 Thread GitBox
dongjoon-hyun commented on PR #11995: URL: https://github.com/apache/kafka/pull/11995#issuecomment-1088909166 Hi, @ijuma . According to your dev mailing list email, is this the last blocker issue before Apache Kafka 3.1.1 RC? -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (KAFKA-12699) Streams no longer overrides the java default uncaught exception handler

2022-04-05 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-12699: -- Fix Version/s: (was: 3.2.0) > Streams no longer overrides the java default uncaught except

[jira] [Commented] (KAFKA-12699) Streams no longer overrides the java default uncaught exception handler

2022-04-05 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517525#comment-17517525 ] Bruno Cadonna commented on KAFKA-12699: --- Removing from the 3.2.0 release since cod

[jira] [Commented] (KAFKA-12774) kafka-streams 2.8: logging in uncaught-exceptionhandler doesn't go through log4j

2022-04-05 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517524#comment-17517524 ] Bruno Cadonna commented on KAFKA-12774: --- Removing from the 3.2.0 release since cod

[jira] [Updated] (KAFKA-12774) kafka-streams 2.8: logging in uncaught-exceptionhandler doesn't go through log4j

2022-04-05 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-12774: -- Fix Version/s: (was: 3.2.0) > kafka-streams 2.8: logging in uncaught-exceptionhandler does

[jira] [Commented] (KAFKA-12774) kafka-streams 2.8: logging in uncaught-exceptionhandler doesn't go through log4j

2022-04-05 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517523#comment-17517523 ] Bruno Cadonna commented on KAFKA-12774: --- [~wcarlson5] [~ableegoldman] [~jorgenring

[GitHub] [kafka] C0urante commented on pull request #11974: KAFKA-13763 (1): Improve unit testing coverage and flexibility for IncrementalCooperativeAssignor

2022-04-05 Thread GitBox
C0urante commented on PR #11974: URL: https://github.com/apache/kafka/pull/11974#issuecomment-105947 Thanks @mimaison. I hope you don't mind but I've pushed one more change that simplifies how the configured set of connectors and tasks is simulated (this came in handy when designing tes

[GitHub] [kafka] C0urante commented on a diff in pull request #11974: KAFKA-13763 (1): Improve unit testing coverage and flexibility for IncrementalCooperativeAssignor

2022-04-05 Thread GitBox
C0urante commented on code in PR #11974: URL: https://github.com/apache/kafka/pull/11974#discussion_r842931708 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java: ## @@ -76,23 +83,21 @@ @Parameters pu

[GitHub] [kafka] mimaison commented on pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2022-04-05 Thread GitBox
mimaison commented on PR #11748: URL: https://github.com/apache/kafka/pull/11748#issuecomment-1088831443 @tombentley @showuon Can you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mimaison commented on a diff in pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2022-04-05 Thread GitBox
mimaison commented on code in PR #11748: URL: https://github.com/apache/kafka/pull/11748#discussion_r842896247 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -169,6 +172,7 @@ public String version() { return listConsumer

[GitHub] [kafka] viktorsomogyi commented on a diff in pull request #11748: KAFKA-12635: Don't emit checkpoints for partitions without any offset…

2022-04-05 Thread GitBox
viktorsomogyi commented on code in PR #11748: URL: https://github.com/apache/kafka/pull/11748#discussion_r842854543 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -169,6 +172,7 @@ public String version() { return listCon

[GitHub] [kafka] ijuma commented on pull request #11991: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionManager

2022-04-05 Thread GitBox
ijuma commented on PR #11991: URL: https://github.com/apache/kafka/pull/11991#issuecomment-1088659695 Thanks, looks like it's been there since 2.4.0 then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Comment Edited] (KAFKA-13799) Improve documentation for Kafka zero-copy

2022-04-05 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517382#comment-17517382 ] RivenSun edited comment on KAFKA-13799 at 4/5/22 12:37 PM: --- Hi

[jira] [Commented] (KAFKA-13799) Improve documentation for Kafka zero-copy

2022-04-05 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17517382#comment-17517382 ] RivenSun commented on KAFKA-13799: -- Hi [~showuon] [~dengziming] and [~guozhang]  I thin

[jira] [Created] (KAFKA-13799) Improve documentation for Kafka zero-copy

2022-04-05 Thread RivenSun (Jira)
RivenSun created KAFKA-13799: Summary: Improve documentation for Kafka zero-copy Key: KAFKA-13799 URL: https://issues.apache.org/jira/browse/KAFKA-13799 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] sciclon2 commented on pull request #11842: KAFKA-13687: Limiting the amount of bytes to be read in a segment logs

2022-04-05 Thread GitBox
sciclon2 commented on PR #11842: URL: https://github.com/apache/kafka/pull/11842#issuecomment-1088562983 @junrao the tests that I added are working locally so I guess the errors are not relate to my tests -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [kafka] mimaison commented on a diff in pull request #11974: KAFKA-13763 (1): Improve unit testing coverage and flexibility for IncrementalCooperativeAssignor

2022-04-05 Thread GitBox
mimaison commented on code in PR #11974: URL: https://github.com/apache/kafka/pull/11974#discussion_r842632626 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java: ## @@ -769,16 +609,16 @@ public void testLostAssi

[GitHub] [kafka] sciclon2 commented on a diff in pull request #11842: KAFKA-13687: Limiting the amount of bytes to be read in a segment logs

2022-04-05 Thread GitBox
sciclon2 commented on code in PR #11842: URL: https://github.com/apache/kafka/pull/11842#discussion_r842615733 ## core/src/main/scala/kafka/tools/DumpLogSegments.scala: ## @@ -430,6 +431,11 @@ object DumpLogSegments { .describedAs("size") .ofType(classOf[java.lang.

[GitHub] [kafka] sciclon2 commented on a diff in pull request #11842: KAFKA-13687: Limiting the amount of bytes to be read in a segment logs

2022-04-05 Thread GitBox
sciclon2 commented on code in PR #11842: URL: https://github.com/apache/kafka/pull/11842#discussion_r842615490 ## core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala: ## @@ -310,6 +334,38 @@ class DumpLogSegmentsTest { None } + // Returns the total bytes of

[GitHub] [kafka] sciclon2 commented on a diff in pull request #11842: KAFKA-13687: Limiting the amount of bytes to be read in a segment logs

2022-04-05 Thread GitBox
sciclon2 commented on code in PR #11842: URL: https://github.com/apache/kafka/pull/11842#discussion_r842614837 ## core/src/test/scala/unit/kafka/tools/DumpLogSegmentsTest.scala: ## @@ -310,6 +334,38 @@ class DumpLogSegmentsTest { None } + // Returns the total bytes of

[GitHub] [kafka] mimaison commented on a diff in pull request #11974: KAFKA-13763 (1): Improve unit testing coverage and flexibility for IncrementalCooperativeAssignor

2022-04-05 Thread GitBox
mimaison commented on code in PR #11974: URL: https://github.com/apache/kafka/pull/11974#discussion_r842589656 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java: ## @@ -76,23 +83,21 @@ @Parameters pu

[GitHub] [kafka] mimaison commented on a diff in pull request #11974: KAFKA-13763 (1): Improve unit testing coverage and flexibility for IncrementalCooperativeAssignor

2022-04-05 Thread GitBox
mimaison commented on code in PR #11974: URL: https://github.com/apache/kafka/pull/11974#discussion_r842589656 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java: ## @@ -76,23 +83,21 @@ @Parameters pu

[GitHub] [kafka] ddrid commented on pull request #11991: KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionManager

2022-04-05 Thread GitBox
ddrid commented on PR #11991: URL: https://github.com/apache/kafka/pull/11991#issuecomment-1088446711 I think it was introduced in #6883, but I'm not sure if it affects all the versions since then. What do you think? @hachikuji -- This is an automated message from the Apache Git Service.

[jira] [Resolved] (KAFKA-13791) Fix FetchResponse#`fetchData` and `forgottenTopics`: Assignment of lazy-initialized members should be the last step with double-checked locking

2022-04-05 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-13791. --- Fix Version/s: 3.3.0 Resolution: Fixed > Fix FetchResponse#`fetchData` and `forgottenTopics`:

[GitHub] [kafka] showuon merged pull request #11981: KAFKA-13791: Fix FetchResponse#`fetchData` and `forgottenTopics`: Assignment of lazy-initialized members should be the last step with double-checke

2022-04-05 Thread GitBox
showuon merged PR #11981: URL: https://github.com/apache/kafka/pull/11981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon commented on pull request #11981: KAFKA-13791: Fix FetchResponse#`fetchData` and `forgottenTopics`: Assignment of lazy-initialized members should be the last step with double-

2022-04-05 Thread GitBox
showuon commented on PR #11981: URL: https://github.com/apache/kafka/pull/11981#issuecomment-1088355283 Failed tests are unrelated. ``` Build / JDK 11 and Scala 2.13 / kafka.api.ClientIdQuotaTest.testProducerConsumerOverrideUnthrottled() Build / JDK 17 and Scala 2.13 / kafk