showuon commented on pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#issuecomment-1070375723
@dajac @jolshan , do you want to have another look for this PR to make it
into v3.2.0?
--
This is an automated message from the Apache Git Service.
To respond to the message
[
https://issues.apache.org/jira/browse/KAFKA-13743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dengziming reassigned KAFKA-13743:
--
Assignee: dengziming
> kraft controller should prevent topics with conflicting metrics names
dengziming commented on pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#issuecomment-1070342480
Thank you @showuon , PTAL again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dengziming commented on a change in pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#discussion_r828767349
##
File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala
##
@@ -224,9 +252,81 @@ object GetOffsetShell {
/**
* Return the partition in
dengziming commented on a change in pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#discussion_r828767212
##
File path: core/src/test/scala/kafka/tools/GetOffsetShellTest.scala
##
@@ -109,6 +111,46 @@ class GetOffsetShellTest extends KafkaServerTestHarness
[
https://issues.apache.org/jira/browse/KAFKA-13751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
RivenSun updated KAFKA-13751:
-
Description:
h1. Phenomenon:
SASL/OAUTHBEARER, whether implemented by default or customized by the use
[
https://issues.apache.org/jira/browse/KAFKA-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507974#comment-17507974
]
dengziming commented on KAFKA-13749:
Thank you for reporting this, can you provided
[
https://issues.apache.org/jira/browse/KAFKA-13751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507973#comment-17507973
]
RivenSun commented on KAFKA-13751:
--
Hi [~showuon] [~guozhang]
I think this issue shoul
RivenSun created KAFKA-13751:
Summary: On the broker side, OAUTHBEARER is not compatible with
other SASL mechanisms
Key: KAFKA-13751
URL: https://issues.apache.org/jira/browse/KAFKA-13751
Project: Kafka
guozhangwang commented on pull request #11705:
URL: https://github.com/apache/kafka/pull/11705#issuecomment-1070221651
+1, thanks @showuon for the contribution! And congrats for it finally being
merged.
--
This is an automated message from the Apache Git Service.
To respond to the messag
[
https://issues.apache.org/jira/browse/KAFKA-13136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507968#comment-17507968
]
Chris Egerton commented on KAFKA-13136:
---
This is not a bug in Kafka Connect per se
dengziming commented on a change in pull request #11471:
URL: https://github.com/apache/kafka/pull/11471#discussion_r828724247
##
File path:
connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java
##
@@ -220,17 +224,22 @@ public void testMissingF
dengziming commented on a change in pull request #11471:
URL: https://github.com/apache/kafka/pull/11471#discussion_r828724024
##
File path:
connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java
##
@@ -204,8 +210,6 @@ private void writeTimesAnd
dongjinleekr commented on pull request #11579:
URL: https://github.com/apache/kafka/pull/11579#issuecomment-1070139215
Rebased onto the latest trunk. cc/ @ijuma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507965#comment-17507965
]
Prashanth Joseph Babu commented on KAFKA-13740:
---
[~cadonna] Thank you so
[
https://issues.apache.org/jira/browse/KAFKA-13740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Prashanth Joseph Babu resolved KAFKA-13740.
---
Resolution: Fixed
> kafka-stream-client-shutdown
> -
C0urante commented on a change in pull request #11196:
URL: https://github.com/apache/kafka/pull/11196#discussion_r828716597
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java
##
@@ -396,6 +396,8 @@ private void commitOffsets(long
[
https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507963#comment-17507963
]
Chris Egerton commented on KAFKA-1:
---
Bumping target release version as feature
[
https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-1:
--
Fix Version/s: 3.3.0
(was: 3.2.0)
> Atomic commit of source connector r
showuon commented on a change in pull request #11909:
URL: https://github.com/apache/kafka/pull/11909#discussion_r828704440
##
File path:
tools/src/main/java/org/apache/kafka/tools/ClientCompatibilityTest.java
##
@@ -172,6 +174,13 @@ public static void main(String[] args) thro
showuon commented on pull request #11905:
URL: https://github.com/apache/kafka/pull/11905#issuecomment-1069914952
@tchiotludo , there is test failed due to this change. Please help fix it.
```
org.apache.kafka.streams.kstream.internals.KTableSourceTest.kTableShouldLogOnOutOfOrder
`
showuon commented on pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#issuecomment-1069887108
Nice work @lkokhreidze ! And nice team work, @cadonna ! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
showuon commented on pull request #11705:
URL: https://github.com/apache/kafka/pull/11705#issuecomment-1069884347
Thanks for all your review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
showuon merged pull request #11705:
URL: https://github.com/apache/kafka/pull/11705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
RivenSun2 commented on pull request #11819:
URL: https://github.com/apache/kafka/pull/11819#issuecomment-1069812919
Hi @dajac @cmccabe
Could you help to review the PR ?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
dongjinleekr commented on pull request #11430:
URL: https://github.com/apache/kafka/pull/11430#issuecomment-1069811650
Rebased onto the latest trunk. cc/ @rajinisivaram
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507913#comment-17507913
]
RivenSun commented on KAFKA-13463:
--
Hi [~showuon] [~guozhang]
My mailbox has not recei
jsancio commented on a change in pull request #11893:
URL: https://github.com/apache/kafka/pull/11893#discussion_r828546402
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -953,6 +971,48 @@ private void cancelMaybeFenceReplicas() {
jsancio commented on a change in pull request #11893:
URL: https://github.com/apache/kafka/pull/11893#discussion_r828546042
##
File path: core/src/main/scala/kafka/server/ControllerServer.scala
##
@@ -158,20 +158,30 @@ class ControllerServer(
alterConfigPolicy = Option(c
jsancio commented on a change in pull request #11893:
URL: https://github.com/apache/kafka/pull/11893#discussion_r828545811
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -1197,6 +1257,25 @@ private void resetState() {
*/
jsancio commented on a change in pull request #11893:
URL: https://github.com/apache/kafka/pull/11893#discussion_r828545292
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -1016,6 +1042,55 @@ ApiError electLeader(String top
jsancio commented on a change in pull request #11893:
URL: https://github.com/apache/kafka/pull/11893#discussion_r828545014
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -147,6 +147,7 @@
private int defaultNumPartitions =
jsancio commented on a change in pull request #11893:
URL: https://github.com/apache/kafka/pull/11893#discussion_r828543830
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -1016,6 +1042,55 @@ ApiError electLeader(String top
jolshan opened a new pull request #11909:
URL: https://github.com/apache/kafka/pull/11909
With the switch to idempotency as a default,
ClientCompatibilityFeaturesTest.run_compatibility_test broke for versions prior
to 0.11 where EOS was enabled. This PR disables idempotency for kafka versi
jsancio commented on a change in pull request #11893:
URL: https://github.com/apache/kafka/pull/11893#discussion_r828542616
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -341,22 +359,25 @@ public void replay(RemoveTopicRe
jsancio commented on a change in pull request #11893:
URL: https://github.com/apache/kafka/pull/11893#discussion_r828541824
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -953,6 +971,48 @@ private void cancelMaybeFenceReplicas() {
jsancio commented on a change in pull request #11893:
URL: https://github.com/apache/kafka/pull/11893#discussion_r828541824
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -953,6 +971,48 @@ private void cancelMaybeFenceReplicas() {
[
https://issues.apache.org/jira/browse/KAFKA-13750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan reassigned KAFKA-13750:
--
Assignee: Justine Olshan
> Client Compatability KafkaTest uses invalid idempotency co
Justine Olshan created KAFKA-13750:
--
Summary: Client Compatability KafkaTest uses invalid idempotency
configs
Key: KAFKA-13750
URL: https://issues.apache.org/jira/browse/KAFKA-13750
Project: Kafka
jsancio commented on a change in pull request #11893:
URL: https://github.com/apache/kafka/pull/11893#discussion_r828510590
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -1745,7 +1745,7 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.
jsancio commented on a change in pull request #11893:
URL: https://github.com/apache/kafka/pull/11893#discussion_r828505982
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -861,6 +875,10 @@ public void handleLeaderChange(LeaderAndEp
[
https://issues.apache.org/jira/browse/KAFKA-13749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akhilesh Chaganti reassigned KAFKA-13749:
-
Assignee: Akhilesh Chaganti
> TopicConfigs and ErrorCode are not set in createT
jsancio commented on a change in pull request #11893:
URL: https://github.com/apache/kafka/pull/11893#discussion_r828471282
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -673,10 +679,19 @@ public void run() throws Exception {
[
https://issues.apache.org/jira/browse/KAFKA-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507868#comment-17507868
]
Chris Egerton commented on KAFKA-7509:
--
Thanks [~mjsax]--I think that's an acceptabl
[
https://issues.apache.org/jira/browse/KAFKA-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507833#comment-17507833
]
Matthias J. Sax commented on KAFKA-7509:
Personally, I think the best way would b
Akhilesh Chaganti created KAFKA-13749:
-
Summary: TopicConfigs and ErrorCode are not set in createTopics
response in KRaft
Key: KAFKA-13749
URL: https://issues.apache.org/jira/browse/KAFKA-13749
Pr
[
https://issues.apache.org/jira/browse/KAFKA-13739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13739:
Labels: beginner newbie (was: )
> Sliding window without grace not working
>
[
https://issues.apache.org/jira/browse/KAFKA-13739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507825#comment-17507825
]
Matthias J. Sax commented on KAFKA-13739:
-
Thanks for chiming in [~lct45] \
{quo
kkonstantine opened a new pull request #11908:
URL: https://github.com/apache/kafka/pull/11908
The purpose of this PR is to stop including the non-production grade
connectors that are meant to be used for demos and quick starts by default in
the CLASSPATH and plugin.path of Connect deploym
Konstantine Karantasis created KAFKA-13748:
--
Summary: Do not include file stream connectors in Connect's
CLASSPATH and plugin.path by default
Key: KAFKA-13748
URL: https://issues.apache.org/jira/browse/KA
jsancio commented on pull request #11893:
URL: https://github.com/apache/kafka/pull/11893#issuecomment-1069422793
Thanks for the reviews @junrao and @mumrah. I uploaded a commit that changes
the election algorithm for `PartitionChangeBuilder`:
https://github.com/apache/kafka/pull/11893/com
mumrah commented on a change in pull request #11893:
URL: https://github.com/apache/kafka/pull/11893#discussion_r828173718
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -1016,6 +1042,55 @@ ApiError electLeader(String topi
cadonna commented on pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#issuecomment-1069358982
Merged!
@lkokhreidze Congrats to this milestone! Nice work! 🥳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
[
https://issues.apache.org/jira/browse/KAFKA-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507768#comment-17507768
]
Chris Egerton edited comment on KAFKA-7509 at 3/16/22, 6:15 PM:
---
lkokhreidze commented on pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#issuecomment-1069360043
Big thank you @cadonna and @showuon for all the reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
[
https://issues.apache.org/jira/browse/KAFKA-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randall Hauch reassigned KAFKA-7509:
Assignee: (was: Randall Hauch)
> Kafka Connect logs unnecessary warnings about unused
[
https://issues.apache.org/jira/browse/KAFKA-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507768#comment-17507768
]
Chris Egerton edited comment on KAFKA-7509 at 3/16/22, 5:41 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507768#comment-17507768
]
Chris Egerton commented on KAFKA-7509:
--
Bumping this again as the problem continues
cadonna merged pull request #11837:
URL: https://github.com/apache/kafka/pull/11837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
guozhangwang commented on pull request #11796:
URL: https://github.com/apache/kafka/pull/11796#issuecomment-1069361318
@vamossagar12 could you resolve the conflicts before I re-trigger jenkins
again?
--
This is an automated message from the Apache Git Service.
To respond to the message,
lkokhreidze commented on pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#issuecomment-1069347833
FYI, if I'm looking at test results correctly, seems like latest failures
are not related.
```
Build / JDK 8 and Scala 2.12 / shouldRestoreState –
org.apache.kafk
mjsax commented on pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-1069342863
> the computation is done again on the cached data
What computation do you mean? In the end, we just iterate? And for both
cases (also with cache) we need to have an intera
mumrah commented on a change in pull request #11893:
URL: https://github.com/apache/kafka/pull/11893#discussion_r828167249
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -341,22 +359,25 @@ public void replay(RemoveTopicRec
mumrah merged pull request #11901:
URL: https://github.com/apache/kafka/pull/11901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr..
mumrah commented on a change in pull request #11893:
URL: https://github.com/apache/kafka/pull/11893#discussion_r828108377
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -147,6 +147,7 @@
private int defaultNumPartitions =
[
https://issues.apache.org/jira/browse/KAFKA-13730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507682#comment-17507682
]
Daniel Fonai commented on KAFKA-13730:
--
[~kirktrue] thank you for the quick respons
sarat-kakarla closed pull request #11907:
URL: https://github.com/apache/kafka/pull/11907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-uns
sarat-kakarla opened a new pull request #11907:
URL: https://github.com/apache/kafka/pull/11907
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of t
C0urante edited a comment on pull request #11894:
URL: https://github.com/apache/kafka/pull/11894#issuecomment-1067359447
Note that, while this aims to enable Connect workers to be brought up on
JVMs that do not provide the `HmacSHA256` algorithm, it does not add support
for Connect to be
[
https://issues.apache.org/jira/browse/KAFKA-13739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507674#comment-17507674
]
Leah Thomas commented on KAFKA-13739:
-
I think your analysis makes sense and the cha
mimaison commented on a change in pull request #11471:
URL: https://github.com/apache/kafka/pull/11471#discussion_r828080748
##
File path:
connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java
##
@@ -204,8 +210,6 @@ private void writeTimesAndFl
mimaison commented on a change in pull request #11471:
URL: https://github.com/apache/kafka/pull/11471#discussion_r828078337
##
File path:
connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java
##
@@ -220,17 +224,22 @@ public void testMissingFil
cadonna commented on pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#issuecomment-1069115152
Yes, doing it in a follow-up PR is totally fine!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
lkokhreidze commented on pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#issuecomment-1069108584
Thanks @cadonna ,
I assume it's okay to do it in a follow-up PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
cadonna edited a comment on pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#issuecomment-1069103952
@lkokhreidze We also need some updates to the docs. The sections to update
are
https://kafka.apache.org/31/documentation/streams/architecture#streams_architecture_recove
cadonna commented on pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#issuecomment-1069103952
@lkokhreidze We also need some updates to the docs. The sections to update
are
https://kafka.apache.org/31/documentation/streams/architecture#streams_architecture_recovery
and
showuon commented on pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#issuecomment-1069090526
@C0urante , thanks for your comments. TBH, I need some time to revisit the
code (since it's long time ago...), and answering your comments later. Thank
you.
--
This is an au
lkokhreidze commented on pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#issuecomment-1069087407
@showuon
I've reduced number of stateful tasks to 9. This should eliminate the
flakiness.
I will do the system test in the follow-up PR.
--
This is an automated m
lkokhreidze commented on a change in pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#discussion_r827960149
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RackAwarenessIntegrationTest.java
##
@@ -108,55 +117,122 @@ public void clea
cadonna commented on a change in pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#discussion_r827955917
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RackAwarenessIntegrationTest.java
##
@@ -108,55 +117,122 @@ public void cleanup(
showuon commented on pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#issuecomment-1069076197
@lkokhreidze , let's make sure the tests stable before we merge this final
piece of PRs. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to th
lkokhreidze commented on a change in pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#discussion_r827942693
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RackAwarenessIntegrationTest.java
##
@@ -108,55 +117,122 @@ public void clea
mimaison opened a new pull request #11906:
URL: https://github.com/apache/kafka/pull/11906
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
mimaison merged pull request #11885:
URL: https://github.com/apache/kafka/pull/11885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
mimaison edited a comment on pull request #11885:
URL: https://github.com/apache/kafka/pull/11885#issuecomment-1068980774
Thanks @mjsax, I confirmed the artifacts are there, merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
mimaison commented on pull request #11885:
URL: https://github.com/apache/kafka/pull/11885#issuecomment-1068980774
I confirmed the artifacts are there, merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
showuon commented on a change in pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#discussion_r827825740
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RackAwarenessIntegrationTest.java
##
@@ -108,55 +117,122 @@ public void cleanup(
lkokhreidze commented on a change in pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#discussion_r827786084
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RackAwarenessIntegrationTest.java
##
@@ -108,55 +117,122 @@ public void clea
lkokhreidze commented on a change in pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#discussion_r82681
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RackAwarenessIntegrationTest.java
##
@@ -108,55 +117,122 @@ public void clea
cadonna commented on a change in pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#discussion_r827776021
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RackAwarenessIntegrationTest.java
##
@@ -108,55 +117,122 @@ public void cleanup(
showuon commented on a change in pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#discussion_r827697359
##
File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala
##
@@ -103,59 +104,77 @@ object GetOffsetShell {
throw new IllegalArgumentExcept
showuon commented on a change in pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#discussion_r827697359
##
File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala
##
@@ -103,59 +104,77 @@ object GetOffsetShell {
throw new IllegalArgumentExcept
lkokhreidze commented on pull request #11837:
URL: https://github.com/apache/kafka/pull/11837#issuecomment-1068813143
Thanks @showuon for the feedback. Should be better now.
Also reduced test timeout to 1.5 minutes.
--
This is an automated message from the Apache Git Service.
To respon
showuon commented on a change in pull request #11173:
URL: https://github.com/apache/kafka/pull/11173#discussion_r827678933
##
File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala
##
@@ -103,59 +104,77 @@ object GetOffsetShell {
throw new IllegalArgumentExcept
94 matches
Mail list logo
