[GitHub] [kafka] showuon commented on pull request #11425: KAFKA-13393 Documentation - Add missing arguments to create a topic

2021-10-24 Thread GitBox
showuon commented on pull request #11425: URL: https://github.com/apache/kafka/pull/11425#issuecomment-950493388 @FlorianLehmann , PR: https://github.com/apache/kafka/pull/11429 to fix from the root: `TopicCommand` is ready for review. Welcome to provide comments. Thanks. -- This is an

[jira] [Commented] (KAFKA-13392) Timeout Exception triggering reassign partitions with --bootstrap-server option

2021-10-24 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433522#comment-17433522 ] Dongjin Lee commented on KAFKA-13392: - [~korjek] It seems like you are contacting th

[jira] [Comment Edited] (KAFKA-12764) Expand Gradle build for Scala 3.0 ?

2021-10-24 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433454#comment-17433454 ] Dejan Stojadinović edited comment on KAFKA-12764 at 10/24/21, 4:14 PM: ---

[jira] [Commented] (KAFKA-12764) Expand Gradle build for Scala 3.0 ?

2021-10-24 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433454#comment-17433454 ] Dejan Stojadinović commented on KAFKA-12764: [~ijuma] Is it safe to say that

[jira] [Commented] (KAFKA-12764) Expand Gradle build for Scala 3.0 ?

2021-10-24 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-12764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433452#comment-17433452 ] Dejan Stojadinović commented on KAFKA-12764: {color:blue}*+Related links/res

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2021-10-24 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-950328049 Rebased onto the latest trunk. @dajac Could you have a look when you are free? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] showuon commented on pull request #11368: KAFKA-13261: Add support for custom partitioners in foreign key joins

2021-10-24 Thread GitBox
showuon commented on pull request #11368: URL: https://github.com/apache/kafka/pull/11368#issuecomment-950322070 For your question: > Is there a way to trigger another Jenkins build from the same commit? Yes, I believe the committers can re-trigger it. But it's fine that the buil

[GitHub] [kafka] showuon commented on a change in pull request #11368: KAFKA-13261: Add support for custom partitioners in foreign key joins

2021-10-24 Thread GitBox
showuon commented on a change in pull request #11368: URL: https://github.com/apache/kafka/pull/11368#discussion_r735113220 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/TableJoined.java ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] dongjinleekr commented on pull request #10678: TRIVIAL: Fix type inconsistencies, unthrown exceptions, etc

2021-10-24 Thread GitBox
dongjinleekr commented on pull request #10678: URL: https://github.com/apache/kafka/pull/10678#issuecomment-950320213 Rebased onto the latest trunk. @cadonna Could you now kindly merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] dongjinleekr commented on a change in pull request #11429: KAFKA-13396: allow create topic without partition/replicaFactor

2021-10-24 Thread GitBox
love this case-by-case approach + it also works like a charm. :smiley: ![20211024-214641](https://user-images.githubusercontent.com/2375128/138594843-52779e07-31ea-4f85-af5b-c25b56025b77.png) -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] dongjinleekr opened a new pull request #11431: KAFKA-13397: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-24 Thread GitBox
dongjinleekr opened a new pull request #11431: URL: https://github.com/apache/kafka/pull/11431 I found this issue while working on [KAFKA-13365](https://issues.apache.org/jira/browse/KAFKA-13365). Since [KAFKA-10777](https://issues.apache.org/jira/browse/KAFKA-10777) is scheduled to be sh

[jira] [Updated] (KAFKA-13397) Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-24 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjin Lee updated KAFKA-13397: Description: This issue is a follow-up of KAFKA-10777 ([KIP-690|https://cwiki.apache.org/confluen

[jira] [Created] (KAFKA-13397) Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics

2021-10-24 Thread Dongjin Lee (Jira)
Dongjin Lee created KAFKA-13397: --- Summary: Honor 'replication.policy.separator' configuration when creating MirrorMaker2 internal topics Key: KAFKA-13397 URL: https://issues.apache.org/jira/browse/KAFKA-13397

[jira] [Assigned] (KAFKA-12634) Should checkpoint after restore finished

2021-10-24 Thread Yanwen Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanwen Lin reassigned KAFKA-12634: -- Assignee: (was: Yanwen Lin) > Should checkpoint after restore finished >

[GitHub] [kafka] dejan2609 commented on pull request #10967: KAFKA-12770: CheckStyle team needs this feature (in order to include Kafka into their regression suite)

2021-10-24 Thread GitBox
dejan2609 commented on pull request #10967: URL: https://github.com/apache/kafka/pull/10967#issuecomment-950299126 @ijuma kindly asking for a review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (KAFKA-13352) Kafka Client does not support passwords starting with number in jaas config

2021-10-24 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433415#comment-17433415 ] Dongjin Lee commented on KAFKA-13352: - Hi [~bvn13], I looked into this issue a littl

[jira] [Assigned] (KAFKA-13352) Kafka Client does not support passwords starting with number in jaas config

2021-10-24 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongjin Lee reassigned KAFKA-13352: --- Assignee: Dongjin Lee > Kafka Client does not support passwords starting with number in jaa

[GitHub] [kafka] dongjinleekr commented on pull request #11430: KAFKA-13352: Kafka Client does not support passwords starting with number in jaas config

2021-10-24 Thread GitBox
dongjinleekr commented on pull request #11430: URL: https://github.com/apache/kafka/pull/11430#issuecomment-950285065 @rajinisivaram Could you have a look? You worked this feature in [commit 69d7671](https://github.com/apache/kafka/commit/9eb665c39af1950548f903ad959449f2e69d7671). -- Thi

[GitHub] [kafka] dongjinleekr opened a new pull request #11430: KAFKA-13352: Kafka Client does not support passwords starting with number in jaas config

2021-10-24 Thread GitBox
dongjinleekr opened a new pull request #11430: URL: https://github.com/apache/kafka/pull/11430 As I left in the comments, the `StreamTokenizer` used by `org.apache.kafka.common.security.JaasConfig` recognizes alphabetical characters, dash, underscore, and dollar sign as a 'word' only. Beca

[GitHub] [kafka] showuon commented on pull request #11429: KAFKA-13396: allow create topic without partition/replicaFactor

2021-10-24 Thread GitBox
showuon commented on pull request #11429: URL: https://github.com/apache/kafka/pull/11429#issuecomment-950278601 @ijuma , please help check this PR when available. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka] showuon commented on a change in pull request #11429: KAFKA-13396: allow create topic without partition/replicaFactor

2021-10-24 Thread GitBox
showuon commented on a change in pull request #11429: URL: https://github.com/apache/kafka/pull/11429#discussion_r735079492 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala ## @@ -123,6 +123,25 @@ class TopicCommandTest { "--topic", topicName

[GitHub] [kafka] showuon commented on a change in pull request #11429: KAFKA-13396: allow create topic without partition/replicaFactor

2021-10-24 Thread GitBox
showuon commented on a change in pull request #11429: URL: https://github.com/apache/kafka/pull/11429#discussion_r735079413 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -625,8 +625,6 @@ object TopicCommand extends Logging { } if (!has(lis

[GitHub] [kafka] showuon opened a new pull request #11429: KAFKA-13396: allow create topic without partition/replicaFactor

2021-10-24 Thread GitBox
showuon opened a new pull request #11429: URL: https://github.com/apache/kafka/pull/11429 In https://github.com/apache/kafka/pull/10457/files#r635196307, the reviewer asked if there's a bug that we only check for zookeeper case, I didn't do a well check and directly confirm it. Now, after