RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872
Hi @guozhangwang Thank you for your reply，I agree with most of your points,
`KIP-580` is also a great optimization, I hope it can be completed as soon as
possible.
B
3schwartz commented on a change in pull request #11418:
URL: https://github.com/apache/kafka/pull/11418#discussion_r733361106
##
File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
##
@@ -1080,8 +1080,13 @@ public void handleSuccessfulResponse(RequestHe
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872
Hi @guozhangwang Thank you for your reply，I agree with most of your points,
`KIP-580` is also a great optimization, I hope it can be completed as soon as
possible.
B
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872
Hi @guozhangwang Thank you for your reply，I agree with most of your points,
`KIP-580` is also a great optimization, I hope it can be completed as soon as
possible.
B
[
https://issues.apache.org/jira/browse/KAFKA-13388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432238#comment-17432238
]
David Jacot commented on KAFKA-13388:
-
[~dhofftgt] Thanks for filing this issue. Whi
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872
Hi @guozhangwang Thank you for your reply，I agree with most of your points,
`KIP-580` is also a great optimization, I hope it can be completed as soon as
possible.
B
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872
Hi @guozhangwang Thank you for your reply，I agree with most of your points,
`KIP-580` is also a great optimization, I hope it can be completed as soon as
possible.
B
Seweryn Habdank-Wojewodzki created KAFKA-13389:
--
Summary: Add to kafka shell scripts checks about server state
Key: KAFKA-13389
URL: https://issues.apache.org/jira/browse/KAFKA-13389
Proje
dajac merged pull request #11203:
URL: https://github.com/apache/kafka/pull/11203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872
Hi @guozhangwang Thank you for your reply，I agree with most of your points,
`KIP-580` is also a great optimization, I hope it can be completed as soon as
possible.
B
[
https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432209#comment-17432209
]
A. Sophie Blee-Goldman commented on KAFKA-12559:
[~adityau] I've added y
[
https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432208#comment-17432208
]
A. Sophie Blee-Goldman commented on KAFKA-12559:
Seems like [~msundeq] i
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872
Hi @guozhangwang Thank you for your reply，I agree with most of your points,
`KIP-580` is also a great optimization, I hope it can be completed as soon as
possible.
B
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872
Hi @guozhangwang ，I agree with most of your points, `KIP-580` is also a
great optimization, I hope it can be completed as soon as possible.
But I still suggest that t
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872
Hi @guozhangwang ，I agree with most of your points, `KIP-580` is also a
great optimization, I hope it can be completed as soon as possible.
But I still suggest that t
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872
Hi @guozhangwang ，I agree with most of your points, `KIP-580` is also a
great optimization, I hope it can be completed as soon as possible.
But I still suggest that t
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872
Hi @guozhangwang ，I agree with most of your points, `KIP-580` is also a
great optimization, I hope it can be completed as soon as possible.
But I still suggest that t
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872
Hi @guozhangwang ，I agree with most of your points, `KIP-580` is also a
great optimization, I hope it can be completed as soon as possible.
But I still suggest that t
ableegoldman opened a new pull request #11421:
URL: https://github.com/apache/kafka/pull/11421
Pt. 1: #10609
Pt. 2: #10683
Pt. 3: #10788
Pt. 4: #
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872
Hi @guozhangwang ，I agree with most of your points, `KIP-580` is also a
great optimization, I hope it can be completed as soon as possible.
But I still suggest that t
RivenSun2 edited a comment on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872
Hi @guozhangwang ，I agree with most of your points, `KIP-580` is also a
great optimization, I hope it can be completed as soon as possible.
But I still suggest that t
RivenSun2 commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-948271872
Hi @guozhangwang ，I agree with most of your points, `KIP-580` is also a
great optimization, I hope it can be completed as soon as possible.
But I still suggest that the `com
ableegoldman commented on pull request #11405:
URL: https://github.com/apache/kafka/pull/11405#issuecomment-948253970
Deployed two soak test applications from this branch a few hours ago -- so
far so good:
1. [alos
soak](https://ccloud-local-dev.datadoghq.com/dashboard/fx7-74g-hn2/s
ableegoldman opened a new pull request #11420:
URL: https://github.com/apache/kafka/pull/11420
In the new NamedTopology API being worked on, state store names and their
uniqueness requirement is going to be scoped only to the owning topology,
rather than to the entire app. In other words,
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432191#comment-17432191
]
Eugen Dück edited comment on KAFKA-13289 at 10/21/21, 4:05 AM:
---
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17432191#comment-17432191
]
Eugen Dück commented on KAFKA-13289:
So the gaps are 100% reproducible. Up until 690
[
https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-13217:
---
Labels: needs-kip newbie newbie++ (was: needs-kip)
> Reconsider skipping th
[
https://issues.apache.org/jira/browse/KAFKA-13217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-13217:
---
Labels: needs-kip (was: )
> Reconsider skipping the LeaveGroup on close() o
ableegoldman commented on pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-948211745
@vvcephei @cadonna @mjsax @guozhangwang anyone have any thoughts on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
ableegoldman commented on a change in pull request #11404:
URL: https://github.com/apache/kafka/pull/11404#discussion_r733265795
##
File path: docs/streams/developer-guide/config-streams.html
##
@@ -755,7 +759,7 @@ probing.rebalance.interval.ms
Recommendation:
kirktrue commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r733262176
##
File path:
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/secured/OAuthBearerLoginCallbackHandler.java
##
@@ -0,0 +1,188 @@
+/*
+
kirktrue commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r733259234
##
File path:
clients/src/test/java/org/apache/kafka/common/security/oauthbearer/secured/AccessTokenValidatorFactoryTest.java
##
@@ -0,0 +1,77 @@
+/*
+
kirktrue commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r733259234
##
File path:
clients/src/test/java/org/apache/kafka/common/security/oauthbearer/secured/AccessTokenValidatorFactoryTest.java
##
@@ -0,0 +1,77 @@
+/*
+
kirktrue commented on a change in pull request #11284:
URL: https://github.com/apache/kafka/pull/11284#discussion_r733259046
##
File path:
clients/src/test/java/org/apache/kafka/common/security/oauthbearer/secured/AccessTokenValidatorFactoryTest.java
##
@@ -0,0 +1,77 @@
+/*
+
ableegoldman commented on pull request #10897:
URL: https://github.com/apache/kafka/pull/10897#issuecomment-948142861
Hey @xdgrulez , sorry for the delay! Somehow your last response slipped past
me. It seems like there have been some conflicting changes merged recently, can
you rebase/pull
ableegoldman commented on a change in pull request #11405:
URL: https://github.com/apache/kafka/pull/11405#discussion_r733239524
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -636,6 +636,10 @@ boolean runLoop() {
guozhangwang commented on pull request #11340:
URL: https://github.com/apache/kafka/pull/11340#issuecomment-948136951
@RivenSun2 I talked to @hachikuji offline about the best options to fix it
in near term, and we feel the async-commit approach may be more appropriate
here. But you'd need
ableegoldman commented on pull request #11405:
URL: https://github.com/apache/kafka/pull/11405#issuecomment-948129334
Just some unrelated/known flaky test failures:
-`NamedTopologyIntegrationTest.shouldPrefixAllInternalTopicNamesWithNamedTopology()`
-`DescribeConsumerGroupTest.testDe
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17431059#comment-17431059
]
Eugen Dück edited comment on KAFKA-13289 at 10/21/21, 12:15 AM:
--
mjsax commented on pull request #11404:
URL: https://github.com/apache/kafka/pull/11404#issuecomment-948116226
@astubbs There is a TOC at the top of the page... Not sure what else we
could do?
* I totally agree with you that we should NOT trigger
`maybeAutoCommitOffsetsSync` inside `onJoinPrepare` w
[
https://issues.apache.org/jira/browse/KAFKA-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17431420#comment-17431420
]
Guozhang Wang commented on KAFKA-13386:
---
Hello [~sduran] thanks for reporting your
guozhangwang commented on a change in pull request #11405:
URL: https://github.com/apache/kafka/pull/11405#discussion_r733022630
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -636,6 +636,10 @@ boolean runLoop() {
rhauch commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r733010990
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Sof
rhauch commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r733010990
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Sof
rhauch commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r733010990
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Sof
kkonstantine commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r732984001
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apac
kkonstantine commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r732984001
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apac
C0urante commented on pull request #10907:
URL: https://github.com/apache/kafka/pull/10907#issuecomment-947780934
Rebased onto https://github.com/apache/kafka/pull/11046 and cleaned up the
`KafkaBasedLog` changes to remove the ugly hack for handling aborted
transactions.
--
This is an a
[
https://issues.apache.org/jira/browse/KAFKA-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-7588.
---
Fix Version/s: 2.5.0
Resolution: Fixed
> Rationalize configurations passed to pluggabl
[
https://issues.apache.org/jira/browse/KAFKA-13370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17431272#comment-17431272
]
Vincent Giroux commented on KAFKA-13370:
Thank you [~showuon] for tackling this
tombentley merged pull request #11419:
URL: https://github.com/apache/kafka/pull/11419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubs
mimaison commented on a change in pull request #11419:
URL: https://github.com/apache/kafka/pull/11419#discussion_r732757865
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/MetricsContext.java
##
@@ -24,16 +24,23 @@
* MetricsContext encapsulates additiona
tombentley opened a new pull request #11419:
URL: https://github.com/apache/kafka/pull/11419
The Javadoc for MetricsContext wasn't correctly formatted for nice/readable
HTML output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
mimaison commented on pull request #11393:
URL: https://github.com/apache/kafka/pull/11393#issuecomment-947597826
@hachikuji @dajac This is following up from KAFKA-13258/13259/13260
(#11288). Can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to
tombentley commented on a change in pull request #10528:
URL: https://github.com/apache/kafka/pull/10528#discussion_r732678989
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##
@@ -506,9 +530,10 @@ public boolean commitOffset
tombentley commented on pull request #10528:
URL: https://github.com/apache/kafka/pull/10528#issuecomment-947550251
> I suspect we may want to either develop a Connect-specific log capture
appender (similar to how Connect has its own embedded testing framework that
was largely copied from
HyunSangHan opened a new pull request #11418:
URL: https://github.com/apache/kafka/pull/11418
I think it may seem a little awkward when I got a log like below,
```
1 partitions have leader brokers without a matching listener, including [...]
```
So I divided it to 2 types
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430275#comment-17430275
]
Eugen Dück edited comment on KAFKA-13289 at 10/20/21, 8:43 AM:
---
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17431059#comment-17431059
]
Eugen Dück commented on KAFKA-13289:
[~msheppard] You are right - my bad!
I have ch
[
https://issues.apache.org/jira/browse/KAFKA-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17431049#comment-17431049
]
Matthew Sheppard commented on KAFKA-13289:
--
Hi Eugen - Can you point out for me
ableegoldman commented on a change in pull request #11405:
URL: https://github.com/apache/kafka/pull/11405#discussion_r732511036
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -900,9 +903,13 @@ void closeAndCleanUpTasks(
ableegoldman commented on a change in pull request #11405:
URL: https://github.com/apache/kafka/pull/11405#discussion_r732509771
##
File path:
streams/src/main/java/org/apache/kafka/streams/errors/StreamsException.java
##
@@ -25,15 +28,45 @@
private final static long se
mimaison commented on a change in pull request #11393:
URL: https://github.com/apache/kafka/pull/11393#discussion_r732504940
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##
@@ -251,397 +284,114 @@
private final UnknownServe
mimaison commented on a change in pull request #11393:
URL: https://github.com/apache/kafka/pull/11393#discussion_r732504453
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/DescribeUserScramCredentialsRequest.java
##
@@ -66,8 +66,15 @@ public DescribeUserS
Mickael Maison created KAFKA-13387:
--
Summary: DescribeUserScramCredentialsResponse does not include
entries from the request when there's an error
Key: KAFKA-13387
URL: https://issues.apache.org/jira/browse/KAFKA
vamossagar12 commented on pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-947398089
Haha thanks @showuon :)
@ableegoldman , need your input again on this one :D Do you agree with going
ahead with merging this PR for Persistent stores and then having a
69 matches
Mail list logo
