[
https://issues.apache.org/jira/browse/KAFKA-13164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423432#comment-17423432
]
Hao Li commented on KAFKA-13164:
Hi [~xdgrulez], when you say "The join didn't work", wh
C0urante commented on a change in pull request #11333:
URL: https://github.com/apache/kafka/pull/11333#discussion_r720508381
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java
##
@@ -576,8 +576,12 @@ private static ConfigInfos vali
[
https://issues.apache.org/jira/browse/KAFKA-13332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423410#comment-17423410
]
A. Sophie Blee-Goldman commented on KAFKA-13332:
I don't think we necess
kowshik commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r720383908
##
File path: core/src/main/scala/kafka/log/UnifiedLog.scala
##
@@ -1505,7 +1505,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Fl
[
https://issues.apache.org/jira/browse/KAFKA-13268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423390#comment-17423390
]
Victoria Xia commented on KAFKA-13268:
--
Hey [~guozhang] we've already got
KTableKT
[
https://issues.apache.org/jira/browse/KAFKA-13261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423388#comment-17423388
]
Victoria Xia commented on KAFKA-13261:
--
Hi [~xnix], KIP-775 for adding interfaces t
C0urante edited a comment on pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#issuecomment-932434127
Thanks @rhauch, I've addressed all of the comments that seemed
straightforward and left a response on the ones where a bit of discussion seems
warranted before making ch
C0urante commented on pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#issuecomment-932434127
Thanks @rhauch, I've addressed all of the comments that seemed
straightforward and left a response on the ones where a bit of discussion seems
warranted before making changes.
C0urante commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r720433703
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache S
C0urante commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r720419911
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache S
C0urante commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r720416578
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache S
gharris1727 commented on a change in pull request #11369:
URL: https://github.com/apache/kafka/pull/11369#discussion_r720414123
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectClusterAssertions.java
##
@@ -45,7 +45,7 @@
gharris1727 commented on a change in pull request #11369:
URL: https://github.com/apache/kafka/pull/11369#discussion_r720410705
##
File path: clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java
##
@@ -1116,11 +1119,79 @@ public void ensureValid(String name, Obje
ccding commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r720404988
##
File path: core/src/main/scala/kafka/log/UnifiedLog.scala
##
@@ -1505,7 +1505,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Flu
junrao commented on a change in pull request #11345:
URL: https://github.com/apache/kafka/pull/11345#discussion_r720394930
##
File path: core/src/main/scala/kafka/log/UnifiedLog.scala
##
@@ -1505,7 +1505,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Flu
C0urante commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r720395810
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##
@@ -570,22 +512,21 @@ public boolean commitOffsets
C0urante commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r720389261
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java
##
@@ -291,6 +286,13 @@ private void maybeThrowProduc
C0urante commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r720384889
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache S
C0urante commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r720384099
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SubmittedRecordsTest.java
##
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apac
[
https://issues.apache.org/jira/browse/KAFKA-9752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Bradstreet updated KAFKA-9752:
Fix Version/s: 2.4.2
2.3.2
> Consumer rebalance can be stuck after new m
C0urante commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r720382154
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache S
C0urante commented on a change in pull request #11323:
URL: https://github.com/apache/kafka/pull/11323#discussion_r720382154
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SubmittedRecords.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache S
[
https://issues.apache.org/jira/browse/KAFKA-13329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421507#comment-17421507
]
Chris Egerton edited comment on KAFKA-13329 at 10/1/21, 4:02 PM:
-
Fátima Galera created KAFKA-13338:
-
Summary: kafka upgrade 6.1.1 asking to change log.cleanup.policy
from delete to compact
Key: KAFKA-13338
URL: https://issues.apache.org/jira/browse/KAFKA-13338
Proj
C0urante commented on a change in pull request #11369:
URL: https://github.com/apache/kafka/pull/11369#discussion_r720238529
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SinkConnectorConfig.java
##
@@ -70,60 +73,105 @@
"keys, all er
ccding commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r720277077
##
File path:
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerRestartTest.java
##
@@ -0,0 +1,1
C0urante commented on a change in pull request #11369:
URL: https://github.com/apache/kafka/pull/11369#discussion_r720235646
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectClusterAssertions.java
##
@@ -45,7 +45,7 @@
pri
ccding commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r720277077
##
File path:
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerRestartTest.java
##
@@ -0,0 +1,1
C0urante commented on a change in pull request #11369:
URL: https://github.com/apache/kafka/pull/11369#discussion_r720277458
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java
##
@@ -0,0 +1,493 @@
+/*
+ * Li
ccding commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r720277077
##
File path:
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerRestartTest.java
##
@@ -0,0 +1,1
C0urante commented on a change in pull request #11369:
URL: https://github.com/apache/kafka/pull/11369#discussion_r720277458
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java
##
@@ -0,0 +1,493 @@
+/*
+ * Li
ccding commented on a change in pull request #11058:
URL: https://github.com/apache/kafka/pull/11058#discussion_r720277077
##
File path:
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerRestartTest.java
##
@@ -0,0 +1,1
cadonna commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r720196549
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,205 @@
+
C0urante commented on a change in pull request #11369:
URL: https://github.com/apache/kafka/pull/11369#discussion_r720238529
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SinkConnectorConfig.java
##
@@ -70,60 +73,105 @@
"keys, all er
C0urante commented on a change in pull request #11369:
URL: https://github.com/apache/kafka/pull/11369#discussion_r720236100
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java
##
@@ -0,0 +1,493 @@
+/*
+ * Li
C0urante commented on a change in pull request #11369:
URL: https://github.com/apache/kafka/pull/11369#discussion_r720235646
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectClusterAssertions.java
##
@@ -45,7 +45,7 @@
pri
C0urante commented on a change in pull request #11369:
URL: https://github.com/apache/kafka/pull/11369#discussion_r720233090
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java
##
@@ -0,0 +1,493 @@
+/*
+ * Li
C0urante commented on a change in pull request #11369:
URL: https://github.com/apache/kafka/pull/11369#discussion_r720227719
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java
##
@@ -344,12 +354,73 @@ public StatusBackingStore stat
C0urante commented on a change in pull request #11369:
URL: https://github.com/apache/kafka/pull/11369#discussion_r720227455
##
File path: clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java
##
@@ -1116,11 +1119,79 @@ public void ensureValid(String name, Object
C0urante commented on a change in pull request #11369:
URL: https://github.com/apache/kafka/pull/11369#discussion_r718559975
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorClientPolicyIntegrationTest.java
##
@@ -133,7 +133,7 @@ privat
[
https://issues.apache.org/jira/browse/KAFKA-13130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423256#comment-17423256
]
Patrick Stuedi edited comment on KAFKA-13130 at 10/1/21, 12:15 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-13130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423256#comment-17423256
]
Patrick Stuedi edited comment on KAFKA-13130 at 10/1/21, 12:13 PM:
---
cadonna commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r720193502
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,203 @@
+
[
https://issues.apache.org/jira/browse/KAFKA-13130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423256#comment-17423256
]
Patrick Stuedi commented on KAFKA-13130:
[~ableegoldman] sorry I missed this, wi
[
https://issues.apache.org/jira/browse/KAFKA-9752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Bradstreet updated KAFKA-9752:
Fix Version/s: (was: 2.4.2)
(was: 2.3.2)
> Consumer rebalance ca
predatorray closed pull request #10525:
URL: https://github.com/apache/kafka/pull/10525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsub
predatorray opened a new pull request #10525:
URL: https://github.com/apache/kafka/pull/10525
This PR is for
[KAFKA-7572](https://issues.apache.org/jira/browse/KAFKA-7572), which fixes the
issue that producers will throw confusing exceptions when a custom Partitioner
returns a negative pa
[
https://issues.apache.org/jira/browse/KAFKA-9965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423150#comment-17423150
]
Jon McEwen edited comment on KAFKA-9965 at 10/1/21, 7:40 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-13303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon McEwen updated KAFKA-13303:
---
Affects Version/s: 2.4.0
2.5.0
2.4.1
[
https://issues.apache.org/jira/browse/KAFKA-13303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon McEwen updated KAFKA-13303:
---
Component/s: producer
> RoundRobinPartitioner broken by KIP-480
> -
[
https://issues.apache.org/jira/browse/KAFKA-13337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Katona updated KAFKA-13337:
--
Description:
During Connect plugin path scan, if an unreadable file/directory is found,
Conne
akatona84 commented on pull request #11371:
URL: https://github.com/apache/kafka/pull/11371#issuecomment-931982306
@heritamas pls change the title MINOR part to be KAFKA-13337
Hey @kkonstantine , could you take a look, pls?
Connect dies during startup if it encounters unreadable pl
[
https://issues.apache.org/jira/browse/KAFKA-13337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Katona reassigned KAFKA-13337:
-
Assignee: Andras Katona
> Scanning for Connect plugins can fail with AccessDeniedExcept
jonmcewen commented on pull request #11326:
URL: https://github.com/apache/kafka/pull/11326#issuecomment-931977355
@showuon please review, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-9965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423150#comment-17423150
]
Jon McEwen commented on KAFKA-9965:
---
PR ready for review please [~showuon]
> Uneven di
akatona84 commented on pull request #11373:
URL: https://github.com/apache/kafka/pull/11373#issuecomment-931973551
@ijuma could you approve this change pls?
Python based build executor died because of it:
```
OSError: [Errno 8] Exec format error: './gradlewAll'
```
--
This
akatona84 opened a new pull request #11373:
URL: https://github.com/apache/kafka/pull/11373
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testi
jonmcewen commented on pull request #11326:
URL: https://github.com/apache/kafka/pull/11326#issuecomment-931972073
Just checked my commit history and I had an earlier implementation like
```
// decrement the count for the partition for which the batch was
aborted, as the last mes
58 matches
Mail list logo
