[jira] [Commented] (KAFKA-13255) Mirrormaker config property config.properties.exclude is not working as expected

2021-08-31 Thread Ryanne Dolan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407742#comment-17407742 ] Ryanne Dolan commented on KAFKA-13255: -- hey [~anadkarni], you'll need to create a p

[GitHub] [kafka] splett2 commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-08-31 Thread GitBox
splett2 commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r699777919 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -628,9 +628,9 @@ class KafkaController(val config: KafkaConfig, topi

[GitHub] [kafka] splett2 commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-08-31 Thread GitBox
splett2 commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r699777919 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -628,9 +628,9 @@ class KafkaController(val config: KafkaConfig, topi

[jira] [Comment Edited] (KAFKA-13255) Mirrormaker config property config.properties.exclude is not working as expected

2021-08-31 Thread Anamika Nadkarni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407528#comment-17407528 ] Anamika Nadkarni edited comment on KAFKA-13255 at 8/31/21, 11:38 PM: -

[GitHub] [kafka] hachikuji commented on a change in pull request #10914: [KAFKA-8522] Streamline tombstone and transaction marker removal

2021-08-31 Thread GitBox
hachikuji commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r699714060 ## File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java ## @@ -156,13 +162,13 @@ public void ensureValid() { }

[GitHub] [kafka] C0urante opened a new pull request #10112: KAFKA-12226: Prevent source task offset failure when producer is overwhelmed

2021-08-31 Thread GitBox
C0urante opened a new pull request #10112: URL: https://github.com/apache/kafka/pull/10112 [Jira](https://issues.apache.org/jira/browse/KAFKA-12226) When a task fails to commit offsets because all outstanding records haven't been ack'd by the broker yet, it's better to retry that sam

[GitHub] [kafka] junrao commented on pull request #10463: KAFKA-12670: support unclean.leader.election.enable in KRaft mode

2021-08-31 Thread GitBox
junrao commented on pull request #10463: URL: https://github.com/apache/kafka/pull/10463#issuecomment-909609953 @dielhennr : Thanks. Since trunk has changed quite a bit, it would be useful to pull all the changes into this PR and rebase before reviewing it again. -- This is an automated

[GitHub] [kafka] guozhangwang merged pull request #11286: add units to metrics descriptions + test fix

2021-08-31 Thread GitBox
guozhangwang merged pull request #11286: URL: https://github.com/apache/kafka/pull/11286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] junrao commented on a change in pull request #10914: [KAFKA-8522] Streamline tombstone and transaction marker removal

2021-08-31 Thread GitBox
junrao commented on a change in pull request #10914: URL: https://github.com/apache/kafka/pull/10914#discussion_r699482697 ## File path: core/src/main/scala/kafka/log/LogCleaner.scala ## @@ -574,14 +577,17 @@ private[log] class Cleaner(val id: Int, val abortedTransacti

[jira] [Comment Edited] (KAFKA-13255) Mirrormaker config property config.properties.exclude is not working as expected

2021-08-31 Thread Anamika Nadkarni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407528#comment-17407528 ] Anamika Nadkarni edited comment on KAFKA-13255 at 8/31/21, 5:22 PM: --

[jira] [Commented] (KAFKA-13255) Mirrormaker config property config.properties.exclude is not working as expected

2021-08-31 Thread Anamika Nadkarni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407528#comment-17407528 ] Anamika Nadkarni commented on KAFKA-13255: -- I have fixed this issue and would l

[jira] [Resolved] (KAFKA-13205) Clarify API specification of Kafka Connect endpoint

2021-08-31 Thread Jonathan Kaleve (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Kaleve resolved KAFKA-13205. - Resolution: Fixed Resolution see https://github.com/strimzi/strimzi-kafka-operator/issue

[GitHub] [kafka] dajac merged pull request #11073: KAFKA-13092: Perf regression in LISR requests

2021-08-31 Thread GitBox
dajac merged pull request #11073: URL: https://github.com/apache/kafka/pull/11073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] ableegoldman commented on a change in pull request #11283: KAFKA-13249: Always update changelog offsets before writing the checkpoint file

2021-08-31 Thread GitBox
ableegoldman commented on a change in pull request #11283: URL: https://github.com/apache/kafka/pull/11283#discussion_r698868805 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -565,7 +565,7 @@ public void closeCleanAndRec

[GitHub] [kafka] guozhangwang commented on a change in pull request #11149: KAFKA-13229: add total blocked time metric to streams (KIP-761)

2021-08-31 Thread GitBox
guozhangwang commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r698854001 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/KafkaProducerMetrics.java ## @@ -0,0 +1,123 @@ +/* + * Licensed to t

[GitHub] [kafka] viktorsomogyi commented on pull request #11276: KAFKA-13240: Disable HTTP TRACE Method in Connect

2021-08-31 Thread GitBox
viktorsomogyi commented on pull request #11276: URL: https://github.com/apache/kafka/pull/11276#issuecomment-909037066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [kafka] hutchiko commented on pull request #11283: KAFKA-13249: Always update changelog offsets before writing the checkpoint file

2021-08-31 Thread GitBox
hutchiko commented on pull request #11283: URL: https://github.com/apache/kafka/pull/11283#issuecomment-908804447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [kafka] guozhangwang merged pull request #11149: KAFKA-13229: add total blocked time metric to streams (KIP-761)

2021-08-31 Thread GitBox
guozhangwang merged pull request #11149: URL: https://github.com/apache/kafka/pull/11149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] dajac commented on pull request #11073: KAFKA-13092: Perf regression in LISR requests

2021-08-31 Thread GitBox
dajac commented on pull request #11073: URL: https://github.com/apache/kafka/pull/11073#issuecomment-908364578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [kafka] dadufour commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely

2021-08-31 Thread GitBox
dadufour commented on pull request #11174: URL: https://github.com/apache/kafka/pull/11174#issuecomment-909121030 Any chance to have it in a 2.7.2? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] rodesai commented on pull request #11286: add units to metrics descriptions + test fix

2021-08-31 Thread GitBox
rodesai commented on pull request #11286: URL: https://github.com/apache/kafka/pull/11286#issuecomment-908931988 @guozhangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [kafka] jlprat commented on pull request #11228: KAFKA-12887 Skip some RuntimeExceptions from exception handler

2021-08-31 Thread GitBox
jlprat commented on pull request #11228: URL: https://github.com/apache/kafka/pull/11228#issuecomment-908365423 Test failure is related to https://issues.apache.org/jira/browse/KAFKA-8138 but not the same, as in this particular instance it seems more like a failure in the test itself (topi

[GitHub] [kafka] hutchiko edited a comment on pull request #11283: KAFKA-13249: Always update changelog offsets before writing the checkpoint file

2021-08-31 Thread GitBox
hutchiko edited a comment on pull request #11283: URL: https://github.com/apache/kafka/pull/11283#issuecomment-908804447 @ableegoldman I did not test against 3.0 just 2.7 and 2.8. I'll rebase onto `trunk` as see how that goes. -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] viktorsomogyi edited a comment on pull request #11276: KAFKA-13240: Disable HTTP TRACE Method in Connect

2021-08-31 Thread GitBox
viktorsomogyi edited a comment on pull request #11276: URL: https://github.com/apache/kafka/pull/11276#issuecomment-909037718 @mimaison would you please review this or suggest someone who can do it? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] junrao merged pull request #11060: MINOR Refactored the existing CheckpointFile in core module, moved to server-common module and introduced it as SnapshotFile.

2021-08-31 Thread GitBox
junrao merged pull request #11060: URL: https://github.com/apache/kafka/pull/11060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] splett2 commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-08-31 Thread GitBox
splett2 commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r698693107 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -628,9 +628,9 @@ class KafkaController(val config: KafkaConfig, topi

[GitHub] [kafka] ableegoldman commented on pull request #11283: KAFKA-13249: Always update changelog offsets before writing the checkpoint file

2021-08-31 Thread GitBox
ableegoldman commented on pull request #11283: URL: https://github.com/apache/kafka/pull/11283#issuecomment-908748576 Hey @hutchiko , thanks for digging into this bug so thoroughly and providing a patch! One quick question before I review -- does this only affect version 2.8 or below speci

[GitHub] [kafka] junrao commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-08-31 Thread GitBox
junrao commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r698652526 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -628,9 +628,9 @@ class KafkaController(val config: KafkaConfig, topic

[GitHub] [kafka] hutchiko commented on a change in pull request #11283: KAFKA-13249: Always update changelog offsets before writing the checkpoint file

2021-08-31 Thread GitBox
hutchiko commented on a change in pull request #11283: URL: https://github.com/apache/kafka/pull/11283#discussion_r698898574 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -565,7 +565,7 @@ public void closeCleanAndRecycle

[jira] [Updated] (KAFKA-13256) Possible NPE in ConfigDef when rendering (enriched) RST or HTML when documentation is not set/NULL

2021-08-31 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-13256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] René Kerner updated KAFKA-13256: Remaining Estimate: 0.5h (was: 2h) Original Estimate: 0.5h (was: 2h) > Possible NPE in Conf

[jira] [Commented] (KAFKA-13256) Possible NPE in ConfigDef when rendering (enriched) RST or HTML when documentation is not set/NULL

2021-08-31 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-13256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407316#comment-17407316 ] René Kerner commented on KAFKA-13256: - PR available: https://github.com/apache/kafka

[GitHub] [kafka] rk3rn3r opened a new pull request #11287: KAFKA-13256 Fix possible NPE when ConfigDef renders RST or HTML and ConfigKey.documentation is unset/NULL

2021-08-31 Thread GitBox
rk3rn3r opened a new pull request #11287: URL: https://github.com/apache/kafka/pull/11287 closes https://issues.apache.org/jira/browse/KAFKA-13256 ### Committer Checklist (excluded from commit message) - [x] Verify design and implementation - [x] Verify test coverage and CI bui

[jira] [Updated] (KAFKA-13256) Possible NPE in ConfigDef when rendering (enriched) RST or HTML when documentation is not set/NULL

2021-08-31 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-13256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] René Kerner updated KAFKA-13256: Description: While working on Debezium I discovered the following issue: When Kafka's ConfigDef r

[jira] [Created] (KAFKA-13256) Possible NPE in ConfigDef when rendering (enriched) RST or HTML when documentation is not set/NULL

2021-08-31 Thread Jira
René Kerner created KAFKA-13256: --- Summary: Possible NPE in ConfigDef when rendering (enriched) RST or HTML when documentation is not set/NULL Key: KAFKA-13256 URL: https://issues.apache.org/jira/browse/KAFKA-13256

[jira] [Updated] (KAFKA-13256) Possible NPE in ConfigDef when rendering (enriched) RST or HTML when documentation is not set/NULL

2021-08-31 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-13256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] René Kerner updated KAFKA-13256: Remaining Estimate: 2h (was: 24h) Original Estimate: 2h (was: 24h) > Possible NPE in Config

[jira] [Updated] (KAFKA-12987) kafka Users don't have avoid brute-force mechanism

2021-08-31 Thread chenzongyi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenzongyi updated KAFKA-12987: --- Summary: kafka Users don't have avoid brute-force mechanism (was: kafka Users don't have avoid brut

[jira] [Updated] (KAFKA-12987) kafka Users don't have

2021-08-31 Thread chenzongyi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenzongyi updated KAFKA-12987: --- Summary: kafka Users don't have (was: kafka用户无密码防暴力破解功能) > kafka Users don't have > -

[jira] [Updated] (KAFKA-12987) kafka Users don't have avoid brute-force

2021-08-31 Thread chenzongyi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenzongyi updated KAFKA-12987: --- Summary: kafka Users don't have avoid brute-force (was: kafka Users don't have ) > kafka Users do

[GitHub] [kafka] dadufour commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely

2021-08-31 Thread GitBox
dadufour commented on pull request #11174: URL: https://github.com/apache/kafka/pull/11174#issuecomment-909121030 Any chance to have it in a 2.7.2? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] viktorsomogyi edited a comment on pull request #11276: KAFKA-13240: Disable HTTP TRACE Method in Connect

2021-08-31 Thread GitBox
viktorsomogyi edited a comment on pull request #11276: URL: https://github.com/apache/kafka/pull/11276#issuecomment-909037718 @mimaison would you please review this or suggest someone who can do it? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] viktorsomogyi commented on pull request #11276: KAFKA-13240: Disable HTTP TRACE Method in Connect

2021-08-31 Thread GitBox
viktorsomogyi commented on pull request #11276: URL: https://github.com/apache/kafka/pull/11276#issuecomment-909037718 @mimaison would you please review this or suggest someone? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] viktorsomogyi commented on pull request #11276: KAFKA-13240: Disable HTTP TRACE Method in Connect

2021-08-31 Thread GitBox
viktorsomogyi commented on pull request #11276: URL: https://github.com/apache/kafka/pull/11276#issuecomment-909037066 It seems like the failing tests are flaky, they are running successfully in my dev environment. -- This is an automated message from the Apache Git Service. To respond t

[jira] [Updated] (KAFKA-13092) Perf regression in LISR requests

2021-08-31 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-13092: Fix Version/s: 2.8.1 > Perf regression in LISR requests > > >

[GitHub] [kafka] dajac merged pull request #11073: KAFKA-13092: Perf regression in LISR requests

2021-08-31 Thread GitBox
dajac merged pull request #11073: URL: https://github.com/apache/kafka/pull/11073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] dajac commented on pull request #11073: KAFKA-13092: Perf regression in LISR requests

2021-08-31 Thread GitBox
dajac commented on pull request #11073: URL: https://github.com/apache/kafka/pull/11073#issuecomment-908971681 @junrao @lbradstreet Thanks for your reviews. The failures are not related. I will merge it to 2.8. -- This is an automated message from the Apache Git Service. To respond