Guozhang Wang created KAFKA-13239:
-
Summary: Use RocksDB.ingestExternalFile for restoration
Key: KAFKA-13239
URL: https://issues.apache.org/jira/browse/KAFKA-13239
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-12882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405630#comment-17405630
]
David Jacot commented on KAFKA-12882:
-
[~rdielhenn] I have split the ticket into two
[
https://issues.apache.org/jira/browse/KAFKA-13238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-13238:
---
Assignee: (was: David Jacot)
> Add ActiveBrokerCount and FencedBrokerCount metrics to t
David Jacot created KAFKA-13238:
---
Summary: Add ActiveBrokerCount and FencedBrokerCount metrics to
the KRaft controller (KIP-748)
Key: KAFKA-13238
URL: https://issues.apache.org/jira/browse/KAFKA-13238
P
David Jacot created KAFKA-13237:
---
Summary: Add ActiveBrokerCount and FencedBrokerCount metrics to
the ZK controller (KIP-748)
Key: KAFKA-13237
URL: https://issues.apache.org/jira/browse/KAFKA-13237
Proj
[
https://issues.apache.org/jira/browse/KAFKA-12882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-12882:
Summary: Add ActiveBrokerCount and FencedBrokerCount metrics (KIP-748)
(was: Add RegisteredBroker
[
https://issues.apache.org/jira/browse/KAFKA-13231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-13231.
-
Fix Version/s: 3.0.1
2.8.1
3.1.0
Reviewer: Jason G
dajac commented on pull request #11264:
URL: https://github.com/apache/kafka/pull/11264#issuecomment-906960791
Merged to trunk, 3.0 and 2.8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
dajac merged pull request #11264:
URL: https://github.com/apache/kafka/pull/11264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
dajac merged pull request #11225:
URL: https://github.com/apache/kafka/pull/11225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
[
https://issues.apache.org/jira/browse/KAFKA-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405612#comment-17405612
]
Binh Van Nguyen commented on KAFKA-8154:
[~gordonmessmer] I am using Kafka client
ableegoldman commented on pull request #11272:
URL: https://github.com/apache/kafka/pull/11272#issuecomment-906922473
@wcarlson5 split the config work out from the Pt. 4 branch, here's the PR as
promised. I ended up refactoring things a bit while I was pulling the changes
out to make thing
[
https://issues.apache.org/jira/browse/KAFKA-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405582#comment-17405582
]
Gordon commented on KAFKA-8154:
---
What version of the client library are you using in your a
[
https://issues.apache.org/jira/browse/KAFKA-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405582#comment-17405582
]
Gordon edited comment on KAFKA-8154 at 8/27/21, 4:47 AM:
-
What ve
ableegoldman opened a new pull request #11272:
URL: https://github.com/apache/kafka/pull/11272
Most configs that are read and used by Streams today originate from the
properties passed in to the KafkaStreams constructor, which means they get
applied universally across all threads, tasks, s
[
https://issues.apache.org/jira/browse/KAFKA-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405568#comment-17405568
]
Binh Van Nguyen commented on KAFKA-8154:
I also faced this issue. In may case, th
dielhennr commented on pull request #10463:
URL: https://github.com/apache/kafka/pull/10463#issuecomment-906901483
@junrao I don't have write access to this fork which is why I stacked my PR
onto this one instead of committing. My PR has no conflicts with this branch so
it should be mergea
mjsax opened a new pull request #11271:
URL: https://github.com/apache/kafka/pull/11271
Already fixed in `trunk`/`3.0`.
@dajac can we include this in 2.8.1 bug-fix release?
Call for review @ableegoldman
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/KAFKA-13236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-13236:
---
Assignee: Matthias J. Sax
> TopologyTestDriver crashes with EOS-beta config
> -
Matthias J. Sax created KAFKA-13236:
---
Summary: TopologyTestDriver crashes with EOS-beta config
Key: KAFKA-13236
URL: https://issues.apache.org/jira/browse/KAFKA-13236
Project: Kafka
Issue T
ableegoldman merged pull request #11263:
URL: https://github.com/apache/kafka/pull/11263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
ableegoldman commented on pull request #11263:
URL: https://github.com/apache/kafka/pull/11263#issuecomment-906828133
Two unrelated flaky test failures in the original build
(`ControllerIntegrationTest.testPartitionReassignmentToBrokerWithOfflineLogDir`
and `TransactionsTest.testCommitTran
ccding opened a new pull request #11270:
URL: https://github.com/apache/kafka/pull/11270
InvalidRequestException is not an error case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
guozhangwang merged pull request #11181:
URL: https://github.com/apache/kafka/pull/11181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsu
guozhangwang commented on pull request #11181:
URL: https://github.com/apache/kafka/pull/11181#issuecomment-906759194
Thanks for confirming, in that case it LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
guozhangwang commented on a change in pull request #11228:
URL: https://github.com/apache/kafka/pull/11228#discussion_r696990858
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -495,9 +498,25 @@ private void replaceStreamThread(final Throwab
guozhangwang commented on pull request #11228:
URL: https://github.com/apache/kafka/pull/11228#issuecomment-906753112
> But it doesn't seem related to the changes in this PR. I would say it
seems a newly found regression (there isn't a ticket yet).
Any opinions @cadonna @guozhangwang ?
guozhangwang commented on a change in pull request #11228:
URL: https://github.com/apache/kafka/pull/11228#discussion_r696987413
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -495,9 +498,25 @@ private void replaceStreamThread(final Throwab
guozhangwang commented on pull request #11228:
URL: https://github.com/apache/kafka/pull/11228#issuecomment-906751797
> Wouldn't it suffice to check the throwable variable in
KafkaStreams#handleStreamsUncaughtException() before line 500 where the
user-specified exception handler is execute
hachikuji commented on pull request #11267:
URL: https://github.com/apache/kafka/pull/11267#issuecomment-906734741
Successful test run for `group_transactions_test.py`:
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2021-08-26--001.system-test-kafka-bra
[
https://issues.apache.org/jira/browse/KAFKA-13234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405454#comment-17405454
]
Lucas Bradstreet commented on KAFKA-13234:
--
We do something similar in upgrade_
junrao merged pull request #11253:
URL: https://github.com/apache/kafka/pull/11253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr..
dajac commented on pull request #11264:
URL: https://github.com/apache/kafka/pull/11264#issuecomment-906709897
Successful run:
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2021-08-26--001.system-test-kafka-branch-builder--1630007187--dajac--KAFKA-1323
hachikuji commented on pull request #11267:
URL: https://github.com/apache/kafka/pull/11267#issuecomment-906705794
Successful test run for `transactions_test.py`:
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2021-08-26--001.system-test-kafka-branch-bu
hachikuji removed a comment on pull request #11268:
URL: https://github.com/apache/kafka/pull/11268#issuecomment-906702297
Successful test run for `transactions_test.py`:
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2021-08-26--001.system-test-kafka-b
hachikuji commented on pull request #11268:
URL: https://github.com/apache/kafka/pull/11268#issuecomment-906702297
Successful test run for `transactions_test.py`:
http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2021-08-26--001.system-test-kafka-branch-bu
kowshik commented on pull request #11253:
URL: https://github.com/apache/kafka/pull/11253#issuecomment-906698169
cc @lbradstreet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
jlprat commented on pull request #11228:
URL: https://github.com/apache/kafka/pull/11228#issuecomment-90213
Current failure is
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-11228/5/testReport/org.apache.kafka.streams.integration/NamedTopologyIntegrationTest/Build___JDK_8_an
dajac commented on pull request #11264:
URL: https://github.com/apache/kafka/pull/11264#issuecomment-906665382
New run to validate:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4665/
--
This is an automated message from the Apache Git Service.
To respond to the messa
dajac commented on pull request #11264:
URL: https://github.com/apache/kafka/pull/11264#issuecomment-906664923
@hachikuji updated the PR to add the node to the error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
dajac commented on a change in pull request #11265:
URL: https://github.com/apache/kafka/pull/11265#discussion_r696899123
##
File path:
tools/src/main/java/org/apache/kafka/tools/TransactionalMessageCopier.java
##
@@ -361,7 +361,7 @@ public void onPartitionsAssigned(Collection
[
https://issues.apache.org/jira/browse/KAFKA-13227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405420#comment-17405420
]
Jason Gustafson commented on KAFKA-13227:
-
[~christo_lolov] Thanks, feel free to
hachikuji commented on a change in pull request #11267:
URL: https://github.com/apache/kafka/pull/11267#discussion_r696889046
##
File path: tests/kafkatest/tests/core/transactions_test.py
##
@@ -108,6 +108,10 @@ def bounce_brokers(self, clean_shutdown):
tim
hachikuji opened a new pull request #11268:
URL: https://github.com/apache/kafka/pull/11268
This patch has a couple small improvements to `TransactionalMessageCopier`
logging:
- Log all fatal exceptions which cause the copier to shutdown unexpectedly
- Log all non-fatal exceptions
ijuma commented on a change in pull request #11267:
URL: https://github.com/apache/kafka/pull/11267#discussion_r69688
##
File path: tests/kafkatest/tests/core/transactions_test.py
##
@@ -108,6 +108,10 @@ def bounce_brokers(self, clean_shutdown):
time.sl
ijuma commented on a change in pull request #11267:
URL: https://github.com/apache/kafka/pull/11267#discussion_r696883461
##
File path: tests/kafkatest/tests/core/transactions_test.py
##
@@ -108,6 +108,10 @@ def bounce_brokers(self, clean_shutdown):
time.sl
hachikuji commented on a change in pull request #11267:
URL: https://github.com/apache/kafka/pull/11267#discussion_r696881720
##
File path: tests/kafkatest/tests/core/transactions_test.py
##
@@ -108,6 +108,10 @@ def bounce_brokers(self, clean_shutdown):
tim
Jason Gustafson created KAFKA-13235:
---
Summary: Add support for static groups to transaction system tests
Key: KAFKA-13235
URL: https://issues.apache.org/jira/browse/KAFKA-13235
Project: Kafka
hachikuji commented on a change in pull request #11265:
URL: https://github.com/apache/kafka/pull/11265#discussion_r696878332
##
File path:
tools/src/main/java/org/apache/kafka/tools/TransactionalMessageCopier.java
##
@@ -361,7 +361,7 @@ public void onPartitionsAssigned(Collec
ijuma commented on a change in pull request #11267:
URL: https://github.com/apache/kafka/pull/11267#discussion_r696876840
##
File path: tests/kafkatest/tests/core/transactions_test.py
##
@@ -108,6 +108,10 @@ def bounce_brokers(self, clean_shutdown):
time.sl
hachikuji commented on a change in pull request #11266:
URL: https://github.com/apache/kafka/pull/11266#discussion_r696875779
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -2344,17 +2344,17 @@ class KafkaController(val config: KafkaConfig,
hachikuji opened a new pull request #11267:
URL: https://github.com/apache/kafka/pull/11267
Clearing under-replicated-partitions helps ensure that partitions do not
become unavailable longer than necessary as brokers are rolled. This prevents
flakiness due to transaction timeouts.
#
hachikuji commented on a change in pull request #11266:
URL: https://github.com/apache/kafka/pull/11266#discussion_r696859115
##
File path: core/src/main/scala/kafka/controller/PartitionStateMachine.scala
##
@@ -437,6 +437,11 @@ class ZkPartitionStateMachine(config: KafkaConfig
mumrah commented on pull request #11266:
URL: https://github.com/apache/kafka/pull/11266#issuecomment-906622164
> A side question is whether any of the zk updates in ReplicaStateMachine
and PartitionStateMachine need similar enhancements?
Added a debug of the partitions to retry in t
Jason Gustafson created KAFKA-13234:
---
Summary: Transaction system tests should check URPs between broker
bounces
Key: KAFKA-13234
URL: https://issues.apache.org/jira/browse/KAFKA-13234
Project: Kafk
jolshan commented on pull request #11073:
URL: https://github.com/apache/kafka/pull/11073#issuecomment-906611414
Ok will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
dajac commented on pull request #11073:
URL: https://github.com/apache/kafka/pull/11073#issuecomment-906600948
@jolshan All tests failed, again. I think that you have to rebase to include
the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
hachikuji commented on a change in pull request #11266:
URL: https://github.com/apache/kafka/pull/11266#discussion_r696830865
##
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##
@@ -2345,14 +2345,14 @@ class KafkaController(val config: KafkaConfig,
mumrah opened a new pull request #11266:
URL: https://github.com/apache/kafka/pull/11266
When debugging issues with partition state, it's very useful to know the
zkVersion that was written. This patch adds the zkVersion of LeaderAndIsr in a
few more places.
--
This is an automated messa
dajac commented on a change in pull request #11265:
URL: https://github.com/apache/kafka/pull/11265#discussion_r696818318
##
File path:
tools/src/main/java/org/apache/kafka/tools/TransactionalMessageCopier.java
##
@@ -361,7 +361,7 @@ public void onPartitionsAssigned(Collection
hachikuji commented on a change in pull request #11265:
URL: https://github.com/apache/kafka/pull/11265#discussion_r696814285
##
File path:
tools/src/main/java/org/apache/kafka/tools/TransactionalMessageCopier.java
##
@@ -361,7 +361,7 @@ public void onPartitionsAssigned(Collec
hachikuji commented on a change in pull request #11264:
URL: https://github.com/apache/kafka/pull/11264#discussion_r696813850
##
File path: tests/kafkatest/services/transactional_message_copier.py
##
@@ -159,12 +159,16 @@ def pids(self, node):
def alive(self, node):
David Arthur created KAFKA-13233:
Summary: Log the partition state zkVersion in more places in the
controller
Key: KAFKA-13233
URL: https://issues.apache.org/jira/browse/KAFKA-13233
Project: Kafka
dajac commented on a change in pull request #11265:
URL: https://github.com/apache/kafka/pull/11265#discussion_r696812903
##
File path:
tools/src/main/java/org/apache/kafka/tools/TransactionalMessageCopier.java
##
@@ -361,7 +361,7 @@ public void onPartitionsAssigned(Collection
hachikuji commented on a change in pull request #11265:
URL: https://github.com/apache/kafka/pull/11265#discussion_r696810930
##
File path:
tools/src/main/java/org/apache/kafka/tools/TransactionalMessageCopier.java
##
@@ -361,7 +361,7 @@ public void onPartitionsAssigned(Collec
jlprat commented on a change in pull request #11228:
URL: https://github.com/apache/kafka/pull/11228#discussion_r696809049
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/EmitOnChangeIntegrationTest.java
##
@@ -104,7 +104,7 @@ public void shouldEmitSam
junrao commented on pull request #10463:
URL: https://github.com/apache/kafka/pull/10463#issuecomment-906572591
Thanks @dielhennr . Could you rebase this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
jlprat commented on pull request #11228:
URL: https://github.com/apache/kafka/pull/11228#issuecomment-906570612
Tests failures seem related, I will investigate them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jlprat closed pull request #11228:
URL: https://github.com/apache/kafka/pull/11228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr..
junrao commented on a change in pull request #11060:
URL: https://github.com/apache/kafka/pull/11060#discussion_r696789655
##
File path:
server-common/src/main/java/org/apache/kafka/server/common/SnapshotFile.java
##
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the Apache Software Fo
dajac commented on pull request #11073:
URL: https://github.com/apache/kafka/pull/11073#issuecomment-906522684
> I think you may be able to just restart the build. (I think only
committers can do that). If that doesn't work, I'll rebase.
Done, thanks.
--
This is an automated messa
jasonyanwenl commented on a change in pull request #11241:
URL: https://github.com/apache/kafka/pull/11241#discussion_r696737354
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFlatMapTest.java
##
@@ -86,4 +88,12 @@ public void testFlatMap
jolshan commented on pull request #11073:
URL: https://github.com/apache/kafka/pull/11073#issuecomment-906500017
I think you may be able to just restart the build. (I think only committers
can do that). If that doesn't work, I'll rebase.
--
This is an automated message from the Apache Gi
ccding commented on pull request #0:
URL: https://github.com/apache/kafka/pull/0#issuecomment-906457166
Thank you @satishd
Addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
0x1991babe closed pull request #11014:
URL: https://github.com/apache/kafka/pull/11014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubs
showuon commented on pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#issuecomment-906431308
@mjsax @vvcephei @guozhangwang , could you have a look at this POC when
available? I need your advice before I can update the KIP and continue to the
DISCUSS/VOTE process. Thank
jlprat commented on pull request #11228:
URL: https://github.com/apache/kafka/pull/11228#issuecomment-906397381
Ping @cadonna and @guozhangwang
Let me know what you think about this version. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message,
jlprat commented on a change in pull request #11228:
URL: https://github.com/apache/kafka/pull/11228#discussion_r696609988
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -495,9 +498,25 @@ private void replaceStreamThread(final Throwable
th
showuon commented on a change in pull request #11242:
URL: https://github.com/apache/kafka/pull/11242#discussion_r696592661
##
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##
@@ -1066,12 +1068,22 @@ private Topology getStatefulTopology(final S
dajac commented on pull request #11073:
URL: https://github.com/apache/kafka/pull/11073#issuecomment-906334811
Do you need to rebase the PR to include it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dajac commented on pull request #11264:
URL: https://github.com/apache/kafka/pull/11264#issuecomment-906316909
> Transactions system tests:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4663/
All tests have passed:
http://confluent-kafka-branch-builder-system-tes
[
https://issues.apache.org/jira/browse/KAFKA-13232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pranciskus Gecas updated KAFKA-13232:
-
Priority: Minor (was: Major)
> UnknownTopicOrPartitionException for loading topic durin
Pranciskus Gecas created KAFKA-13232:
Summary: UnknownTopicOrPartitionException for loading topic during
broker startup.
Key: KAFKA-13232
URL: https://issues.apache.org/jira/browse/KAFKA-13232
Pro
dajac opened a new pull request #11265:
URL: https://github.com/apache/kafka/pull/11265
`ExactlyOnceMessageProcessor` is the reference so this patch updates
`TransactionalMessageCopier` to be similar.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and i
dajac commented on pull request #11264:
URL: https://github.com/apache/kafka/pull/11264#issuecomment-90626
Transactions system tests:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4663/
--
This is an automated message from the Apache Git Service.
To respond to the
dajac opened a new pull request #11264:
URL: https://github.com/apache/kafka/pull/11264
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
David Jacot created KAFKA-13231:
---
Summary: `TransactionalMessageCopier.start_node` should wait until
the process if fully started
Key: KAFKA-13231
URL: https://issues.apache.org/jira/browse/KAFKA-13231
satishd commented on pull request #0:
URL: https://github.com/apache/kafka/pull/0#issuecomment-906243973
@junrao The intention of the PR looks reasonable to me. I left a comment
[here](https://github.com/apache/kafka/pull/0#discussion_r696454031) on one
of the changes.
--
satishd commented on a change in pull request #0:
URL: https://github.com/apache/kafka/pull/0#discussion_r696454031
##
File path:
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java
##
@@ -253,9 +253,9 @@ public RemoteLogManager
showuon commented on a change in pull request #9858:
URL: https://github.com/apache/kafka/pull/9858#discussion_r696447534
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -75,9 +76,19 @@
@Category(IntegrationTest.
Luke Chen created KAFKA-13230:
-
Summary: port EmbeddedKafkaCluster back to auto clean up way
Key: KAFKA-13230
URL: https://issues.apache.org/jira/browse/KAFKA-13230
Project: Kafka
Issue Type: Imp
cadonna commented on pull request #11228:
URL: https://github.com/apache/kafka/pull/11228#issuecomment-906227809
@guozhangwang What do you mean exactly by "this would require us to add
another private function like
handleStreamsUncaughtException(StreamThreadExceptionResponse)"?
Wouldn'
cadonna commented on pull request #11241:
URL: https://github.com/apache/kafka/pull/11241#issuecomment-906204832
> > Thanks for the PR @jasonyanwenl !
> > Here my feedback!
> > I think we should consider to introduce a specific exception for
exceptions that originate from user code. S
cadonna commented on a change in pull request #11241:
URL: https://github.com/apache/kafka/pull/11241#discussion_r696409669
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFlatMapTest.java
##
@@ -86,4 +88,12 @@ public void testFlatMap() {
dajac commented on pull request #11104:
URL: https://github.com/apache/kafka/pull/11104#issuecomment-906181988
Started a new build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
showuon commented on a change in pull request #11227:
URL: https://github.com/apache/kafka/pull/11227#discussion_r696369857
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java
##
@@ -124,8 +124,8 @@
fi
showuon commented on pull request #11227:
URL: https://github.com/apache/kafka/pull/11227#issuecomment-906167845
@patrickstuedi , thanks for the comments. I've addressed all your comments
and add test coverage. Please take a look again. Thank you.
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/KAFKA-13227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405006#comment-17405006
]
Christo Lolov commented on KAFKA-13227:
---
Hello,
I would be interested in picking
98 matches
Mail list logo
