[jira] [Commented] (KAFKA-12698) CVE-2019-25013 high priority vulnerability reported in Kafka

2021-04-22 Thread priya Vijay (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17330046#comment-17330046 ] priya Vijay commented on KAFKA-12698: - can someone please provide some insight in to

[jira] [Updated] (KAFKA-12698) CVE-2019-25013 high priority vulnerability reported in Kafka

2021-04-22 Thread priya Vijay (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] priya Vijay updated KAFKA-12698: Summary: CVE-2019-25013 high priority vulnerability reported in Kafka (was: CVE-2019-25013 vulne

[GitHub] [kafka] highluck commented on pull request #9640: KAFKA-10283; Consolidate client-level and consumer-level assignment within ClientState

2021-04-22 Thread GitBox
highluck commented on pull request #9640: URL: https://github.com/apache/kafka/pull/9640#issuecomment-825427682 @guozhangwang Yes, I checked, but the logic was not changed except for assignActiveToConsumer, so the test is consistent. There seems to be no problem locally! -- This i

[GitHub] [kafka] vitojeng commented on pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2021-04-22 Thread GitBox
vitojeng commented on pull request #9821: URL: https://github.com/apache/kafka/pull/9821#issuecomment-825407840 @ableegoldman The PR build is done, please talk a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] guozhangwang commented on pull request #9640: KAFKA-10283; Consolidate client-level and consumer-level assignment within ClientState

2021-04-22 Thread GitBox
guozhangwang commented on pull request #9640: URL: https://github.com/apache/kafka/pull/9640#issuecomment-825384541 @highluck I'm re-triggering the unit test again, at the mean time, could you also run them locally and see if the failed tests are consistent? -- This is an automated messa

[GitHub] [kafka] showuon commented on pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-22 Thread GitBox
showuon commented on pull request #9627: URL: https://github.com/apache/kafka/pull/9627#issuecomment-825382213 Failed test cases are unrelated and flaky (all passed in my local env). Thanks. ``` Build / JDK 15 and Scala 2.13 / kafka.network.DynamicConnectionQuotaTest.testDynamicL

[GitHub] [kafka] ableegoldman commented on pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-22 Thread GitBox
ableegoldman commented on pull request #10573: URL: https://github.com/apache/kafka/pull/10573#issuecomment-825367328 @mjsax thanks for the review, addressed your comments please give it another pass -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ableegoldman commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-22 Thread GitBox
ableegoldman commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r618914490 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -1010,18 +1026,51 @@ public StreamsConfig(final Map props) {

[GitHub] [kafka] ableegoldman commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-22 Thread GitBox
ableegoldman commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r618912905 ## File path: docs/streams/upgrade-guide.html ## @@ -53,17 +53,19 @@ Upgrade Guide and API Changes -Starting in Kafka Streams 2

[GitHub] [kafka] ableegoldman commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-22 Thread GitBox
ableegoldman commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r618912357 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -667,12 +668,14 @@ probing.rebalance.interval.msprocessing.guarantee

[GitHub] [kafka] ableegoldman commented on a change in pull request #10573: KAFKA-12574: KIP-732, Deprecate eos-alpha and replace eos-beta with eos-v2

2021-04-22 Thread GitBox
ableegoldman commented on a change in pull request #10573: URL: https://github.com/apache/kafka/pull/10573#discussion_r618911355 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -642,9 +647,13 @@ public void beginTransaction() thro

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-22 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r618910174 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] ableegoldman commented on pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-22 Thread GitBox
ableegoldman commented on pull request #9627: URL: https://github.com/apache/kafka/pull/9627#issuecomment-825355637 > I'll ping @chia7712 when the build tests completed. He is in the same timezone with me. :) Perfect. Go team -- This is an automated message from the Apache Git Ser

[GitHub] [kafka] showuon commented on pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-22 Thread GitBox
showuon commented on pull request #9627: URL: https://github.com/apache/kafka/pull/9627#issuecomment-825354532 @ableegoldman , thank you very much! I'll ping @chia7712 when the build tests completed. He is in the same timezone with me. :) And @chia7712 , thanks for following up for this

[GitHub] [kafka] wenbingshen commented on a change in pull request #10588: KAFKA-12662: add unit test for ProducerPerformance

2021-04-22 Thread GitBox
wenbingshen commented on a change in pull request #10588: URL: https://github.com/apache/kafka/pull/10588#discussion_r618900520 ## File path: tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java ## @@ -190,6 +166,51 @@ public static void main(String[] args) throw

[GitHub] [kafka] showuon commented on a change in pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-22 Thread GitBox
showuon commented on a change in pull request #9627: URL: https://github.com/apache/kafka/pull/9627#discussion_r618894302 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -1386,7 +1400,7 @@ public void run() {

[GitHub] [kafka] showuon commented on pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-22 Thread GitBox
showuon commented on pull request #9627: URL: https://github.com/apache/kafka/pull/9627#issuecomment-825339296 @ableegoldman @kkonstantine , thanks for the good comments. It makes the change smaller and simpler. Please help check again. Thank you. -- This is an automated message from the

[GitHub] [kafka] showuon commented on a change in pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-22 Thread GitBox
showuon commented on a change in pull request #9627: URL: https://github.com/apache/kafka/pull/9627#discussion_r618893986 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -1023,9 +1023,14 @@ protected void close(Tim

[GitHub] [kafka] cmccabe opened a new pull request #10589: MINOR: add defaults to TopicConfig.java

2021-04-22 Thread GitBox
cmccabe opened a new pull request #10589: URL: https://github.com/apache/kafka/pull/10589 Add default values for the configurations to TopicConfig.java. Eventually we want to move all of the log configurations into TopicConfig.java, and this is a good step along the way. -- This is

[GitHub] [kafka] dengziming commented on a change in pull request #10588: KAFKA-12662: add unit test for ProducerPerformance

2021-04-22 Thread GitBox
dengziming commented on a change in pull request #10588: URL: https://github.com/apache/kafka/pull/10588#discussion_r618874302 ## File path: build.gradle ## @@ -1485,7 +1485,7 @@ project(':tools') { testImplementation libs.junitJupiter testImplementation project(':cli

[GitHub] [kafka] dengziming commented on pull request #10576: KAFKA-12701: Remove topicId from MetadataReq since it was not supported in 2.8.0

2021-04-22 Thread GitBox
dengziming commented on pull request #10576: URL: https://github.com/apache/kafka/pull/10576#issuecomment-825322789 Thank you @junrao @jolshan , move to #10584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] dengziming closed pull request #10576: KAFKA-12701: Remove topicId from MetadataReq since it was not supported in 2.8.0

2021-04-22 Thread GitBox
dengziming closed pull request #10576: URL: https://github.com/apache/kafka/pull/10576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[jira] [Commented] (KAFKA-10619) Producer will enable EOS by default

2021-04-22 Thread Soumyajit Sahu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329915#comment-17329915 ] Soumyajit Sahu commented on KAFKA-10619: Hi Cheng, I would like to raise an iss

[GitHub] [kafka] vitojeng commented on a change in pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2021-04-22 Thread GitBox
vitojeng commented on a change in pull request #9821: URL: https://github.com/apache/kafka/pull/9821#discussion_r618840083 ## File path: docs/streams/upgrade-guide.html ## @@ -93,6 +93,9 @@ Upgrade Guide and API Changes Streams API changes in 3.0.0 + +W

[GitHub] [kafka] ableegoldman commented on pull request #10482: KAFKA-12499: add transaction timeout verification

2021-04-22 Thread GitBox
ableegoldman commented on pull request #10482: URL: https://github.com/apache/kafka/pull/10482#issuecomment-825278618 @abbccdda it looks like some eos test failed in the PR build, guessing it's related -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kafka] ableegoldman commented on a change in pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

2021-04-22 Thread GitBox
ableegoldman commented on a change in pull request #9821: URL: https://github.com/apache/kafka/pull/9821#discussion_r618828160 ## File path: docs/streams/upgrade-guide.html ## @@ -93,6 +93,9 @@ Upgrade Guide and API Changes Streams API changes in 3.0.0 + +

[GitHub] [kafka] ableegoldman commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-22 Thread GitBox
ableegoldman commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r618826641 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/Serdes.java ## @@ -128,13 +128,27 @@ public UUIDSerde() { static publ

[GitHub] [kafka] ableegoldman commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-22 Thread GitBox
ableegoldman commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r618826368 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -77,21 +87,39 @@ public void configure(Map configs

[GitHub] [kafka] ableegoldman commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-22 Thread GitBox
ableegoldman commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r618824748 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache So

[GitHub] [kafka] ableegoldman commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-22 Thread GitBox
ableegoldman commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r618824127 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache So

[GitHub] [kafka] ableegoldman commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-22 Thread GitBox
ableegoldman commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r618824127 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache So

[GitHub] [kafka] ableegoldman commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-22 Thread GitBox
ableegoldman commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r618824127 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache So

[GitHub] [kafka] ableegoldman commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-22 Thread GitBox
ableegoldman commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r618823669 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache So

[GitHub] [kafka] ableegoldman commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-22 Thread GitBox
ableegoldman commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r618823378 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache So

[GitHub] [kafka] ableegoldman commented on a change in pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-22 Thread GitBox
ableegoldman commented on a change in pull request #9627: URL: https://github.com/apache/kafka/pull/9627#discussion_r618821079 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerGroupMember.java ## @@ -202,7 +202,7 @@ public void req

[GitHub] [kafka] chia7712 commented on a change in pull request #10582: MINOR: Bump latest 2.6 version to 2.6.2

2021-04-22 Thread GitBox
chia7712 commented on a change in pull request #10582: URL: https://github.com/apache/kafka/pull/10582#discussion_r618815048 ## File path: tests/docker/Dockerfile ## @@ -60,7 +60,7 @@ RUN mkdir -p "/opt/kafka-2.2.2" && chmod a+rw /opt/kafka-2.2.2 && curl -s "$KAFK RUN mkdir -

[jira] [Created] (KAFKA-12710) Consider enabling (at least some) optimizations by default

2021-04-22 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-12710: -- Summary: Consider enabling (at least some) optimizations by default Key: KAFKA-12710 URL: https://issues.apache.org/jira/browse/KAFKA-12710 Project

[jira] [Commented] (KAFKA-10493) KTable out-of-order updates are not being ignored

2021-04-22 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329888#comment-17329888 ] A. Sophie Blee-Goldman commented on KAFKA-10493: Imo we should find a wa

[GitHub] [kafka] Nathan22177 commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-22 Thread GitBox
Nathan22177 commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r618795692 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -234,13 +247,15 @@ public V delete(final

[GitHub] [kafka] Nathan22177 commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-22 Thread GitBox
Nathan22177 commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r618783595 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -234,13 +247,15 @@ public V delete(final

[GitHub] [kafka] mjsax commented on pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-22 Thread GitBox
mjsax commented on pull request #9627: URL: https://github.com/apache/kafka/pull/9627#issuecomment-825210429 @ableegoldman Can you have a look into this PR -- you are familiar with the consumer code. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mjsax commented on a change in pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-22 Thread GitBox
mjsax commented on a change in pull request #10548: URL: https://github.com/apache/kafka/pull/10548#discussion_r618760487 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java ## @@ -219,11 +224,19 @@ public V putIfAbsent(final

[GitHub] [kafka] junrao commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-22 Thread GitBox
junrao commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r618761439 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1057,83 @@ void validateManualPartitionAssi

[GitHub] [kafka] ableegoldman commented on a change in pull request #10582: MINOR: Bump latest 2.6 version to 2.6.2

2021-04-22 Thread GitBox
ableegoldman commented on a change in pull request #10582: URL: https://github.com/apache/kafka/pull/10582#discussion_r618753516 ## File path: tests/docker/Dockerfile ## @@ -60,7 +60,7 @@ RUN mkdir -p "/opt/kafka-2.2.2" && chmod a+rw /opt/kafka-2.2.2 && curl -s "$KAFK RUN mkd

[GitHub] [kafka] kpatelatwork edited a comment on pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-22 Thread GitBox
kpatelatwork edited a comment on pull request #10530: URL: https://github.com/apache/kafka/pull/10530#issuecomment-825190538 @tombentley and @C0urante Thanks for the above comment. I peeked at the code for upgrading to Apache HttpClient and this seems like a big work especially aro

[GitHub] [kafka] kpatelatwork commented on pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-22 Thread GitBox
kpatelatwork commented on pull request #10530: URL: https://github.com/apache/kafka/pull/10530#issuecomment-825190538 @tombentley and @C0urante Thanks for the above comment. I peeked at the code for upgrading to Apache HttpClient and this seems like a big work especially around the

[GitHub] [kafka] Nathan22177 edited a comment on pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-22 Thread GitBox
Nathan22177 edited a comment on pull request #10548: URL: https://github.com/apache/kafka/pull/10548#issuecomment-825160003 Ooo. I see. Yea, sorry, I also completely overlooked the wrapped key part. I'll fix it. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] Nathan22177 commented on pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-22 Thread GitBox
Nathan22177 commented on pull request #10548: URL: https://github.com/apache/kafka/pull/10548#issuecomment-825160003 Ooo. I see yea sorry I also completely looked over the wrapped key part. I'll fix it. -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Commented] (KAFKA-10493) KTable out-of-order updates are not being ignored

2021-04-22 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329387#comment-17329387 ] Bruno Cadonna commented on KAFKA-10493: --- Good point about the compaction!   {quot

[jira] [Commented] (KAFKA-10493) KTable out-of-order updates are not being ignored

2021-04-22 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329373#comment-17329373 ] Matthias J. Sax commented on KAFKA-10493: - {quote}verify the order during restor

[jira] [Comment Edited] (KAFKA-10800) Validate the snapshot id when the state machine creates a snapshot

2021-04-22 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329364#comment-17329364 ] Jose Armando Garcia Sancio edited comment on KAFKA-10800 at 4/22/21, 7:05 PM:

[jira] [Commented] (KAFKA-10800) Validate the snapshot id when the state machine creates a snapshot

2021-04-22 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329364#comment-17329364 ] Jose Armando Garcia Sancio commented on KAFKA-10800: 1) What does "t

[GitHub] [kafka] ableegoldman commented on a change in pull request #10582: MINOR: Bump latest 2.6 version to 2.6.2

2021-04-22 Thread GitBox
ableegoldman commented on a change in pull request #10582: URL: https://github.com/apache/kafka/pull/10582#discussion_r618639618 ## File path: tests/docker/Dockerfile ## @@ -60,7 +60,7 @@ RUN mkdir -p "/opt/kafka-2.2.2" && chmod a+rw /opt/kafka-2.2.2 && curl -s "$KAFK RUN mkd

[GitHub] [kafka] mjsax commented on pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-22 Thread GitBox
mjsax commented on pull request #10548: URL: https://github.com/apache/kafka/pull/10548#issuecomment-825070459 > They do? Since 2017 according to annotations? Might be that we're talking different classes? The input parameter is `Windowed sessionKey` and the check is if `sessionKey

[GitHub] [kafka] tang7526 commented on pull request #10534: KAFKA-806: Index may not always observe log.index.interval.bytes

2021-04-22 Thread GitBox
tang7526 commented on pull request #10534: URL: https://github.com/apache/kafka/pull/10534#issuecomment-825051965 @chia7712 Could you help to review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [kafka] tang7526 commented on pull request #10588: KAFKA-12662: add unit test for ProducerPerformance

2021-04-22 Thread GitBox
tang7526 commented on pull request #10588: URL: https://github.com/apache/kafka/pull/10588#issuecomment-825051567 @chia7712 Could you help to review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (KAFKA-9895) Truncation request on broker start up may cause OffsetOutOfRangeException

2021-04-22 Thread Konstantin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329317#comment-17329317 ] Konstantin commented on KAFKA-9895: --- We bumped into this as well on kafka 2.4.1. Here'

[GitHub] [kafka] jolshan commented on pull request #10584: KAFKA-12701: NPE in MetadataRequest when using topic IDs

2021-04-22 Thread GitBox
jolshan commented on pull request #10584: URL: https://github.com/apache/kafka/pull/10584#issuecomment-825041572 Test failures look unrelated. Some of the usual suspects like `RaftClusterTest.testCreateClusterAndCreateAndManyTopicsWithManyPartitions()` and `MirrorConnectorsIntegrationSSLTe

[jira] [Created] (KAFKA-12709) Admin API for ListTransactions

2021-04-22 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-12709: --- Summary: Admin API for ListTransactions Key: KAFKA-12709 URL: https://issues.apache.org/jira/browse/KAFKA-12709 Project: Kafka Issue Type: Sub-task

[jira] [Resolved] (KAFKA-12586) Admin API for DescribeTransactions

2021-04-22 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12586. - Resolution: Fixed > Admin API for DescribeTransactions > ---

[GitHub] [kafka] hachikuji merged pull request #10483: KAFKA-12586; Add `DescribeTransactions` Admin API

2021-04-22 Thread GitBox
hachikuji merged pull request #10483: URL: https://github.com/apache/kafka/pull/10483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [kafka] hachikuji commented on pull request #10483: KAFKA-12586; Add `DescribeTransactions` Admin API

2021-04-22 Thread GitBox
hachikuji commented on pull request #10483: URL: https://github.com/apache/kafka/pull/10483#issuecomment-824996875 @dajac Thanks for reviewing. I will go ahead and merge since the only failures look like the usual MM ones. @chia7712 Feel free to leave additional comments and I can a

[GitHub] [kafka] tang7526 opened a new pull request #10588: KAFKA-12662: add unit test for ProducerPerformance

2021-04-22 Thread GitBox
tang7526 opened a new pull request #10588: URL: https://github.com/apache/kafka/pull/10588 https://issues.apache.org/jira/browse/KAFKA-12662 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build sta

[GitHub] [kafka] kkonstantine commented on a change in pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-22 Thread GitBox
kkonstantine commented on a change in pull request #9627: URL: https://github.com/apache/kafka/pull/9627#discussion_r618521825 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -1023,9 +1023,14 @@ protected void clos

[GitHub] [kafka] kpatelatwork commented on pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-22 Thread GitBox
kpatelatwork commented on pull request #10530: URL: https://github.com/apache/kafka/pull/10530#issuecomment-824873571 Great catch @C0urante . Let me investigate what it takes to upgrade to an Apache HttpClient and how much of an effort it is. I Agree a seemingly simple change doesn't seem

[GitHub] [kafka] tombentley commented on pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-22 Thread GitBox
tombentley commented on pull request #10530: URL: https://github.com/apache/kafka/pull/10530#issuecomment-824864967 Great spot @C0urante! I completely agree we shouldn't break working single-node distributed installs and that trying to fix this validation approach is going to end up being

[GitHub] [kafka] Nathan22177 commented on pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-22 Thread GitBox
Nathan22177 commented on pull request #10548: URL: https://github.com/apache/kafka/pull/10548#issuecomment-824842899 Tests for aforementioned checks were added here: https://github.com/apache/kafka/pull/9520/files#diff-dc416cbdf3efca7ee284fe1e27110e737c4178b7a1cc0696d9d7a72bb8e6e764

[GitHub] [kafka] C0urante commented on pull request #10074: KAFKA-12305: Fix Flatten SMT for array types

2021-04-22 Thread GitBox
C0urante commented on pull request #10074: URL: https://github.com/apache/kafka/pull/10074#issuecomment-824801861 Thanks @tombentley--good call on updating the docs; I've done that. RE a test for the recursive case--I don't think it'll hurt, so I updated the existing tests to include it. P

[GitHub] [kafka] Nathan22177 commented on pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-22 Thread GitBox
Nathan22177 commented on pull request #10548: URL: https://github.com/apache/kafka/pull/10548#issuecomment-824839639 And both are covered with tests. ![image](https://user-images.githubusercontent.com/44339288/115722128-5c563c80-a387-11eb-9646-37a626827129.png) -- This is an autom

[GitHub] [kafka] Nathan22177 commented on pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-22 Thread GitBox
Nathan22177 commented on pull request #10548: URL: https://github.com/apache/kafka/pull/10548#issuecomment-824837667 > > All of them already had the checks. > > Sweet. I did not double check the code before. > > Seems, `put(final Windowed sessionKey,...)` and `remove(final Win

[GitHub] [kafka] Nathan22177 edited a comment on pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-22 Thread GitBox
Nathan22177 edited a comment on pull request #10548: URL: https://github.com/apache/kafka/pull/10548#issuecomment-824837667 > Seems, `put(final Windowed sessionKey,...)` and `remove(final Windowed sessionKey)` don't check for `sessionKey.key() != null` though? Can we add this check?

[GitHub] [kafka] C0urante commented on pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-22 Thread GitBox
C0urante commented on pull request #10530: URL: https://github.com/apache/kafka/pull/10530#issuecomment-824847306 I've just realized--this may not be a safe change to make. Although we should fail fast on startup if a worker tries to join an existing cluster with a bad hostname, it's still

[GitHub] [kafka] cadonna opened a new pull request #10587: KAFKA-8897: Upgrade RocksDB to 6.8.1

2021-04-22 Thread GitBox
cadonna opened a new pull request #10587: URL: https://github.com/apache/kafka/pull/10587 RocksDB 6.8.1 is the newest version I could upgrade without running into a SIGABRT issue with error message "Pure virtual function called!" during Gradle builds. ### Committer Checklist (ex

[GitHub] [kafka] tombentley commented on pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

2021-04-22 Thread GitBox
tombentley commented on pull request #9441: URL: https://github.com/apache/kafka/pull/9441#issuecomment-824800741 Thanks @hachikuji, it's much simpler now, if you could take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] tombentley commented on a change in pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-22 Thread GitBox
tombentley commented on a change in pull request #10530: URL: https://github.com/apache/kafka/pull/10530#discussion_r618372208 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServer.java ## @@ -357,21 +358,53 @@ public URI advertisedUrl()

[GitHub] [kafka] showuon commented on pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-22 Thread GitBox
showuon commented on pull request #9627: URL: https://github.com/apache/kafka/pull/9627#issuecomment-824786063 All failed tests are flaky and unrelated. ``` Build / JDK 11 and Scala 2.13 / kafka.server.RaftClusterTest.testCreateClusterAndCreateListDeleteTopic() Build / JDK

[GitHub] [kafka] tombentley commented on a change in pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

2021-04-22 Thread GitBox
tombentley commented on a change in pull request #9441: URL: https://github.com/apache/kafka/pull/9441#discussion_r618358643 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -905,19 +908,32 @@ class GroupCoordinator(val brokerId: Int, *

[GitHub] [kafka] showuon commented on pull request #10547: KAFKA-12284: increase request timeout to make tests reliable

2021-04-22 Thread GitBox
showuon commented on pull request #10547: URL: https://github.com/apache/kafka/pull/10547#issuecomment-824789512 Failed tests are ``` Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationSSLTest.testReplication() Build / JDK

[jira] [Commented] (KAFKA-10493) KTable out-of-order updates are not being ignored

2021-04-22 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17327212#comment-17327212 ] Bruno Cadonna commented on KAFKA-10493: --- The options that I see are: # verify the

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-22 Thread GitBox
satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r618227233 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/AbstractApiMessageAndVersionSerde.java ## @@ -0,0 +

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-22 Thread GitBox
satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r618229816 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/AbstractMetadataMessageSerde.java ## @@ -19,52 +19,

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-22 Thread GitBox
satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r618228663 ## File path: build.gradle ## @@ -1410,6 +1410,7 @@ project(':storage') { implementation project(':storage:api') implementation project(':client

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-22 Thread GitBox
satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r618227233 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/AbstractApiMessageAndVersionSerde.java ## @@ -0,0 +

[GitHub] [kafka] satishd commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

2021-04-22 Thread GitBox
satishd commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r618221025 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/AbstractApiMessageAndVersionSerde.java ## @@ -0,0 +

[GitHub] [kafka] cadonna commented on pull request #10548: KAFKA-12396 added a nullcheck before trying to retrieve a key

2021-04-22 Thread GitBox
cadonna commented on pull request #10548: URL: https://github.com/apache/kafka/pull/10548#issuecomment-824665014 > > * prefixScan() (prefix should not be `null` either I guess? \cc @guozhangwang @cadonna > Yes! Actually, the implementations in `RocksDBStore` and `InMemory

[GitHub] [kafka] showuon commented on pull request #10547: KAFKA-12284: increase request timeout to make tests reliable

2021-04-22 Thread GitBox
showuon commented on pull request #10547: URL: https://github.com/apache/kafka/pull/10547#issuecomment-824644809 Done. Let's wait and see :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [kafka] chia7712 commented on pull request #10547: KAFKA-12284: increase request timeout to make tests reliable

2021-04-22 Thread GitBox
chia7712 commented on pull request #10547: URL: https://github.com/apache/kafka/pull/10547#issuecomment-824640807 @showuon Could you merge trunk to trigger QA again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Resolved] (KAFKA-12371) MirrorMaker 2.0 documentation is incorrect

2021-04-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-12371. Resolution: Duplicate > MirrorMaker 2.0 documentation is incorrect > -

[jira] [Resolved] (KAFKA-12529) kafka-configs.sh does not work while changing the sasl jaas configurations.

2021-04-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-12529. Resolution: Duplicate see KAFKA-12530 > kafka-configs.sh does not work while changing the

[jira] [Resolved] (KAFKA-12528) kafka-configs.sh does not work while changing the sasl jaas configurations.

2021-04-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-12528. Resolution: Duplicate see KAFKA-12530 > kafka-configs.sh does not work while changing the

[jira] [Created] (KAFKA-12708) Rewrite org.apache.kafka.test.Microbenchmarks by JMH

2021-04-22 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-12708: -- Summary: Rewrite org.apache.kafka.test.Microbenchmarks by JMH Key: KAFKA-12708 URL: https://issues.apache.org/jira/browse/KAFKA-12708 Project: Kafka Issu

[GitHub] [kafka] showuon commented on pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-22 Thread GitBox
showuon commented on pull request #9627: URL: https://github.com/apache/kafka/pull/9627#issuecomment-824620099 @chia7712 , thanks for the good suggestion! You make the change simpler!! :) Please help check again. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] showuon commented on a change in pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-22 Thread GitBox
showuon commented on a change in pull request #9627: URL: https://github.com/apache/kafka/pull/9627#discussion_r618159827 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -1001,9 +1001,14 @@ protected void close(Tim

[GitHub] [kafka] showuon commented on a change in pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2021-04-22 Thread GitBox
showuon commented on a change in pull request #9627: URL: https://github.com/apache/kafka/pull/9627#discussion_r618158921 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerGroupMember.java ## @@ -203,8 +203,8 @@ public void requestR

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-22 Thread GitBox
cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r618138592 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -957,22 +890,27 @@ ApiError electLeader(String topi

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-22 Thread GitBox
cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r618138346 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1057,83 @@ void validateManualPartitionAss

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-22 Thread GitBox
cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r618135556 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1057,83 @@ void validateManualPartitionAss

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-22 Thread GitBox
cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r618133367 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -172,47 +174,54 @@ String diff(PartitionControlInfo

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-22 Thread GitBox
cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r618133367 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -172,47 +174,54 @@ String diff(PartitionControlInfo

[GitHub] [kafka] cmccabe commented on a change in pull request #10564: MINOR: clean up some replication code

2021-04-22 Thread GitBox
cmccabe commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r618132526 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -356,7 +369,8 @@ public void replay(PartitionChange

  1   2   >