[GitHub] [kafka] UnityLung commented on pull request #10303: MINOR: Remove redundant inheritance from FilteringJmxReporter #onMetricRemoved

UnityLung commented on pull request #10303: URL: https://github.com/apache/kafka/pull/10303#issuecomment-797257733 @chia7712 Could you review it? This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [kafka] dongjoon-hyun commented on pull request #10285: KAFKA-12442: Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1

dongjoon-hyun commented on pull request #10285: URL: https://github.com/apache/kafka/pull/10285#issuecomment-797250027 Thank you for review and merging, @chia7712 and all! This is an automated message from the Apache Git Serv

[jira] [Assigned] (KAFKA-12442) Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1

[ https://issues.apache.org/jira/browse/KAFKA-12442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-12442: -- Assignee: Dongjoon Hyun > Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1 >

[jira] [Resolved] (KAFKA-12442) Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1

[ https://issues.apache.org/jira/browse/KAFKA-12442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-12442. Fix Version/s: 3.0.0 Resolution: Fixed > Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1 >

[GitHub] [kafka] chia7712 merged pull request #10285: KAFKA-12442: Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1

chia7712 merged pull request #10285: URL: https://github.com/apache/kafka/pull/10285 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] satishd commented on pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

satishd commented on pull request #10218: URL: https://github.com/apache/kafka/pull/10218#issuecomment-797234253 thanks @junrao @kowshik for the review comments, addressed with the latest commits/comments. This is an aut

[jira] [Commented] (KAFKA-12459) Improve raft simulation tests

[ https://issues.apache.org/jira/browse/KAFKA-12459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300036#comment-17300036 ] Lucas Bradstreet commented on KAFKA-12459: -- It might be worth considering looki

[GitHub] [kafka] ijuma commented on pull request #10306: MINOR: socket setup max should be 30 seconds

ijuma commented on pull request #10306: URL: https://github.com/apache/kafka/pull/10306#issuecomment-797220532 This needs a JIRA and a release note, no? This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] hachikuji commented on a change in pull request #10135: KAFKA-10348: Share client channel between forwarding and auto creation manager

hachikuji commented on a change in pull request #10135: URL: https://github.com/apache/kafka/pull/10135#discussion_r592887105 ## File path: core/src/main/scala/kafka/server/ForwardingManager.scala ## @@ -72,11 +54,9 @@ class ForwardingManagerImpl( ) extends ForwardingManager w

[GitHub] [kafka] chia7712 commented on a change in pull request #10292: MINOR: fix client_compatibility_features_test.py

chia7712 commented on a change in pull request #10292: URL: https://github.com/apache/kafka/pull/10292#discussion_r592886905 ## File path: tests/kafkatest/tests/client/client_compatibility_features_test.py ## @@ -130,4 +134,7 @@ def run_compatibility_test(self, broker_version,

[GitHub] [kafka] chia7712 commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

chia7712 commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r592885424 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -80,15 +156,34 @@ public Errors error() { return Er

[GitHub] [kafka] hachikuji commented on a change in pull request #10281: KAFKA-12432: AdminClient should time out nodes that are never ready

hachikuji commented on a change in pull request #10281: URL: https://github.com/apache/kafka/pull/10281#discussion_r592865485 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -1136,17 +1185,12 @@ private void timeoutCallsInFlight(T

[jira] [Commented] (KAFKA-12457) Implications of KIP-516 for quorum controller

[ https://issues.apache.org/jira/browse/KAFKA-12457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299982#comment-17299982 ] Jason Gustafson commented on KAFKA-12457: - [~guozhang] My understanding is that

[jira] [Created] (KAFKA-12459) Improve raft simulation tests

Jason Gustafson created KAFKA-12459: --- Summary: Improve raft simulation tests Key: KAFKA-12459 URL: https://issues.apache.org/jira/browse/KAFKA-12459 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] hachikuji commented on a change in pull request #10289: KAFKA-12440: ClusterId validation for Vote, BeginQuorum, EndQuorum and FetchSnapshot

hachikuji commented on a change in pull request #10289: URL: https://github.com/apache/kafka/pull/10289#discussion_r592853088 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -939,12 +951,27 @@ private FetchResponseData buildEmptyFetchResponse(

[jira] [Commented] (KAFKA-12373) Improve KafkaRaftClient handling of graceful shutdown

[ https://issues.apache.org/jira/browse/KAFKA-12373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299975#comment-17299975 ] Jason Gustafson commented on KAFKA-12373: - [~sagarrao] Please feel free to pick

[jira] [Commented] (KAFKA-12446) Define KGroupedTable#aggregate subtractor + adder order of execution

[ https://issues.apache.org/jira/browse/KAFKA-12446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299967#comment-17299967 ] Guozhang Wang commented on KAFKA-12446: --- +1 as well to make it explicit on public

[GitHub] [kafka] hachikuji commented on a change in pull request #10227: KAFKA-12382: add a README for KIP-500

hachikuji commented on a change in pull request #10227: URL: https://github.com/apache/kafka/pull/10227#discussion_r592845663 ## File path: config/nozk-broker.properties ## @@ -68,7 +71,7 @@ socket.request.max.bytes=104857600 # Log Basics ##

[jira] [Commented] (KAFKA-12457) Implications of KIP-516 for quorum controller

[ https://issues.apache.org/jira/browse/KAFKA-12457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299964#comment-17299964 ] Guozhang Wang commented on KAFKA-12457: --- [~jolshan] [~hachikuji] Just curious, are

[jira] [Commented] (KAFKA-6599) KTable KTable join semantics violated when caching enabled

[ https://issues.apache.org/jira/browse/KAFKA-6599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299960#comment-17299960 ] Guozhang Wang commented on KAFKA-6599: -- Thanks [~aosipov] for your analysis! Though

[GitHub] [kafka] mjsax commented on a change in pull request #10300: KAFKA-12452: Remove deprecated overloads of ProcessorContext#forward

mjsax commented on a change in pull request #10300: URL: https://github.com/apache/kafka/pull/10300#discussion_r592837536 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContextTest.java ## @@ -155,29 +155,20 @@ public void sho

[GitHub] [kafka] mjsax commented on pull request #10300: KAFKA-12452: Remove deprecated overloads of ProcessorContext#forward

mjsax commented on pull request #10300: URL: https://github.com/apache/kafka/pull/10300#issuecomment-797159492 @ableegoldman Remove the failing test -- cf inline comment. This is an automated message from the Apache Git Servi

[GitHub] [kafka] mjsax commented on a change in pull request #10300: KAFKA-12452: Remove deprecated overloads of ProcessorContext#forward

mjsax commented on a change in pull request #10300: URL: https://github.com/apache/kafka/pull/10300#discussion_r592837536 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContextTest.java ## @@ -155,29 +155,20 @@ public void sho

[jira] [Created] (KAFKA-12458) Implementation of Tiered Storage Integration with Azure Storage (ADLS + Blob Storage)

Israel Ekpo created KAFKA-12458: --- Summary: Implementation of Tiered Storage Integration with Azure Storage (ADLS + Blob Storage) Key: KAFKA-12458 URL: https://issues.apache.org/jira/browse/KAFKA-12458 P

[GitHub] [kafka] hachikuji commented on a change in pull request #10227: KAFKA-12382: add a README for KIP-500

hachikuji commented on a change in pull request #10227: URL: https://github.com/apache/kafka/pull/10227#discussion_r592828497 ## File path: KIP-500.md ## @@ -0,0 +1,131 @@ +KIP-500 Early Access Release + + +# Introduction +It is now possible to run A

[GitHub] [kafka] hachikuji commented on a change in pull request #10227: KAFKA-12382: add a README for KIP-500

hachikuji commented on a change in pull request #10227: URL: https://github.com/apache/kafka/pull/10227#discussion_r592828096 ## File path: KIP-500.md ## @@ -0,0 +1,131 @@ +KIP-500 Early Access Release + + +# Introduction +It is now possible to run A

[GitHub] [kafka] ableegoldman commented on a change in pull request #10203: KAFKA-12415: Prepare for Gradle 7.0 and restrict transitive scope for non api dependencies

ableegoldman commented on a change in pull request #10203: URL: https://github.com/apache/kafka/pull/10203#discussion_r592825616 ## File path: README.md ## @@ -69,10 +69,6 @@ Generate coverage for a single module, i.e.: ### Building a binary release gzipped tar ball ### .

[GitHub] [kafka] ableegoldman commented on a change in pull request #10203: KAFKA-12415: Prepare for Gradle 7.0 and restrict transitive scope for non api dependencies

ableegoldman commented on a change in pull request #10203: URL: https://github.com/apache/kafka/pull/10203#discussion_r592825616 ## File path: README.md ## @@ -69,10 +69,6 @@ Generate coverage for a single module, i.e.: ### Building a binary release gzipped tar ball ### .

[GitHub] [kafka] jolshan commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

jolshan commented on a change in pull request #10282: URL: https://github.com/apache/kafka/pull/10282#discussion_r592824939 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -425,36 +425,35 @@ class Partition(val topicPartition: TopicPartition, } /**

[GitHub] [kafka] hachikuji commented on a change in pull request #10282: KAFKA-12426: Missing logic to create partition.metadata files in RaftReplicaManager

hachikuji commented on a change in pull request #10282: URL: https://github.com/apache/kafka/pull/10282#discussion_r592823206 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -425,36 +425,35 @@ class Partition(val topicPartition: TopicPartition, } /

[GitHub] [kafka] ijuma commented on a change in pull request #10203: KAFKA-12415: Prepare for Gradle 7.0 and restrict transitive scope for non api dependencies

ijuma commented on a change in pull request #10203: URL: https://github.com/apache/kafka/pull/10203#discussion_r592821618 ## File path: README.md ## @@ -69,10 +69,6 @@ Generate coverage for a single module, i.e.: ### Building a binary release gzipped tar ball ### ./gradle

[GitHub] [kafka] ableegoldman commented on a change in pull request #10203: KAFKA-12415: Prepare for Gradle 7.0 and restrict transitive scope for non api dependencies

ableegoldman commented on a change in pull request #10203: URL: https://github.com/apache/kafka/pull/10203#discussion_r592808364 ## File path: README.md ## @@ -69,10 +69,6 @@ Generate coverage for a single module, i.e.: ### Building a binary release gzipped tar ball ### .

[jira] [Commented] (KAFKA-12457) Implications of KIP-516 for quorum controller

[ https://issues.apache.org/jira/browse/KAFKA-12457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299937#comment-17299937 ] Justine Olshan commented on KAFKA-12457: FYI, there is already work in progress

[jira] [Comment Edited] (KAFKA-12457) Implications of KIP-516 for quorum controller

[ https://issues.apache.org/jira/browse/KAFKA-12457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299936#comment-17299936 ] Justine Olshan edited comment on KAFKA-12457 at 3/11/21, 11:43 PM: ---

[jira] [Commented] (KAFKA-12457) Implications of KIP-516 for quorum controller

[ https://issues.apache.org/jira/browse/KAFKA-12457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299936#comment-17299936 ] Justine Olshan commented on KAFKA-12457: Thanks for creating this JIRA. There is

[jira] [Commented] (KAFKA-12453) Guidance on whether a topology is eligible for optimisation

[ https://issues.apache.org/jira/browse/KAFKA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299935#comment-17299935 ] Matthias J. Sax commented on KAFKA-12453: - Personally, I think it might be bette

[jira] [Created] (KAFKA-12457) Implications of KIP-516 for quorum controller

Jason Gustafson created KAFKA-12457: --- Summary: Implications of KIP-516 for quorum controller Key: KAFKA-12457 URL: https://issues.apache.org/jira/browse/KAFKA-12457 Project: Kafka Issue Typ

[GitHub] [kafka] cmccabe commented on pull request #10306: MINOR: socket setup max should be 30 seconds

cmccabe commented on pull request #10306: URL: https://github.com/apache/kafka/pull/10306#issuecomment-797102787 Committed to trunk and 2.8 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] cmccabe merged pull request #10306: MINOR: socket setup max should be 30 seconds

cmccabe merged pull request #10306: URL: https://github.com/apache/kafka/pull/10306 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] cmccabe commented on a change in pull request #10227: KAFKA-12382: add a README for KIP-500

cmccabe commented on a change in pull request #10227: URL: https://github.com/apache/kafka/pull/10227#discussion_r592777630 ## File path: KIP-500.md ## @@ -0,0 +1,131 @@ +KIP-500 Early Access Release + + +# Introduction +It is now possible to run Apa

[GitHub] [kafka] cmccabe commented on a change in pull request #10227: KAFKA-12382: add a README for KIP-500

cmccabe commented on a change in pull request #10227: URL: https://github.com/apache/kafka/pull/10227#discussion_r592776987 ## File path: KIP-500.md ## @@ -0,0 +1,131 @@ +KIP-500 Early Access Release + + +# Introduction +It is now possible to run Apa

[GitHub] [kafka] cmccabe commented on a change in pull request #10227: KAFKA-12382: add a README for KIP-500

cmccabe commented on a change in pull request #10227: URL: https://github.com/apache/kafka/pull/10227#discussion_r592776569 ## File path: config/nozk-broker.properties ## @@ -68,7 +71,7 @@ socket.request.max.bytes=104857600 # Log Basics

[GitHub] [kafka] cmccabe commented on pull request #10306: MINOR: socket setup max should be 30 seconds

cmccabe commented on pull request #10306: URL: https://github.com/apache/kafka/pull/10306#issuecomment-797099771 I retried the tests that failed locally and they all worked for me. Will commit in a minute. This is an automa

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r592761061 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -80,15 +156,34 @@ public Errors error() { return Err

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r592761061 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -80,15 +156,34 @@ public Errors error() { return Err

[jira] [Assigned] (KAFKA-12265) Move the BatchAccumulator in KafkaRaftClient to LeaderState

[ https://issues.apache.org/jira/browse/KAFKA-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Deshpande reassigned KAFKA-12265: --- Assignee: Rohit Deshpande > Move the BatchAccumulator in KafkaRaftClient to LeaderS

[jira] [Commented] (KAFKA-12265) Move the BatchAccumulator in KafkaRaftClient to LeaderState

[ https://issues.apache.org/jira/browse/KAFKA-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299896#comment-17299896 ] Rohit Deshpande commented on KAFKA-12265: - thanks [~jagsancio] I can work on thi

[jira] [Commented] (KAFKA-12456) Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR

[ https://issues.apache.org/jira/browse/KAFKA-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299889#comment-17299889 ] Ismael Juma commented on KAFKA-12456: - I suggest INFO. > Log "Listeners are not ide

[jira] [Created] (KAFKA-12456) Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR

Michael Bingham created KAFKA-12456: --- Summary: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR Key: KAFKA-12456 URL: https://issues.apache.org/jira/browse/KAFKA-12456

[GitHub] [kafka] guozhangwang commented on pull request #10305: KAFKA-10357: Add missing repartition topic validation

guozhangwang commented on pull request #10305: URL: https://github.com/apache/kafka/pull/10305#issuecomment-797057347 cc @rodesai This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] askldjd commented on pull request #8921: KAFKA-10160: Kafka MM2 consumer configuration

askldjd commented on pull request #8921: URL: https://github.com/apache/kafka/pull/8921#issuecomment-797052226 https://github.com/apache/kafka/pull/8921#issuecomment-755307931 I am running into this issue right now. It looks like this PR never got merged to trunk. @satishbellapu, are

[jira] [Created] (KAFKA-12455) OffsetValidationTest.test_broker_rolling_bounce failing for Raft quorums

Ron Dagostino created KAFKA-12455: - Summary: OffsetValidationTest.test_broker_rolling_bounce failing for Raft quorums Key: KAFKA-12455 URL: https://issues.apache.org/jira/browse/KAFKA-12455 Project: K

[GitHub] [kafka] ableegoldman commented on pull request #10300: KAFKA-12452: Remove deprecated overloads of ProcessorContext#forward

ableegoldman commented on pull request #10300: URL: https://github.com/apache/kafka/pull/10300#issuecomment-797026073 Looks like a relevant test failure: `AbstractProcessorContextTest failed` This is an automated message from

[GitHub] [kafka] cadonna commented on pull request #10305: KAFKA-10357: Add missing repartition topic validation

cadonna commented on pull request #10305: URL: https://github.com/apache/kafka/pull/10305#issuecomment-797018113 Call for review: @guozhangwang This is an automated message from the Apache Git Service. To respond to the mess

[jira] [Updated] (KAFKA-12405) Inconsistent broker without active topics still involved in coordinating consumer group

[ https://issues.apache.org/jira/browse/KAFKA-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander updated KAFKA-12405: -- Description: Short description: Broker without active topics and with inconsistent data still involve

[GitHub] [kafka] rondagostino commented on pull request #10292: MINOR: fix client_compatibility_features_test.py

rondagostino commented on pull request #10292: URL: https://github.com/apache/kafka/pull/10292#issuecomment-796970993 This needs to be cherry-picked to 2.8. This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] rondagostino commented on a change in pull request #10292: MINOR: fix client_compatibility_features_test.py

rondagostino commented on a change in pull request #10292: URL: https://github.com/apache/kafka/pull/10292#discussion_r592639264 ## File path: tests/kafkatest/tests/client/client_compatibility_features_test.py ## @@ -130,4 +134,7 @@ def run_compatibility_test(self, broker_versi

[GitHub] [kafka] rondagostino commented on pull request #10298: MINOR: Disable client compatibility system test for Raft quorums

rondagostino commented on pull request #10298: URL: https://github.com/apache/kafka/pull/10298#issuecomment-796968115 Closing in favor of https://github.com/apache/kafka/pull/10292 -- thanks @chia7712! This is an automated m

[GitHub] [kafka] rondagostino closed pull request #10298: MINOR: Disable client compatibility system test for Raft quorums

rondagostino closed pull request #10298: URL: https://github.com/apache/kafka/pull/10298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] jolshan commented on pull request #10286: KAFKA-12318: system tests need to fetch Topic IDs via Admin Client instead of via ZooKeeper

jolshan commented on pull request #10286: URL: https://github.com/apache/kafka/pull/10286#issuecomment-796963473 System tests `upgrade_test.py` and `downgrade_test.py` passed with latest code. This is an automated message f

[jira] [Commented] (KAFKA-12449) Remove deprecated WindowStore#put

[ https://issues.apache.org/jira/browse/KAFKA-12449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299808#comment-17299808 ] Jorge Esteban Quilcate Otoya commented on KAFKA-12449: -- This issue

[GitHub] [kafka] jeqo commented on pull request #10293: [KAFKA-12449] Remove deprecated WindowStore#put

jeqo commented on pull request #10293: URL: https://github.com/apache/kafka/pull/10293#issuecomment-796958801 Totally missed that this was proposed and accepted in KIP-474. Hope is not stepping into an existing implementation. -

[GitHub] [kafka] jeqo commented on a change in pull request #10293: [KAFKA-12449] Remove deprecated WindowStore#put

jeqo commented on a change in pull request #10293: URL: https://github.com/apache/kafka/pull/10293#discussion_r592620749 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractWindowBytesStoreTest.java ## @@ -710,73 +710,9 @@ public void testPutAn

[GitHub] [kafka] jeqo commented on a change in pull request #10293: [KAFKA-12449] Remove deprecated WindowStore#put

jeqo commented on a change in pull request #10293: URL: https://github.com/apache/kafka/pull/10293#discussion_r592620290 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractWindowBytesStoreTest.java ## @@ -710,73 +710,9 @@ public void testPutAn

[GitHub] [kafka] hachikuji commented on pull request #10306: MINOR: socket setup max should be 30 seconds

hachikuji commented on pull request #10306: URL: https://github.com/apache/kafka/pull/10306#issuecomment-796953732 cc @vvcephei This might be a good one for 2.8 since it is a simple fix. This is an automated message from the

[GitHub] [kafka] cmccabe commented on a change in pull request #10306: MINOR: socket setup max should be 30 seconds

cmccabe commented on a change in pull request #10306: URL: https://github.com/apache/kafka/pull/10306#discussion_r592610989 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/AdminClientConfig.java ## @@ -162,7 +162,7 @@

[jira] [Commented] (KAFKA-12428) Add a last-heartbeat-seconds-ago metric to Kafka Consumer

[ https://issues.apache.org/jira/browse/KAFKA-12428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299798#comment-17299798 ] Guozhang Wang commented on KAFKA-12428: --- Hello [~ketulgupta], thanks for your inte

[GitHub] [kafka] hachikuji commented on a change in pull request #10306: MINOR: socket setup should be 30s for AdminCLient

hachikuji commented on a change in pull request #10306: URL: https://github.com/apache/kafka/pull/10306#discussion_r592601984 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/AdminClientConfig.java ## @@ -162,7 +162,7 @@

[GitHub] [kafka] cmccabe opened a new pull request #10306: MINOR: socket setup should be 30s for AdminCLient

cmccabe opened a new pull request #10306: URL: https://github.com/apache/kafka/pull/10306 socket.connection.setup.timeout.max.ms should be 30 seconds for AdminClient. The current value of 127 seconds is longer than the default API timeout. With that timeout, AdminClient API calls wil

[jira] [Commented] (KAFKA-12265) Move the BatchAccumulator in KafkaRaftClient to LeaderState

[ https://issues.apache.org/jira/browse/KAFKA-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299790#comment-17299790 ] Guozhang Wang commented on KAFKA-12265: --- Thanks [~jagsancio] for the updated descr

[GitHub] [kafka] hachikuji merged pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

hachikuji merged pull request #10021: URL: https://github.com/apache/kafka/pull/10021 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] cmccabe commented on pull request #10281: KAFKA-12432: AdminClient should time out nodes that are never ready

cmccabe commented on pull request #10281: URL: https://github.com/apache/kafka/pull/10281#issuecomment-796936178 > I don't think this is accurate. The NetworkClient enforces the request timeout, which is passed through the ClientRequest object. If the response is not received before the ti

[GitHub] [kafka] cadonna opened a new pull request #10305: KAFKA-10357: Add missing repartition topic validation

cadonna opened a new pull request #10305: URL: https://github.com/apache/kafka/pull/10305 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[GitHub] [kafka] guozhangwang merged pull request #10266: KAFKA-10357: Add validation method for internal topics

guozhangwang merged pull request #10266: URL: https://github.com/apache/kafka/pull/10266 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r592577341 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,152 @@ +/* + * Licensed t

[jira] [Commented] (KAFKA-12372) Enhance TimestampCoverter to handle multiple timestamp or date fields

[ https://issues.apache.org/jira/browse/KAFKA-12372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299768#comment-17299768 ] Hoa Le commented on KAFKA-12372: Hi Team, Can someone in the team get reviews the PR fo

[jira] [Updated] (KAFKA-12372) Enhance TimestampCoverter to handle multiple timestamp or date fields

[ https://issues.apache.org/jira/browse/KAFKA-12372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hoa Le updated KAFKA-12372: --- Fix Version/s: (was: 3.0.0) 2.7.1 > Enhance TimestampCoverter to handle multiple time

[GitHub] [kafka] wenbingshen commented on pull request #10304: KAFKA-12454:Add ERROR logging on kafka-log-dirs when given brokerIds do not exist in current kafka cluster

wenbingshen commented on pull request #10304: URL: https://github.com/apache/kafka/pull/10304#issuecomment-796915807 @chia7712 Can you help review this PR? Thank you. This is an automated message from the Apache Git Service.

[jira] [Commented] (KAFKA-12265) Move the BatchAccumulator in KafkaRaftClient to LeaderState

[ https://issues.apache.org/jira/browse/KAFKA-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299761#comment-17299761 ] Jose Armando Garcia Sancio commented on KAFKA-12265: [~rohitdeshaws]

[GitHub] [kafka] wenbingshen opened a new pull request #10304: KAFKA-12454:Add ERROR logging on kafka-log-dirs when given brokerIds do not exist in current kafka cluster

wenbingshen opened a new pull request #10304: URL: https://github.com/apache/kafka/pull/10304 When non-existent brokerIds value are given, the kafka-log-dirs tool will have a timeout error: Exception in thread "main" java.util.concurrent.ExecutionException: org.apache.kafka.common.e

[jira] [Updated] (KAFKA-12265) Move the BatchAccumulator in KafkaRaftClient to LeaderState

[ https://issues.apache.org/jira/browse/KAFKA-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-12265: --- Description: The {{KafkaRaftClient}} has a field for the {{BatchAccu

[jira] [Commented] (KAFKA-12265) Move the BatchAccumulator in KafkaRaftClient to LeaderState

[ https://issues.apache.org/jira/browse/KAFKA-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17299757#comment-17299757 ] Jose Armando Garcia Sancio commented on KAFKA-12265: {quote}Just cur

[GitHub] [kafka] levzem commented on pull request #10299: KAFKA-10070: parameterize Connect unit tests to remove code duplication

levzem commented on pull request #10299: URL: https://github.com/apache/kafka/pull/10299#issuecomment-796909792 @C0urante @kkonstantine @rhauch would appreciate some 👀 , thanks! This is an automated message from the Apache Gi

[GitHub] [kafka] jolshan commented on pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on pull request #9944: URL: https://github.com/apache/kafka/pull/9944#issuecomment-796906853 @chia7712 yes. The consumer already gets periodic metadata updates, so I use that to get the mapping. This is an

[GitHub] [kafka] chia7712 commented on pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

chia7712 commented on pull request #9944: URL: https://github.com/apache/kafka/pull/9944#issuecomment-796902838 > The idea is that the sender will always have the topic ID -> name conversion for topic IDs it sends. Do you mean the client (consumer) must have a mapping (name -> ID) in

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r592546512 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -80,15 +156,34 @@ public Errors error() { return Err

[GitHub] [kafka] chia7712 commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

chia7712 commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r592542384 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -80,15 +156,34 @@ public Errors error() { return Er

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r592536126 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -80,15 +156,34 @@ public Errors error() { return Err

[GitHub] [kafka] jolshan edited a comment on pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan edited a comment on pull request #9944: URL: https://github.com/apache/kafka/pull/9944#issuecomment-796886007 @chia7712 There was a lot of back and forth about whether we should simply include the topic ID and the name in the protocol (to uniquely identify the topic--which is somet

[GitHub] [kafka] jolshan commented on pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on pull request #9944: URL: https://github.com/apache/kafka/pull/9944#issuecomment-796886007 @chia7712 There was a lot of back and forth about whether we should simply include the topic ID in the protocol (to uniquely identify the topic--which is something we may want to

[GitHub] [kafka] chia7712 commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

chia7712 commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r592530926 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -80,15 +156,34 @@ public Errors error() { return Er

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r592524660 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -80,15 +156,34 @@ public Errors error() { return Err

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r592520900 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -216,6 +217,14 @@ public synchronized boolean updateRequested() {

[jira] [Assigned] (KAFKA-12454) Add ERROR logging on kafka-log-dirs when given brokerIds do not exist in current kafka cluster

[ https://issues.apache.org/jira/browse/KAFKA-12454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenbing Shen reassigned KAFKA-12454: Assignee: Wenbing Shen > Add ERROR logging on kafka-log-dirs when given brokerIds do not

[jira] [Created] (KAFKA-12454) Add ERROR logging on kafka-log-dirs when given brokerIds do not exist in current kafka cluster

Wenbing Shen created KAFKA-12454: Summary: Add ERROR logging on kafka-log-dirs when given brokerIds do not exist in current kafka cluster Key: KAFKA-12454 URL: https://issues.apache.org/jira/browse/KAFKA-12454

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r592437366 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteLogMetadataManager.java ## @@ -0,0 +1,173 @@ +/* + *

[GitHub] [kafka] chia7712 commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

chia7712 commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r592335738 ## File path: clients/src/main/java/org/apache/kafka/clients/Metadata.java ## @@ -216,6 +217,14 @@ public synchronized boolean updateRequested() {

[GitHub] [kafka] cadonna commented on pull request #10266: KAFKA-10357: Add validation method for internal topics

cadonna commented on pull request #10266: URL: https://github.com/apache/kafka/pull/10266#issuecomment-796690925 Call for committer review: @mjsax @ableegoldman @guozhangwang This is an automated message from the Apache Git S

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r592248245 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteLogMetadataManager.java ## @@ -0,0 +1,173 @@ +/* + *

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r592173915 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteLogMetadataManager.java ## @@ -0,0 +1,173 @@ +/* + *

  1   2   >