dengziming commented on a change in pull request #9684:
URL: https://github.com/apache/kafka/pull/9684#discussion_r546309985
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1896,6 +1896,11 @@ class KafkaApis(val requestChannel: RequestChannel,
dengziming commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r546309738
##
File path: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java
##
@@ -343,7 +344,8 @@
INVALID_UPDATE_VERSION(95, "The given update
dengziming closed pull request #9770:
URL: https://github.com/apache/kafka/pull/9770
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jolshan edited a comment on pull request #9768:
URL: https://github.com/apache/kafka/pull/9768#issuecomment-748542929
I just noticed this issue too. Thanks for looking into a fix. Looks like
@dengziming and I had different ideas about how to assign topic IDs in this
test and we didn't catc
jolshan edited a comment on pull request #9768:
URL: https://github.com/apache/kafka/pull/9768#issuecomment-748542929
I just noticed this issue too. Thanks for looking into a fix. Looks like
@dengziming and I had different ideas about how to assign topic IDs in this
test. LGTM
--
jolshan edited a comment on pull request #9768:
URL: https://github.com/apache/kafka/pull/9768#issuecomment-748542929
I just noticed this issue too. Thanks for looking into a fix. Looks like
@dengziming and I had different ideas about how to assign topic IDs in this
test.
---
jolshan edited a comment on pull request #9768:
URL: https://github.com/apache/kafka/pull/9768#issuecomment-748542929
I just noticed this issue too. Thanks for looking into a fix. Looks like
@dengziming and I had different ideas about how to assign topic IDs in this
test. LGTM
--
jolshan edited a comment on pull request #9768:
URL: https://github.com/apache/kafka/pull/9768#issuecomment-748542929
I just noticed this issue too. Thanks for looking into a fix. Did we figure
out the root cause?
This is an
jolshan edited a comment on pull request #9768:
URL: https://github.com/apache/kafka/pull/9768#issuecomment-748542929
I just noticed this issue too. Thanks for looking into a fix. LGTM
This is an automated message from the Ap
jolshan commented on pull request #9768:
URL: https://github.com/apache/kafka/pull/9768#issuecomment-748542929
I just noticed this issue too. Thanks for looking into a fix.
This is an automated message from the Apache Git Ser
jolshan commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r546292513
##
File path: clients/src/main/java/org/apache/kafka/common/protocol/Errors.java
##
@@ -343,7 +344,8 @@
INVALID_UPDATE_VERSION(95, "The given update ve
[
https://issues.apache.org/jira/browse/KAFKA-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan reassigned KAFKA-10580:
--
Assignee: Justine Olshan
> Add topic ID support to Fetch request
> --
tguruprasad closed pull request #9767:
URL: https://github.com/apache/kafka/pull/9767
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
tguruprasad commented on pull request #9767:
URL: https://github.com/apache/kafka/pull/9767#issuecomment-748502435
@chia7712 thanks for pointing out the existing PR. Since I had created and
assigned JIRA to myself I didn't realized someone has made fix for it. Let me
close this PR and keep
[
https://issues.apache.org/jira/browse/KAFKA-10869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Bradstreet updated KAFKA-10869:
-
Description: We want to do this so we don't lose topic IDs upon downgrades.
If we downgr
vamossagar12 commented on a change in pull request #9717:
URL: https://github.com/apache/kafka/pull/9717#discussion_r546260595
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBRangeIteratorTest.java
##
@@ -0,0 +1,295 @@
+/*
+ * Licensed to th
[
https://issues.apache.org/jira/browse/KAFKA-10869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Bradstreet updated KAFKA-10869:
-
Affects Version/s: 2.8.0
> Gate topic IDs behind IBP 2.8
> -
qq619618919 commented on pull request #8656:
URL: https://github.com/apache/kafka/pull/8656#issuecomment-748469787
@ryannedolan I've added TODO, But my submit shows All Checks have failed.Why
is that?
This is an automated me
dengziming opened a new pull request #9770:
URL: https://github.com/apache/kafka/pull/9770
*More detailed description of your change*
Add ByteBufferAccessorTest similar to SendBuilderTest
1. test basic read and write
2. test none zero-copy when writing ByteBuffer and Records
3.
dengziming opened a new pull request #9769:
URL: https://github.com/apache/kafka/pull/9769
*More detailed description of your change*
1. Add topicNames in `MetadataCache` and add alter
`KafkaApis.handleTopicMetadataRequest` according to the KIP
2. Add method `describeTopicsWithIds` in
20 matches
Mail list logo
