[GitHub] [kafka] feyman2016 commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

feyman2016 commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-632991430 @abbccdda Just fixed, thanks! This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [kafka] brary commented on a change in pull request #8706: KAFKA-10030 allow fetching a key from a single partition

brary commented on a change in pull request #8706: URL: https://github.com/apache/kafka/pull/8706#discussion_r429515106 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StoreQueryIntegrationTest.java ## @@ -296,6 +297,87 @@ public void shouldQuerySpecif

[GitHub] [kafka] feyman2016 commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

feyman2016 commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-632987873 @abbccdda ahh, sorry, checking, will fix soon This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] birdgodtech opened a new pull request #8721: 2.3 fork update

birdgodtech opened a new pull request #8721: URL: https://github.com/apache/kafka/pull/8721 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testi

[GitHub] [kafka] birdgodtech closed pull request #8721: 2.3 fork update

birdgodtech closed pull request #8721: URL: https://github.com/apache/kafka/pull/8721 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] abbccdda commented on a change in pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

abbccdda commented on a change in pull request #8680: URL: https://github.com/apache/kafka/pull/8680#discussion_r429476928 ## File path: core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala ## @@ -47,7 +56,30 @@ class FinalizedFeatureChangeListener(zkClient: K

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429510931 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -129,7 +129,10 @@ class KafkaServer(val config: KafkaConfig, time: Time = Time.SY

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429510931 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -129,7 +129,10 @@ class KafkaServer(val config: KafkaConfig, time: Time = Time.SY

[GitHub] [kafka] feyman2016 commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

feyman2016 commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-632974316 @abbccdda Updated, thanks! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r429507189 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java ## @@ -261,6 +261,43 @@ public void shouldNo

[jira] [Updated] (KAFKA-10035) Improve the AbstractResetIntegrationTest

[ https://issues.apache.org/jira/browse/KAFKA-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] feyman updated KAFKA-10035: --- Description: In the test: AbstractResetIntegrationTest, there are several places like below:   {code:java}

[jira] [Updated] (KAFKA-10035) Improve the AbstractResetIntegrationTest

[ https://issues.apache.org/jira/browse/KAFKA-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] feyman updated KAFKA-10035: --- Labels: (was: newbie) > Improve the AbstractResetIntegrationTest > ---

[jira] [Updated] (KAFKA-10035) Improve the AbstractResetIntegrationTest

[ https://issues.apache.org/jira/browse/KAFKA-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] feyman updated KAFKA-10035: --- Labels: newbie (was: ) > Improve the AbstractResetIntegrationTest > ---

[jira] [Created] (KAFKA-10035) Improve the AbstractResetIntegrationTest

feyman created KAFKA-10035: -- Summary: Improve the AbstractResetIntegrationTest Key: KAFKA-10035 URL: https://issues.apache.org/jira/browse/KAFKA-10035 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] ableegoldman commented on pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

ableegoldman commented on pull request #8697: URL: https://github.com/apache/kafka/pull/8697#issuecomment-632971229 spotBugs is currently failing with a mysterious and uninformative exception so there's no use kicking off the tests again until I figure out what's going on. Might be a spotB

[GitHub] [kafka] ableegoldman commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

ableegoldman commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429505517 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -899,6 +920,28 @@ public boolean maybePunctuate

[GitHub] [kafka] ableegoldman commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

ableegoldman commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429505441 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -899,6 +920,28 @@ public boolean maybePunctuate

[GitHub] [kafka] ableegoldman commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

ableegoldman commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429505029 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -149,6 +154,10 @@ public int ha

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r429504725 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -379,6 +379,22 @@ private static MetadataResponse pr

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r429504532 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -2411,6 +2429,57 @@ public void testRemoveMembersFrom

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r429504705 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -119,7 +122,9 @@ + "* This tool will not clean up the local state o

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r429504600 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -27,10 +27,12 @@ import org.apache.kafka.clients.admin.DescribeConsumerGroupsOp

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r429504532 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -2411,6 +2429,57 @@ public void testRemoveMembersFrom

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r429504184 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupResult.java ## @@ -51,9 +52,21 @@ if (thro

[GitHub] [kafka] xvrl commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xvrl commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429503342 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -129,7 +129,10 @@ class KafkaServer(val config: KafkaConfig, time: Time = Time.SYSTEM,

[GitHub] [kafka] mjsax commented on a change in pull request #8646: KAFKA-9974: Fix flaky test by removing unneeded asserts

mjsax commented on a change in pull request #8646: URL: https://github.com/apache/kafka/pull/8646#discussion_r429501759 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java ## @@ -133,11 +133,6 @@ public void shouldApplyU

[GitHub] [kafka] mjsax commented on pull request #8706: KAFKA-10030 allow fetching a key from a single partition

mjsax commented on pull request #8706: URL: https://github.com/apache/kafka/pull/8706#issuecomment-632961815 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8706: KAFKA-10030 allow fetching a key from a single partition

mjsax commented on pull request #8706: URL: https://github.com/apache/kafka/pull/8706#issuecomment-632961839 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

mjsax commented on pull request #6824: URL: https://github.com/apache/kafka/pull/6824#issuecomment-632960993 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

mjsax commented on pull request #8697: URL: https://github.com/apache/kafka/pull/8697#issuecomment-632961017 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

mjsax commented on pull request #6824: URL: https://github.com/apache/kafka/pull/6824#issuecomment-632961042 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

mjsax commented on pull request #8697: URL: https://github.com/apache/kafka/pull/8697#issuecomment-632960947 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

mjsax commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429499547 ## File path: clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java ## @@ -492,6 +493,52 @@ public void testPercentiles() { assertE

[jira] [Assigned] (KAFKA-10034) Clarify Usage of "batch.size" and "max.request.size" Producer Configs

[ https://issues.apache.org/jira/browse/KAFKA-10034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Badai Aqrandista reassigned KAFKA-10034: Assignee: Badai Aqrandista > Clarify Usage of "batch.size" and "max.request.size"

[GitHub] [kafka] mjsax commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

mjsax commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429500010 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -149,6 +154,10 @@ public int hashCode(

[GitHub] [kafka] mjsax commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

mjsax commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429499887 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -899,6 +920,28 @@ public boolean maybePunctuateSystemT

[GitHub] [kafka] mjsax commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

mjsax commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429499839 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -899,6 +920,28 @@ public boolean maybePunctuateSystemT

[GitHub] [kafka] aakashnshah opened a new pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

aakashnshah opened a new pull request #8720: URL: https://github.com/apache/kafka/pull/8720 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] mjsax commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

mjsax commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429499547 ## File path: clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java ## @@ -492,6 +493,52 @@ public void testPercentiles() { assertE

[GitHub] [kafka] mjsax commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

mjsax commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429499547 ## File path: clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java ## @@ -492,6 +493,52 @@ public void testPercentiles() { assertE

[GitHub] [kafka] abbccdda commented on pull request #8221: KAFKA-9561: update task input partitions after rebalance

abbccdda commented on pull request #8221: URL: https://github.com/apache/kafka/pull/8221#issuecomment-632954730 @avalsa Hey just FYI, the release date for 2.6 is May 27th, if you couldn't make it to get changes done before May 25th (next Monday), I will go ahead to fix this patch and merge

[GitHub] [kafka] ableegoldman commented on a change in pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

ableegoldman commented on a change in pull request #8716: URL: https://github.com/apache/kafka/pull/8716#discussion_r429496605 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -1148,6 +1148,9 @@ private void verifyMaxInFlightRequestPerConnec

[GitHub] [kafka] mjsax commented on pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

mjsax commented on pull request #6824: URL: https://github.com/apache/kafka/pull/6824#issuecomment-632954613 > I asked this on the dev mailing list a while ago but didn't get a great answer - is there some sort of tooling I can use to edit the HTML docs like processor-api.html? I really do

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429495993 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -129,7 +129,10 @@ class KafkaServer(val config: KafkaConfig, time: Time = Time.SY

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429495993 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -129,7 +129,10 @@ class KafkaServer(val config: KafkaConfig, time: Time = Time.SY

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429496027 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/MetricsReporter.java ## @@ -65,4 +66,13 @@ default void validateReconfiguration(Map

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429495940 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java ## @@ -71,8 +72,13 @@ public JmxReporter() { /** * Cre

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429495910 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java ## @@ -318,4 +324,15 @@ public AttributeList setAttributes(Attribut

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429495778 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetricsContext.java ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (KAFKA-10034) Clarify Usage of "batch.size" and "max.request.size" Producer Configs

Mark Cox created KAFKA-10034: Summary: Clarify Usage of "batch.size" and "max.request.size" Producer Configs Key: KAFKA-10034 URL: https://issues.apache.org/jira/browse/KAFKA-10034 Project: Kafka

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429495778 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetricsContext.java ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] ijuma commented on pull request #8714: MINOR: Improve broker registration and Log logging

ijuma commented on pull request #8714: URL: https://github.com/apache/kafka/pull/8714#issuecomment-632952047 Unrelated flaky failure: > org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true] --

[GitHub] [kafka] ableegoldman commented on a change in pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

ableegoldman commented on a change in pull request #8716: URL: https://github.com/apache/kafka/pull/8716#discussion_r429491985 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -1148,6 +1148,9 @@ private void verifyMaxInFlightRequestPerConnec

[GitHub] [kafka] ableegoldman commented on a change in pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

ableegoldman commented on a change in pull request #8716: URL: https://github.com/apache/kafka/pull/8716#discussion_r429490753 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java ## @@ -359,6 +359,10 @@ private

[GitHub] [kafka] ableegoldman commented on a change in pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

ableegoldman commented on a change in pull request #8716: URL: https://github.com/apache/kafka/pull/8716#discussion_r429490483 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -1148,6 +1148,9 @@ private void verifyMaxInFlightRequestPerConnec

[GitHub] [kafka] ableegoldman commented on a change in pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

ableegoldman commented on a change in pull request #8716: URL: https://github.com/apache/kafka/pull/8716#discussion_r429490483 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -1148,6 +1148,9 @@ private void verifyMaxInFlightRequestPerConnec

[GitHub] [kafka] ableegoldman commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

ableegoldman commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429457310 ## File path: checkstyle/suppressions.xml ## @@ -183,6 +183,8 @@ files="StreamsPartitionAssignor.java"/> +

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429476820 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/ConnectUtils.java ## @@ -16,19 +16,24 @@ */ package org.apache.kafka.connec

[GitHub] [kafka] kkonstantine commented on pull request #8511: KAFKA-9888: Copy connector configs before passing to REST extensions

kkonstantine commented on pull request #8511: URL: https://github.com/apache/kafka/pull/8511#issuecomment-632924635 retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] ableegoldman commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

ableegoldman commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429470290 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -149,6 +154,10 @@ public int ha

[GitHub] [kafka] ableegoldman commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

ableegoldman commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429469651 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -149,6 +154,10 @@ public int ha

[GitHub] [kafka] ijuma commented on pull request #8376: KAFKA-9724 Newer clients not always sending fetch request to older brokers

ijuma commented on pull request #8376: URL: https://github.com/apache/kafka/pull/8376#issuecomment-632922284 Do we think this is safe to backport or is it best to stick with 2.6.0? This is an automated message from the Apache

[GitHub] [kafka] ableegoldman commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

ableegoldman commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429457310 ## File path: checkstyle/suppressions.xml ## @@ -183,6 +183,8 @@ files="StreamsPartitionAssignor.java"/> +

[GitHub] [kafka] rhauch commented on pull request #8654: KAFKA-9931: Implement KIP-605 to expand support for Connect worker internal topic configurations

rhauch commented on pull request #8654: URL: https://github.com/apache/kafka/pull/8654#issuecomment-632920985 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ableegoldman commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

ableegoldman commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429461550 ## File path: clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java ## @@ -492,6 +493,52 @@ public void testPercentiles() {

[GitHub] [kafka] ableegoldman commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

ableegoldman commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429457310 ## File path: checkstyle/suppressions.xml ## @@ -183,6 +183,8 @@ files="StreamsPartitionAssignor.java"/> +

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r42951 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -129,7 +129,10 @@ class KafkaServer(val config: KafkaConfig, time: Time = Time.SY

[GitHub] [kafka] xvrl commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xvrl commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429442671 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/MetricsContext.java ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] xvrl commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xvrl commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429442787 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/MetricsContext.java ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] gnkoshelev commented on pull request #8715: KAFKA-10033: AdminClient should throw UnknownTopicOrPartitionException instead of UnknownServerException if altering configs of non-existin

gnkoshelev commented on pull request #8715: URL: https://github.com/apache/kafka/pull/8715#issuecomment-632900624 >Be sure to update `core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala` to the new exception. My bad - You're absolutely right. >it'll use the me

[GitHub] [kafka] vvcephei merged pull request #8713: KAFKA-6145: Add unit tests for assignments of only stateless tasks

vvcephei merged pull request #8713: URL: https://github.com/apache/kafka/pull/8713 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #8713: KAFKA-6145: Add unit tests for assignments of only stateless tasks

vvcephei commented on pull request #8713: URL: https://github.com/apache/kafka/pull/8713#issuecomment-632899282 Unrelated test failures: org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false] org.apache.kafka.streams.int

[GitHub] [kafka] xvrl commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xvrl commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429440655 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/MetricsContext.java ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] xvrl commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xvrl commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429439813 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java ## @@ -71,8 +72,13 @@ public JmxReporter() { /** * Create a

[GitHub] [kafka] mumrah commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

mumrah commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429387498 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java ## @@ -318,4 +324,15 @@ public AttributeList setAttributes(AttributeLis

[GitHub] [kafka] xvrl commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

xvrl commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r429432997 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetricsContext.java ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] xinzhuxiansheng edited a comment on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

xinzhuxiansheng edited a comment on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-632888658 > > > @xinzhuxiansheng could you run the whole unit test suite locally since jenkins seems a bit unstable at the moment? You can run ` ./gradlew cleanTest t

[GitHub] [kafka] xinzhuxiansheng commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

xinzhuxiansheng commented on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-632888658 > > > @xinzhuxiansheng could you run the whole unit test suite locally since jenkins seems a bit unstable at the moment? You can run ` ./gradlew cleanTest test`

[GitHub] [kafka] mmolimar commented on pull request #8663: KAFKA-9985: Sink connector may exhaust broker when writing in DLQ

mmolimar commented on pull request #8663: URL: https://github.com/apache/kafka/pull/8663#issuecomment-632886432 Just fixed @rhauch @C0urante Thanks! This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] C0urante commented on pull request #8663: KAFKA-9985: Sink connector may exhaust broker when writing in DLQ

C0urante commented on pull request #8663: URL: https://github.com/apache/kafka/pull/8663#issuecomment-632884640 Ahh, think we might want to use `@SuppressWarnings("unchecked")` for the `parseTopicsList` method. This was my suggested change; sorry @mmolimar! ---

[GitHub] [kafka] bdbyrne commented on pull request #8715: KAFKA-10033: AdminClient should throw UnknownTopicOrPartitionException instead of UnknownServerException if altering configs of non-existing t

bdbyrne commented on pull request #8715: URL: https://github.com/apache/kafka/pull/8715#issuecomment-632871693 Hi @gnkoshelev, That's a fair point. It's odd that `AdminOperationException` was chosen there, and appears to go back to 2014, if not earlier. Be sure to update `core/src/

[GitHub] [kafka] vvcephei commented on a change in pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

vvcephei commented on a change in pull request #8716: URL: https://github.com/apache/kafka/pull/8716#discussion_r429420017 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/TaskAssignorIntegrationTest.java ## @@ -0,0 +1,94 @@ +package org.apache.kafka.st

[jira] [Commented] (KAFKA-10005) Decouple RestoreListener from RestoreCallback and not enable bulk loading for RocksDB

[ https://issues.apache.org/jira/browse/KAFKA-10005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114342#comment-17114342 ] Guozhang Wang commented on KAFKA-10005: --- Here's a rough idea to replace the bulk l

[GitHub] [kafka] gnkoshelev commented on pull request #8715: KAFKA-10033: AdminClient should throw UnknownTopicOrPartitionException instead of UnknownServerException if altering configs of non-existin

gnkoshelev commented on pull request #8715: URL: https://github.com/apache/kafka/pull/8715#issuecomment-632864284 Hi @bdbyrne, If so what do you say to ``` def validateTopicCreate(topic: String, partitionReplicaAssignment: Map[Int, Seq[Int]],

[GitHub] [kafka] vvcephei commented on a change in pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

vvcephei commented on a change in pull request #8716: URL: https://github.com/apache/kafka/pull/8716#discussion_r429352661 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java ## @@ -359,6 +359,10 @@ private Ass

[GitHub] [kafka] hachikuji merged pull request #8702: MINOR: Fix join group request timeout lower bound

hachikuji merged pull request #8702: URL: https://github.com/apache/kafka/pull/8702 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] rhauch commented on pull request #8663: KAFKA-9985: Sink connector may exhaust broker when writing in DLQ

rhauch commented on pull request #8663: URL: https://github.com/apache/kafka/pull/8663#issuecomment-632857353 Build failure: ``` 12:46:00 /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk8-scala2.12/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SinkConnectorConfi

[GitHub] [kafka] abbccdda commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

abbccdda commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r429404004 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -27,10 +27,12 @@ import org.apache.kafka.clients.admin.DescribeConsumerGroupsOpti

[GitHub] [kafka] vvcephei commented on pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

vvcephei commented on pull request #8716: URL: https://github.com/apache/kafka/pull/8716#issuecomment-632850480 Previously, it would always fail for me within the first one to three tests, the first one more often than not.

[GitHub] [kafka] vvcephei commented on pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

vvcephei commented on pull request #8716: URL: https://github.com/apache/kafka/pull/8716#issuecomment-632849774 FWIW: ``` SESSION REPORT (ALL TESTS) ducktape version: 0.7.7 session_id: 2020

[GitHub] [kafka] mjsax merged pull request #8710: MINOR: Improve security documentation for Kafka Streams

mjsax merged pull request #8710: URL: https://github.com/apache/kafka/pull/8710 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #8710: MINOR: Improve security documentation for Kafka Streams

mjsax commented on pull request #8710: URL: https://github.com/apache/kafka/pull/8710#issuecomment-632847305 Thanks for the PR @JimGalasyn! Merged to `trunk`. This is an automated message from the Apache Git Service. To respo

[GitHub] [kafka] ableegoldman commented on a change in pull request #8697: [WIP] KAFKA-9983: KIP-613, add task-level e2e latency metrics (min and max)

ableegoldman commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r429396524 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -137,6 +138,7 @@ public StreamTask(final TaskId

[GitHub] [kafka] rhauch opened a new pull request #8719: [WIP] MINOR: Improve failure message in Kafka cluster used in Connect integration tests (pre Gradle memory change)

rhauch opened a new pull request #8719: URL: https://github.com/apache/kafka/pull/8719 DO NOT MERGE Debugging build failures See #8718 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] rhauch opened a new pull request #8718: [WIP] MINOR: Improve failure message in Kafka cluster used in Connect integration tests

rhauch opened a new pull request #8718: URL: https://github.com/apache/kafka/pull/8718 DO NOT MERGE Debugging build failures This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Commented] (KAFKA-7500) MirrorMaker 2.0 (KIP-382)

[ https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114309#comment-17114309 ] Ryanne Dolan commented on KAFKA-7500: - [~qq619618919] I usually recommend using a loa

[jira] [Commented] (KAFKA-9168) Integrate JNI direct buffer support to RocksDBStore

[ https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114291#comment-17114291 ] Guozhang Wang commented on KAFKA-9168: -- Just add a reference that this feature is on

[jira] [Assigned] (KAFKA-10005) Decouple RestoreListener from RestoreCallback and not enable bulk loading for RocksDB

[ https://issues.apache.org/jira/browse/KAFKA-10005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reassigned KAFKA-10005: - Assignee: (was: Guozhang Wang) > Decouple RestoreListener from RestoreCallback and

[GitHub] [kafka] rhauch commented on pull request #8630: KAFKA-9969: Exclude ConnectorClientConfigRequest from class loading isolation

rhauch commented on pull request #8630: URL: https://github.com/apache/kafka/pull/8630#issuecomment-632824360 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] rhauch commented on pull request #8630: KAFKA-9969: Exclude ConnectorClientConfigRequest from class loading isolation

rhauch commented on pull request #8630: URL: https://github.com/apache/kafka/pull/8630#issuecomment-632824461 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

  1   2   >