[GitHub] [kafka] kkonstantine commented on pull request #8654: KAFKA-9931: Implement KIP-605 to expand support for Connect worker internal topic configurations

2020-05-20 Thread GitBox
kkonstantine commented on pull request #8654: URL: https://github.com/apache/kafka/pull/8654#issuecomment-631879517 retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] kkonstantine commented on a change in pull request #8654: KAFKA-9931: Implement KIP-605 to expand support for Connect worker internal topic configurations

2020-05-20 Thread GitBox
kkonstantine commented on a change in pull request #8654: URL: https://github.com/apache/kafka/pull/8654#discussion_r428443080 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/InternalTopicsIntegrationTest.java ## @@ -0,0 +1,187 @@ +/* + * Licen

[GitHub] [kafka] cmccabe opened a new pull request #8703: MINOR: add a getOrCreate function to KRPC collections

2020-05-20 Thread GitBox
cmccabe opened a new pull request #8703: URL: https://github.com/apache/kafka/pull/8703 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] pgwhalen commented on pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-20 Thread GitBox
pgwhalen commented on pull request #6824: URL: https://github.com/apache/kafka/pull/6824#issuecomment-631873644 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] abbccdda commented on a change in pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-05-20 Thread GitBox
abbccdda commented on a change in pull request #8680: URL: https://github.com/apache/kafka/pull/8680#discussion_r428370254 ## File path: clients/src/main/java/org/apache/kafka/common/feature/BaseVersionRange.java ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [kafka] ijuma merged pull request #8472: KAFKA-9855 - return cached Structs for Schemas with no fields

2020-05-20 Thread GitBox
ijuma merged pull request #8472: URL: https://github.com/apache/kafka/pull/8472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #8472: KAFKA-9855 - return cached Structs for Schemas with no fields

2020-05-20 Thread GitBox
ijuma commented on pull request #8472: URL: https://github.com/apache/kafka/pull/8472#issuecomment-631870599 I have a WIP PR that removes structs altogether, but this is a good improvement in the meantime. Merging to trunk. Thanks. -

[jira] [Updated] (KAFKA-9950) MirrorMaker2 sharing of ConfigDef can lead to ConcurrentModificationException

2020-05-20 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9950: -- Fix Version/s: 2.5.1 2.4.2 2.6.0 > Mirror

[jira] [Resolved] (KAFKA-9950) MirrorMaker2 sharing of ConfigDef can lead to ConcurrentModificationException

2020-05-20 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-9950. --- Resolution: Fixed > MirrorMaker2 sharing of ConfigDef can lead to ConcurrentM

[GitHub] [kafka] kkonstantine commented on pull request #8511: KAFKA-9888: Copy connector configs before passing to REST extensions

2020-05-20 Thread GitBox
kkonstantine commented on pull request #8511: URL: https://github.com/apache/kafka/pull/8511#issuecomment-631869695 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] kkonstantine commented on a change in pull request #8511: KAFKA-9888: Copy connector configs before passing to REST extensions

2020-05-20 Thread GitBox
kkonstantine commented on a change in pull request #8511: URL: https://github.com/apache/kafka/pull/8511#discussion_r428436342 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/health/ConnectClusterStateImpl.java ## @@ -86,7 +86,7 @@ public Connector

[GitHub] [kafka] kkonstantine commented on pull request #8444: KAFKA-8869: Remove task configs for deleted connectors from config snapshot

2020-05-20 Thread GitBox
kkonstantine commented on pull request #8444: URL: https://github.com/apache/kafka/pull/8444#issuecomment-631868755 Merged to `trunk` and backported to `2.5`, `2.4` and `2.3` This is an automated message from the Apache Git S

[GitHub] [kafka] kkonstantine merged pull request #8608: KAFKA-9950: Construct new ConfigDef for MirrorTaskConfig before defining new properties

2020-05-20 Thread GitBox
kkonstantine merged pull request #8608: URL: https://github.com/apache/kafka/pull/8608 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] kkonstantine commented on pull request #8608: KAFKA-9950: Construct new ConfigDef for MirrorTaskConfig before defining new properties

2020-05-20 Thread GitBox
kkonstantine commented on pull request #8608: URL: https://github.com/apache/kafka/pull/8608#issuecomment-631867826 jdk8: single failure on known flaky test: `org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]` jdk11: single failur

[GitHub] [kafka] kkonstantine commented on pull request #8118: KAFKA-9472: Remove deleted tasks from status store

2020-05-20 Thread GitBox
kkonstantine commented on pull request #8118: URL: https://github.com/apache/kafka/pull/8118#issuecomment-631867151 retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Updated] (KAFKA-8869) Map taskConfigs in KafkaConfigBackingStore grows monotonically despite of task removals

2020-05-20 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-8869: -- Fix Version/s: 2.5.1 2.4.2 2.3.2 > Map ta

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-20 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r428433779 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -109,7 +94,7 @@ public void logChange

[jira] [Resolved] (KAFKA-8869) Map taskConfigs in KafkaConfigBackingStore grows monotonically despite of task removals

2020-05-20 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-8869. --- Resolution: Fixed > Map taskConfigs in KafkaConfigBackingStore grows monotoni

[jira] [Updated] (KAFKA-9472) Reducing number of tasks for connector causes deleted tasks to show as UNASSIGNED

2020-05-20 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9472: -- Fix Version/s: 2.5.1 2.4.2 2.6.0

[GitHub] [kafka] radai-rosenblatt commented on pull request #8472: KAFKA-9855 - return cached Structs for Schemas with no fields

2020-05-20 Thread GitBox
radai-rosenblatt commented on pull request #8472: URL: https://github.com/apache/kafka/pull/8472#issuecomment-631866599 @ijuma - any more modifications required? This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] radai-rosenblatt commented on pull request #8193: be helpful when throwing ConcurrentModificationException out of consumers

2020-05-20 Thread GitBox
radai-rosenblatt commented on pull request #8193: URL: https://github.com/apache/kafka/pull/8193#issuecomment-631866532 @ijuma - any further modifications required? This is an automated message from the Apache Git Service. To

[GitHub] [kafka] kkonstantine merged pull request #8444: KAFKA-8869: Remove task configs for deleted connectors from config snapshot

2020-05-20 Thread GitBox
kkonstantine merged pull request #8444: URL: https://github.com/apache/kafka/pull/8444 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] pgwhalen commented on a change in pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-20 Thread GitBox
pgwhalen commented on a change in pull request #6824: URL: https://github.com/apache/kafka/pull/6824#discussion_r428422376 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java ## @@ -953,7 +977,7 @@ void to(final TopicNameExtractor topicExtractor,

[GitHub] [kafka] apovzner edited a comment on pull request #8650: MINOR: Added unit tests for ConnectionQuotas

2020-05-20 Thread GitBox
apovzner edited a comment on pull request #8650: URL: https://github.com/apache/kafka/pull/8650#issuecomment-631853083 JDK 14 build has an unrelated test failure: org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false] It looks lik

[GitHub] [kafka] apovzner commented on pull request #8650: MINOR: Added unit tests for ConnectionQuotas

2020-05-20 Thread GitBox
apovzner commented on pull request #8650: URL: https://github.com/apache/kafka/pull/8650#issuecomment-631853083 JDK build has an unrelated test failure: org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false] It looks like tests pa

[GitHub] [kafka] kkonstantine commented on pull request #8444: KAFKA-8869: Remove task configs for deleted connectors from config snapshot

2020-05-20 Thread GitBox
kkonstantine commented on pull request #8444: URL: https://github.com/apache/kafka/pull/8444#issuecomment-631852881 jdk8: success jdk11: success jdk14: single failure on known flaky test: `org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEo

[jira] [Resolved] (KAFKA-9409) Increase Immutability of ClusterConfigState

2020-05-20 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-9409. --- Resolution: Fixed > Increase Immutability of ClusterConfigState > ---

[jira] [Updated] (KAFKA-9409) Increase Immutability of ClusterConfigState

2020-05-20 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9409: -- Fix Version/s: 2.6.0 > Increase Immutability of ClusterConfigState > --

[GitHub] [kafka] kkonstantine merged pull request #7942: KAFKA-9409: Supplement immutability of ClusterConfigState class in Connect

2020-05-20 Thread GitBox
kkonstantine merged pull request #7942: URL: https://github.com/apache/kafka/pull/7942 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] hachikuji commented on pull request #8702: MINOR: Fix join group request timeout lower bound

2020-05-20 Thread GitBox
hachikuji commented on pull request #8702: URL: https://github.com/apache/kafka/pull/8702#issuecomment-631849729 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] kkonstantine commented on pull request #7942: KAFKA-9409: Increase Immutability of ClusterConfigState

2020-05-20 Thread GitBox
kkonstantine commented on pull request #7942: URL: https://github.com/apache/kafka/pull/7942#issuecomment-631849532 jdk8: 1 flaky failure: `EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]` jdk11: didn't start jdk14: success ---

[jira] [Commented] (KAFKA-7500) MirrorMaker 2.0 (KIP-382)

2020-05-20 Thread victor (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112732#comment-17112732 ] victor commented on KAFKA-7500: --- [~ryannedolan] I have two distinct kafka clusters located

[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-20 Thread GitBox
guozhangwang commented on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-631837772 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-20 Thread GitBox
guozhangwang commented on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-631837548 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] omkreddy merged pull request #8700: MINOR: Increase gradle daemon’s heap size to 2g

2020-05-20 Thread GitBox
omkreddy merged pull request #8700: URL: https://github.com/apache/kafka/pull/8700 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] omkreddy commented on pull request #8700: MINOR: Increase gradle daemon’s heap size to 2g

2020-05-20 Thread GitBox
omkreddy commented on pull request #8700: URL: https://github.com/apache/kafka/pull/8700#issuecomment-631829621 Merging as test failures are not related, This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] hachikuji commented on a change in pull request #8702: MINOR: Fix join group request timeout lower bound

2020-05-20 Thread GitBox
hachikuji commented on a change in pull request #8702: URL: https://github.com/apache/kafka/pull/8702#discussion_r428389929 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -565,8 +566,8 @@ private void recordRebala

[jira] [Commented] (KAFKA-9981) Running a dedicated mm2 cluster with more than one nodes,When the configuration is updated the task is not aware and will lose the update operation.

2020-05-20 Thread victor (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112690#comment-17112690 ] victor commented on KAFKA-9981: --- [~ChrisEgerton] mm2 has realized data backup. How does kaf

[GitHub] [kafka] hachikuji opened a new pull request #8702: MINOR: Fix join group request timeout lower bound

2020-05-20 Thread GitBox
hachikuji opened a new pull request #8702: URL: https://github.com/apache/kafka/pull/8702 If the request timeout is larger than the rebalance timeout, we should use the former as the JoinGroup request timeout. ### Committer Checklist (excluded from commit message) - [ ] Verify des

[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-20 Thread GitBox
guozhangwang commented on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-631810146 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] mjsax commented on pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-20 Thread GitBox
mjsax commented on pull request #8679: URL: https://github.com/apache/kafka/pull/8679#issuecomment-631809507 Added the test. Will merge after Jenkins passed. This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] mjsax commented on pull request #8650: MINOR: Added unit tests for ConnectionQuotas

2020-05-20 Thread GitBox
mjsax commented on pull request #8650: URL: https://github.com/apache/kafka/pull/8650#issuecomment-631804240 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8650: MINOR: Added unit tests for ConnectionQuotas

2020-05-20 Thread GitBox
mjsax commented on pull request #8650: URL: https://github.com/apache/kafka/pull/8650#issuecomment-631804131 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] mjsax commented on pull request #8637: KAFKA-9976: Reuse repartition node in all cases for KGroupedStream and KGroupedTable aggregates

2020-05-20 Thread GitBox
mjsax commented on pull request #8637: URL: https://github.com/apache/kafka/pull/8637#issuecomment-631803677 Seems you agree to my last comment: https://github.com/apache/kafka/pull/8504#issuecomment-631757206 I think it's best to close this PR and also the ticker (either as "not a

[GitHub] [kafka] mjsax commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-20 Thread GitBox
mjsax commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r428376734 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java ## @@ -77,6 +79,38 @@ public void shouldLogAndMet

[GitHub] [kafka] mjsax commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-20 Thread GitBox
mjsax commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r424060697 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java ## @@ -77,6 +79,38 @@ public void shouldLogAndMet

[GitHub] [kafka] mjsax commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-20 Thread GitBox
mjsax commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r424060697 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java ## @@ -77,6 +79,38 @@ public void shouldLogAndMet

[jira] [Resolved] (KAFKA-1056) Evenly Distribute Intervals in OffsetIndex

2020-05-20 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-1056. -- Resolution: Fixed > Evenly Distribute Intervals in OffsetIndex > --

[jira] [Commented] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

2020-05-20 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112676#comment-17112676 ] Matthias J. Sax commented on KAFKA-6520: The consumer only stores/caches the last

[GitHub] [kafka] hachikuji commented on pull request #8701: MINOR: Add reason to log message when incrementing the log start offset

2020-05-20 Thread GitBox
hachikuji commented on pull request #8701: URL: https://github.com/apache/kafka/pull/8701#issuecomment-631789824 Need to fix some of the uses in test cases. Debating whether I should create an enum for the reason and get rid of the overload... -

[GitHub] [kafka] omkreddy commented on pull request #8700: MINOR: Increase gradle daemon’s heap size to 2g

2020-05-20 Thread GitBox
omkreddy commented on pull request #8700: URL: https://github.com/apache/kafka/pull/8700#issuecomment-631785818 retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] hachikuji opened a new pull request #8701: MINOR: Add reason to log message when incrementing the log start offset

2020-05-20 Thread GitBox
hachikuji opened a new pull request #8701: URL: https://github.com/apache/kafka/pull/8701 Sometimes logging leaves us guessing at the cause of an increment to the log start offset. Since this results in deletion of user data, I think the logging should be clear about the reason. ###

[GitHub] [kafka] xvrl commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xvrl commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428352951 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -270,9 +272,15 @@ Duration adminTimeout() { L

[GitHub] [kafka] xvrl commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xvrl commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428351889 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -270,9 +272,15 @@ Duration adminTimeout() { L

[GitHub] [kafka] C0urante commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-20 Thread GitBox
C0urante commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r428333743 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/predicates/RecordIsTombstone.java ## @@ -0,0 +1,48 @@ +/* + * Licensed

[GitHub] [kafka] rhauch commented on pull request #8654: KAFKA-9931: Implement KIP-605 to expand support for Connect worker internal topic configurations

2020-05-20 Thread GitBox
rhauch commented on pull request #8654: URL: https://github.com/apache/kafka/pull/8654#issuecomment-631762530 Thanks for the review, @kkonstantine. I think I've incorporated all of your suggestions. This is an automated mess

[GitHub] [kafka] rhauch commented on pull request #8654: KAFKA-9931: Implement KIP-605 to expand support for Connect worker internal topic configurations

2020-05-20 Thread GitBox
rhauch commented on pull request #8654: URL: https://github.com/apache/kafka/pull/8654#issuecomment-631762616 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] bbejeck commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-20 Thread GitBox
bbejeck commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r428343055 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java ## @@ -77,6 +79,38 @@ public void shouldLogAndM

[GitHub] [kafka] bbejeck commented on pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-20 Thread GitBox
bbejeck commented on pull request #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-631757206 > @bbejeck Are the any backward compatibility concerns for KAFKA-9976 ? Good point, maybe we should just leave this one alone for now. If you agree I'll close that PR. --

[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-20 Thread GitBox
guozhangwang commented on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-631755813 There are known flaky tests that may fail, I'm validating that there's no consistent test failures. @xinzhuxiansheng ---

[GitHub] [kafka] guozhangwang merged pull request #8661: KAFKA-9603: Do not turn on bulk loading for segmented stores on stand-by tasks

2020-05-20 Thread GitBox
guozhangwang merged pull request #8661: URL: https://github.com/apache/kafka/pull/8661 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (KAFKA-9878) Block AddPartitionsToTxn call until the txn markers are committed

2020-05-20 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-9878: --- Description: Currently the EndTxn call from Producer will immediately return as the control record i

[GitHub] [kafka] rhauch commented on a change in pull request #8654: KAFKA-9931: Implement KIP-605 to expand support for Connect worker internal topic configurations

2020-05-20 Thread GitBox
rhauch commented on a change in pull request #8654: URL: https://github.com/apache/kafka/pull/8654#discussion_r428333268 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/InternalTopicsIntegrationTest.java ## @@ -0,0 +1,187 @@ +/* + * Licensed to

[GitHub] [kafka] rhauch commented on a change in pull request #8654: KAFKA-9931: Implement KIP-605 to expand support for Connect worker internal topic configurations

2020-05-20 Thread GitBox
rhauch commented on a change in pull request #8654: URL: https://github.com/apache/kafka/pull/8654#discussion_r428334196 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/InternalTopicsIntegrationTest.java ## @@ -0,0 +1,187 @@ +/* + * Licensed to

[GitHub] [kafka] rhauch commented on a change in pull request #8654: KAFKA-9931: Implement KIP-605 to expand support for Connect worker internal topic configurations

2020-05-20 Thread GitBox
rhauch commented on a change in pull request #8654: URL: https://github.com/apache/kafka/pull/8654#discussion_r428333268 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/InternalTopicsIntegrationTest.java ## @@ -0,0 +1,187 @@ +/* + * Licensed to

[GitHub] [kafka] rhauch commented on pull request #8270: KAFKA-9216: Enforce connect internal topic configuration at startup

2020-05-20 Thread GitBox
rhauch commented on pull request #8270: URL: https://github.com/apache/kafka/pull/8270#issuecomment-631747698 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-20 Thread GitBox
guozhangwang commented on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-631738575 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] guozhangwang commented on pull request #8661: KAFKA-9603: Do not turn on bulk loading for segmented stores on stand-by tasks

2020-05-20 Thread GitBox
guozhangwang commented on pull request #8661: URL: https://github.com/apache/kafka/pull/8661#issuecomment-631737855 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] guozhangwang commented on pull request #8661: KAFKA-9603: Do not turn on bulk loading for segmented stores on stand-by tasks

2020-05-20 Thread GitBox
guozhangwang commented on pull request #8661: URL: https://github.com/apache/kafka/pull/8661#issuecomment-631738264 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] guozhangwang commented on pull request #8661: KAFKA-9603: Do not turn on bulk loading for segmented stores on stand-by tasks

2020-05-20 Thread GitBox
guozhangwang commented on pull request #8661: URL: https://github.com/apache/kafka/pull/8661#issuecomment-631737464 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] apovzner commented on pull request #8650: MINOR: Added unit tests for ConnectionQuotas

2020-05-20 Thread GitBox
apovzner commented on pull request #8650: URL: https://github.com/apache/kafka/pull/8650#issuecomment-631702750 One of the build failures failed due to one of the unit tests added in this PR. It was bug in the test, that was waiting on the wrong future, which had a name similar to another

[GitHub] [kafka] tombentley commented on pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-20 Thread GitBox
tombentley commented on pull request #8699: URL: https://github.com/apache/kafka/pull/8699#issuecomment-631683003 @C0urante you might also want to take a look. This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] C0urante commented on pull request #8357: KAFKA-9767: Add logging to basic auth rest extension

2020-05-20 Thread GitBox
C0urante commented on pull request #8357: URL: https://github.com/apache/kafka/pull/8357#issuecomment-631682508 Thanks @rhauch; I've added the requested unit test. This is ready for another round when you have time This is a

[GitHub] [kafka] C0urante commented on a change in pull request #8357: KAFKA-9767: Add logging to basic auth rest extension

2020-05-20 Thread GitBox
C0urante commented on a change in pull request #8357: URL: https://github.com/apache/kafka/pull/8357#discussion_r428260801 ## File path: connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java ## @@ -67,36 +87,60 @

[GitHub] [kafka] C0urante commented on a change in pull request #8357: KAFKA-9767: Add logging to basic auth rest extension

2020-05-20 Thread GitBox
C0urante commented on a change in pull request #8357: URL: https://github.com/apache/kafka/pull/8357#discussion_r428260448 ## File path: connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java ## @@ -67,36 +87,60 @

[GitHub] [kafka] omkreddy commented on pull request #8700: MINOR: Increase gradle daemon’s heap size to 2g

2020-05-20 Thread GitBox
omkreddy commented on pull request #8700: URL: https://github.com/apache/kafka/pull/8700#issuecomment-631677805 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428255598 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java ## @@ -233,17 +233,18 @@ private void addHerder(SourceAndTar

[jira] [Commented] (KAFKA-9987) Improve sticky partition assignor algorithm

2020-05-20 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112535#comment-17112535 ] Sophie Blee-Goldman commented on KAFKA-9987: [~hai_lin] I put this on pause t

[GitHub] [kafka] tombentley commented on pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-20 Thread GitBox
tombentley commented on pull request #8699: URL: https://github.com/apache/kafka/pull/8699#issuecomment-631651186 Still need to review test coverage, but @kkonstantine, @mimaison, @bbejeck you might want to give it an initial pass. -

[GitHub] [kafka] tombentley opened a new pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-20 Thread GitBox
tombentley opened a new pull request #8699: URL: https://github.com/apache/kafka/pull/8699 * Add Predicate interface * Add Filter SMT * Add the predicate implementations defined in the KIP. * Create abstraction in ConnectorConfig for configuring Transformations and Connectors with

[GitHub] [kafka] omkreddy opened a new pull request #8700: MINOR: Increase gradle daemon’s heap size to 2g

2020-05-20 Thread GitBox
omkreddy opened a new pull request #8700: URL: https://github.com/apache/kafka/pull/8700 We have seen out of memory error in builds. This PR is to increase the gradle heap memory to 2g. ``` [Error] : Error while emitting kafka/log/LogTest [2020-05-20T11:33:15.133Z] GC overhead

[jira] [Commented] (KAFKA-8159) Built-in serdes for signed numbers do not obey lexicographical ordering

2020-05-20 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112511#comment-17112511 ] Guozhang Wang commented on KAFKA-8159: -- Hey John, What I was asking is actually bey

[jira] [Comment Edited] (KAFKA-4084) automated leader rebalance causes replication downtime for clusters with too many partitions

2020-05-20 Thread Hai Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112508#comment-17112508 ] Hai Lin edited comment on KAFKA-4084 at 5/20/20, 6:18 PM: -- Thank

[jira] [Comment Edited] (KAFKA-4084) automated leader rebalance causes replication downtime for clusters with too many partitions

2020-05-20 Thread Hai Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112508#comment-17112508 ] Hai Lin edited comment on KAFKA-4084 at 5/20/20, 6:18 PM: -- Thank

[jira] [Commented] (KAFKA-4084) automated leader rebalance causes replication downtime for clusters with too many partitions

2020-05-20 Thread Hai Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112508#comment-17112508 ] Hai Lin commented on KAFKA-4084: Thanks [~sql_consulting] point me to this ticket. [~junr

[GitHub] [kafka] C0urante commented on pull request #8511: KAFKA-9888: Copy connector configs before passing to REST extensions

2020-05-20 Thread GitBox
C0urante commented on pull request #8511: URL: https://github.com/apache/kafka/pull/8511#issuecomment-631633951 Thanks @kkonstantine, I've addressed both of your comments. Ready for another round when you have time. This is

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428205238 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -92,6 +93,7 @@ private final ExecutorService executo

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428203784 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -92,6 +93,7 @@ private final ExecutorService executo

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428203600 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectStandalone.java ## @@ -93,7 +93,7 @@ public static void main(String[] ar

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428203369 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java ## @@ -101,24 +101,25 @@ public Connect startConnect(Ma

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428203009 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java ## @@ -101,24 +101,25 @@ public Connect startConnect(Ma

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428202532 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java ## @@ -101,24 +101,25 @@ public Connect startConnect(Ma

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428202742 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java ## @@ -101,24 +101,25 @@ public Connect startConnect(Ma

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428202270 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java ## @@ -233,17 +233,18 @@ private void addHerder(SourceAndTar

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428202016 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java ## @@ -233,17 +233,18 @@ private void addHerder(SourceAndTar

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428201738 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java ## @@ -233,17 +233,18 @@ private void addHerder(SourceAndTar

[jira] [Resolved] (KAFKA-9859) kafka-streams-application-reset tool doesn't take into account topics generated by KTable foreign key join operation

2020-05-20 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Levani Kokhreidze resolved KAFKA-9859. -- Fix Version/s: 2.6.0 Resolution: Fixed fixed with PR [https://github.com/apache/

[jira] [Commented] (KAFKA-9899) LogCleaner Tries To Clean Single Partition Over 1000x/Minute

2020-05-20 Thread Jeff Nadler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112460#comment-17112460 ] Jeff Nadler commented on KAFKA-9899: upgraded to 2.5.0, still experiencing this issue

[GitHub] [kafka] nizhikov commented on pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
nizhikov commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-631614084 @ijuma I can't see downside in forcing usage of the latest TLS version. Added this change to PR. This is an au

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r428173640 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +622,34 @@ public void testUnsupportedTLSVersi

  1   2   >