[GitHub] [kafka] kkonstantine merged pull request #8693: MINOR: Fix redundant typos in comments and javadocs

2020-05-19 Thread GitBox
kkonstantine merged pull request #8693: URL: https://github.com/apache/kafka/pull/8693 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] kkonstantine commented on pull request #7942: KAFKA-9409: Increase Immutability of ClusterConfigState

2020-05-19 Thread GitBox
kkonstantine commented on pull request #7942: URL: https://github.com/apache/kafka/pull/7942#issuecomment-631268323 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] kkonstantine commented on pull request #8118: KAFKA-9472: Remove deleted tasks from status store

2020-05-19 Thread GitBox
kkonstantine commented on pull request #8118: URL: https://github.com/apache/kafka/pull/8118#issuecomment-631264425 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] kkonstantine commented on pull request #8135: KAFKA-9570: Define SSL configs in all worker config classes, not just distributed

2020-05-19 Thread GitBox
kkonstantine commented on pull request #8135: URL: https://github.com/apache/kafka/pull/8135#issuecomment-631262289 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] kkonstantine commented on pull request #8444: KAFKA-8869: Remove task configs for deleted connectors from config snapshot

2020-05-19 Thread GitBox
kkonstantine commented on pull request #8444: URL: https://github.com/apache/kafka/pull/8444#issuecomment-631261878 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] kkonstantine commented on a change in pull request #8511: KAFKA-9888: Copy connector configs before passing to REST extensions

2020-05-19 Thread GitBox
kkonstantine commented on a change in pull request #8511: URL: https://github.com/apache/kafka/pull/8511#discussion_r427761810 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java ## @@ -280,8 +280,8 @@ public void stop() {

[GitHub] [kafka] kkonstantine commented on pull request #8608: KAFKA-9950: Construct new ConfigDef for MirrorTaskConfig before defining new properties

2020-05-19 Thread GitBox
kkonstantine commented on pull request #8608: URL: https://github.com/apache/kafka/pull/8608#issuecomment-631254109 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] mjsax commented on a change in pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-19 Thread GitBox
mjsax commented on a change in pull request #8679: URL: https://github.com/apache/kafka/pull/8679#discussion_r427752328 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/graph/StreamsGraphTest.java ## @@ -254,6 +253,7 @@ private Topology getTopolo

[GitHub] [kafka] ableegoldman opened a new pull request #8697: KAFKA-9983: KIP-613, add task-level e2e latency metrics (min and max)

2020-05-19 Thread GitBox
ableegoldman opened a new pull request #8697: URL: https://github.com/apache/kafka/pull/8697 Kicking this off with just the min and max sensors for the INFO-level task metrics. There is an existing `Percentiles` sensor implementation, but I'm having trouble convincing myself that it

[GitHub] [kafka] ableegoldman commented on pull request #8697: KAFKA-9983: KIP-613, add task-level e2e latency metrics (min and max)

2020-05-19 Thread GitBox
ableegoldman commented on pull request #8697: URL: https://github.com/apache/kafka/pull/8697#issuecomment-631225868 call for review @guozhangwang @mjsax @vvcephei This is an automated message from the Apache Git Service. To

[GitHub] [kafka] chia7712 commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-05-19 Thread GitBox
chia7712 commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r427723802 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -369,6 +369,31 @@ class GroupCoordinator(val brokerId: Int, }

[jira] [Comment Edited] (KAFKA-9982) [kafka-connect] Source connector does not guarantee at least once delivery

2020-05-19 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111563#comment-17111563 ] Chris Egerton edited comment on KAFKA-9982 at 5/20/20, 2:43 AM: ---

[jira] [Commented] (KAFKA-8159) Built-in serdes for signed numbers do not obey lexicographical ordering

2020-05-19 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111694#comment-17111694 ] John Roesler commented on KAFKA-8159: - Hi [~ableegoldman] , Thanks for pointing this

[GitHub] [kafka] hachikuji commented on pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-05-19 Thread GitBox
hachikuji commented on pull request #8311: URL: https://github.com/apache/kafka/pull/8311#issuecomment-631178938 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] mjsax commented on a change in pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-19 Thread GitBox
mjsax commented on a change in pull request #6824: URL: https://github.com/apache/kafka/pull/6824#discussion_r427675991 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java ## @@ -700,12 +703,29 @@ public void process(final ProcessorS

[GitHub] [kafka] mjsax commented on a change in pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-19 Thread GitBox
mjsax commented on a change in pull request #6824: URL: https://github.com/apache/kafka/pull/6824#discussion_r427675683 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java ## @@ -213,6 +215,48 @@ public void testDrivingSt

[GitHub] [kafka] mjsax commented on a change in pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-19 Thread GitBox
mjsax commented on a change in pull request #8679: URL: https://github.com/apache/kafka/pull/8679#discussion_r427674857 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/KStream.scala ## @@ -232,10 +232,53 @@ class KStream[K, V](val inne

[GitHub] [kafka] mjsax commented on pull request #8650: MINOR: Added unit tests for ConnectionQuotas

2020-05-19 Thread GitBox
mjsax commented on pull request #8650: URL: https://github.com/apache/kafka/pull/8650#issuecomment-631153303 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] gwenshap commented on pull request #8650: MINOR: Added unit tests for ConnectionQuotas

2020-05-19 Thread GitBox
gwenshap commented on pull request #8650: URL: https://github.com/apache/kafka/pull/8650#issuecomment-631127554 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-10021) When reading to the end of the config log, check if fetch.max.wait.ms is greater than worker.sync.timeout.ms

2020-05-19 Thread Arjun Satish (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111584#comment-17111584 ] Arjun Satish commented on KAFKA-10021: -- Thanks, [~hachikuji]! > When reading to th

[jira] [Issue Comment Deleted] (KAFKA-10021) When reading to the end of the config log, check if fetch.max.wait.ms is greater than worker.sync.timeout.ms

2020-05-19 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-10021: Comment: was deleted (was: [~wicknicks] Each consumer instance has a separate connection t

[jira] [Commented] (KAFKA-10021) When reading to the end of the config log, check if fetch.max.wait.ms is greater than worker.sync.timeout.ms

2020-05-19 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111581#comment-17111581 ] Jason Gustafson commented on KAFKA-10021: - [~wicknicks] Each consumer instance h

[jira] [Commented] (KAFKA-10021) When reading to the end of the config log, check if fetch.max.wait.ms is greater than worker.sync.timeout.ms

2020-05-19 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111580#comment-17111580 ] Jason Gustafson commented on KAFKA-10021: - [~wicknicks] Each consumer instance h

[GitHub] [kafka] pgwhalen commented on a change in pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-19 Thread GitBox
pgwhalen commented on a change in pull request #6824: URL: https://github.com/apache/kafka/pull/6824#discussion_r427629040 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java ## @@ -700,12 +703,29 @@ public void process(final Process

[GitHub] [kafka] pgwhalen commented on a change in pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-19 Thread GitBox
pgwhalen commented on a change in pull request #6824: URL: https://github.com/apache/kafka/pull/6824#discussion_r427628532 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java ## @@ -213,6 +215,48 @@ public void testDrivin

[GitHub] [kafka] guozhangwang merged pull request #8681: KAFKA-10010: Should make state store registration idempotent

2020-05-19 Thread GitBox
guozhangwang merged pull request #8681: URL: https://github.com/apache/kafka/pull/8681 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] vvcephei commented on a change in pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-19 Thread GitBox
vvcephei commented on a change in pull request #8679: URL: https://github.com/apache/kafka/pull/8679#discussion_r427623832 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/KStream.scala ## @@ -232,10 +232,53 @@ class KStream[K, V](val i

[jira] [Resolved] (KAFKA-9982) [kafka-connect] Source connector does not guarantee at least once delivery

2020-05-19 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-9982. -- Resolution: Not A Bug > [kafka-connect] Source connector does not guarantee at least once deliv

[jira] [Commented] (KAFKA-9982) [kafka-connect] Source connector does not guarantee at least once delivery

2020-05-19 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111563#comment-17111563 ] Chris Egerton commented on KAFKA-9982: -- [~q.xu] I'd like to mark this closed, but if

[GitHub] [kafka] vvcephei commented on a change in pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-19 Thread GitBox
vvcephei commented on a change in pull request #8679: URL: https://github.com/apache/kafka/pull/8679#discussion_r427621713 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/graph/StreamsGraphTest.java ## @@ -254,6 +253,7 @@ private Topology getTop

[GitHub] [kafka] vvcephei commented on a change in pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-19 Thread GitBox
vvcephei commented on a change in pull request #8679: URL: https://github.com/apache/kafka/pull/8679#discussion_r427621177 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java ## @@ -815,9 +815,10 @@ * * @param topic the topic name

[GitHub] [kafka] vvcephei commented on a change in pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-19 Thread GitBox
vvcephei commented on a change in pull request #8679: URL: https://github.com/apache/kafka/pull/8679#discussion_r427617788 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java ## @@ -484,8 +493,14 @@ private Topology setup

[GitHub] [kafka] vvcephei commented on a change in pull request #8696: KAFKA-6145: KIP-441: Enforce Standby Task Stickiness

2020-05-19 Thread GitBox
vvcephei commented on a change in pull request #8696: URL: https://github.com/apache/kafka/pull/8696#discussion_r427615915 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java ## @@ -338,7 +338,7 @@ privat

[GitHub] [kafka] vvcephei opened a new pull request #8696: KAFKA-6145: KIP-441: Enforce Standby Task Stickiness

2020-05-19 Thread GitBox
vvcephei opened a new pull request #8696: URL: https://github.com/apache/kafka/pull/8696 We should treat standbys similarly to active stateful tasks and re-assign them to instances that are already caught-up on them while we warm them up on the desired destination, instead of immedi

[GitHub] [kafka] mjsax commented on a change in pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-19 Thread GitBox
mjsax commented on a change in pull request #6824: URL: https://github.com/apache/kafka/pull/6824#discussion_r427605702 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java ## @@ -213,6 +215,48 @@ public void testDrivingSt

[GitHub] [kafka] mjsax commented on a change in pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-19 Thread GitBox
mjsax commented on a change in pull request #6824: URL: https://github.com/apache/kafka/pull/6824#discussion_r427603579 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java ## @@ -700,12 +703,29 @@ public void process(final ProcessorS

[GitHub] [kafka] guozhangwang merged pull request #8682: KAFKA-10011: Remove task id from lockedTaskDirectories during handleLostAll

2020-05-19 Thread GitBox
guozhangwang merged pull request #8682: URL: https://github.com/apache/kafka/pull/8682 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] mjsax commented on a change in pull request #8049: MINOR: Added missing default serdes to the streams.scala.Serdes

2020-05-19 Thread GitBox
mjsax commented on a change in pull request #8049: URL: https://github.com/apache/kafka/pull/8049#discussion_r427591063 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala ## @@ -30,12 +32,15 @@ object Serdes { implicit def JavaLon

[GitHub] [kafka] rnpridgeon commented on pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-19 Thread GitBox
rnpridgeon commented on pull request #8691: URL: https://github.com/apache/kafka/pull/8691#issuecomment-631074323 Since MetricsReporter instances are the ultimate consumers of the MetadataContext instance I would like to propose moving construction MetricsContext there. This would allow ea

[jira] [Updated] (KAFKA-10018) Change command line tool from /bin/sh to /bin/bash

2020-05-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10018: Summary: Change command line tool from /bin/sh to /bin/bash (was: Change sh to bash) >

[jira] [Updated] (KAFKA-10018) Change command line tools from /bin/sh to /bin/bash

2020-05-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10018: Summary: Change command line tools from /bin/sh to /bin/bash (was: Change command line

[GitHub] [kafka] ableegoldman commented on pull request #8682: KAFKA-10011: Remove task id from lockedTaskDirectories during handleLostAll

2020-05-19 Thread GitBox
ableegoldman commented on pull request #8682: URL: https://github.com/apache/kafka/pull/8682#issuecomment-631072710 Well, `releaseLockedUnassignedTaskDirectories` does exactly that -- it only releases the unassigned task directories (which we just lock in order to report the offset sums in

[GitHub] [kafka] guozhangwang commented on pull request #8682: KAFKA-10011: Remove task id from lockedTaskDirectories during handleLostAll

2020-05-19 Thread GitBox
guozhangwang commented on pull request #8682: URL: https://github.com/apache/kafka/pull/8682#issuecomment-631070764 > @guozhangwang Why would we warn? You mean if we have any tasks leftover? These are just tasks that are currently assigned I think we would only have leftover tasks if

[jira] [Updated] (KAFKA-9929) Support reverse iterator on WindowStore

2020-05-19 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya updated KAFKA-9929: Labels: needs-kip (was: ) > Support reverse iterator on WindowStor

[GitHub] [kafka] ableegoldman commented on pull request #8682: KAFKA-10011: Remove task id from lockedTaskDirectories during handleLostAll

2020-05-19 Thread GitBox
ableegoldman commented on pull request #8682: URL: https://github.com/apache/kafka/pull/8682#issuecomment-631068928 @guozhangwang Why would we warn? You mean if we have any tasks leftover? These are just tasks that are currently assigned ---

[GitHub] [kafka] guozhangwang commented on pull request #8682: KAFKA-10011: Remove task id from lockedTaskDirectories during handleLostAll

2020-05-19 Thread GitBox
guozhangwang commented on pull request #8682: URL: https://github.com/apache/kafka/pull/8682#issuecomment-631068405 I think it is still better to log a warn at the end of `releaseLockedUnassignedTaskDirectories` if the map is not empty at the end, will add it before merging.

[GitHub] [kafka] guozhangwang commented on pull request #8694: KAFKA-10022: console-producer supports the setting of client.id

2020-05-19 Thread GitBox
guozhangwang commented on pull request #8694: URL: https://github.com/apache/kafka/pull/8694#issuecomment-631065860 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] mjsax commented on a change in pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-19 Thread GitBox
mjsax commented on a change in pull request #8679: URL: https://github.com/apache/kafka/pull/8679#discussion_r427581563 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/graph/StreamsGraphTest.java ## @@ -254,6 +253,7 @@ private Topology getTopolo

[GitHub] [kafka] mjsax commented on a change in pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-19 Thread GitBox
mjsax commented on a change in pull request #8679: URL: https://github.com/apache/kafka/pull/8679#discussion_r427579474 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java ## @@ -815,9 +815,10 @@ * * @param topic the topic name *

[GitHub] [kafka] mjsax commented on a change in pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-19 Thread GitBox
mjsax commented on a change in pull request #8679: URL: https://github.com/apache/kafka/pull/8679#discussion_r427578311 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java ## @@ -484,8 +493,14 @@ private Topology setupTop

[GitHub] [kafka] mjsax commented on a change in pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-19 Thread GitBox
mjsax commented on a change in pull request #8679: URL: https://github.com/apache/kafka/pull/8679#discussion_r426211425 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java ## @@ -846,16 +847,13 @@ * from the auto-generated topic using default

[jira] [Commented] (KAFKA-10016) Support For Purge Topic

2020-05-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111501#comment-17111501 ] Matthias J. Sax commented on KAFKA-10016: - Ah sorry. Linked the wrong KIP. The f

[jira] [Commented] (KAFKA-10021) When reading to the end of the config log, check if fetch.max.wait.ms is greater than worker.sync.timeout.ms

2020-05-19 Thread Arjun Satish (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111493#comment-17111493 ] Arjun Satish commented on KAFKA-10021: -- [~hachikuji] [~skaundinya] do consumers in

[jira] [Commented] (KAFKA-4327) Move Reset Tool from core to streams

2020-05-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111489#comment-17111489 ] Matthias J. Sax commented on KAFKA-4327: Not 100% sure. It's all a little tricky.

[GitHub] [kafka] vvcephei commented on a change in pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-19 Thread GitBox
vvcephei commented on a change in pull request #8679: URL: https://github.com/apache/kafka/pull/8679#discussion_r427543403 ## File path: streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java ## @@ -285,7 +286,28 @@ public void shouldProcessViaThroughTopic() {

[GitHub] [kafka] rhauch commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-19 Thread GitBox
rhauch commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r426971298 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -270,9 +272,15 @@ Duration adminTimeout() {

[GitHub] [kafka] rhauch commented on pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-19 Thread GitBox
rhauch commented on pull request #8691: URL: https://github.com/apache/kafka/pull/8691#issuecomment-631035724 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] nizhikov opened a new pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-19 Thread GitBox
nizhikov opened a new pull request #8695: URL: https://github.com/apache/kafka/pull/8695 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[jira] [Updated] (KAFKA-9992) EmbeddedKafkaCluster.deleteTopicAndWait not working with kafka_2.13

2020-05-19 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-9992: Fix Version/s: 2.4.2 > EmbeddedKafkaCluster.deleteTopicAndWait not working with kafka_2.13 > --

[GitHub] [kafka] hachikuji commented on a change in pull request #8376: KAFKA-9724 Newer clients not always sending fetch request to older brokers

2020-05-19 Thread GitBox
hachikuji commented on a change in pull request #8376: URL: https://github.com/apache/kafka/pull/8376#discussion_r427535098 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -1098,8 +1098,20 @@ Node selectReadReplica(TopicPartit

[GitHub] [kafka] vvcephei commented on a change in pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-19 Thread GitBox
vvcephei commented on a change in pull request #8679: URL: https://github.com/apache/kafka/pull/8679#discussion_r426337376 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java ## @@ -846,16 +847,13 @@ * from the auto-generated topic using defa

[jira] [Commented] (KAFKA-9992) EmbeddedKafkaCluster.deleteTopicAndWait not working with kafka_2.13

2020-05-19 Thread Andras Katona (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111436#comment-17111436 ] Andras Katona commented on KAFKA-9992: -- Okay :) cool! > EmbeddedKafkaCluster.delete

[GitHub] [kafka] glasser commented on pull request #8692: KAFKA-10018:Change sh to bash

2020-05-19 Thread GitBox
glasser commented on pull request #8692: URL: https://github.com/apache/kafka/pull/8692#issuecomment-631018459 I don't know why my name was mentioned here. This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (KAFKA-9992) EmbeddedKafkaCluster.deleteTopicAndWait not working with kafka_2.13

2020-05-19 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111433#comment-17111433 ] John Roesler commented on KAFKA-9992: - No problem, [~akatona] ! Thanks again for the

[jira] [Updated] (KAFKA-9992) EmbeddedKafkaCluster.deleteTopicAndWait not working with kafka_2.13

2020-05-19 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-9992: Fix Version/s: 2.5.1 > EmbeddedKafkaCluster.deleteTopicAndWait not working with kafka_2.13 > --

[jira] [Commented] (KAFKA-8638) Preferred Leader Blacklist (deprioritized list)

2020-05-19 Thread Hai Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111427#comment-17111427 ] Hai Lin commented on KAFKA-8638: What's the current status is this kip? I see this will b

[jira] [Updated] (KAFKA-9992) EmbeddedKafkaCluster.deleteTopicAndWait not working with kafka_2.13

2020-05-19 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-9992: Fix Version/s: 2.6.0 > EmbeddedKafkaCluster.deleteTopicAndWait not working with kafka_2.13 > --

[GitHub] [kafka] vvcephei merged pull request #8673: KAFKA-9992: EmbeddedKafkaCluster.deleteTopicAndWait not working with kafka_2.13

2020-05-19 Thread GitBox
vvcephei merged pull request #8673: URL: https://github.com/apache/kafka/pull/8673 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #8673: KAFKA-9992: EmbeddedKafkaCluster.deleteTopicAndWait not working with kafka_2.13

2020-05-19 Thread GitBox
vvcephei commented on pull request #8673: URL: https://github.com/apache/kafka/pull/8673#issuecomment-631004738 The tests that failed are known to be flaky and seem unrelated to this change: org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlpha

[GitHub] [kafka] vvcephei commented on pull request #8689: KAFKA-6145: Add unit tests to verify fix of bug KAFKA-9173

2020-05-19 Thread GitBox
vvcephei commented on pull request #8689: URL: https://github.com/apache/kafka/pull/8689#issuecomment-631003896 Thanks, @cadonna ! This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] vvcephei merged pull request #8689: KAFKA-6145: Add unit tests to verify fix of bug KAFKA-9173

2020-05-19 Thread GitBox
vvcephei merged pull request #8689: URL: https://github.com/apache/kafka/pull/8689 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #8689: KAFKA-6145: Add unit tests to verify fix of bug KAFKA-9173

2020-05-19 Thread GitBox
vvcephei commented on pull request #8689: URL: https://github.com/apache/kafka/pull/8689#issuecomment-631002557 Test failures were unrelated: kafka.api.SaslPlaintextConsumerTest.testCoordinatorFailover and 3x: org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shou

[jira] [Commented] (KAFKA-10020) KIP-616: Rename implicit Serdes instances in kafka-streams-scala

2020-05-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111397#comment-17111397 ] Matthias J. Sax commented on KAFKA-10020: - [~lmnet] I added you to the list of c

[jira] [Updated] (KAFKA-10020) KIP-616: Rename implicit Serdes instances in kafka-streams-scala

2020-05-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10020: Labels: kip (was: ) > KIP-616: Rename implicit Serdes instances in kafka-streams-scala >

[jira] [Assigned] (KAFKA-10020) KIP-616: Rename implicit Serdes instances in kafka-streams-scala

2020-05-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-10020: --- Assignee: Yuriy Badalyantc > KIP-616: Rename implicit Serdes instances in kafka-str

[jira] [Commented] (KAFKA-9216) Enforce connect internal topic configuration at startup

2020-05-19 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111394#comment-17111394 ] Greg Harris commented on KAFKA-9216: I believe that KAFKA-5087 has an intent similar

[jira] [Commented] (KAFKA-10016) Support For Purge Topic

2020-05-19 Thread David Mollitor (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111393#comment-17111393 ] David Mollitor commented on KAFKA-10016: [~mjsax] looks like it was replaced wit

[jira] [Created] (KAFKA-10025) Segfault in RocksDB Statistics

2020-05-19 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10025: --- Summary: Segfault in RocksDB Statistics Key: KAFKA-10025 URL: https://issues.apache.org/jira/browse/KAFKA-10025 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-9987) Improve sticky partition assignor algorithm

2020-05-19 Thread Hai Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111361#comment-17111361 ] Hai Lin commented on KAFKA-9987: [~ableegoldman] do you think the pull request is ready t

[jira] [Commented] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

2020-05-19 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111343#comment-17111343 ] Boyang Chen commented on KAFKA-9891: Sorry I was oncall last week. Will take another

[jira] [Commented] (KAFKA-10021) When reading to the end of the config log, check if fetch.max.wait.ms is greater than worker.sync.timeout.ms

2020-05-19 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111338#comment-17111338 ] Jason Gustafson commented on KAFKA-10021: - For a little more detail, the problem

[jira] [Created] (KAFKA-10024) Add dynamic configuration and enforce quota for per-IP connection rate limits

2020-05-19 Thread Anna Povzner (Jira)
Anna Povzner created KAFKA-10024: Summary: Add dynamic configuration and enforce quota for per-IP connection rate limits Key: KAFKA-10024 URL: https://issues.apache.org/jira/browse/KAFKA-10024 Project

[GitHub] [kafka] chia7712 commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-05-19 Thread GitBox
chia7712 commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r427435780 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -369,6 +369,31 @@ class GroupCoordinator(val brokerId: Int, }

[jira] [Comment Edited] (KAFKA-9998) KafkaProducer.close(timeout) still may block indefinitely

2020-05-19 Thread radai rosenblatt (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111317#comment-17111317 ] radai rosenblatt edited comment on KAFKA-9998 at 5/19/20, 4:23 PM:

[jira] [Commented] (KAFKA-9998) KafkaProducer.close(timeout) still may block indefinitely

2020-05-19 Thread radai rosenblatt (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111317#comment-17111317 ] radai rosenblatt commented on KAFKA-9998: - i think thats wrong, for several reaso

[GitHub] [kafka] hachikuji commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-05-19 Thread GitBox
hachikuji commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r427432140 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -970,7 +970,16 @@ class Partition(val topicPartition: TopicPartition, } }

[GitHub] [kafka] hachikuji commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-05-19 Thread GitBox
hachikuji commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r427430032 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -369,6 +369,31 @@ class GroupCoordinator(val brokerId: Int, }

[GitHub] [kafka] abbccdda commented on pull request #8221: KAFKA-9561: update task input partitions after rebalance

2020-05-19 Thread GitBox
abbccdda commented on pull request #8221: URL: https://github.com/apache/kafka/pull/8221#issuecomment-630919038 @avalsa Hey there, just a reminder that we are one week away from the feature freeze, so let's try to ramp up and get this into 2.6, thank you for all the work so far!

[GitHub] [kafka] abbccdda commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-19 Thread GitBox
abbccdda commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-630918452 @feyman2016 Thanks for the context. I don't worry too much for comment vanish if you change the commit history, as they would not be gone but just show as `outdated` on github. J

[GitHub] [kafka] vvcephei commented on pull request #8689: KAFKA-6145: Add unit tests to verify fix of bug KAFKA-9173

2020-05-19 Thread GitBox
vvcephei commented on pull request #8689: URL: https://github.com/apache/kafka/pull/8689#issuecomment-630915857 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] vvcephei commented on pull request #8689: KAFKA-6145: Add unit tests to verify fix of bug KAFKA-9173

2020-05-19 Thread GitBox
vvcephei commented on pull request #8689: URL: https://github.com/apache/kafka/pull/8689#issuecomment-630915569 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8689: KAFKA-6145: Add unit tests to verify fix of bug KAFKA-9173

2020-05-19 Thread GitBox
vvcephei commented on pull request #8689: URL: https://github.com/apache/kafka/pull/8689#issuecomment-630915672 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Created] (KAFKA-10023) Enforce broker-wide and per-listener connection creation rate (KIP-612, part 1)

2020-05-19 Thread Anna Povzner (Jira)
Anna Povzner created KAFKA-10023: Summary: Enforce broker-wide and per-listener connection creation rate (KIP-612, part 1) Key: KAFKA-10023 URL: https://issues.apache.org/jira/browse/KAFKA-10023 Proje

[jira] [Updated] (KAFKA-9647) Add ability to suppress until window end (not close)

2020-05-19 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-9647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sören Henning updated KAFKA-9647: - Description: *Preface:* This feature request originates from a [recently asked question on Stack

[GitHub] [kafka] ocadaruma commented on pull request #8693: MINOR: Fix typo in RecordAccumulator

2020-05-19 Thread GitBox
ocadaruma commented on pull request #8693: URL: https://github.com/apache/kafka/pull/8693#issuecomment-630884243 Fixed similar typos in those files. Thanks. This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] bbejeck merged pull request #8622: MINOR: Update stream documentation

2020-05-19 Thread GitBox
bbejeck merged pull request #8622: URL: https://github.com/apache/kafka/pull/8622 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] bbejeck commented on pull request #8622: MINOR: Update stream documentation

2020-05-19 Thread GitBox
bbejeck commented on pull request #8622: URL: https://github.com/apache/kafka/pull/8622#issuecomment-630882502 Thanks @showuon for the contribution! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] bbejeck commented on pull request #8622: MINOR: Update stream documentation

2020-05-19 Thread GitBox
bbejeck commented on pull request #8622: URL: https://github.com/apache/kafka/pull/8622#issuecomment-630882690 Merged #8622 into trunk. This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] vvcephei commented on pull request #8673: KAFKA-9992: EmbeddedKafkaCluster.deleteTopicAndWait not working with kafka_2.13

2020-05-19 Thread GitBox
vvcephei commented on pull request #8673: URL: https://github.com/apache/kafka/pull/8673#issuecomment-630880668 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8673: KAFKA-9992: EmbeddedKafkaCluster.deleteTopicAndWait not working with kafka_2.13

2020-05-19 Thread GitBox
vvcephei commented on pull request #8673: URL: https://github.com/apache/kafka/pull/8673#issuecomment-630880367 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

  1   2   >